[INFO] fetching crate molconv 0.2.0... [INFO] linting molconv-0.2.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate molconv 0.2.0 into /workspace/builds/worker-3-tc1/source [INFO] started tweaking crates.io crate molconv 0.2.0 [INFO] finished tweaking crates.io crate molconv 0.2.0 [INFO] tweaked toml for crates.io crate molconv 0.2.0 written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate molconv 0.2.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate molconv 0.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded cfg-if v0.1.9 [INFO] [stderr] Downloaded redox_syscall v0.1.56 [INFO] [stderr] Downloaded wasi v0.7.0 [INFO] [stderr] Downloaded remove_dir_all v0.5.2 [INFO] [stderr] Downloaded lazy-init v0.3.0 [INFO] [stderr] Downloaded tempfile v3.1.0 [INFO] [stderr] Downloaded getrandom v0.1.12 [INFO] [stderr] Downloaded atty v0.2.13 [INFO] [stderr] Downloaded num_cpus v1.10.1 [INFO] [stderr] Downloaded failure_derive v0.1.6 [INFO] [stderr] Downloaded jobserver v0.1.17 [INFO] [stderr] Downloaded unicode-width v0.1.6 [INFO] [stderr] Downloaded yaml-rust v0.3.5 [INFO] [stderr] Downloaded failure v0.1.6 [INFO] [stderr] Downloaded rand v0.7.2 [INFO] [stderr] Downloaded cc v1.0.45 [INFO] [stderr] Downloaded rustc-demangle v0.1.16 [INFO] [stderr] Downloaded proc-macro2 v1.0.6 [INFO] [stderr] Downloaded quote v1.0.2 [INFO] [stderr] Downloaded syn v1.0.7 [INFO] [stderr] Downloaded synstructure v0.12.2 [INFO] [stderr] Downloaded backtrace v0.3.40 [INFO] [stderr] Downloaded libc v0.2.62 [INFO] [stderr] Downloaded backtrace-sys v0.1.32 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a59b6bfcefde73c290b42d0b96aab32d8f0d4ac699d78d607f56c3d5b02b41a5 [INFO] running `Command { std: "docker" "start" "-a" "a59b6bfcefde73c290b42d0b96aab32d8f0d4ac699d78d607f56c3d5b02b41a5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a59b6bfcefde73c290b42d0b96aab32d8f0d4ac699d78d607f56c3d5b02b41a5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a59b6bfcefde73c290b42d0b96aab32d8f0d4ac699d78d607f56c3d5b02b41a5", kill_on_drop: false }` [INFO] [stdout] a59b6bfcefde73c290b42d0b96aab32d8f0d4ac699d78d607f56c3d5b02b41a5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 01be1bace1968ae505349840f306d6cd65aa09ab77425005687f96f6f8a2aae8 [INFO] running `Command { std: "docker" "start" "-a" "01be1bace1968ae505349840f306d6cd65aa09ab77425005687f96f6f8a2aae8", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Compiling libc v0.2.62 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling cfg-if v0.1.9 [INFO] [stderr] Compiling proc-macro2 v1.0.6 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling syn v1.0.7 [INFO] [stderr] Compiling getrandom v0.1.12 [INFO] [stderr] Compiling failure_derive v0.1.6 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking ppv-lite86 v0.2.6 [INFO] [stderr] Checking rustc-demangle v0.1.16 [INFO] [stderr] Checking unicode-width v0.1.6 [INFO] [stderr] Checking yaml-rust v0.3.5 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking lazy-init v0.3.0 [INFO] [stderr] Checking remove_dir_all v0.5.2 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking c2-chacha v0.2.3 [INFO] [stderr] Compiling jobserver v0.1.17 [INFO] [stderr] Compiling num_cpus v1.10.1 [INFO] [stderr] Checking atty v0.2.13 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Compiling cc v1.0.45 [INFO] [stderr] Checking rand_chacha v0.2.1 [INFO] [stderr] Checking rand v0.7.2 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Compiling backtrace-sys v0.1.32 [INFO] [stderr] Compiling molconv v0.2.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking tempfile v3.1.0 [INFO] [stderr] Checking backtrace v0.3.40 [INFO] [stderr] Compiling synstructure v0.12.2 [INFO] [stderr] Checking failure v0.1.6 [INFO] [stdout] warning: type `int_least8_t` should have an upper camel case name [INFO] [stdout] --> src/molconv/xdr/c_abi/xdr_seek.rs:73:10 [INFO] [stdout] | [INFO] [stdout] 73 | pub type int_least8_t = ::std::os::raw::c_schar; [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to upper camel case: `IntLeast8T` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `int_least16_t` should have an upper camel case name [INFO] [stdout] --> src/molconv/xdr/c_abi/xdr_seek.rs:74:10 [INFO] [stdout] | [INFO] [stdout] 74 | pub type int_least16_t = ::std::os::raw::c_short; [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `IntLeast16T` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `int_least32_t` should have an upper camel case name [INFO] [stdout] --> src/molconv/xdr/c_abi/xdr_seek.rs:75:10 [INFO] [stdout] | [INFO] [stdout] 75 | pub type int_least32_t = ::std::os::raw::c_int; [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `IntLeast32T` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `int_least64_t` should have an upper camel case name [INFO] [stdout] --> src/molconv/xdr/c_abi/xdr_seek.rs:76:10 [INFO] [stdout] | [INFO] [stdout] 76 | pub type int_least64_t = ::std::os::raw::c_long; [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `IntLeast64T` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `uint_least8_t` should have an upper camel case name [INFO] [stdout] --> src/molconv/xdr/c_abi/xdr_seek.rs:77:10 [INFO] [stdout] | [INFO] [stdout] 77 | pub type uint_least8_t = ::std::os::raw::c_uchar; [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `UintLeast8T` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `uint_least16_t` should have an upper camel case name [INFO] [stdout] --> src/molconv/xdr/c_abi/xdr_seek.rs:78:10 [INFO] [stdout] | [INFO] [stdout] 78 | pub type uint_least16_t = ::std::os::raw::c_ushort; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `UintLeast16T` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `uint_least32_t` should have an upper camel case name [INFO] [stdout] --> src/molconv/xdr/c_abi/xdr_seek.rs:79:10 [INFO] [stdout] | [INFO] [stdout] 79 | pub type uint_least32_t = ::std::os::raw::c_uint; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `UintLeast32T` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `uint_least64_t` should have an upper camel case name [INFO] [stdout] --> src/molconv/xdr/c_abi/xdr_seek.rs:80:10 [INFO] [stdout] | [INFO] [stdout] 80 | pub type uint_least64_t = ::std::os::raw::c_ulong; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `UintLeast64T` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `int_fast8_t` should have an upper camel case name [INFO] [stdout] --> src/molconv/xdr/c_abi/xdr_seek.rs:81:10 [INFO] [stdout] | [INFO] [stdout] 81 | pub type int_fast8_t = ::std::os::raw::c_schar; [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to upper camel case: `IntFast8T` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `int_fast16_t` should have an upper camel case name [INFO] [stdout] --> src/molconv/xdr/c_abi/xdr_seek.rs:82:10 [INFO] [stdout] | [INFO] [stdout] 82 | pub type int_fast16_t = ::std::os::raw::c_long; [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to upper camel case: `IntFast16T` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `int_fast32_t` should have an upper camel case name [INFO] [stdout] --> src/molconv/xdr/c_abi/xdr_seek.rs:83:10 [INFO] [stdout] | [INFO] [stdout] 83 | pub type int_fast32_t = ::std::os::raw::c_long; [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to upper camel case: `IntFast32T` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `int_fast64_t` should have an upper camel case name [INFO] [stdout] --> src/molconv/xdr/c_abi/xdr_seek.rs:84:10 [INFO] [stdout] | [INFO] [stdout] 84 | pub type int_fast64_t = ::std::os::raw::c_long; [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to upper camel case: `IntFast64T` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `uint_fast8_t` should have an upper camel case name [INFO] [stdout] --> src/molconv/xdr/c_abi/xdr_seek.rs:85:10 [INFO] [stdout] | [INFO] [stdout] 85 | pub type uint_fast8_t = ::std::os::raw::c_uchar; [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to upper camel case: `UintFast8T` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `uint_fast16_t` should have an upper camel case name [INFO] [stdout] --> src/molconv/xdr/c_abi/xdr_seek.rs:86:10 [INFO] [stdout] | [INFO] [stdout] 86 | pub type uint_fast16_t = ::std::os::raw::c_ulong; [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `UintFast16T` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `uint_fast32_t` should have an upper camel case name [INFO] [stdout] --> src/molconv/xdr/c_abi/xdr_seek.rs:87:10 [INFO] [stdout] | [INFO] [stdout] 87 | pub type uint_fast32_t = ::std::os::raw::c_ulong; [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `UintFast32T` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `uint_fast64_t` should have an upper camel case name [INFO] [stdout] --> src/molconv/xdr/c_abi/xdr_seek.rs:88:10 [INFO] [stdout] | [INFO] [stdout] 88 | pub type uint_fast64_t = ::std::os::raw::c_ulong; [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `UintFast64T` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `intmax_t` should have an upper camel case name [INFO] [stdout] --> src/molconv/xdr/c_abi/xdr_seek.rs:89:10 [INFO] [stdout] | [INFO] [stdout] 89 | pub type intmax_t = ::std::os::raw::c_long; [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to upper camel case: `IntmaxT` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `uintmax_t` should have an upper camel case name [INFO] [stdout] --> src/molconv/xdr/c_abi/xdr_seek.rs:90:10 [INFO] [stdout] | [INFO] [stdout] 90 | pub type uintmax_t = ::std::os::raw::c_ulong; [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to upper camel case: `UintmaxT` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/molconv/xdr/mod.rs:84:77 [INFO] [stdout] | [INFO] [stdout] 84 | _ => Err(TrajectoryError { operation: String::from("read"), code: code }), [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/molconv/xdr/mod.rs:100:78 [INFO] [stdout] | [INFO] [stdout] 100 | _ => Err(TrajectoryError { operation: String::from("write"), code: code }) [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/molconv/xdr/mod.rs:110:78 [INFO] [stdout] | [INFO] [stdout] 110 | _ => Err(TrajectoryError { operation: String::from("flush"), code: code}) [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/molconv/xdr/mod.rs:163:77 [INFO] [stdout] | [INFO] [stdout] 163 | _ => Err(TrajectoryError { operation: String::from("read"), code: code }), [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/molconv/xdr/mod.rs:181:78 [INFO] [stdout] | [INFO] [stdout] 181 | _ => Err(TrajectoryError { operation: String::from("write"), code: code }), [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/molconv/xdr/mod.rs:191:77 [INFO] [stdout] | [INFO] [stdout] 191 | _ => Err(TrajectoryError { operation: String::from("read"), code: code }), [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/molconv/lib.rs:70:13 [INFO] [stdout] | [INFO] [stdout] 70 | num_atoms: num_atoms, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_atoms` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `int_least8_t` should have an upper camel case name [INFO] [stdout] --> src/molconv/xdr/c_abi/xdr_seek.rs:73:10 [INFO] [stdout] | [INFO] [stdout] 73 | pub type int_least8_t = ::std::os::raw::c_schar; [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to upper camel case: `IntLeast8T` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `int_least16_t` should have an upper camel case name [INFO] [stdout] --> src/molconv/xdr/c_abi/xdr_seek.rs:74:10 [INFO] [stdout] | [INFO] [stdout] 74 | pub type int_least16_t = ::std::os::raw::c_short; [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `IntLeast16T` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `int_least32_t` should have an upper camel case name [INFO] [stdout] --> src/molconv/xdr/c_abi/xdr_seek.rs:75:10 [INFO] [stdout] | [INFO] [stdout] 75 | pub type int_least32_t = ::std::os::raw::c_int; [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `IntLeast32T` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `int_least64_t` should have an upper camel case name [INFO] [stdout] --> src/molconv/xdr/c_abi/xdr_seek.rs:76:10 [INFO] [stdout] | [INFO] [stdout] 76 | pub type int_least64_t = ::std::os::raw::c_long; [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `IntLeast64T` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `uint_least8_t` should have an upper camel case name [INFO] [stdout] --> src/molconv/xdr/c_abi/xdr_seek.rs:77:10 [INFO] [stdout] | [INFO] [stdout] 77 | pub type uint_least8_t = ::std::os::raw::c_uchar; [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `UintLeast8T` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `uint_least16_t` should have an upper camel case name [INFO] [stdout] --> src/molconv/xdr/c_abi/xdr_seek.rs:78:10 [INFO] [stdout] | [INFO] [stdout] 78 | pub type uint_least16_t = ::std::os::raw::c_ushort; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `UintLeast16T` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `uint_least32_t` should have an upper camel case name [INFO] [stdout] --> src/molconv/xdr/c_abi/xdr_seek.rs:79:10 [INFO] [stdout] | [INFO] [stdout] 79 | pub type uint_least32_t = ::std::os::raw::c_uint; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `UintLeast32T` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `uint_least64_t` should have an upper camel case name [INFO] [stdout] --> src/molconv/xdr/c_abi/xdr_seek.rs:80:10 [INFO] [stdout] | [INFO] [stdout] 80 | pub type uint_least64_t = ::std::os::raw::c_ulong; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `UintLeast64T` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `int_fast8_t` should have an upper camel case name [INFO] [stdout] --> src/molconv/xdr/c_abi/xdr_seek.rs:81:10 [INFO] [stdout] | [INFO] [stdout] 81 | pub type int_fast8_t = ::std::os::raw::c_schar; [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to upper camel case: `IntFast8T` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `int_fast16_t` should have an upper camel case name [INFO] [stdout] --> src/molconv/xdr/c_abi/xdr_seek.rs:82:10 [INFO] [stdout] | [INFO] [stdout] 82 | pub type int_fast16_t = ::std::os::raw::c_long; [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to upper camel case: `IntFast16T` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `int_fast32_t` should have an upper camel case name [INFO] [stdout] --> src/molconv/xdr/c_abi/xdr_seek.rs:83:10 [INFO] [stdout] | [INFO] [stdout] 83 | pub type int_fast32_t = ::std::os::raw::c_long; [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to upper camel case: `IntFast32T` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `int_fast64_t` should have an upper camel case name [INFO] [stdout] --> src/molconv/xdr/c_abi/xdr_seek.rs:84:10 [INFO] [stdout] | [INFO] [stdout] 84 | pub type int_fast64_t = ::std::os::raw::c_long; [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to upper camel case: `IntFast64T` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `uint_fast8_t` should have an upper camel case name [INFO] [stdout] --> src/molconv/xdr/c_abi/xdr_seek.rs:85:10 [INFO] [stdout] | [INFO] [stdout] 85 | pub type uint_fast8_t = ::std::os::raw::c_uchar; [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to upper camel case: `UintFast8T` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `uint_fast16_t` should have an upper camel case name [INFO] [stdout] --> src/molconv/xdr/c_abi/xdr_seek.rs:86:10 [INFO] [stdout] | [INFO] [stdout] 86 | pub type uint_fast16_t = ::std::os::raw::c_ulong; [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `UintFast16T` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `uint_fast32_t` should have an upper camel case name [INFO] [stdout] --> src/molconv/xdr/c_abi/xdr_seek.rs:87:10 [INFO] [stdout] | [INFO] [stdout] 87 | pub type uint_fast32_t = ::std::os::raw::c_ulong; [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `UintFast32T` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `uint_fast64_t` should have an upper camel case name [INFO] [stdout] --> src/molconv/xdr/c_abi/xdr_seek.rs:88:10 [INFO] [stdout] | [INFO] [stdout] 88 | pub type uint_fast64_t = ::std::os::raw::c_ulong; [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `UintFast64T` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `intmax_t` should have an upper camel case name [INFO] [stdout] --> src/molconv/xdr/c_abi/xdr_seek.rs:89:10 [INFO] [stdout] | [INFO] [stdout] 89 | pub type intmax_t = ::std::os::raw::c_long; [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to upper camel case: `IntmaxT` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `uintmax_t` should have an upper camel case name [INFO] [stdout] --> src/molconv/xdr/c_abi/xdr_seek.rs:90:10 [INFO] [stdout] | [INFO] [stdout] 90 | pub type uintmax_t = ::std::os::raw::c_ulong; [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to upper camel case: `UintmaxT` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/molconv/xdr/mod.rs:84:77 [INFO] [stdout] | [INFO] [stdout] 84 | _ => Err(TrajectoryError { operation: String::from("read"), code: code }), [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/molconv/xdr/mod.rs:100:78 [INFO] [stdout] | [INFO] [stdout] 100 | _ => Err(TrajectoryError { operation: String::from("write"), code: code }) [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/molconv/xdr/mod.rs:110:78 [INFO] [stdout] | [INFO] [stdout] 110 | _ => Err(TrajectoryError { operation: String::from("flush"), code: code}) [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/molconv/xdr/mod.rs:163:77 [INFO] [stdout] | [INFO] [stdout] 163 | _ => Err(TrajectoryError { operation: String::from("read"), code: code }), [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/molconv/xdr/mod.rs:181:78 [INFO] [stdout] | [INFO] [stdout] 181 | _ => Err(TrajectoryError { operation: String::from("write"), code: code }), [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/molconv/xdr/mod.rs:191:77 [INFO] [stdout] | [INFO] [stdout] 191 | _ => Err(TrajectoryError { operation: String::from("read"), code: code }), [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/molconv/lib.rs:70:13 [INFO] [stdout] | [INFO] [stdout] 70 | num_atoms: num_atoms, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_atoms` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `filemode` is never read [INFO] [stdout] --> src/molconv/xdr/mod.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 21 | struct XDRFile { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] 22 | xdrfile: *mut XDRFILE, [INFO] [stdout] 23 | filemode: FileMode, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/molconv/trajectory.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | / return match *self { [INFO] [stdout] 20 | | FileMode::Write => "w", [INFO] [stdout] 21 | | FileMode::Append => "a", [INFO] [stdout] 22 | | FileMode::Read => "r", [INFO] [stdout] 23 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 ~ match *self { [INFO] [stdout] 20 + FileMode::Write => "w", [INFO] [stdout] 21 + FileMode::Append => "a", [INFO] [stdout] 22 + FileMode::Read => "r", [INFO] [stdout] 23 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/molconv/xdr/mod.rs:38:17 [INFO] [stdout] | [INFO] [stdout] 38 | return Ok(XDRFile { xdrfile, filemode, path }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 38 - return Ok(XDRFile { xdrfile, filemode, path }); [INFO] [stdout] 38 + Ok(XDRFile { xdrfile, filemode, path }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/molconv/xdr/mod.rs:40:17 [INFO] [stdout] | [INFO] [stdout] 40 | return Err(err_msg("Failed to open trajectory file")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return Err(err_msg("Failed to open trajectory file")); [INFO] [stdout] 40 + Err(err_msg("Failed to open trajectory file")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/molconv/lib.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | / return Frame { [INFO] [stdout] 46 | | num_atoms: 0, [INFO] [stdout] 47 | | step: 0, [INFO] [stdout] 48 | | time: 0.0, [INFO] [stdout] 49 | | box_vector: [[0.0; 3]; 3], [INFO] [stdout] 50 | | coords: Vec::with_capacity(0) [INFO] [stdout] 51 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 45 ~ Frame { [INFO] [stdout] 46 + num_atoms: 0, [INFO] [stdout] 47 + step: 0, [INFO] [stdout] 48 + time: 0.0, [INFO] [stdout] 49 + box_vector: [[0.0; 3]; 3], [INFO] [stdout] 50 + coords: Vec::with_capacity(0) [INFO] [stdout] 51 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/molconv/lib.rs:65:9 [INFO] [stdout] | [INFO] [stdout] 65 | return Frame{ ..Default::default() }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 65 - return Frame{ ..Default::default() }; [INFO] [stdout] 65 + Frame{ ..Default::default() } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/molconv/lib.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 69 | / return Frame { [INFO] [stdout] 70 | | num_atoms: num_atoms, [INFO] [stdout] 71 | | coords: vec![[0.0, 0.0, 0.0]; num_atoms as usize], [INFO] [stdout] 72 | | ..Default::default() [INFO] [stdout] 73 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 69 ~ Frame { [INFO] [stdout] 70 + num_atoms: num_atoms, [INFO] [stdout] 71 + coords: vec![[0.0, 0.0, 0.0]; num_atoms as usize], [INFO] [stdout] 72 + ..Default::default() [INFO] [stdout] 73 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/molconv/lib.rs:78:23 [INFO] [stdout] | [INFO] [stdout] 78 | self.coords = self.coords.iter() // TODO faster implementation? [INFO] [stdout] | _______________________^ [INFO] [stdout] 79 | | .map(|elem| elem.clone()) [INFO] [stdout] | |_____________________________________^ help: consider calling the dedicated `copied` method: `self.coords.iter().copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[f32; 3]` which implements the `Copy` trait [INFO] [stdout] --> src/molconv/lib.rs:79:25 [INFO] [stdout] | [INFO] [stdout] 79 | .map(|elem| elem.clone()) [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*elem` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/molconv/lib.rs:14:17 [INFO] [stdout] | [INFO] [stdout] 14 | #[derive(Debug, Fail, Clone)] [INFO] [stdout] | ^--- [INFO] [stdout] | | [INFO] [stdout] | `Fail` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_failure_Fail_FOR_TrajectoryError` [INFO] [stdout] 15 | #[fail(display="Trajectory Error while {}: {}", operation, code)] [INFO] [stdout] 16 | pub struct TrajectoryError { [INFO] [stdout] | --------------- `TrajectoryError` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Fail` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Fail` may come from an old version of the `failure_derive` crate, try updating your dependency with `cargo update -p failure_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Fail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/molconv/lib.rs:14:17 [INFO] [stdout] | [INFO] [stdout] 14 | #[derive(Debug, Fail, Clone)] [INFO] [stdout] | ^--- [INFO] [stdout] | | [INFO] [stdout] | `Display` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_failure_core_fmt_Display_FOR_TrajectoryError` [INFO] [stdout] 15 | #[fail(display="Trajectory Error while {}: {}", operation, code)] [INFO] [stdout] 16 | pub struct TrajectoryError { [INFO] [stdout] | --------------- `TrajectoryError` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Fail` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Fail` may come from an old version of the `failure_derive` crate, try updating your dependency with `cargo update -p failure_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Fail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `filemode` is never read [INFO] [stdout] --> src/molconv/xdr/mod.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 21 | struct XDRFile { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] 22 | xdrfile: *mut XDRFILE, [INFO] [stdout] 23 | filemode: FileMode, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/molconv/trajectory.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | / return match *self { [INFO] [stdout] 20 | | FileMode::Write => "w", [INFO] [stdout] 21 | | FileMode::Append => "a", [INFO] [stdout] 22 | | FileMode::Read => "r", [INFO] [stdout] 23 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 ~ match *self { [INFO] [stdout] 20 + FileMode::Write => "w", [INFO] [stdout] 21 + FileMode::Append => "a", [INFO] [stdout] 22 + FileMode::Read => "r", [INFO] [stdout] 23 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/molconv/trajectory.rs:172:17 [INFO] [stdout] | [INFO] [stdout] 172 | assert!(!traj_type.is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `traj_type.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `read_trr_natoms` doesn't need a mutable reference [INFO] [stdout] --> src/molconv/xdr/c_abi/xdrfile_trr.rs:56:57 [INFO] [stdout] | [INFO] [stdout] 56 | read_trr_natoms(path.as_ptr() as *const i8, &mut natoms); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 56 - read_trr_natoms(path.as_ptr() as *const i8, &mut natoms); [INFO] [stdout] 56 + read_trr_natoms(path.as_ptr() as *const i8, &natoms); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting raw pointers to the same type and constness is unnecessary (`*const i8` -> `*const i8`) [INFO] [stdout] --> src/molconv/xdr/c_abi/xdrfile_trr.rs:56:29 [INFO] [stdout] | [INFO] [stdout] 56 | read_trr_natoms(path.as_ptr() as *const i8, &mut natoms); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `path.as_ptr()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `read_trr_nframes` doesn't need a mutable reference [INFO] [stdout] --> src/molconv/xdr/c_abi/xdrfile_trr.rs:67:69 [INFO] [stdout] | [INFO] [stdout] 67 | let code = read_trr_nframes(path.as_ptr() as *const i8, &mut nframes); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 67 - let code = read_trr_nframes(path.as_ptr() as *const i8, &mut nframes); [INFO] [stdout] 67 + let code = read_trr_nframes(path.as_ptr() as *const i8, &nframes); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting raw pointers to the same type and constness is unnecessary (`*const i8` -> `*const i8`) [INFO] [stdout] --> src/molconv/xdr/c_abi/xdrfile_trr.rs:67:41 [INFO] [stdout] | [INFO] [stdout] 67 | let code = read_trr_nframes(path.as_ptr() as *const i8, &mut nframes); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `path.as_ptr()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `read_xtc_natoms` doesn't need a mutable reference [INFO] [stdout] --> src/molconv/xdr/c_abi/xdrfile_xtc.rs:52:55 [INFO] [stdout] | [INFO] [stdout] 52 | read_xtc_natoms(path.as_ptr() as *mut i8, &mut natoms); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 52 - read_xtc_natoms(path.as_ptr() as *mut i8, &mut natoms); [INFO] [stdout] 52 + read_xtc_natoms(path.as_ptr() as *mut i8, &natoms); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `read_xtc_nframes` doesn't need a mutable reference [INFO] [stdout] --> src/molconv/xdr/c_abi/xdrfile_xtc.rs:63:69 [INFO] [stdout] | [INFO] [stdout] 63 | let code = read_xtc_nframes(path.as_ptr() as *const i8, &mut nframes); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 63 - let code = read_xtc_nframes(path.as_ptr() as *const i8, &mut nframes); [INFO] [stdout] 63 + let code = read_xtc_nframes(path.as_ptr() as *const i8, &nframes); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting raw pointers to the same type and constness is unnecessary (`*const i8` -> `*const i8`) [INFO] [stdout] --> src/molconv/xdr/c_abi/xdrfile_xtc.rs:63:41 [INFO] [stdout] | [INFO] [stdout] 63 | let code = read_xtc_nframes(path.as_ptr() as *const i8, &mut nframes); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `path.as_ptr()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/molconv/xdr/mod.rs:38:17 [INFO] [stdout] | [INFO] [stdout] 38 | return Ok(XDRFile { xdrfile, filemode, path }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 38 - return Ok(XDRFile { xdrfile, filemode, path }); [INFO] [stdout] 38 + Ok(XDRFile { xdrfile, filemode, path }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/molconv/xdr/mod.rs:40:17 [INFO] [stdout] | [INFO] [stdout] 40 | return Err(err_msg("Failed to open trajectory file")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return Err(err_msg("Failed to open trajectory file")); [INFO] [stdout] 40 + Err(err_msg("Failed to open trajectory file")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/molconv/xdr/mod.rs:235:23 [INFO] [stdout] | [INFO] [stdout] 235 | Err(_) => assert!(false), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] = note: `#[warn(clippy::assertions_on_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> src/molconv/xdr/mod.rs:236:23 [INFO] [stdout] | [INFO] [stdout] 236 | Ok(()) => assert!(true) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/molconv/xdr/mod.rs:244:23 [INFO] [stdout] | [INFO] [stdout] 244 | Err(e) => assert!(false, "{:?}", e), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> src/molconv/xdr/mod.rs:245:23 [INFO] [stdout] | [INFO] [stdout] 245 | Ok(()) => assert!(true) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/molconv/xdr/mod.rs:271:23 [INFO] [stdout] | [INFO] [stdout] 271 | Err(_) => assert!(false), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> src/molconv/xdr/mod.rs:272:23 [INFO] [stdout] | [INFO] [stdout] 272 | Ok(()) => assert!(true) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/molconv/xdr/mod.rs:280:23 [INFO] [stdout] | [INFO] [stdout] 280 | Err(e) => assert!(false, "{:?}", e), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> src/molconv/xdr/mod.rs:281:23 [INFO] [stdout] | [INFO] [stdout] 281 | Ok(()) => assert!(true) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/molconv/lib.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | / return Frame { [INFO] [stdout] 46 | | num_atoms: 0, [INFO] [stdout] 47 | | step: 0, [INFO] [stdout] 48 | | time: 0.0, [INFO] [stdout] 49 | | box_vector: [[0.0; 3]; 3], [INFO] [stdout] 50 | | coords: Vec::with_capacity(0) [INFO] [stdout] 51 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 45 ~ Frame { [INFO] [stdout] 46 + num_atoms: 0, [INFO] [stdout] 47 + step: 0, [INFO] [stdout] 48 + time: 0.0, [INFO] [stdout] 49 + box_vector: [[0.0; 3]; 3], [INFO] [stdout] 50 + coords: Vec::with_capacity(0) [INFO] [stdout] 51 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/molconv/lib.rs:65:9 [INFO] [stdout] | [INFO] [stdout] 65 | return Frame{ ..Default::default() }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 65 - return Frame{ ..Default::default() }; [INFO] [stdout] 65 + Frame{ ..Default::default() } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/molconv/lib.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 69 | / return Frame { [INFO] [stdout] 70 | | num_atoms: num_atoms, [INFO] [stdout] 71 | | coords: vec![[0.0, 0.0, 0.0]; num_atoms as usize], [INFO] [stdout] 72 | | ..Default::default() [INFO] [stdout] 73 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 69 ~ Frame { [INFO] [stdout] 70 + num_atoms: num_atoms, [INFO] [stdout] 71 + coords: vec![[0.0, 0.0, 0.0]; num_atoms as usize], [INFO] [stdout] 72 + ..Default::default() [INFO] [stdout] 73 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/molconv/lib.rs:78:23 [INFO] [stdout] | [INFO] [stdout] 78 | self.coords = self.coords.iter() // TODO faster implementation? [INFO] [stdout] | _______________________^ [INFO] [stdout] 79 | | .map(|elem| elem.clone()) [INFO] [stdout] | |_____________________________________^ help: consider calling the dedicated `copied` method: `self.coords.iter().copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[f32; 3]` which implements the `Copy` trait [INFO] [stdout] --> src/molconv/lib.rs:79:25 [INFO] [stdout] | [INFO] [stdout] 79 | .map(|elem| elem.clone()) [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*elem` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/molconv/lib.rs:14:17 [INFO] [stdout] | [INFO] [stdout] 14 | #[derive(Debug, Fail, Clone)] [INFO] [stdout] | ^--- [INFO] [stdout] | | [INFO] [stdout] | `Fail` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_failure_Fail_FOR_TrajectoryError` [INFO] [stdout] 15 | #[fail(display="Trajectory Error while {}: {}", operation, code)] [INFO] [stdout] 16 | pub struct TrajectoryError { [INFO] [stdout] | --------------- `TrajectoryError` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Fail` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Fail` may come from an old version of the `failure_derive` crate, try updating your dependency with `cargo update -p failure_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Fail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/molconv/lib.rs:14:17 [INFO] [stdout] | [INFO] [stdout] 14 | #[derive(Debug, Fail, Clone)] [INFO] [stdout] | ^--- [INFO] [stdout] | | [INFO] [stdout] | `Display` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_failure_core_fmt_Display_FOR_TrajectoryError` [INFO] [stdout] 15 | #[fail(display="Trajectory Error while {}: {}", operation, code)] [INFO] [stdout] 16 | pub struct TrajectoryError { [INFO] [stdout] | --------------- `TrajectoryError` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Fail` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Fail` may come from an old version of the `failure_derive` crate, try updating your dependency with `cargo update -p failure_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Fail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/molconv/trajectory.rs:204:9 [INFO] [stdout] | [INFO] [stdout] 204 | traj.read(&mut frame2); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 204 | let _ = traj.read(&mut frame2); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/molconv/trajectory.rs:223:38 [INFO] [stdout] | [INFO] [stdout] 223 | assert!(frames[0].step == 1, frames[0].step); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `assert!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 223 | assert!(frames[0].step == 1, "{}", frames[0].step); [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/cli.rs:135:14 [INFO] [stdout] | [INFO] [stdout] 135 | .map(|i| PathBuf::from(i)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `PathBuf::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/cli.rs:148:9 [INFO] [stdout] | [INFO] [stdout] 148 | std::usize::MAX - 1 // because we might later do `last + 1` [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 148 - std::usize::MAX - 1 // because we might later do `last + 1` [INFO] [stdout] 148 + usize::MAX - 1 // because we might later do `last + 1` [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cli.rs:156:25 [INFO] [stdout] | [INFO] [stdout] 156 | read_index_file(&index_path)? [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `index_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:35:20 [INFO] [stdout] | [INFO] [stdout] 35 | if config.indeces.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!config.indeces.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `.map().collect()` can be replaced with `.try_for_each()` [INFO] [stdout] --> src/main.rs:54:17 [INFO] [stdout] | [INFO] [stdout] 54 | / frame_iter.map(|frame| { [INFO] [stdout] 55 | | frames_written += 1; [INFO] [stdout] 56 | | out_traj.write(&frame) [INFO] [stdout] 57 | | }).collect::>()?; [INFO] [stdout] | |___________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_collect_result_unit [INFO] [stdout] = note: `#[warn(clippy::map_collect_result_unit)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 54 ~ frame_iter.try_for_each(|frame| { [INFO] [stdout] 55 + frames_written += 1; [INFO] [stdout] 56 + out_traj.write(&frame) [INFO] [stdout] 57 ~ })?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/cli.rs:135:14 [INFO] [stdout] | [INFO] [stdout] 135 | .map(|i| PathBuf::from(i)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `PathBuf::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/cli.rs:148:9 [INFO] [stdout] | [INFO] [stdout] 148 | std::usize::MAX - 1 // because we might later do `last + 1` [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 148 - std::usize::MAX - 1 // because we might later do `last + 1` [INFO] [stdout] 148 + usize::MAX - 1 // because we might later do `last + 1` [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cli.rs:156:25 [INFO] [stdout] | [INFO] [stdout] 156 | read_index_file(&index_path)? [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `index_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:35:20 [INFO] [stdout] | [INFO] [stdout] 35 | if config.indeces.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!config.indeces.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `.map().collect()` can be replaced with `.try_for_each()` [INFO] [stdout] --> src/main.rs:54:17 [INFO] [stdout] | [INFO] [stdout] 54 | / frame_iter.map(|frame| { [INFO] [stdout] 55 | | frames_written += 1; [INFO] [stdout] 56 | | out_traj.write(&frame) [INFO] [stdout] 57 | | }).collect::>()?; [INFO] [stdout] | |___________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_collect_result_unit [INFO] [stdout] = note: `#[warn(clippy::map_collect_result_unit)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 54 ~ frame_iter.try_for_each(|frame| { [INFO] [stdout] 55 + frames_written += 1; [INFO] [stdout] 56 + out_traj.write(&frame) [INFO] [stdout] 57 ~ })?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 8.47s [INFO] running `Command { std: "docker" "inspect" "01be1bace1968ae505349840f306d6cd65aa09ab77425005687f96f6f8a2aae8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "01be1bace1968ae505349840f306d6cd65aa09ab77425005687f96f6f8a2aae8", kill_on_drop: false }` [INFO] [stdout] 01be1bace1968ae505349840f306d6cd65aa09ab77425005687f96f6f8a2aae8