[INFO] fetching crate minilp 0.2.2... [INFO] linting minilp-0.2.2 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate minilp 0.2.2 into /workspace/builds/worker-1-tc1/source [INFO] started tweaking crates.io crate minilp 0.2.2 [INFO] finished tweaking crates.io crate minilp 0.2.2 [INFO] tweaked toml for crates.io crate minilp 0.2.2 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate minilp 0.2.2 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate minilp 0.2.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded matrixmultiply v0.2.3 [INFO] [stderr] Downloaded hermit-abi v0.1.10 [INFO] [stderr] Downloaded winapi-util v0.1.4 [INFO] [stderr] Downloaded sprs v0.7.1 [INFO] [stderr] Downloaded ndarray v0.13.0 [INFO] [stderr] Downloaded regex v1.3.6 [INFO] [stderr] Downloaded regex-syntax v0.6.17 [INFO] [stderr] Downloaded libc v0.2.68 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 088ae468c2bc6320bd492e36b7b4373abafd1e8b4bd3d6a3cb8ae78ff015b75e [INFO] running `Command { std: "docker" "start" "-a" "088ae468c2bc6320bd492e36b7b4373abafd1e8b4bd3d6a3cb8ae78ff015b75e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "088ae468c2bc6320bd492e36b7b4373abafd1e8b4bd3d6a3cb8ae78ff015b75e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "088ae468c2bc6320bd492e36b7b4373abafd1e8b4bd3d6a3cb8ae78ff015b75e", kill_on_drop: false }` [INFO] [stdout] 088ae468c2bc6320bd492e36b7b4373abafd1e8b4bd3d6a3cb8ae78ff015b75e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7c36ef3daa48547bfc18f02890b8f378b1e9d3f0a43e95350b438e2ddfd2a24b [INFO] running `Command { std: "docker" "start" "-a" "7c36ef3daa48547bfc18f02890b8f378b1e9d3f0a43e95350b438e2ddfd2a24b", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.68 [INFO] [stderr] Compiling num-traits v0.2.11 [INFO] [stderr] Compiling num-integer v0.1.42 [INFO] [stderr] Compiling num-complex v0.2.4 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling ndarray v0.13.0 [INFO] [stderr] Checking regex-syntax v0.6.17 [INFO] [stderr] Checking ppv-lite86 v0.2.6 [INFO] [stderr] Checking termcolor v1.1.0 [INFO] [stderr] Checking matrixmultiply v0.2.3 [INFO] [stderr] Checking itertools v0.8.2 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking getrandom v0.1.14 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand_pcg v0.2.1 [INFO] [stderr] Checking num-traits v0.1.43 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking regex v1.3.6 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Checking sprs v0.7.1 [INFO] [stderr] Checking minilp v0.2.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ordering.rs:490:17 [INFO] [stdout] | [INFO] [stdout] 490 | let mut cur_step = dfs_stack.last_mut().unwrap(); [INFO] [stdout] | ----^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `row2col` and `block_cols` are never read [INFO] [stdout] --> src/ordering.rs:547:9 [INFO] [stdout] | [INFO] [stdout] 545 | pub struct BlockDiagForm { [INFO] [stdout] | ------------- fields in this struct [INFO] [stdout] 546 | /// Row permutation: for each original row its new row number so that diag is nonzero. [INFO] [stdout] 547 | pub row2col: Vec, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 548 | /// For each block its set of columns (the order of blocks is lower block triangular) [INFO] [stdout] 549 | pub block_cols: Vec>, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `BlockDiagForm` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `rhs` [INFO] [stdout] --> src/lu.rs:60:22 [INFO] [stdout] | [INFO] [stdout] 60 | for i in 0..rhs.len() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 60 - for i in 0..rhs.len() { [INFO] [stdout] 60 + for (i, ) in rhs.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the method `copy_from_slice` doesn't need a mutable reference [INFO] [stdout] --> src/lu.rs:75:33 [INFO] [stdout] | [INFO] [stdout] 75 | rhs.copy_from_slice(&mut scratch.dense_rhs); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 75 - rhs.copy_from_slice(&mut scratch.dense_rhs); [INFO] [stdout] 75 + rhs.copy_from_slice(&scratch.dense_rhs); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lu.rs:171:21 [INFO] [stdout] | [INFO] [stdout] 171 | |new_i| &lower.col_rows(new_i), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `lower.col_rows(new_i)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(name).is_some()` [INFO] [stdout] --> src/mps.rs:149:37 [INFO] [stdout] | [INFO] [stdout] 149 | if var_name2idx.get(name).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `contains_key(name)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] = note: `#[warn(clippy::unnecessary_get_then_check)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(key).is_none()` [INFO] [stdout] --> src/mps.rs:166:41 [INFO] [stdout] | [INFO] [stdout] 166 | } else if free_rows.get(key).is_none() { [INFO] [stdout] | ----------^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: replace it with: `!free_rows.contains(key)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/mps.rs:338:16 [INFO] [stdout] | [INFO] [stdout] 338 | fn to_next(&mut self) -> io::Result<()> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Result.or_else(|x| Err(y))`, which is more succinctly expressed as `map_err(|x| y)` [INFO] [stdout] --> src/mps.rs:391:5 [INFO] [stdout] | [INFO] [stdout] 391 | / input.parse().or_else(|_| { [INFO] [stdout] 392 | | Err(io::Error::new( [INFO] [stdout] 393 | | io::ErrorKind::InvalidData, [INFO] [stdout] 394 | | format!( [INFO] [stdout] ... | [INFO] [stdout] 398 | | )) [INFO] [stdout] 399 | | }) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] = note: `#[warn(clippy::bind_instead_of_map)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 391 ~ input.parse().map_err(|_| io::Error::new( [INFO] [stdout] 392 + io::ErrorKind::InvalidData, [INFO] [stdout] 393 + format!( [INFO] [stdout] 394 + "line {}: couldn't parse float from string: `{}`", [INFO] [stdout] 395 + line_idx, input [INFO] [stdout] 396 + ), [INFO] [stdout] 397 + )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ordering.rs:490:17 [INFO] [stdout] | [INFO] [stdout] 490 | let mut cur_step = dfs_stack.last_mut().unwrap(); [INFO] [stdout] | ----^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `c` is used to index `cols` [INFO] [stdout] --> src/ordering.rs:106:18 [INFO] [stdout] | [INFO] [stdout] 106 | for c in 0..size { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 106 - for c in 0..size { [INFO] [stdout] 106 + for (c, ) in cols.iter().enumerate().take(size) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to pop elements from a `Vec` in a loop [INFO] [stdout] --> src/ordering.rs:136:17 [INFO] [stdout] | [INFO] [stdout] 136 | let c = stack.pop().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_while_let_some [INFO] [stdout] = note: `#[warn(clippy::manual_while_let_some)]` on by default [INFO] [stdout] help: consider using a `while..let` loop [INFO] [stdout] | [INFO] [stdout] 135 ~ while let Some(c) = stack.pop() { [INFO] [stdout] 136 ~ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/solver.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 74 | write!(f, "Solver\n")?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] = note: `#[warn(clippy::write_with_newline)]` on by default [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 74 - write!(f, "Solver\n")?; [INFO] [stdout] 74 + writeln!(f, "Solver")?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/solver.rs:75:9 [INFO] [stdout] | [INFO] [stdout] 75 | / write!( [INFO] [stdout] 76 | | f, [INFO] [stdout] 77 | | "num_vars: {}, num_constraints: {}, is_primal_feasible: {}, is_dual_feasible: {}\n", [INFO] [stdout] 78 | | self.num_vars, [INFO] [stdout] ... | [INFO] [stdout] 81 | | self.is_dual_feasible, [INFO] [stdout] 82 | | )?; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 75 ~ writeln!( [INFO] [stdout] 76 | f, [INFO] [stdout] 77 ~ "num_vars: {}, num_constraints: {}, is_primal_feasible: {}, is_dual_feasible: {}", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/solver.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 86 | write!(f, "orig_constraints:\n")?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 86 - write!(f, "orig_constraints:\n")?; [INFO] [stdout] 86 + writeln!(f, "orig_constraints:")?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/solver.rs:88:13 [INFO] [stdout] | [INFO] [stdout] 88 | write!(f, "{:?}\n", to_dense(&row))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 88 - write!(f, "{:?}\n", to_dense(&row))?; [INFO] [stdout] 88 + writeln!(f, "{:?}", to_dense(&row))?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/solver.rs:102:9 [INFO] [stdout] | [INFO] [stdout] 102 | write!(f, "cur_obj_val: {:?}\n", self.cur_obj_val)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 102 - write!(f, "cur_obj_val: {:?}\n", self.cur_obj_val)?; [INFO] [stdout] 102 + writeln!(f, "cur_obj_val: {:?}", self.cur_obj_val)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/solver.rs:662:16 [INFO] [stdout] | [INFO] [stdout] 662 | if !(var_state.at_min && obj_coeff > -EPS) && !(var_state.at_max && obj_coeff < EPS) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(var_state.at_min && obj_coeff > -EPS || var_state.at_max && obj_coeff < EPS)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `rhs` [INFO] [stdout] --> src/lu.rs:60:22 [INFO] [stdout] | [INFO] [stdout] 60 | for i in 0..rhs.len() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 60 - for i in 0..rhs.len() { [INFO] [stdout] 60 + for (i, ) in rhs.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the method `copy_from_slice` doesn't need a mutable reference [INFO] [stdout] --> src/lu.rs:75:33 [INFO] [stdout] | [INFO] [stdout] 75 | rhs.copy_from_slice(&mut scratch.dense_rhs); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 75 - rhs.copy_from_slice(&mut scratch.dense_rhs); [INFO] [stdout] 75 + rhs.copy_from_slice(&scratch.dense_rhs); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lu.rs:171:21 [INFO] [stdout] | [INFO] [stdout] 171 | |new_i| &lower.col_rows(new_i), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `lower.col_rows(new_i)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/sparse.rs:320:9 [INFO] [stdout] | [INFO] [stdout] 320 | write!(f, "nondiag:\n")?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 320 - write!(f, "nondiag:\n")?; [INFO] [stdout] 320 + writeln!(f, "nondiag:")?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/sparse.rs:322:13 [INFO] [stdout] | [INFO] [stdout] 322 | write!(f, "{:?}\n", to_dense(&row))? [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 322 - write!(f, "{:?}\n", to_dense(&row))? [INFO] [stdout] 322 + writeln!(f, "{:?}", to_dense(&row))? [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/sparse.rs:324:9 [INFO] [stdout] | [INFO] [stdout] 324 | write!(f, "diag: {:?}\n", self.diag)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 324 - write!(f, "diag: {:?}\n", self.diag)?; [INFO] [stdout] 324 + writeln!(f, "diag: {:?}", self.diag)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/lib.rs:350:17 [INFO] [stdout] | [INFO] [stdout] 350 | pub fn iter(&self) -> SolutionIter { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 350 | pub fn iter(&self) -> SolutionIter<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/helpers.rs:5:10 [INFO] [stdout] | [INFO] [stdout] 5 | vec: &CsVecBase, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the lifetime is elided here [INFO] [stdout] 6 | len: usize, [INFO] [stdout] 7 | ) -> CsVecView [INFO] [stdout] | ^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 7 | ) -> CsVecView<'_, f64> [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(name).is_some()` [INFO] [stdout] --> src/mps.rs:149:37 [INFO] [stdout] | [INFO] [stdout] 149 | if var_name2idx.get(name).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `contains_key(name)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] = note: `#[warn(clippy::unnecessary_get_then_check)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(key).is_none()` [INFO] [stdout] --> src/mps.rs:166:41 [INFO] [stdout] | [INFO] [stdout] 166 | } else if free_rows.get(key).is_none() { [INFO] [stdout] | ----------^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: replace it with: `!free_rows.contains(key)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/mps.rs:338:16 [INFO] [stdout] | [INFO] [stdout] 338 | fn to_next(&mut self) -> io::Result<()> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Result.or_else(|x| Err(y))`, which is more succinctly expressed as `map_err(|x| y)` [INFO] [stdout] --> src/mps.rs:391:5 [INFO] [stdout] | [INFO] [stdout] 391 | / input.parse().or_else(|_| { [INFO] [stdout] 392 | | Err(io::Error::new( [INFO] [stdout] 393 | | io::ErrorKind::InvalidData, [INFO] [stdout] 394 | | format!( [INFO] [stdout] ... | [INFO] [stdout] 398 | | )) [INFO] [stdout] 399 | | }) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] = note: `#[warn(clippy::bind_instead_of_map)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 391 ~ input.parse().map_err(|_| io::Error::new( [INFO] [stdout] 392 + io::ErrorKind::InvalidData, [INFO] [stdout] 393 + format!( [INFO] [stdout] 394 + "line {}: couldn't parse float from string: `{}`", [INFO] [stdout] 395 + line_idx, input [INFO] [stdout] 396 + ), [INFO] [stdout] 397 + )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `c` is used to index `cols` [INFO] [stdout] --> src/ordering.rs:106:18 [INFO] [stdout] | [INFO] [stdout] 106 | for c in 0..size { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 106 - for c in 0..size { [INFO] [stdout] 106 + for (c, ) in cols.iter().enumerate().take(size) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to pop elements from a `Vec` in a loop [INFO] [stdout] --> src/ordering.rs:136:17 [INFO] [stdout] | [INFO] [stdout] 136 | let c = stack.pop().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_while_let_some [INFO] [stdout] = note: `#[warn(clippy::manual_while_let_some)]` on by default [INFO] [stdout] help: consider using a `while..let` loop [INFO] [stdout] | [INFO] [stdout] 135 ~ while let Some(c) = stack.pop() { [INFO] [stdout] 136 ~ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/solver.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 74 | write!(f, "Solver\n")?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] = note: `#[warn(clippy::write_with_newline)]` on by default [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 74 - write!(f, "Solver\n")?; [INFO] [stdout] 74 + writeln!(f, "Solver")?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/solver.rs:75:9 [INFO] [stdout] | [INFO] [stdout] 75 | / write!( [INFO] [stdout] 76 | | f, [INFO] [stdout] 77 | | "num_vars: {}, num_constraints: {}, is_primal_feasible: {}, is_dual_feasible: {}\n", [INFO] [stdout] 78 | | self.num_vars, [INFO] [stdout] ... | [INFO] [stdout] 81 | | self.is_dual_feasible, [INFO] [stdout] 82 | | )?; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 75 ~ writeln!( [INFO] [stdout] 76 | f, [INFO] [stdout] 77 ~ "num_vars: {}, num_constraints: {}, is_primal_feasible: {}, is_dual_feasible: {}", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/solver.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 86 | write!(f, "orig_constraints:\n")?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 86 - write!(f, "orig_constraints:\n")?; [INFO] [stdout] 86 + writeln!(f, "orig_constraints:")?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/solver.rs:88:13 [INFO] [stdout] | [INFO] [stdout] 88 | write!(f, "{:?}\n", to_dense(&row))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 88 - write!(f, "{:?}\n", to_dense(&row))?; [INFO] [stdout] 88 + writeln!(f, "{:?}", to_dense(&row))?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/solver.rs:102:9 [INFO] [stdout] | [INFO] [stdout] 102 | write!(f, "cur_obj_val: {:?}\n", self.cur_obj_val)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 102 - write!(f, "cur_obj_val: {:?}\n", self.cur_obj_val)?; [INFO] [stdout] 102 + writeln!(f, "cur_obj_val: {:?}", self.cur_obj_val)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/solver.rs:662:16 [INFO] [stdout] | [INFO] [stdout] 662 | if !(var_state.at_min && obj_coeff > -EPS) && !(var_state.at_max && obj_coeff < EPS) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(var_state.at_min && obj_coeff > -EPS || var_state.at_max && obj_coeff < EPS)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/sparse.rs:320:9 [INFO] [stdout] | [INFO] [stdout] 320 | write!(f, "nondiag:\n")?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 320 - write!(f, "nondiag:\n")?; [INFO] [stdout] 320 + writeln!(f, "nondiag:")?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/sparse.rs:322:13 [INFO] [stdout] | [INFO] [stdout] 322 | write!(f, "{:?}\n", to_dense(&row))? [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 322 - write!(f, "{:?}\n", to_dense(&row))? [INFO] [stdout] 322 + writeln!(f, "{:?}", to_dense(&row))? [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/sparse.rs:324:9 [INFO] [stdout] | [INFO] [stdout] 324 | write!(f, "diag: {:?}\n", self.diag)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 324 - write!(f, "diag: {:?}\n", self.diag)?; [INFO] [stdout] 324 + writeln!(f, "diag: {:?}", self.diag)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:475:32 [INFO] [stdout] | [INFO] [stdout] 475 | problem.add_constraint(&[(v1, 1.0), (v2, 1.0)], ComparisonOp::Le, 20.0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(v1, 1.0), (v2, 1.0)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:476:32 [INFO] [stdout] | [INFO] [stdout] 476 | problem.add_constraint(&[(v2, -4.0), (v1, 1.0)], ComparisonOp::Ge, -20.0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(v2, -4.0), (v1, 1.0)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implementation of inherent method `to_string(&self) -> String` for type `Tour` [INFO] [stdout] --> examples/tsp.rs:161:5 [INFO] [stdout] | [INFO] [stdout] 161 | / fn to_string(&self) -> String { [INFO] [stdout] 162 | | self.0 [INFO] [stdout] 163 | | .iter() [INFO] [stdout] 164 | | .map(|n| (n + 1).to_string()) [INFO] [stdout] 165 | | .collect::>() [INFO] [stdout] 166 | | .join(" ") [INFO] [stdout] 167 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: implement trait `Display` for type `Tour` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inherent_to_string [INFO] [stdout] = note: `#[warn(clippy::inherent_to_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:533:32 [INFO] [stdout] | [INFO] [stdout] 533 | problem.add_constraint(&[(v1, 1.0), (v2, 1.0)], ComparisonOp::Le, 4.0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(v1, 1.0), (v2, 1.0)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:534:32 [INFO] [stdout] | [INFO] [stdout] 534 | problem.add_constraint(&[(v1, 1.0), (v2, 1.0)], ComparisonOp::Ge, 2.0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(v1, 1.0), (v2, 1.0)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:535:32 [INFO] [stdout] | [INFO] [stdout] 535 | problem.add_constraint(&[(v1, 1.0), (v2, -1.0)], ComparisonOp::Ge, 0.0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(v1, 1.0), (v2, -1.0)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:548:32 [INFO] [stdout] | [INFO] [stdout] 548 | problem.add_constraint(&[(v1, 1.0), (v2, 1.0)], ComparisonOp::Le, 4.0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(v1, 1.0), (v2, 1.0)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:549:32 [INFO] [stdout] | [INFO] [stdout] 549 | problem.add_constraint(&[(v1, 1.0), (v2, 1.0)], ComparisonOp::Ge, 1.0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(v1, 1.0), (v2, 1.0)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `edge_vars` [INFO] [stdout] --> examples/tsp.rs:226:14 [INFO] [stdout] | [INFO] [stdout] 226 | for i in 0..num_points { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 226 - for i in 0..num_points { [INFO] [stdout] 226 + for (i, ) in edge_vars.iter_mut().enumerate().take(num_points) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `edge_vars` [INFO] [stdout] --> examples/tsp.rs:241:14 [INFO] [stdout] | [INFO] [stdout] 241 | for i in 0..num_points { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 241 - for i in 0..num_points { [INFO] [stdout] 241 + for (i, ) in edge_vars.iter().enumerate().take(num_points) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is used to index `edge_vars` [INFO] [stdout] --> examples/tsp.rs:243:18 [INFO] [stdout] | [INFO] [stdout] 243 | for j in 0..num_points { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 243 - for j in 0..num_points { [INFO] [stdout] 243 + for (j, ) in edge_vars.iter().enumerate().take(num_points) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:583:32 [INFO] [stdout] | [INFO] [stdout] 583 | problem.add_constraint(&[(v1, 1.0), (v2, 1.0)], ComparisonOp::Le, 4.0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(v1, 1.0), (v2, 1.0)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:584:32 [INFO] [stdout] | [INFO] [stdout] 584 | problem.add_constraint(&[(v1, 1.0), (v2, 1.0)], ComparisonOp::Ge, 2.0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(v1, 1.0), (v2, 1.0)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:591:33 [INFO] [stdout] | [INFO] [stdout] 591 | .add_constraint(&[(v1, -1.0), (v2, 1.0)], ComparisonOp::Le, 0.0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(v1, -1.0), (v2, 1.0)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:604:33 [INFO] [stdout] | [INFO] [stdout] 604 | .add_constraint(&[(v1, -1.0), (v2, 1.0)], ComparisonOp::Le, 0.0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(v1, -1.0), (v2, 1.0)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:614:33 [INFO] [stdout] | [INFO] [stdout] 614 | .add_constraint(&[(v1, -1.0), (v2, 1.0)], ComparisonOp::Ge, 3.0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(v1, -1.0), (v2, 1.0)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:628:32 [INFO] [stdout] | [INFO] [stdout] 628 | problem.add_constraint(&[(v1, 3.0), (v2, 2.0)], ComparisonOp::Le, 6.0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(v1, 3.0), (v2, 2.0)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:629:32 [INFO] [stdout] | [INFO] [stdout] 629 | problem.add_constraint(&[(v1, -3.0), (v2, 2.0)], ComparisonOp::Le, 0.0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(v1, -3.0), (v2, 2.0)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> examples/tsp.rs:536:5 [INFO] [stdout] | [INFO] [stdout] 536 | return (best_cut_weight, best_cut); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 536 - return (best_cut_weight, best_cut); [INFO] [stdout] 536 + (best_cut_weight, best_cut) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/lib.rs:350:17 [INFO] [stdout] | [INFO] [stdout] 350 | pub fn iter(&self) -> SolutionIter { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 350 | pub fn iter(&self) -> SolutionIter<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/helpers.rs:5:10 [INFO] [stdout] | [INFO] [stdout] 5 | vec: &CsVecBase, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the lifetime is elided here [INFO] [stdout] 6 | len: usize, [INFO] [stdout] 7 | ) -> CsVecView [INFO] [stdout] | ^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 7 | ) -> CsVecView<'_, f64> [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 6.82s [INFO] running `Command { std: "docker" "inspect" "7c36ef3daa48547bfc18f02890b8f378b1e9d3f0a43e95350b438e2ddfd2a24b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7c36ef3daa48547bfc18f02890b8f378b1e9d3f0a43e95350b438e2ddfd2a24b", kill_on_drop: false }` [INFO] [stdout] 7c36ef3daa48547bfc18f02890b8f378b1e9d3f0a43e95350b438e2ddfd2a24b