[INFO] fetching crate minigrep_vandaeldev 0.1.0... [INFO] linting minigrep_vandaeldev-0.1.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate minigrep_vandaeldev 0.1.0 into /workspace/builds/worker-4-tc1/source [INFO] started tweaking crates.io crate minigrep_vandaeldev 0.1.0 [INFO] finished tweaking crates.io crate minigrep_vandaeldev 0.1.0 [INFO] tweaked toml for crates.io crate minigrep_vandaeldev 0.1.0 written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate minigrep_vandaeldev 0.1.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate minigrep_vandaeldev 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 108671e3c442e956bcdd5df2a174d0ae27582d4722ab24982b94dd75399def8f [INFO] running `Command { std: "docker" "start" "-a" "108671e3c442e956bcdd5df2a174d0ae27582d4722ab24982b94dd75399def8f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "108671e3c442e956bcdd5df2a174d0ae27582d4722ab24982b94dd75399def8f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "108671e3c442e956bcdd5df2a174d0ae27582d4722ab24982b94dd75399def8f", kill_on_drop: false }` [INFO] [stdout] 108671e3c442e956bcdd5df2a174d0ae27582d4722ab24982b94dd75399def8f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b8b58799aed804c35f86b6317e89dcd0177f9d297b3865704ebf816b45143d01 [INFO] running `Command { std: "docker" "start" "-a" "b8b58799aed804c35f86b6317e89dcd0177f9d297b3865704ebf816b45143d01", kill_on_drop: false }` [INFO] [stderr] Checking minigrep_vandaeldev v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:47:21 [INFO] [stdout] | [INFO] [stdout] 47 | let has_c_env = !env::var("CASE_INSENSITIVE").is_err(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `env::var("CASE_INSENSITIVE").is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:47:21 [INFO] [stdout] | [INFO] [stdout] 47 | let has_c_env = !env::var("CASE_INSENSITIVE").is_err(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `env::var("CASE_INSENSITIVE").is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/lib.rs:112:5 [INFO] [stdout] | [INFO] [stdout] 112 | assert_eq!(config.query.is_empty(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 112 - assert_eq!(config.query.is_empty(), false); [INFO] [stdout] 112 + assert!(!config.query.is_empty()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/lib.rs:113:5 [INFO] [stdout] | [INFO] [stdout] 113 | assert_eq!(config.filename.is_empty(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 113 - assert_eq!(config.filename.is_empty(), false); [INFO] [stdout] 113 + assert!(!config.filename.is_empty()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/lib.rs:127:5 [INFO] [stdout] | [INFO] [stdout] 127 | let result = run(config).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding and replace variable usages with `()` [INFO] [stdout] | [INFO] [stdout] 127 ~ run(config).unwrap(); [INFO] [stdout] 128 ~ assert_eq!((), ()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.23s [INFO] running `Command { std: "docker" "inspect" "b8b58799aed804c35f86b6317e89dcd0177f9d297b3865704ebf816b45143d01", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b8b58799aed804c35f86b6317e89dcd0177f9d297b3865704ebf816b45143d01", kill_on_drop: false }` [INFO] [stdout] b8b58799aed804c35f86b6317e89dcd0177f9d297b3865704ebf816b45143d01