[INFO] fetching crate mini_paste-proc_macro 0.1.11... [INFO] linting mini_paste-proc_macro-0.1.11 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate mini_paste-proc_macro 0.1.11 into /workspace/builds/worker-6-tc1/source [INFO] started tweaking crates.io crate mini_paste-proc_macro 0.1.11 [INFO] finished tweaking crates.io crate mini_paste-proc_macro 0.1.11 [INFO] tweaked toml for crates.io crate mini_paste-proc_macro 0.1.11 written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate mini_paste-proc_macro 0.1.11 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b8e8bae3f1a0e086238388836d116248cc52b8698d4bb14d33930a7cc0fc6b38 [INFO] running `Command { std: "docker" "start" "-a" "b8e8bae3f1a0e086238388836d116248cc52b8698d4bb14d33930a7cc0fc6b38", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b8e8bae3f1a0e086238388836d116248cc52b8698d4bb14d33930a7cc0fc6b38", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b8e8bae3f1a0e086238388836d116248cc52b8698d4bb14d33930a7cc0fc6b38", kill_on_drop: false }` [INFO] [stdout] b8e8bae3f1a0e086238388836d116248cc52b8698d4bb14d33930a7cc0fc6b38 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2f80f5ad8b35905311dd55e0cd5d449090f5f6b013bdb9fa02c6265c142b4375 [INFO] running `Command { std: "docker" "start" "-a" "2f80f5ad8b35905311dd55e0cd5d449090f5f6b013bdb9fa02c6265c142b4375", kill_on_drop: false }` [INFO] [stderr] Checking mini_paste-proc_macro v0.1.11 (/opt/rustwide/workdir) [INFO] [stdout] warning: this pattern creates a reference to a reference [INFO] [stdout] --> mod.rs:24:16 [INFO] [stdout] | [INFO] [stdout] 24 | | Err((ref err_msg, span)) => compile_error(err_msg, span), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 24 - | Err((ref err_msg, span)) => compile_error(err_msg, span), [INFO] [stdout] 24 + | Err((err_msg, span)) => compile_error(err_msg, span), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> mod.rs:63:20 [INFO] [stdout] | [INFO] [stdout] 63 | if true [INFO] [stdout] | ____________________^ [INFO] [stdout] 64 | | && group.delimiter() == Delimiter::Bracket [INFO] [stdout] 65 | | && matches!( [INFO] [stdout] 66 | | group.stream().into_iter().next(), [INFO] [stdout] ... | [INFO] [stdout] 69 | | , [INFO] [stdout] 70 | | ) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 63 ~ if group.delimiter() == Delimiter::Bracket && matches!( [INFO] [stdout] 64 + group.stream().into_iter().next(), [INFO] [stdout] 65 + Some(TT::Punct(p)) [INFO] [stdout] 66 + if p.as_char() == '<' [INFO] [stdout] 67 + , [INFO] [stdout] 68 + ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> mod.rs:63:20 [INFO] [stdout] | [INFO] [stdout] 63 | if true [INFO] [stdout] | ____________________^ [INFO] [stdout] 64 | | && group.delimiter() == Delimiter::Bracket [INFO] [stdout] | |__________________________________________________________^ help: try: `group.delimiter() == Delimiter::Bracket` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stdout] --> mod.rs:76:21 [INFO] [stdout] | [INFO] [stdout] 76 | let ref mut ident = String::new(); [INFO] [stdout] | ----^^^^^^^^^^^^^----------------- help: try: `let ident = &mut String::new();` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stdout] = note: `#[warn(clippy::toplevel_ref_arg)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stdout] --> mod.rs:97:29 [INFO] [stdout] | [INFO] [stdout] 97 | let ref s = lit.to_string(); [INFO] [stdout] | ----^^^^^------------------- help: try: `let s = &lit.to_string();` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> mod.rs:166:5 [INFO] [stdout] | [INFO] [stdout] 166 | let _ = tokens.by_ref().take(2).for_each(drop); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 166 - let _ = tokens.by_ref().take(2).for_each(drop); [INFO] [stdout] 166 + tokens.by_ref().take(2).for_each(drop); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> mod.rs:172:5 [INFO] [stdout] | [INFO] [stdout] 172 | let _ = tokens.by_ref().take(2).for_each(drop); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 172 - let _ = tokens.by_ref().take(2).for_each(drop); [INFO] [stdout] 172 + tokens.by_ref().take(2).for_each(drop); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> mod.rs:178:5 [INFO] [stdout] | [INFO] [stdout] 178 | let _ = tokens.by_ref().take(2).for_each(drop); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 178 - let _ = tokens.by_ref().take(2).for_each(drop); [INFO] [stdout] 178 + tokens.by_ref().take(2).for_each(drop); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern creates a reference to a reference [INFO] [stdout] --> mod.rs:185:16 [INFO] [stdout] | [INFO] [stdout] 185 | | Err((ref err_msg, span)) => return compile_error(err_msg, span), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 185 - | Err((ref err_msg, span)) => return compile_error(err_msg, span), [INFO] [stdout] 185 + | Err((err_msg, span)) => return compile_error(err_msg, span), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern creates a reference to a reference [INFO] [stdout] --> mod.rs:24:16 [INFO] [stdout] | [INFO] [stdout] 24 | | Err((ref err_msg, span)) => compile_error(err_msg, span), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 24 - | Err((ref err_msg, span)) => compile_error(err_msg, span), [INFO] [stdout] 24 + | Err((err_msg, span)) => compile_error(err_msg, span), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> mod.rs:63:20 [INFO] [stdout] | [INFO] [stdout] 63 | if true [INFO] [stdout] | ____________________^ [INFO] [stdout] 64 | | && group.delimiter() == Delimiter::Bracket [INFO] [stdout] 65 | | && matches!( [INFO] [stdout] 66 | | group.stream().into_iter().next(), [INFO] [stdout] ... | [INFO] [stdout] 69 | | , [INFO] [stdout] 70 | | ) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 63 ~ if group.delimiter() == Delimiter::Bracket && matches!( [INFO] [stdout] 64 + group.stream().into_iter().next(), [INFO] [stdout] 65 + Some(TT::Punct(p)) [INFO] [stdout] 66 + if p.as_char() == '<' [INFO] [stdout] 67 + , [INFO] [stdout] 68 + ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> mod.rs:63:20 [INFO] [stdout] | [INFO] [stdout] 63 | if true [INFO] [stdout] | ____________________^ [INFO] [stdout] 64 | | && group.delimiter() == Delimiter::Bracket [INFO] [stdout] | |__________________________________________________________^ help: try: `group.delimiter() == Delimiter::Bracket` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stdout] --> mod.rs:76:21 [INFO] [stdout] | [INFO] [stdout] 76 | let ref mut ident = String::new(); [INFO] [stdout] | ----^^^^^^^^^^^^^----------------- help: try: `let ident = &mut String::new();` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stdout] = note: `#[warn(clippy::toplevel_ref_arg)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stdout] --> mod.rs:97:29 [INFO] [stdout] | [INFO] [stdout] 97 | let ref s = lit.to_string(); [INFO] [stdout] | ----^^^^^------------------- help: try: `let s = &lit.to_string();` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> mod.rs:166:5 [INFO] [stdout] | [INFO] [stdout] 166 | let _ = tokens.by_ref().take(2).for_each(drop); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 166 - let _ = tokens.by_ref().take(2).for_each(drop); [INFO] [stdout] 166 + tokens.by_ref().take(2).for_each(drop); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> mod.rs:172:5 [INFO] [stdout] | [INFO] [stdout] 172 | let _ = tokens.by_ref().take(2).for_each(drop); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 172 - let _ = tokens.by_ref().take(2).for_each(drop); [INFO] [stdout] 172 + tokens.by_ref().take(2).for_each(drop); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> mod.rs:178:5 [INFO] [stdout] | [INFO] [stdout] 178 | let _ = tokens.by_ref().take(2).for_each(drop); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 178 - let _ = tokens.by_ref().take(2).for_each(drop); [INFO] [stdout] 178 + tokens.by_ref().take(2).for_each(drop); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern creates a reference to a reference [INFO] [stdout] --> mod.rs:185:16 [INFO] [stdout] | [INFO] [stdout] 185 | | Err((ref err_msg, span)) => return compile_error(err_msg, span), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 185 - | Err((ref err_msg, span)) => return compile_error(err_msg, span), [INFO] [stdout] 185 + | Err((err_msg, span)) => return compile_error(err_msg, span), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.16s [INFO] running `Command { std: "docker" "inspect" "2f80f5ad8b35905311dd55e0cd5d449090f5f6b013bdb9fa02c6265c142b4375", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2f80f5ad8b35905311dd55e0cd5d449090f5f6b013bdb9fa02c6265c142b4375", kill_on_drop: false }` [INFO] [stdout] 2f80f5ad8b35905311dd55e0cd5d449090f5f6b013bdb9fa02c6265c142b4375