[INFO] fetching crate mini_markdown 0.3.5... [INFO] linting mini_markdown-0.3.5 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate mini_markdown 0.3.5 into /workspace/builds/worker-1-tc1/source [INFO] started tweaking crates.io crate mini_markdown 0.3.5 [INFO] finished tweaking crates.io crate mini_markdown 0.3.5 [INFO] tweaked toml for crates.io crate mini_markdown 0.3.5 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate mini_markdown 0.3.5 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4011f16f6c7ad8883510cd490d52a55eba132efb27024d25bd3a0cb68a2a4ad0 [INFO] running `Command { std: "docker" "start" "-a" "4011f16f6c7ad8883510cd490d52a55eba132efb27024d25bd3a0cb68a2a4ad0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4011f16f6c7ad8883510cd490d52a55eba132efb27024d25bd3a0cb68a2a4ad0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4011f16f6c7ad8883510cd490d52a55eba132efb27024d25bd3a0cb68a2a4ad0", kill_on_drop: false }` [INFO] [stdout] 4011f16f6c7ad8883510cd490d52a55eba132efb27024d25bd3a0cb68a2a4ad0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 10576a43295dd0a2e46c0b6d984b8a48559cef629a9824ab4f7c460d5c8b5e0d [INFO] running `Command { std: "docker" "start" "-a" "10576a43295dd0a2e46c0b6d984b8a48559cef629a9824ab4f7c460d5c8b5e0d", kill_on_drop: false }` [INFO] [stderr] Checking mini_markdown v0.3.5 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `tokens` [INFO] [stdout] --> src/lexer.rs:269:62 [INFO] [stdout] | [INFO] [stdout] 269 | pub(crate) fn lex_newlines<'a>(char_iter: &mut MiniIter<'a>, tokens: &Vec) -> Result, ParseError<'a>> { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_tokens` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `tokens` [INFO] [stdout] --> src/lexer.rs:269:62 [INFO] [stdout] | [INFO] [stdout] 269 | pub(crate) fn lex_newlines<'a>(char_iter: &mut MiniIter<'a>, tokens: &Vec) -> Result, ParseError<'a>> { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_tokens` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/lexer.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 73 | / match self { [INFO] [stdout] 74 | | Token::Code(_) => true, [INFO] [stdout] 75 | | Token::Link(_, _, _) => true, [INFO] [stdout] 76 | | Token::Bold(_) => true, [INFO] [stdout] ... | [INFO] [stdout] 80 | | _ => false [INFO] [stdout] 81 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 73 - match self { [INFO] [stdout] 74 - Token::Code(_) => true, [INFO] [stdout] 75 - Token::Link(_, _, _) => true, [INFO] [stdout] 76 - Token::Bold(_) => true, [INFO] [stdout] 77 - Token::Italic(_) => true, [INFO] [stdout] 78 - Token::BoldItalic(_) => true, [INFO] [stdout] 79 - Token::Plaintext(_) => true, [INFO] [stdout] 80 - _ => false [INFO] [stdout] 81 - } [INFO] [stdout] 73 + matches!(self, Token::Code(_) | Token::Link(_, _, _) | Token::Bold(_) | Token::Italic(_) | Token::BoldItalic(_) | Token::Plaintext(_)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:97:32 [INFO] [stdout] | [INFO] [stdout] 97 | Alignment::Left => return write!(f, "left"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 97 - Alignment::Left => return write!(f, "left"), [INFO] [stdout] 97 + Alignment::Left => write!(f, "left"), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:98:33 [INFO] [stdout] | [INFO] [stdout] 98 | Alignment::Right => return write!(f, "right"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 98 - Alignment::Right => return write!(f, "right"), [INFO] [stdout] 98 + Alignment::Right => write!(f, "right"), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:99:34 [INFO] [stdout] | [INFO] [stdout] 99 | Alignment::Center => return write!(f, "center"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 99 - Alignment::Center => return write!(f, "center"), [INFO] [stdout] 99 + Alignment::Center => write!(f, "center"), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/lexer.rs:110:24 [INFO] [stdout] | [INFO] [stdout] 110 | pub(crate) fn push_str<'a>(t: &mut Vec, s: &'a str) { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 110 - pub(crate) fn push_str<'a>(t: &mut Vec, s: &'a str) { [INFO] [stdout] 110 + pub(crate) fn push_str(t: &mut Vec, s: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:150:5 [INFO] [stdout] | [INFO] [stdout] 150 | return Ok(Token::Header(hashes.len(), parsed_line, None)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 150 - return Ok(Token::Header(hashes.len(), parsed_line, None)); [INFO] [stdout] 150 + Ok(Token::Header(hashes.len(), parsed_line, None)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lexer.rs:124:29 [INFO] [stdout] | [INFO] [stdout] 124 | if char_iter.next_if_eq(&" ").is_none() && char_iter.next_if_eq(&"\t").is_none() && char_iter.peek() != Some(&"\n"){ [INFO] [stdout] | ^^^^ help: change this to: `" "` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lexer.rs:124:69 [INFO] [stdout] | [INFO] [stdout] 124 | if char_iter.next_if_eq(&" ").is_none() && char_iter.next_if_eq(&"\t").is_none() && char_iter.peek() != Some(&"\n"){ [INFO] [stdout] | ^^^^^ help: change this to: `"\t"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lexer.rs:124:114 [INFO] [stdout] | [INFO] [stdout] 124 | if char_iter.next_if_eq(&" ").is_none() && char_iter.next_if_eq(&"\t").is_none() && char_iter.peek() != Some(&"\n"){ [INFO] [stdout] | ^^^^^ help: change this to: `"\n"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lexer.rs:131:38 [INFO] [stdout] | [INFO] [stdout] 131 | line = line.strip_prefix(&heading).unwrap() [INFO] [stdout] | ^^^^^^^^ help: change this to: `heading` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lexer.rs:147:106 [INFO] [stdout] | [INFO] [stdout] 147 | let parsed_line = crate::render_ignore(line_without_optional_trailing_hash_sequence.trim_end_matches(&[' ', '\t']), &['#']) [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `[' ', '\t']` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:169:17 [INFO] [stdout] | [INFO] [stdout] 169 | return Ok(Token::Italic(s.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 169 - return Ok(Token::Italic(s.to_string())) [INFO] [stdout] 169 + Ok(Token::Italic(s.to_string())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:171:17 [INFO] [stdout] | [INFO] [stdout] 171 | return Err(ParseError{content: char_iter.get_substring_from(start_index).unwrap_or("")}); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 171 - return Err(ParseError{content: char_iter.get_substring_from(start_index).unwrap_or("")}); [INFO] [stdout] 171 + Err(ParseError{content: char_iter.get_substring_from(start_index).unwrap_or("")}) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:178:17 [INFO] [stdout] | [INFO] [stdout] 178 | return Ok(Token::Bold(s.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 178 - return Ok(Token::Bold(s.to_string())) [INFO] [stdout] 178 + Ok(Token::Bold(s.to_string())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:180:17 [INFO] [stdout] | [INFO] [stdout] 180 | return Err(ParseError{content: char_iter.get_substring_from(start_index).unwrap_or("")}); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 180 - return Err(ParseError{content: char_iter.get_substring_from(start_index).unwrap_or("")}); [INFO] [stdout] 180 + Err(ParseError{content: char_iter.get_substring_from(start_index).unwrap_or("")}) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:187:17 [INFO] [stdout] | [INFO] [stdout] 187 | return Ok(Token::BoldItalic(s.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 187 - return Ok(Token::BoldItalic(s.to_string())) [INFO] [stdout] 187 + Ok(Token::BoldItalic(s.to_string())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:189:17 [INFO] [stdout] | [INFO] [stdout] 189 | return Err(ParseError{content: char_iter.get_substring_from(start_index).unwrap_or("")}); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 189 - return Err(ParseError{content: char_iter.get_substring_from(start_index).unwrap_or("")}); [INFO] [stdout] 189 + Err(ParseError{content: char_iter.get_substring_from(start_index).unwrap_or("")}) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:194:17 [INFO] [stdout] | [INFO] [stdout] 194 | return Ok(Token::HorizontalRule) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 194 - return Ok(Token::HorizontalRule) [INFO] [stdout] 194 + Ok(Token::HorizontalRule) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:196:17 [INFO] [stdout] | [INFO] [stdout] 196 | return Err(ParseError{content: asterunds}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 196 - return Err(ParseError{content: asterunds}) [INFO] [stdout] 196 + Err(ParseError{content: asterunds}) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lexer.rs:156:53 [INFO] [stdout] | [INFO] [stdout] 156 | if asterunds.len() == 1 && char_iter.next_if_eq(&" ").is_some(){ [INFO] [stdout] | ^^^^ help: change this to: `" "` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lexer.rs:161:72 [INFO] [stdout] | [INFO] [stdout] 161 | if asterunds.chars().all(|x| x == '*') && char_iter.peek() == Some(&"\n"){ [INFO] [stdout] | ^^^^^ help: change this to: `"\n"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lexer.rs:167:74 [INFO] [stdout] | [INFO] [stdout] 167 | if char_iter.peek() != Some("*") || char_iter.peek() != Some(&"_"){ [INFO] [stdout] | ^^^^ help: change this to: `"_"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:231:5 [INFO] [stdout] | [INFO] [stdout] 231 | return Err(ParseError{content: char_iter.get_substring_from(start_index).unwrap_or("")}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 231 - return Err(ParseError{content: char_iter.get_substring_from(start_index).unwrap_or("")}) [INFO] [stdout] 231 + Err(ParseError{content: char_iter.get_substring_from(start_index).unwrap_or("")}) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/lexer.rs:220:57 [INFO] [stdout] | [INFO] [stdout] 220 | "\t\t" => return Ok(Token::Code("\t".to_owned()+&line.to_string())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `line` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:256:9 [INFO] [stdout] | [INFO] [stdout] 256 | return Err(ParseError{content: char_iter.get_substring_from(start_index).unwrap_or("")}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 256 - return Err(ParseError{content: char_iter.get_substring_from(start_index).unwrap_or("")}) [INFO] [stdout] 256 + Err(ParseError{content: char_iter.get_substring_from(start_index).unwrap_or("")}) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:262:9 [INFO] [stdout] | [INFO] [stdout] 262 | return Ok(Token::Code(s.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 262 - return Ok(Token::Code(s.to_string())) [INFO] [stdout] 262 + Ok(Token::Code(s.to_string())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lexer.rs:239:47 [INFO] [stdout] | [INFO] [stdout] 239 | if char_iter.next_if_eq("\n") != Some(&"\n") { [INFO] [stdout] | ^^^^^ help: change this to: `"\n"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:271:36 [INFO] [stdout] | [INFO] [stdout] 271 | Some(s) if s.len() >= 2 => return Ok(Token::Newline), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 271 - Some(s) if s.len() >= 2 => return Ok(Token::Newline), [INFO] [stdout] 271 + Some(s) if s.len() >= 2 => Ok(Token::Newline), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:272:35 [INFO] [stdout] | [INFO] [stdout] 272 | Some(s) if s.len() < 2 => return Err(ParseError{content: s}), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 272 - Some(s) if s.len() < 2 => return Err(ParseError{content: s}), [INFO] [stdout] 272 + Some(s) if s.len() < 2 => Err(ParseError{content: s}), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:273:14 [INFO] [stdout] | [INFO] [stdout] 273 | _ => return Err(ParseError{content: ""}), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 273 - _ => return Err(ParseError{content: ""}), [INFO] [stdout] 273 + _ => Err(ParseError{content: ""}), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/lexer.rs:269:70 [INFO] [stdout] | [INFO] [stdout] 269 | pub(crate) fn lex_newlines<'a>(char_iter: &mut MiniIter<'a>, tokens: &Vec) -> Result, ParseError<'a>> { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 269 - pub(crate) fn lex_newlines<'a>(char_iter: &mut MiniIter<'a>, tokens: &Vec) -> Result, ParseError<'a>> { [INFO] [stdout] 269 + pub(crate) fn lex_newlines<'a>(char_iter: &mut MiniIter<'a>, tokens: &[Token]) -> Result, ParseError<'a>> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lexer.rs:284:26 [INFO] [stdout] | [INFO] [stdout] 284 | char_iter.next_if_eq(&"\n"); [INFO] [stdout] | ^^^^^ help: change this to: `"\n"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:295:20 [INFO] [stdout] | [INFO] [stdout] 295 | Err(_e) => return Err(ParseError{content: char_iter.get_substring_from(start_index).unwrap_or("")}), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 295 - Err(_e) => return Err(ParseError{content: char_iter.get_substring_from(start_index).unwrap_or("")}), [INFO] [stdout] 295 + Err(_e) => Err(ParseError{content: char_iter.get_substring_from(start_index).unwrap_or("")}), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:296:44 [INFO] [stdout] | [INFO] [stdout] 296 | Ok(Token::Link(link, title, _)) => return Ok(Token::Image(link.content.to_string(), title)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 296 - Ok(Token::Link(link, title, _)) => return Ok(Token::Image(link.content.to_string(), title)), [INFO] [stdout] 296 + Ok(Token::Link(link, title, _)) => Ok(Token::Image(link.content.to_string(), title)), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:297:14 [INFO] [stdout] | [INFO] [stdout] 297 | _ => return Err(ParseError{content: "Non link token returned from lex_links"}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 297 - _ => return Err(ParseError{content: "Non link token returned from lex_links"}) [INFO] [stdout] 297 + _ => Err(ParseError{content: "Non link token returned from lex_links"}) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lexer.rs:290:42 [INFO] [stdout] | [INFO] [stdout] 290 | if char_iter.next_if_eq("!") != Some(&"!"){ [INFO] [stdout] | ^^^^ help: change this to: `"!"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lexer.rs:303:42 [INFO] [stdout] | [INFO] [stdout] 303 | if char_iter.next_if_eq("[") != Some(&"[") { [INFO] [stdout] | ^^^^ help: change this to: `"["` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lexer.rs:307:42 [INFO] [stdout] | [INFO] [stdout] 307 | if char_iter.next_if_eq("]") != Some(&"]") { [INFO] [stdout] | ^^^^ help: change this to: `"]"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lexer.rs:311:68 [INFO] [stdout] | [INFO] [stdout] 311 | if title.starts_with("^") && char_iter.next_if_eq(":") == Some(&":") { [INFO] [stdout] | ^^^^ help: change this to: `":"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lexer.rs:317:40 [INFO] [stdout] | [INFO] [stdout] 317 | if char_iter.peek() != Some(&" ") && char_iter.peek() != Some(&"\t") { [INFO] [stdout] | ^^^^ help: change this to: `" "` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lexer.rs:317:74 [INFO] [stdout] | [INFO] [stdout] 317 | if char_iter.peek() != Some(&" ") && char_iter.peek() != Some(&"\t") { [INFO] [stdout] | ^^^^^ help: change this to: `"\t"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lexer.rs:320:50 [INFO] [stdout] | [INFO] [stdout] 320 | if char_iter.next_if_eq("\t") == Some(&"\t") { [INFO] [stdout] | ^^^^^ help: change this to: `"\t"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lexer.rs:323:40 [INFO] [stdout] | [INFO] [stdout] 323 | if char_iter.peek() == Some(&" ") { [INFO] [stdout] | ^^^^ help: change this to: `" "` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lexer.rs:338:42 [INFO] [stdout] | [INFO] [stdout] 338 | if char_iter.next_if_eq("(") != Some(&"(") { [INFO] [stdout] | ^^^^ help: change this to: `"("` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lexer.rs:342:33 [INFO] [stdout] | [INFO] [stdout] 342 | if char_iter.peek() != Some(&")") && char_iter.peek() != Some(&" ") { [INFO] [stdout] | ^^^^ help: change this to: `")"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lexer.rs:342:67 [INFO] [stdout] | [INFO] [stdout] 342 | if char_iter.peek() != Some(&")") && char_iter.peek() != Some(&" ") { [INFO] [stdout] | ^^^^ help: change this to: `" "` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lexer.rs:345:42 [INFO] [stdout] | [INFO] [stdout] 345 | if char_iter.next_if_eq(")") == Some(&")") { [INFO] [stdout] | ^^^^ help: change this to: `")"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lexer.rs:348:55 [INFO] [stdout] | [INFO] [stdout] 348 | Err(se) => return Err(ParseError{content: &se.content}), [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `se.content` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lexer.rs:352:33 [INFO] [stdout] | [INFO] [stdout] 352 | if char_iter.peek() == Some(&" ") { [INFO] [stdout] | ^^^^ help: change this to: `" "` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `skip_while(

).next()` on an `Iterator` [INFO] [stdout] --> src/lexer.rs:354:9 [INFO] [stdout] | [INFO] [stdout] 354 | char_iter.skip_while(|c| c != &"\n").next(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: this is more succinctly expressed by calling `.find(!

)` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#skip_while_next [INFO] [stdout] = note: `#[warn(clippy::skip_while_next)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lexer.rs:357:54 [INFO] [stdout] | [INFO] [stdout] 357 | Err(se) => return Err(ParseError{content: &se.content}), [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `se.content` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lexer.rs:371:16 [INFO] [stdout] | [INFO] [stdout] 371 | if !char_iter.next_if_eq(&"\n").is_some(){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `char_iter.next_if_eq(&"\n").is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:374:13 [INFO] [stdout] | [INFO] [stdout] 374 | return parse_details(char_iter) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 374 - return parse_details(char_iter) [INFO] [stdout] 374 + parse_details(char_iter) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:379:51 [INFO] [stdout] | [INFO] [stdout] 379 | Ok(vl) if vl.scheme.is_some() => {return Ok(Token::Link(vl, None, None))} // Auto links require a scheme [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 379 - Ok(vl) if vl.scheme.is_some() => {return Ok(Token::Link(vl, None, None))} // Auto links require a scheme [INFO] [stdout] 379 + Ok(vl) if vl.scheme.is_some() => {Ok(Token::Link(vl, None, None))} // Auto links require a scheme [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:380:23 [INFO] [stdout] | [INFO] [stdout] 380 | _ => {return Err(ParseError{content: char_iter.get_substring_from(start_index).unwrap_or("")})} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 380 - _ => {return Err(ParseError{content: char_iter.get_substring_from(start_index).unwrap_or("")})} [INFO] [stdout] 380 + _ => {Err(ParseError{content: char_iter.get_substring_from(start_index).unwrap_or("")})} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:385:13 [INFO] [stdout] | [INFO] [stdout] 385 | return Err(ParseError{content: "<>"}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 385 - return Err(ParseError{content: "<>"}) [INFO] [stdout] 385 + Err(ParseError{content: "<>"}) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:387:19 [INFO] [stdout] | [INFO] [stdout] 387 | (_, _) => return Err(ParseError{content: s}), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 387 - (_, _) => return Err(ParseError{content: s}), [INFO] [stdout] 387 + (_, _) => Err(ParseError{content: s}), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lexer.rs:370:34 [INFO] [stdout] | [INFO] [stdout] 370 | char_iter.next_if_eq(&"\r"); [INFO] [stdout] | ^^^^^ help: change this to: `"\r"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lexer.rs:371:38 [INFO] [stdout] | [INFO] [stdout] 371 | if !char_iter.next_if_eq(&"\n").is_some(){ [INFO] [stdout] | ^^^^^ help: change this to: `"\n"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to one [INFO] [stdout] --> src/lexer.rs:376:27 [INFO] [stdout] | [INFO] [stdout] 376 | (_, Some(">")) if s.len() >= 1 => { [INFO] [stdout] | ^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!s.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lexer.rs:384:27 [INFO] [stdout] | [INFO] [stdout] 384 | (_, Some(">")) if s.len() == 0 => { [INFO] [stdout] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:410:34 [INFO] [stdout] | [INFO] [stdout] 410 | if line.starts_with(" [ ] "){return Ok(Token::TaskListItem(TaskBox::Unchecked, line[5..].to_string()))} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 410 - if line.starts_with(" [ ] "){return Ok(Token::TaskListItem(TaskBox::Unchecked, line[5..].to_string()))} [INFO] [stdout] 410 + if line.starts_with(" [ ] "){Ok(Token::TaskListItem(TaskBox::Unchecked, line[5..].to_string()))} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:411:68 [INFO] [stdout] | [INFO] [stdout] 411 | ...| line.starts_with(" [X] "){return Ok(Token::TaskListItem(TaskBox::Checked, line[5..].to_string()))} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 411 - else if line.starts_with(" [x] ") || line.starts_with(" [X] "){return Ok(Token::TaskListItem(TaskBox::Checked, line[5..].to_string()))} [INFO] [stdout] 411 + else if line.starts_with(" [x] ") || line.starts_with(" [X] "){Ok(Token::TaskListItem(TaskBox::Checked, line[5..].to_string()))} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:424:9 [INFO] [stdout] | [INFO] [stdout] 424 | return Ok(Token::UnorderedListEntry(list_element_tokens)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 424 - return Ok(Token::UnorderedListEntry(list_element_tokens)) [INFO] [stdout] 424 + Ok(Token::UnorderedListEntry(list_element_tokens)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/lexer.rs:410:84 [INFO] [stdout] | [INFO] [stdout] 410 | if line.starts_with(" [ ] "){return Ok(Token::TaskListItem(TaskBox::Unchecked, line[5..].to_string()))} [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/lexer.rs:410:5 [INFO] [stdout] | [INFO] [stdout] 410 | if line.starts_with(" [ ] "){return Ok(Token::TaskListItem(TaskBox::Unchecked, line[5..].to_string()))} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 410 - if line.starts_with(" [ ] "){return Ok(Token::TaskListItem(TaskBox::Unchecked, line[5..].to_string()))} [INFO] [stdout] 410 + if let Some() = line.strip_prefix(" [ ] ") {return Ok(Token::TaskListItem(TaskBox::Unchecked, .to_string()))} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:437:13 [INFO] [stdout] | [INFO] [stdout] 437 | return Ok(Token::OrderedListEntry(s.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 437 - return Ok(Token::OrderedListEntry(s.to_string())) [INFO] [stdout] 437 + Ok(Token::OrderedListEntry(s.to_string())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:439:14 [INFO] [stdout] | [INFO] [stdout] 439 | _ => return Err(ParseError{content: c}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 439 - _ => return Err(ParseError{content: c}) [INFO] [stdout] 439 + _ => Err(ParseError{content: c}) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lexer.rs:433:50 [INFO] [stdout] | [INFO] [stdout] 433 | if char_iter.next_if_eq(" ") != Some(&" "){ [INFO] [stdout] | ^^^^ help: change this to: `" "` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:450:14 [INFO] [stdout] | [INFO] [stdout] 450 | 1 => return Err(ParseError{content: lead_tildes}), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 450 - 1 => return Err(ParseError{content: lead_tildes}), [INFO] [stdout] 450 + 1 => Err(ParseError{content: lead_tildes}), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:457:13 [INFO] [stdout] | [INFO] [stdout] 457 | return Ok(Token::Strikethrough(line.to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 457 - return Ok(Token::Strikethrough(line.to_string())); [INFO] [stdout] 457 + Ok(Token::Strikethrough(line.to_string())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:459:14 [INFO] [stdout] | [INFO] [stdout] 459 | _ => return Err(ParseError{content: lead_tildes}), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 459 - _ => return Err(ParseError{content: lead_tildes}), [INFO] [stdout] 459 + _ => Err(ParseError{content: lead_tildes}), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lexer.rs:490:32 [INFO] [stdout] | [INFO] [stdout] 490 | while char_iter.next_if_eq(&"|") == Some("|") { [INFO] [stdout] | ^^^^ help: change this to: `"|"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/lexer.rs:501:22 [INFO] [stdout] | [INFO] [stdout] 501 | .filter(|&x| x != "") [INFO] [stdout] | ^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!x.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/lexer.rs:505:22 [INFO] [stdout] | [INFO] [stdout] 505 | .filter(|&x| x != "") [INFO] [stdout] | ^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!x.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/lexer.rs:519:22 [INFO] [stdout] | [INFO] [stdout] 519 | .filter(|&x| x != "") [INFO] [stdout] | ^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!x.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lexer.rs:524:47 [INFO] [stdout] | [INFO] [stdout] 524 | let mut inner_tokens = crate::lex(&e, &[]); [INFO] [stdout] | ^^ help: change this to: `e` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/lexer.rs:528:54 [INFO] [stdout] | [INFO] [stdout] 528 | rows.push(alignments.clone().into_iter().zip(r.into_iter()).collect()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 528 - rows.push(alignments.clone().into_iter().zip(r.into_iter()).collect()); [INFO] [stdout] 528 + rows.push(alignments.clone().into_iter().zip(r).collect()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/lexer.rs:530:48 [INFO] [stdout] | [INFO] [stdout] 530 | Ok(Token::Table(alignments.into_iter().zip(headings.into_iter()).collect(), rows)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 530 - Ok(Token::Table(alignments.into_iter().zip(headings.into_iter()).collect(), rows)) [INFO] [stdout] 530 + Ok(Token::Table(alignments.into_iter().zip(headings).collect(), rows)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/iter.rs:97:36 [INFO] [stdout] | [INFO] [stdout] 97 | Some(newline_index) => return self.the_str.get(self.index..=(self.index+newline_index)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 97 - Some(newline_index) => return self.the_str.get(self.index..=(self.index+newline_index)), [INFO] [stdout] 97 + Some(newline_index) => self.the_str.get(self.index..=(self.index+newline_index)), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/iter.rs:98:46 [INFO] [stdout] | [INFO] [stdout] 98 | None if self.peek().is_some() => return self.the_str.get(self.index..=(self.the_str.len()-1)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 98 - None if self.peek().is_some() => return self.the_str.get(self.index..=(self.the_str.len()-1)), [INFO] [stdout] 98 + None if self.peek().is_some() => self.the_str.get(self.index..=(self.the_str.len()-1)), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/iter.rs:108:17 [INFO] [stdout] | [INFO] [stdout] 108 | return ret [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 108 - return ret [INFO] [stdout] 108 + ret [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/iter.rs:113:17 [INFO] [stdout] | [INFO] [stdout] 113 | return ret [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 113 - return ret [INFO] [stdout] 113 + ret [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/lexer.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 73 | / match self { [INFO] [stdout] 74 | | Token::Code(_) => true, [INFO] [stdout] 75 | | Token::Link(_, _, _) => true, [INFO] [stdout] 76 | | Token::Bold(_) => true, [INFO] [stdout] ... | [INFO] [stdout] 80 | | _ => false [INFO] [stdout] 81 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 73 - match self { [INFO] [stdout] 74 - Token::Code(_) => true, [INFO] [stdout] 75 - Token::Link(_, _, _) => true, [INFO] [stdout] 76 - Token::Bold(_) => true, [INFO] [stdout] 77 - Token::Italic(_) => true, [INFO] [stdout] 78 - Token::BoldItalic(_) => true, [INFO] [stdout] 79 - Token::Plaintext(_) => true, [INFO] [stdout] 80 - _ => false [INFO] [stdout] 81 - } [INFO] [stdout] 73 + matches!(self, Token::Code(_) | Token::Link(_, _, _) | Token::Bold(_) | Token::Italic(_) | Token::BoldItalic(_) | Token::Plaintext(_)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:97:32 [INFO] [stdout] | [INFO] [stdout] 97 | Alignment::Left => return write!(f, "left"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 97 - Alignment::Left => return write!(f, "left"), [INFO] [stdout] 97 + Alignment::Left => write!(f, "left"), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:29:22 [INFO] [stdout] | [INFO] [stdout] 29 | None => {return format!("http:{}", amp_replace_content)}, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - None => {return format!("http:{}", amp_replace_content)}, [INFO] [stdout] 29 + None => {format!("http:{}", amp_replace_content)}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:30:41 [INFO] [stdout] | [INFO] [stdout] 30 | Some(Scheme::Email(_s)) => {return format!("{}", amp_replace_content)}, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - Some(Scheme::Email(_s)) => {return format!("{}", amp_replace_content)}, [INFO] [stdout] 30 + Some(Scheme::Email(_s)) => {format!("{}", amp_replace_content)}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:31:25 [INFO] [stdout] | [INFO] [stdout] 31 | Some(s) => {return format!("{}:{}", s, amp_replace_content)}, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 31 - Some(s) => {return format!("{}:{}", s, amp_replace_content)}, [INFO] [stdout] 31 + Some(s) => {format!("{}:{}", s, amp_replace_content)}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/lib.rs:30:48 [INFO] [stdout] | [INFO] [stdout] 30 | Some(Scheme::Email(_s)) => {return format!("{}", amp_replace_content)}, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `amp_replace_content.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:98:33 [INFO] [stdout] | [INFO] [stdout] 98 | Alignment::Right => return write!(f, "right"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 98 - Alignment::Right => return write!(f, "right"), [INFO] [stdout] 98 + Alignment::Right => write!(f, "right"), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:99:34 [INFO] [stdout] | [INFO] [stdout] 99 | Alignment::Center => return write!(f, "center"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 99 - Alignment::Center => return write!(f, "center"), [INFO] [stdout] 99 + Alignment::Center => write!(f, "center"), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:40:22 [INFO] [stdout] | [INFO] [stdout] 40 | None => {return write!(f, "http:{}", percent_encode(self.content).replace('&', "&"))}, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - None => {return write!(f, "http:{}", percent_encode(self.content).replace('&', "&"))}, [INFO] [stdout] 40 + None => {write!(f, "http:{}", percent_encode(self.content).replace('&', "&"))}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/lexer.rs:110:24 [INFO] [stdout] | [INFO] [stdout] 110 | pub(crate) fn push_str<'a>(t: &mut Vec, s: &'a str) { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 110 - pub(crate) fn push_str<'a>(t: &mut Vec, s: &'a str) { [INFO] [stdout] 110 + pub(crate) fn push_str(t: &mut Vec, s: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:41:25 [INFO] [stdout] | [INFO] [stdout] 41 | Some(s) => {return write!(f, "{}:{}", s, percent_encode(self.content).replace('&', "&"))}, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 41 - Some(s) => {return write!(f, "{}:{}", s, percent_encode(self.content).replace('&', "&"))}, [INFO] [stdout] 41 + Some(s) => {write!(f, "{}:{}", s, percent_encode(self.content).replace('&', "&"))}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:150:5 [INFO] [stdout] | [INFO] [stdout] 150 | return Ok(Token::Header(hashes.len(), parsed_line, None)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 150 - return Ok(Token::Header(hashes.len(), parsed_line, None)); [INFO] [stdout] 150 + Ok(Token::Header(hashes.len(), parsed_line, None)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lexer.rs:124:29 [INFO] [stdout] | [INFO] [stdout] 124 | if char_iter.next_if_eq(&" ").is_none() && char_iter.next_if_eq(&"\t").is_none() && char_iter.peek() != Some(&"\n"){ [INFO] [stdout] | ^^^^ help: change this to: `" "` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lexer.rs:124:69 [INFO] [stdout] | [INFO] [stdout] 124 | if char_iter.next_if_eq(&" ").is_none() && char_iter.next_if_eq(&"\t").is_none() && char_iter.peek() != Some(&"\n"){ [INFO] [stdout] | ^^^^^ help: change this to: `"\t"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lexer.rs:124:114 [INFO] [stdout] | [INFO] [stdout] 124 | if char_iter.next_if_eq(&" ").is_none() && char_iter.next_if_eq(&"\t").is_none() && char_iter.peek() != Some(&"\n"){ [INFO] [stdout] | ^^^^^ help: change this to: `"\n"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lexer.rs:131:38 [INFO] [stdout] | [INFO] [stdout] 131 | line = line.strip_prefix(&heading).unwrap() [INFO] [stdout] | ^^^^^^^^ help: change this to: `heading` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:57:33 [INFO] [stdout] | [INFO] [stdout] 57 | Scheme::Http(s) => {return write!(f, "{}", s)}, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 57 - Scheme::Http(s) => {return write!(f, "{}", s)}, [INFO] [stdout] 57 + Scheme::Http(s) => {write!(f, "{}", s)}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:58:34 [INFO] [stdout] | [INFO] [stdout] 58 | Scheme::Email(s) => {return write!(f, "{}", s)}, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 58 - Scheme::Email(s) => {return write!(f, "{}", s)}, [INFO] [stdout] 58 + Scheme::Email(s) => {write!(f, "{}", s)}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:59:32 [INFO] [stdout] | [INFO] [stdout] 59 | Scheme::Irc(s) => {return write!(f, "{}", s)}, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 - Scheme::Irc(s) => {return write!(f, "{}", s)}, [INFO] [stdout] 59 + Scheme::Irc(s) => {write!(f, "{}", s)}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:60:34 [INFO] [stdout] | [INFO] [stdout] 60 | Scheme::Other(s) => {return write!(f, "{}", s)}, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 60 - Scheme::Other(s) => {return write!(f, "{}", s)}, [INFO] [stdout] 60 + Scheme::Other(s) => {write!(f, "{}", s)}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lexer.rs:147:106 [INFO] [stdout] | [INFO] [stdout] 147 | let parsed_line = crate::render_ignore(line_without_optional_trailing_hash_sequence.trim_end_matches(&[' ', '\t']), &['#']) [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `[' ', '\t']` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:169:17 [INFO] [stdout] | [INFO] [stdout] 169 | return Ok(Token::Italic(s.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 169 - return Ok(Token::Italic(s.to_string())) [INFO] [stdout] 169 + Ok(Token::Italic(s.to_string())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:171:17 [INFO] [stdout] | [INFO] [stdout] 171 | return Err(ParseError{content: char_iter.get_substring_from(start_index).unwrap_or("")}); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 171 - return Err(ParseError{content: char_iter.get_substring_from(start_index).unwrap_or("")}); [INFO] [stdout] 171 + Err(ParseError{content: char_iter.get_substring_from(start_index).unwrap_or("")}) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:178:17 [INFO] [stdout] | [INFO] [stdout] 178 | return Ok(Token::Bold(s.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 178 - return Ok(Token::Bold(s.to_string())) [INFO] [stdout] 178 + Ok(Token::Bold(s.to_string())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:180:17 [INFO] [stdout] | [INFO] [stdout] 180 | return Err(ParseError{content: char_iter.get_substring_from(start_index).unwrap_or("")}); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 180 - return Err(ParseError{content: char_iter.get_substring_from(start_index).unwrap_or("")}); [INFO] [stdout] 180 + Err(ParseError{content: char_iter.get_substring_from(start_index).unwrap_or("")}) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:187:17 [INFO] [stdout] | [INFO] [stdout] 187 | return Ok(Token::BoldItalic(s.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 187 - return Ok(Token::BoldItalic(s.to_string())) [INFO] [stdout] 187 + Ok(Token::BoldItalic(s.to_string())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:189:17 [INFO] [stdout] | [INFO] [stdout] 189 | return Err(ParseError{content: char_iter.get_substring_from(start_index).unwrap_or("")}); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 189 - return Err(ParseError{content: char_iter.get_substring_from(start_index).unwrap_or("")}); [INFO] [stdout] 189 + Err(ParseError{content: char_iter.get_substring_from(start_index).unwrap_or("")}) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:194:17 [INFO] [stdout] | [INFO] [stdout] 194 | return Ok(Token::HorizontalRule) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 194 - return Ok(Token::HorizontalRule) [INFO] [stdout] 194 + Ok(Token::HorizontalRule) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:196:17 [INFO] [stdout] | [INFO] [stdout] 196 | return Err(ParseError{content: asterunds}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 196 - return Err(ParseError{content: asterunds}) [INFO] [stdout] 196 + Err(ParseError{content: asterunds}) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lexer.rs:156:53 [INFO] [stdout] | [INFO] [stdout] 156 | if asterunds.len() == 1 && char_iter.next_if_eq(&" ").is_some(){ [INFO] [stdout] | ^^^^ help: change this to: `" "` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lexer.rs:161:72 [INFO] [stdout] | [INFO] [stdout] 161 | if asterunds.chars().all(|x| x == '*') && char_iter.peek() == Some(&"\n"){ [INFO] [stdout] | ^^^^^ help: change this to: `"\n"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:154:45 [INFO] [stdout] | [INFO] [stdout] 154 | if char_iter.peek() == Some(&"#"){ [INFO] [stdout] | ^^^^ help: change this to: `"#"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lexer.rs:167:74 [INFO] [stdout] | [INFO] [stdout] 167 | if char_iter.peek() != Some("*") || char_iter.peek() != Some(&"_"){ [INFO] [stdout] | ^^^^ help: change this to: `"_"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:231:5 [INFO] [stdout] | [INFO] [stdout] 231 | return Err(ParseError{content: char_iter.get_substring_from(start_index).unwrap_or("")}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 231 - return Err(ParseError{content: char_iter.get_substring_from(start_index).unwrap_or("")}) [INFO] [stdout] 231 + Err(ParseError{content: char_iter.get_substring_from(start_index).unwrap_or("")}) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: attempt to mutate range bound within loop [INFO] [stdout] --> src/lib.rs:227:25 [INFO] [stdout] | [INFO] [stdout] 227 | quote_level-=1; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the range of the loop is unchanged [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_range_bound [INFO] [stdout] = note: `#[warn(clippy::mut_range_bound)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/lexer.rs:220:57 [INFO] [stdout] | [INFO] [stdout] 220 | "\t\t" => return Ok(Token::Code("\t".to_owned()+&line.to_string())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `line` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:256:9 [INFO] [stdout] | [INFO] [stdout] 256 | return Err(ParseError{content: char_iter.get_substring_from(start_index).unwrap_or("")}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 256 - return Err(ParseError{content: char_iter.get_substring_from(start_index).unwrap_or("")}) [INFO] [stdout] 256 + Err(ParseError{content: char_iter.get_substring_from(start_index).unwrap_or("")}) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:262:9 [INFO] [stdout] | [INFO] [stdout] 262 | return Ok(Token::Code(s.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 262 - return Ok(Token::Code(s.to_string())) [INFO] [stdout] 262 + Ok(Token::Code(s.to_string())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lexer.rs:239:47 [INFO] [stdout] | [INFO] [stdout] 239 | if char_iter.next_if_eq("\n") != Some(&"\n") { [INFO] [stdout] | ^^^^^ help: change this to: `"\n"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/lib.rs:285:20 [INFO] [stdout] | [INFO] [stdout] 285 | if in_task_list == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `!in_task_list` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/lib.rs:300:20 [INFO] [stdout] | [INFO] [stdout] 300 | if in_unordered_list == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!in_unordered_list` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/lib.rs:305:31 [INFO] [stdout] | [INFO] [stdout] 305 | html.push_str(format!("

  • ").as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"
  • ".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:271:36 [INFO] [stdout] | [INFO] [stdout] 271 | Some(s) if s.len() >= 2 => return Ok(Token::Newline), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 271 - Some(s) if s.len() >= 2 => return Ok(Token::Newline), [INFO] [stdout] 271 + Some(s) if s.len() >= 2 => Ok(Token::Newline), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:272:35 [INFO] [stdout] | [INFO] [stdout] 272 | Some(s) if s.len() < 2 => return Err(ParseError{content: s}), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 272 - Some(s) if s.len() < 2 => return Err(ParseError{content: s}), [INFO] [stdout] 272 + Some(s) if s.len() < 2 => Err(ParseError{content: s}), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` [INFO] [stdout] --> src/lib.rs:306:25 [INFO] [stdout] | [INFO] [stdout] 306 | if toks.into_iter().all(|t| matches!(t, Token::Plaintext(_))) {html.push_str(format!("\n").as_str());} [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:273:14 [INFO] [stdout] | [INFO] [stdout] 273 | _ => return Err(ParseError{content: ""}), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 273 - _ => return Err(ParseError{content: ""}), [INFO] [stdout] 273 + _ => Err(ParseError{content: ""}), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/lib.rs:306:94 [INFO] [stdout] | [INFO] [stdout] 306 | if toks.into_iter().all(|t| matches!(t, Token::Plaintext(_))) {html.push_str(format!("\n").as_str());} [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/lexer.rs:269:70 [INFO] [stdout] | [INFO] [stdout] 269 | pub(crate) fn lex_newlines<'a>(char_iter: &mut MiniIter<'a>, tokens: &Vec) -> Result, ParseError<'a>> { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 269 - pub(crate) fn lex_newlines<'a>(char_iter: &mut MiniIter<'a>, tokens: &Vec) -> Result, ParseError<'a>> { [INFO] [stdout] 269 + pub(crate) fn lex_newlines<'a>(char_iter: &mut MiniIter<'a>, tokens: &[Token]) -> Result, ParseError<'a>> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lexer.rs:284:26 [INFO] [stdout] | [INFO] [stdout] 284 | char_iter.next_if_eq(&"\n"); [INFO] [stdout] | ^^^^^ help: change this to: `"\n"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:310:51 [INFO] [stdout] | [INFO] [stdout] 310 | ... html.push_str(&render(&text[1..].trim_start_matches(" ")).replace("
    ", "
      "));  
[INFO] [stdout]     |                                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `text[1..].trim_start_matches(" ")`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/lib.rs:313:48
[INFO] [stdout]     |
[INFO] [stdout] 313 | ...                   let text = &render(&text.trim_start_matches(" ")).replace("
    ", "
      ");
[INFO] [stdout]     |                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `text.trim_start_matches(" ")`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]    --> src/lib.rs:319:31
[INFO] [stdout]     |
[INFO] [stdout] 319 |                 html.push_str(format!("
    • \n").as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:295:20 [INFO] [stdout] | [INFO] [stdout] 295 | Err(_e) => return Err(ParseError{content: char_iter.get_substring_from(start_index).unwrap_or("")}), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 295 - Err(_e) => return Err(ParseError{content: char_iter.get_substring_from(start_index).unwrap_or("")}), [INFO] [stdout] 295 + Err(_e) => Err(ParseError{content: char_iter.get_substring_from(start_index).unwrap_or("")}), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:296:44 [INFO] [stdout] | [INFO] [stdout] 296 | Ok(Token::Link(link, title, _)) => return Ok(Token::Image(link.content.to_string(), title)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 296 - Ok(Token::Link(link, title, _)) => return Ok(Token::Image(link.content.to_string(), title)), [INFO] [stdout] 296 + Ok(Token::Link(link, title, _)) => Ok(Token::Image(link.content.to_string(), title)), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/lib.rs:322:20 [INFO] [stdout] | [INFO] [stdout] 322 | if in_ordered_list == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!in_ordered_list` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:297:14 [INFO] [stdout] | [INFO] [stdout] 297 | _ => return Err(ParseError{content: "Non link token returned from lex_links"}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 297 - _ => return Err(ParseError{content: "Non link token returned from lex_links"}) [INFO] [stdout] 297 + _ => Err(ParseError{content: "Non link token returned from lex_links"}) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/lib.rs:324:35 [INFO] [stdout] | [INFO] [stdout] 324 | html.push_str(format!("
      \n").as_str()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"
        \n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lexer.rs:290:42 [INFO] [stdout] | [INFO] [stdout] 290 | if char_iter.next_if_eq("!") != Some(&"!"){ [INFO] [stdout] | ^^^^ help: change this to: `"!"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lexer.rs:303:42 [INFO] [stdout] | [INFO] [stdout] 303 | if char_iter.next_if_eq("[") != Some(&"[") { [INFO] [stdout] | ^^^^ help: change this to: `"["` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lexer.rs:307:42 [INFO] [stdout] | [INFO] [stdout] 307 | if char_iter.next_if_eq("]") != Some(&"]") { [INFO] [stdout] | ^^^^ help: change this to: `"]"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/lib.rs:338:31 [INFO] [stdout] | [INFO] [stdout] 338 | html.push_str(format!("{}", sanitize_display_text(t)).as_str())}, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `sanitize_display_text(t).to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lexer.rs:311:68 [INFO] [stdout] | [INFO] [stdout] 311 | if title.starts_with("^") && char_iter.next_if_eq(":") == Some(&":") { [INFO] [stdout] | ^^^^ help: change this to: `":"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lexer.rs:317:40 [INFO] [stdout] | [INFO] [stdout] 317 | if char_iter.peek() != Some(&" ") && char_iter.peek() != Some(&"\t") { [INFO] [stdout] | ^^^^ help: change this to: `" "` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lexer.rs:317:74 [INFO] [stdout] | [INFO] [stdout] 317 | if char_iter.peek() != Some(&" ") && char_iter.peek() != Some(&"\t") { [INFO] [stdout] | ^^^^^ help: change this to: `"\t"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lexer.rs:320:50 [INFO] [stdout] | [INFO] [stdout] 320 | if char_iter.next_if_eq("\t") == Some(&"\t") { [INFO] [stdout] | ^^^^^ help: change this to: `"\t"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lexer.rs:323:40 [INFO] [stdout] | [INFO] [stdout] 323 | if char_iter.peek() == Some(&" ") { [INFO] [stdout] | ^^^^ help: change this to: `" "` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:376:56 [INFO] [stdout] | [INFO] [stdout] 376 | &render(&sanitize_display_text(&t.trim_start_matches(" "))).replace("\t", " ") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `t.trim_start_matches(" ")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lexer.rs:338:42 [INFO] [stdout] | [INFO] [stdout] 338 | if char_iter.next_if_eq("(") != Some(&"(") { [INFO] [stdout] | ^^^^ help: change this to: `"("` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lexer.rs:342:33 [INFO] [stdout] | [INFO] [stdout] 342 | if char_iter.peek() != Some(&")") && char_iter.peek() != Some(&" ") { [INFO] [stdout] | ^^^^ help: change this to: `")"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lexer.rs:342:67 [INFO] [stdout] | [INFO] [stdout] 342 | if char_iter.peek() != Some(&")") && char_iter.peek() != Some(&" ") { [INFO] [stdout] | ^^^^ help: change this to: `" "` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lexer.rs:345:42 [INFO] [stdout] | [INFO] [stdout] 345 | if char_iter.next_if_eq(")") == Some(&")") { [INFO] [stdout] | ^^^^ help: change this to: `")"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lexer.rs:348:55 [INFO] [stdout] | [INFO] [stdout] 348 | Err(se) => return Err(ParseError{content: &se.content}), [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `se.content` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lexer.rs:352:33 [INFO] [stdout] | [INFO] [stdout] 352 | if char_iter.peek() == Some(&" ") { [INFO] [stdout] | ^^^^ help: change this to: `" "` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `skip_while(

        ).next()` on an `Iterator` [INFO] [stdout] --> src/lexer.rs:354:9 [INFO] [stdout] | [INFO] [stdout] 354 | char_iter.skip_while(|c| c != &"\n").next(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: this is more succinctly expressed by calling `.find(!

        )` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#skip_while_next [INFO] [stdout] = note: `#[warn(clippy::skip_while_next)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lexer.rs:357:54 [INFO] [stdout] | [INFO] [stdout] 357 | Err(se) => return Err(ParseError{content: &se.content}), [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `se.content` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lexer.rs:371:16 [INFO] [stdout] | [INFO] [stdout] 371 | if !char_iter.next_if_eq(&"\n").is_some(){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `char_iter.next_if_eq(&"\n").is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:374:13 [INFO] [stdout] | [INFO] [stdout] 374 | return parse_details(char_iter) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 374 - return parse_details(char_iter) [INFO] [stdout] 374 + parse_details(char_iter) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:379:51 [INFO] [stdout] | [INFO] [stdout] 379 | Ok(vl) if vl.scheme.is_some() => {return Ok(Token::Link(vl, None, None))} // Auto links require a scheme [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 379 - Ok(vl) if vl.scheme.is_some() => {return Ok(Token::Link(vl, None, None))} // Auto links require a scheme [INFO] [stdout] 379 + Ok(vl) if vl.scheme.is_some() => {Ok(Token::Link(vl, None, None))} // Auto links require a scheme [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:380:23 [INFO] [stdout] | [INFO] [stdout] 380 | _ => {return Err(ParseError{content: char_iter.get_substring_from(start_index).unwrap_or("")})} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 380 - _ => {return Err(ParseError{content: char_iter.get_substring_from(start_index).unwrap_or("")})} [INFO] [stdout] 380 + _ => {Err(ParseError{content: char_iter.get_substring_from(start_index).unwrap_or("")})} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:385:13 [INFO] [stdout] | [INFO] [stdout] 385 | return Err(ParseError{content: "<>"}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 385 - return Err(ParseError{content: "<>"}) [INFO] [stdout] 385 + Err(ParseError{content: "<>"}) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:387:19 [INFO] [stdout] | [INFO] [stdout] 387 | (_, _) => return Err(ParseError{content: s}), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 387 - (_, _) => return Err(ParseError{content: s}), [INFO] [stdout] 387 + (_, _) => Err(ParseError{content: s}), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` [INFO] [stdout] --> src/lib.rs:408:35 [INFO] [stdout] | [INFO] [stdout] 408 | for h in headings.into_iter() { [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lexer.rs:370:34 [INFO] [stdout] | [INFO] [stdout] 370 | char_iter.next_if_eq(&"\r"); [INFO] [stdout] | ^^^^^ help: change this to: `"\r"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lexer.rs:371:38 [INFO] [stdout] | [INFO] [stdout] 371 | if !char_iter.next_if_eq(&"\n").is_some(){ [INFO] [stdout] | ^^^^^ help: change this to: `"\n"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:418:95 [INFO] [stdout] | [INFO] [stdout] 418 | ... Token::Plaintext(s) => row_string.push_str(&sanitize_display_text(&s)), [INFO] [stdout] | ^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to one [INFO] [stdout] --> src/lexer.rs:376:27 [INFO] [stdout] | [INFO] [stdout] 376 | (_, Some(">")) if s.len() >= 1 => { [INFO] [stdout] | ^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!s.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lexer.rs:384:27 [INFO] [stdout] | [INFO] [stdout] 384 | (_, Some(">")) if s.len() == 0 => { [INFO] [stdout] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:410:34 [INFO] [stdout] | [INFO] [stdout] 410 | if line.starts_with(" [ ] "){return Ok(Token::TaskListItem(TaskBox::Unchecked, line[5..].to_string()))} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 410 - if line.starts_with(" [ ] "){return Ok(Token::TaskListItem(TaskBox::Unchecked, line[5..].to_string()))} [INFO] [stdout] 410 + if line.starts_with(" [ ] "){Ok(Token::TaskListItem(TaskBox::Unchecked, line[5..].to_string()))} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:411:68 [INFO] [stdout] | [INFO] [stdout] 411 | ...| line.starts_with(" [X] "){return Ok(Token::TaskListItem(TaskBox::Checked, line[5..].to_string()))} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 411 - else if line.starts_with(" [x] ") || line.starts_with(" [X] "){return Ok(Token::TaskListItem(TaskBox::Checked, line[5..].to_string()))} [INFO] [stdout] 411 + else if line.starts_with(" [x] ") || line.starts_with(" [X] "){Ok(Token::TaskListItem(TaskBox::Checked, line[5..].to_string()))} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:424:9 [INFO] [stdout] | [INFO] [stdout] 424 | return Ok(Token::UnorderedListEntry(list_element_tokens)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 424 - return Ok(Token::UnorderedListEntry(list_element_tokens)) [INFO] [stdout] 424 + Ok(Token::UnorderedListEntry(list_element_tokens)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/lexer.rs:410:84 [INFO] [stdout] | [INFO] [stdout] 410 | if line.starts_with(" [ ] "){return Ok(Token::TaskListItem(TaskBox::Unchecked, line[5..].to_string()))} [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/lexer.rs:410:5 [INFO] [stdout] | [INFO] [stdout] 410 | if line.starts_with(" [ ] "){return Ok(Token::TaskListItem(TaskBox::Unchecked, line[5..].to_string()))} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 410 - if line.starts_with(" [ ] "){return Ok(Token::TaskListItem(TaskBox::Unchecked, line[5..].to_string()))} [INFO] [stdout] 410 + if let Some() = line.strip_prefix(" [ ] ") {return Ok(Token::TaskListItem(TaskBox::Unchecked, .to_string()))} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:464:8 [INFO] [stdout] | [INFO] [stdout] 464 | if references.len() > 0{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!references.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:437:13 [INFO] [stdout] | [INFO] [stdout] 437 | return Ok(Token::OrderedListEntry(s.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 437 - return Ok(Token::OrderedListEntry(s.to_string())) [INFO] [stdout] 437 + Ok(Token::OrderedListEntry(s.to_string())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:439:14 [INFO] [stdout] | [INFO] [stdout] 439 | _ => return Err(ParseError{content: c}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 439 - _ => return Err(ParseError{content: c}) [INFO] [stdout] 439 + _ => Err(ParseError{content: c}) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lexer.rs:433:50 [INFO] [stdout] | [INFO] [stdout] 433 | if char_iter.next_if_eq(" ") != Some(&" "){ [INFO] [stdout] | ^^^^ help: change this to: `" "` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:450:14 [INFO] [stdout] | [INFO] [stdout] 450 | 1 => return Err(ParseError{content: lead_tildes}), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 450 - 1 => return Err(ParseError{content: lead_tildes}), [INFO] [stdout] 450 + 1 => Err(ParseError{content: lead_tildes}), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:537:8 [INFO] [stdout] | [INFO] [stdout] 537 | if scheme.len() != 0 && ( scheme.len() < 2 || scheme.len() > 32 ) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!scheme.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:457:13 [INFO] [stdout] | [INFO] [stdout] 457 | return Ok(Token::Strikethrough(line.to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 457 - return Ok(Token::Strikethrough(line.to_string())); [INFO] [stdout] 457 + Ok(Token::Strikethrough(line.to_string())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:459:14 [INFO] [stdout] | [INFO] [stdout] 459 | _ => return Err(ParseError{content: lead_tildes}), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 459 - _ => return Err(ParseError{content: lead_tildes}), [INFO] [stdout] 459 + _ => Err(ParseError{content: lead_tildes}), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:561:105 [INFO] [stdout] | [INFO] [stdout] 561 | ...lto"))), content: &source.split(":").last().unwrap()}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `source.split(":").last().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:563:101 [INFO] [stdout] | [INFO] [stdout] 563 | return Ok(ValidURL{scheme: Some(source_scheme.unwrap_or(Scheme::Email("mailto"))), content: &source}) [INFO] [stdout] | ^^^^^^^ help: change this to: `source` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lexer.rs:490:32 [INFO] [stdout] | [INFO] [stdout] 490 | while char_iter.next_if_eq(&"|") == Some("|") { [INFO] [stdout] | ^^^^ help: change this to: `"|"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/lexer.rs:501:22 [INFO] [stdout] | [INFO] [stdout] 501 | .filter(|&x| x != "") [INFO] [stdout] | ^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!x.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/lib.rs:526:37 [INFO] [stdout] | [INFO] [stdout] 526 | pub(crate) fn validate_link(source: &str) -> Result { [INFO] [stdout] | ^^^^ ^^^^^^^^ ^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | | [INFO] [stdout] | | the same lifetime is hidden here [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 526 | pub(crate) fn validate_link(source: &str) -> Result, SanitizationError<'_>> { [INFO] [stdout] | ++++ ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/lexer.rs:505:22 [INFO] [stdout] | [INFO] [stdout] 505 | .filter(|&x| x != "") [INFO] [stdout] | ^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!x.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/lexer.rs:519:22 [INFO] [stdout] | [INFO] [stdout] 519 | .filter(|&x| x != "") [INFO] [stdout] | ^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!x.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lexer.rs:524:47 [INFO] [stdout] | [INFO] [stdout] 524 | let mut inner_tokens = crate::lex(&e, &[]); [INFO] [stdout] | ^^ help: change this to: `e` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/lexer.rs:528:54 [INFO] [stdout] | [INFO] [stdout] 528 | rows.push(alignments.clone().into_iter().zip(r.into_iter()).collect()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 528 - rows.push(alignments.clone().into_iter().zip(r.into_iter()).collect()); [INFO] [stdout] 528 + rows.push(alignments.clone().into_iter().zip(r).collect()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/lexer.rs:530:48 [INFO] [stdout] | [INFO] [stdout] 530 | Ok(Token::Table(alignments.into_iter().zip(headings.into_iter()).collect(), rows)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 530 - Ok(Token::Table(alignments.into_iter().zip(headings.into_iter()).collect(), rows)) [INFO] [stdout] 530 + Ok(Token::Table(alignments.into_iter().zip(headings).collect(), rows)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/iter.rs:97:36 [INFO] [stdout] | [INFO] [stdout] 97 | Some(newline_index) => return self.the_str.get(self.index..=(self.index+newline_index)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 97 - Some(newline_index) => return self.the_str.get(self.index..=(self.index+newline_index)), [INFO] [stdout] 97 + Some(newline_index) => self.the_str.get(self.index..=(self.index+newline_index)), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/iter.rs:98:46 [INFO] [stdout] | [INFO] [stdout] 98 | None if self.peek().is_some() => return self.the_str.get(self.index..=(self.the_str.len()-1)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 98 - None if self.peek().is_some() => return self.the_str.get(self.index..=(self.the_str.len()-1)), [INFO] [stdout] 98 + None if self.peek().is_some() => self.the_str.get(self.index..=(self.the_str.len()-1)), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/iter.rs:108:17 [INFO] [stdout] | [INFO] [stdout] 108 | return ret [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 108 - return ret [INFO] [stdout] 108 + ret [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/iter.rs:113:17 [INFO] [stdout] | [INFO] [stdout] 113 | return ret [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 113 - return ret [INFO] [stdout] 113 + ret [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:29:22 [INFO] [stdout] | [INFO] [stdout] 29 | None => {return format!("http:{}", amp_replace_content)}, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - None => {return format!("http:{}", amp_replace_content)}, [INFO] [stdout] 29 + None => {format!("http:{}", amp_replace_content)}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:30:41 [INFO] [stdout] | [INFO] [stdout] 30 | Some(Scheme::Email(_s)) => {return format!("{}", amp_replace_content)}, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - Some(Scheme::Email(_s)) => {return format!("{}", amp_replace_content)}, [INFO] [stdout] 30 + Some(Scheme::Email(_s)) => {format!("{}", amp_replace_content)}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:31:25 [INFO] [stdout] | [INFO] [stdout] 31 | Some(s) => {return format!("{}:{}", s, amp_replace_content)}, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 31 - Some(s) => {return format!("{}:{}", s, amp_replace_content)}, [INFO] [stdout] 31 + Some(s) => {format!("{}:{}", s, amp_replace_content)}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/lib.rs:30:48 [INFO] [stdout] | [INFO] [stdout] 30 | Some(Scheme::Email(_s)) => {return format!("{}", amp_replace_content)}, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `amp_replace_content.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:40:22 [INFO] [stdout] | [INFO] [stdout] 40 | None => {return write!(f, "http:{}", percent_encode(self.content).replace('&', "&"))}, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - None => {return write!(f, "http:{}", percent_encode(self.content).replace('&', "&"))}, [INFO] [stdout] 40 + None => {write!(f, "http:{}", percent_encode(self.content).replace('&', "&"))}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:41:25 [INFO] [stdout] | [INFO] [stdout] 41 | Some(s) => {return write!(f, "{}:{}", s, percent_encode(self.content).replace('&', "&"))}, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 41 - Some(s) => {return write!(f, "{}:{}", s, percent_encode(self.content).replace('&', "&"))}, [INFO] [stdout] 41 + Some(s) => {write!(f, "{}:{}", s, percent_encode(self.content).replace('&', "&"))}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:57:33 [INFO] [stdout] | [INFO] [stdout] 57 | Scheme::Http(s) => {return write!(f, "{}", s)}, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 57 - Scheme::Http(s) => {return write!(f, "{}", s)}, [INFO] [stdout] 57 + Scheme::Http(s) => {write!(f, "{}", s)}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:58:34 [INFO] [stdout] | [INFO] [stdout] 58 | Scheme::Email(s) => {return write!(f, "{}", s)}, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 58 - Scheme::Email(s) => {return write!(f, "{}", s)}, [INFO] [stdout] 58 + Scheme::Email(s) => {write!(f, "{}", s)}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:59:32 [INFO] [stdout] | [INFO] [stdout] 59 | Scheme::Irc(s) => {return write!(f, "{}", s)}, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 - Scheme::Irc(s) => {return write!(f, "{}", s)}, [INFO] [stdout] 59 + Scheme::Irc(s) => {write!(f, "{}", s)}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:60:34 [INFO] [stdout] | [INFO] [stdout] 60 | Scheme::Other(s) => {return write!(f, "{}", s)}, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 60 - Scheme::Other(s) => {return write!(f, "{}", s)}, [INFO] [stdout] 60 + Scheme::Other(s) => {write!(f, "{}", s)}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:154:45 [INFO] [stdout] | [INFO] [stdout] 154 | if char_iter.peek() == Some(&"#"){ [INFO] [stdout] | ^^^^ help: change this to: `"#"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: attempt to mutate range bound within loop [INFO] [stdout] --> src/lib.rs:227:25 [INFO] [stdout] | [INFO] [stdout] 227 | quote_level-=1; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the range of the loop is unchanged [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_range_bound [INFO] [stdout] = note: `#[warn(clippy::mut_range_bound)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/lib.rs:285:20 [INFO] [stdout] | [INFO] [stdout] 285 | if in_task_list == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `!in_task_list` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/lib.rs:300:20 [INFO] [stdout] | [INFO] [stdout] 300 | if in_unordered_list == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!in_unordered_list` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/lib.rs:305:31 [INFO] [stdout] | [INFO] [stdout] 305 | html.push_str(format!("

      1. ").as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"
      2. ".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` [INFO] [stdout] --> src/lib.rs:306:25 [INFO] [stdout] | [INFO] [stdout] 306 | if toks.into_iter().all(|t| matches!(t, Token::Plaintext(_))) {html.push_str(format!("\n").as_str());} [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/lib.rs:306:94 [INFO] [stdout] | [INFO] [stdout] 306 | if toks.into_iter().all(|t| matches!(t, Token::Plaintext(_))) {html.push_str(format!("\n").as_str());} [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:310:51 [INFO] [stdout] | [INFO] [stdout] 310 | ... html.push_str(&render(&text[1..].trim_start_matches(" ")).replace("
        ", "
          "));  
[INFO] [stdout]     |                                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `text[1..].trim_start_matches(" ")`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/lib.rs:313:48
[INFO] [stdout]     |
[INFO] [stdout] 313 | ...                   let text = &render(&text.trim_start_matches(" ")).replace("
        ", "
          ");
[INFO] [stdout]     |                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `text.trim_start_matches(" ")`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]    --> src/lib.rs:319:31
[INFO] [stdout]     |
[INFO] [stdout] 319 |                 html.push_str(format!("
        3. \n").as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/lib.rs:322:20 [INFO] [stdout] | [INFO] [stdout] 322 | if in_ordered_list == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!in_ordered_list` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/lib.rs:324:35 [INFO] [stdout] | [INFO] [stdout] 324 | html.push_str(format!("
          \n").as_str()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"
            \n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/lib.rs:338:31 [INFO] [stdout] | [INFO] [stdout] 338 | html.push_str(format!("{}", sanitize_display_text(t)).as_str())}, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `sanitize_display_text(t).to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:376:56 [INFO] [stdout] | [INFO] [stdout] 376 | &render(&sanitize_display_text(&t.trim_start_matches(" "))).replace("\t", " ") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `t.trim_start_matches(" ")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` [INFO] [stdout] --> src/lib.rs:408:35 [INFO] [stdout] | [INFO] [stdout] 408 | for h in headings.into_iter() { [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:418:95 [INFO] [stdout] | [INFO] [stdout] 418 | ... Token::Plaintext(s) => row_string.push_str(&sanitize_display_text(&s)), [INFO] [stdout] | ^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:464:8 [INFO] [stdout] | [INFO] [stdout] 464 | if references.len() > 0{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!references.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:537:8 [INFO] [stdout] | [INFO] [stdout] 537 | if scheme.len() != 0 && ( scheme.len() < 2 || scheme.len() > 32 ) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!scheme.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:561:105 [INFO] [stdout] | [INFO] [stdout] 561 | ...lto"))), content: &source.split(":").last().unwrap()}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `source.split(":").last().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:563:101 [INFO] [stdout] | [INFO] [stdout] 563 | return Ok(ValidURL{scheme: Some(source_scheme.unwrap_or(Scheme::Email("mailto"))), content: &source}) [INFO] [stdout] | ^^^^^^^ help: change this to: `source` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/lib.rs:526:37 [INFO] [stdout] | [INFO] [stdout] 526 | pub(crate) fn validate_link(source: &str) -> Result { [INFO] [stdout] | ^^^^ ^^^^^^^^ ^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | | [INFO] [stdout] | | the same lifetime is hidden here [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 526 | pub(crate) fn validate_link(source: &str) -> Result, SanitizationError<'_>> { [INFO] [stdout] | ++++ ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/iter_tests/all.rs:6:44 [INFO] [stdout] | [INFO] [stdout] 6 | let mut some_text_iter = MiniIter::new(&some_text); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `some_text` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/iter_tests/all.rs:15:44 [INFO] [stdout] | [INFO] [stdout] 15 | let mut some_text_iter = MiniIter::new(&some_text); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `some_text` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/iter_tests/all.rs:24:44 [INFO] [stdout] | [INFO] [stdout] 24 | let mut some_text_iter = MiniIter::new(&some_text); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `some_text` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/iter_tests/all.rs:32:44 [INFO] [stdout] | [INFO] [stdout] 32 | let mut some_text_iter = MiniIter::new(&some_text); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `some_text` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/iter_tests/all.rs:40:44 [INFO] [stdout] | [INFO] [stdout] 40 | let mut some_text_iter = MiniIter::new(&some_text); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `some_text` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/iter_tests/all.rs:60:40 [INFO] [stdout] | [INFO] [stdout] 60 | let mut slash_iter = MiniIter::new(&slashes); [INFO] [stdout] | ^^^^^^^^ help: change this to: `slashes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/iter_tests/all.rs:73:44 [INFO] [stdout] | [INFO] [stdout] 73 | let mut some_text_iter = MiniIter::new(&some_text); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `some_text` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/iter_tests/all.rs:83:45 [INFO] [stdout] | [INFO] [stdout] 83 | let mut other_text_iter = MiniIter::new(&other_text); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `other_text` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/iter_tests/all.rs:92:44 [INFO] [stdout] | [INFO] [stdout] 92 | let mut some_text_iter = MiniIter::new(&some_text); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `some_text` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/iter_tests/all.rs:104:44 [INFO] [stdout] | [INFO] [stdout] 104 | let mut some_text_iter = MiniIter::new(&some_text); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `some_text` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/iter_tests/all.rs:118:44 [INFO] [stdout] | [INFO] [stdout] 118 | let mut some_text_iter = MiniIter::new(&some_text); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `some_text` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.99s [INFO] running `Command { std: "docker" "inspect" "10576a43295dd0a2e46c0b6d984b8a48559cef629a9824ab4f7c460d5c8b5e0d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "10576a43295dd0a2e46c0b6d984b8a48559cef629a9824ab4f7c460d5c8b5e0d", kill_on_drop: false }` [INFO] [stdout] 10576a43295dd0a2e46c0b6d984b8a48559cef629a9824ab4f7c460d5c8b5e0d