[INFO] fetching crate micro_http_async 0.1.4...
[INFO] linting micro_http_async-0.1.4 against nightly for clippy-nonminimal_bool-denied
[INFO] extracting crate micro_http_async 0.1.4 into /workspace/builds/worker-5-tc1/source
[INFO] started tweaking crates.io crate micro_http_async 0.1.4
[INFO] finished tweaking crates.io crate micro_http_async 0.1.4
[INFO] tweaked toml for crates.io crate micro_http_async 0.1.4 written to /workspace/builds/worker-5-tc1/source/Cargo.toml
[INFO] validating manifest of crates.io crate micro_http_async 0.1.4 on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate crates.io crate micro_http_async 0.1.4 already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]  Downloading crates ...
[INFO] [stderr]   Downloaded pin-project-lite v0.2.7
[INFO] [stderr]   Downloaded tokio-rustls v0.23.2
[INFO] [stderr]   Downloaded chunked_transfer v1.4.0
[INFO] [stderr]   Downloaded rustls-pemfile v0.2.1
[INFO] [stderr]   Downloaded proc-macro2 v1.0.29
[INFO] [stderr]   Downloaded webpki v0.22.0
[INFO] [stderr]   Downloaded mio v0.7.13
[INFO] [stderr]   Downloaded serde_json v1.0.68
[INFO] [stderr]   Downloaded rustls v0.20.2
[INFO] [stderr]   Downloaded syn v1.0.76
[INFO] [stderr]   Downloaded libc v0.2.101
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] e88d509aa68fb94ea21e133d1f74c569aea75c8a3e45fd1205709cb73adc23c1
[INFO] running `Command { std: "docker" "start" "-a" "e88d509aa68fb94ea21e133d1f74c569aea75c8a3e45fd1205709cb73adc23c1", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "e88d509aa68fb94ea21e133d1f74c569aea75c8a3e45fd1205709cb73adc23c1", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "e88d509aa68fb94ea21e133d1f74c569aea75c8a3e45fd1205709cb73adc23c1", kill_on_drop: false }`
[INFO] [stdout] e88d509aa68fb94ea21e133d1f74c569aea75c8a3e45fd1205709cb73adc23c1
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 953715cd1c732d9ec855764273e505aeaf723d38502c40d7576d4afadab491ab
[INFO] running `Command { std: "docker" "start" "-a" "953715cd1c732d9ec855764273e505aeaf723d38502c40d7576d4afadab491ab", kill_on_drop: false }`
[INFO] [stderr]    Compiling proc-macro2 v1.0.29
[INFO] [stderr]    Compiling syn v1.0.76
[INFO] [stderr]    Compiling libc v0.2.101
[INFO] [stderr]    Compiling futures-core v0.3.19
[INFO] [stderr]     Checking pin-project-lite v0.2.7
[INFO] [stderr]     Checking once_cell v1.9.0
[INFO] [stderr]    Compiling futures-channel v0.3.19
[INFO] [stderr]    Compiling futures-util v0.3.19
[INFO] [stderr]    Compiling ring v0.16.20
[INFO] [stderr]     Checking futures-sink v0.3.19
[INFO] [stderr]    Compiling serde_derive v1.0.130
[INFO] [stderr]    Compiling serde v1.0.130
[INFO] [stderr]    Compiling ryu v1.0.5
[INFO] [stderr]    Compiling serde_json v1.0.68
[INFO] [stderr]     Checking aho-corasick v0.7.18
[INFO] [stderr]     Checking itoa v0.4.8
[INFO] [stderr]     Checking regex-syntax v0.6.25
[INFO] [stderr]     Checking chunked_transfer v1.4.0
[INFO] [stderr]     Checking rustls-pemfile v0.2.1
[INFO] [stderr]    Compiling quote v1.0.9
[INFO] [stderr]     Checking mio v0.7.13
[INFO] [stderr]     Checking num_cpus v1.13.0
[INFO] [stderr]     Checking regex v1.5.4
[INFO] [stderr]     Checking sct v0.7.0
[INFO] [stderr]     Checking webpki v0.22.0
[INFO] [stderr]     Checking rustls v0.20.2
[INFO] [stderr]    Compiling futures-macro v0.3.19
[INFO] [stderr]    Compiling tokio-macros v1.7.0
[INFO] [stderr]     Checking tokio v1.15.0
[INFO] [stderr]     Checking tokio-rustls v0.23.2
[INFO] [stderr]     Checking futures-executor v0.3.19
[INFO] [stderr]     Checking futures v0.3.19
[INFO] [stderr]     Checking micro_http_async v0.1.4 (/opt/rustwide/workdir)
[INFO] [stdout] warning: large size difference between variants
[INFO] [stdout]   --> src/connection.rs:9:1
[INFO] [stdout]    |
[INFO] [stdout]  9 | / pub enum ConnectionType{
[INFO] [stdout] 10 | |     Plain(Option<TcpStream>),
[INFO] [stdout]    | |     ------------------------ the second-largest variant contains at least 32 bytes
[INFO] [stdout] 11 | |     TLS(Option<TlsStream<TcpStream>>)
[INFO] [stdout]    | |     --------------------------------- the largest variant contains at least 552 bytes
[INFO] [stdout] 12 | | }
[INFO] [stdout]    | |_^ the entire enum is at least 552 bytes
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
[INFO] [stdout]    = note: `#[warn(clippy::large_enum_variant)]` on by default
[INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum
[INFO] [stdout]    |
[INFO] [stdout] 11 -     TLS(Option<TlsStream<TcpStream>>)
[INFO] [stdout] 11 +     TLS(Box<Option<TlsStream<TcpStream>>>)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: name `TLS` contains a capitalized acronym
[INFO] [stdout]   --> src/connection.rs:11:5
[INFO] [stdout]    |
[INFO] [stdout] 11 |     TLS(Option<TlsStream<TcpStream>>)
[INFO] [stdout]    |     ^^^ help: consider making the acronym lowercase, except the initial letter: `Tls`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
[INFO] [stdout]    = note: `#[warn(clippy::upper_case_acronyms)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/connection.rs:101:17
[INFO] [stdout]     |
[INFO] [stdout] 101 |                 return Ok(buffer) // return our vector;
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]     = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 101 ~                 Ok(buffer) // return our vector;
[INFO] [stdout] 102 |
[INFO] [stdout] ...
[INFO] [stdout] 126 |             }
[INFO] [stdout] 127 ~         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/connection.rs:125:17
[INFO] [stdout]     |
[INFO] [stdout] 125 |                 return Ok(buffer) // return our vector;
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 125 ~                 Ok(buffer) // return our vector;
[INFO] [stdout] 126 |             }
[INFO] [stdout] 127 ~         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you are using an explicit closure for copying elements
[INFO] [stdout]   --> src/connection.rs:95:39
[INFO] [stdout]    |
[INFO] [stdout] 95 |                   let buffer: Vec<u8> = buffer
[INFO] [stdout]    |  _______________________________________^
[INFO] [stdout] 96 | |                     .iter()
[INFO] [stdout] 97 | |                     .filter(|x| **x != 0x0u8)
[INFO] [stdout] 98 | |                     .map(|x| *x)
[INFO] [stdout]    | |________________________________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stdout]    = note: `#[warn(clippy::map_clone)]` on by default
[INFO] [stdout] help: consider calling the dedicated `copied` method
[INFO] [stdout]    |
[INFO] [stdout] 95 ~                 let buffer: Vec<u8> = buffer
[INFO] [stdout] 96 +                     .iter()
[INFO] [stdout] 97 +                     .filter(|x| **x != 0x0u8).copied()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you are using an explicit closure for copying elements
[INFO] [stdout]    --> src/connection.rs:116:39
[INFO] [stdout]     |
[INFO] [stdout] 116 |                   let buffer: Vec<u8> = buffer
[INFO] [stdout]     |  _______________________________________^
[INFO] [stdout] 117 | |                     .iter()
[INFO] [stdout] 118 | |                     .filter(|x| **x != 0x0u8)
[INFO] [stdout] 119 | |                     .map(|x| *x)
[INFO] [stdout]     | |________________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stdout] help: consider calling the dedicated `copied` method
[INFO] [stdout]     |
[INFO] [stdout] 116 ~                 let buffer: Vec<u8> = buffer
[INFO] [stdout] 117 +                     .iter()
[INFO] [stdout] 118 +                     .filter(|x| **x != 0x0u8).copied()
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/html_loader.rs:96:9
[INFO] [stdout]    |
[INFO] [stdout] 96 |         return file;
[INFO] [stdout]    |         ^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 96 -         return file;
[INFO] [stdout] 96 +         file
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: large size difference between variants
[INFO] [stdout]   --> src/connection.rs:9:1
[INFO] [stdout]    |
[INFO] [stdout]  9 | / pub enum ConnectionType{
[INFO] [stdout] 10 | |     Plain(Option<TcpStream>),
[INFO] [stdout]    | |     ------------------------ the second-largest variant contains at least 32 bytes
[INFO] [stdout] 11 | |     TLS(Option<TlsStream<TcpStream>>)
[INFO] [stdout]    | |     --------------------------------- the largest variant contains at least 552 bytes
[INFO] [stdout] 12 | | }
[INFO] [stdout]    | |_^ the entire enum is at least 552 bytes
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
[INFO] [stdout]    = note: `#[warn(clippy::large_enum_variant)]` on by default
[INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum
[INFO] [stdout]    |
[INFO] [stdout] 11 -     TLS(Option<TlsStream<TcpStream>>)
[INFO] [stdout] 11 +     TLS(Box<Option<TlsStream<TcpStream>>>)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: name `TLS` contains a capitalized acronym
[INFO] [stdout]   --> src/connection.rs:11:5
[INFO] [stdout]    |
[INFO] [stdout] 11 |     TLS(Option<TlsStream<TcpStream>>)
[INFO] [stdout]    |     ^^^ help: consider making the acronym lowercase, except the initial letter: `Tls`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
[INFO] [stdout]    = note: `#[warn(clippy::upper_case_acronyms)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/html_loader.rs:119:58
[INFO] [stdout]     |
[INFO] [stdout] 119 |                     file = file.replace(&var_to_replace, &v);
[INFO] [stdout]     |                                                          ^^ help: change this to: `v`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/json_response.rs:32:9
[INFO] [stdout]    |
[INFO] [stdout] 32 |         return file;
[INFO] [stdout]    |         ^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 32 -         return file;
[INFO] [stdout] 32 +         file
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/connection.rs:101:17
[INFO] [stdout]     |
[INFO] [stdout] 101 |                 return Ok(buffer) // return our vector;
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]     = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 101 ~                 Ok(buffer) // return our vector;
[INFO] [stdout] 102 |
[INFO] [stdout] ...
[INFO] [stdout] 126 |             }
[INFO] [stdout] 127 ~         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/connection.rs:125:17
[INFO] [stdout]     |
[INFO] [stdout] 125 |                 return Ok(buffer) // return our vector;
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 125 ~                 Ok(buffer) // return our vector;
[INFO] [stdout] 126 |             }
[INFO] [stdout] 127 ~         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you are using an explicit closure for copying elements
[INFO] [stdout]   --> src/connection.rs:95:39
[INFO] [stdout]    |
[INFO] [stdout] 95 |                   let buffer: Vec<u8> = buffer
[INFO] [stdout]    |  _______________________________________^
[INFO] [stdout] 96 | |                     .iter()
[INFO] [stdout] 97 | |                     .filter(|x| **x != 0x0u8)
[INFO] [stdout] 98 | |                     .map(|x| *x)
[INFO] [stdout]    | |________________________________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stdout]    = note: `#[warn(clippy::map_clone)]` on by default
[INFO] [stdout] help: consider calling the dedicated `copied` method
[INFO] [stdout]    |
[INFO] [stdout] 95 ~                 let buffer: Vec<u8> = buffer
[INFO] [stdout] 96 +                     .iter()
[INFO] [stdout] 97 +                     .filter(|x| **x != 0x0u8).copied()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you are using an explicit closure for copying elements
[INFO] [stdout]    --> src/connection.rs:116:39
[INFO] [stdout]     |
[INFO] [stdout] 116 |                   let buffer: Vec<u8> = buffer
[INFO] [stdout]     |  _______________________________________^
[INFO] [stdout] 117 | |                     .iter()
[INFO] [stdout] 118 | |                     .filter(|x| **x != 0x0u8)
[INFO] [stdout] 119 | |                     .map(|x| *x)
[INFO] [stdout]     | |________________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stdout] help: consider calling the dedicated `copied` method
[INFO] [stdout]     |
[INFO] [stdout] 116 ~                 let buffer: Vec<u8> = buffer
[INFO] [stdout] 117 +                     .iter()
[INFO] [stdout] 118 +                     .filter(|x| **x != 0x0u8).copied()
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]    --> src/request.rs:118:34
[INFO] [stdout]     |
[INFO] [stdout] 118 |     async fn get_method(strings: &Vec<String>) -> Option<HttpMethod> {
[INFO] [stdout]     |                                  ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]     = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 118 -     async fn get_method(strings: &Vec<String>) -> Option<HttpMethod> {
[INFO] [stdout] 118 +     async fn get_method(strings: &[String]) -> Option<HttpMethod> {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/request.rs:158:16
[INFO] [stdout]     |
[INFO] [stdout] 158 |             if !method.is_none() {
[INFO] [stdout]     |                ^^^^^^^^^^^^^^^^^ help: try: `method.is_some()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]    --> src/request.rs:171:31
[INFO] [stdout]     |
[INFO] [stdout] 171 |     async fn get_uri(strings: &Vec<String>) -> String {
[INFO] [stdout]     |                               ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 171 -     async fn get_uri(strings: &Vec<String>) -> String {
[INFO] [stdout] 171 +     async fn get_uri(strings: &[String]) -> String {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/html_loader.rs:96:9
[INFO] [stdout]    |
[INFO] [stdout] 96 |         return file;
[INFO] [stdout]    |         ^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 96 -         return file;
[INFO] [stdout] 96 +         file
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: returning the result of a `let` binding from a block
[INFO] [stdout]    --> src/request.rs:182:9
[INFO] [stdout]     |
[INFO] [stdout] 176 | /         let uri = if strings.len() > 1 {
[INFO] [stdout] 177 | |             strings[1].clone()
[INFO] [stdout] 178 | |         } else {
[INFO] [stdout] 179 | |             "/error".to_string()
[INFO] [stdout] 180 | |         };
[INFO] [stdout]     | |__________- unnecessary `let` binding
[INFO] [stdout] 181 |
[INFO] [stdout] 182 |           uri
[INFO] [stdout]     |           ^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stdout]     = note: `#[warn(clippy::let_and_return)]` on by default
[INFO] [stdout] help: return the expression directly
[INFO] [stdout]     |
[INFO] [stdout] 176 ~         
[INFO] [stdout] 177 |
[INFO] [stdout] 178 ~         if strings.len() > 1 {
[INFO] [stdout] 179 +             strings[1].clone()
[INFO] [stdout] 180 +         } else {
[INFO] [stdout] 181 +             "/error".to_string()
[INFO] [stdout] 182 +         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do
[INFO] [stdout]    --> src/request.rs:190:28
[INFO] [stdout]     |
[INFO] [stdout] 190 |     async fn get_vars(uri: &String) -> (HashMap<String, String>, String) {
[INFO] [stdout]     |                            ^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 190 -     async fn get_vars(uri: &String) -> (HashMap<String, String>, String) {
[INFO] [stdout] 190 +     async fn get_vars(uri: &str) -> (HashMap<String, String>, String) {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]    --> src/request.rs:218:40
[INFO] [stdout]     |
[INFO] [stdout] 218 |     async fn get_post_request(strings: &Vec<String>) -> HashMap<String, PostRequest> {
[INFO] [stdout]     |                                        ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 218 -     async fn get_post_request(strings: &Vec<String>) -> HashMap<String, PostRequest> {
[INFO] [stdout] 218 +     async fn get_post_request(strings: &[String]) -> HashMap<String, PostRequest> {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: comparison to empty slice
[INFO] [stdout]    --> src/request.rs:227:57
[INFO] [stdout]     |
[INFO] [stdout] 227 |         let index_of_post = strings.iter().position(|x| x == "").unwrap();
[INFO] [stdout]     |                                                         ^^^^^^^ help: using `is_empty` is clearer and more explicit: `x.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty
[INFO] [stdout]     = note: `#[warn(clippy::comparison_to_empty)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/html_loader.rs:119:58
[INFO] [stdout]     |
[INFO] [stdout] 119 |                     file = file.replace(&var_to_replace, &v);
[INFO] [stdout]     |                                                          ^^ help: change this to: `v`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/json_response.rs:32:9
[INFO] [stdout]    |
[INFO] [stdout] 32 |         return file;
[INFO] [stdout]    |         ^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 32 -         return file;
[INFO] [stdout] 32 +         file
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: compiling a regex in a loop
[INFO] [stdout]    --> src/request.rs:264:30
[INFO] [stdout]     |
[INFO] [stdout] 264 |                     let re = Regex::new(r"\w*?([\d|\.]+)\w*?([\d{1,4}]+).*").unwrap();
[INFO] [stdout]     |                              ^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout] help: move the regex construction outside this loop
[INFO] [stdout]    --> src/request.rs:259:13
[INFO] [stdout]     |
[INFO] [stdout] 259 |             for string in strings[index_of_post + 1..].iter() {
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#regex_creation_in_loops
[INFO] [stdout]     = note: `#[warn(clippy::regex_creation_in_loops)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: compiling a regex in a loop
[INFO] [stdout]    --> src/request.rs:296:34
[INFO] [stdout]     |
[INFO] [stdout] 296 |                         let re = Regex::new(r#""([^"].+)""#).unwrap();
[INFO] [stdout]     |                                  ^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout] help: move the regex construction outside this loop
[INFO] [stdout]    --> src/request.rs:259:13
[INFO] [stdout]     |
[INFO] [stdout] 259 |             for string in strings[index_of_post + 1..].iter() {
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#regex_creation_in_loops
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: compiling a regex in a loop
[INFO] [stdout]    --> src/request.rs:310:34
[INFO] [stdout]     |
[INFO] [stdout] 310 |                         let re = Regex::new(r#""([^"].+)""#).unwrap();
[INFO] [stdout]     |                                  ^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout] help: move the regex construction outside this loop
[INFO] [stdout]    --> src/request.rs:259:13
[INFO] [stdout]     |
[INFO] [stdout] 259 |             for string in strings[index_of_post + 1..].iter() {
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#regex_creation_in_loops
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]    --> src/request.rs:348:38
[INFO] [stdout]     |
[INFO] [stdout] 348 |     async fn get_user_agent(strings: &Vec<String>) -> String {
[INFO] [stdout]     |                                      ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 348 -     async fn get_user_agent(strings: &Vec<String>) -> String {
[INFO] [stdout] 348 +     async fn get_user_agent(strings: &[String]) -> String {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this creates an owned instance just for comparison
[INFO] [stdout]    --> src/request.rs:358:25
[INFO] [stdout]     |
[INFO] [stdout] 358 |             if agent != "none".to_string() {
[INFO] [stdout]     |                         ^^^^^^^^^^^^^^^^^^ help: try: `"none"`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stdout]     = note: `#[warn(clippy::cmp_owned)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/response.rs:27:17
[INFO] [stdout]    |
[INFO] [stdout] 27 |                 return Response::Ok;
[INFO] [stdout]    |                 ^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 27 -                 return Response::Ok;
[INFO] [stdout] 27 +                 Response::Ok
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/response.rs:30:17
[INFO] [stdout]    |
[INFO] [stdout] 30 |                 return Response::Redirect;
[INFO] [stdout]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 30 -                 return Response::Redirect;
[INFO] [stdout] 30 +                 Response::Redirect
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]    --> src/request.rs:118:34
[INFO] [stdout]     |
[INFO] [stdout] 118 |     async fn get_method(strings: &Vec<String>) -> Option<HttpMethod> {
[INFO] [stdout]     |                                  ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]     = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 118 -     async fn get_method(strings: &Vec<String>) -> Option<HttpMethod> {
[INFO] [stdout] 118 +     async fn get_method(strings: &[String]) -> Option<HttpMethod> {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/response.rs:33:17
[INFO] [stdout]    |
[INFO] [stdout] 33 |                 return Response::ClientErr;
[INFO] [stdout]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 33 -                 return Response::ClientErr;
[INFO] [stdout] 33 +                 Response::ClientErr
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/request.rs:158:16
[INFO] [stdout]     |
[INFO] [stdout] 158 |             if !method.is_none() {
[INFO] [stdout]     |                ^^^^^^^^^^^^^^^^^ help: try: `method.is_some()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/response.rs:36:17
[INFO] [stdout]    |
[INFO] [stdout] 36 |                 return Response::ServerErr;
[INFO] [stdout]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 36 -                 return Response::ServerErr;
[INFO] [stdout] 36 +                 Response::ServerErr
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/response.rs:39:17
[INFO] [stdout]    |
[INFO] [stdout] 39 |                 return Response::ServerErr;
[INFO] [stdout]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 39 -                 return Response::ServerErr;
[INFO] [stdout] 39 +                 Response::ServerErr
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]    --> src/request.rs:171:31
[INFO] [stdout]     |
[INFO] [stdout] 171 |     async fn get_uri(strings: &Vec<String>) -> String {
[INFO] [stdout]     |                               ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 171 -     async fn get_uri(strings: &Vec<String>) -> String {
[INFO] [stdout] 171 +     async fn get_uri(strings: &[String]) -> String {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: returning the result of a `let` binding from a block
[INFO] [stdout]    --> src/request.rs:182:9
[INFO] [stdout]     |
[INFO] [stdout] 176 | /         let uri = if strings.len() > 1 {
[INFO] [stdout] 177 | |             strings[1].clone()
[INFO] [stdout] 178 | |         } else {
[INFO] [stdout] 179 | |             "/error".to_string()
[INFO] [stdout] 180 | |         };
[INFO] [stdout]     | |__________- unnecessary `let` binding
[INFO] [stdout] 181 |
[INFO] [stdout] 182 |           uri
[INFO] [stdout]     |           ^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stdout]     = note: `#[warn(clippy::let_and_return)]` on by default
[INFO] [stdout] help: return the expression directly
[INFO] [stdout]     |
[INFO] [stdout] 176 ~         
[INFO] [stdout] 177 |
[INFO] [stdout] 178 ~         if strings.len() > 1 {
[INFO] [stdout] 179 +             strings[1].clone()
[INFO] [stdout] 180 +         } else {
[INFO] [stdout] 181 +             "/error".to_string()
[INFO] [stdout] 182 +         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do
[INFO] [stdout]    --> src/request.rs:190:28
[INFO] [stdout]     |
[INFO] [stdout] 190 |     async fn get_vars(uri: &String) -> (HashMap<String, String>, String) {
[INFO] [stdout]     |                            ^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 190 -     async fn get_vars(uri: &String) -> (HashMap<String, String>, String) {
[INFO] [stdout] 190 +     async fn get_vars(uri: &str) -> (HashMap<String, String>, String) {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]    --> src/request.rs:218:40
[INFO] [stdout]     |
[INFO] [stdout] 218 |     async fn get_post_request(strings: &Vec<String>) -> HashMap<String, PostRequest> {
[INFO] [stdout]     |                                        ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 218 -     async fn get_post_request(strings: &Vec<String>) -> HashMap<String, PostRequest> {
[INFO] [stdout] 218 +     async fn get_post_request(strings: &[String]) -> HashMap<String, PostRequest> {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: comparison to empty slice
[INFO] [stdout]    --> src/request.rs:227:57
[INFO] [stdout]     |
[INFO] [stdout] 227 |         let index_of_post = strings.iter().position(|x| x == "").unwrap();
[INFO] [stdout]     |                                                         ^^^^^^^ help: using `is_empty` is clearer and more explicit: `x.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty
[INFO] [stdout]     = note: `#[warn(clippy::comparison_to_empty)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary use of `to_string`
[INFO] [stdout]    --> src/routes.rs:182:33
[INFO] [stdout]     |
[INFO] [stdout] 182 |                 self.routes.get(&"err".to_string()).unwrap() // we assume we've got an error handler
[INFO] [stdout]     |                                 ^^^^^^^^^^^^^^^^^^ help: replace it with: `"err"`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned
[INFO] [stdout]     = note: `#[warn(clippy::unnecessary_to_owned)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: compiling a regex in a loop
[INFO] [stdout]    --> src/request.rs:264:30
[INFO] [stdout]     |
[INFO] [stdout] 264 |                     let re = Regex::new(r"\w*?([\d|\.]+)\w*?([\d{1,4}]+).*").unwrap();
[INFO] [stdout]     |                              ^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout] help: move the regex construction outside this loop
[INFO] [stdout]    --> src/request.rs:259:13
[INFO] [stdout]     |
[INFO] [stdout] 259 |             for string in strings[index_of_post + 1..].iter() {
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#regex_creation_in_loops
[INFO] [stdout]     = note: `#[warn(clippy::regex_creation_in_loops)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: compiling a regex in a loop
[INFO] [stdout]    --> src/request.rs:296:34
[INFO] [stdout]     |
[INFO] [stdout] 296 |                         let re = Regex::new(r#""([^"].+)""#).unwrap();
[INFO] [stdout]     |                                  ^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout] help: move the regex construction outside this loop
[INFO] [stdout]    --> src/request.rs:259:13
[INFO] [stdout]     |
[INFO] [stdout] 259 |             for string in strings[index_of_post + 1..].iter() {
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#regex_creation_in_loops
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: compiling a regex in a loop
[INFO] [stdout]    --> src/request.rs:310:34
[INFO] [stdout]     |
[INFO] [stdout] 310 |                         let re = Regex::new(r#""([^"].+)""#).unwrap();
[INFO] [stdout]     |                                  ^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout] help: move the regex construction outside this loop
[INFO] [stdout]    --> src/request.rs:259:13
[INFO] [stdout]     |
[INFO] [stdout] 259 |             for string in strings[index_of_post + 1..].iter() {
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#regex_creation_in_loops
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]    --> src/request.rs:348:38
[INFO] [stdout]     |
[INFO] [stdout] 348 |     async fn get_user_agent(strings: &Vec<String>) -> String {
[INFO] [stdout]     |                                      ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 348 -     async fn get_user_agent(strings: &Vec<String>) -> String {
[INFO] [stdout] 348 +     async fn get_user_agent(strings: &[String]) -> String {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this creates an owned instance just for comparison
[INFO] [stdout]    --> src/request.rs:358:25
[INFO] [stdout]     |
[INFO] [stdout] 358 |             if agent != "none".to_string() {
[INFO] [stdout]     |                         ^^^^^^^^^^^^^^^^^^ help: try: `"none"`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stdout]     = note: `#[warn(clippy::cmp_owned)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/response.rs:27:17
[INFO] [stdout]    |
[INFO] [stdout] 27 |                 return Response::Ok;
[INFO] [stdout]    |                 ^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 27 -                 return Response::Ok;
[INFO] [stdout] 27 +                 Response::Ok
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/response.rs:30:17
[INFO] [stdout]    |
[INFO] [stdout] 30 |                 return Response::Redirect;
[INFO] [stdout]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 30 -                 return Response::Redirect;
[INFO] [stdout] 30 +                 Response::Redirect
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/response.rs:33:17
[INFO] [stdout]    |
[INFO] [stdout] 33 |                 return Response::ClientErr;
[INFO] [stdout]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 33 -                 return Response::ClientErr;
[INFO] [stdout] 33 +                 Response::ClientErr
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/response.rs:36:17
[INFO] [stdout]    |
[INFO] [stdout] 36 |                 return Response::ServerErr;
[INFO] [stdout]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 36 -                 return Response::ServerErr;
[INFO] [stdout] 36 +                 Response::ServerErr
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/response.rs:39:17
[INFO] [stdout]    |
[INFO] [stdout] 39 |                 return Response::ServerErr;
[INFO] [stdout]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 39 -                 return Response::ServerErr;
[INFO] [stdout] 39 +                 Response::ServerErr
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary use of `to_string`
[INFO] [stdout]    --> src/routes.rs:182:33
[INFO] [stdout]     |
[INFO] [stdout] 182 |                 self.routes.get(&"err".to_string()).unwrap() // we assume we've got an error handler
[INFO] [stdout]     |                                 ^^^^^^^^^^^^^^^^^^ help: replace it with: `"err"`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned
[INFO] [stdout]     = note: `#[warn(clippy::unnecessary_to_owned)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: feature `string_remove_matches` is declared but not used
[INFO] [stdout]   --> src/lib.rs:39:12
[INFO] [stdout]    |
[INFO] [stdout] 39 | #![feature(string_remove_matches)]
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_features)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: feature `string_remove_matches` is declared but not used
[INFO] [stdout]   --> src/lib.rs:39:12
[INFO] [stdout]    |
[INFO] [stdout] 39 | #![feature(string_remove_matches)]
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_features)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 14.56s
[INFO] running `Command { std: "docker" "inspect" "953715cd1c732d9ec855764273e505aeaf723d38502c40d7576d4afadab491ab", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "953715cd1c732d9ec855764273e505aeaf723d38502c40d7576d4afadab491ab", kill_on_drop: false }`
[INFO] [stdout] 953715cd1c732d9ec855764273e505aeaf723d38502c40d7576d4afadab491ab