[INFO] fetching crate mesh-portal-versions 0.2.0-rc1... [INFO] linting mesh-portal-versions-0.2.0-rc1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate mesh-portal-versions 0.2.0-rc1 into /workspace/builds/worker-7-tc1/source [INFO] started tweaking crates.io crate mesh-portal-versions 0.2.0-rc1 [INFO] finished tweaking crates.io crate mesh-portal-versions 0.2.0-rc1 [INFO] tweaked toml for crates.io crate mesh-portal-versions 0.2.0-rc1 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate mesh-portal-versions 0.2.0-rc1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 30 packages to latest compatible versions [INFO] [stderr] Adding bincode v1.3.3 (available: v3.0.0) [INFO] [stderr] Adding nom v7.1.3 (available: v8.0.0) [INFO] [stderr] Adding nom-supreme v0.6.0 (available: v0.8.0) [INFO] [stderr] Adding semver v0.11.0 (available: v1.0.27) [INFO] [stderr] Adding strum v0.21.0 (available: v0.28.0) [INFO] [stderr] Adding strum_macros v0.21.1 (available: v0.28.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded joinery v2.1.0 [INFO] [stderr] Downloaded brownstone v1.1.0 [INFO] [stderr] Downloaded nom-supreme v0.6.0 [INFO] [stderr] Downloaded indent_write v2.2.0 [INFO] [stderr] Downloaded strum_macros v0.21.1 [INFO] [stderr] Downloaded strum v0.21.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 598dad4b88aa33e9fa1e6f1744d9c320928f3530b98455f1ac1cae82a6ebb3c2 [INFO] running `Command { std: "docker" "start" "-a" "598dad4b88aa33e9fa1e6f1744d9c320928f3530b98455f1ac1cae82a6ebb3c2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "598dad4b88aa33e9fa1e6f1744d9c320928f3530b98455f1ac1cae82a6ebb3c2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "598dad4b88aa33e9fa1e6f1744d9c320928f3530b98455f1ac1cae82a6ebb3c2", kill_on_drop: false }` [INFO] [stdout] 598dad4b88aa33e9fa1e6f1744d9c320928f3530b98455f1ac1cae82a6ebb3c2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ae584ff3f5f8a0b2e871a6ce3c1b3546737dfc245d6ed7b2146f54a02907bee9 [INFO] running `Command { std: "docker" "start" "-a" "ae584ff3f5f8a0b2e871a6ce3c1b3546737dfc245d6ed7b2146f54a02907bee9", kill_on_drop: false }` [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking joinery v2.1.0 [INFO] [stderr] Checking indent_write v2.2.0 [INFO] [stderr] Checking strum v0.21.0 [INFO] [stderr] Checking pest v2.8.6 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Checking regex v1.12.3 [INFO] [stderr] Checking brownstone v1.1.0 [INFO] [stderr] Checking nom-supreme v0.6.0 [INFO] [stderr] Checking semver-parser v0.10.3 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Checking semver v0.11.0 [INFO] [stderr] Compiling strum_macros v0.21.1 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking mesh-portal-versions v0.2.0-rc1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused `#[macro_use]` import [INFO] [stdout] --> src/lib.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | #[macro_use] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `#[macro_use]` import [INFO] [stdout] --> src/lib.rs:5:1 [INFO] [stdout] | [INFO] [stdout] 5 | #[macro_use] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::collections::HashMap` [INFO] [stdout] --> src/lib.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use std::collections::HashMap; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::sync::Arc` [INFO] [stdout] --> src/lib.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use std::sync::Arc; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::str::FromStr` [INFO] [stdout] --> src/version/mod.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::str::FromStr; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `VerboseError` and `context` [INFO] [stdout] --> src/version/mod.rs:2:18 [INFO] [stdout] | [INFO] [stdout] 2 | use nom::error::{context, VerboseError}; [INFO] [stdout] | ^^^^^^^ ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `separated_pair`, `terminated`, and `tuple` [INFO] [stdout] --> src/version/mod.rs:3:21 [INFO] [stdout] | [INFO] [stdout] 3 | use nom::sequence::{tuple, terminated, separated_pair}; [INFO] [stdout] | ^^^^^ ^^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `nom::character::complete::digit1` [INFO] [stdout] --> src/version/mod.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use nom::character::complete::digit1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `nom::bytes::complete::tag` [INFO] [stdout] --> src/version/mod.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use nom::bytes::complete::tag; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `nom::IResult` [INFO] [stdout] --> src/version/mod.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use nom::IResult; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::convert::From` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::convert::From; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::convert::TryInto` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::convert::TryInto; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fmt::Debug` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::fmt::Debug; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::hash::Hash` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use std::hash::Hash; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::sync::Arc` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use std::sync::Arc; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Deserialize` and `Serialize` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:8:13 [INFO] [stdout] | [INFO] [stdout] 8 | use serde::{Deserialize, Serialize}; [INFO] [stdout] | ^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::error::Error` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use crate::error::Error; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `semver::SemVerError` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | use semver::SemVerError; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `semver::ReqParseError` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:856:9 [INFO] [stdout] | [INFO] [stdout] 856 | use semver::ReqParseError; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `address` and `path` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:863:41 [INFO] [stdout] | [INFO] [stdout] 863 | ...::v0_0_1::parse::{address, camel_case_to_string, capture_address, consume_address_kind_path, file_chars, path, path_regex, captu... [INFO] [stdout] | ^^^^^^^ ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `VerboseError` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:875:33 [INFO] [stdout] | [INFO] [stdout] 875 | use nom::error::{ErrorKind, VerboseError}; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ParserExt` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:879:39 [INFO] [stdout] | [INFO] [stdout] 879 | use nom_supreme::{parse_from_str, ParserExt}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `nom_supreme::parser_ext::FromStrParser` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:881:9 [INFO] [stdout] | [INFO] [stdout] 881 | use nom_supreme::parser_ext::FromStrParser; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Rc` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:883:59 [INFO] [stdout] | [INFO] [stdout] 883 | use crate::version::v0_0_1::entity::request::{Action, Rc, RcCommandType, RequestCore}; [INFO] [stdout] | ^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this is an `else {..}` but the formatting might hide it [INFO] [stdout] --> src/version/v0_0_1/mod.rs:1163:26 [INFO] [stdout] | [INFO] [stdout] 1163 | } else [INFO] [stdout] | __________________________^ [INFO] [stdout] 1164 | | { [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = note: to remove this lint, remove the `else` or remove the new line between `else` and `{..}` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stdout] = note: `#[warn(clippy::suspicious_else_formatting)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this is an `else {..}` but the formatting might hide it [INFO] [stdout] --> src/version/v0_0_1/mod.rs:1172:22 [INFO] [stdout] | [INFO] [stdout] 1172 | } else [INFO] [stdout] | ______________________^ [INFO] [stdout] 1173 | | { [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = note: to remove this lint, remove the `else` or remove the new line between `else` and `{..}` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `TryFrom` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:1282:28 [INFO] [stdout] | [INFO] [stdout] 1282 | use std::convert::{TryFrom, TryInto}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::str::FromStr` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:1283:13 [INFO] [stdout] | [INFO] [stdout] 1283 | use std::str::FromStr; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `alpha1` and `digit1` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:1287:40 [INFO] [stdout] | [INFO] [stdout] 1287 | use nom::character::complete::{alpha1, digit1}; [INFO] [stdout] | ^^^^^^ ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Err` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:1293:19 [INFO] [stdout] | [INFO] [stdout] 1293 | use nom::{Err, IResult}; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `version_address_segment` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:1297:132 [INFO] [stdout] | [INFO] [stdout] 1297 | ...domain_chars, skewer_chars, version_req_chars, Res, version_address_segment, version_chars, address, file_chars}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ParserExt` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:1303:42 [INFO] [stdout] | [INFO] [stdout] 1303 | use nom_supreme::{parse_from_str,ParserExt}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/version/v0_0_1/mod.rs:1741:17 [INFO] [stdout] | [INFO] [stdout] 1741 | (char_item == '"') [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 1741 - (char_item == '"') [INFO] [stdout] 1741 + char_item == '"' [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `#[macro_use]` import [INFO] [stdout] --> src/lib.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | #[macro_use] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `#[macro_use]` import [INFO] [stdout] --> src/lib.rs:5:1 [INFO] [stdout] | [INFO] [stdout] 5 | #[macro_use] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::collections::HashMap` [INFO] [stdout] --> src/lib.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use std::collections::HashMap; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::sync::Arc` [INFO] [stdout] --> src/lib.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use std::sync::Arc; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::str::FromStr` [INFO] [stdout] --> src/version/mod.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::str::FromStr; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `VerboseError` and `context` [INFO] [stdout] --> src/version/mod.rs:2:18 [INFO] [stdout] | [INFO] [stdout] 2 | use nom::error::{context, VerboseError}; [INFO] [stdout] | ^^^^^^^ ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `separated_pair`, `terminated`, and `tuple` [INFO] [stdout] --> src/version/mod.rs:3:21 [INFO] [stdout] | [INFO] [stdout] 3 | use nom::sequence::{tuple, terminated, separated_pair}; [INFO] [stdout] | ^^^^^ ^^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `nom::character::complete::digit1` [INFO] [stdout] --> src/version/mod.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use nom::character::complete::digit1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `nom::bytes::complete::tag` [INFO] [stdout] --> src/version/mod.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use nom::bytes::complete::tag; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `nom::IResult` [INFO] [stdout] --> src/version/mod.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use nom::IResult; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::convert::From` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::convert::From; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::convert::TryInto` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::convert::TryInto; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fmt::Debug` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::fmt::Debug; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::hash::Hash` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use std::hash::Hash; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::sync::Arc` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use std::sync::Arc; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Deserialize` and `Serialize` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:8:13 [INFO] [stdout] | [INFO] [stdout] 8 | use serde::{Deserialize, Serialize}; [INFO] [stdout] | ^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::error::Error` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use crate::error::Error; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::convert::TryInto` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:2848:9 [INFO] [stdout] | [INFO] [stdout] 2848 | use std::convert::TryInto; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `semver::SemVerError` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | use semver::SemVerError; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::collections::HashMap` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3083:9 [INFO] [stdout] | [INFO] [stdout] 3083 | use std::collections::HashMap; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Deserialize` and `Serialize` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3086:17 [INFO] [stdout] | [INFO] [stdout] 3086 | use serde::{Deserialize, Serialize}; [INFO] [stdout] | ^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `PayloadClaim`, `ResourceKind`, and `ResourceType` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3098:47 [INFO] [stdout] | [INFO] [stdout] 3098 | use crate::version::v0_0_1::id::{Address, ResourceKind, Meta, PayloadClaim, ResourceType, CaptureAddress}; [INFO] [stdout] | ^^^^^^^^^^^^ ^^^^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::version::v0_0_1::pattern::TksPattern` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3099:9 [INFO] [stdout] | [INFO] [stdout] 3099 | use crate::version::v0_0_1::pattern::TksPattern; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `RcCommandType` and `Rc` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3102:59 [INFO] [stdout] | [INFO] [stdout] 3102 | use crate::version::v0_0_1::entity::request::{Action, Rc, RcCommandType, RequestCore}; [INFO] [stdout] | ^^ ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `semver::ReqParseError` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:856:9 [INFO] [stdout] | [INFO] [stdout] 856 | use semver::ReqParseError; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `address` and `path` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:863:41 [INFO] [stdout] | [INFO] [stdout] 863 | ...::v0_0_1::parse::{address, camel_case_to_string, capture_address, consume_address_kind_path, file_chars, path, path_regex, captu... [INFO] [stdout] | ^^^^^^^ ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `VerboseError` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:875:33 [INFO] [stdout] | [INFO] [stdout] 875 | use nom::error::{ErrorKind, VerboseError}; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ParserExt` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:879:39 [INFO] [stdout] | [INFO] [stdout] 879 | use nom_supreme::{parse_from_str, ParserExt}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `nom_supreme::parser_ext::FromStrParser` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:881:9 [INFO] [stdout] | [INFO] [stdout] 881 | use nom_supreme::parser_ext::FromStrParser; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Rc` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:883:59 [INFO] [stdout] | [INFO] [stdout] 883 | use crate::version::v0_0_1::entity::request::{Action, Rc, RcCommandType, RequestCore}; [INFO] [stdout] | ^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this is an `else {..}` but the formatting might hide it [INFO] [stdout] --> src/version/v0_0_1/mod.rs:1163:26 [INFO] [stdout] | [INFO] [stdout] 1163 | } else [INFO] [stdout] | __________________________^ [INFO] [stdout] 1164 | | { [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = note: to remove this lint, remove the `else` or remove the new line between `else` and `{..}` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stdout] = note: `#[warn(clippy::suspicious_else_formatting)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this is an `else {..}` but the formatting might hide it [INFO] [stdout] --> src/version/v0_0_1/mod.rs:1172:22 [INFO] [stdout] | [INFO] [stdout] 1172 | } else [INFO] [stdout] | ______________________^ [INFO] [stdout] 1173 | | { [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = note: to remove this lint, remove the `else` or remove the new line between `else` and `{..}` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `TryFrom` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:1282:28 [INFO] [stdout] | [INFO] [stdout] 1282 | use std::convert::{TryFrom, TryInto}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::str::FromStr` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:1283:13 [INFO] [stdout] | [INFO] [stdout] 1283 | use std::str::FromStr; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `alpha1` and `digit1` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:1287:40 [INFO] [stdout] | [INFO] [stdout] 1287 | use nom::character::complete::{alpha1, digit1}; [INFO] [stdout] | ^^^^^^ ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Err` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:1293:19 [INFO] [stdout] | [INFO] [stdout] 1293 | use nom::{Err, IResult}; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `version_address_segment` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:1297:132 [INFO] [stdout] | [INFO] [stdout] 1297 | ...domain_chars, skewer_chars, version_req_chars, Res, version_address_segment, version_chars, address, file_chars}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ParserExt` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:1303:42 [INFO] [stdout] | [INFO] [stdout] 1303 | use nom_supreme::{parse_from_str,ParserExt}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/version/v0_0_1/mod.rs:1741:17 [INFO] [stdout] | [INFO] [stdout] 1741 | (char_item == '"') [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 1741 - (char_item == '"') [INFO] [stdout] 1741 + char_item == '"' [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type parameter `PAYLOAD_CLAIM` should have an upper camel case name [INFO] [stdout] --> src/version/v0_0_1/mod.rs:4008:27 [INFO] [stdout] | [INFO] [stdout] 4008 | pub struct PayloadRef { [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `PayloadClaim` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type parameter `PAYLOAD_PATTERN` should have an upper camel case name [INFO] [stdout] --> src/version/v0_0_1/mod.rs:4008:42 [INFO] [stdout] | [INFO] [stdout] 4008 | pub struct PayloadRef { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `PayloadPattern` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type parameter `PAYLOAD_REF` should have an upper camel case name [INFO] [stdout] --> src/version/v0_0_1/mod.rs:4032:39 [INFO] [stdout] | [INFO] [stdout] 4032 | pub enum PayloadDelivery { [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to upper camel case: `PayloadRef` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `TryFrom` and `TryInto` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:4085:28 [INFO] [stdout] | [INFO] [stdout] 4085 | use std::convert::{TryFrom, TryInto}; [INFO] [stdout] | ^^^^^^^ ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::error::Error` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:4090:13 [INFO] [stdout] | [INFO] [stdout] 4090 | use crate::error::Error; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `PayloadMap` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:4091:56 [INFO] [stdout] | [INFO] [stdout] 4091 | use crate::version::v0_0_1::payload::{Payload, PayloadMap}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::convert::TryInto` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:2848:9 [INFO] [stdout] | [INFO] [stdout] 2848 | use std::convert::TryInto; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::collections::HashMap` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3083:9 [INFO] [stdout] | [INFO] [stdout] 3083 | use std::collections::HashMap; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Deserialize` and `Serialize` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3086:17 [INFO] [stdout] | [INFO] [stdout] 3086 | use serde::{Deserialize, Serialize}; [INFO] [stdout] | ^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `PayloadClaim`, `ResourceKind`, and `ResourceType` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3098:47 [INFO] [stdout] | [INFO] [stdout] 3098 | use crate::version::v0_0_1::id::{Address, ResourceKind, Meta, PayloadClaim, ResourceType, CaptureAddress}; [INFO] [stdout] | ^^^^^^^^^^^^ ^^^^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::version::v0_0_1::pattern::TksPattern` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3099:9 [INFO] [stdout] | [INFO] [stdout] 3099 | use crate::version::v0_0_1::pattern::TksPattern; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `RcCommandType` and `Rc` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3102:59 [INFO] [stdout] | [INFO] [stdout] 3102 | use crate::version::v0_0_1::entity::request::{Action, Rc, RcCommandType, RequestCore}; [INFO] [stdout] | ^^ ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::collections::HashMap` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:4334:9 [INFO] [stdout] | [INFO] [stdout] 4334 | use std::collections::HashMap; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ResourceKind` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:4340:47 [INFO] [stdout] | [INFO] [stdout] 4340 | use crate::version::v0_0_1::id::{Address, ResourceKind}; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Payload` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:4420:47 [INFO] [stdout] | [INFO] [stdout] 4420 | use crate::version::v0_0_1::payload::{Payload, PayloadPattern}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Rc` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:4424:55 [INFO] [stdout] | [INFO] [stdout] 4424 | use crate::version::v0_0_1::entity::request::{Rc, RequestCore}; [INFO] [stdout] | ^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::version::v0_0_1::payload::PayloadType::Primitive` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:4426:13 [INFO] [stdout] | [INFO] [stdout] 4426 | use crate::version::v0_0_1::payload::PayloadType::Primitive; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `http_pattern` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:4666:200 [INFO] [stdout] | [INFO] [stdout] 4666 | ...oped, EntityPattern, HttpPattern, MsgPattern, RcPattern, http_pattern}; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::version::v0_0_1::bin::Bin` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:4883:13 [INFO] [stdout] | [INFO] [stdout] 4883 | use crate::version::v0_0_1::bin::Bin; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `BadRequest`, `Fail`, and `NotFound` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:4888:44 [INFO] [stdout] | [INFO] [stdout] 4888 | use crate::version::v0_0_1::fail::{BadRequest, Fail, NotFound}; [INFO] [stdout] | ^^^^^^^^^^ ^^^^ ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Address`, `PayloadClaim`, `ResourceKind`, and `ResourceType` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:4889:42 [INFO] [stdout] | [INFO] [stdout] 4889 | use crate::version::v0_0_1::id::{Address, ResourceKind, Meta, PayloadClaim, ResourceType}; [INFO] [stdout] | ^^^^^^^ ^^^^^^^^^^^^ ^^^^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::version::v0_0_1::pattern::TksPattern` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:4890:13 [INFO] [stdout] | [INFO] [stdout] 4890 | use crate::version::v0_0_1::pattern::TksPattern; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::error::Error` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:4894:13 [INFO] [stdout] | [INFO] [stdout] 4894 | use crate::error::Error; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::version::v0_0_1::fail` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:4898:13 [INFO] [stdout] | [INFO] [stdout] 4898 | use crate::version::v0_0_1::fail; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::version::v0_0_1::http::HttpResponse` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:4899:13 [INFO] [stdout] | [INFO] [stdout] 4899 | use crate::version::v0_0_1::http::HttpResponse; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type parameter `PAYLOAD_CLAIM` should have an upper camel case name [INFO] [stdout] --> src/version/v0_0_1/mod.rs:4008:27 [INFO] [stdout] | [INFO] [stdout] 4008 | pub struct PayloadRef { [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `PayloadClaim` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type parameter `PAYLOAD_PATTERN` should have an upper camel case name [INFO] [stdout] --> src/version/v0_0_1/mod.rs:4008:42 [INFO] [stdout] | [INFO] [stdout] 4008 | pub struct PayloadRef { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `PayloadPattern` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type parameter `PAYLOAD_REF` should have an upper camel case name [INFO] [stdout] --> src/version/v0_0_1/mod.rs:4032:39 [INFO] [stdout] | [INFO] [stdout] 4032 | pub enum PayloadDelivery { [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to upper camel case: `PayloadRef` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `TryFrom` and `TryInto` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:4085:28 [INFO] [stdout] | [INFO] [stdout] 4085 | use std::convert::{TryFrom, TryInto}; [INFO] [stdout] | ^^^^^^^ ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::error::Error` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:4090:13 [INFO] [stdout] | [INFO] [stdout] 4090 | use crate::error::Error; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `PayloadMap` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:4091:56 [INFO] [stdout] | [INFO] [stdout] 4091 | use crate::version::v0_0_1::payload::{Payload, PayloadMap}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::version::v0_0_1::command::common::SetProperties` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5063:17 [INFO] [stdout] | [INFO] [stdout] 5063 | use crate::version::v0_0_1::command::common::SetProperties; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::version::v0_0_1::util::ConvertFrom` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5092:17 [INFO] [stdout] | [INFO] [stdout] 5092 | use crate::version::v0_0_1::util::ConvertFrom; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `HashMap` and `HashSet` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5230:36 [INFO] [stdout] | [INFO] [stdout] 5230 | use std::collections::{HashMap, HashSet}; [INFO] [stdout] | ^^^^^^^ ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::collections::HashMap` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:4334:9 [INFO] [stdout] | [INFO] [stdout] 4334 | use std::collections::HashMap; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `TryFrom` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5231:32 [INFO] [stdout] | [INFO] [stdout] 5231 | use std::convert::{TryFrom, TryInto}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ResourceKind` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:4340:47 [INFO] [stdout] | [INFO] [stdout] 4340 | use crate::version::v0_0_1::id::{Address, ResourceKind}; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::marker::PhantomData` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5232:17 [INFO] [stdout] | [INFO] [stdout] 5232 | use std::marker::PhantomData; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `BadCoercion` and `Fail` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5237:48 [INFO] [stdout] | [INFO] [stdout] 5237 | use crate::version::v0_0_1::fail::{BadCoercion, Fail}; [INFO] [stdout] | ^^^^^^^^^^^ ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::version::v0_0_1::util::ConvertFrom` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5242:17 [INFO] [stdout] | [INFO] [stdout] 5242 | use crate::version::v0_0_1::util::ConvertFrom; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5313:29 [INFO] [stdout] | [INFO] [stdout] 5313 | ... hops: hops, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `hops` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Payload` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:4420:47 [INFO] [stdout] | [INFO] [stdout] 4420 | use crate::version::v0_0_1::payload::{Payload, PayloadPattern}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Rc` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:4424:55 [INFO] [stdout] | [INFO] [stdout] 4424 | use crate::version::v0_0_1::entity::request::{Rc, RequestCore}; [INFO] [stdout] | ^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::version::v0_0_1::payload::PayloadType::Primitive` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:4426:13 [INFO] [stdout] | [INFO] [stdout] 4426 | use crate::version::v0_0_1::payload::PayloadType::Primitive; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::convert::TryInto` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5381:17 [INFO] [stdout] | [INFO] [stdout] 5381 | use std::convert::TryInto; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::error::Error` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5385:17 [INFO] [stdout] | [INFO] [stdout] 5385 | use crate::error::Error; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::version::v0_0_1::fail` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5454:13 [INFO] [stdout] | [INFO] [stdout] 5454 | use crate::version::v0_0_1::fail; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ResourceKind` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5455:57 [INFO] [stdout] | [INFO] [stdout] 5455 | use crate::version::v0_0_1::id::{Address, Meta, ResourceKind}; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `RequestCore` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5458:55 [INFO] [stdout] | [INFO] [stdout] 5458 | use crate::version::v0_0_1::entity::request::{RequestCore}; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::version::v0_0_1::fail::Fail` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5459:13 [INFO] [stdout] | [INFO] [stdout] 5459 | use crate::version::v0_0_1::fail::Fail; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `nom::CompareResult::Incomplete` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5561:9 [INFO] [stdout] | [INFO] [stdout] 5561 | use nom::CompareResult::Incomplete; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ResourceType` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5565:77 [INFO] [stdout] | [INFO] [stdout] 5565 | use crate::version::v0_0_1::id::{Address, AddressAndKind, ResourceKind, ResourceType}; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `PayloadMap` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5567:52 [INFO] [stdout] | [INFO] [stdout] 5567 | use crate::version::v0_0_1::payload::{Payload, PayloadMap}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `http_pattern` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:4666:200 [INFO] [stdout] | [INFO] [stdout] 4666 | ...oped, EntityPattern, HttpPattern, MsgPattern, RcPattern, http_pattern}; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::version::v0_0_1::bin::Bin` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:4883:13 [INFO] [stdout] | [INFO] [stdout] 4883 | use crate::version::v0_0_1::bin::Bin; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `BadRequest`, `Fail`, and `NotFound` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:4888:44 [INFO] [stdout] | [INFO] [stdout] 4888 | use crate::version::v0_0_1::fail::{BadRequest, Fail, NotFound}; [INFO] [stdout] | ^^^^^^^^^^ ^^^^ ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Address`, `PayloadClaim`, `ResourceKind`, and `ResourceType` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:4889:42 [INFO] [stdout] | [INFO] [stdout] 4889 | use crate::version::v0_0_1::id::{Address, ResourceKind, Meta, PayloadClaim, ResourceType}; [INFO] [stdout] | ^^^^^^^ ^^^^^^^^^^^^ ^^^^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::version::v0_0_1::pattern::TksPattern` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:4890:13 [INFO] [stdout] | [INFO] [stdout] 4890 | use crate::version::v0_0_1::pattern::TksPattern; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::error::Error` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:4894:13 [INFO] [stdout] | [INFO] [stdout] 4894 | use crate::error::Error; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::version::v0_0_1::fail` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:4898:13 [INFO] [stdout] | [INFO] [stdout] 4898 | use crate::version::v0_0_1::fail; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::version::v0_0_1::http::HttpResponse` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:4899:13 [INFO] [stdout] | [INFO] [stdout] 4899 | use crate::version::v0_0_1::http::HttpResponse; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::version::v0_0_1::command::common::SetProperties` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5063:17 [INFO] [stdout] | [INFO] [stdout] 5063 | use crate::version::v0_0_1::command::common::SetProperties; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::version::v0_0_1::util::ConvertFrom` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5092:17 [INFO] [stdout] | [INFO] [stdout] 5092 | use crate::version::v0_0_1::util::ConvertFrom; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::ops::Deref` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5784:13 [INFO] [stdout] | [INFO] [stdout] 5784 | use std::ops::Deref; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `ResourceKind` and `ResourceType` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5789:51 [INFO] [stdout] | [INFO] [stdout] 5789 | use crate::version::v0_0_1::id::{Address, ResourceKind, ResourceType}; [INFO] [stdout] | ^^^^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::version::v0_0_1::pattern::TksPattern` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5791:13 [INFO] [stdout] | [INFO] [stdout] 5791 | use crate::version::v0_0_1::pattern::TksPattern; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::version::v0_0_1::payload::Payload` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5792:13 [INFO] [stdout] | [INFO] [stdout] 5792 | use crate::version::v0_0_1::payload::Payload; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::version::v0_0_1::util::unique_id` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5796:13 [INFO] [stdout] | [INFO] [stdout] 5796 | use crate::version::v0_0_1::util::unique_id; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Artifact` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5878:48 [INFO] [stdout] | [INFO] [stdout] 5878 | use crate::version::v0_0_1::artifact::{Artifact, ArtifactResponse}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `ConfigBody` and `Config` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5879:54 [INFO] [stdout] | [INFO] [stdout] 5879 | use crate::version::v0_0_1::config::{Assign, Config, ConfigBody}; [INFO] [stdout] | ^^^^^^ ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `ResourceKind` and `ResourceType` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5881:51 [INFO] [stdout] | [INFO] [stdout] 5881 | use crate::version::v0_0_1::id::{Address, ResourceKind, ResourceType}; [INFO] [stdout] | ^^^^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::version::v0_0_1::payload::Payload` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5883:13 [INFO] [stdout] | [INFO] [stdout] 5883 | use crate::version::v0_0_1::payload::Payload; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `ArtifactResponse` and `Artifact` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5934:48 [INFO] [stdout] | [INFO] [stdout] 5934 | use crate::version::v0_0_1::artifact::{Artifact, ArtifactRequest, ArtifactResponse}; [INFO] [stdout] | ^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `HashMap` and `HashSet` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5230:36 [INFO] [stdout] | [INFO] [stdout] 5230 | use std::collections::{HashMap, HashSet}; [INFO] [stdout] | ^^^^^^^ ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `TryFrom` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5231:32 [INFO] [stdout] | [INFO] [stdout] 5231 | use std::convert::{TryFrom, TryInto}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::marker::PhantomData` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5232:17 [INFO] [stdout] | [INFO] [stdout] 5232 | use std::marker::PhantomData; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `BadCoercion` and `Fail` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5237:48 [INFO] [stdout] | [INFO] [stdout] 5237 | use crate::version::v0_0_1::fail::{BadCoercion, Fail}; [INFO] [stdout] | ^^^^^^^^^^^ ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Artifact` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5976:48 [INFO] [stdout] | [INFO] [stdout] 5976 | use crate::version::v0_0_1::artifact::{Artifact, ArtifactResponse}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::version::v0_0_1::util::ConvertFrom` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5242:17 [INFO] [stdout] | [INFO] [stdout] 5242 | use crate::version::v0_0_1::util::ConvertFrom; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::version::v0_0_1::id::Specific` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6146:9 [INFO] [stdout] | [INFO] [stdout] 6146 | use crate::version::v0_0_1::id::Specific; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5313:29 [INFO] [stdout] | [INFO] [stdout] 5313 | ... hops: hops, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `hops` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::convert::TryInto` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5381:17 [INFO] [stdout] | [INFO] [stdout] 5381 | use std::convert::TryInto; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::error::Error` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5385:17 [INFO] [stdout] | [INFO] [stdout] 5385 | use crate::error::Error; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Bad` and `NotFound` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6186:13 [INFO] [stdout] | [INFO] [stdout] 6186 | Bad, BadCoercion, BadRequest, Conditional, Messaging, NotFound, [INFO] [stdout] | ^^^ ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::version::v0_0_1::fail` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5454:13 [INFO] [stdout] | [INFO] [stdout] 5454 | use crate::version::v0_0_1::fail; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ResourceKind` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5455:57 [INFO] [stdout] | [INFO] [stdout] 5455 | use crate::version::v0_0_1::id::{Address, Meta, ResourceKind}; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `RequestCore` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5458:55 [INFO] [stdout] | [INFO] [stdout] 5458 | use crate::version::v0_0_1::entity::request::{RequestCore}; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::version::v0_0_1::fail::Fail` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5459:13 [INFO] [stdout] | [INFO] [stdout] 5459 | use crate::version::v0_0_1::fail::Fail; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `nom::CompareResult::Incomplete` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5561:9 [INFO] [stdout] | [INFO] [stdout] 5561 | use nom::CompareResult::Incomplete; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ResourceType` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5565:77 [INFO] [stdout] | [INFO] [stdout] 5565 | use crate::version::v0_0_1::id::{Address, AddressAndKind, ResourceKind, ResourceType}; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `PayloadMap` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5567:52 [INFO] [stdout] | [INFO] [stdout] 5567 | use crate::version::v0_0_1::payload::{Payload, PayloadMap}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::ops::Deref` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5784:13 [INFO] [stdout] | [INFO] [stdout] 5784 | use std::ops::Deref; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `ResourceKind` and `ResourceType` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5789:51 [INFO] [stdout] | [INFO] [stdout] 5789 | use crate::version::v0_0_1::id::{Address, ResourceKind, ResourceType}; [INFO] [stdout] | ^^^^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::version::v0_0_1::pattern::TksPattern` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5791:13 [INFO] [stdout] | [INFO] [stdout] 5791 | use crate::version::v0_0_1::pattern::TksPattern; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::version::v0_0_1::payload::Payload` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5792:13 [INFO] [stdout] | [INFO] [stdout] 5792 | use crate::version::v0_0_1::payload::Payload; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::version::v0_0_1::util::unique_id` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5796:13 [INFO] [stdout] | [INFO] [stdout] 5796 | use crate::version::v0_0_1::util::unique_id; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Artifact` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5878:48 [INFO] [stdout] | [INFO] [stdout] 5878 | use crate::version::v0_0_1::artifact::{Artifact, ArtifactResponse}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `ConfigBody` and `Config` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5879:54 [INFO] [stdout] | [INFO] [stdout] 5879 | use crate::version::v0_0_1::config::{Assign, Config, ConfigBody}; [INFO] [stdout] | ^^^^^^ ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `ResourceKind` and `ResourceType` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5881:51 [INFO] [stdout] | [INFO] [stdout] 5881 | use crate::version::v0_0_1::id::{Address, ResourceKind, ResourceType}; [INFO] [stdout] | ^^^^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::version::v0_0_1::payload::Payload` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5883:13 [INFO] [stdout] | [INFO] [stdout] 5883 | use crate::version::v0_0_1::payload::Payload; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `ArtifactResponse` and `Artifact` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5934:48 [INFO] [stdout] | [INFO] [stdout] 5934 | use crate::version::v0_0_1::artifact::{Artifact, ArtifactRequest, ArtifactResponse}; [INFO] [stdout] | ^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Artifact` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5976:48 [INFO] [stdout] | [INFO] [stdout] 5976 | use crate::version::v0_0_1::artifact::{Artifact, ArtifactResponse}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::version::v0_0_1::id::Specific` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6146:9 [INFO] [stdout] | [INFO] [stdout] 6146 | use crate::version::v0_0_1::id::Specific; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::str::FromStr` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6329:9 [INFO] [stdout] | [INFO] [stdout] 6329 | use std::str::FromStr; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `alpha1`, `alphanumeric1`, `multispace1`, and `space0` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6334:44 [INFO] [stdout] | [INFO] [stdout] 6334 | use nom::character::complete::{alpha0, alphanumeric1, digit1, alpha1, multispace1,multispace0, space1,space0}; [INFO] [stdout] | ^^^^^^^^^^^^^ ^^^^^^ ^^^^^^^^^^^ ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `separated_list1` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6337:46 [INFO] [stdout] | [INFO] [stdout] 6337 | use nom::multi::{many0, separated_list0, separated_list1}; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `nom_supreme::parse_from_str` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6340:9 [INFO] [stdout] | [INFO] [stdout] 6340 | use nom_supreme::parse_from_str; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Version` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6343:93 [INFO] [stdout] | [INFO] [stdout] 6343 | use crate::version::v0_0_1::id::{Address, AddressSegment, CaptureAddress, RouteSegment, Version}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `kind` and `specific` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6344:84 [INFO] [stdout] | [INFO] [stdout] 6344 | use crate::version::v0_0_1::pattern::parse::{address_kind_pattern, delim_kind, kind, resource_type, specific, specific_pattern... [INFO] [stdout] | ^^^^ ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `nom::bytes::complete::take` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6345:9 [INFO] [stdout] | [INFO] [stdout] 6345 | use nom::bytes::complete::take; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::version::v0_0_1::config::bind::parse::pipeline_step` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6348:9 [INFO] [stdout] | [INFO] [stdout] 6348 | use crate::version::v0_0_1::config::bind::parse::pipeline_step; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Bad` and `NotFound` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6186:13 [INFO] [stdout] | [INFO] [stdout] 6186 | Bad, BadCoercion, BadRequest, Conditional, Messaging, NotFound, [INFO] [stdout] | ^^^ ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::str::FromStr` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6329:9 [INFO] [stdout] | [INFO] [stdout] 6329 | use std::str::FromStr; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `alpha1`, `alphanumeric1`, `multispace1`, and `space0` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6334:44 [INFO] [stdout] | [INFO] [stdout] 6334 | use nom::character::complete::{alpha0, alphanumeric1, digit1, alpha1, multispace1,multispace0, space1,space0}; [INFO] [stdout] | ^^^^^^^^^^^^^ ^^^^^^ ^^^^^^^^^^^ ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `separated_list1` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6337:46 [INFO] [stdout] | [INFO] [stdout] 6337 | use nom::multi::{many0, separated_list0, separated_list1}; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `nom_supreme::parse_from_str` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6340:9 [INFO] [stdout] | [INFO] [stdout] 6340 | use nom_supreme::parse_from_str; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Version` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6343:93 [INFO] [stdout] | [INFO] [stdout] 6343 | use crate::version::v0_0_1::id::{Address, AddressSegment, CaptureAddress, RouteSegment, Version}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `kind` and `specific` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6344:84 [INFO] [stdout] | [INFO] [stdout] 6344 | use crate::version::v0_0_1::pattern::parse::{address_kind_pattern, delim_kind, kind, resource_type, specific, specific_pattern... [INFO] [stdout] | ^^^^ ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `nom::bytes::complete::take` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6345:9 [INFO] [stdout] | [INFO] [stdout] 6345 | use nom::bytes::complete::take; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::version::v0_0_1::config::bind::parse::pipeline_step` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6348:9 [INFO] [stdout] | [INFO] [stdout] 6348 | use crate::version::v0_0_1::config::bind::parse::pipeline_step; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::str::FromStr` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:7436:9 [INFO] [stdout] | [INFO] [stdout] 7436 | use std::str::FromStr; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `recognize` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:7438:42 [INFO] [stdout] | [INFO] [stdout] 7438 | use nom::combinator::{all_consuming, recognize}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `AddressSegment` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:7441:38 [INFO] [stdout] | [INFO] [stdout] 7441 | use crate::version::v0_0_1::id::{AddressSegment, RouteSegment}; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `base_address_segment`, `camel_case`, and `skewer_chars` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:7442:50 [INFO] [stdout] | [INFO] [stdout] 7442 | ...1::parse::{address, camel_case, route_segment, version_address_segment, skewer_chars, base_address_segment, rec_skewer, address... [INFO] [stdout] | ^^^^^^^^^^ ^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `nom::Err` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:7443:9 [INFO] [stdout] | [INFO] [stdout] 7443 | use nom::Err; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `nom::error::VerboseError` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:7444:9 [INFO] [stdout] | [INFO] [stdout] 7444 | use nom::error::VerboseError; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `pipeline_step` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:7446:100 [INFO] [stdout] | [INFO] [stdout] 7446 | use crate::version::v0_0_1::config::bind::parse::{bind, http_section, http_selector, pipeline, pipeline_step, pipeline_stop}; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `http_pattern_scoped` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:7451:57 [INFO] [stdout] | [INFO] [stdout] 7451 | use crate::version::v0_0_1::pattern::{http_pattern, http_pattern_scoped, upload_step}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `err` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:91:21 [INFO] [stdout] | [INFO] [stdout] 91 | Err(err) => { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_err` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `error` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:147:21 [INFO] [stdout] | [INFO] [stdout] 147 | Err(error) => { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_error` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `s` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:219:21 [INFO] [stdout] | [INFO] [stdout] 219 | fn from_str(s: &str) -> Result { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_s` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `err` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:91:21 [INFO] [stdout] | [INFO] [stdout] 91 | Err(err) => { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_err` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `error` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:1107:21 [INFO] [stdout] | [INFO] [stdout] 1107 | Err(error) => { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_error` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `error` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:147:21 [INFO] [stdout] | [INFO] [stdout] 147 | Err(error) => { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_error` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `s` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:219:21 [INFO] [stdout] | [INFO] [stdout] 219 | fn from_str(s: &str) -> Result { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_s` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `error` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:1107:21 [INFO] [stdout] | [INFO] [stdout] 1107 | Err(error) => { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_error` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/version/v0_0_1/mod.rs:2198:17 [INFO] [stdout] | [INFO] [stdout] 2198 | let mut entries = entries; [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `error` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:2233:17 [INFO] [stdout] | [INFO] [stdout] 2233 | Err(error) => { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_error` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `exact` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:2460:17 [INFO] [stdout] | [INFO] [stdout] 2460 | exact => ValuePattern::Pattern( [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_exact` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `next` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:2471:34 [INFO] [stdout] | [INFO] [stdout] 2471 | multispace0(input).map(|(next, _)| (input, PatternBlock::None)) [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_next` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/version/v0_0_1/mod.rs:2198:17 [INFO] [stdout] | [INFO] [stdout] 2198 | let mut entries = entries; [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `error` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:2233:17 [INFO] [stdout] | [INFO] [stdout] 2233 | Err(error) => { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_error` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `exact` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:2460:17 [INFO] [stdout] | [INFO] [stdout] 2460 | exact => ValuePattern::Pattern( [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_exact` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `next` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:2471:34 [INFO] [stdout] | [INFO] [stdout] 2471 | multispace0(input).map(|(next, _)| (input, PatternBlock::None)) [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_next` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `primitive` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3131:36 [INFO] [stdout] | [INFO] [stdout] 3131 | Payload::Primitive(primitive) => PayloadType::Primitive, [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_primitive` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `list` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3132:31 [INFO] [stdout] | [INFO] [stdout] 3132 | Payload::List(list) => PayloadType::List, [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_list` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `map` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3133:30 [INFO] [stdout] | [INFO] [stdout] 3133 | Payload::Map(map) => PayloadType::Map, [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_map` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `primitive` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3131:36 [INFO] [stdout] | [INFO] [stdout] 3131 | Payload::Primitive(primitive) => PayloadType::Primitive, [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_primitive` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `list` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3132:31 [INFO] [stdout] | [INFO] [stdout] 3132 | Payload::List(list) => PayloadType::List, [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_list` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `map` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3133:30 [INFO] [stdout] | [INFO] [stdout] 3133 | Payload::Map(map) => PayloadType::Map, [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_map` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `errors` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3848:35 [INFO] [stdout] | [INFO] [stdout] 3848 | Primitive::Errors(errors) => { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_errors` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:4134:45 [INFO] [stdout] | [INFO] [stdout] 4134 | PropertyMod::Set { key, value,lock } => { [INFO] [stdout] | ^^^^^ help: try ignoring the field: `value: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `lock` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:4134:51 [INFO] [stdout] | [INFO] [stdout] 4134 | PropertyMod::Set { key, value,lock } => { [INFO] [stdout] | ^^^^ help: try ignoring the field: `lock: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `errors` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3848:35 [INFO] [stdout] | [INFO] [stdout] 3848 | Primitive::Errors(errors) => { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_errors` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:4134:45 [INFO] [stdout] | [INFO] [stdout] 4134 | PropertyMod::Set { key, value,lock } => { [INFO] [stdout] | ^^^^^ help: try ignoring the field: `value: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `lock` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:4134:51 [INFO] [stdout] | [INFO] [stdout] 4134 | PropertyMod::Set { key, value,lock } => { [INFO] [stdout] | ^^^^ help: try ignoring the field: `lock: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5163:37 [INFO] [stdout] | [INFO] [stdout] 5163 | pub fn fulfillment( mut self, bin: Bin) -> Create { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5163:37 [INFO] [stdout] | [INFO] [stdout] 5163 | pub fn fulfillment( mut self, bin: Bin) -> Create { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `code` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5647:38 [INFO] [stdout] | [INFO] [stdout] 5647 | tag("Ok")(input).map(|(next, code)| (next, Code::Ok)) [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_code` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `err` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5656:21 [INFO] [stdout] | [INFO] [stdout] 5656 | Err(err) => { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_err` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `code` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5647:38 [INFO] [stdout] | [INFO] [stdout] 5647 | tag("Ok")(input).map(|(next, code)| (next, Code::Ok)) [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_code` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `err` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5656:21 [INFO] [stdout] | [INFO] [stdout] 5656 | Err(err) => { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_err` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `response` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5836:37 [INFO] [stdout] | [INFO] [stdout] 5836 | Frame::Response(response) => { [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_response` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `artifact` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5840:37 [INFO] [stdout] | [INFO] [stdout] 5840 | Frame::Artifact(artifact) => Option::None, [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_artifact` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `exact` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6040:39 [INFO] [stdout] | [INFO] [stdout] 6040 | ValuePattern::Pattern(exact) => match x { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_exact` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `response` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5836:37 [INFO] [stdout] | [INFO] [stdout] 5836 | Frame::Response(response) => { [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_response` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `artifact` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5840:37 [INFO] [stdout] | [INFO] [stdout] 5840 | Frame::Artifact(artifact) => Option::None, [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_artifact` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `exact` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6040:39 [INFO] [stdout] | [INFO] [stdout] 6040 | ValuePattern::Pattern(exact) => match x { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_exact` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `files_wildcard` is assigned to, but never used [INFO] [stdout] --> src/version/v0_0_1/mod.rs:7157:13 [INFO] [stdout] | [INFO] [stdout] 7157 | let mut files_wildcard = false; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_files_wildcard` instead [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `files_wildcard` is never read [INFO] [stdout] --> src/version/v0_0_1/mod.rs:7163:21 [INFO] [stdout] | [INFO] [stdout] 7163 | files_wildcard = true; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/version/v0_0_1/mod.rs:766:12 [INFO] [stdout] | [INFO] [stdout] 765 | impl Path { [INFO] [stdout] | --------- associated function in this implementation [INFO] [stdout] 766 | fn new(string: &str) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `filename` is never used [INFO] [stdout] --> src/version/v0_0_1/mod.rs:1747:8 [INFO] [stdout] | [INFO] [stdout] 1747 | fn filename(i: T) -> Res [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `MapConParam` is never used [INFO] [stdout] --> src/version/v0_0_1/mod.rs:2181:10 [INFO] [stdout] | [INFO] [stdout] 2181 | enum MapConParam { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `insert_block_pattern` is never used [INFO] [stdout] --> src/version/v0_0_1/mod.rs:2485:8 [INFO] [stdout] | [INFO] [stdout] 2485 | fn insert_block_pattern(input: &str) -> Res<&str, UploadBlock> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `space` is never used [INFO] [stdout] --> src/version/v0_0_1/mod.rs:1437:12 [INFO] [stdout] | [INFO] [stdout] 1437 | fn space(input: &str) -> Res<&str, &str> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5367:20 [INFO] [stdout] | [INFO] [stdout] 5366 | impl Select { [INFO] [stdout] | ----------- associated function in this implementation [INFO] [stdout] 5367 | fn new(pattern: AddressKindPattern) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `any_resource_path_segment` is never used [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6370:8 [INFO] [stdout] | [INFO] [stdout] 6370 | fn any_resource_path_segment(i: T) -> Res [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `files_wildcard` is assigned to, but never used [INFO] [stdout] --> src/version/v0_0_1/mod.rs:7157:13 [INFO] [stdout] | [INFO] [stdout] 7157 | let mut files_wildcard = false; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_files_wildcard` instead [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `files_wildcard` is never read [INFO] [stdout] --> src/version/v0_0_1/mod.rs:7163:21 [INFO] [stdout] | [INFO] [stdout] 7163 | files_wildcard = true; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:79:5 [INFO] [stdout] | [INFO] [stdout] 79 | / impl ToString for AddressAndKind { [INFO] [stdout] 80 | | fn to_string(&self) -> String { [INFO] [stdout] 81 | | format!("{}<{}>", self.address.to_string(), self.kind.to_string() ) [INFO] [stdout] 82 | | } [INFO] [stdout] 83 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] = note: `#[warn(clippy::to_string_trait_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:164:5 [INFO] [stdout] | [INFO] [stdout] 164 | / impl ToString for Version { [INFO] [stdout] 165 | | fn to_string(&self) -> String { [INFO] [stdout] 166 | | self.version.to_string() [INFO] [stdout] 167 | | } [INFO] [stdout] 168 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:204:5 [INFO] [stdout] | [INFO] [stdout] 204 | / impl ToString for Specific { [INFO] [stdout] 205 | | fn to_string(&self) -> String { [INFO] [stdout] 206 | | format!( [INFO] [stdout] 207 | | "{}:{}:{}:{}", [INFO] [stdout] ... | [INFO] [stdout] 214 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `ok` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:7458:16 [INFO] [stdout] | [INFO] [stdout] 7458 | Ok(ok) => { [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_ok` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:245:5 [INFO] [stdout] | [INFO] [stdout] 245 | / impl ToString for RouteSegment { [INFO] [stdout] 246 | | fn to_string(&self) -> String { [INFO] [stdout] 247 | | match self { [INFO] [stdout] 248 | | RouteSegment::Resource => "".to_string(), [INFO] [stdout] ... | [INFO] [stdout] 258 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `next` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:7489:14 [INFO] [stdout] | [INFO] [stdout] 7489 | let (next, addy) = all_consuming(address)("hello.com:bundle:1.2.3:/")?; [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_next` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `next` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:7491:13 [INFO] [stdout] | [INFO] [stdout] 7491 | let (next, addy) = all_consuming(address)("hello.com:bundle:1.2.3")?; [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_next` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `addy` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:7491:19 [INFO] [stdout] | [INFO] [stdout] 7491 | let (next, addy) = all_consuming(address)("hello.com:bundle:1.2.3")?; [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_addy` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `next` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:7493:13 [INFO] [stdout] | [INFO] [stdout] 7493 | let (next, addy) = all_consuming(address)("hello.com:bundle:1.2.3:/greater-glory/file.txt")?; [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_next` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/version/v0_0_1/mod.rs:304:13 [INFO] [stdout] | [INFO] [stdout] 304 | / match self { [INFO] [stdout] 305 | | AddressSegment::Version(_) => true, [INFO] [stdout] 306 | | _ => false [INFO] [stdout] 307 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 304 - match self { [INFO] [stdout] 305 - AddressSegment::Version(_) => true, [INFO] [stdout] 306 - _ => false [INFO] [stdout] 307 - } [INFO] [stdout] 304 + matches!(self, AddressSegment::Version(_)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:7546:13 [INFO] [stdout] | [INFO] [stdout] 7546 | let address = address.to_address(regex.captures("/index.html" ).unwrap() )?; [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/version/v0_0_1/mod.rs:311:13 [INFO] [stdout] | [INFO] [stdout] 311 | / match self { [INFO] [stdout] 312 | | AddressSegment::Dir(_) => true, [INFO] [stdout] 313 | | AddressSegment::FilesystemRootDir => true, [INFO] [stdout] 314 | | AddressSegment::File(_) => true, [INFO] [stdout] 315 | | _ => false [INFO] [stdout] 316 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 311 - match self { [INFO] [stdout] 312 - AddressSegment::Dir(_) => true, [INFO] [stdout] 313 - AddressSegment::FilesystemRootDir => true, [INFO] [stdout] 314 - AddressSegment::File(_) => true, [INFO] [stdout] 315 - _ => false [INFO] [stdout] 316 - } [INFO] [stdout] 311 + matches!(self, AddressSegment::Dir(_) | AddressSegment::FilesystemRootDir | AddressSegment::File(_)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/version/v0_0_1/mod.rs:320:13 [INFO] [stdout] | [INFO] [stdout] 320 | / match self { [INFO] [stdout] 321 | | AddressSegment::File(_) => true, [INFO] [stdout] 322 | | _ => false [INFO] [stdout] 323 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 320 - match self { [INFO] [stdout] 321 - AddressSegment::File(_) => true, [INFO] [stdout] 322 - _ => false [INFO] [stdout] 323 - } [INFO] [stdout] 320 + matches!(self, AddressSegment::File(_)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/version/v0_0_1/mod.rs:327:13 [INFO] [stdout] | [INFO] [stdout] 327 | / match self { [INFO] [stdout] 328 | | AddressSegment::Dir(_) => true, [INFO] [stdout] 329 | | AddressSegment::FilesystemRootDir => true, [INFO] [stdout] 330 | | _ => false [INFO] [stdout] 331 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 327 - match self { [INFO] [stdout] 328 - AddressSegment::Dir(_) => true, [INFO] [stdout] 329 - AddressSegment::FilesystemRootDir => true, [INFO] [stdout] 330 - _ => false [INFO] [stdout] 331 - } [INFO] [stdout] 327 + matches!(self, AddressSegment::Dir(_) | AddressSegment::FilesystemRootDir) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:361:5 [INFO] [stdout] | [INFO] [stdout] 361 | / impl ToString for AddressSegment { [INFO] [stdout] 362 | | fn to_string(&self) -> String { [INFO] [stdout] 363 | | match self { [INFO] [stdout] 364 | | AddressSegment::Space(space) => space.clone(), [INFO] [stdout] ... | [INFO] [stdout] 373 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/version/v0_0_1/mod.rs:392:13 [INFO] [stdout] | [INFO] [stdout] 392 | return self.parent().expect("expected parent").to_bundle() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 392 - return self.parent().expect("expected parent").to_bundle() [INFO] [stdout] 392 + self.parent().expect("expected parent").to_bundle() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/version/v0_0_1/mod.rs:405:13 [INFO] [stdout] | [INFO] [stdout] 405 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 405 - return false; [INFO] [stdout] 405 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/version/v0_0_1/mod.rs:410:17 [INFO] [stdout] | [INFO] [stdout] 410 | / if self.is_artifact_bundle_part() && segment.is_file() { [INFO] [stdout] 411 | | true [INFO] [stdout] 412 | | } else { [INFO] [stdout] 413 | | false [INFO] [stdout] 414 | | } [INFO] [stdout] | |_________________^ help: you can reduce it to: `self.is_artifact_bundle_part() && segment.is_file()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `get_some_plus` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:7660:13 [INFO] [stdout] | [INFO] [stdout] 7660 | let get_some_plus = RequestCore { [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_get_some_plus` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `get_some_plus` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:7693:13 [INFO] [stdout] | [INFO] [stdout] 7693 | let get_some_plus = RequestCore { [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_get_some_plus` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/version/v0_0_1/mod.rs:482:25 [INFO] [stdout] | [INFO] [stdout] 482 | path.push_str("/"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `path.push('/')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/version/v0_0_1/mod.rs:518:5 [INFO] [stdout] | [INFO] [stdout] 518 | impl Into for Address { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: `impl From for Foreign` is allowed by the orphan rules, for more information see [INFO] [stdout] https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: `#[warn(clippy::from_over_into)]` on by default [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 518 ~ impl From
for String { [INFO] [stdout] 519 ~ fn from(val: Address) -> Self { [INFO] [stdout] 520 ~ val.to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:524:5 [INFO] [stdout] | [INFO] [stdout] 524 | / impl ToString for Address { [INFO] [stdout] 525 | | fn to_string(&self) -> String { [INFO] [stdout] 526 | | let mut rtn = String::new(); [INFO] [stdout] ... | [INFO] [stdout] 554 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:615:5 [INFO] [stdout] | [INFO] [stdout] 615 | / impl ToString for CaptureAddress { [INFO] [stdout] 616 | | fn to_string(&self) -> String { [INFO] [stdout] 617 | | let mut rtn = String::new(); [INFO] [stdout] ... | [INFO] [stdout] 645 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:654:5 [INFO] [stdout] | [INFO] [stdout] 654 | / impl ToString for KindParts [INFO] [stdout] 655 | | { [INFO] [stdout] 656 | | fn to_string(&self) -> String { [INFO] [stdout] 657 | | if self.kind.is_some() && self.specific.is_some() { [INFO] [stdout] ... | [INFO] [stdout] 674 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `expect` on `self.kind` after checking its variant with `is_some` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:661:21 [INFO] [stdout] | [INFO] [stdout] 657 | if self.kind.is_some() && self.specific.is_some() { [INFO] [stdout] | ------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 661 | self.kind.as_ref().expect("kind"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `expect` on `self.specific` after checking its variant with `is_some` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:662:21 [INFO] [stdout] | [INFO] [stdout] 657 | if self.kind.is_some() && self.specific.is_some() { [INFO] [stdout] | ----------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 662 | self.specific.as_ref().expect("specific").to_string() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/version/v0_0_1/mod.rs:660:39 [INFO] [stdout] | [INFO] [stdout] 660 | self.resource_type.to_string(), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/version/v0_0_1/mod.rs:667:39 [INFO] [stdout] | [INFO] [stdout] 667 | self.resource_type.to_string(), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:695:21 [INFO] [stdout] | [INFO] [stdout] 695 | / match rest { [INFO] [stdout] 696 | | Some((kind, specific)) => { [INFO] [stdout] 697 | | rtn.kind = Option::Some(kind.to_string()); [INFO] [stdout] 698 | | match specific { [INFO] [stdout] ... | [INFO] [stdout] 705 | | None => {} [INFO] [stdout] 706 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 695 ~ if let Some((kind, specific)) = rest { [INFO] [stdout] 696 + rtn.kind = Option::Some(kind.to_string()); [INFO] [stdout] 697 + match specific { [INFO] [stdout] 698 + Some(specific) => { [INFO] [stdout] 699 + rtn.specific = Option::Some(specific); [INFO] [stdout] 700 + } [INFO] [stdout] 701 + None => {} [INFO] [stdout] 702 + } [INFO] [stdout] 703 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:698:29 [INFO] [stdout] | [INFO] [stdout] 698 | / ... match specific { [INFO] [stdout] 699 | | ... Some(specific) => { [INFO] [stdout] 700 | | ... rtn.specific = Option::Some(specific); [INFO] [stdout] ... | [INFO] [stdout] 703 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 698 ~ if let Some(specific) = specific { [INFO] [stdout] 699 + rtn.specific = Option::Some(specific); [INFO] [stdout] 700 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/version/v0_0_1/mod.rs:766:12 [INFO] [stdout] | [INFO] [stdout] 765 | impl Path { [INFO] [stdout] | --------- associated function in this implementation [INFO] [stdout] 766 | fn new(string: &str) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `filename` is never used [INFO] [stdout] --> src/version/v0_0_1/mod.rs:1747:8 [INFO] [stdout] | [INFO] [stdout] 1747 | fn filename(i: T) -> Res [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `MapConParam` is never used [INFO] [stdout] --> src/version/v0_0_1/mod.rs:2181:10 [INFO] [stdout] | [INFO] [stdout] 2181 | enum MapConParam { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `insert_block_pattern` is never used [INFO] [stdout] --> src/version/v0_0_1/mod.rs:2485:8 [INFO] [stdout] | [INFO] [stdout] 2485 | fn insert_block_pattern(input: &str) -> Res<&str, UploadBlock> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `space` is never used [INFO] [stdout] --> src/version/v0_0_1/mod.rs:1437:12 [INFO] [stdout] | [INFO] [stdout] 1437 | fn space(input: &str) -> Res<&str, &str> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5367:20 [INFO] [stdout] | [INFO] [stdout] 5366 | impl Select { [INFO] [stdout] | ----------- associated function in this implementation [INFO] [stdout] 5367 | fn new(pattern: AddressKindPattern) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `any_resource_path_segment` is never used [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6370:8 [INFO] [stdout] | [INFO] [stdout] 6370 | fn any_resource_path_segment(i: T) -> Res [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `eprintln!` args [INFO] [stdout] --> src/version/v0_0_1/mod.rs:809:50 [INFO] [stdout] | [INFO] [stdout] 809 | ... eprintln!("{}", error.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:819:13 [INFO] [stdout] | [INFO] [stdout] 819 | / match split.last() { [INFO] [stdout] 820 | | None => Option::None, [INFO] [stdout] 821 | | Some(last) => Option::Some(last.to_string()), [INFO] [stdout] 822 | | } [INFO] [stdout] | |_____________^ help: try: `split.last().map(|last| last.to_string())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:843:5 [INFO] [stdout] | [INFO] [stdout] 843 | / impl ToString for Path { [INFO] [stdout] 844 | | fn to_string(&self) -> String { [INFO] [stdout] 845 | | self.string.clone() [INFO] [stdout] 846 | | } [INFO] [stdout] 847 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/version/v0_0_1/mod.rs:1022:51 [INFO] [stdout] | [INFO] [stdout] 1022 | } else if address_kind_path.is_root() { [INFO] [stdout] | ___________________________________________________^ [INFO] [stdout] 1023 | | false [INFO] [stdout] 1024 | | } else if self.is_root() { [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/version/v0_0_1/mod.rs:1024:38 [INFO] [stdout] | [INFO] [stdout] 1024 | } else if self.is_root() { [INFO] [stdout] | ______________________________________^ [INFO] [stdout] 1025 | | false [INFO] [stdout] 1026 | | } else if address_kind_path.is_final() { [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:1115:5 [INFO] [stdout] | [INFO] [stdout] 1115 | / impl ToString for VersionReq { [INFO] [stdout] 1116 | | fn to_string(&self) -> String { [INFO] [stdout] 1117 | | self.version.to_string() [INFO] [stdout] 1118 | | } [INFO] [stdout] 1119 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:79:5 [INFO] [stdout] | [INFO] [stdout] 79 | / impl ToString for AddressAndKind { [INFO] [stdout] 80 | | fn to_string(&self) -> String { [INFO] [stdout] 81 | | format!("{}<{}>", self.address.to_string(), self.kind.to_string() ) [INFO] [stdout] 82 | | } [INFO] [stdout] 83 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] = note: `#[warn(clippy::to_string_trait_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/version/v0_0_1/mod.rs:1148:13 [INFO] [stdout] | [INFO] [stdout] 1148 | / match self { [INFO] [stdout] 1149 | | SegmentPattern::Exact(_) => true, [INFO] [stdout] 1150 | | _ => false, [INFO] [stdout] 1151 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 1148 - match self { [INFO] [stdout] 1149 - SegmentPattern::Exact(_) => true, [INFO] [stdout] 1150 - _ => false, [INFO] [stdout] 1151 - } [INFO] [stdout] 1148 + matches!(self, SegmentPattern::Exact(_)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:164:5 [INFO] [stdout] | [INFO] [stdout] 164 | / impl ToString for Version { [INFO] [stdout] 165 | | fn to_string(&self) -> String { [INFO] [stdout] 166 | | self.version.to_string() [INFO] [stdout] 167 | | } [INFO] [stdout] 168 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:204:5 [INFO] [stdout] | [INFO] [stdout] 204 | / impl ToString for Specific { [INFO] [stdout] 205 | | fn to_string(&self) -> String { [INFO] [stdout] 206 | | format!( [INFO] [stdout] 207 | | "{}:{}:{}:{}", [INFO] [stdout] ... | [INFO] [stdout] 214 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:1235:5 [INFO] [stdout] | [INFO] [stdout] 1235 | / impl ToString for SpecificPattern { [INFO] [stdout] 1236 | | fn to_string(&self) -> String { [INFO] [stdout] 1237 | | format!( [INFO] [stdout] 1238 | | "{}:{}:{}:({})", [INFO] [stdout] ... | [INFO] [stdout] 1245 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:245:5 [INFO] [stdout] | [INFO] [stdout] 245 | / impl ToString for RouteSegment { [INFO] [stdout] 246 | | fn to_string(&self) -> String { [INFO] [stdout] 247 | | match self { [INFO] [stdout] 248 | | RouteSegment::Resource => "".to_string(), [INFO] [stdout] ... | [INFO] [stdout] 258 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:1486:17 [INFO] [stdout] | [INFO] [stdout] 1486 | / match more { [INFO] [stdout] 1487 | | Some((kind, specific)) => { [INFO] [stdout] 1488 | | parts.kind = Option::Some(kind.to_string()); [INFO] [stdout] 1489 | | parts.specific = specific; [INFO] [stdout] 1490 | | } [INFO] [stdout] 1491 | | None => {} [INFO] [stdout] 1492 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1486 ~ if let Some((kind, specific)) = more { [INFO] [stdout] 1487 + parts.kind = Option::Some(kind.to_string()); [INFO] [stdout] 1488 + parts.specific = specific; [INFO] [stdout] 1489 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary map of the identity function [INFO] [stdout] --> src/version/v0_0_1/mod.rs:1505:30 [INFO] [stdout] | [INFO] [stdout] 1505 | .parse(input) [INFO] [stdout] | ______________________________^ [INFO] [stdout] 1506 | | .map(|(next, kind)| (next, kind)) [INFO] [stdout] | |_________________________________________________^ help: remove the call to `map` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_identity [INFO] [stdout] = note: `#[warn(clippy::map_identity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `version::v0_0_1::id::KindParts` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:1518:16 [INFO] [stdout] | [INFO] [stdout] 1518 | Ok(kind_parts.try_into()?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary map of the identity function [INFO] [stdout] --> src/version/v0_0_1/mod.rs:1523:33 [INFO] [stdout] | [INFO] [stdout] 1523 | pattern(kind)(input).map(|(next, kind)| (next, kind)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the call to `map` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_identity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/version/v0_0_1/mod.rs:304:13 [INFO] [stdout] | [INFO] [stdout] 304 | / match self { [INFO] [stdout] 305 | | AddressSegment::Version(_) => true, [INFO] [stdout] 306 | | _ => false [INFO] [stdout] 307 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 304 - match self { [INFO] [stdout] 305 - AddressSegment::Version(_) => true, [INFO] [stdout] 306 - _ => false [INFO] [stdout] 307 - } [INFO] [stdout] 304 + matches!(self, AddressSegment::Version(_)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/version/v0_0_1/mod.rs:311:13 [INFO] [stdout] | [INFO] [stdout] 311 | / match self { [INFO] [stdout] 312 | | AddressSegment::Dir(_) => true, [INFO] [stdout] 313 | | AddressSegment::FilesystemRootDir => true, [INFO] [stdout] 314 | | AddressSegment::File(_) => true, [INFO] [stdout] 315 | | _ => false [INFO] [stdout] 316 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 311 - match self { [INFO] [stdout] 312 - AddressSegment::Dir(_) => true, [INFO] [stdout] 313 - AddressSegment::FilesystemRootDir => true, [INFO] [stdout] 314 - AddressSegment::File(_) => true, [INFO] [stdout] 315 - _ => false [INFO] [stdout] 316 - } [INFO] [stdout] 311 + matches!(self, AddressSegment::Dir(_) | AddressSegment::FilesystemRootDir | AddressSegment::File(_)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/version/v0_0_1/mod.rs:320:13 [INFO] [stdout] | [INFO] [stdout] 320 | / match self { [INFO] [stdout] 321 | | AddressSegment::File(_) => true, [INFO] [stdout] 322 | | _ => false [INFO] [stdout] 323 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 320 - match self { [INFO] [stdout] 321 - AddressSegment::File(_) => true, [INFO] [stdout] 322 - _ => false [INFO] [stdout] 323 - } [INFO] [stdout] 320 + matches!(self, AddressSegment::File(_)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/version/v0_0_1/mod.rs:327:13 [INFO] [stdout] | [INFO] [stdout] 327 | / match self { [INFO] [stdout] 328 | | AddressSegment::Dir(_) => true, [INFO] [stdout] 329 | | AddressSegment::FilesystemRootDir => true, [INFO] [stdout] 330 | | _ => false [INFO] [stdout] 331 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 327 - match self { [INFO] [stdout] 328 - AddressSegment::Dir(_) => true, [INFO] [stdout] 329 - AddressSegment::FilesystemRootDir => true, [INFO] [stdout] 330 - _ => false [INFO] [stdout] 331 - } [INFO] [stdout] 327 + matches!(self, AddressSegment::Dir(_) | AddressSegment::FilesystemRootDir) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:361:5 [INFO] [stdout] | [INFO] [stdout] 361 | / impl ToString for AddressSegment { [INFO] [stdout] 362 | | fn to_string(&self) -> String { [INFO] [stdout] 363 | | match self { [INFO] [stdout] 364 | | AddressSegment::Space(space) => space.clone(), [INFO] [stdout] ... | [INFO] [stdout] 373 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:1725:17 [INFO] [stdout] | [INFO] [stdout] 1725 | / !(char_item == '-') [INFO] [stdout] 1726 | | && !((char_item.is_alpha() && char_item.is_lowercase()) [INFO] [stdout] 1727 | | || char_item.is_dec_digit()) [INFO] [stdout] | |____________________________________________________^ help: try: `!((char_item == '-') || char_item.is_dec_digit() || char_item.is_alpha() && char_item.is_lowercase())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:1725:17 [INFO] [stdout] | [INFO] [stdout] 1725 | !(char_item == '-') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '-')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:1755:17 [INFO] [stdout] | [INFO] [stdout] 1755 | !(char_item == '-') && !(char_item.is_alpha() || char_item.is_dec_digit()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!((char_item == '-') || char_item.is_alpha() || char_item.is_dec_digit())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:1755:17 [INFO] [stdout] | [INFO] [stdout] 1755 | !(char_item == '-') && !(char_item.is_alpha() || char_item.is_dec_digit()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '-')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/version/v0_0_1/mod.rs:392:13 [INFO] [stdout] | [INFO] [stdout] 392 | return self.parent().expect("expected parent").to_bundle() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 392 - return self.parent().expect("expected parent").to_bundle() [INFO] [stdout] 392 + self.parent().expect("expected parent").to_bundle() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/version/v0_0_1/mod.rs:1808:38 [INFO] [stdout] | [INFO] [stdout] 1808 | ... found.to_string() [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/version/v0_0_1/mod.rs:405:13 [INFO] [stdout] | [INFO] [stdout] 405 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 405 - return false; [INFO] [stdout] 405 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/version/v0_0_1/mod.rs:1820:38 [INFO] [stdout] | [INFO] [stdout] 1820 | ... found.to_string() [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/version/v0_0_1/mod.rs:410:17 [INFO] [stdout] | [INFO] [stdout] 410 | / if self.is_artifact_bundle_part() && segment.is_file() { [INFO] [stdout] 411 | | true [INFO] [stdout] 412 | | } else { [INFO] [stdout] 413 | | false [INFO] [stdout] 414 | | } [INFO] [stdout] | |_________________^ help: you can reduce it to: `self.is_artifact_bundle_part() && segment.is_file()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:1829:5 [INFO] [stdout] | [INFO] [stdout] 1829 | / impl ToString for EntityPattern { [INFO] [stdout] 1830 | | fn to_string(&self) -> String { [INFO] [stdout] 1831 | | match self { [INFO] [stdout] 1832 | | EntityPattern::Rc(rc) => rc.to_string(), [INFO] [stdout] ... | [INFO] [stdout] 1837 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/version/v0_0_1/mod.rs:482:25 [INFO] [stdout] | [INFO] [stdout] 482 | path.push_str("/"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `path.push('/')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:1859:5 [INFO] [stdout] | [INFO] [stdout] 1859 | / impl ToString for RcPattern { [INFO] [stdout] 1860 | | fn to_string(&self) -> String { [INFO] [stdout] 1861 | | format!("Rc<{}>", self.command.to_string()) [INFO] [stdout] 1862 | | } [INFO] [stdout] 1863 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/version/v0_0_1/mod.rs:518:5 [INFO] [stdout] | [INFO] [stdout] 518 | impl Into for Address { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: `impl From for Foreign` is allowed by the orphan rules, for more information see [INFO] [stdout] https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: `#[warn(clippy::from_over_into)]` on by default [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 518 ~ impl From
for String { [INFO] [stdout] 519 ~ fn from(val: Address) -> Self { [INFO] [stdout] 520 ~ val.to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:524:5 [INFO] [stdout] | [INFO] [stdout] 524 | / impl ToString for Address { [INFO] [stdout] 525 | | fn to_string(&self) -> String { [INFO] [stdout] 526 | | let mut rtn = String::new(); [INFO] [stdout] ... | [INFO] [stdout] 554 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:1871:5 [INFO] [stdout] | [INFO] [stdout] 1871 | / impl ToString for MsgPattern { [INFO] [stdout] 1872 | | fn to_string(&self) -> String { [INFO] [stdout] 1873 | | format!("Msg<{}>{}", self.action.to_string(), self.path_regex) [INFO] [stdout] 1874 | | } [INFO] [stdout] 1875 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:615:5 [INFO] [stdout] | [INFO] [stdout] 615 | / impl ToString for CaptureAddress { [INFO] [stdout] 616 | | fn to_string(&self) -> String { [INFO] [stdout] 617 | | let mut rtn = String::new(); [INFO] [stdout] ... | [INFO] [stdout] 645 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:1903:5 [INFO] [stdout] | [INFO] [stdout] 1903 | / impl ToString for HttpPattern { [INFO] [stdout] 1904 | | fn to_string(&self) -> String { [INFO] [stdout] 1905 | | format!("Http<{}>{}", self.method.to_string(), self.path_regex) [INFO] [stdout] 1906 | | } [INFO] [stdout] 1907 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/version/v0_0_1/mod.rs:1913:38 [INFO] [stdout] | [INFO] [stdout] 1913 | self.method.is_match(&method)?; [INFO] [stdout] | ^^^^^^^ help: change this to: `method` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:654:5 [INFO] [stdout] | [INFO] [stdout] 654 | / impl ToString for KindParts [INFO] [stdout] 655 | | { [INFO] [stdout] 656 | | fn to_string(&self) -> String { [INFO] [stdout] 657 | | if self.kind.is_some() && self.specific.is_some() { [INFO] [stdout] ... | [INFO] [stdout] 674 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `expect` on `self.kind` after checking its variant with `is_some` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:661:21 [INFO] [stdout] | [INFO] [stdout] 657 | if self.kind.is_some() && self.specific.is_some() { [INFO] [stdout] | ------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 661 | self.kind.as_ref().expect("kind"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `expect` on `self.specific` after checking its variant with `is_some` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:662:21 [INFO] [stdout] | [INFO] [stdout] 657 | if self.kind.is_some() && self.specific.is_some() { [INFO] [stdout] | ----------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 662 | self.specific.as_ref().expect("specific").to_string() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/version/v0_0_1/mod.rs:660:39 [INFO] [stdout] | [INFO] [stdout] 660 | self.resource_type.to_string(), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/version/v0_0_1/mod.rs:667:39 [INFO] [stdout] | [INFO] [stdout] 667 | self.resource_type.to_string(), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:695:21 [INFO] [stdout] | [INFO] [stdout] 695 | / match rest { [INFO] [stdout] 696 | | Some((kind, specific)) => { [INFO] [stdout] 697 | | rtn.kind = Option::Some(kind.to_string()); [INFO] [stdout] 698 | | match specific { [INFO] [stdout] ... | [INFO] [stdout] 705 | | None => {} [INFO] [stdout] 706 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 695 ~ if let Some((kind, specific)) = rest { [INFO] [stdout] 696 + rtn.kind = Option::Some(kind.to_string()); [INFO] [stdout] 697 + match specific { [INFO] [stdout] 698 + Some(specific) => { [INFO] [stdout] 699 + rtn.specific = Option::Some(specific); [INFO] [stdout] 700 + } [INFO] [stdout] 701 + None => {} [INFO] [stdout] 702 + } [INFO] [stdout] 703 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:698:29 [INFO] [stdout] | [INFO] [stdout] 698 | / ... match specific { [INFO] [stdout] 699 | | ... Some(specific) => { [INFO] [stdout] 700 | | ... rtn.specific = Option::Some(specific); [INFO] [stdout] ... | [INFO] [stdout] 703 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 698 ~ if let Some(specific) = specific { [INFO] [stdout] 699 + rtn.specific = Option::Some(specific); [INFO] [stdout] 700 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `eprintln!` args [INFO] [stdout] --> src/version/v0_0_1/mod.rs:809:50 [INFO] [stdout] | [INFO] [stdout] 809 | ... eprintln!("{}", error.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:819:13 [INFO] [stdout] | [INFO] [stdout] 819 | / match split.last() { [INFO] [stdout] 820 | | None => Option::None, [INFO] [stdout] 821 | | Some(last) => Option::Some(last.to_string()), [INFO] [stdout] 822 | | } [INFO] [stdout] | |_____________^ help: try: `split.last().map(|last| last.to_string())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:843:5 [INFO] [stdout] | [INFO] [stdout] 843 | / impl ToString for Path { [INFO] [stdout] 844 | | fn to_string(&self) -> String { [INFO] [stdout] 845 | | self.string.clone() [INFO] [stdout] 846 | | } [INFO] [stdout] 847 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary map of the identity function [INFO] [stdout] --> src/version/v0_0_1/mod.rs:2144:65 [INFO] [stdout] | [INFO] [stdout] 2144 | delimited(tag("["), map_entry_patterns, tag("]"))(input) [INFO] [stdout] | _________________________________________________________________^ [INFO] [stdout] 2145 | | .map(|(next, params)| (next, params)) [INFO] [stdout] | |_________________________________________________^ help: remove the call to `map` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_identity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary map of the identity function [INFO] [stdout] --> src/version/v0_0_1/mod.rs:2149:31 [INFO] [stdout] | [INFO] [stdout] 2149 | payload_pattern(input).map(|(next, con)| (next, con)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the call to `map` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_identity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:2161:13 [INFO] [stdout] | [INFO] [stdout] 2161 | / match required { [INFO] [stdout] 2162 | | Option::Some(required) => { [INFO] [stdout] 2163 | | for require in required { [INFO] [stdout] 2164 | | required_map.insert(require.key, require.payload); [INFO] [stdout] ... | [INFO] [stdout] 2167 | | Option::None => {} [INFO] [stdout] 2168 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 2161 ~ if let Option::Some(required) = required { [INFO] [stdout] 2162 + for require in required { [INFO] [stdout] 2163 + required_map.insert(require.key, require.payload); [INFO] [stdout] 2164 + } [INFO] [stdout] 2165 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/version/v0_0_1/mod.rs:1022:51 [INFO] [stdout] | [INFO] [stdout] 1022 | } else if address_kind_path.is_root() { [INFO] [stdout] | ___________________________________________________^ [INFO] [stdout] 1023 | | false [INFO] [stdout] 1024 | | } else if self.is_root() { [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/version/v0_0_1/mod.rs:1024:38 [INFO] [stdout] | [INFO] [stdout] 1024 | } else if self.is_root() { [INFO] [stdout] | ______________________________________^ [INFO] [stdout] 1025 | | false [INFO] [stdout] 1026 | | } else if address_kind_path.is_final() { [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary map of the identity function [INFO] [stdout] --> src/version/v0_0_1/mod.rs:2452:64 [INFO] [stdout] | [INFO] [stdout] 2452 | value_pattern(input, payload_structure_with_validation) [INFO] [stdout] | ________________________________________________________________^ [INFO] [stdout] 2453 | | .map(|(next, payload_pattern)| (next, payload_pattern)) [INFO] [stdout] | |___________________________________________________________________^ help: remove the call to `map` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_identity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:1115:5 [INFO] [stdout] | [INFO] [stdout] 1115 | / impl ToString for VersionReq { [INFO] [stdout] 1116 | | fn to_string(&self) -> String { [INFO] [stdout] 1117 | | self.version.to_string() [INFO] [stdout] 1118 | | } [INFO] [stdout] 1119 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/version/v0_0_1/mod.rs:1148:13 [INFO] [stdout] | [INFO] [stdout] 1148 | / match self { [INFO] [stdout] 1149 | | SegmentPattern::Exact(_) => true, [INFO] [stdout] 1150 | | _ => false, [INFO] [stdout] 1151 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 1148 - match self { [INFO] [stdout] 1149 - SegmentPattern::Exact(_) => true, [INFO] [stdout] 1150 - _ => false, [INFO] [stdout] 1151 - } [INFO] [stdout] 1148 + matches!(self, SegmentPattern::Exact(_)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/version/v0_0_1/mod.rs:2659:5 [INFO] [stdout] | [INFO] [stdout] 2659 | impl Into> for Pattern<&str> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] help: replace the `Into` implementation with `From>` [INFO] [stdout] | [INFO] [stdout] 2659 ~ impl From> for Pattern { [INFO] [stdout] 2660 ~ fn from(val: Pattern<&str>) -> Self { [INFO] [stdout] 2661 ~ match val { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:2668:5 [INFO] [stdout] | [INFO] [stdout] 2668 | / impl

ToString for Pattern

[INFO] [stdout] 2669 | | where [INFO] [stdout] 2670 | | P: ToString, [INFO] [stdout] ... | [INFO] [stdout] 2678 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/version/v0_0_1/mod.rs:2720:5 [INFO] [stdout] | [INFO] [stdout] 2720 | impl Into> for EmptyPattern<&str> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] help: replace the `Into` implementation with `From>` [INFO] [stdout] | [INFO] [stdout] 2720 ~ impl From> for EmptyPattern { [INFO] [stdout] 2721 ~ fn from(val: EmptyPattern<&str>) -> Self { [INFO] [stdout] 2722 ~ match val { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:1235:5 [INFO] [stdout] | [INFO] [stdout] 1235 | / impl ToString for SpecificPattern { [INFO] [stdout] 1236 | | fn to_string(&self) -> String { [INFO] [stdout] 1237 | | format!( [INFO] [stdout] 1238 | | "{}:{}:{}:({})", [INFO] [stdout] ... | [INFO] [stdout] 1245 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:2729:5 [INFO] [stdout] | [INFO] [stdout] 2729 | / impl

ToString for EmptyPattern

[INFO] [stdout] 2730 | | where [INFO] [stdout] 2731 | | P: ToString, [INFO] [stdout] ... | [INFO] [stdout] 2739 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:2798:5 [INFO] [stdout] | [INFO] [stdout] 2798 | / impl ToString for AddressKindPath [INFO] [stdout] 2799 | | { [INFO] [stdout] 2800 | | fn to_string(&self) -> String { [INFO] [stdout] 2801 | | let mut rtn = String::new(); [INFO] [stdout] ... | [INFO] [stdout] 2819 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:1486:17 [INFO] [stdout] | [INFO] [stdout] 1486 | / match more { [INFO] [stdout] 1487 | | Some((kind, specific)) => { [INFO] [stdout] 1488 | | parts.kind = Option::Some(kind.to_string()); [INFO] [stdout] 1489 | | parts.specific = specific; [INFO] [stdout] 1490 | | } [INFO] [stdout] 1491 | | None => {} [INFO] [stdout] 1492 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1486 ~ if let Some((kind, specific)) = more { [INFO] [stdout] 1487 + parts.kind = Option::Some(kind.to_string()); [INFO] [stdout] 1488 + parts.specific = specific; [INFO] [stdout] 1489 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary map of the identity function [INFO] [stdout] --> src/version/v0_0_1/mod.rs:1505:30 [INFO] [stdout] | [INFO] [stdout] 1505 | .parse(input) [INFO] [stdout] | ______________________________^ [INFO] [stdout] 1506 | | .map(|(next, kind)| (next, kind)) [INFO] [stdout] | |_________________________________________________^ help: remove the call to `map` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_identity [INFO] [stdout] = note: `#[warn(clippy::map_identity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `version::v0_0_1::id::KindParts` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:1518:16 [INFO] [stdout] | [INFO] [stdout] 1518 | Ok(kind_parts.try_into()?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary map of the identity function [INFO] [stdout] --> src/version/v0_0_1/mod.rs:1523:33 [INFO] [stdout] | [INFO] [stdout] 1523 | pattern(kind)(input).map(|(next, kind)| (next, kind)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the call to `map` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_identity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:2827:5 [INFO] [stdout] | [INFO] [stdout] 2827 | / impl ToString for AddressKindSegment { [INFO] [stdout] 2828 | | fn to_string(&self) -> String { [INFO] [stdout] 2829 | | format!( [INFO] [stdout] 2830 | | "{}<{}>", [INFO] [stdout] ... | [INFO] [stdout] 2835 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/version/v0_0_1/mod.rs:2842:13 [INFO] [stdout] | [INFO] [stdout] 2842 | Ok(consume_address_kind_path(s)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 2842 - Ok(consume_address_kind_path(s)?) [INFO] [stdout] 2842 + consume_address_kind_path(s) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:1725:17 [INFO] [stdout] | [INFO] [stdout] 1725 | / !(char_item == '-') [INFO] [stdout] 1726 | | && !((char_item.is_alpha() && char_item.is_lowercase()) [INFO] [stdout] 1727 | | || char_item.is_dec_digit()) [INFO] [stdout] | |____________________________________________________^ help: try: `!((char_item == '-') || char_item.is_dec_digit() || char_item.is_alpha() && char_item.is_lowercase())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:1725:17 [INFO] [stdout] | [INFO] [stdout] 1725 | !(char_item == '-') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '-')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:1755:17 [INFO] [stdout] | [INFO] [stdout] 1755 | !(char_item == '-') && !(char_item.is_alpha() || char_item.is_dec_digit()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!((char_item == '-') || char_item.is_alpha() || char_item.is_dec_digit())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:1755:17 [INFO] [stdout] | [INFO] [stdout] 1755 | !(char_item == '-') && !(char_item.is_alpha() || char_item.is_dec_digit()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '-')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/version/v0_0_1/mod.rs:1808:38 [INFO] [stdout] | [INFO] [stdout] 1808 | ... found.to_string() [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/version/v0_0_1/mod.rs:1820:38 [INFO] [stdout] | [INFO] [stdout] 1820 | ... found.to_string() [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:1829:5 [INFO] [stdout] | [INFO] [stdout] 1829 | / impl ToString for EntityPattern { [INFO] [stdout] 1830 | | fn to_string(&self) -> String { [INFO] [stdout] 1831 | | match self { [INFO] [stdout] 1832 | | EntityPattern::Rc(rc) => rc.to_string(), [INFO] [stdout] ... | [INFO] [stdout] 1837 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/version/v0_0_1/mod.rs:2890:13 [INFO] [stdout] | [INFO] [stdout] 2883 | / let response = Response { [INFO] [stdout] 2884 | | id: unique_id(), [INFO] [stdout] 2885 | | from: self.to, [INFO] [stdout] 2886 | | to: self.from, [INFO] [stdout] 2887 | | core, [INFO] [stdout] 2888 | | response_to: self.id [INFO] [stdout] 2889 | | }; [INFO] [stdout] | |______________- unnecessary `let` binding [INFO] [stdout] 2890 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 2883 ~ [INFO] [stdout] 2884 ~ Response { [INFO] [stdout] 2885 + id: unique_id(), [INFO] [stdout] 2886 + from: self.to, [INFO] [stdout] 2887 + to: self.from, [INFO] [stdout] 2888 + core, [INFO] [stdout] 2889 + response_to: self.id [INFO] [stdout] 2890 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:1859:5 [INFO] [stdout] | [INFO] [stdout] 1859 | / impl ToString for RcPattern { [INFO] [stdout] 1860 | | fn to_string(&self) -> String { [INFO] [stdout] 1861 | | format!("Rc<{}>", self.command.to_string()) [INFO] [stdout] 1862 | | } [INFO] [stdout] 1863 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:1871:5 [INFO] [stdout] | [INFO] [stdout] 1871 | / impl ToString for MsgPattern { [INFO] [stdout] 1872 | | fn to_string(&self) -> String { [INFO] [stdout] 1873 | | format!("Msg<{}>{}", self.action.to_string(), self.path_regex) [INFO] [stdout] 1874 | | } [INFO] [stdout] 1875 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/version/v0_0_1/mod.rs:2906:13 [INFO] [stdout] | [INFO] [stdout] 2899 | / let response = Response { [INFO] [stdout] 2900 | | id: unique_id(), [INFO] [stdout] 2901 | | from: self.to, [INFO] [stdout] 2902 | | to: self.from, [INFO] [stdout] 2903 | | core, [INFO] [stdout] 2904 | | response_to: self.id [INFO] [stdout] 2905 | | }; [INFO] [stdout] | |______________- unnecessary `let` binding [INFO] [stdout] 2906 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 2899 ~ [INFO] [stdout] 2900 ~ Response { [INFO] [stdout] 2901 + id: unique_id(), [INFO] [stdout] 2902 + from: self.to, [INFO] [stdout] 2903 + to: self.from, [INFO] [stdout] 2904 + core, [INFO] [stdout] 2905 + response_to: self.id [INFO] [stdout] 2906 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `ProtoRequest` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:2918:9 [INFO] [stdout] | [INFO] [stdout] 2918 | / pub fn new() -> Self { [INFO] [stdout] 2919 | | Self { [INFO] [stdout] 2920 | | id: unique_id(), [INFO] [stdout] 2921 | | to: Option::None, [INFO] [stdout] ... | [INFO] [stdout] 2924 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 2917 ~ impl Default for ProtoRequest { [INFO] [stdout] 2918 + fn default() -> Self { [INFO] [stdout] 2919 + Self::new() [INFO] [stdout] 2920 + } [INFO] [stdout] 2921 + } [INFO] [stdout] 2922 + [INFO] [stdout] 2923 ~ impl ProtoRequest { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:1903:5 [INFO] [stdout] | [INFO] [stdout] 1903 | / impl ToString for HttpPattern { [INFO] [stdout] 1904 | | fn to_string(&self) -> String { [INFO] [stdout] 1905 | | format!("Http<{}>{}", self.method.to_string(), self.path_regex) [INFO] [stdout] 1906 | | } [INFO] [stdout] 1907 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/version/v0_0_1/mod.rs:1913:38 [INFO] [stdout] | [INFO] [stdout] 1913 | self.method.is_match(&method)?; [INFO] [stdout] | ^^^^^^^ help: change this to: `method` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> src/version/v0_0_1/mod.rs:2986:5 [INFO] [stdout] | [INFO] [stdout] 2986 | / pub enum Message { [INFO] [stdout] 2987 | | Request(Request), [INFO] [stdout] | | ---------------- the largest variant contains at least 1264 bytes [INFO] [stdout] 2988 | | Response(Response) [INFO] [stdout] | | ------------------ the second-largest variant contains at least 576 bytes [INFO] [stdout] 2989 | | } [INFO] [stdout] | |_____^ the entire enum is at least 1264 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] = note: `#[warn(clippy::large_enum_variant)]` on by default [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 2987 - Request(Request), [INFO] [stdout] 2987 + Request(Box), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3108:5 [INFO] [stdout] | [INFO] [stdout] 3108 | / pub enum Payload { [INFO] [stdout] 3109 | | Empty, [INFO] [stdout] 3110 | | Primitive(Primitive), [INFO] [stdout] | | -------------------- the largest variant contains at least 360 bytes [INFO] [stdout] 3111 | | List(PrimitiveList), [INFO] [stdout] 3112 | | Map(PayloadMap), [INFO] [stdout] | | --------------- the second-largest variant contains at least 48 bytes [INFO] [stdout] 3113 | | } [INFO] [stdout] | |_____^ the entire enum is at least 360 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 3110 - Primitive(Primitive), [INFO] [stdout] 3110 + Primitive(Box), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary map of the identity function [INFO] [stdout] --> src/version/v0_0_1/mod.rs:2144:65 [INFO] [stdout] | [INFO] [stdout] 2144 | delimited(tag("["), map_entry_patterns, tag("]"))(input) [INFO] [stdout] | _________________________________________________________________^ [INFO] [stdout] 2145 | | .map(|(next, params)| (next, params)) [INFO] [stdout] | |_________________________________________________^ help: remove the call to `map` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_identity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary map of the identity function [INFO] [stdout] --> src/version/v0_0_1/mod.rs:2149:31 [INFO] [stdout] | [INFO] [stdout] 2149 | payload_pattern(input).map(|(next, con)| (next, con)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the call to `map` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_identity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:2161:13 [INFO] [stdout] | [INFO] [stdout] 2161 | / match required { [INFO] [stdout] 2162 | | Option::Some(required) => { [INFO] [stdout] 2163 | | for require in required { [INFO] [stdout] 2164 | | required_map.insert(require.key, require.payload); [INFO] [stdout] ... | [INFO] [stdout] 2167 | | Option::None => {} [INFO] [stdout] 2168 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 2161 ~ if let Option::Some(required) = required { [INFO] [stdout] 2162 + for require in required { [INFO] [stdout] 2163 + required_map.insert(require.key, require.payload); [INFO] [stdout] 2164 + } [INFO] [stdout] 2165 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let .. else` expression looks like `matches!` macro [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3117:13 [INFO] [stdout] | [INFO] [stdout] 3117 | / if let Self::Empty = self { [INFO] [stdout] 3118 | | false [INFO] [stdout] 3119 | | } else { [INFO] [stdout] 3120 | | true [INFO] [stdout] 3121 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 3117 - if let Self::Empty = self { [INFO] [stdout] 3118 - false [INFO] [stdout] 3119 - } else { [INFO] [stdout] 3120 - true [INFO] [stdout] 3121 - } [INFO] [stdout] 3117 + !matches!(self, Self::Empty) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3172:5 [INFO] [stdout] | [INFO] [stdout] 3172 | impl Into for PayloadMap { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 3172 ~ impl From for Payload { [INFO] [stdout] 3173 ~ fn from(val: PayloadMap) -> Self { [INFO] [stdout] 3174 ~ Payload::Map(val) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3192:5 [INFO] [stdout] | [INFO] [stdout] 3192 | / impl Default for PayloadMap { [INFO] [stdout] 3193 | | fn default() -> Self { [INFO] [stdout] 3194 | | Self { [INFO] [stdout] 3195 | | map: Default::default(), [INFO] [stdout] ... | [INFO] [stdout] 3198 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 3168 ~ #[derive(Default)] [INFO] [stdout] 3169 ~ pub struct PayloadMap { [INFO] [stdout] 3170 | pub map: HashMap, [INFO] [stdout] ... [INFO] [stdout] 3192 | [INFO] [stdout] 3193 ~ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary map of the identity function [INFO] [stdout] --> src/version/v0_0_1/mod.rs:2452:64 [INFO] [stdout] | [INFO] [stdout] 2452 | value_pattern(input, payload_structure_with_validation) [INFO] [stdout] | ________________________________________________________________^ [INFO] [stdout] 2453 | | .map(|(next, payload_pattern)| (next, payload_pattern)) [INFO] [stdout] | |___________________________________________________________________^ help: remove the call to `map` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_identity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3256:5 [INFO] [stdout] | [INFO] [stdout] 3256 | / impl ToString for Errors { [INFO] [stdout] 3257 | | fn to_string(&self) -> String { [INFO] [stdout] 3258 | | let mut rtn = String::new(); [INFO] [stdout] 3259 | | for (index,(_,value)) in self.iter().enumerate() { [INFO] [stdout] ... | [INFO] [stdout] 3267 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3262:21 [INFO] [stdout] | [INFO] [stdout] 3262 | rtn.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `rtn.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/version/v0_0_1/mod.rs:2659:5 [INFO] [stdout] | [INFO] [stdout] 2659 | impl Into> for Pattern<&str> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] help: replace the `Into` implementation with `From>` [INFO] [stdout] | [INFO] [stdout] 2659 ~ impl From> for Pattern { [INFO] [stdout] 2660 ~ fn from(val: Pattern<&str>) -> Self { [INFO] [stdout] 2661 ~ match val { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:2668:5 [INFO] [stdout] | [INFO] [stdout] 2668 | / impl

ToString for Pattern

[INFO] [stdout] 2669 | | where [INFO] [stdout] 2670 | | P: ToString, [INFO] [stdout] ... | [INFO] [stdout] 2678 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/version/v0_0_1/mod.rs:2720:5 [INFO] [stdout] | [INFO] [stdout] 2720 | impl Into> for EmptyPattern<&str> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] help: replace the `Into` implementation with `From>` [INFO] [stdout] | [INFO] [stdout] 2720 ~ impl From> for EmptyPattern { [INFO] [stdout] 2721 ~ fn from(val: EmptyPattern<&str>) -> Self { [INFO] [stdout] 2722 ~ match val { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:2729:5 [INFO] [stdout] | [INFO] [stdout] 2729 | / impl

ToString for EmptyPattern

[INFO] [stdout] 2730 | | where [INFO] [stdout] 2731 | | P: ToString, [INFO] [stdout] ... | [INFO] [stdout] 2739 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3384:5 [INFO] [stdout] | [INFO] [stdout] 3384 | / impl ToString for PrimitiveList [INFO] [stdout] 3385 | | { [INFO] [stdout] 3386 | | fn to_string(&self) -> String { [INFO] [stdout] 3387 | | format!("{}[]", self.primitive_type.to_string()) [INFO] [stdout] 3388 | | } [INFO] [stdout] 3389 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3387:48 [INFO] [stdout] | [INFO] [stdout] 3387 | format!("{}[]", self.primitive_type.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3404:44 [INFO] [stdout] | [INFO] [stdout] 3404 | self.primitive_type.to_string(), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3405:51 [INFO] [stdout] | [INFO] [stdout] 3405 | primitive.primitive_type().to_string() [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:2798:5 [INFO] [stdout] | [INFO] [stdout] 2798 | / impl ToString for AddressKindPath [INFO] [stdout] 2799 | | { [INFO] [stdout] 2800 | | fn to_string(&self) -> String { [INFO] [stdout] 2801 | | let mut rtn = String::new(); [INFO] [stdout] ... | [INFO] [stdout] 2819 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:2827:5 [INFO] [stdout] | [INFO] [stdout] 2827 | / impl ToString for AddressKindSegment { [INFO] [stdout] 2828 | | fn to_string(&self) -> String { [INFO] [stdout] 2829 | | format!( [INFO] [stdout] 2830 | | "{}<{}>", [INFO] [stdout] ... | [INFO] [stdout] 2835 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/version/v0_0_1/mod.rs:2842:13 [INFO] [stdout] | [INFO] [stdout] 2842 | Ok(consume_address_kind_path(s)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 2842 - Ok(consume_address_kind_path(s)?) [INFO] [stdout] 2842 + consume_address_kind_path(s) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/version/v0_0_1/mod.rs:2890:13 [INFO] [stdout] | [INFO] [stdout] 2883 | / let response = Response { [INFO] [stdout] 2884 | | id: unique_id(), [INFO] [stdout] 2885 | | from: self.to, [INFO] [stdout] 2886 | | to: self.from, [INFO] [stdout] 2887 | | core, [INFO] [stdout] 2888 | | response_to: self.id [INFO] [stdout] 2889 | | }; [INFO] [stdout] | |______________- unnecessary `let` binding [INFO] [stdout] 2890 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 2883 ~ [INFO] [stdout] 2884 ~ Response { [INFO] [stdout] 2885 + id: unique_id(), [INFO] [stdout] 2886 + from: self.to, [INFO] [stdout] 2887 + to: self.from, [INFO] [stdout] 2888 + core, [INFO] [stdout] 2889 + response_to: self.id [INFO] [stdout] 2890 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3506:39 [INFO] [stdout] | [INFO] [stdout] 3506 | self.primitive.to_string(), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3507:43 [INFO] [stdout] | [INFO] [stdout] 3507 | i.primitive_type().to_string() [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/version/v0_0_1/mod.rs:2906:13 [INFO] [stdout] | [INFO] [stdout] 2899 | / let response = Response { [INFO] [stdout] 2900 | | id: unique_id(), [INFO] [stdout] 2901 | | from: self.to, [INFO] [stdout] 2902 | | to: self.from, [INFO] [stdout] 2903 | | core, [INFO] [stdout] 2904 | | response_to: self.id [INFO] [stdout] 2905 | | }; [INFO] [stdout] | |______________- unnecessary `let` binding [INFO] [stdout] 2906 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 2899 ~ [INFO] [stdout] 2900 ~ Response { [INFO] [stdout] 2901 + id: unique_id(), [INFO] [stdout] 2902 + from: self.to, [INFO] [stdout] 2903 + to: self.from, [INFO] [stdout] 2904 + core, [INFO] [stdout] 2905 + response_to: self.id [INFO] [stdout] 2906 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `ProtoRequest` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:2918:9 [INFO] [stdout] | [INFO] [stdout] 2918 | / pub fn new() -> Self { [INFO] [stdout] 2919 | | Self { [INFO] [stdout] 2920 | | id: unique_id(), [INFO] [stdout] 2921 | | to: Option::None, [INFO] [stdout] ... | [INFO] [stdout] 2924 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 2917 ~ impl Default for ProtoRequest { [INFO] [stdout] 2918 + fn default() -> Self { [INFO] [stdout] 2919 + Self::new() [INFO] [stdout] 2920 + } [INFO] [stdout] 2921 + } [INFO] [stdout] 2922 + [INFO] [stdout] 2923 ~ impl ProtoRequest { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3541:51 [INFO] [stdout] | [INFO] [stdout] 3541 | ... payload.payload_type().to_string() [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3553:41 [INFO] [stdout] | [INFO] [stdout] 3553 | ... expected.to_string(), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3554:55 [INFO] [stdout] | [INFO] [stdout] 3554 | ... found.primitive_type().to_string() [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> src/version/v0_0_1/mod.rs:2986:5 [INFO] [stdout] | [INFO] [stdout] 2986 | / pub enum Message { [INFO] [stdout] 2987 | | Request(Request), [INFO] [stdout] | | ---------------- the largest variant contains at least 1264 bytes [INFO] [stdout] 2988 | | Response(Response) [INFO] [stdout] | | ------------------ the second-largest variant contains at least 576 bytes [INFO] [stdout] 2989 | | } [INFO] [stdout] | |_____^ the entire enum is at least 1264 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] = note: `#[warn(clippy::large_enum_variant)]` on by default [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 2987 - Request(Request), [INFO] [stdout] 2987 + Request(Box), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3561:37 [INFO] [stdout] | [INFO] [stdout] 3561 | ... expected.to_string(), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3562:51 [INFO] [stdout] | [INFO] [stdout] 3562 | ... payload.payload_type().to_string() [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3573:51 [INFO] [stdout] | [INFO] [stdout] 3573 | ... payload.payload_type().to_string() [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3585:51 [INFO] [stdout] | [INFO] [stdout] 3585 | ... payload.payload_type().to_string() [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3108:5 [INFO] [stdout] | [INFO] [stdout] 3108 | / pub enum Payload { [INFO] [stdout] 3109 | | Empty, [INFO] [stdout] 3110 | | Primitive(Primitive), [INFO] [stdout] | | -------------------- the largest variant contains at least 360 bytes [INFO] [stdout] 3111 | | List(PrimitiveList), [INFO] [stdout] 3112 | | Map(PayloadMap), [INFO] [stdout] | | --------------- the second-largest variant contains at least 48 bytes [INFO] [stdout] 3113 | | } [INFO] [stdout] | |_____^ the entire enum is at least 360 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 3110 - Primitive(Primitive), [INFO] [stdout] 3110 + Primitive(Box), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3603:37 [INFO] [stdout] | [INFO] [stdout] 3603 | self.structure.is_match(&payload)?; [INFO] [stdout] | ^^^^^^^^ help: change this to: `payload` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let .. else` expression looks like `matches!` macro [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3117:13 [INFO] [stdout] | [INFO] [stdout] 3117 | / if let Self::Empty = self { [INFO] [stdout] 3118 | | false [INFO] [stdout] 3119 | | } else { [INFO] [stdout] 3120 | | true [INFO] [stdout] 3121 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 3117 - if let Self::Empty = self { [INFO] [stdout] 3118 - false [INFO] [stdout] 3119 - } else { [INFO] [stdout] 3120 - true [INFO] [stdout] 3121 - } [INFO] [stdout] 3117 + !matches!(self, Self::Empty) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3172:5 [INFO] [stdout] | [INFO] [stdout] 3172 | impl Into for PayloadMap { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 3172 ~ impl From for Payload { [INFO] [stdout] 3173 ~ fn from(val: PayloadMap) -> Self { [INFO] [stdout] 3174 ~ Payload::Map(val) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3192:5 [INFO] [stdout] | [INFO] [stdout] 3192 | / impl Default for PayloadMap { [INFO] [stdout] 3193 | | fn default() -> Self { [INFO] [stdout] 3194 | | Self { [INFO] [stdout] 3195 | | map: Default::default(), [INFO] [stdout] ... | [INFO] [stdout] 3198 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 3168 ~ #[derive(Default)] [INFO] [stdout] 3169 ~ pub struct PayloadMap { [INFO] [stdout] 3170 | pub map: HashMap, [INFO] [stdout] ... [INFO] [stdout] 3192 | [INFO] [stdout] 3193 ~ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3256:5 [INFO] [stdout] | [INFO] [stdout] 3256 | / impl ToString for Errors { [INFO] [stdout] 3257 | | fn to_string(&self) -> String { [INFO] [stdout] 3258 | | let mut rtn = String::new(); [INFO] [stdout] 3259 | | for (index,(_,value)) in self.iter().enumerate() { [INFO] [stdout] ... | [INFO] [stdout] 3267 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3262:21 [INFO] [stdout] | [INFO] [stdout] 3262 | rtn.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `rtn.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3651:5 [INFO] [stdout] | [INFO] [stdout] 3651 | / impl ToString for Call { [INFO] [stdout] 3652 | | fn to_string(&self) -> String { [INFO] [stdout] 3653 | | format!("{}^{}", self.address.to_string(), self.kind.to_string()) [INFO] [stdout] 3654 | | } [INFO] [stdout] 3655 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3671:5 [INFO] [stdout] | [INFO] [stdout] 3671 | / impl ToString for MsgCall { [INFO] [stdout] 3672 | | fn to_string(&self) -> String { [INFO] [stdout] 3673 | | format!("Msg<{}>{}", self.action, self.path) [INFO] [stdout] 3674 | | } [INFO] [stdout] 3675 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3689:5 [INFO] [stdout] | [INFO] [stdout] 3689 | / impl ToString for HttpCall { [INFO] [stdout] 3690 | | fn to_string(&self) -> String { [INFO] [stdout] 3691 | | format!("Http<{}>{}", self.method.to_string(), self.path) [INFO] [stdout] 3692 | | } [INFO] [stdout] 3693 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3691:46 [INFO] [stdout] | [INFO] [stdout] 3691 | format!("Http<{}>{}", self.method.to_string(), self.path) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3384:5 [INFO] [stdout] | [INFO] [stdout] 3384 | / impl ToString for PrimitiveList [INFO] [stdout] 3385 | | { [INFO] [stdout] 3386 | | fn to_string(&self) -> String { [INFO] [stdout] 3387 | | format!("{}[]", self.primitive_type.to_string()) [INFO] [stdout] 3388 | | } [INFO] [stdout] 3389 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3387:48 [INFO] [stdout] | [INFO] [stdout] 3387 | format!("{}[]", self.primitive_type.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3404:44 [INFO] [stdout] | [INFO] [stdout] 3404 | self.primitive_type.to_string(), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3405:51 [INFO] [stdout] | [INFO] [stdout] 3405 | primitive.primitive_type().to_string() [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3744:25 [INFO] [stdout] | [INFO] [stdout] 3744 | self.to_string(), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3745:26 [INFO] [stdout] | [INFO] [stdout] 3745 | found.to_string() [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3752:5 [INFO] [stdout] | [INFO] [stdout] 3752 | / impl ToString for CallKind { [INFO] [stdout] 3753 | | fn to_string(&self) -> String { [INFO] [stdout] 3754 | | match self { [INFO] [stdout] 3755 | | CallKind::Msg(msg) => msg.to_string(), [INFO] [stdout] ... | [INFO] [stdout] 3759 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3506:39 [INFO] [stdout] | [INFO] [stdout] 3506 | self.primitive.to_string(), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3874:5 [INFO] [stdout] | [INFO] [stdout] 3874 | / impl ToString for MapPattern { [INFO] [stdout] 3875 | | fn to_string(&self) -> String { [INFO] [stdout] 3876 | | "Map?".to_string() [INFO] [stdout] 3877 | | } [INFO] [stdout] 3878 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3507:43 [INFO] [stdout] | [INFO] [stdout] 3507 | i.primitive_type().to_string() [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3932:21 [INFO] [stdout] | [INFO] [stdout] 3932 | / &map.get(key) [INFO] [stdout] 3933 | | .expect("expected map element after testing for it"), [INFO] [stdout] | |____________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 3932 ~ map.get(key) [INFO] [stdout] 3933 ~ .expect("expected map element after testing for it"), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3541:51 [INFO] [stdout] | [INFO] [stdout] 3541 | ... payload.payload_type().to_string() [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3553:41 [INFO] [stdout] | [INFO] [stdout] 3553 | ... expected.to_string(), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3554:55 [INFO] [stdout] | [INFO] [stdout] 3554 | ... found.primitive_type().to_string() [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3561:37 [INFO] [stdout] | [INFO] [stdout] 3561 | ... expected.to_string(), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3562:51 [INFO] [stdout] | [INFO] [stdout] 3562 | ... payload.payload_type().to_string() [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3573:51 [INFO] [stdout] | [INFO] [stdout] 3573 | ... payload.payload_type().to_string() [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3585:51 [INFO] [stdout] | [INFO] [stdout] 3585 | ... payload.payload_type().to_string() [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3603:37 [INFO] [stdout] | [INFO] [stdout] 3603 | self.structure.is_match(&payload)?; [INFO] [stdout] | ^^^^^^^^ help: change this to: `payload` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> src/version/v0_0_1/mod.rs:4094:9 [INFO] [stdout] | [INFO] [stdout] 4094 | / pub enum StateSrc { [INFO] [stdout] 4095 | | Stateless, [INFO] [stdout] | | --------- the second-largest variant carries no data at all [INFO] [stdout] 4096 | | StatefulDirect(Payload), [INFO] [stdout] | | ----------------------- the largest variant contains at least 360 bytes [INFO] [stdout] 4097 | | } [INFO] [stdout] | |_________^ the entire enum is at least 360 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 4096 - StatefulDirect(Payload), [INFO] [stdout] 4096 + StatefulDirect(Box), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3651:5 [INFO] [stdout] | [INFO] [stdout] 3651 | / impl ToString for Call { [INFO] [stdout] 3652 | | fn to_string(&self) -> String { [INFO] [stdout] 3653 | | format!("{}^{}", self.address.to_string(), self.kind.to_string()) [INFO] [stdout] 3654 | | } [INFO] [stdout] 3655 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/version/v0_0_1/mod.rs:4111:9 [INFO] [stdout] | [INFO] [stdout] 4111 | / impl Default for SetProperties { [INFO] [stdout] 4112 | | fn default() -> Self { [INFO] [stdout] 4113 | | Self { [INFO] [stdout] 4114 | | map: Default::default() [INFO] [stdout] ... | [INFO] [stdout] 4117 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 4107 ~ #[derive(Default)] [INFO] [stdout] 4108 ~ pub struct SetProperties { [INFO] [stdout] 4109 | pub map: HashMap [INFO] [stdout] 4110 | } [INFO] [stdout] 4111 | [INFO] [stdout] 4112 ~ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3671:5 [INFO] [stdout] | [INFO] [stdout] 3671 | / impl ToString for MsgCall { [INFO] [stdout] 3672 | | fn to_string(&self) -> String { [INFO] [stdout] 3673 | | format!("Msg<{}>{}", self.action, self.path) [INFO] [stdout] 3674 | | } [INFO] [stdout] 3675 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3689:5 [INFO] [stdout] | [INFO] [stdout] 3689 | / impl ToString for HttpCall { [INFO] [stdout] 3690 | | fn to_string(&self) -> String { [INFO] [stdout] 3691 | | format!("Http<{}>{}", self.method.to_string(), self.path) [INFO] [stdout] 3692 | | } [INFO] [stdout] 3693 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3691:46 [INFO] [stdout] | [INFO] [stdout] 3691 | format!("Http<{}>{}", self.method.to_string(), self.path) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/version/v0_0_1/mod.rs:4179:9 [INFO] [stdout] | [INFO] [stdout] 4179 | / impl Default for SetRegistry { [INFO] [stdout] 4180 | | fn default() -> Self { [INFO] [stdout] 4181 | | Self { [INFO] [stdout] 4182 | | labels: Default::default(), [INFO] [stdout] ... | [INFO] [stdout] 4185 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 4161 ~ #[derive(Default)] [INFO] [stdout] 4162 ~ pub struct SetRegistry { [INFO] [stdout] 4163 | pub labels: Vec, [INFO] [stdout] ... [INFO] [stdout] 4179 | [INFO] [stdout] 4180 ~ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3744:25 [INFO] [stdout] | [INFO] [stdout] 3744 | self.to_string(), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3745:26 [INFO] [stdout] | [INFO] [stdout] 3745 | found.to_string() [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3752:5 [INFO] [stdout] | [INFO] [stdout] 3752 | / impl ToString for CallKind { [INFO] [stdout] 3753 | | fn to_string(&self) -> String { [INFO] [stdout] 3754 | | match self { [INFO] [stdout] 3755 | | CallKind::Msg(msg) => msg.to_string(), [INFO] [stdout] ... | [INFO] [stdout] 3759 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3874:5 [INFO] [stdout] | [INFO] [stdout] 3874 | / impl ToString for MapPattern { [INFO] [stdout] 3875 | | fn to_string(&self) -> String { [INFO] [stdout] 3876 | | "Map?".to_string() [INFO] [stdout] 3877 | | } [INFO] [stdout] 3878 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/version/v0_0_1/mod.rs:3932:21 [INFO] [stdout] | [INFO] [stdout] 3932 | / &map.get(key) [INFO] [stdout] 3933 | | .expect("expected map element after testing for it"), [INFO] [stdout] | |____________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 3932 ~ map.get(key) [INFO] [stdout] 3933 ~ .expect("expected map element after testing for it"), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/version/v0_0_1/mod.rs:4298:5 [INFO] [stdout] | [INFO] [stdout] 4298 | impl Into for HttpRequest { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 4298 ~ impl From for RequestCore { [INFO] [stdout] 4299 ~ fn from(val: HttpRequest) -> Self { [INFO] [stdout] 4300 | RequestCore { [INFO] [stdout] 4301 ~ action: Action::Http(val.method), [INFO] [stdout] 4302 ~ headers: val.headers, [INFO] [stdout] 4303 ~ path: val.path, [INFO] [stdout] 4304 ~ body: Payload::Primitive(Primitive::Bin(val.body)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:4309:5 [INFO] [stdout] | [INFO] [stdout] 4309 | / impl ToString for HttpRequest { [INFO] [stdout] 4310 | | fn to_string(&self) -> String { [INFO] [stdout] 4311 | | format!("Http<{}>{}", self.method.to_string(), self.path) [INFO] [stdout] 4312 | | } [INFO] [stdout] 4313 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/version/v0_0_1/mod.rs:4311:46 [INFO] [stdout] | [INFO] [stdout] 4311 | format!("Http<{}>{}", self.method.to_string(), self.path) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:4350:5 [INFO] [stdout] | [INFO] [stdout] 4350 | / impl ToString for PortalKind { [INFO] [stdout] 4351 | | fn to_string(&self) -> String { [INFO] [stdout] 4352 | | match self { [INFO] [stdout] 4353 | | PortalKind::Mechtron => "Mechtron".to_string(), [INFO] [stdout] ... | [INFO] [stdout] 4357 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> src/version/v0_0_1/mod.rs:4094:9 [INFO] [stdout] | [INFO] [stdout] 4094 | / pub enum StateSrc { [INFO] [stdout] 4095 | | Stateless, [INFO] [stdout] | | --------- the second-largest variant carries no data at all [INFO] [stdout] 4096 | | StatefulDirect(Payload), [INFO] [stdout] | | ----------------------- the largest variant contains at least 360 bytes [INFO] [stdout] 4097 | | } [INFO] [stdout] | |_________^ the entire enum is at least 360 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 4096 - StatefulDirect(Payload), [INFO] [stdout] 4096 + StatefulDirect(Box), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/version/v0_0_1/mod.rs:4111:9 [INFO] [stdout] | [INFO] [stdout] 4111 | / impl Default for SetProperties { [INFO] [stdout] 4112 | | fn default() -> Self { [INFO] [stdout] 4113 | | Self { [INFO] [stdout] 4114 | | map: Default::default() [INFO] [stdout] ... | [INFO] [stdout] 4117 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 4107 ~ #[derive(Default)] [INFO] [stdout] 4108 ~ pub struct SetProperties { [INFO] [stdout] 4109 | pub map: HashMap [INFO] [stdout] 4110 | } [INFO] [stdout] 4111 | [INFO] [stdout] 4112 ~ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/version/v0_0_1/mod.rs:4179:9 [INFO] [stdout] | [INFO] [stdout] 4179 | / impl Default for SetRegistry { [INFO] [stdout] 4180 | | fn default() -> Self { [INFO] [stdout] 4181 | | Self { [INFO] [stdout] 4182 | | labels: Default::default(), [INFO] [stdout] ... | [INFO] [stdout] 4185 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 4161 ~ #[derive(Default)] [INFO] [stdout] 4162 ~ pub struct SetRegistry { [INFO] [stdout] 4163 | pub labels: Vec, [INFO] [stdout] ... [INFO] [stdout] 4179 | [INFO] [stdout] 4180 ~ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Pipeline` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:4538:13 [INFO] [stdout] | [INFO] [stdout] 4538 | / pub fn new() -> Self { [INFO] [stdout] 4539 | | Self { segments: vec![] } [INFO] [stdout] 4540 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 4537 ~ impl Default for Pipeline { [INFO] [stdout] 4538 + fn default() -> Self { [INFO] [stdout] 4539 + Self::new() [INFO] [stdout] 4540 + } [INFO] [stdout] 4541 + } [INFO] [stdout] 4542 + [INFO] [stdout] 4543 ~ impl Pipeline { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/version/v0_0_1/mod.rs:4298:5 [INFO] [stdout] | [INFO] [stdout] 4298 | impl Into for HttpRequest { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 4298 ~ impl From for RequestCore { [INFO] [stdout] 4299 ~ fn from(val: HttpRequest) -> Self { [INFO] [stdout] 4300 | RequestCore { [INFO] [stdout] 4301 ~ action: Action::Http(val.method), [INFO] [stdout] 4302 ~ headers: val.headers, [INFO] [stdout] 4303 ~ path: val.path, [INFO] [stdout] 4304 ~ body: Payload::Primitive(Primitive::Bin(val.body)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:4309:5 [INFO] [stdout] | [INFO] [stdout] 4309 | / impl ToString for HttpRequest { [INFO] [stdout] 4310 | | fn to_string(&self) -> String { [INFO] [stdout] 4311 | | format!("Http<{}>{}", self.method.to_string(), self.path) [INFO] [stdout] 4312 | | } [INFO] [stdout] 4313 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/version/v0_0_1/mod.rs:4311:46 [INFO] [stdout] | [INFO] [stdout] 4311 | format!("Http<{}>{}", self.method.to_string(), self.path) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:4350:5 [INFO] [stdout] | [INFO] [stdout] 4350 | / impl ToString for PortalKind { [INFO] [stdout] 4351 | | fn to_string(&self) -> String { [INFO] [stdout] 4352 | | match self { [INFO] [stdout] 4353 | | PortalKind::Mechtron => "Mechtron".to_string(), [INFO] [stdout] ... | [INFO] [stdout] 4357 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> src/version/v0_0_1/mod.rs:4902:9 [INFO] [stdout] | [INFO] [stdout] 4902 | / pub enum Action { [INFO] [stdout] 4903 | | Rc(Rc), [INFO] [stdout] | | ------ the largest variant contains at least 696 bytes [INFO] [stdout] 4904 | | Http(HttpMethod), [INFO] [stdout] 4905 | | Msg(String) [INFO] [stdout] | | ----------- the second-largest variant contains at least 24 bytes [INFO] [stdout] 4906 | | } [INFO] [stdout] | |_________^ the entire enum is at least 696 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 4903 - Rc(Rc), [INFO] [stdout] 4903 + Rc(Box), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/version/v0_0_1/mod.rs:4908:9 [INFO] [stdout] | [INFO] [stdout] 4908 | impl Into for Action { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 4908 ~ impl From for RequestCore { [INFO] [stdout] 4909 ~ fn from(val: Action) -> Self { [INFO] [stdout] 4910 | RequestCore { [INFO] [stdout] 4911 | headers: Default::default(), [INFO] [stdout] 4912 ~ action: val, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> src/version/v0_0_1/mod.rs:4980:9 [INFO] [stdout] | [INFO] [stdout] 4980 | / pub enum Rc { [INFO] [stdout] 4981 | | Create(Create), [INFO] [stdout] | | -------------- the largest variant contains at least 696 bytes [INFO] [stdout] 4982 | | Select(Select), [INFO] [stdout] | | -------------- the second-largest variant contains at least 408 bytes [INFO] [stdout] 4983 | | Update(Update), [INFO] [stdout] ... | [INFO] [stdout] 4986 | | Set(Set) [INFO] [stdout] 4987 | | } [INFO] [stdout] | |_________^ the entire enum is at least 696 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 4981 - Create(Create), [INFO] [stdout] 4981 + Create(Box), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Pipeline` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:4538:13 [INFO] [stdout] | [INFO] [stdout] 4538 | / pub fn new() -> Self { [INFO] [stdout] 4539 | | Self { segments: vec![] } [INFO] [stdout] 4540 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 4537 ~ impl Default for Pipeline { [INFO] [stdout] 4538 + fn default() -> Self { [INFO] [stdout] 4539 + Self::new() [INFO] [stdout] 4540 + } [INFO] [stdout] 4541 + } [INFO] [stdout] 4542 + [INFO] [stdout] 4543 ~ impl Pipeline { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5042:9 [INFO] [stdout] | [INFO] [stdout] 5042 | / impl ToString for Rc { [INFO] [stdout] 5043 | | fn to_string(&self) -> String { [INFO] [stdout] 5044 | | format!("Rc<{}>", self.get_type().to_string()) [INFO] [stdout] 5045 | | } [INFO] [stdout] 5046 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5044:50 [INFO] [stdout] | [INFO] [stdout] 5044 | format!("Rc<{}>", self.get_type().to_string()) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> src/version/v0_0_1/mod.rs:4902:9 [INFO] [stdout] | [INFO] [stdout] 4902 | / pub enum Action { [INFO] [stdout] 4903 | | Rc(Rc), [INFO] [stdout] | | ------ the largest variant contains at least 696 bytes [INFO] [stdout] 4904 | | Http(HttpMethod), [INFO] [stdout] 4905 | | Msg(String) [INFO] [stdout] | | ----------- the second-largest variant contains at least 24 bytes [INFO] [stdout] 4906 | | } [INFO] [stdout] | |_________^ the entire enum is at least 696 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 4903 - Rc(Rc), [INFO] [stdout] 4903 + Rc(Box), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5174:13 [INFO] [stdout] | [INFO] [stdout] 5174 | impl Into for CreateOp { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 5174 ~ impl From for Create { [INFO] [stdout] 5175 ~ fn from(val: CreateOp) -> Self { [INFO] [stdout] 5176 | Create { [INFO] [stdout] 5177 ~ template: val.template, [INFO] [stdout] 5178 ~ state: val.state, [INFO] [stdout] 5179 ~ properties: val.properties, [INFO] [stdout] 5180 ~ strategy: val.strategy, [INFO] [stdout] 5181 ~ registry: val.registry [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/version/v0_0_1/mod.rs:4908:9 [INFO] [stdout] | [INFO] [stdout] 4908 | impl Into for Action { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 4908 ~ impl From for RequestCore { [INFO] [stdout] 4909 ~ fn from(val: Action) -> Self { [INFO] [stdout] 4910 | RequestCore { [INFO] [stdout] 4911 | headers: Default::default(), [INFO] [stdout] 4912 ~ action: val, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> src/version/v0_0_1/mod.rs:4980:9 [INFO] [stdout] | [INFO] [stdout] 4980 | / pub enum Rc { [INFO] [stdout] 4981 | | Create(Create), [INFO] [stdout] | | -------------- the largest variant contains at least 696 bytes [INFO] [stdout] 4982 | | Select(Select), [INFO] [stdout] | | -------------- the second-largest variant contains at least 408 bytes [INFO] [stdout] 4983 | | Update(Update), [INFO] [stdout] ... | [INFO] [stdout] 4986 | | Set(Set) [INFO] [stdout] 4987 | | } [INFO] [stdout] | |_________^ the entire enum is at least 696 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 4981 - Create(Create), [INFO] [stdout] 4981 + Create(Box), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5042:9 [INFO] [stdout] | [INFO] [stdout] 5042 | / impl ToString for Rc { [INFO] [stdout] 5043 | | fn to_string(&self) -> String { [INFO] [stdout] 5044 | | format!("Rc<{}>", self.get_type().to_string()) [INFO] [stdout] 5045 | | } [INFO] [stdout] 5046 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5044:50 [INFO] [stdout] | [INFO] [stdout] 5044 | format!("Rc<{}>", self.get_type().to_string()) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5256:30 [INFO] [stdout] | [INFO] [stdout] 5256 | .map(|stub| Primitive::Stub(stub)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `Primitive::Stub` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5332:13 [INFO] [stdout] | [INFO] [stdout] 5332 | impl Into for SubSelect { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 5332 ~ impl From for Select { [INFO] [stdout] 5333 ~ fn from(val: SubSelect) -> Self { [INFO] [stdout] 5334 | Select { [INFO] [stdout] 5335 ~ pattern: val.pattern, [INFO] [stdout] 5336 ~ properties: val.properties, [INFO] [stdout] 5337 ~ into_payload: val.into_payload, [INFO] [stdout] 5338 | kind: SelectKind::SubSelect { [INFO] [stdout] 5339 ~ address: val.address, [INFO] [stdout] 5340 ~ hops: val.hops, [INFO] [stdout] 5341 ~ address_kind_path: val.address_kind_path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5430:13 [INFO] [stdout] | [INFO] [stdout] 5430 | / impl ToString for QueryResult [INFO] [stdout] 5431 | | { [INFO] [stdout] 5432 | | fn to_string(&self) -> String { [INFO] [stdout] 5433 | | match self { [INFO] [stdout] ... | [INFO] [stdout] 5439 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5441:13 [INFO] [stdout] | [INFO] [stdout] 5441 | impl Into for Query { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 5441 ~ impl From for Rc { [INFO] [stdout] 5442 ~ fn from(val: Query) -> Self { [INFO] [stdout] 5443 ~ Rc::Query(val) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `ResponseCore` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5478:13 [INFO] [stdout] | [INFO] [stdout] 5478 | / pub fn new() -> Self { [INFO] [stdout] 5479 | | ResponseCore { [INFO] [stdout] 5480 | | headers: Meta::new(), [INFO] [stdout] 5481 | | code: 200, [INFO] [stdout] ... | [INFO] [stdout] 5484 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 5471 ~ impl Default for ResponseCore { [INFO] [stdout] 5472 + fn default() -> Self { [INFO] [stdout] 5473 + Self::new() [INFO] [stdout] 5474 + } [INFO] [stdout] 5475 + } [INFO] [stdout] 5476 + [INFO] [stdout] 5477 ~ impl ResponseCore { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5520:17 [INFO] [stdout] | [INFO] [stdout] 5520 | return self.code >= 200 && self.code <= 299; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 5520 - return self.code >= 200 && self.code <= 299; [INFO] [stdout] 5520 + self.code >= 200 && self.code <= 299 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5594:5 [INFO] [stdout] | [INFO] [stdout] 5594 | / impl ToString for Code { [INFO] [stdout] 5595 | | fn to_string(&self) -> String { [INFO] [stdout] 5596 | | match self { [INFO] [stdout] 5597 | | Code::Ok => "Ok".to_string(), [INFO] [stdout] ... | [INFO] [stdout] 5603 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5814:9 [INFO] [stdout] | [INFO] [stdout] 5814 | / impl ToString for Log { [INFO] [stdout] 5815 | | fn to_string(&self) -> String { [INFO] [stdout] 5816 | | format!("{}: {}", self.src, self.message ) [INFO] [stdout] 5817 | | } [INFO] [stdout] 5818 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5821:9 [INFO] [stdout] | [INFO] [stdout] 5821 | / pub enum Frame { [INFO] [stdout] 5822 | | Log(Log), [INFO] [stdout] 5823 | | AssignRequest(Exchanger), [INFO] [stdout] 5824 | | Request(Request), [INFO] [stdout] | | ---------------- the largest variant contains at least 1264 bytes [INFO] [stdout] 5825 | | Response(Response), [INFO] [stdout] | | ------------------ the second-largest variant contains at least 576 bytes [INFO] [stdout] ... | [INFO] [stdout] 5828 | | Close(CloseReason), [INFO] [stdout] 5829 | | } [INFO] [stdout] | |_________^ the entire enum is at least 1264 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 5824 - Request(Request), [INFO] [stdout] 5824 + Request(Box), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5611:5 [INFO] [stdout] | [INFO] [stdout] 5611 | / impl ToString for Progress { [INFO] [stdout] 5612 | | fn to_string(&self) -> String { [INFO] [stdout] 5613 | | format!("{}/{}", self.step, self.total) [INFO] [stdout] 5614 | | } [INFO] [stdout] 5615 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5617:5 [INFO] [stdout] | [INFO] [stdout] 5617 | / impl ToString for Status { [INFO] [stdout] 5618 | | fn to_string(&self) -> String { [INFO] [stdout] 5619 | | match self { [INFO] [stdout] 5620 | | Status::Unknown => "Unknown".to_string(), [INFO] [stdout] ... | [INFO] [stdout] 5631 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5702:13 [INFO] [stdout] | [INFO] [stdout] 5702 | Ok(status(s)?) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 5702 - Ok(status(s)?) [INFO] [stdout] 5702 + status(s) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5888:9 [INFO] [stdout] | [INFO] [stdout] 5888 | / pub enum Frame { [INFO] [stdout] 5889 | | Init, [INFO] [stdout] 5890 | | Assign(Exchanger), [INFO] [stdout] 5891 | | Request(Request), [INFO] [stdout] | | ---------------- the largest variant contains at least 1264 bytes [INFO] [stdout] 5892 | | Response(Response), [INFO] [stdout] | | ------------------ the second-largest variant contains at least 576 bytes [INFO] [stdout] 5893 | | Artifact(Exchanger), [INFO] [stdout] 5894 | | Close(CloseReason), [INFO] [stdout] 5895 | | } [INFO] [stdout] | |_________^ the entire enum is at least 1264 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 5891 - Request(Request), [INFO] [stdout] 5891 + Request(Box), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6049:5 [INFO] [stdout] | [INFO] [stdout] 6049 | / impl ToString for ValuePattern { [INFO] [stdout] 6050 | | fn to_string(&self) -> String { [INFO] [stdout] 6051 | | match self { [INFO] [stdout] 6052 | | ValuePattern::Any => "*".to_string(), [INFO] [stdout] ... | [INFO] [stdout] 6057 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6067:5 [INFO] [stdout] | [INFO] [stdout] 6067 | / impl ToString for RegexMatcher { [INFO] [stdout] 6068 | | fn to_string(&self) -> String { [INFO] [stdout] 6069 | | self.pattern.clone() [INFO] [stdout] 6070 | | } [INFO] [stdout] 6071 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6095:5 [INFO] [stdout] | [INFO] [stdout] 6095 | / impl ToString for StringMatcher { [INFO] [stdout] 6096 | | fn to_string(&self) -> String { [INFO] [stdout] 6097 | | self.pattern.clone() [INFO] [stdout] 6098 | | } [INFO] [stdout] 6099 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5814:9 [INFO] [stdout] | [INFO] [stdout] 5814 | / impl ToString for Log { [INFO] [stdout] 5815 | | fn to_string(&self) -> String { [INFO] [stdout] 5816 | | format!("{}: {}", self.src, self.message ) [INFO] [stdout] 5817 | | } [INFO] [stdout] 5818 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5821:9 [INFO] [stdout] | [INFO] [stdout] 5821 | / pub enum Frame { [INFO] [stdout] 5822 | | Log(Log), [INFO] [stdout] 5823 | | AssignRequest(Exchanger), [INFO] [stdout] 5824 | | Request(Request), [INFO] [stdout] | | ---------------- the largest variant contains at least 1264 bytes [INFO] [stdout] 5825 | | Response(Response), [INFO] [stdout] | | ------------------ the second-largest variant contains at least 576 bytes [INFO] [stdout] ... | [INFO] [stdout] 5828 | | Close(CloseReason), [INFO] [stdout] 5829 | | } [INFO] [stdout] | |_________^ the entire enum is at least 1264 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 5824 - Request(Request), [INFO] [stdout] 5824 + Request(Box), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5888:9 [INFO] [stdout] | [INFO] [stdout] 5888 | / pub enum Frame { [INFO] [stdout] 5889 | | Init, [INFO] [stdout] 5890 | | Assign(Exchanger), [INFO] [stdout] 5891 | | Request(Request), [INFO] [stdout] | | ---------------- the largest variant contains at least 1264 bytes [INFO] [stdout] 5892 | | Response(Response), [INFO] [stdout] | | ------------------ the second-largest variant contains at least 576 bytes [INFO] [stdout] 5893 | | Artifact(Exchanger), [INFO] [stdout] 5894 | | Close(CloseReason), [INFO] [stdout] 5895 | | } [INFO] [stdout] | |_________^ the entire enum is at least 1264 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 5891 - Request(Request), [INFO] [stdout] 5891 + Request(Box), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6049:5 [INFO] [stdout] | [INFO] [stdout] 6049 | / impl ToString for ValuePattern { [INFO] [stdout] 6050 | | fn to_string(&self) -> String { [INFO] [stdout] 6051 | | match self { [INFO] [stdout] 6052 | | ValuePattern::Any => "*".to_string(), [INFO] [stdout] ... | [INFO] [stdout] 6057 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6067:5 [INFO] [stdout] | [INFO] [stdout] 6067 | / impl ToString for RegexMatcher { [INFO] [stdout] 6068 | | fn to_string(&self) -> String { [INFO] [stdout] 6069 | | self.pattern.clone() [INFO] [stdout] 6070 | | } [INFO] [stdout] 6071 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6095:5 [INFO] [stdout] | [INFO] [stdout] 6095 | / impl ToString for StringMatcher { [INFO] [stdout] 6096 | | fn to_string(&self) -> String { [INFO] [stdout] 6097 | | self.pattern.clone() [INFO] [stdout] 6098 | | } [INFO] [stdout] 6099 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6313:5 [INFO] [stdout] | [INFO] [stdout] 6313 | / impl ToString for Fail { [INFO] [stdout] 6314 | | fn to_string(&self) -> String { [INFO] [stdout] 6315 | | "Fail".to_string() [INFO] [stdout] 6316 | | } [INFO] [stdout] 6317 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6319:5 [INFO] [stdout] | [INFO] [stdout] 6319 | impl Into for Fail { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 6319 ~ impl From for Error { [INFO] [stdout] 6320 ~ fn from(val: Fail) -> Self { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6378:17 [INFO] [stdout] | [INFO] [stdout] 6378 | / !(char_item == '-') [INFO] [stdout] 6379 | | && !(char_item == '.') [INFO] [stdout] 6380 | | && !(char_item == '/') [INFO] [stdout] 6381 | | && !(char_item == '_') [INFO] [stdout] 6382 | | && !(char_item.is_alpha() || char_item.is_dec_digit()) [INFO] [stdout] | |__________________________________________________________________________^ help: try: `!((char_item == '-') || (char_item == '.') || (char_item == '/') || (char_item == '_') || char_item.is_alpha() || char_item.is_dec_digit())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6378:17 [INFO] [stdout] | [INFO] [stdout] 6378 | !(char_item == '-') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '-')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6379:24 [INFO] [stdout] | [INFO] [stdout] 6379 | && !(char_item == '.') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '.')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6380:24 [INFO] [stdout] | [INFO] [stdout] 6380 | && !(char_item == '/') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '/')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6381:24 [INFO] [stdout] | [INFO] [stdout] 6381 | && !(char_item == '_') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '_')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6396:17 [INFO] [stdout] | [INFO] [stdout] 6396 | !(char_item == '-') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '-')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6397:24 [INFO] [stdout] | [INFO] [stdout] 6397 | && !(char_item == '.') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '.')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6398:24 [INFO] [stdout] | [INFO] [stdout] 6398 | && !(char_item == '/') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '/')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6399:24 [INFO] [stdout] | [INFO] [stdout] 6399 | && !(char_item == '_') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '_')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6400:24 [INFO] [stdout] | [INFO] [stdout] 6400 | && !(char_item == ':') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != ':')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6401:24 [INFO] [stdout] | [INFO] [stdout] 6401 | && !(char_item == '(') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '(')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6402:24 [INFO] [stdout] | [INFO] [stdout] 6402 | && !(char_item == ')') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != ')')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6771:17 [INFO] [stdout] | [INFO] [stdout] 6771 | / !(char_item == '-') [INFO] [stdout] 6772 | | && !(char_item == '.') [INFO] [stdout] 6773 | | && !((char_item.is_alpha() && char_item.is_lowercase()) [INFO] [stdout] 6774 | | || char_item.is_dec_digit()) [INFO] [stdout] | |________________________________________________^ help: try: `!((char_item == '-') || (char_item == '.') || char_item.is_dec_digit() || char_item.is_alpha() && char_item.is_lowercase())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6771:17 [INFO] [stdout] | [INFO] [stdout] 6771 | !(char_item == '-') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '-')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6772:24 [INFO] [stdout] | [INFO] [stdout] 6772 | && !(char_item == '.') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '.')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6788:17 [INFO] [stdout] | [INFO] [stdout] 6788 | / !(char_item == '-') [INFO] [stdout] 6789 | | && !(char_item == '.') [INFO] [stdout] 6790 | | && !((char_item.is_alpha() && char_item.is_lowercase()) [INFO] [stdout] 6791 | | || char_item.is_dec_digit()) [INFO] [stdout] | |____________________________________________________^ help: try: `!((char_item == '-') || (char_item == '.') || char_item.is_dec_digit() || char_item.is_alpha() && char_item.is_lowercase())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6788:17 [INFO] [stdout] | [INFO] [stdout] 6788 | !(char_item == '-') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '-')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6789:24 [INFO] [stdout] | [INFO] [stdout] 6789 | && !(char_item == '.') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '.')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6805:17 [INFO] [stdout] | [INFO] [stdout] 6805 | / !(char_item == '-') [INFO] [stdout] 6806 | | && !(char_item == '.') [INFO] [stdout] 6807 | | && !(char_item.is_alpha() || char_item.is_dec_digit()) [INFO] [stdout] | |__________________________________________________________________________^ help: try: `!((char_item == '-') || (char_item == '.') || char_item.is_alpha() || char_item.is_dec_digit())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6805:17 [INFO] [stdout] | [INFO] [stdout] 6805 | !(char_item == '-') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '-')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6806:24 [INFO] [stdout] | [INFO] [stdout] 6806 | && !(char_item == '.') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '.')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6824:22 [INFO] [stdout] | [INFO] [stdout] 6824 | !char_item.is_digit(10) && [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `char_item.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6840:17 [INFO] [stdout] | [INFO] [stdout] 6840 | !(char_item == '-') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '-')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6841:24 [INFO] [stdout] | [INFO] [stdout] 6841 | && !(char_item == '>') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '>')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6842:24 [INFO] [stdout] | [INFO] [stdout] 6842 | && !(char_item == '<') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '<')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6843:24 [INFO] [stdout] | [INFO] [stdout] 6843 | && !(char_item == '^') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '^')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6844:24 [INFO] [stdout] | [INFO] [stdout] 6844 | && !(char_item == '=') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '=')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6892:22 [INFO] [stdout] | [INFO] [stdout] 6892 | !char_item.is_digit(10) && [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `char_item.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6910:22 [INFO] [stdout] | [INFO] [stdout] 6910 | !char_item.is_digit(10) && [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `char_item.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6927:22 [INFO] [stdout] | [INFO] [stdout] 6927 | !char_item.is_digit(10) && [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `char_item.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6942:17 [INFO] [stdout] | [INFO] [stdout] 6942 | / !(char_item == '-') [INFO] [stdout] 6943 | | && !(char_item == '.') [INFO] [stdout] 6944 | | && !((char_item.is_alpha() && char_item.is_lowercase()) [INFO] [stdout] 6945 | | || char_item.is_dec_digit()) [INFO] [stdout] | |____________________________________________________^ help: try: `!((char_item == '-') || (char_item == '.') || char_item.is_dec_digit() || char_item.is_alpha() && char_item.is_lowercase())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6942:17 [INFO] [stdout] | [INFO] [stdout] 6942 | !(char_item == '-') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '-')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6943:24 [INFO] [stdout] | [INFO] [stdout] 6943 | && !(char_item == '.') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '.')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6959:17 [INFO] [stdout] | [INFO] [stdout] 6959 | / !(char_item == '-') [INFO] [stdout] 6960 | | && !(char_item == '.') [INFO] [stdout] 6961 | | && !(char_item == '$') [INFO] [stdout] 6962 | | && !((char_item.is_alpha() && char_item.is_lowercase()) [INFO] [stdout] 6963 | | || char_item.is_dec_digit()) [INFO] [stdout] | |________________________________________________^ help: try: `!((char_item == '-') || (char_item == '.') || (char_item == '$') || char_item.is_dec_digit() || char_item.is_alpha() && char_item.is_lowercase())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6959:17 [INFO] [stdout] | [INFO] [stdout] 6959 | !(char_item == '-') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '-')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6960:24 [INFO] [stdout] | [INFO] [stdout] 6960 | && !(char_item == '.') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '.')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6961:24 [INFO] [stdout] | [INFO] [stdout] 6961 | && !(char_item == '$') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '$')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6978:17 [INFO] [stdout] | [INFO] [stdout] 6978 | / !(char_item == '-') [INFO] [stdout] 6979 | | && !(char_item == '.') [INFO] [stdout] 6980 | | && !((char_item.is_alpha() && char_item.is_lowercase()) [INFO] [stdout] 6981 | | || char_item.is_dec_digit()) [INFO] [stdout] | |____________________________________________________^ help: try: `!((char_item == '-') || (char_item == '.') || char_item.is_dec_digit() || char_item.is_alpha() && char_item.is_lowercase())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6978:17 [INFO] [stdout] | [INFO] [stdout] 6978 | !(char_item == '-') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '-')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6979:24 [INFO] [stdout] | [INFO] [stdout] 6979 | && !(char_item == '.') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '.')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6995:17 [INFO] [stdout] | [INFO] [stdout] 6995 | / !(char_item == '-') [INFO] [stdout] 6996 | | && !(char_item == '.') [INFO] [stdout] 6997 | | && !(char_item == '/') [INFO] [stdout] 6998 | | && !(char_item == ':') [INFO] [stdout] 6999 | | && !(char_item == '_') [INFO] [stdout] 7000 | | && !(char_item.is_alpha() || char_item.is_dec_digit()) [INFO] [stdout] | |__________________________________________________________________________^ help: try: `!((char_item == '-') || (char_item == '.') || (char_item == '/') || (char_item == ':') || (char_item == '_') || char_item.is_alpha() || char_item.is_dec_digit())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6313:5 [INFO] [stdout] | [INFO] [stdout] 6313 | / impl ToString for Fail { [INFO] [stdout] 6314 | | fn to_string(&self) -> String { [INFO] [stdout] 6315 | | "Fail".to_string() [INFO] [stdout] 6316 | | } [INFO] [stdout] 6317 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6995:17 [INFO] [stdout] | [INFO] [stdout] 6995 | !(char_item == '-') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '-')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6996:24 [INFO] [stdout] | [INFO] [stdout] 6996 | && !(char_item == '.') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '.')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6997:24 [INFO] [stdout] | [INFO] [stdout] 6997 | && !(char_item == '/') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '/')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6319:5 [INFO] [stdout] | [INFO] [stdout] 6319 | impl Into for Fail { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 6319 ~ impl From for Error { [INFO] [stdout] 6320 ~ fn from(val: Fail) -> Self { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6998:24 [INFO] [stdout] | [INFO] [stdout] 6998 | && !(char_item == ':') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != ':')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6999:24 [INFO] [stdout] | [INFO] [stdout] 6999 | && !(char_item == '_') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '_')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:7014:17 [INFO] [stdout] | [INFO] [stdout] 7014 | / !(char_item == '-') [INFO] [stdout] 7015 | | && !(char_item == '.') [INFO] [stdout] 7016 | | && !(char_item == '_') [INFO] [stdout] 7017 | | && !(char_item == '$') [INFO] [stdout] 7018 | | && !(char_item.is_alpha() || char_item.is_dec_digit()) [INFO] [stdout] | |__________________________________________________________________________^ help: try: `!((char_item == '-') || (char_item == '.') || (char_item == '_') || (char_item == '$') || char_item.is_alpha() || char_item.is_dec_digit())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:7014:17 [INFO] [stdout] | [INFO] [stdout] 7014 | !(char_item == '-') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '-')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:7015:24 [INFO] [stdout] | [INFO] [stdout] 7015 | && !(char_item == '.') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '.')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:7016:24 [INFO] [stdout] | [INFO] [stdout] 7016 | && !(char_item == '_') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '_')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:7017:24 [INFO] [stdout] | [INFO] [stdout] 7017 | && !(char_item == '$') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '$')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:7032:17 [INFO] [stdout] | [INFO] [stdout] 7032 | / !(char_item == '-') [INFO] [stdout] 7033 | | && !(char_item == '.') [INFO] [stdout] 7034 | | && !(char_item == '_') [INFO] [stdout] 7035 | | && !(char_item.is_alpha() || char_item.is_dec_digit()) [INFO] [stdout] | |__________________________________________________________________________^ help: try: `!((char_item == '-') || (char_item == '.') || (char_item == '_') || char_item.is_alpha() || char_item.is_dec_digit())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:7032:17 [INFO] [stdout] | [INFO] [stdout] 7032 | !(char_item == '-') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '-')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:7033:24 [INFO] [stdout] | [INFO] [stdout] 7033 | && !(char_item == '.') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '.')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:7034:24 [INFO] [stdout] | [INFO] [stdout] 7034 | && !(char_item == '_') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '_')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6378:17 [INFO] [stdout] | [INFO] [stdout] 6378 | / !(char_item == '-') [INFO] [stdout] 6379 | | && !(char_item == '.') [INFO] [stdout] 6380 | | && !(char_item == '/') [INFO] [stdout] 6381 | | && !(char_item == '_') [INFO] [stdout] 6382 | | && !(char_item.is_alpha() || char_item.is_dec_digit()) [INFO] [stdout] | |__________________________________________________________________________^ help: try: `!((char_item == '-') || (char_item == '.') || (char_item == '/') || (char_item == '_') || char_item.is_alpha() || char_item.is_dec_digit())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6378:17 [INFO] [stdout] | [INFO] [stdout] 6378 | !(char_item == '-') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '-')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6379:24 [INFO] [stdout] | [INFO] [stdout] 6379 | && !(char_item == '.') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '.')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6380:24 [INFO] [stdout] | [INFO] [stdout] 6380 | && !(char_item == '/') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '/')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6381:24 [INFO] [stdout] | [INFO] [stdout] 6381 | && !(char_item == '_') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '_')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:7049:17 [INFO] [stdout] | [INFO] [stdout] 7049 | / !(char_item == '-') [INFO] [stdout] 7050 | | && !(char_item == '.') [INFO] [stdout] 7051 | | && !(char_item == '_') [INFO] [stdout] 7052 | | && !(char_item == '%') [INFO] [stdout] 7053 | | && !(char_item.is_alpha() || char_item.is_dec_digit()) [INFO] [stdout] | |__________________________________________________________________________^ help: try: `!((char_item == '-') || (char_item == '.') || (char_item == '_') || (char_item == '%') || char_item.is_alpha() || char_item.is_dec_digit())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:7049:17 [INFO] [stdout] | [INFO] [stdout] 7049 | !(char_item == '-') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '-')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:7050:24 [INFO] [stdout] | [INFO] [stdout] 7050 | && !(char_item == '.') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '.')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:7051:24 [INFO] [stdout] | [INFO] [stdout] 7051 | && !(char_item == '_') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '_')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:7052:24 [INFO] [stdout] | [INFO] [stdout] 7052 | && !(char_item == '%') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '%')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/version/v0_0_1/mod.rs:7102:42 [INFO] [stdout] | [INFO] [stdout] 7102 | pub fn parse_version(input: &str) -> Res<&str, ((&str, &str, &str), Option<&str>)> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6396:17 [INFO] [stdout] | [INFO] [stdout] 6396 | !(char_item == '-') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '-')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6397:24 [INFO] [stdout] | [INFO] [stdout] 6397 | && !(char_item == '.') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '.')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6398:24 [INFO] [stdout] | [INFO] [stdout] 6398 | && !(char_item == '/') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '/')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6399:24 [INFO] [stdout] | [INFO] [stdout] 6399 | && !(char_item == '_') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '_')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6400:24 [INFO] [stdout] | [INFO] [stdout] 6400 | && !(char_item == ':') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != ':')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6401:24 [INFO] [stdout] | [INFO] [stdout] 6401 | && !(char_item == '(') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '(')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6402:24 [INFO] [stdout] | [INFO] [stdout] 6402 | && !(char_item == ')') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != ')')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:7249:17 [INFO] [stdout] | [INFO] [stdout] 7249 | / match more { [INFO] [stdout] 7250 | | Some((kind, specific)) => { [INFO] [stdout] 7251 | | parts.kind = Option::Some(kind.to_string()); [INFO] [stdout] 7252 | | parts.specific = specific; [INFO] [stdout] 7253 | | } [INFO] [stdout] 7254 | | None => {} [INFO] [stdout] 7255 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 7249 ~ if let Some((kind, specific)) = more { [INFO] [stdout] 7250 + parts.kind = Option::Some(kind.to_string()); [INFO] [stdout] 7251 + parts.specific = specific; [INFO] [stdout] 7252 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6771:17 [INFO] [stdout] | [INFO] [stdout] 6771 | / !(char_item == '-') [INFO] [stdout] 6772 | | && !(char_item == '.') [INFO] [stdout] 6773 | | && !((char_item.is_alpha() && char_item.is_lowercase()) [INFO] [stdout] 6774 | | || char_item.is_dec_digit()) [INFO] [stdout] | |________________________________________________^ help: try: `!((char_item == '-') || (char_item == '.') || char_item.is_dec_digit() || char_item.is_alpha() && char_item.is_lowercase())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6771:17 [INFO] [stdout] | [INFO] [stdout] 6771 | !(char_item == '-') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '-')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6772:24 [INFO] [stdout] | [INFO] [stdout] 6772 | && !(char_item == '.') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '.')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6788:17 [INFO] [stdout] | [INFO] [stdout] 6788 | / !(char_item == '-') [INFO] [stdout] 6789 | | && !(char_item == '.') [INFO] [stdout] 6790 | | && !((char_item.is_alpha() && char_item.is_lowercase()) [INFO] [stdout] 6791 | | || char_item.is_dec_digit()) [INFO] [stdout] | |____________________________________________________^ help: try: `!((char_item == '-') || (char_item == '.') || char_item.is_dec_digit() || char_item.is_alpha() && char_item.is_lowercase())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6788:17 [INFO] [stdout] | [INFO] [stdout] 6788 | !(char_item == '-') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '-')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6789:24 [INFO] [stdout] | [INFO] [stdout] 6789 | && !(char_item == '.') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '.')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6805:17 [INFO] [stdout] | [INFO] [stdout] 6805 | / !(char_item == '-') [INFO] [stdout] 6806 | | && !(char_item == '.') [INFO] [stdout] 6807 | | && !(char_item.is_alpha() || char_item.is_dec_digit()) [INFO] [stdout] | |__________________________________________________________________________^ help: try: `!((char_item == '-') || (char_item == '.') || char_item.is_alpha() || char_item.is_dec_digit())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6805:17 [INFO] [stdout] | [INFO] [stdout] 6805 | !(char_item == '-') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '-')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6806:24 [INFO] [stdout] | [INFO] [stdout] 6806 | && !(char_item == '.') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '.')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6824:22 [INFO] [stdout] | [INFO] [stdout] 6824 | !char_item.is_digit(10) && [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `char_item.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6840:17 [INFO] [stdout] | [INFO] [stdout] 6840 | !(char_item == '-') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '-')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6841:24 [INFO] [stdout] | [INFO] [stdout] 6841 | && !(char_item == '>') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '>')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6842:24 [INFO] [stdout] | [INFO] [stdout] 6842 | && !(char_item == '<') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '<')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6843:24 [INFO] [stdout] | [INFO] [stdout] 6843 | && !(char_item == '^') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '^')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6844:24 [INFO] [stdout] | [INFO] [stdout] 6844 | && !(char_item == '=') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '=')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `extern` block uses type `std::string::String`, which is not FFI-safe [INFO] [stdout] --> src/version/v0_0_1/mod.rs:16:39 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn mesh_portal_unique_id() -> String; [INFO] [stdout] | ^^^^^^ not FFI-safe [INFO] [stdout] | [INFO] [stdout] = help: consider adding a `#[repr(C)]` or `#[repr(transparent)]` attribute to this struct [INFO] [stdout] = note: this struct has unspecified layout [INFO] [stdout] = note: `#[warn(improper_ctypes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6892:22 [INFO] [stdout] | [INFO] [stdout] 6892 | !char_item.is_digit(10) && [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `char_item.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6910:22 [INFO] [stdout] | [INFO] [stdout] 6910 | !char_item.is_digit(10) && [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `char_item.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6927:22 [INFO] [stdout] | [INFO] [stdout] 6927 | !char_item.is_digit(10) && [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `char_item.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6942:17 [INFO] [stdout] | [INFO] [stdout] 6942 | / !(char_item == '-') [INFO] [stdout] 6943 | | && !(char_item == '.') [INFO] [stdout] 6944 | | && !((char_item.is_alpha() && char_item.is_lowercase()) [INFO] [stdout] 6945 | | || char_item.is_dec_digit()) [INFO] [stdout] | |____________________________________________________^ help: try: `!((char_item == '-') || (char_item == '.') || char_item.is_dec_digit() || char_item.is_alpha() && char_item.is_lowercase())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6942:17 [INFO] [stdout] | [INFO] [stdout] 6942 | !(char_item == '-') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '-')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6943:24 [INFO] [stdout] | [INFO] [stdout] 6943 | && !(char_item == '.') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '.')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6959:17 [INFO] [stdout] | [INFO] [stdout] 6959 | / !(char_item == '-') [INFO] [stdout] 6960 | | && !(char_item == '.') [INFO] [stdout] 6961 | | && !(char_item == '$') [INFO] [stdout] 6962 | | && !((char_item.is_alpha() && char_item.is_lowercase()) [INFO] [stdout] 6963 | | || char_item.is_dec_digit()) [INFO] [stdout] | |________________________________________________^ help: try: `!((char_item == '-') || (char_item == '.') || (char_item == '$') || char_item.is_dec_digit() || char_item.is_alpha() && char_item.is_lowercase())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6959:17 [INFO] [stdout] | [INFO] [stdout] 6959 | !(char_item == '-') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '-')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6960:24 [INFO] [stdout] | [INFO] [stdout] 6960 | && !(char_item == '.') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '.')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6961:24 [INFO] [stdout] | [INFO] [stdout] 6961 | && !(char_item == '$') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '$')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6978:17 [INFO] [stdout] | [INFO] [stdout] 6978 | / !(char_item == '-') [INFO] [stdout] 6979 | | && !(char_item == '.') [INFO] [stdout] 6980 | | && !((char_item.is_alpha() && char_item.is_lowercase()) [INFO] [stdout] 6981 | | || char_item.is_dec_digit()) [INFO] [stdout] | |____________________________________________________^ help: try: `!((char_item == '-') || (char_item == '.') || char_item.is_dec_digit() || char_item.is_alpha() && char_item.is_lowercase())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6978:17 [INFO] [stdout] | [INFO] [stdout] 6978 | !(char_item == '-') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '-')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6979:24 [INFO] [stdout] | [INFO] [stdout] 6979 | && !(char_item == '.') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '.')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6995:17 [INFO] [stdout] | [INFO] [stdout] 6995 | / !(char_item == '-') [INFO] [stdout] 6996 | | && !(char_item == '.') [INFO] [stdout] 6997 | | && !(char_item == '/') [INFO] [stdout] 6998 | | && !(char_item == ':') [INFO] [stdout] 6999 | | && !(char_item == '_') [INFO] [stdout] 7000 | | && !(char_item.is_alpha() || char_item.is_dec_digit()) [INFO] [stdout] | |__________________________________________________________________________^ help: try: `!((char_item == '-') || (char_item == '.') || (char_item == '/') || (char_item == ':') || (char_item == '_') || char_item.is_alpha() || char_item.is_dec_digit())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6995:17 [INFO] [stdout] | [INFO] [stdout] 6995 | !(char_item == '-') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '-')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6996:24 [INFO] [stdout] | [INFO] [stdout] 6996 | && !(char_item == '.') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '.')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6997:24 [INFO] [stdout] | [INFO] [stdout] 6997 | && !(char_item == '/') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '/')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6998:24 [INFO] [stdout] | [INFO] [stdout] 6998 | && !(char_item == ':') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != ':')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:6999:24 [INFO] [stdout] | [INFO] [stdout] 6999 | && !(char_item == '_') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '_')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:7014:17 [INFO] [stdout] | [INFO] [stdout] 7014 | / !(char_item == '-') [INFO] [stdout] 7015 | | && !(char_item == '.') [INFO] [stdout] 7016 | | && !(char_item == '_') [INFO] [stdout] 7017 | | && !(char_item == '$') [INFO] [stdout] 7018 | | && !(char_item.is_alpha() || char_item.is_dec_digit()) [INFO] [stdout] | |__________________________________________________________________________^ help: try: `!((char_item == '-') || (char_item == '.') || (char_item == '_') || (char_item == '$') || char_item.is_alpha() || char_item.is_dec_digit())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:7014:17 [INFO] [stdout] | [INFO] [stdout] 7014 | !(char_item == '-') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '-')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:7015:24 [INFO] [stdout] | [INFO] [stdout] 7015 | && !(char_item == '.') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '.')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:7016:24 [INFO] [stdout] | [INFO] [stdout] 7016 | && !(char_item == '_') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '_')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:7017:24 [INFO] [stdout] | [INFO] [stdout] 7017 | && !(char_item == '$') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '$')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:7032:17 [INFO] [stdout] | [INFO] [stdout] 7032 | / !(char_item == '-') [INFO] [stdout] 7033 | | && !(char_item == '.') [INFO] [stdout] 7034 | | && !(char_item == '_') [INFO] [stdout] 7035 | | && !(char_item.is_alpha() || char_item.is_dec_digit()) [INFO] [stdout] | |__________________________________________________________________________^ help: try: `!((char_item == '-') || (char_item == '.') || (char_item == '_') || char_item.is_alpha() || char_item.is_dec_digit())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:7032:17 [INFO] [stdout] | [INFO] [stdout] 7032 | !(char_item == '-') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '-')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:7033:24 [INFO] [stdout] | [INFO] [stdout] 7033 | && !(char_item == '.') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '.')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:7034:24 [INFO] [stdout] | [INFO] [stdout] 7034 | && !(char_item == '_') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '_')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:7049:17 [INFO] [stdout] | [INFO] [stdout] 7049 | / !(char_item == '-') [INFO] [stdout] 7050 | | && !(char_item == '.') [INFO] [stdout] 7051 | | && !(char_item == '_') [INFO] [stdout] 7052 | | && !(char_item == '%') [INFO] [stdout] 7053 | | && !(char_item.is_alpha() || char_item.is_dec_digit()) [INFO] [stdout] | |__________________________________________________________________________^ help: try: `!((char_item == '-') || (char_item == '.') || (char_item == '_') || (char_item == '%') || char_item.is_alpha() || char_item.is_dec_digit())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:7049:17 [INFO] [stdout] | [INFO] [stdout] 7049 | !(char_item == '-') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '-')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:7050:24 [INFO] [stdout] | [INFO] [stdout] 7050 | && !(char_item == '.') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '.')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:7051:24 [INFO] [stdout] | [INFO] [stdout] 7051 | && !(char_item == '_') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '_')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/version/v0_0_1/mod.rs:7052:24 [INFO] [stdout] | [INFO] [stdout] 7052 | && !(char_item == '%') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(char_item != '%')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/version/v0_0_1/mod.rs:7102:42 [INFO] [stdout] | [INFO] [stdout] 7102 | pub fn parse_version(input: &str) -> Res<&str, ((&str, &str, &str), Option<&str>)> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:7249:17 [INFO] [stdout] | [INFO] [stdout] 7249 | / match more { [INFO] [stdout] 7250 | | Some((kind, specific)) => { [INFO] [stdout] 7251 | | parts.kind = Option::Some(kind.to_string()); [INFO] [stdout] 7252 | | parts.specific = specific; [INFO] [stdout] 7253 | | } [INFO] [stdout] 7254 | | None => {} [INFO] [stdout] 7255 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 7249 ~ if let Some((kind, specific)) = more { [INFO] [stdout] 7250 + parts.kind = Option::Some(kind.to_string()); [INFO] [stdout] 7251 + parts.specific = specific; [INFO] [stdout] 7252 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5503:53 [INFO] [stdout] | [INFO] [stdout] 5503 | let errors = Errors::default(message.clone()); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/version/v0_0_1/mod.rs:7457:9 [INFO] [stdout] | [INFO] [stdout] 7457 | / match all_consuming(rec_skewer)("317"){ [INFO] [stdout] 7458 | | Ok(ok) => { [INFO] [stdout] 7459 | | return Err("should not have parsed 317".into()); [INFO] [stdout] ... | [INFO] [stdout] 7462 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 7457 ~ if let Ok(ok) = all_consuming(rec_skewer)("317") { [INFO] [stdout] 7458 + return Err("should not have parsed 317".into()); [INFO] [stdout] 7459 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `extern` block uses type `std::string::String`, which is not FFI-safe [INFO] [stdout] --> src/version/v0_0_1/mod.rs:16:39 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn mesh_portal_unique_id() -> String; [INFO] [stdout] | ^^^^^^ not FFI-safe [INFO] [stdout] | [INFO] [stdout] = help: consider adding a `#[repr(C)]` or `#[repr(transparent)]` attribute to this struct [INFO] [stdout] = note: this struct has unspecified layout [INFO] [stdout] = note: `#[warn(improper_ctypes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/version/v0_0_1/mod.rs:5503:53 [INFO] [stdout] | [INFO] [stdout] 5503 | let errors = Errors::default(message.clone()); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 15.57s [INFO] running `Command { std: "docker" "inspect" "ae584ff3f5f8a0b2e871a6ce3c1b3546737dfc245d6ed7b2146f54a02907bee9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ae584ff3f5f8a0b2e871a6ce3c1b3546737dfc245d6ed7b2146f54a02907bee9", kill_on_drop: false }` [INFO] [stdout] ae584ff3f5f8a0b2e871a6ce3c1b3546737dfc245d6ed7b2146f54a02907bee9