[INFO] fetching crate melodies-core 0.1.0...
[INFO] linting melodies-core-0.1.0 against nightly for clippy-nonminimal_bool-denied
[INFO] extracting crate melodies-core 0.1.0 into /workspace/builds/worker-4-tc1/source
[INFO] started tweaking crates.io crate melodies-core 0.1.0
[INFO] finished tweaking crates.io crate melodies-core 0.1.0
[INFO] tweaked toml for crates.io crate melodies-core 0.1.0 written to /workspace/builds/worker-4-tc1/source/Cargo.toml
[INFO] validating manifest of crates.io crate melodies-core 0.1.0 on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Blocking waiting for file lock on package cache
[INFO] [stderr]     Updating crates.io index
[INFO] [stderr]     Blocking waiting for file lock on package cache
[INFO] [stderr]      Locking 6 packages to latest compatible versions
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] ebe1ea35a214b81c8a82722da13788614c444cfbf280d363fc3afe4623643509
[INFO] running `Command { std: "docker" "start" "-a" "ebe1ea35a214b81c8a82722da13788614c444cfbf280d363fc3afe4623643509", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "ebe1ea35a214b81c8a82722da13788614c444cfbf280d363fc3afe4623643509", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "ebe1ea35a214b81c8a82722da13788614c444cfbf280d363fc3afe4623643509", kill_on_drop: false }`
[INFO] [stdout] ebe1ea35a214b81c8a82722da13788614c444cfbf280d363fc3afe4623643509
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] ec3336a50fcf32caa4cf09f871bdf09e5d940ef2bc090aad5f976559c1d93631
[INFO] running `Command { std: "docker" "start" "-a" "ec3336a50fcf32caa4cf09f871bdf09e5d940ef2bc090aad5f976559c1d93631", kill_on_drop: false }`
[INFO] [stderr]    Compiling syn v2.0.117
[INFO] [stderr]    Compiling zeroize_derive v1.4.3
[INFO] [stderr]     Checking zeroize v1.8.2
[INFO] [stderr]     Checking melodies-core v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: name `PSK` contains a capitalized acronym
[INFO] [stdout]   --> src/handshake_pattern.rs:10:5
[INFO] [stdout]    |
[INFO] [stdout] 10 |     PSK,
[INFO] [stdout]    |     ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Psk`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
[INFO] [stdout]    = note: `#[warn(clippy::upper_case_acronyms)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/handshake_pattern.rs:345:17
[INFO] [stdout]     |
[INFO] [stdout] 345 | /                 if se {
[INFO] [stdout] 346 | |                     if !ee {
[INFO] [stdout] 347 | |                         return Err(InvalidReason::MissingEphemeralDH);
[INFO] [stdout] 348 | |                     }
[INFO] [stdout] 349 | |                 }
[INFO] [stdout]     | |_________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout]     = note: `#[warn(clippy::collapsible_if)]` on by default
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 345 ~                 if se
[INFO] [stdout] 346 ~                     && !ee {
[INFO] [stdout] 347 |                         return Err(InvalidReason::MissingEphemeralDH);
[INFO] [stdout] 348 ~                     }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/handshake_pattern.rs:350:17
[INFO] [stdout]     |
[INFO] [stdout] 350 | /                 if ss {
[INFO] [stdout] 351 | |                     if !es {
[INFO] [stdout] 352 | |                         return Err(InvalidReason::MissingEphemeralDH);
[INFO] [stdout] 353 | |                     }
[INFO] [stdout] 354 | |                 }
[INFO] [stdout]     | |_________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 350 ~                 if ss
[INFO] [stdout] 351 ~                     && !es {
[INFO] [stdout] 352 |                         return Err(InvalidReason::MissingEphemeralDH);
[INFO] [stdout] 353 ~                     }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/handshake_pattern.rs:356:17
[INFO] [stdout]     |
[INFO] [stdout] 356 | /                 if es {
[INFO] [stdout] 357 | |                     if !ee {
[INFO] [stdout] 358 | |                         return Err(InvalidReason::MissingEphemeralDH);
[INFO] [stdout] 359 | |                     }
[INFO] [stdout] 360 | |                 }
[INFO] [stdout]     | |_________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 356 ~                 if es
[INFO] [stdout] 357 ~                     && !ee {
[INFO] [stdout] 358 |                         return Err(InvalidReason::MissingEphemeralDH);
[INFO] [stdout] 359 ~                     }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/handshake_pattern.rs:361:17
[INFO] [stdout]     |
[INFO] [stdout] 361 | /                 if ss {
[INFO] [stdout] 362 | |                     if !es {
[INFO] [stdout] 363 | |                         return Err(InvalidReason::MissingEphemeralDH);
[INFO] [stdout] 364 | |                     }
[INFO] [stdout] 365 | |                 }
[INFO] [stdout]     | |_________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 361 ~                 if ss
[INFO] [stdout] 362 ~                     && !es {
[INFO] [stdout] 363 |                         return Err(InvalidReason::MissingEphemeralDH);
[INFO] [stdout] 364 ~                     }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/handshake_pattern.rs:395:17
[INFO] [stdout]     |
[INFO] [stdout] 395 |           assert!(!HandshakePattern {
[INFO] [stdout]     |  _________________^
[INFO] [stdout] 396 | |             name: "",
[INFO] [stdout] 397 | |             patterns: &[&[PSK], &[]]
[INFO] [stdout] ...   |
[INFO] [stdout] 400 | |         .is_ok());
[INFO] [stdout]     | |________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 395 ~         assert!(HandshakePattern {
[INFO] [stdout] 396 +             name: "",
[INFO] [stdout] 397 +             patterns: &[&[PSK], &[]]
[INFO] [stdout] 398 +         }
[INFO] [stdout] 399 ~         .validate().is_err());
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this function has too many arguments (8/7)
[INFO] [stdout]   --> src/handshake_state.rs:57:5
[INFO] [stdout]    |
[INFO] [stdout] 57 | /     pub fn new(
[INFO] [stdout] 58 | |         cipher: &'static dyn Cipher,
[INFO] [stdout] 59 | |         pattern: &'static HandshakePattern,
[INFO] [stdout] 60 | |         initiator: bool,
[INFO] [stdout] ...  |
[INFO] [stdout] 65 | |         re: Option<[u8; DHLEN]>,
[INFO] [stdout] 66 | |     ) -> Self {
[INFO] [stdout]    | |_____________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stdout]    = note: `#[warn(clippy::too_many_arguments)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/handshake_state.rs:70:71
[INFO] [stdout]    |
[INFO] [stdout] 70 |             symmetric_state: SymmetricState::new(&Self::protocol_name(&pattern, cipher), cipher),
[INFO] [stdout]    |                                                                       ^^^^^^^^ help: change this to: `pattern`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/handshake_state.rs:139:18
[INFO] [stdout]     |
[INFO] [stdout] 139 |         local.dh(&remote, &mut tmp);
[INFO] [stdout]     |                  ^^^^^^^ help: change this to: `remote`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/handshake_state.rs:213:51
[INFO] [stdout]     |
[INFO] [stdout] 213 |                     self.symmetric_state.mix_hash(&re_buf);
[INFO] [stdout]     |                                                   ^^^^^^^ help: change this to: `re_buf`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/handshake_state.rs:214:78
[INFO] [stdout]     |
[INFO] [stdout] 214 |                     if self.pattern.has_psk() { self.symmetric_state.mix_key(&re_buf); }
[INFO] [stdout]     |                                                                              ^^^^^^^ help: change this to: `re_buf`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: name `PSK` contains a capitalized acronym
[INFO] [stdout]   --> src/handshake_pattern.rs:10:5
[INFO] [stdout]    |
[INFO] [stdout] 10 |     PSK,
[INFO] [stdout]    |     ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Psk`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
[INFO] [stdout]    = note: `#[warn(clippy::upper_case_acronyms)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded unit return type
[INFO] [stdout]   --> src/crypto.rs:96:36
[INFO] [stdout]    |
[INFO] [stdout] 96 |     write_text: impl FnOnce(&mut H) -> ()
[INFO] [stdout]    |                                    ^^^^^^ help: remove the `-> ()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stdout]    = note: `#[warn(clippy::unused_unit)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/crypto.rs:111:17
[INFO] [stdout]     |
[INFO] [stdout] 111 |     hash.update(&key_block);
[INFO] [stdout]     |                 ^^^^^^^^^^ help: change this to: `key_block`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/crypto.rs:119:17
[INFO] [stdout]     |
[INFO] [stdout] 119 |     hash.update(&key_block);
[INFO] [stdout]     |                 ^^^^^^^^^^ help: change this to: `key_block`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: deref which would be done by auto-deref
[INFO] [stdout]    --> src/crypto.rs:142:33
[INFO] [stdout]     |
[INFO] [stdout] 142 |         hmac::<L, H>(&temp_key, *output, |hash| {
[INFO] [stdout]     |                                 ^^^^^^^ help: try: `output`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
[INFO] [stdout]     = note: `#[warn(clippy::explicit_auto_deref)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing
[INFO] [stdout]    --> src/handshake_state.rs:189:9
[INFO] [stdout]     |
[INFO] [stdout] 189 |         drop(buf_remaining);
[INFO] [stdout]     |         ^^^^^-------------^
[INFO] [stdout]     |              |
[INFO] [stdout]     |              argument has type `&mut [u8]`
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(dropping_references)]` on by default
[INFO] [stdout] help: use `let _ = ...` to ignore the expression or result
[INFO] [stdout]     |
[INFO] [stdout] 189 -         drop(buf_remaining);
[INFO] [stdout] 189 +         let _ = buf_remaining;
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/handshake_pattern.rs:345:17
[INFO] [stdout]     |
[INFO] [stdout] 345 | /                 if se {
[INFO] [stdout] 346 | |                     if !ee {
[INFO] [stdout] 347 | |                         return Err(InvalidReason::MissingEphemeralDH);
[INFO] [stdout] 348 | |                     }
[INFO] [stdout] 349 | |                 }
[INFO] [stdout]     | |_________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout]     = note: `#[warn(clippy::collapsible_if)]` on by default
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 345 ~                 if se
[INFO] [stdout] 346 ~                     && !ee {
[INFO] [stdout] 347 |                         return Err(InvalidReason::MissingEphemeralDH);
[INFO] [stdout] 348 ~                     }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/handshake_pattern.rs:350:17
[INFO] [stdout]     |
[INFO] [stdout] 350 | /                 if ss {
[INFO] [stdout] 351 | |                     if !es {
[INFO] [stdout] 352 | |                         return Err(InvalidReason::MissingEphemeralDH);
[INFO] [stdout] 353 | |                     }
[INFO] [stdout] 354 | |                 }
[INFO] [stdout]     | |_________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 350 ~                 if ss
[INFO] [stdout] 351 ~                     && !es {
[INFO] [stdout] 352 |                         return Err(InvalidReason::MissingEphemeralDH);
[INFO] [stdout] 353 ~                     }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/handshake_pattern.rs:356:17
[INFO] [stdout]     |
[INFO] [stdout] 356 | /                 if es {
[INFO] [stdout] 357 | |                     if !ee {
[INFO] [stdout] 358 | |                         return Err(InvalidReason::MissingEphemeralDH);
[INFO] [stdout] 359 | |                     }
[INFO] [stdout] 360 | |                 }
[INFO] [stdout]     | |_________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 356 ~                 if es
[INFO] [stdout] 357 ~                     && !ee {
[INFO] [stdout] 358 |                         return Err(InvalidReason::MissingEphemeralDH);
[INFO] [stdout] 359 ~                     }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/handshake_pattern.rs:361:17
[INFO] [stdout]     |
[INFO] [stdout] 361 | /                 if ss {
[INFO] [stdout] 362 | |                     if !es {
[INFO] [stdout] 363 | |                         return Err(InvalidReason::MissingEphemeralDH);
[INFO] [stdout] 364 | |                     }
[INFO] [stdout] 365 | |                 }
[INFO] [stdout]     | |_________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 361 ~                 if ss
[INFO] [stdout] 362 ~                     && !es {
[INFO] [stdout] 363 |                         return Err(InvalidReason::MissingEphemeralDH);
[INFO] [stdout] 364 ~                     }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this function has too many arguments (8/7)
[INFO] [stdout]   --> src/handshake_state.rs:57:5
[INFO] [stdout]    |
[INFO] [stdout] 57 | /     pub fn new(
[INFO] [stdout] 58 | |         cipher: &'static dyn Cipher,
[INFO] [stdout] 59 | |         pattern: &'static HandshakePattern,
[INFO] [stdout] 60 | |         initiator: bool,
[INFO] [stdout] ...  |
[INFO] [stdout] 65 | |         re: Option<[u8; DHLEN]>,
[INFO] [stdout] 66 | |     ) -> Self {
[INFO] [stdout]    | |_____________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stdout]    = note: `#[warn(clippy::too_many_arguments)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/handshake_state.rs:70:71
[INFO] [stdout]    |
[INFO] [stdout] 70 |             symmetric_state: SymmetricState::new(&Self::protocol_name(&pattern, cipher), cipher),
[INFO] [stdout]    |                                                                       ^^^^^^^^ help: change this to: `pattern`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/handshake_state.rs:139:18
[INFO] [stdout]     |
[INFO] [stdout] 139 |         local.dh(&remote, &mut tmp);
[INFO] [stdout]     |                  ^^^^^^^ help: change this to: `remote`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/handshake_state.rs:213:51
[INFO] [stdout]     |
[INFO] [stdout] 213 |                     self.symmetric_state.mix_hash(&re_buf);
[INFO] [stdout]     |                                                   ^^^^^^^ help: change this to: `re_buf`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/handshake_state.rs:214:78
[INFO] [stdout]     |
[INFO] [stdout] 214 |                     if self.pattern.has_psk() { self.symmetric_state.mix_key(&re_buf); }
[INFO] [stdout]     |                                                                              ^^^^^^^ help: change this to: `re_buf`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded unit return type
[INFO] [stdout]   --> src/crypto.rs:96:36
[INFO] [stdout]    |
[INFO] [stdout] 96 |     write_text: impl FnOnce(&mut H) -> ()
[INFO] [stdout]    |                                    ^^^^^^ help: remove the `-> ()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stdout]    = note: `#[warn(clippy::unused_unit)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/crypto.rs:111:17
[INFO] [stdout]     |
[INFO] [stdout] 111 |     hash.update(&key_block);
[INFO] [stdout]     |                 ^^^^^^^^^^ help: change this to: `key_block`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/crypto.rs:119:17
[INFO] [stdout]     |
[INFO] [stdout] 119 |     hash.update(&key_block);
[INFO] [stdout]     |                 ^^^^^^^^^^ help: change this to: `key_block`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: deref which would be done by auto-deref
[INFO] [stdout]    --> src/crypto.rs:142:33
[INFO] [stdout]     |
[INFO] [stdout] 142 |         hmac::<L, H>(&temp_key, *output, |hash| {
[INFO] [stdout]     |                                 ^^^^^^^ help: try: `output`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
[INFO] [stdout]     = note: `#[warn(clippy::explicit_auto_deref)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing
[INFO] [stdout]    --> src/handshake_state.rs:189:9
[INFO] [stdout]     |
[INFO] [stdout] 189 |         drop(buf_remaining);
[INFO] [stdout]     |         ^^^^^-------------^
[INFO] [stdout]     |              |
[INFO] [stdout]     |              argument has type `&mut [u8]`
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(dropping_references)]` on by default
[INFO] [stdout] help: use `let _ = ...` to ignore the expression or result
[INFO] [stdout]     |
[INFO] [stdout] 189 -         drop(buf_remaining);
[INFO] [stdout] 189 +         let _ = buf_remaining;
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 6.21s
[INFO] running `Command { std: "docker" "inspect" "ec3336a50fcf32caa4cf09f871bdf09e5d940ef2bc090aad5f976559c1d93631", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "ec3336a50fcf32caa4cf09f871bdf09e5d940ef2bc090aad5f976559c1d93631", kill_on_drop: false }`
[INFO] [stdout] ec3336a50fcf32caa4cf09f871bdf09e5d940ef2bc090aad5f976559c1d93631