[INFO] fetching crate medea-turn 0.12.0... [INFO] linting medea-turn-0.12.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate medea-turn 0.12.0 into /workspace/builds/worker-0-tc1/source [INFO] started tweaking crates.io crate medea-turn 0.12.0 [INFO] finished tweaking crates.io crate medea-turn 0.12.0 [INFO] tweaked toml for crates.io crate medea-turn 0.12.0 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate medea-turn 0.12.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate medea-turn 0.12.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded stun_codec v0.4.0 [INFO] [stderr] Downloaded bytecodec v0.5.0 [INFO] [stderr] Downloaded tokio v1.46.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 337d657dd1bb48207a2dfe6e7b318691f8e8f9112b526261b5762db8d556c134 [INFO] running `Command { std: "docker" "start" "-a" "337d657dd1bb48207a2dfe6e7b318691f8e8f9112b526261b5762db8d556c134", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "337d657dd1bb48207a2dfe6e7b318691f8e8f9112b526261b5762db8d556c134", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "337d657dd1bb48207a2dfe6e7b318691f8e8f9112b526261b5762db8d556c134", kill_on_drop: false }` [INFO] [stdout] 337d657dd1bb48207a2dfe6e7b318691f8e8f9112b526261b5762db8d556c134 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4e4f18d34a3bc630d13ae20907c73ba90b455fbb32cf79130c53f16df02d25da [INFO] running `Command { std: "docker" "start" "-a" "4e4f18d34a3bc630d13ae20907c73ba90b455fbb32cf79130c53f16df02d25da", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.174 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Checking md5 v0.7.0 [INFO] [stderr] Checking crc v3.3.0 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Compiling syn v2.0.104 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking secrecy v0.10.3 [INFO] [stderr] Checking getrandom v0.3.3 [INFO] [stderr] Checking socket2 v0.5.10 [INFO] [stderr] Checking mio v1.0.4 [INFO] [stderr] Checking rand_core v0.9.3 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking rand v0.9.1 [INFO] [stderr] Compiling trackable_derive v1.0.0 [INFO] [stderr] Checking trackable v1.3.0 [INFO] [stderr] Checking bytecodec v0.5.0 [INFO] [stderr] Checking stun_codec v0.4.0 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling tokio-macros v2.5.0 [INFO] [stderr] Compiling derive_more-impl v2.0.1 [INFO] [stderr] Compiling async-trait v0.1.88 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking tokio v1.46.1 [INFO] [stderr] Checking derive_more v2.0.1 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking tokio-util v0.7.15 [INFO] [stderr] Checking medea-turn v0.12.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: lint `clippy::string_to_string` has been removed: `clippy::implicit_clone` covers those cases [INFO] [stdout] --> src/lib.rs:97:5 [INFO] [stdout] | [INFO] [stdout] 97 | clippy::string_to_string, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `clippy::string_to_string` has been removed: `clippy::implicit_clone` covers those cases [INFO] [stdout] --> src/lib.rs:97:5 [INFO] [stdout] | [INFO] [stdout] 97 | clippy::string_to_string, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: integer literal has a better hexadecimal representation [INFO] [stdout] --> src/allocation/manager.rs:182:27 [INFO] [stdout] | [INFO] [stdout] 182 | max_port: 65535, [INFO] [stdout] | ^^^^^ help: consider: `0xFFFF` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#decimal_literal_representation [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | clippy::decimal_literal_representation, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: integer literal has a better hexadecimal representation [INFO] [stdout] --> src/server/request.rs:1028:31 [INFO] [stdout] | [INFO] [stdout] 1028 | max_port: 65535, [INFO] [stdout] | ^^^^^ help: consider: `0xFFFF` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#decimal_literal_representation [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/channel_bind.rs:107:36 [INFO] [stdout] | [INFO] [stdout] 107 | let turn_socket = Arc::new(UdpSocket::bind("0.0.0.0:0").await.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:119:5 [INFO] [stdout] | [INFO] [stdout] 119 | clippy::unwrap_used, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/channel_bind.rs:109:26 [INFO] [stdout] | [INFO] [stdout] 109 | let relay_addr = relay_socket.local_addr().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/channel_bind.rs:116:13 [INFO] [stdout] | [INFO] [stdout] 116 | Username::new(String::from("user")).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hand-coded well-known IP address [INFO] [stdout] --> src/allocation/channel_bind.rs:120:36 [INFO] [stdout] | [INFO] [stdout] 120 | let addr = SocketAddr::new(Ipv4Addr::new(0, 0, 0, 0).into(), 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ip_constant [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:70:5 [INFO] [stdout] | [INFO] [stdout] 70 | clippy::pedantic, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(clippy::ip_constant)]` implied by `#[warn(clippy::pedantic)]` [INFO] [stdout] help: use [INFO] [stdout] | [INFO] [stdout] 120 - let addr = SocketAddr::new(Ipv4Addr::new(0, 0, 0, 0).into(), 0); [INFO] [stdout] 120 + let addr = SocketAddr::new(Ipv4Addr::UNSPECIFIED.into(), 0); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/channel_bind.rs:129:17 [INFO] [stdout] | [INFO] [stdout] 129 | let a = create_channel_bind_allocation(Duration::from_millis(20)) [INFO] [stdout] | _________________^ [INFO] [stdout] 130 | | .await [INFO] [stdout] 131 | | .unwrap(); [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: importing trait that is only used anonymously [INFO] [stdout] --> src/allocation/manager.rs:157:14 [INFO] [stdout] | [INFO] [stdout] 157 | str::FromStr, [INFO] [stdout] | ^^^^^^^ help: use: `FromStr as _` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_trait_names [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:117:5 [INFO] [stdout] | [INFO] [stdout] 117 | clippy::unused_trait_names, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hand-coded well-known IP address [INFO] [stdout] --> src/allocation/manager.rs:195:17 [INFO] [stdout] | [INFO] [stdout] 195 | Ipv4Addr::new(0, 0, 0, 0).into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ip_constant [INFO] [stdout] help: use [INFO] [stdout] | [INFO] [stdout] 195 - Ipv4Addr::new(0, 0, 0, 0).into(), [INFO] [stdout] 195 + Ipv4Addr::UNSPECIFIED.into(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hand-coded well-known IP address [INFO] [stdout] --> src/allocation/manager.rs:199:17 [INFO] [stdout] | [INFO] [stdout] 199 | Ipv4Addr::new(0, 0, 0, 0).into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ip_constant [INFO] [stdout] help: use [INFO] [stdout] | [INFO] [stdout] 199 - Ipv4Addr::new(0, 0, 0, 0).into(), [INFO] [stdout] 199 + Ipv4Addr::UNSPECIFIED.into(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/manager.rs:208:27 [INFO] [stdout] | [INFO] [stdout] 208 | let turn_socket = UdpSocket::bind("127.0.0.1:0").await.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/manager.rs:210:31 [INFO] [stdout] | [INFO] [stdout] 210 | let client_listener = UdpSocket::bind("127.0.0.1:0").await.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/manager.rs:211:24 [INFO] [stdout] | [INFO] [stdout] 211 | let src_addr = client_listener.local_addr().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this could be rewritten as `let...else` [INFO] [stdout] --> src/allocation/manager.rs:217:17 [INFO] [stdout] | [INFO] [stdout] 217 | / let n = match client_listener.recv_from(&mut buffer).await { [INFO] [stdout] 218 | | Ok((n, _)) => n, [INFO] [stdout] 219 | | Err(_) => break, [INFO] [stdout] 220 | | }; [INFO] [stdout] | |__________________^ help: consider writing: `let Ok((n, _)) = client_listener.recv_from(&mut buffer).await else { break };` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_let_else [INFO] [stdout] = note: `#[warn(clippy::manual_let_else)]` implied by `#[warn(clippy::pedantic)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/manager.rs:228:23 [INFO] [stdout] | [INFO] [stdout] 228 | dst_addr: turn_socket.local_addr().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/manager.rs:232:13 [INFO] [stdout] | [INFO] [stdout] 232 | _ = m [INFO] [stdout] | _____________^ [INFO] [stdout] 233 | | .create_allocation( [INFO] [stdout] 234 | | five_tuple, [INFO] [stdout] 235 | | Arc::new(turn_socket), [INFO] [stdout] ... | [INFO] [stdout] 241 | | .await [INFO] [stdout] 242 | | .unwrap(); [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/manager.rs:238:17 [INFO] [stdout] | [INFO] [stdout] 238 | Username::new(String::from("user")).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on an `Option` value [INFO] [stdout] --> src/allocation/manager.rs:243:17 [INFO] [stdout] | [INFO] [stdout] 243 | let a = m.get_alloc(&five_tuple).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is `None`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/manager.rs:245:30 [INFO] [stdout] | [INFO] [stdout] 245 | let peer_listener1 = UdpSocket::bind("127.0.0.1:0").await.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/manager.rs:246:30 [INFO] [stdout] | [INFO] [stdout] 246 | let peer_listener2 = UdpSocket::bind("127.0.0.1:0").await.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/manager.rs:249:30 [INFO] [stdout] | [INFO] [stdout] 249 | a.add_permission(peer_listener1.local_addr().unwrap().ip()).await; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/manager.rs:250:13 [INFO] [stdout] | [INFO] [stdout] 250 | / a.add_channel_bind( [INFO] [stdout] 251 | | ChannelNumber::MIN, [INFO] [stdout] 252 | | peer_listener2.local_addr().unwrap(), [INFO] [stdout] 253 | | DEFAULT_LIFETIME, [INFO] [stdout] 254 | | ) [INFO] [stdout] 255 | | .await [INFO] [stdout] 256 | | .unwrap(); [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/manager.rs:252:17 [INFO] [stdout] | [INFO] [stdout] 252 | peer_listener2.local_addr().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/manager.rs:258:13 [INFO] [stdout] | [INFO] [stdout] 258 | a.relay_socket.local_addr().unwrap().port() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/manager.rs:263:13 [INFO] [stdout] | [INFO] [stdout] 263 | SocketAddr::from_str(&relay_addr_with_host_str).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-binding `let` without a type annotation [INFO] [stdout] --> src/allocation/manager.rs:266:9 [INFO] [stdout] | [INFO] [stdout] 266 | / let _ = peer_listener1 [INFO] [stdout] 267 | | .send_to(target_text.as_bytes(), relay_addr_with_host) [INFO] [stdout] 268 | | .await [INFO] [stdout] 269 | | .unwrap(); [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] help: consider adding a type annotation [INFO] [stdout] --> src/allocation/manager.rs:266:14 [INFO] [stdout] | [INFO] [stdout] 266 | let _ = peer_listener1 [INFO] [stdout] | ^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 45 | clippy::let_underscore_untyped, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/manager.rs:266:17 [INFO] [stdout] | [INFO] [stdout] 266 | let _ = peer_listener1 [INFO] [stdout] | _________________^ [INFO] [stdout] 267 | | .send_to(target_text.as_bytes(), relay_addr_with_host) [INFO] [stdout] 268 | | .await [INFO] [stdout] 269 | | .unwrap(); [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on an `Option` value [INFO] [stdout] --> src/allocation/manager.rs:270:20 [INFO] [stdout] | [INFO] [stdout] 270 | let data = data_ch_rx.recv().await.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is `None`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/manager.rs:272:19 [INFO] [stdout] | [INFO] [stdout] 272 | let msg = MessageDecoder::::new() [INFO] [stdout] | ___________________^ [INFO] [stdout] 273 | | .decode_from_bytes(&data) [INFO] [stdout] 274 | | .unwrap() [INFO] [stdout] 275 | | .unwrap(); [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/manager.rs:272:19 [INFO] [stdout] | [INFO] [stdout] 272 | let msg = MessageDecoder::::new() [INFO] [stdout] | ___________________^ [INFO] [stdout] 273 | | .decode_from_bytes(&data) [INFO] [stdout] 274 | | .unwrap() [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on an `Option` value [INFO] [stdout] --> src/allocation/manager.rs:276:24 [INFO] [stdout] | [INFO] [stdout] 276 | let msg_data = msg.get_attribute::().unwrap().data().to_vec(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is `None`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-binding `let` without a type annotation [INFO] [stdout] --> src/allocation/manager.rs:285:9 [INFO] [stdout] | [INFO] [stdout] 285 | / let _ = peer_listener2 [INFO] [stdout] 286 | | .send_to(target_text2.as_bytes(), relay_addr_with_host) [INFO] [stdout] 287 | | .await [INFO] [stdout] 288 | | .unwrap(); [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] help: consider adding a type annotation [INFO] [stdout] --> src/allocation/manager.rs:285:14 [INFO] [stdout] | [INFO] [stdout] 285 | let _ = peer_listener2 [INFO] [stdout] | ^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/manager.rs:285:17 [INFO] [stdout] | [INFO] [stdout] 285 | let _ = peer_listener2 [INFO] [stdout] | _________________^ [INFO] [stdout] 286 | | .send_to(target_text2.as_bytes(), relay_addr_with_host) [INFO] [stdout] 287 | | .await [INFO] [stdout] 288 | | .unwrap(); [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on an `Option` value [INFO] [stdout] --> src/allocation/manager.rs:289:20 [INFO] [stdout] | [INFO] [stdout] 289 | let data = data_ch_rx.recv().await.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is `None`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `data` shadows a previous, unrelated binding [INFO] [stdout] --> src/allocation/manager.rs:289:13 [INFO] [stdout] | [INFO] [stdout] 289 | let data = data_ch_rx.recv().await.unwrap(); [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] note: previous binding is here [INFO] [stdout] --> src/allocation/manager.rs:270:13 [INFO] [stdout] | [INFO] [stdout] 270 | let data = data_ch_rx.recv().await.unwrap(); [INFO] [stdout] | ^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#shadow_unrelated [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:88:5 [INFO] [stdout] | [INFO] [stdout] 88 | clippy::shadow_unrelated, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/manager.rs:293:28 [INFO] [stdout] | [INFO] [stdout] 293 | let channel_data = ChannelData::decode(data).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/manager.rs:310:22 [INFO] [stdout] | [INFO] [stdout] 310 | Arc::new(UdpSocket::bind("0.0.0.0:0").await.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/manager.rs:314:13 [INFO] [stdout] | [INFO] [stdout] 314 | _ = m [INFO] [stdout] | _____________^ [INFO] [stdout] 315 | | .create_allocation( [INFO] [stdout] 316 | | five_tuple, [INFO] [stdout] 317 | | DynTransport::clone(&turn_socket), [INFO] [stdout] ... | [INFO] [stdout] 323 | | .await [INFO] [stdout] 324 | | .unwrap(); [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/manager.rs:320:17 [INFO] [stdout] | [INFO] [stdout] 320 | Username::new(String::from("user")).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/manager.rs:332:17 [INFO] [stdout] | [INFO] [stdout] 332 | Username::new(String::from("user")).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/allocation/manager.rs:367:13 [INFO] [stdout] | [INFO] [stdout] 367 | !m.get_alloc(&five_tuple).is_some(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `m.get_alloc(&five_tuple).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/manager.rs:343:22 [INFO] [stdout] | [INFO] [stdout] 343 | Arc::new(UdpSocket::bind("0.0.0.0:0").await.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/manager.rs:347:13 [INFO] [stdout] | [INFO] [stdout] 347 | _ = m [INFO] [stdout] | _____________^ [INFO] [stdout] 348 | | .create_allocation( [INFO] [stdout] 349 | | five_tuple, [INFO] [stdout] 350 | | DynTransport::clone(&turn_socket), [INFO] [stdout] ... | [INFO] [stdout] 356 | | .await [INFO] [stdout] 357 | | .unwrap(); [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/manager.rs:353:17 [INFO] [stdout] | [INFO] [stdout] 353 | Username::new(String::from("user")).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/manager.rs:375:22 [INFO] [stdout] | [INFO] [stdout] 375 | Arc::new(UdpSocket::bind("0.0.0.0:0").await.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/manager.rs:383:17 [INFO] [stdout] | [INFO] [stdout] 383 | _ = m [INFO] [stdout] | _________________^ [INFO] [stdout] 384 | | .create_allocation( [INFO] [stdout] 385 | | five_tuple, [INFO] [stdout] 386 | | DynTransport::clone(&turn_socket), [INFO] [stdout] ... | [INFO] [stdout] 392 | | .await [INFO] [stdout] 393 | | .unwrap(); [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/manager.rs:389:21 [INFO] [stdout] | [INFO] [stdout] 389 | Username::new(String::from("user")).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: only a `panic!` in `if`-then statement [INFO] [stdout] --> src/allocation/manager.rs:402:13 [INFO] [stdout] | [INFO] [stdout] 402 | / if count >= 10 { [INFO] [stdout] 403 | | panic!("`Allocation`s didn't timeout"); [INFO] [stdout] 404 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_assert [INFO] [stdout] = note: `#[warn(clippy::manual_assert)]` implied by `#[warn(clippy::pedantic)]` [INFO] [stdout] help: replace `if`-then-`panic!` with `assert!` [INFO] [stdout] | [INFO] [stdout] 402 - if count >= 10 { [INFO] [stdout] 403 - panic!("`Allocation`s didn't timeout"); [INFO] [stdout] 404 - } [INFO] [stdout] 402 + assert!(count < 10, "`Allocation`s didn't timeout"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/manager.rs:425:22 [INFO] [stdout] | [INFO] [stdout] 425 | Arc::new(UdpSocket::bind("0.0.0.0:0").await.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/manager.rs:431:13 [INFO] [stdout] | [INFO] [stdout] 431 | _ = m [INFO] [stdout] | _____________^ [INFO] [stdout] 432 | | .create_allocation( [INFO] [stdout] 433 | | five_tuple1, [INFO] [stdout] 434 | | DynTransport::clone(&turn_socket), [INFO] [stdout] ... | [INFO] [stdout] 440 | | .await [INFO] [stdout] 441 | | .unwrap(); [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/manager.rs:437:17 [INFO] [stdout] | [INFO] [stdout] 437 | Username::new(String::from("user")).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/manager.rs:442:13 [INFO] [stdout] | [INFO] [stdout] 442 | _ = m [INFO] [stdout] | _____________^ [INFO] [stdout] 443 | | .create_allocation( [INFO] [stdout] 444 | | five_tuple2, [INFO] [stdout] 445 | | DynTransport::clone(&turn_socket), [INFO] [stdout] ... | [INFO] [stdout] 451 | | .await [INFO] [stdout] 452 | | .unwrap(); [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/manager.rs:448:17 [INFO] [stdout] | [INFO] [stdout] 448 | Username::new(String::from("user")).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/manager.rs:453:13 [INFO] [stdout] | [INFO] [stdout] 453 | _ = m [INFO] [stdout] | _____________^ [INFO] [stdout] 454 | | .create_allocation( [INFO] [stdout] 455 | | five_tuple3, [INFO] [stdout] 456 | | DynTransport::clone(&turn_socket), [INFO] [stdout] ... | [INFO] [stdout] 462 | | .await [INFO] [stdout] 463 | | .unwrap(); [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/manager.rs:459:17 [INFO] [stdout] | [INFO] [stdout] 459 | Username::new(String::from("user2")).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: importing trait that is only used anonymously [INFO] [stdout] --> src/allocation/mod.rs:510:14 [INFO] [stdout] | [INFO] [stdout] 510 | str::FromStr, [INFO] [stdout] | ^^^^^^^ help: use: `FromStr as _` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_trait_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary structure name repetition [INFO] [stdout] --> src/allocation/mod.rs:524:13 [INFO] [stdout] | [INFO] [stdout] 524 | FiveTuple { [INFO] [stdout] | ^^^^^^^^^ help: use the applicable keyword: `Self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:121:5 [INFO] [stdout] | [INFO] [stdout] 121 | clippy::use_self, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hand-coded well-known IP address [INFO] [stdout] --> src/allocation/mod.rs:526:43 [INFO] [stdout] | [INFO] [stdout] 526 | src_addr: SocketAddr::new(Ipv4Addr::new(0, 0, 0, 0).into(), 0), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ip_constant [INFO] [stdout] help: use [INFO] [stdout] | [INFO] [stdout] 526 - src_addr: SocketAddr::new(Ipv4Addr::new(0, 0, 0, 0).into(), 0), [INFO] [stdout] 526 + src_addr: SocketAddr::new(Ipv4Addr::UNSPECIFIED.into(), 0), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hand-coded well-known IP address [INFO] [stdout] --> src/allocation/mod.rs:527:43 [INFO] [stdout] | [INFO] [stdout] 527 | dst_addr: SocketAddr::new(Ipv4Addr::new(0, 0, 0, 0).into(), 0), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ip_constant [INFO] [stdout] help: use [INFO] [stdout] | [INFO] [stdout] 527 - dst_addr: SocketAddr::new(Ipv4Addr::new(0, 0, 0, 0).into(), 0), [INFO] [stdout] 527 + dst_addr: SocketAddr::new(Ipv4Addr::UNSPECIFIED.into(), 0), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/mod.rs:534:36 [INFO] [stdout] | [INFO] [stdout] 534 | let turn_socket = Arc::new(UdpSocket::bind("0.0.0.0:0").await.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/mod.rs:536:26 [INFO] [stdout] | [INFO] [stdout] 536 | let relay_addr = relay_socket.local_addr().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/mod.rs:543:13 [INFO] [stdout] | [INFO] [stdout] 543 | Username::new(String::from("user")).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/mod.rs:547:21 [INFO] [stdout] | [INFO] [stdout] 547 | let addr1 = SocketAddr::from_str("127.0.0.1:3478").unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/mod.rs:548:21 [INFO] [stdout] | [INFO] [stdout] 548 | let addr2 = SocketAddr::from_str("127.0.0.1:3479").unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/mod.rs:549:21 [INFO] [stdout] | [INFO] [stdout] 549 | let addr3 = SocketAddr::from_str("127.0.0.2:3478").unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/mod.rs:567:36 [INFO] [stdout] | [INFO] [stdout] 567 | let turn_socket = Arc::new(UdpSocket::bind("0.0.0.0:0").await.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/mod.rs:569:26 [INFO] [stdout] | [INFO] [stdout] 569 | let relay_addr = relay_socket.local_addr().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/mod.rs:576:13 [INFO] [stdout] | [INFO] [stdout] 576 | Username::new(String::from("user")).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/mod.rs:580:20 [INFO] [stdout] | [INFO] [stdout] 580 | let addr = SocketAddr::from_str("127.0.0.1:3478").unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/mod.rs:589:36 [INFO] [stdout] | [INFO] [stdout] 589 | let turn_socket = Arc::new(UdpSocket::bind("0.0.0.0:0").await.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/mod.rs:591:26 [INFO] [stdout] | [INFO] [stdout] 591 | let relay_addr = relay_socket.local_addr().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/mod.rs:598:13 [INFO] [stdout] | [INFO] [stdout] 598 | Username::new(String::from("user")).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/mod.rs:602:20 [INFO] [stdout] | [INFO] [stdout] 602 | let addr = SocketAddr::from_str("127.0.0.1:3478").unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/mod.rs:604:9 [INFO] [stdout] | [INFO] [stdout] 604 | / a.add_channel_bind(ChannelNumber::MIN, addr, DEFAULT_LIFETIME) [INFO] [stdout] 605 | | .await [INFO] [stdout] 606 | | .unwrap(); [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on an `Option` value [INFO] [stdout] --> src/allocation/mod.rs:609:13 [INFO] [stdout] | [INFO] [stdout] 609 | a.get_channel_addr(&ChannelNumber::MIN).await.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is `None`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/mod.rs:619:36 [INFO] [stdout] | [INFO] [stdout] 619 | let turn_socket = Arc::new(UdpSocket::bind("0.0.0.0:0").await.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/mod.rs:621:26 [INFO] [stdout] | [INFO] [stdout] 621 | let relay_addr = relay_socket.local_addr().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/mod.rs:628:13 [INFO] [stdout] | [INFO] [stdout] 628 | Username::new(String::from("user")).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/mod.rs:632:20 [INFO] [stdout] | [INFO] [stdout] 632 | let addr = SocketAddr::from_str("127.0.0.1:3478").unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/mod.rs:633:21 [INFO] [stdout] | [INFO] [stdout] 633 | let addr2 = SocketAddr::from_str("127.0.0.1:3479").unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/mod.rs:635:9 [INFO] [stdout] | [INFO] [stdout] 635 | / a.add_channel_bind(ChannelNumber::MIN, addr, DEFAULT_LIFETIME) [INFO] [stdout] 636 | | .await [INFO] [stdout] 637 | | .unwrap(); [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on an `Option` value [INFO] [stdout] --> src/allocation/mod.rs:639:36 [INFO] [stdout] | [INFO] [stdout] 639 | let exist_channel_number = a.get_channel_number(&addr).await.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is `None`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/mod.rs:648:36 [INFO] [stdout] | [INFO] [stdout] 648 | let turn_socket = Arc::new(UdpSocket::bind("0.0.0.0:0").await.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/mod.rs:650:26 [INFO] [stdout] | [INFO] [stdout] 650 | let relay_addr = relay_socket.local_addr().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/mod.rs:657:13 [INFO] [stdout] | [INFO] [stdout] 657 | Username::new(String::from("user")).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/mod.rs:661:20 [INFO] [stdout] | [INFO] [stdout] 661 | let addr = SocketAddr::from_str("127.0.0.1:3478").unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/mod.rs:662:9 [INFO] [stdout] | [INFO] [stdout] 662 | / a.add_channel_bind(ChannelNumber::MIN, addr, DEFAULT_LIFETIME) [INFO] [stdout] 663 | | .await [INFO] [stdout] 664 | | .unwrap(); [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/mod.rs:681:13 [INFO] [stdout] | [INFO] [stdout] 681 | "0.0.0.0:3478".parse::().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/mod.rs:683:13 [INFO] [stdout] | [INFO] [stdout] 683 | "0.0.0.0:3479".parse::().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/mod.rs:686:13 [INFO] [stdout] | [INFO] [stdout] 686 | "0.0.0.0:3480".parse::().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/allocation/mod.rs:688:13 [INFO] [stdout] | [INFO] [stdout] 688 | "0.0.0.0:3481".parse::().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/chandata.rs:182:13 [INFO] [stdout] | [INFO] [stdout] 182 | ChannelData::encode(&mut buf, 4, ChannelNumber::MIN + 1).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/chandata.rs:184:23 [INFO] [stdout] | [INFO] [stdout] 184 | let decoded = ChannelData::decode(buf.to_vec()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/chandata.rs:235:17 [INFO] [stdout] | [INFO] [stdout] 235 | / ChannelData::encode(a_buf.as_mut(), a.data.len(), a.number) [INFO] [stdout] 236 | | .unwrap(); [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/chandata.rs:243:17 [INFO] [stdout] | [INFO] [stdout] 243 | / ChannelData::encode(b_buf.as_mut(), b.data.len(), b.number) [INFO] [stdout] 244 | | .unwrap(); [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this could be rewritten as `let...else` [INFO] [stdout] --> src/chandata.rs:323:13 [INFO] [stdout] | [INFO] [stdout] 323 | / let b = match hex::decode(h) { [INFO] [stdout] 324 | | Ok(b) => b, [INFO] [stdout] 325 | | Err(_) => panic!("hex decode error"), [INFO] [stdout] 326 | | }; [INFO] [stdout] | |______________^ help: consider writing: `let Ok(b) = hex::decode(h) else { panic!("hex decode error") };` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_let_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Err(_)` matches all errors [INFO] [stdout] --> src/chandata.rs:325:17 [INFO] [stdout] | [INFO] [stdout] 325 | Err(_) => panic!("hex decode error"), [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: match each error separately or use the error output, or use `.expect(msg)` if the error case is unreachable [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stdout] = note: `#[warn(clippy::match_wild_err_arm)]` implied by `#[warn(clippy::pedantic)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use Option::map_or_else instead of an if let/else [INFO] [stdout] --> src/chandata.rs:323:21 [INFO] [stdout] | [INFO] [stdout] 323 | let b = match hex::decode(h) { [INFO] [stdout] | _____________________^ [INFO] [stdout] 324 | | Ok(b) => b, [INFO] [stdout] 325 | | Err(_) => panic!("hex decode error"), [INFO] [stdout] 326 | | }; [INFO] [stdout] | |_____________^ help: try: `hex::decode(h).map_or_else(|_| panic!("hex decode error"), |b| b)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_if_let_else [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:65:5 [INFO] [stdout] | [INFO] [stdout] 65 | clippy::option_if_let_else, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/chandata.rs:333:21 [INFO] [stdout] | [INFO] [stdout] 333 | let m = ChannelData::decode(packet.clone()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/chandata.rs:340:17 [INFO] [stdout] | [INFO] [stdout] 340 | std::iter::repeat(0u8).take(ChannelData::HEADER_SIZE), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(0u8, ChannelData::HEADER_SIZE)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] = note: `#[warn(clippy::manual_repeat_n)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider bringing this path into scope with the `use` keyword [INFO] [stdout] --> src/chandata.rs:340:17 [INFO] [stdout] | [INFO] [stdout] 340 | std::iter::repeat(0u8).take(ChannelData::HEADER_SIZE), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absolute_paths [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | clippy::absolute_paths, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/chandata.rs:345:17 [INFO] [stdout] | [INFO] [stdout] 345 | ChannelData::encode(&mut buf, payload_size, m.number).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/chandata.rs:347:17 [INFO] [stdout] | [INFO] [stdout] 347 | ChannelData::decode(buf[..encoded_len].to_vec()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/server/request.rs:932:24 [INFO] [stdout] | [INFO] [stdout] 932 | let lifetime = Lifetime::new(Duration::from_secs(5)).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `lifetime_duration` shadows a previous, unrelated binding [INFO] [stdout] --> src/server/request.rs:948:13 [INFO] [stdout] | [INFO] [stdout] 948 | let lifetime_duration = get_lifetime(&m); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: previous binding is here [INFO] [stdout] --> src/server/request.rs:939:13 [INFO] [stdout] | [INFO] [stdout] 939 | let lifetime_duration = get_lifetime(&m); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#shadow_unrelated [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/server/request.rs:958:24 [INFO] [stdout] | [INFO] [stdout] 958 | let lifetime = Lifetime::new(MAXIMUM_ALLOCATION_LIFETIME * 2).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: importing trait that is only used anonymously [INFO] [stdout] --> src/server/request.rs:980:14 [INFO] [stdout] | [INFO] [stdout] 980 | str::FromStr, [INFO] [stdout] | ^^^^^^^ help: use: `FromStr as _` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_trait_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/server/request.rs:1021:22 [INFO] [stdout] | [INFO] [stdout] 1021 | Arc::new(UdpSocket::bind("0.0.0.0:0").await.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/server/request.rs:1036:29 [INFO] [stdout] | [INFO] [stdout] 1036 | SocketAddr::new(IpAddr::from_str("127.0.0.1").unwrap(), 5000); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/server/request.rs:1046:13 [INFO] [stdout] | [INFO] [stdout] 1046 | _ = allocation_manager [INFO] [stdout] | _____________^ [INFO] [stdout] 1047 | | .create_allocation( [INFO] [stdout] 1048 | | five_tuple, [INFO] [stdout] 1049 | | Arc::clone(&conn), [INFO] [stdout] ... | [INFO] [stdout] 1055 | | .await [INFO] [stdout] 1056 | | .unwrap(); [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/server/request.rs:1052:17 [INFO] [stdout] | [INFO] [stdout] 1052 | Username::new(String::from("user")).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/server/request.rs:1065:25 [INFO] [stdout] | [INFO] [stdout] 1065 | m.add_attribute(Lifetime::new(Duration::default()).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/server/request.rs:1066:25 [INFO] [stdout] | [INFO] [stdout] 1066 | m.add_attribute(Nonce::new(STATIC_KEY.to_owned()).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/server/request.rs:1067:25 [INFO] [stdout] | [INFO] [stdout] 1067 | m.add_attribute(Realm::new(STATIC_KEY.to_owned()).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/server/request.rs:1068:25 [INFO] [stdout] | [INFO] [stdout] 1068 | m.add_attribute(Username::new(STATIC_KEY.to_owned()).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/server/request.rs:1069:25 [INFO] [stdout] | [INFO] [stdout] 1069 | let integrity = MessageIntegrity::new_long_term_credential( [INFO] [stdout] | _________________________^ [INFO] [stdout] 1070 | | &m, [INFO] [stdout] 1071 | | &Username::new(STATIC_KEY.to_owned()).unwrap(), [INFO] [stdout] 1072 | | &Realm::new(STATIC_KEY.to_owned()).unwrap(), [INFO] [stdout] ... | [INFO] [stdout] 1075 | | .unwrap(); [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/server/request.rs:1071:14 [INFO] [stdout] | [INFO] [stdout] 1071 | &Username::new(STATIC_KEY.to_owned()).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/server/request.rs:1072:14 [INFO] [stdout] | [INFO] [stdout] 1072 | &Realm::new(STATIC_KEY.to_owned()).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string()` called on a `&str` [INFO] [stdout] --> src/server/request.rs:1085:30 [INFO] [stdout] | [INFO] [stdout] 1085 | address: "".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `"".to_owned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#str_to_string [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:92:5 [INFO] [stdout] | [INFO] [stdout] 92 | clippy::str_to_string, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty String is being created manually [INFO] [stdout] --> src/server/request.rs:1085:30 [INFO] [stdout] | [INFO] [stdout] 1085 | address: "".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using: `String::new()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_string_new [INFO] [stdout] = note: `#[warn(clippy::manual_string_new)]` implied by `#[warn(clippy::pedantic)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/server/request.rs:1095:9 [INFO] [stdout] | [INFO] [stdout] 1095 | / handle(Request::Message(m), &conn, five_tuple, &mut turn) [INFO] [stdout] 1096 | | .await [INFO] [stdout] 1097 | | .unwrap(); [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on an `Option` value [INFO] [stdout] --> src/server/request.rs:1099:17 [INFO] [stdout] | [INFO] [stdout] 1099 | assert!(turn.unwrap().alloc.get_alloc(&five_tuple).is_none()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is `None`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/transport/mod.rs:232:24 [INFO] [stdout] | [INFO] [stdout] 232 | let udp_addr = lookup_host(true, "localhost:1234").await.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 18.14s [INFO] running `Command { std: "docker" "inspect" "4e4f18d34a3bc630d13ae20907c73ba90b455fbb32cf79130c53f16df02d25da", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4e4f18d34a3bc630d13ae20907c73ba90b455fbb32cf79130c53f16df02d25da", kill_on_drop: false }` [INFO] [stdout] 4e4f18d34a3bc630d13ae20907c73ba90b455fbb32cf79130c53f16df02d25da