[INFO] fetching crate md-to-tui 0.1.2... [INFO] linting md-to-tui-0.1.2 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate md-to-tui 0.1.2 into /workspace/builds/worker-4-tc1/source [INFO] started tweaking crates.io crate md-to-tui 0.1.2 [INFO] finished tweaking crates.io crate md-to-tui 0.1.2 [INFO] tweaked toml for crates.io crate md-to-tui 0.1.2 written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate md-to-tui 0.1.2 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 56 packages to latest compatible versions [INFO] [stderr] Adding crossterm v0.26.1 (available: v0.29.0) [INFO] [stderr] Adding ratatui v0.21.0 (available: v0.30.0) [INFO] [stderr] Adding thiserror v1.0.69 (available: v2.0.18) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded pretty_env_logger v0.5.0 [INFO] [stderr] Downloaded crossterm v0.26.1 [INFO] [stderr] Downloaded ratatui v0.21.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fe9fc58ec74a636788e8ef70c80f7daafa5174633ea478cf5c4bed3f1bb93024 [INFO] running `Command { std: "docker" "start" "-a" "fe9fc58ec74a636788e8ef70c80f7daafa5174633ea478cf5c4bed3f1bb93024", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fe9fc58ec74a636788e8ef70c80f7daafa5174633ea478cf5c4bed3f1bb93024", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fe9fc58ec74a636788e8ef70c80f7daafa5174633ea478cf5c4bed3f1bb93024", kill_on_drop: false }` [INFO] [stdout] fe9fc58ec74a636788e8ef70c80f7daafa5174633ea478cf5c4bed3f1bb93024 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6504c0560880499f829addc296ac82edb4766fa7bc5751ce11564449ec31d455 [INFO] running `Command { std: "docker" "start" "-a" "6504c0560880499f829addc296ac82edb4766fa7bc5751ce11564449ec31d455", kill_on_drop: false }` [INFO] [stderr] Compiling signal-hook v0.3.18 [INFO] [stderr] Checking aho-corasick v1.1.4 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking is-terminal v0.4.17 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Checking humantime v2.3.0 [INFO] [stderr] Checking cassowary v0.3.0 [INFO] [stderr] Checking signal-hook-mio v0.2.5 [INFO] [stderr] Checking crossterm v0.26.1 [INFO] [stderr] Checking regex-automata v0.4.14 [INFO] [stderr] Checking ratatui v0.21.0 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Checking regex v1.12.3 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking pretty_env_logger v0.5.0 [INFO] [stderr] Checking md-to-tui v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/lib.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / //// # Usage [INFO] [stdout] 2 | | //// this library implements `MarkdownParsable` for types that implement `ToString` trait. [INFO] [stdout] 3 | | //// You can use `parse_markdown` fn to parse markdown to `Text`. [INFO] [stdout] 4 | | //// `parse_markdown` takes `option` of `MdStyle` and returns `Result, Error>` [INFO] [stdout] ... | [INFO] [stdout] 17 | | //// ` [INFO] [stdout] 18 | | use error::Error; [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] = note: `#[warn(clippy::four_forward_slashes)]` on by default [INFO] [stdout] help: turn these into doc comments by removing one `/` [INFO] [stdout] | [INFO] [stdout] 1 + /// # Usage [INFO] [stdout] 2 ~ /// this library implements `MarkdownParsable` for types that implement `ToString` trait. [INFO] [stdout] 3 ~ /// You can use `parse_markdown` fn to parse markdown to `Text`. [INFO] [stdout] 4 ~ /// `parse_markdown` takes `option` of `MdStyle` and returns `Result, Error>` [INFO] [stdout] 5 ~ /// ```rust [INFO] [stdout] 6 ~ /// example [INFO] [stdout] 7 ~ /// let md = " [INFO] [stdout] 8 ~ /// # TODO [INFO] [stdout] 9 ~ /// [INFO] [stdout] 10 ~ /// - [ ] one [INFO] [stdout] 11 ~ /// - [ ] two [INFO] [stdout] 12 ~ /// [INFO] [stdout] 13 ~ /// [link](http://exp.com) [INFO] [stdout] 14 ~ /// [INFO] [stdout] 15 ~ /// " [INFO] [stdout] 16 ~ /// let res = md.parse_markdown(Some(style)) [INFO] [stdout] 17 ~ /// ` [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same postfix: `Err` [INFO] [stdout] --> src/error.rs:4:1 [INFO] [stdout] | [INFO] [stdout] 4 | / pub enum Error { [INFO] [stdout] 5 | | #[default] [INFO] [stdout] 6 | | DefErr, [INFO] [stdout] ... | [INFO] [stdout] 9 | | LexerErr(String), [INFO] [stdout] 10 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/error.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | let text: String; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `text` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 13 ~ [INFO] [stdout] 14 ~ let text: String = match self { [INFO] [stdout] 15 ~ Self::DefErr => "Deafult error".into(), [INFO] [stdout] 16 ~ Self::ParserErr(s) => format!("Parser Err {}", s), [INFO] [stdout] 17 ~ Self::LexerErr(s) => format!("Parser Err {}", s), [INFO] [stdout] 18 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/parser/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod parser; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: importing legacy numeric constants [INFO] [stdout] --> src/parser/parser.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::usize; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove this import [INFO] [stdout] = note: then `usize::` will resolve to the respective associated constant [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser/parser.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 57 | return parser; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 57 - return parser; [INFO] [stdout] 57 + parser [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/parser/parser.rs:44:21 [INFO] [stdout] | [INFO] [stdout] 44 | let style = match style { [INFO] [stdout] | _____________________^ [INFO] [stdout] 45 | | Some(style) => style, [INFO] [stdout] 46 | | None => MdStyle::default(), [INFO] [stdout] 47 | | }; [INFO] [stdout] | |_________^ help: replace it with: `style.unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parser/parser.rs:65:23 [INFO] [stdout] | [INFO] [stdout] 65 | let mut end = !(self.position >= self.input.len()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.position < self.input.len())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parser/parser.rs:71:19 [INFO] [stdout] | [INFO] [stdout] 71 | end = !(self.position >= self.input.len()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.position < self.input.len())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/parser/parser.rs:123:63 [INFO] [stdout] | [INFO] [stdout] 123 | _ => Span::from(format!("TODO: {}", self.token.to_string())), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser/parser.rs:148:13 [INFO] [stdout] | [INFO] [stdout] 148 | return Token::EOF; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 148 - return Token::EOF; [INFO] [stdout] 148 + Token::EOF [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> src/parser/parser_helpers.rs:9:29 [INFO] [stdout] | [INFO] [stdout] 9 | Span::styled("#".repeat(heading.clone()), style.heading) [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*heading` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/parser/parser_helpers.rs:21:42 [INFO] [stdout] | [INFO] [stdout] 21 | Token::Indent(i) => Span::styled(format!("{}", i) ,style.list), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `i.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: importing legacy numeric constants [INFO] [stdout] --> src/parser/lexer.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | u8, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: remove this import [INFO] [stdout] = note: then `u8::` will resolve to the respective associated constant [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `EOL` contains a capitalized acronym [INFO] [stdout] --> src/parser/lexer.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | EOL, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Eol` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `EOF` contains a capitalized acronym [INFO] [stdout] --> src/parser/lexer.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | EOF, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Eof` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `write!` args [INFO] [stdout] --> src/parser/lexer.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 79 | write!(f, "{}", format!("{}{}", text, tok)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `write!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] = note: `#[warn(clippy::format_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser/lexer.rs:104:9 [INFO] [stdout] | [INFO] [stdout] 104 | / return Lexer { [INFO] [stdout] 105 | | position: 0, [INFO] [stdout] 106 | | read_position: 0, [INFO] [stdout] 107 | | ch: 0, [INFO] [stdout] 108 | | input: "".into(), [INFO] [stdout] 109 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 104 ~ Lexer { [INFO] [stdout] 105 + position: 0, [INFO] [stdout] 106 + read_position: 0, [INFO] [stdout] 107 + ch: 0, [INFO] [stdout] 108 + input: "".into(), [INFO] [stdout] 109 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parser/lexer.rs:119:15 [INFO] [stdout] | [INFO] [stdout] 119 | while !(self.position >= self.input.len()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.position < self.input.len())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/parser/lexer.rs:153:9 [INFO] [stdout] | [INFO] [stdout] 153 | / match tk { [INFO] [stdout] 154 | | Token::Illegal(_) => return Err(Error::LexerErr(tk.to_string())), [INFO] [stdout] 155 | | _ => (), [INFO] [stdout] 156 | | } [INFO] [stdout] | |_________^ help: try: `if let Token::Illegal(_) = tk { return Err(Error::LexerErr(tk.to_string())) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser/lexer.rs:174:13 [INFO] [stdout] | [INFO] [stdout] 174 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 174 - return 0; [INFO] [stdout] 174 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser/lexer.rs:185:9 [INFO] [stdout] | [INFO] [stdout] 185 | return Token::Indent(String::from_utf8_lossy(&self.input[pos..self.position]).to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 185 - return Token::Indent(String::from_utf8_lossy(&self.input[pos..self.position]).to_string()); [INFO] [stdout] 185 + Token::Indent(String::from_utf8_lossy(&self.input[pos..self.position]).to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/style/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod style; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/lib.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / //// # Usage [INFO] [stdout] 2 | | //// this library implements `MarkdownParsable` for types that implement `ToString` trait. [INFO] [stdout] 3 | | //// You can use `parse_markdown` fn to parse markdown to `Text`. [INFO] [stdout] 4 | | //// `parse_markdown` takes `option` of `MdStyle` and returns `Result, Error>` [INFO] [stdout] ... | [INFO] [stdout] 17 | | //// ` [INFO] [stdout] 18 | | use error::Error; [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] = note: `#[warn(clippy::four_forward_slashes)]` on by default [INFO] [stdout] help: turn these into doc comments by removing one `/` [INFO] [stdout] | [INFO] [stdout] 1 + /// # Usage [INFO] [stdout] 2 ~ /// this library implements `MarkdownParsable` for types that implement `ToString` trait. [INFO] [stdout] 3 ~ /// You can use `parse_markdown` fn to parse markdown to `Text`. [INFO] [stdout] 4 ~ /// `parse_markdown` takes `option` of `MdStyle` and returns `Result, Error>` [INFO] [stdout] 5 ~ /// ```rust [INFO] [stdout] 6 ~ /// example [INFO] [stdout] 7 ~ /// let md = " [INFO] [stdout] 8 ~ /// # TODO [INFO] [stdout] 9 ~ /// [INFO] [stdout] 10 ~ /// - [ ] one [INFO] [stdout] 11 ~ /// - [ ] two [INFO] [stdout] 12 ~ /// [INFO] [stdout] 13 ~ /// [link](http://exp.com) [INFO] [stdout] 14 ~ /// [INFO] [stdout] 15 ~ /// " [INFO] [stdout] 16 ~ /// let res = md.parse_markdown(Some(style)) [INFO] [stdout] 17 ~ /// ` [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same postfix: `Err` [INFO] [stdout] --> src/error.rs:4:1 [INFO] [stdout] | [INFO] [stdout] 4 | / pub enum Error { [INFO] [stdout] 5 | | #[default] [INFO] [stdout] 6 | | DefErr, [INFO] [stdout] ... | [INFO] [stdout] 9 | | LexerErr(String), [INFO] [stdout] 10 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/error.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | let text: String; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `text` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 13 ~ [INFO] [stdout] 14 ~ let text: String = match self { [INFO] [stdout] 15 ~ Self::DefErr => "Deafult error".into(), [INFO] [stdout] 16 ~ Self::ParserErr(s) => format!("Parser Err {}", s), [INFO] [stdout] 17 ~ Self::LexerErr(s) => format!("Parser Err {}", s), [INFO] [stdout] 18 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/parser/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod parser; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: importing legacy numeric constants [INFO] [stdout] --> src/parser/parser.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::usize; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove this import [INFO] [stdout] = note: then `usize::` will resolve to the respective associated constant [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser/parser.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 57 | return parser; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 57 - return parser; [INFO] [stdout] 57 + parser [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/parser/parser.rs:44:21 [INFO] [stdout] | [INFO] [stdout] 44 | let style = match style { [INFO] [stdout] | _____________________^ [INFO] [stdout] 45 | | Some(style) => style, [INFO] [stdout] 46 | | None => MdStyle::default(), [INFO] [stdout] 47 | | }; [INFO] [stdout] | |_________^ help: replace it with: `style.unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parser/parser.rs:65:23 [INFO] [stdout] | [INFO] [stdout] 65 | let mut end = !(self.position >= self.input.len()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.position < self.input.len())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parser/parser.rs:71:19 [INFO] [stdout] | [INFO] [stdout] 71 | end = !(self.position >= self.input.len()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.position < self.input.len())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/parser/parser.rs:123:63 [INFO] [stdout] | [INFO] [stdout] 123 | _ => Span::from(format!("TODO: {}", self.token.to_string())), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser/parser.rs:148:13 [INFO] [stdout] | [INFO] [stdout] 148 | return Token::EOF; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 148 - return Token::EOF; [INFO] [stdout] 148 + Token::EOF [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/parser/parser.rs:186:26 [INFO] [stdout] | [INFO] [stdout] 186 | .map(|f| format!("{}", f.content.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `f.content.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/parser/parser.rs:186:49 [INFO] [stdout] | [INFO] [stdout] 186 | .map(|f| format!("{}", f.content.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> src/parser/parser_helpers.rs:9:29 [INFO] [stdout] | [INFO] [stdout] 9 | Span::styled("#".repeat(heading.clone()), style.heading) [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*heading` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/parser/parser_helpers.rs:21:42 [INFO] [stdout] | [INFO] [stdout] 21 | Token::Indent(i) => Span::styled(format!("{}", i) ,style.list), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `i.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: importing legacy numeric constants [INFO] [stdout] --> src/parser/lexer.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | u8, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: remove this import [INFO] [stdout] = note: then `u8::` will resolve to the respective associated constant [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `EOL` contains a capitalized acronym [INFO] [stdout] --> src/parser/lexer.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | EOL, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Eol` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `EOF` contains a capitalized acronym [INFO] [stdout] --> src/parser/lexer.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | EOF, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Eof` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `write!` args [INFO] [stdout] --> src/parser/lexer.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 79 | write!(f, "{}", format!("{}{}", text, tok)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `write!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] = note: `#[warn(clippy::format_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser/lexer.rs:104:9 [INFO] [stdout] | [INFO] [stdout] 104 | / return Lexer { [INFO] [stdout] 105 | | position: 0, [INFO] [stdout] 106 | | read_position: 0, [INFO] [stdout] 107 | | ch: 0, [INFO] [stdout] 108 | | input: "".into(), [INFO] [stdout] 109 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 104 ~ Lexer { [INFO] [stdout] 105 + position: 0, [INFO] [stdout] 106 + read_position: 0, [INFO] [stdout] 107 + ch: 0, [INFO] [stdout] 108 + input: "".into(), [INFO] [stdout] 109 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parser/lexer.rs:119:15 [INFO] [stdout] | [INFO] [stdout] 119 | while !(self.position >= self.input.len()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.position < self.input.len())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/parser/lexer.rs:153:9 [INFO] [stdout] | [INFO] [stdout] 153 | / match tk { [INFO] [stdout] 154 | | Token::Illegal(_) => return Err(Error::LexerErr(tk.to_string())), [INFO] [stdout] 155 | | _ => (), [INFO] [stdout] 156 | | } [INFO] [stdout] | |_________^ help: try: `if let Token::Illegal(_) = tk { return Err(Error::LexerErr(tk.to_string())) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser/lexer.rs:174:13 [INFO] [stdout] | [INFO] [stdout] 174 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 174 - return 0; [INFO] [stdout] 174 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser/lexer.rs:185:9 [INFO] [stdout] | [INFO] [stdout] 185 | return Token::Indent(String::from_utf8_lossy(&self.input[pos..self.position]).to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 185 - return Token::Indent(String::from_utf8_lossy(&self.input[pos..self.position]).to_string()); [INFO] [stdout] 185 + Token::Indent(String::from_utf8_lossy(&self.input[pos..self.position]).to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/style/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod style; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 10.79s [INFO] running `Command { std: "docker" "inspect" "6504c0560880499f829addc296ac82edb4766fa7bc5751ce11564449ec31d455", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6504c0560880499f829addc296ac82edb4766fa7bc5751ce11564449ec31d455", kill_on_drop: false }` [INFO] [stdout] 6504c0560880499f829addc296ac82edb4766fa7bc5751ce11564449ec31d455