[INFO] fetching crate mcwr 0.2.3... [INFO] linting mcwr-0.2.3 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate mcwr 0.2.3 into /workspace/builds/worker-5-tc1/source [INFO] started tweaking crates.io crate mcwr 0.2.3 [INFO] finished tweaking crates.io crate mcwr 0.2.3 [INFO] tweaked toml for crates.io crate mcwr 0.2.3 written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate mcwr 0.2.3 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate mcwr 0.2.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded translateutil v0.1.0 [INFO] [stderr] Downloaded xattr v1.4.0 [INFO] [stderr] Downloaded discard v1.0.4 [INFO] [stderr] Downloaded dwldutil v1.1.0 [INFO] [stderr] Downloaded stdweb-internal-runtime v0.1.5 [INFO] [stderr] Downloaded value-bag v1.10.0 [INFO] [stderr] Downloaded ghash v0.3.1 [INFO] [stderr] Downloaded aead v0.3.2 [INFO] [stderr] Downloaded stdweb-derive v0.5.3 [INFO] [stderr] Downloaded cpuid-bool v0.2.0 [INFO] [stderr] Downloaded universal-hash v0.4.0 [INFO] [stderr] Downloaded cipher v0.2.5 [INFO] [stderr] Downloaded env_logger v0.11.7 [INFO] [stderr] Downloaded spinning_top v0.2.5 [INFO] [stderr] Downloaded clap_derive v4.5.28 [INFO] [stderr] Downloaded flume v0.9.2 [INFO] [stderr] Downloaded curl v0.4.47 [INFO] [stderr] Downloaded aesni v0.10.0 [INFO] [stderr] Downloaded aes-soft v0.6.4 [INFO] [stderr] Downloaded winnow v0.7.4 [INFO] [stderr] Downloaded aes-gcm v0.8.0 [INFO] [stderr] Downloaded aes v0.6.0 [INFO] [stderr] Downloaded isahc v0.9.14 [INFO] [stderr] Downloaded stdweb v0.4.20 [INFO] [stderr] Downloaded async-std v1.13.1 [INFO] [stderr] Downloaded time v0.2.27 [INFO] [stderr] Downloaded cc v1.2.13 [INFO] [stderr] Downloaded bytes v1.10.0 [INFO] [stderr] Downloaded surf v2.3.2 [INFO] [stderr] Downloaded http-client v6.5.3 [INFO] [stderr] Downloaded standback v0.2.17 [INFO] [stderr] Downloaded ctr v0.6.0 [INFO] [stderr] Downloaded time-macros v0.1.1 [INFO] [stderr] Downloaded cookie v0.14.4 [INFO] [stderr] Downloaded polyval v0.4.5 [INFO] [stderr] Downloaded crypto-mac v0.10.0 [INFO] [stderr] Downloaded time-macros-impl v0.1.2 [INFO] [stderr] Downloaded hkdf v0.10.0 [INFO] [stderr] Downloaded const_fn v0.4.11 [INFO] [stderr] Downloaded hmac v0.10.1 [INFO] [stderr] Downloaded stdweb-internal-macros v0.2.9 [INFO] [stderr] Downloaded mclr v3.0.0 [INFO] [stderr] Downloaded bzip2-sys v0.1.12+1.0.8 [INFO] [stderr] Downloaded curl-sys v0.4.80+curl-8.12.1 [INFO] [stderr] Downloaded libnghttp2-sys v0.1.11+1.64.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 06d71cc60f9738bc4fb2f03fb8491d3812a772203785d8992b6b32a8dacfd85c [INFO] running `Command { std: "docker" "start" "-a" "06d71cc60f9738bc4fb2f03fb8491d3812a772203785d8992b6b32a8dacfd85c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "06d71cc60f9738bc4fb2f03fb8491d3812a772203785d8992b6b32a8dacfd85c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "06d71cc60f9738bc4fb2f03fb8491d3812a772203785d8992b6b32a8dacfd85c", kill_on_drop: false }` [INFO] [stdout] 06d71cc60f9738bc4fb2f03fb8491d3812a772203785d8992b6b32a8dacfd85c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 545c6be8eac959da71f8040fdd7db49e2575bc04691770349da1de048a360a50 [INFO] running `Command { std: "docker" "start" "-a" "545c6be8eac959da71f8040fdd7db49e2575bc04691770349da1de048a360a50", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.93 [INFO] [stderr] Compiling unicode-ident v1.0.16 [INFO] [stderr] Compiling libc v0.2.169 [INFO] [stderr] Checking once_cell v1.20.3 [INFO] [stderr] Compiling pkg-config v0.3.31 [INFO] [stderr] Checking value-bag v1.10.0 [INFO] [stderr] Compiling cc v1.2.13 [INFO] [stderr] Checking bitflags v2.8.0 [INFO] [stderr] Compiling serde v1.0.217 [INFO] [stderr] Compiling rustix v0.38.44 [INFO] [stderr] Checking linux-raw-sys v0.4.15 [INFO] [stderr] Checking generic-array v0.14.7 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking futures-lite v2.6.0 [INFO] [stderr] Checking writeable v0.5.5 [INFO] [stderr] Checking litemap v0.7.4 [INFO] [stderr] Checking async-task v4.7.1 [INFO] [stderr] Checking tracing-core v0.1.33 [INFO] [stderr] Checking icu_locid_transform_data v1.5.0 [INFO] [stderr] Checking event-listener v5.4.0 [INFO] [stderr] Checking piper v0.2.4 [INFO] [stderr] Compiling standback v0.2.17 [INFO] [stderr] Compiling proc-macro-hack v0.5.20+deprecated [INFO] [stderr] Checking log v0.4.26 [INFO] [stderr] Checking icu_properties_data v1.5.0 [INFO] [stderr] Compiling wasm-bindgen-shared v0.2.100 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking futures-sink v0.3.31 [INFO] [stderr] Checking write16 v1.0.0 [INFO] [stderr] Checking icu_normalizer_data v1.5.0 [INFO] [stderr] Checking event-listener-strategy v0.5.3 [INFO] [stderr] Checking utf16_iter v1.0.5 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Checking cpuid-bool v0.2.0 [INFO] [stderr] Compiling bumpalo v3.17.0 [INFO] [stderr] Compiling const_fn v0.4.11 [INFO] [stderr] Checking async-lock v3.4.0 [INFO] [stderr] Checking async-channel v2.3.1 [INFO] [stderr] Checking itoa v1.0.14 [INFO] [stderr] Checking async-channel v1.9.0 [INFO] [stderr] Compiling time v0.2.27 [INFO] [stderr] Compiling cookie v0.14.4 [INFO] [stderr] Compiling quote v1.0.38 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking getrandom v0.1.16 [INFO] [stderr] Compiling anyhow v1.0.97 [INFO] [stderr] Checking cipher v0.2.5 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking blocking v1.6.1 [INFO] [stderr] Compiling syn v2.0.98 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking universal-hash v0.4.0 [INFO] [stderr] Checking aes-soft v0.6.4 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking async-executor v1.13.1 [INFO] [stderr] Checking crypto-mac v0.10.0 [INFO] [stderr] Checking polyval v0.4.5 [INFO] [stderr] Checking ctr v0.6.0 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking aes v0.6.0 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Checking hmac v0.10.1 [INFO] [stderr] Checking aead v0.3.2 [INFO] [stderr] Checking ghash v0.3.1 [INFO] [stderr] Compiling serde_json v1.0.138 [INFO] [stderr] Checking ryu v1.0.19 [INFO] [stderr] Checking regex-syntax v0.8.5 [INFO] [stderr] Checking waker-fn v1.2.0 [INFO] [stderr] Compiling wasm-bindgen v0.2.100 [INFO] [stderr] Compiling curl v0.4.47 [INFO] [stderr] Checking fastrand v1.9.0 [INFO] [stderr] Checking aes-gcm v0.8.0 [INFO] [stderr] Checking sha2 v0.9.9 [INFO] [stderr] Checking hkdf v0.10.0 [INFO] [stderr] Checking anstyle-parse v0.2.6 [INFO] [stderr] Checking spinning_top v0.2.5 [INFO] [stderr] Checking socket2 v0.5.8 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Checking kv-log-macro v1.0.7 [INFO] [stderr] Checking colorchoice v1.0.3 [INFO] [stderr] Compiling unicase v2.8.1 [INFO] [stderr] Compiling http-types v2.12.0 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking futures-lite v1.13.0 [INFO] [stderr] Checking anstyle v1.0.10 [INFO] [stderr] Checking bytes v1.10.0 [INFO] [stderr] Checking anstyle-query v1.1.2 [INFO] [stderr] Compiling isahc v0.9.14 [INFO] [stderr] Compiling mime_guess v2.0.5 [INFO] [stderr] Checking flume v0.9.2 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking anstream v0.6.18 [INFO] [stderr] Checking sluice v0.5.5 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking infer v0.2.3 [INFO] [stderr] Compiling portable-atomic v1.11.0 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Checking unicode-width v0.2.0 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Compiling getrandom v0.3.2 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking miniz_oxide v0.8.8 [INFO] [stderr] Compiling hashbrown v0.15.2 [INFO] [stderr] Compiling rustix v1.0.3 [INFO] [stderr] Checking async-fs v2.1.2 [INFO] [stderr] Compiling libnghttp2-sys v0.1.11+1.64.0 [INFO] [stderr] Compiling libz-sys v1.1.22 [INFO] [stderr] Compiling openssl-sys v0.9.106 [INFO] [stderr] Compiling curl-sys v0.4.80+curl-8.12.1 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Compiling bzip2-sys v0.1.12+1.0.8 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Checking console v0.15.11 [INFO] [stderr] Checking time v0.1.45 [INFO] [stderr] Checking filetime v0.2.25 [INFO] [stderr] Checking flate2 v1.1.1 [INFO] [stderr] Compiling indexmap v2.8.0 [INFO] [stderr] Checking encoding_rs v0.8.35 [INFO] [stderr] Checking linux-raw-sys v0.9.3 [INFO] [stderr] Compiling winnow v0.7.4 [INFO] [stderr] Checking jiff v0.2.5 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking is-terminal v0.4.16 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking clap_lex v0.7.4 [INFO] [stderr] Checking indicatif v0.17.11 [INFO] [stderr] Checking clap_builder v4.5.27 [INFO] [stderr] Checking shell-words v1.1.0 [INFO] [stderr] Checking fuzzy-matcher v0.3.7 [INFO] [stderr] Checking bzip2 v0.4.4 [INFO] [stderr] Compiling time-macros-impl v0.1.2 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Checking time-macros v0.1.1 [INFO] [stderr] Checking env_filter v0.1.3 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Checking tempfile v3.19.1 [INFO] [stderr] Checking xattr v1.4.0 [INFO] [stderr] Checking tar v0.4.44 [INFO] [stderr] Compiling synstructure v0.13.1 [INFO] [stderr] Compiling wasm-bindgen-backend v0.2.100 [INFO] [stderr] Checking env_logger v0.11.7 [INFO] [stderr] Compiling zerofrom-derive v0.1.5 [INFO] [stderr] Compiling yoke-derive v0.7.5 [INFO] [stderr] Compiling zerovec-derive v0.10.3 [INFO] [stderr] Compiling serde_derive v1.0.217 [INFO] [stderr] Compiling tracing-attributes v0.1.28 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling icu_provider_macros v1.5.0 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling pin-project-internal v1.1.10 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling async-trait v0.1.88 [INFO] [stderr] Compiling clap_derive v4.5.28 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Compiling wasm-bindgen-macro-support v0.2.100 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking zip v0.5.13 [INFO] [stderr] Checking dialoguer v0.11.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking zerofrom v0.1.5 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking yoke v0.7.5 [INFO] [stderr] Checking pin-project v1.1.10 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking zerovec v0.10.4 [INFO] [stderr] Checking polling v3.7.4 [INFO] [stderr] Checking tracing-futures v0.2.5 [INFO] [stderr] Checking async-io v2.4.0 [INFO] [stderr] Checking clap v4.5.28 [INFO] [stderr] Checking async-global-executor v2.4.1 [INFO] [stderr] Checking async-signal v0.2.10 [INFO] [stderr] Checking async-net v2.0.0 [INFO] [stderr] Checking async-std v1.13.1 [INFO] [stderr] Compiling wasm-bindgen-macro v0.2.100 [INFO] [stderr] Checking async-process v2.3.0 [INFO] [stderr] Checking tinystr v0.7.6 [INFO] [stderr] Checking icu_collections v1.5.0 [INFO] [stderr] Checking icu_locid v1.5.0 [INFO] [stderr] Checking smol v2.0.2 [INFO] [stderr] Checking icu_provider v1.5.0 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking icu_locid_transform v1.5.0 [INFO] [stderr] Checking js-sys v0.3.77 [INFO] [stderr] Checking icu_properties v1.5.1 [INFO] [stderr] Checking icu_normalizer v1.5.0 [INFO] [stderr] Checking serde_qs v0.8.5 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking idna_adapter v1.2.0 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Checking web-sys v0.3.77 [INFO] [stderr] Compiling serde_spanned v0.6.8 [INFO] [stderr] Compiling toml_datetime v0.6.8 [INFO] [stderr] Compiling toml_edit v0.22.24 [INFO] [stderr] Checking http-client v6.5.3 [INFO] [stderr] Checking surf v2.3.2 [INFO] [stderr] Checking dwldutil v1.1.0 [INFO] [stderr] Checking mclr v3.0.0 [INFO] [stderr] Compiling toml v0.8.20 [INFO] [stderr] Compiling translateutil v0.1.0 [INFO] [stderr] Checking mcwr v0.2.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition value: `modpack` [INFO] [stdout] --> src/main.rs:9:7 [INFO] [stdout] | [INFO] [stdout] 9 | #[cfg(feature = "modpack")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `console`, `default`, `dialoguer`, `en`, `es`, `export`, `indicatif`, `interactive`, and `translateutil` [INFO] [stdout] = help: consider adding `modpack` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fmt::format` [INFO] [stdout] --> src/cline.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use std::fmt::format; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `modpack` [INFO] [stdout] --> src/main.rs:9:7 [INFO] [stdout] | [INFO] [stdout] 9 | #[cfg(feature = "modpack")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `console`, `default`, `dialoguer`, `en`, `es`, `export`, `indicatif`, `interactive`, and `translateutil` [INFO] [stdout] = help: consider adding `modpack` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fmt::format` [INFO] [stdout] --> src/cline.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use std::fmt::format; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `run` [INFO] [stdout] --> src/cline.rs:71:13 [INFO] [stdout] | [INFO] [stdout] 71 | run, [INFO] [stdout] | ^^^ help: try ignoring the field: `run: _` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `silent` [INFO] [stdout] --> src/cline.rs:72:13 [INFO] [stdout] | [INFO] [stdout] 72 | silent, [INFO] [stdout] | ^^^^^^ help: try ignoring the field: `silent: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `run` [INFO] [stdout] --> src/cline.rs:71:13 [INFO] [stdout] | [INFO] [stdout] 71 | run, [INFO] [stdout] | ^^^ help: try ignoring the field: `run: _` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `silent` [INFO] [stdout] --> src/cline.rs:72:13 [INFO] [stdout] | [INFO] [stdout] 72 | silent, [INFO] [stdout] | ^^^^^^ help: try ignoring the field: `silent: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `term` [INFO] [stdout] --> src/interactive.rs:93:19 [INFO] [stdout] | [INFO] [stdout] 93 | fn configurations(term: &Term) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_term` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `term` [INFO] [stdout] --> src/interactive.rs:192:19 [INFO] [stdout] | [INFO] [stdout] 192 | fn select_version(term: &Term) -> String { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_term` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `term` [INFO] [stdout] --> src/interactive.rs:93:19 [INFO] [stdout] | [INFO] [stdout] 93 | fn configurations(term: &Term) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_term` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/mvers.rs:304:13 [INFO] [stdout] | [INFO] [stdout] 304 | let mut binding = std::process::Command::new(self.java_home.as_str()); [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get_map` is never used [INFO] [stdout] --> src/config.rs:346:12 [INFO] [stdout] | [INFO] [stdout] 53 | impl Types { [INFO] [stdout] | ---------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 346 | pub fn get_map(&self) -> HashMap { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `term` [INFO] [stdout] --> src/interactive.rs:192:19 [INFO] [stdout] | [INFO] [stdout] 192 | fn select_version(term: &Term) -> String { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_term` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `WORLD` and `SERVER` are never constructed [INFO] [stdout] --> src/mvers.rs:243:5 [INFO] [stdout] | [INFO] [stdout] 242 | pub enum RunType { [INFO] [stdout] | ------- variants in this enum [INFO] [stdout] 243 | WORLD(String), [INFO] [stdout] | ^^^^^ [INFO] [stdout] 244 | SERVER(String), [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `ram`, `event`, and `err_event` are never read [INFO] [stdout] --> src/mvers.rs:255:9 [INFO] [stdout] | [INFO] [stdout] 248 | pub struct Command { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 255 | pub ram: CommandRamConfig, [INFO] [stdout] | ^^^ [INFO] [stdout] 256 | pub event: fn(String), [INFO] [stdout] | ^^^^^ [INFO] [stdout] 257 | pub err_event: fn(String), [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `bin` and `logger` are never read [INFO] [stdout] --> src/mvers.rs:264:9 [INFO] [stdout] | [INFO] [stdout] 261 | pub struct CommandResourcesConfig { [INFO] [stdout] | ---------------------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 264 | pub bin: String, [INFO] [stdout] | ^^^ [INFO] [stdout] 265 | pub logger: String, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `xmx` and `xms` are never read [INFO] [stdout] --> src/mvers.rs:268:9 [INFO] [stdout] | [INFO] [stdout] 267 | pub struct CommandRamConfig { [INFO] [stdout] | ---------------- fields in this struct [INFO] [stdout] 268 | pub xmx: i32, [INFO] [stdout] | ^^^ [INFO] [stdout] 269 | pub xms: i32, [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/mvers.rs:304:13 [INFO] [stdout] | [INFO] [stdout] 304 | let mut binding = std::process::Command::new(self.java_home.as_str()); [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get_map` is never used [INFO] [stdout] --> src/config.rs:346:12 [INFO] [stdout] | [INFO] [stdout] 53 | impl Types { [INFO] [stdout] | ---------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 346 | pub fn get_map(&self) -> HashMap { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `WORLD` and `SERVER` are never constructed [INFO] [stdout] --> src/mvers.rs:243:5 [INFO] [stdout] | [INFO] [stdout] 242 | pub enum RunType { [INFO] [stdout] | ------- variants in this enum [INFO] [stdout] 243 | WORLD(String), [INFO] [stdout] | ^^^^^ [INFO] [stdout] 244 | SERVER(String), [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `ram`, `event`, and `err_event` are never read [INFO] [stdout] --> src/mvers.rs:255:9 [INFO] [stdout] | [INFO] [stdout] 248 | pub struct Command { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 255 | pub ram: CommandRamConfig, [INFO] [stdout] | ^^^ [INFO] [stdout] 256 | pub event: fn(String), [INFO] [stdout] | ^^^^^ [INFO] [stdout] 257 | pub err_event: fn(String), [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `bin` and `logger` are never read [INFO] [stdout] --> src/mvers.rs:264:9 [INFO] [stdout] | [INFO] [stdout] 261 | pub struct CommandResourcesConfig { [INFO] [stdout] | ---------------------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 264 | pub bin: String, [INFO] [stdout] | ^^^ [INFO] [stdout] 265 | pub logger: String, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `xmx` and `xms` are never read [INFO] [stdout] --> src/mvers.rs:268:9 [INFO] [stdout] | [INFO] [stdout] 267 | pub struct CommandRamConfig { [INFO] [stdout] | ---------------- fields in this struct [INFO] [stdout] 268 | pub xmx: i32, [INFO] [stdout] | ^^^ [INFO] [stdout] 269 | pub xms: i32, [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/cline.rs:102:21 [INFO] [stdout] | [INFO] [stdout] 102 | format!("{}", k) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `k.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/cline.rs:113:13 [INFO] [stdout] | [INFO] [stdout] 113 | / if !confirm { [INFO] [stdout] 114 | | if !confirmation(format!("¿Quieres eliminar la version {}?", version).as_str()) { [INFO] [stdout] 115 | | exit(0); [INFO] [stdout] 116 | | } [INFO] [stdout] 117 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 113 ~ if !confirm [INFO] [stdout] 114 ~ && !confirmation(format!("¿Quieres eliminar la version {}?", version).as_str()) { [INFO] [stdout] 115 | exit(0); [INFO] [stdout] 116 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/cline.rs:182:5 [INFO] [stdout] | [INFO] [stdout] 182 | / if input == "s" || input == "si" { [INFO] [stdout] 183 | | true [INFO] [stdout] 184 | | } else { [INFO] [stdout] 185 | | false [INFO] [stdout] 186 | | } [INFO] [stdout] | |_____^ help: you can reduce it to: `input == "s" || input == "si"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:75:13 [INFO] [stdout] | [INFO] [stdout] 75 | return Self::into_string(text); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 75 - return Self::into_string(text); [INFO] [stdout] 75 + Self::into_string(text) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:77:13 [INFO] [stdout] | [INFO] [stdout] 77 | return Self::into_number(text); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 77 - return Self::into_number(text); [INFO] [stdout] 77 + Self::into_number(text) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:79:13 [INFO] [stdout] | [INFO] [stdout] 79 | return Self::into_vec(text); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 79 - return Self::into_vec(text); [INFO] [stdout] 79 + Self::into_vec(text) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:81:13 [INFO] [stdout] | [INFO] [stdout] 81 | return Self::into_map(text); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 81 - return Self::into_map(text); [INFO] [stdout] 81 + Self::into_map(text) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:83:13 [INFO] [stdout] | [INFO] [stdout] 83 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 83 - return None; [INFO] [stdout] 83 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/config.rs:86:30 [INFO] [stdout] | [INFO] [stdout] 86 | pub fn is_string(string: &String) -> bool { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 86 - pub fn is_string(string: &String) -> bool { [INFO] [stdout] 86 + pub fn is_string(string: &str) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/config.rs:90:27 [INFO] [stdout] | [INFO] [stdout] 90 | pub fn is_vec(string: &String) -> bool { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 90 - pub fn is_vec(string: &String) -> bool { [INFO] [stdout] 90 + pub fn is_vec(string: &str) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/config.rs:94:27 [INFO] [stdout] | [INFO] [stdout] 94 | pub fn is_map(string: &String) -> bool { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 94 - pub fn is_map(string: &String) -> bool { [INFO] [stdout] 94 + pub fn is_map(string: &str) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/config.rs:98:27 [INFO] [stdout] | [INFO] [stdout] 98 | pub fn is_num(string: &String) -> bool { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 98 - pub fn is_num(string: &String) -> bool { [INFO] [stdout] 98 + pub fn is_num(string: &str) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/config.rs:173:28 [INFO] [stdout] | [INFO] [stdout] 173 | if !(i < chars.len()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `(i >= chars.len())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/config.rs:254:28 [INFO] [stdout] | [INFO] [stdout] 254 | if !(i < chars.len()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `(i >= chars.len())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/cline.rs:102:21 [INFO] [stdout] | [INFO] [stdout] 102 | format!("{}", k) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `k.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/cline.rs:113:13 [INFO] [stdout] | [INFO] [stdout] 113 | / if !confirm { [INFO] [stdout] 114 | | if !confirmation(format!("¿Quieres eliminar la version {}?", version).as_str()) { [INFO] [stdout] 115 | | exit(0); [INFO] [stdout] 116 | | } [INFO] [stdout] 117 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 113 ~ if !confirm [INFO] [stdout] 114 ~ && !confirmation(format!("¿Quieres eliminar la version {}?", version).as_str()) { [INFO] [stdout] 115 | exit(0); [INFO] [stdout] 116 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f32` which implements the `Copy` trait [INFO] [stdout] --> src/config.rs:336:38 [INFO] [stdout] | [INFO] [stdout] 336 | Types::Number(number) => number.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*number` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/cline.rs:182:5 [INFO] [stdout] | [INFO] [stdout] 182 | / if input == "s" || input == "si" { [INFO] [stdout] 183 | | true [INFO] [stdout] 184 | | } else { [INFO] [stdout] 185 | | false [INFO] [stdout] 186 | | } [INFO] [stdout] | |_____^ help: you can reduce it to: `input == "s" || input == "si"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: iterating on a map's keys [INFO] [stdout] --> src/interactive.rs:100:38 [INFO] [stdout] | [INFO] [stdout] 100 | let rendereable_config = config.iter().map(|(key, _)| format!("{}", key)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `config.keys().map(|key| format!("{}", key))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] = note: `#[warn(clippy::iter_kv_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/interactive.rs:100:67 [INFO] [stdout] | [INFO] [stdout] 100 | let rendereable_config = config.iter().map(|(key, _)| format!("{}", key)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `key.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: iterating on a map's keys [INFO] [stdout] --> src/interactive.rs:117:38 [INFO] [stdout] | [INFO] [stdout] 117 | let rendereable_config = config.iter().map(|(key, _)| format!("{}", key)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `config.keys().map(|key| format!("{}", key))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/interactive.rs:117:67 [INFO] [stdout] | [INFO] [stdout] 117 | let rendereable_config = config.iter().map(|(key, _)| format!("{}", key)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `key.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:75:13 [INFO] [stdout] | [INFO] [stdout] 75 | return Self::into_string(text); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 75 - return Self::into_string(text); [INFO] [stdout] 75 + Self::into_string(text) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:77:13 [INFO] [stdout] | [INFO] [stdout] 77 | return Self::into_number(text); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 77 - return Self::into_number(text); [INFO] [stdout] 77 + Self::into_number(text) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:79:13 [INFO] [stdout] | [INFO] [stdout] 79 | return Self::into_vec(text); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 79 - return Self::into_vec(text); [INFO] [stdout] 79 + Self::into_vec(text) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:81:13 [INFO] [stdout] | [INFO] [stdout] 81 | return Self::into_map(text); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 81 - return Self::into_map(text); [INFO] [stdout] 81 + Self::into_map(text) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:83:13 [INFO] [stdout] | [INFO] [stdout] 83 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 83 - return None; [INFO] [stdout] 83 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/interactive.rs:147:37 [INFO] [stdout] | [INFO] [stdout] 147 | let version_id = select_version(&term); [INFO] [stdout] | ^^^^^ help: change this to: `term` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/config.rs:86:30 [INFO] [stdout] | [INFO] [stdout] 86 | pub fn is_string(string: &String) -> bool { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 86 - pub fn is_string(string: &String) -> bool { [INFO] [stdout] 86 + pub fn is_string(string: &str) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/config.rs:90:27 [INFO] [stdout] | [INFO] [stdout] 90 | pub fn is_vec(string: &String) -> bool { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 90 - pub fn is_vec(string: &String) -> bool { [INFO] [stdout] 90 + pub fn is_vec(string: &str) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/config.rs:94:27 [INFO] [stdout] | [INFO] [stdout] 94 | pub fn is_map(string: &String) -> bool { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 94 - pub fn is_map(string: &String) -> bool { [INFO] [stdout] 94 + pub fn is_map(string: &str) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/config.rs:98:27 [INFO] [stdout] | [INFO] [stdout] 98 | pub fn is_num(string: &String) -> bool { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 98 - pub fn is_num(string: &String) -> bool { [INFO] [stdout] 98 + pub fn is_num(string: &str) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/config.rs:173:28 [INFO] [stdout] | [INFO] [stdout] 173 | if !(i < chars.len()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `(i >= chars.len())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/config.rs:254:28 [INFO] [stdout] | [INFO] [stdout] 254 | if !(i < chars.len()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `(i >= chars.len())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> src/mconf.rs:13:11 [INFO] [stdout] | [INFO] [stdout] 13 | match config().get(key).map(|s| s.clone()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `config().get(key).cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> src/mconf.rs:19:11 [INFO] [stdout] | [INFO] [stdout] 19 | match config().get(key).map(|s| s.clone()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `config().get(key).cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: importing legacy numeric constants [INFO] [stdout] --> src/mvers.rs:13:15 [INFO] [stdout] | [INFO] [stdout] 13 | use std::{fs, i32}; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove this import [INFO] [stdout] = note: then `i32::` will resolve to the respective associated constant [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow [INFO] [stdout] --> src/mvers.rs:49:31 [INFO] [stdout] | [INFO] [stdout] 49 | assets_index: (&self.assets).clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `self.assets` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f32` which implements the `Copy` trait [INFO] [stdout] --> src/config.rs:336:38 [INFO] [stdout] | [INFO] [stdout] 336 | Types::Number(number) => number.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*number` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/mvers.rs:121:17 [INFO] [stdout] | [INFO] [stdout] 121 | create_meta(&meta_file, meta); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `meta_file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/mvers.rs:147:13 [INFO] [stdout] | [INFO] [stdout] 147 | &mconf::get("assets").get_string().as_str(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `mconf::get("assets").get_string().as_str()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/mvers.rs:179:29 [INFO] [stdout] | [INFO] [stdout] 179 | fn read_dir_to_version(dir: &PathBuf) -> (String, Version) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 179 - fn read_dir_to_version(dir: &PathBuf) -> (String, Version) { [INFO] [stdout] 179 + fn read_dir_to_version(dir: &Path) -> (String, Version) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mvers.rs:207:9 [INFO] [stdout] | [INFO] [stdout] 207 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 207 - return None; [INFO] [stdout] 207 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(&version).is_none()` [INFO] [stdout] --> src/mvers.rs:206:15 [INFO] [stdout] | [INFO] [stdout] 206 | if list().get(&version).is_none() { [INFO] [stdout] | -------^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: replace it with: `!list().contains_key(&version)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] = note: `#[warn(clippy::unnecessary_get_then_check)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `WORLD` contains a capitalized acronym [INFO] [stdout] --> src/mvers.rs:243:5 [INFO] [stdout] | [INFO] [stdout] 243 | WORLD(String), [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `World` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: iterating on a map's keys [INFO] [stdout] --> src/interactive.rs:100:38 [INFO] [stdout] | [INFO] [stdout] 100 | let rendereable_config = config.iter().map(|(key, _)| format!("{}", key)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `config.keys().map(|key| format!("{}", key))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] = note: `#[warn(clippy::iter_kv_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SERVER` contains a capitalized acronym [INFO] [stdout] --> src/mvers.rs:244:5 [INFO] [stdout] | [INFO] [stdout] 244 | SERVER(String), [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Server` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NORMAL` contains a capitalized acronym [INFO] [stdout] --> src/mvers.rs:245:5 [INFO] [stdout] | [INFO] [stdout] 245 | NORMAL, [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Normal` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/interactive.rs:100:67 [INFO] [stdout] | [INFO] [stdout] 100 | let rendereable_config = config.iter().map(|(key, _)| format!("{}", key)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `key.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/mvers.rs:292:9 [INFO] [stdout] | [INFO] [stdout] 292 | / match OperatingSystem::detect() { [INFO] [stdout] 293 | | OperatingSystem::Linux => { [INFO] [stdout] 294 | | let chmod = std::process::Command::new("/bin/chmod") [INFO] [stdout] 295 | | .arg("+x") [INFO] [stdout] ... | [INFO] [stdout] 301 | | _ => {} [INFO] [stdout] 302 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 292 ~ if let OperatingSystem::Linux = OperatingSystem::detect() { [INFO] [stdout] 293 + let chmod = std::process::Command::new("/bin/chmod") [INFO] [stdout] 294 + .arg("+x") [INFO] [stdout] 295 + .arg(self.java_home.clone().as_str()) [INFO] [stdout] 296 + .spawn(); [INFO] [stdout] 297 + [INFO] [stdout] 298 + chmod.unwrap().wait().unwrap(); [INFO] [stdout] 299 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: iterating on a map's keys [INFO] [stdout] --> src/interactive.rs:117:38 [INFO] [stdout] | [INFO] [stdout] 117 | let rendereable_config = config.iter().map(|(key, _)| format!("{}", key)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `config.keys().map(|key| format!("{}", key))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/interactive.rs:117:67 [INFO] [stdout] | [INFO] [stdout] 117 | let rendereable_config = config.iter().map(|(key, _)| format!("{}", key)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `key.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/interactive.rs:147:37 [INFO] [stdout] | [INFO] [stdout] 147 | let version_id = select_version(&term); [INFO] [stdout] | ^^^^^ help: change this to: `term` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> src/mconf.rs:13:11 [INFO] [stdout] | [INFO] [stdout] 13 | match config().get(key).map(|s| s.clone()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `config().get(key).cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> src/mconf.rs:19:11 [INFO] [stdout] | [INFO] [stdout] 19 | match config().get(key).map(|s| s.clone()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `config().get(key).cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: importing legacy numeric constants [INFO] [stdout] --> src/mvers.rs:13:15 [INFO] [stdout] | [INFO] [stdout] 13 | use std::{fs, i32}; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove this import [INFO] [stdout] = note: then `i32::` will resolve to the respective associated constant [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow [INFO] [stdout] --> src/mvers.rs:49:31 [INFO] [stdout] | [INFO] [stdout] 49 | assets_index: (&self.assets).clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `self.assets` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/mvers.rs:121:17 [INFO] [stdout] | [INFO] [stdout] 121 | create_meta(&meta_file, meta); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `meta_file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/mvers.rs:147:13 [INFO] [stdout] | [INFO] [stdout] 147 | &mconf::get("assets").get_string().as_str(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `mconf::get("assets").get_string().as_str()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/mvers.rs:179:29 [INFO] [stdout] | [INFO] [stdout] 179 | fn read_dir_to_version(dir: &PathBuf) -> (String, Version) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 179 - fn read_dir_to_version(dir: &PathBuf) -> (String, Version) { [INFO] [stdout] 179 + fn read_dir_to_version(dir: &Path) -> (String, Version) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mvers.rs:207:9 [INFO] [stdout] | [INFO] [stdout] 207 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 207 - return None; [INFO] [stdout] 207 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(&version).is_none()` [INFO] [stdout] --> src/mvers.rs:206:15 [INFO] [stdout] | [INFO] [stdout] 206 | if list().get(&version).is_none() { [INFO] [stdout] | -------^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: replace it with: `!list().contains_key(&version)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] = note: `#[warn(clippy::unnecessary_get_then_check)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `WORLD` contains a capitalized acronym [INFO] [stdout] --> src/mvers.rs:243:5 [INFO] [stdout] | [INFO] [stdout] 243 | WORLD(String), [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `World` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SERVER` contains a capitalized acronym [INFO] [stdout] --> src/mvers.rs:244:5 [INFO] [stdout] | [INFO] [stdout] 244 | SERVER(String), [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Server` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NORMAL` contains a capitalized acronym [INFO] [stdout] --> src/mvers.rs:245:5 [INFO] [stdout] | [INFO] [stdout] 245 | NORMAL, [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Normal` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/mvers.rs:292:9 [INFO] [stdout] | [INFO] [stdout] 292 | / match OperatingSystem::detect() { [INFO] [stdout] 293 | | OperatingSystem::Linux => { [INFO] [stdout] 294 | | let chmod = std::process::Command::new("/bin/chmod") [INFO] [stdout] 295 | | .arg("+x") [INFO] [stdout] ... | [INFO] [stdout] 301 | | _ => {} [INFO] [stdout] 302 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 292 ~ if let OperatingSystem::Linux = OperatingSystem::detect() { [INFO] [stdout] 293 + let chmod = std::process::Command::new("/bin/chmod") [INFO] [stdout] 294 + .arg("+x") [INFO] [stdout] 295 + .arg(self.java_home.clone().as_str()) [INFO] [stdout] 296 + .spawn(); [INFO] [stdout] 297 + [INFO] [stdout] 298 + chmod.unwrap().wait().unwrap(); [INFO] [stdout] 299 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/tests.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 34 | assert_eq!(Types::is_string(&string), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 34 - assert_eq!(Types::is_string(&string), true); [INFO] [stdout] 34 + assert!(Types::is_string(&string)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/tests.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 43 | assert_eq!(Types::is_vec(&vec), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 43 - assert_eq!(Types::is_vec(&vec), true); [INFO] [stdout] 43 + assert!(Types::is_vec(&vec)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 44.75s [INFO] running `Command { std: "docker" "inspect" "545c6be8eac959da71f8040fdd7db49e2575bc04691770349da1de048a360a50", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "545c6be8eac959da71f8040fdd7db49e2575bc04691770349da1de048a360a50", kill_on_drop: false }` [INFO] [stdout] 545c6be8eac959da71f8040fdd7db49e2575bc04691770349da1de048a360a50