[INFO] fetching crate mcp25625 0.1.0... [INFO] linting mcp25625-0.1.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate mcp25625 0.1.0 into /workspace/builds/worker-7-tc1/source [INFO] started tweaking crates.io crate mcp25625 0.1.0 [INFO] finished tweaking crates.io crate mcp25625 0.1.0 [INFO] tweaked toml for crates.io crate mcp25625 0.1.0 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate mcp25625 0.1.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 30 packages to latest compatible versions [INFO] [stderr] Adding cortex-m v0.6.7 (available: v0.7.7) [INFO] [stderr] Adding embedded-hal v0.2.7 (available: v1.0.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded hash32 v0.1.1 [INFO] [stderr] Downloaded as-slice v0.1.5 [INFO] [stderr] Downloaded generic-array v0.13.3 [INFO] [stderr] Downloaded vhrdcan v0.1.0 [INFO] [stderr] Downloaded cortex-m v0.6.7 [INFO] [stderr] Downloaded aligned v0.3.5 [INFO] [stderr] Downloaded hash32-derive v0.1.1 [INFO] [stderr] Downloaded heapless v0.5.6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fefe2790730a2bc80a965cb81919d0f4b65ee21470a85563f94d5e4b3e9a59fd [INFO] running `Command { std: "docker" "start" "-a" "fefe2790730a2bc80a965cb81919d0f4b65ee21470a85563f94d5e4b3e9a59fd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fefe2790730a2bc80a965cb81919d0f4b65ee21470a85563f94d5e4b3e9a59fd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fefe2790730a2bc80a965cb81919d0f4b65ee21470a85563f94d5e4b3e9a59fd", kill_on_drop: false }` [INFO] [stdout] fefe2790730a2bc80a965cb81919d0f4b65ee21470a85563f94d5e4b3e9a59fd [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c3a2ba7ec404a9ab4f2c24ce37c407c7830577f4d7c37a93c0400fae3dae68bf [INFO] running `Command { std: "docker" "start" "-a" "c3a2ba7ec404a9ab4f2c24ce37c407c7830577f4d7c37a93c0400fae3dae68bf", kill_on_drop: false }` [INFO] [stderr] Compiling cortex-m v0.7.7 [INFO] [stderr] Checking vcell v0.1.3 [INFO] [stderr] Compiling heapless v0.5.6 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Compiling cortex-m v0.6.7 [INFO] [stderr] Checking bitfield v0.13.2 [INFO] [stderr] Compiling generic-array v0.14.9 [INFO] [stderr] Checking nb v0.1.3 [INFO] [stderr] Checking hash32 v0.1.1 [INFO] [stderr] Checking generic-array v0.12.4 [INFO] [stderr] Checking generic-array v0.13.3 [INFO] [stderr] Compiling bare-metal v0.2.5 [INFO] [stderr] Compiling hash32-derive v0.1.1 [INFO] [stderr] Checking volatile-register v0.2.2 [INFO] [stderr] Checking embedded-hal v0.2.7 [INFO] [stderr] Checking as-slice v0.1.5 [INFO] [stderr] Checking aligned v0.3.5 [INFO] [stderr] Checking vhrdcan v0.1.0 [INFO] [stderr] Checking mcp25625 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/lib.rs:307:1 [INFO] [stdout] | [INFO] [stdout] 307 | / /// [INFO] [stdout] 308 | | [INFO] [stdout] | |_^ [INFO] [stdout] 309 | impl BfpctrlR { [INFO] [stdout] | - the comment documents this implementation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/lib.rs:535:13 [INFO] [stdout] | [INFO] [stdout] 535 | fn bits(self: &Self) -> u8; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] = note: `#[warn(clippy::needless_arbitrary_self_type)]` on by default [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 535 - fn bits(self: &Self) -> u8; [INFO] [stdout] 535 + fn bits(&self) -> u8; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/lib.rs:307:1 [INFO] [stdout] | [INFO] [stdout] 307 | / /// [INFO] [stdout] 308 | | [INFO] [stdout] | |_^ [INFO] [stdout] 309 | impl BfpctrlR { [INFO] [stdout] | - the comment documents this implementation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/lib.rs:535:13 [INFO] [stdout] | [INFO] [stdout] 535 | fn bits(self: &Self) -> u8; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] = note: `#[warn(clippy::needless_arbitrary_self_type)]` on by default [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 535 - fn bits(self: &Self) -> u8; [INFO] [stdout] 535 + fn bits(&self) -> u8; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `txb_ctrl` is never read [INFO] [stdout] --> src/lib.rs:668:9 [INFO] [stdout] | [INFO] [stdout] 667 | struct McpTxBuf { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] 668 | pub txb_ctrl: u8, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unsafe function's docs are missing a `# Safety` section [INFO] [stdout] --> src/lib.rs:82:5 [INFO] [stdout] | [INFO] [stdout] 82 | pub unsafe fn bits(&mut self, bits: U) -> &mut Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc [INFO] [stdout] = note: `#[warn(clippy::missing_safety_doc)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty doc comment [INFO] [stdout] --> src/lib.rs:197:1 [INFO] [stdout] | [INFO] [stdout] 197 | / /// [INFO] [stdout] 198 | | /// [INFO] [stdout] | |___^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing or filling it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_docs [INFO] [stdout] = note: `#[warn(clippy::empty_docs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty doc comment [INFO] [stdout] --> src/lib.rs:249:1 [INFO] [stdout] | [INFO] [stdout] 249 | / /// [INFO] [stdout] 250 | | /// [INFO] [stdout] 251 | | /// [INFO] [stdout] 252 | | /// [INFO] [stdout] | |___^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing or filling it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_docs [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/lib.rs:296:53 [INFO] [stdout] | [INFO] [stdout] 296 | self.w.bits = (self.w.bits & !(0b1 << 0)) | (((value as u8) & 0b1) << 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `(((value as u8) & 0b1))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty doc comment [INFO] [stdout] --> src/lib.rs:306:1 [INFO] [stdout] | [INFO] [stdout] 306 | / /// [INFO] [stdout] 307 | | /// [INFO] [stdout] | |___^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing or filling it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_docs [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/lib.rs:312:47 [INFO] [stdout] | [INFO] [stdout] 312 | pub fn b0fm(&self) -> B0feR { B0feR::new(((self.bits >> 0) & 0x01) != 0) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider reducing it to: `self.bits` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `txb_ctrl` is never read [INFO] [stdout] --> src/lib.rs:668:9 [INFO] [stdout] | [INFO] [stdout] 667 | struct McpTxBuf { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] 668 | pub txb_ctrl: u8, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unsafe function's docs are missing a `# Safety` section [INFO] [stdout] --> src/lib.rs:82:5 [INFO] [stdout] | [INFO] [stdout] 82 | pub unsafe fn bits(&mut self, bits: U) -> &mut Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc [INFO] [stdout] = note: `#[warn(clippy::missing_safety_doc)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty doc comment [INFO] [stdout] --> src/lib.rs:197:1 [INFO] [stdout] | [INFO] [stdout] 197 | / /// [INFO] [stdout] 198 | | /// [INFO] [stdout] | |___^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing or filling it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_docs [INFO] [stdout] = note: `#[warn(clippy::empty_docs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty doc comment [INFO] [stdout] --> src/lib.rs:249:1 [INFO] [stdout] | [INFO] [stdout] 249 | / /// [INFO] [stdout] 250 | | /// [INFO] [stdout] 251 | | /// [INFO] [stdout] 252 | | /// [INFO] [stdout] | |___^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing or filling it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_docs [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:838:12 [INFO] [stdout] | [INFO] [stdout] 838 | if !(config.brp <= 63) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(config.brp > 63)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/lib.rs:835:13 [INFO] [stdout] | [INFO] [stdout] 835 | if !(tq_per_bit >= 5 && tq_per_bit <= 25) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(5..=25).contains(&tq_per_bit)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/lib.rs:296:53 [INFO] [stdout] | [INFO] [stdout] 296 | self.w.bits = (self.w.bits & !(0b1 << 0)) | (((value as u8) & 0b1) << 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `(((value as u8) & 0b1))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty doc comment [INFO] [stdout] --> src/lib.rs:306:1 [INFO] [stdout] | [INFO] [stdout] 306 | / /// [INFO] [stdout] 307 | | /// [INFO] [stdout] | |___^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing or filling it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_docs [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/lib.rs:312:47 [INFO] [stdout] | [INFO] [stdout] 312 | pub fn b0fm(&self) -> B0feR { B0feR::new(((self.bits >> 0) & 0x01) != 0) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider reducing it to: `self.bits` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lib.rs:898:13 [INFO] [stdout] | [INFO] [stdout] 898 | rxb0ctrl = rxb0ctrl | (0b11 << 5); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rxb0ctrl |= (0b11 << 5)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lib.rs:899:13 [INFO] [stdout] | [INFO] [stdout] 899 | rxb1ctrl = rxb1ctrl | (0b11 << 5); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rxb1ctrl |= (0b11 << 5)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/lib.rs:1079:17 [INFO] [stdout] | [INFO] [stdout] 1079 | 0x00 + (filter as u8) * 4 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `(filter as u8) * 4` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/lib.rs:316:17 [INFO] [stdout] | [INFO] [stdout] 316 | pub fn b0fs(&mut self) -> B0fsW { [INFO] [stdout] | ^^^^^^^^^ ^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 316 | pub fn b0fs(&mut self) -> B0fsW<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/lib.rs:322:17 [INFO] [stdout] | [INFO] [stdout] 322 | pub fn b0fe(&mut self) -> B0feW { [INFO] [stdout] | ^^^^^^^^^ ^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 322 | pub fn b0fe(&mut self) -> B0feW<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/lib.rs:328:17 [INFO] [stdout] | [INFO] [stdout] 328 | pub fn b0fm(&mut self) -> B0fmW { [INFO] [stdout] | ^^^^^^^^^ ^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 328 | pub fn b0fm(&mut self) -> B0fmW<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:838:12 [INFO] [stdout] | [INFO] [stdout] 838 | if !(config.brp <= 63) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(config.brp > 63)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/lib.rs:835:13 [INFO] [stdout] | [INFO] [stdout] 835 | if !(tq_per_bit >= 5 && tq_per_bit <= 25) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(5..=25).contains(&tq_per_bit)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lib.rs:898:13 [INFO] [stdout] | [INFO] [stdout] 898 | rxb0ctrl = rxb0ctrl | (0b11 << 5); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rxb0ctrl |= (0b11 << 5)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lib.rs:899:13 [INFO] [stdout] | [INFO] [stdout] 899 | rxb1ctrl = rxb1ctrl | (0b11 << 5); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rxb1ctrl |= (0b11 << 5)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/lib.rs:1079:17 [INFO] [stdout] | [INFO] [stdout] 1079 | 0x00 + (filter as u8) * 4 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `(filter as u8) * 4` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/lib.rs:316:17 [INFO] [stdout] | [INFO] [stdout] 316 | pub fn b0fs(&mut self) -> B0fsW { [INFO] [stdout] | ^^^^^^^^^ ^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 316 | pub fn b0fs(&mut self) -> B0fsW<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/lib.rs:322:17 [INFO] [stdout] | [INFO] [stdout] 322 | pub fn b0fe(&mut self) -> B0feW { [INFO] [stdout] | ^^^^^^^^^ ^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 322 | pub fn b0fe(&mut self) -> B0feW<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/lib.rs:328:17 [INFO] [stdout] | [INFO] [stdout] 328 | pub fn b0fm(&mut self) -> B0fmW { [INFO] [stdout] | ^^^^^^^^^ ^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 328 | pub fn b0fm(&mut self) -> B0fmW<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.59s [INFO] running `Command { std: "docker" "inspect" "c3a2ba7ec404a9ab4f2c24ce37c407c7830577f4d7c37a93c0400fae3dae68bf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c3a2ba7ec404a9ab4f2c24ce37c407c7830577f4d7c37a93c0400fae3dae68bf", kill_on_drop: false }` [INFO] [stdout] c3a2ba7ec404a9ab4f2c24ce37c407c7830577f4d7c37a93c0400fae3dae68bf