[INFO] fetching crate mbox 0.7.1... [INFO] linting mbox-0.7.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate mbox 0.7.1 into /workspace/builds/worker-5-tc1/source [INFO] started tweaking crates.io crate mbox 0.7.1 [INFO] finished tweaking crates.io crate mbox 0.7.1 [INFO] tweaked toml for crates.io crate mbox 0.7.1 written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate mbox 0.7.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 2 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] abc9b1b853f1619da45f2bc80543f4a27291fab8b44ed1dda92df8de9658f672 [INFO] running `Command { std: "docker" "start" "-a" "abc9b1b853f1619da45f2bc80543f4a27291fab8b44ed1dda92df8de9658f672", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "abc9b1b853f1619da45f2bc80543f4a27291fab8b44ed1dda92df8de9658f672", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "abc9b1b853f1619da45f2bc80543f4a27291fab8b44ed1dda92df8de9658f672", kill_on_drop: false }` [INFO] [stdout] abc9b1b853f1619da45f2bc80543f4a27291fab8b44ed1dda92df8de9658f672 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4d3b79f98ea6eab8aafdc0152a6f327deb4a10670596dcfc47a166d88b50f84f [INFO] running `Command { std: "docker" "start" "-a" "4d3b79f98ea6eab8aafdc0152a6f327deb4a10670596dcfc47a166d88b50f84f", kill_on_drop: false }` [INFO] [stderr] Checking mbox v0.7.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unneeded sub `cfg` when there is only one condition [INFO] [stdout] --> src/sentinel.rs:145:11 [INFO] [stdout] | [INFO] [stdout] 145 | #[cfg(all(feature = "std"))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `feature = "std"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_minimal_cfg [INFO] [stdout] = note: `#[warn(clippy::non_minimal_cfg)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded sub `cfg` when there is only one condition [INFO] [stdout] --> src/sentinel.rs:145:11 [INFO] [stdout] | [INFO] [stdout] 145 | #[cfg(all(feature = "std"))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `feature = "std"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_minimal_cfg [INFO] [stdout] = note: `#[warn(clippy::non_minimal_cfg)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `clippy::derive_hash_xor_eq` has been renamed to `clippy::derived_hash_with_manual_eq` [INFO] [stdout] --> src/sentinel.rs:197:9 [INFO] [stdout] | [INFO] [stdout] 197 | #[allow(clippy::derive_hash_xor_eq)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `clippy::derived_hash_with_manual_eq` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `clippy::derive_hash_xor_eq` has been renamed to `clippy::derived_hash_with_manual_eq` [INFO] [stdout] --> src/sentinel.rs:204:9 [INFO] [stdout] | [INFO] [stdout] 204 | #[allow(clippy::derive_hash_xor_eq)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `clippy::derived_hash_with_manual_eq` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `clippy::derive_hash_xor_eq` has been renamed to `clippy::derived_hash_with_manual_eq` [INFO] [stdout] --> src/sentinel.rs:197:9 [INFO] [stdout] | [INFO] [stdout] 197 | #[allow(clippy::derive_hash_xor_eq)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `clippy::derived_hash_with_manual_eq` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `clippy::derive_hash_xor_eq` has been renamed to `clippy::derived_hash_with_manual_eq` [INFO] [stdout] --> src/sentinel.rs:204:9 [INFO] [stdout] | [INFO] [stdout] 204 | #[allow(clippy::derive_hash_xor_eq)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `clippy::derived_hash_with_manual_eq` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `clone` on a `Copy` type [INFO] [stdout] --> src/mbox.rs:540:33 [INFO] [stdout] | [INFO] [stdout] 540 | fn clone(&self) -> Self { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 541 | | Self { [INFO] [stdout] 542 | | ptr: self.ptr, [INFO] [stdout] 543 | | len: self.len, [INFO] [stdout] 544 | | } [INFO] [stdout] 545 | | } [INFO] [stdout] | |_________^ help: change this to: `{ *self }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_clone_impl [INFO] [stdout] = note: `#[warn(clippy::non_canonical_clone_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/mbox.rs:428:13 [INFO] [stdout] | [INFO] [stdout] 428 | assert!(!Some(MBox::new(0u64)).is_none()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Some(MBox::new(0u64)).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/mbox.rs:429:13 [INFO] [stdout] | [INFO] [stdout] 429 | assert!(!Some(MBox::new(())).is_none()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Some(MBox::new(())).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/mbox.rs:430:13 [INFO] [stdout] | [INFO] [stdout] 430 | assert!(!Some(MBox::new(&b)).is_none()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Some(MBox::new(&b)).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `clone` on a `Copy` type [INFO] [stdout] --> src/mbox.rs:540:33 [INFO] [stdout] | [INFO] [stdout] 540 | fn clone(&self) -> Self { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 541 | | Self { [INFO] [stdout] 542 | | ptr: self.ptr, [INFO] [stdout] 543 | | len: self.len, [INFO] [stdout] 544 | | } [INFO] [stdout] 545 | | } [INFO] [stdout] | |_________^ help: change this to: `{ *self }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_clone_impl [INFO] [stdout] = note: `#[warn(clippy::non_canonical_clone_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary operation [INFO] [stdout] --> src/mbox.rs:935:9 [INFO] [stdout] | [INFO] [stdout] 935 | / { [INFO] [stdout] 936 | | iter.next().unwrap().assert_eq(1) [INFO] [stdout] 937 | | }; [INFO] [stdout] | |__________^ help: statement can be reduced to: `iter.next().unwrap().assert_eq(1);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stdout] = note: `#[warn(clippy::unnecessary_operation)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary operation [INFO] [stdout] --> src/mbox.rs:938:9 [INFO] [stdout] | [INFO] [stdout] 938 | / { [INFO] [stdout] 939 | | iter.next().unwrap().assert_eq(2) [INFO] [stdout] 940 | | }; [INFO] [stdout] | |__________^ help: statement can be reduced to: `iter.next().unwrap().assert_eq(2);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary operation [INFO] [stdout] --> src/mbox.rs:941:9 [INFO] [stdout] | [INFO] [stdout] 941 | / { [INFO] [stdout] 942 | | iter.next_back().unwrap().assert_eq(3) [INFO] [stdout] 943 | | }; [INFO] [stdout] | |__________^ help: statement can be reduced to: `iter.next_back().unwrap().assert_eq(3);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.54s [INFO] running `Command { std: "docker" "inspect" "4d3b79f98ea6eab8aafdc0152a6f327deb4a10670596dcfc47a166d88b50f84f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4d3b79f98ea6eab8aafdc0152a6f327deb4a10670596dcfc47a166d88b50f84f", kill_on_drop: false }` [INFO] [stdout] 4d3b79f98ea6eab8aafdc0152a6f327deb4a10670596dcfc47a166d88b50f84f