[INFO] fetching crate maver 0.1.0... [INFO] linting maver-0.1.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate maver 0.1.0 into /workspace/builds/worker-3-tc1/source [INFO] started tweaking crates.io crate maver 0.1.0 [INFO] finished tweaking crates.io crate maver 0.1.0 [INFO] tweaked toml for crates.io crate maver 0.1.0 written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate maver 0.1.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate maver 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded itoa v0.4.4 [INFO] [stderr] Downloaded ryu v1.0.0 [INFO] [stderr] Downloaded num_cpus v1.10.1 [INFO] [stderr] Downloaded c2-chacha v0.2.2 [INFO] [stderr] Downloaded nodrop v0.1.13 [INFO] [stderr] Downloaded serde v1.0.99 [INFO] [stderr] Downloaded either v1.5.2 [INFO] [stderr] Downloaded ppv-lite86 v0.2.5 [INFO] [stderr] Downloaded rand_core v0.5.0 [INFO] [stderr] Downloaded wasi v0.5.0 [INFO] [stderr] Downloaded rand_distr v0.2.1 [INFO] [stderr] Downloaded serde_derive v1.0.99 [INFO] [stderr] Downloaded serde_json v1.0.40 [INFO] [stderr] Downloaded rayon v1.1.0 [INFO] [stderr] Downloaded crossbeam-utils v0.6.6 [INFO] [stderr] Downloaded syn v1.0.3 [INFO] [stderr] Downloaded rand v0.7.0 [INFO] [stderr] Downloaded rayon-core v1.5.0 [INFO] [stderr] Downloaded getrandom v0.1.10 [INFO] [stderr] Downloaded crossbeam-epoch v0.7.2 [INFO] [stderr] Downloaded arrayvec v0.4.11 [INFO] [stderr] Downloaded memoffset v0.5.1 [INFO] [stderr] Downloaded scopeguard v1.0.0 [INFO] [stderr] Downloaded crossbeam-deque v0.6.3 [INFO] [stderr] Downloaded crossbeam-queue v0.1.2 [INFO] [stderr] Downloaded cfg-if v0.1.9 [INFO] [stderr] Downloaded lazy_static v1.3.0 [INFO] [stderr] Downloaded proc-macro2 v1.0.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5092a35ba2c64a7e2bb8807d74f42d62883f67fa284b6f77a4e8124d52fa82a5 [INFO] running `Command { std: "docker" "start" "-a" "5092a35ba2c64a7e2bb8807d74f42d62883f67fa284b6f77a4e8124d52fa82a5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5092a35ba2c64a7e2bb8807d74f42d62883f67fa284b6f77a4e8124d52fa82a5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5092a35ba2c64a7e2bb8807d74f42d62883f67fa284b6f77a4e8124d52fa82a5", kill_on_drop: false }` [INFO] [stdout] 5092a35ba2c64a7e2bb8807d74f42d62883f67fa284b6f77a4e8124d52fa82a5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1c5f7ce77adf5822eebd4a3da3815c1923345fec69afca6bd2f4508faad11edf [INFO] running `Command { std: "docker" "start" "-a" "1c5f7ce77adf5822eebd4a3da3815c1923345fec69afca6bd2f4508faad11edf", kill_on_drop: false }` [INFO] [stderr] Checking cfg-if v0.1.9 [INFO] [stderr] Checking lazy_static v1.3.0 [INFO] [stderr] Compiling libc v0.2.62 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling proc-macro2 v1.0.1 [INFO] [stderr] Compiling arrayvec v0.4.11 [INFO] [stderr] Compiling getrandom v0.1.10 [INFO] [stderr] Compiling syn v1.0.3 [INFO] [stderr] Checking nodrop v0.1.13 [INFO] [stderr] Checking ppv-lite86 v0.2.5 [INFO] [stderr] Checking scopeguard v1.0.0 [INFO] [stderr] Compiling rayon-core v1.5.0 [INFO] [stderr] Compiling serde v1.0.99 [INFO] [stderr] Compiling ryu v1.0.0 [INFO] [stderr] Checking itoa v0.4.4 [INFO] [stderr] Checking either v1.5.2 [INFO] [stderr] Checking crossbeam-utils v0.6.6 [INFO] [stderr] Checking c2-chacha v0.2.2 [INFO] [stderr] Checking crossbeam-queue v0.1.2 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Checking num_cpus v1.10.1 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Checking rand_core v0.5.0 [INFO] [stderr] Checking rand_chacha v0.2.1 [INFO] [stderr] Compiling memoffset v0.5.1 [INFO] [stderr] Checking rand v0.7.0 [INFO] [stderr] Checking crossbeam-epoch v0.7.2 [INFO] [stderr] Checking crossbeam-deque v0.6.3 [INFO] [stderr] Checking rand_distr v0.2.1 [INFO] [stderr] Checking rayon v1.1.0 [INFO] [stderr] Compiling serde_derive v1.0.99 [INFO] [stderr] Checking serde_json v1.0.40 [INFO] [stderr] Checking maver v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/lib.rs:153:48 [INFO] [stdout] | [INFO] [stdout] 153 | #[derive(Copy,Clone,PartialEq,Eq,Debug,Serialize,Deserialize)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 176 | / activation_fn! { [INFO] [stdout] 177 | | Tanh { [INFO] [stdout] 178 | | output x => {x.tanh().abs()}, [INFO] [stdout] 179 | | der x => { [INFO] [stdout] ... | [INFO] [stdout] 213 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Serialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` which comes from the expansion of the macro `activation_fn` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/lib.rs:153:58 [INFO] [stdout] | [INFO] [stdout] 153 | #[derive(Copy,Clone,PartialEq,Eq,Debug,Serialize,Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 176 | / activation_fn! { [INFO] [stdout] 177 | | Tanh { [INFO] [stdout] 178 | | output x => {x.tanh().abs()}, [INFO] [stdout] 179 | | der x => { [INFO] [stdout] ... | [INFO] [stdout] 213 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Deserialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` which comes from the expansion of the macro `activation_fn` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/lib.rs:224:23 [INFO] [stdout] | [INFO] [stdout] 224 | #[derive(Clone, Debug,Serialize,Deserialize)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Serialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/lib.rs:224:33 [INFO] [stdout] | [INFO] [stdout] 224 | #[derive(Clone, Debug,Serialize,Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Deserialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/lib.rs:262:23 [INFO] [stdout] | [INFO] [stdout] 262 | #[derive(Clone, Debug,Serialize,Deserialize)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Serialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/lib.rs:262:33 [INFO] [stdout] | [INFO] [stdout] 262 | #[derive(Clone, Debug,Serialize,Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Deserialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/lib.rs:153:48 [INFO] [stdout] | [INFO] [stdout] 153 | #[derive(Copy,Clone,PartialEq,Eq,Debug,Serialize,Deserialize)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 176 | / activation_fn! { [INFO] [stdout] 177 | | Tanh { [INFO] [stdout] 178 | | output x => {x.tanh().abs()}, [INFO] [stdout] 179 | | der x => { [INFO] [stdout] ... | [INFO] [stdout] 213 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Serialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` which comes from the expansion of the macro `activation_fn` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/lib.rs:153:58 [INFO] [stdout] | [INFO] [stdout] 153 | #[derive(Copy,Clone,PartialEq,Eq,Debug,Serialize,Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 176 | / activation_fn! { [INFO] [stdout] 177 | | Tanh { [INFO] [stdout] 178 | | output x => {x.tanh().abs()}, [INFO] [stdout] 179 | | der x => { [INFO] [stdout] ... | [INFO] [stdout] 213 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Deserialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` which comes from the expansion of the macro `activation_fn` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/lib.rs:224:23 [INFO] [stdout] | [INFO] [stdout] 224 | #[derive(Clone, Debug,Serialize,Deserialize)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Serialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/lib.rs:224:33 [INFO] [stdout] | [INFO] [stdout] 224 | #[derive(Clone, Debug,Serialize,Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Deserialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/lib.rs:262:23 [INFO] [stdout] | [INFO] [stdout] 262 | #[derive(Clone, Debug,Serialize,Deserialize)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Serialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/lib.rs:262:33 [INFO] [stdout] | [INFO] [stdout] 262 | #[derive(Clone, Debug,Serialize,Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Deserialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `VecUtil` is never used [INFO] [stdout] --> src/lib.rs:403:7 [INFO] [stdout] | [INFO] [stdout] 403 | trait VecUtil { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/lib.rs:243:36 [INFO] [stdout] | [INFO] [stdout] 243 | pub fn activate(&self, inputs: &Vec) -> f64 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 243 - pub fn activate(&self, inputs: &Vec) -> f64 { [INFO] [stdout] 243 + pub fn activate(&self, inputs: &[f64]) -> f64 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/lib.rs:309:40 [INFO] [stdout] | [INFO] [stdout] 309 | pub fn forward_set(&mut self, row: &Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 309 ~ pub fn forward_set(&mut self, row: &[f64]) -> Vec { [INFO] [stdout] 310 ~ self.layers.iter_mut().fold(row.to_owned(), |inputs, layer| { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `VecUtil` is never used [INFO] [stdout] --> src/lib.rs:403:7 [INFO] [stdout] | [INFO] [stdout] 403 | trait VecUtil { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:334:34 [INFO] [stdout] | [INFO] [stdout] 334 | self.forward_set(&input); [INFO] [stdout] | ^^^^^^ help: change this to: `input` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:335:36 [INFO] [stdout] | [INFO] [stdout] 335 | self.backpropagate(&input, &expected, lrate); [INFO] [stdout] | ^^^^^^ help: change this to: `input` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:335:44 [INFO] [stdout] | [INFO] [stdout] 335 | self.backpropagate(&input, &expected, lrate); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `expected` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/lib.rs:348:44 [INFO] [stdout] | [INFO] [stdout] 348 | pub fn backpropagate(&mut self, input: &Vec, expected: &Vec, lrate: Option) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 348 ~ pub fn backpropagate(&mut self, input: &[f64], expected: &Vec, lrate: Option) { [INFO] [stdout] 349 | for i in (0..self.layers.len()).rev() { [INFO] [stdout] 350 | let prev: Vec = if i == 0 { [INFO] [stdout] 351 ~ input.to_owned() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/lib.rs:348:65 [INFO] [stdout] | [INFO] [stdout] 348 | pub fn backpropagate(&mut self, input: &Vec, expected: &Vec, lrate: Option) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 348 - pub fn backpropagate(&mut self, input: &Vec, expected: &Vec, lrate: Option) { [INFO] [stdout] 348 + pub fn backpropagate(&mut self, input: &Vec, expected: &[f64], lrate: Option) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is used to index `expected` [INFO] [stdout] --> src/lib.rs:355:22 [INFO] [stdout] | [INFO] [stdout] 355 | for j in 0..self.layers[i].len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 355 - for j in 0..self.layers[i].len() { [INFO] [stdout] 355 + for (j, ) in expected.iter().enumerate().take(self.layers[i].len()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stdout] --> src/lib.rs:364:21 [INFO] [stdout] | [INFO] [stdout] 364 | let ref mut perceptron = self.layers[i][j]; [INFO] [stdout] | ----^^^^^^^^^^^^^^^^^^--------------------- help: try: `let perceptron = &mut self.layers[i][j];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stdout] = note: `#[warn(clippy::toplevel_ref_arg)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `k` is used to index `prev` [INFO] [stdout] --> src/lib.rs:366:26 [INFO] [stdout] | [INFO] [stdout] 366 | for k in 0..prev.len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 366 - for k in 0..prev.len() { [INFO] [stdout] 366 + for (k, ) in prev.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:446:20 [INFO] [stdout] | [INFO] [stdout] 446 | if !(self.nn.layers.len() <= sacred_layers) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.nn.layers.len() > sacred_layers)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:459:16 [INFO] [stdout] | [INFO] [stdout] 459 | if !(self.nn.layers.len() <= sacred_layers) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.nn.layers.len() > sacred_layers)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/lib.rs:491:72 [INFO] [stdout] | [INFO] [stdout] 491 | if random::() < learn_params.weight_mutate_pr { [INFO] [stdout] | ________________________________________________________________________^ [INFO] [stdout] 492 | | *weight += weight_distr.sample(&mut rng); [INFO] [stdout] 493 | | } else if random::() < learn_params.weight_replace_pr { [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/lib.rs:493:80 [INFO] [stdout] | [INFO] [stdout] 493 | } else if random::() < learn_params.weight_replace_pr { [INFO] [stdout] | ________________________________________________________________________________^ [INFO] [stdout] 494 | | *weight += weight_distr.sample(&mut rng); [INFO] [stdout] 495 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:507:24 [INFO] [stdout] | [INFO] [stdout] 507 | org.mutate(&p); [INFO] [stdout] | ^^ help: change this to: `p` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:631:9 [INFO] [stdout] | [INFO] [stdout] 631 | return fittest; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 631 - return fittest; [INFO] [stdout] 631 + fittest [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/lib.rs:153:48 [INFO] [stdout] | [INFO] [stdout] 153 | #[derive(Copy,Clone,PartialEq,Eq,Debug,Serialize,Deserialize)] [INFO] [stdout] | ^-------- [INFO] [stdout] | | [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_Activation` [INFO] [stdout] 154 | pub enum Activation { [INFO] [stdout] | ---------- `Activation` is not local [INFO] [stdout] ... [INFO] [stdout] 176 | / activation_fn! { [INFO] [stdout] 177 | | Tanh { [INFO] [stdout] 178 | | output x => {x.tanh().abs()}, [INFO] [stdout] 179 | | der x => { [INFO] [stdout] ... | [INFO] [stdout] 213 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` which comes from the expansion of the macro `activation_fn` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/lib.rs:153:58 [INFO] [stdout] | [INFO] [stdout] 153 | #[derive(Copy,Clone,PartialEq,Eq,Debug,Serialize,Deserialize)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_Activation` [INFO] [stdout] 154 | pub enum Activation { [INFO] [stdout] | ---------- `Activation` is not local [INFO] [stdout] ... [INFO] [stdout] 176 | / activation_fn! { [INFO] [stdout] 177 | | Tanh { [INFO] [stdout] 178 | | output x => {x.tanh().abs()}, [INFO] [stdout] 179 | | der x => { [INFO] [stdout] ... | [INFO] [stdout] 213 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` which comes from the expansion of the macro `activation_fn` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/lib.rs:224:23 [INFO] [stdout] | [INFO] [stdout] 224 | #[derive(Clone, Debug,Serialize,Deserialize)] [INFO] [stdout] | ^-------- [INFO] [stdout] | | [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_Perceptron` [INFO] [stdout] 225 | pub struct Perceptron { [INFO] [stdout] | ---------- `Perceptron` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/lib.rs:224:33 [INFO] [stdout] | [INFO] [stdout] 224 | #[derive(Clone, Debug,Serialize,Deserialize)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_Perceptron` [INFO] [stdout] 225 | pub struct Perceptron { [INFO] [stdout] | ---------- `Perceptron` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/lib.rs:262:23 [INFO] [stdout] | [INFO] [stdout] 262 | #[derive(Clone, Debug,Serialize,Deserialize)] [INFO] [stdout] | ^-------- [INFO] [stdout] | | [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_NeuralNetwork` [INFO] [stdout] 263 | pub struct NeuralNetwork { [INFO] [stdout] | ------------- `NeuralNetwork` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/lib.rs:262:33 [INFO] [stdout] | [INFO] [stdout] 262 | #[derive(Clone, Debug,Serialize,Deserialize)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_NeuralNetwork` [INFO] [stdout] 263 | pub struct NeuralNetwork { [INFO] [stdout] | ------------- `NeuralNetwork` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/lib.rs:243:36 [INFO] [stdout] | [INFO] [stdout] 243 | pub fn activate(&self, inputs: &Vec) -> f64 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 243 - pub fn activate(&self, inputs: &Vec) -> f64 { [INFO] [stdout] 243 + pub fn activate(&self, inputs: &[f64]) -> f64 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/lib.rs:309:40 [INFO] [stdout] | [INFO] [stdout] 309 | pub fn forward_set(&mut self, row: &Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 309 ~ pub fn forward_set(&mut self, row: &[f64]) -> Vec { [INFO] [stdout] 310 ~ self.layers.iter_mut().fold(row.to_owned(), |inputs, layer| { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:334:34 [INFO] [stdout] | [INFO] [stdout] 334 | self.forward_set(&input); [INFO] [stdout] | ^^^^^^ help: change this to: `input` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:335:36 [INFO] [stdout] | [INFO] [stdout] 335 | self.backpropagate(&input, &expected, lrate); [INFO] [stdout] | ^^^^^^ help: change this to: `input` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:335:44 [INFO] [stdout] | [INFO] [stdout] 335 | self.backpropagate(&input, &expected, lrate); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `expected` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/lib.rs:348:44 [INFO] [stdout] | [INFO] [stdout] 348 | pub fn backpropagate(&mut self, input: &Vec, expected: &Vec, lrate: Option) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 348 ~ pub fn backpropagate(&mut self, input: &[f64], expected: &Vec, lrate: Option) { [INFO] [stdout] 349 | for i in (0..self.layers.len()).rev() { [INFO] [stdout] 350 | let prev: Vec = if i == 0 { [INFO] [stdout] 351 ~ input.to_owned() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/lib.rs:348:65 [INFO] [stdout] | [INFO] [stdout] 348 | pub fn backpropagate(&mut self, input: &Vec, expected: &Vec, lrate: Option) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 348 - pub fn backpropagate(&mut self, input: &Vec, expected: &Vec, lrate: Option) { [INFO] [stdout] 348 + pub fn backpropagate(&mut self, input: &Vec, expected: &[f64], lrate: Option) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is used to index `expected` [INFO] [stdout] --> src/lib.rs:355:22 [INFO] [stdout] | [INFO] [stdout] 355 | for j in 0..self.layers[i].len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 355 - for j in 0..self.layers[i].len() { [INFO] [stdout] 355 + for (j, ) in expected.iter().enumerate().take(self.layers[i].len()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stdout] --> src/lib.rs:364:21 [INFO] [stdout] | [INFO] [stdout] 364 | let ref mut perceptron = self.layers[i][j]; [INFO] [stdout] | ----^^^^^^^^^^^^^^^^^^--------------------- help: try: `let perceptron = &mut self.layers[i][j];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stdout] = note: `#[warn(clippy::toplevel_ref_arg)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `k` is used to index `prev` [INFO] [stdout] --> src/lib.rs:366:26 [INFO] [stdout] | [INFO] [stdout] 366 | for k in 0..prev.len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 366 - for k in 0..prev.len() { [INFO] [stdout] 366 + for (k, ) in prev.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:446:20 [INFO] [stdout] | [INFO] [stdout] 446 | if !(self.nn.layers.len() <= sacred_layers) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.nn.layers.len() > sacred_layers)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:459:16 [INFO] [stdout] | [INFO] [stdout] 459 | if !(self.nn.layers.len() <= sacred_layers) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.nn.layers.len() > sacred_layers)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/lib.rs:491:72 [INFO] [stdout] | [INFO] [stdout] 491 | if random::() < learn_params.weight_mutate_pr { [INFO] [stdout] | ________________________________________________________________________^ [INFO] [stdout] 492 | | *weight += weight_distr.sample(&mut rng); [INFO] [stdout] 493 | | } else if random::() < learn_params.weight_replace_pr { [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/lib.rs:493:80 [INFO] [stdout] | [INFO] [stdout] 493 | } else if random::() < learn_params.weight_replace_pr { [INFO] [stdout] | ________________________________________________________________________________^ [INFO] [stdout] 494 | | *weight += weight_distr.sample(&mut rng); [INFO] [stdout] 495 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:507:24 [INFO] [stdout] | [INFO] [stdout] 507 | org.mutate(&p); [INFO] [stdout] | ^^ help: change this to: `p` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:631:9 [INFO] [stdout] | [INFO] [stdout] 631 | return fittest; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 631 - return fittest; [INFO] [stdout] 631 + fittest [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/lib.rs:153:48 [INFO] [stdout] | [INFO] [stdout] 153 | #[derive(Copy,Clone,PartialEq,Eq,Debug,Serialize,Deserialize)] [INFO] [stdout] | ^-------- [INFO] [stdout] | | [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_Activation` [INFO] [stdout] 154 | pub enum Activation { [INFO] [stdout] | ---------- `Activation` is not local [INFO] [stdout] ... [INFO] [stdout] 176 | / activation_fn! { [INFO] [stdout] 177 | | Tanh { [INFO] [stdout] 178 | | output x => {x.tanh().abs()}, [INFO] [stdout] 179 | | der x => { [INFO] [stdout] ... | [INFO] [stdout] 213 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` which comes from the expansion of the macro `activation_fn` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/lib.rs:153:58 [INFO] [stdout] | [INFO] [stdout] 153 | #[derive(Copy,Clone,PartialEq,Eq,Debug,Serialize,Deserialize)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_Activation` [INFO] [stdout] 154 | pub enum Activation { [INFO] [stdout] | ---------- `Activation` is not local [INFO] [stdout] ... [INFO] [stdout] 176 | / activation_fn! { [INFO] [stdout] 177 | | Tanh { [INFO] [stdout] 178 | | output x => {x.tanh().abs()}, [INFO] [stdout] 179 | | der x => { [INFO] [stdout] ... | [INFO] [stdout] 213 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` which comes from the expansion of the macro `activation_fn` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/lib.rs:224:23 [INFO] [stdout] | [INFO] [stdout] 224 | #[derive(Clone, Debug,Serialize,Deserialize)] [INFO] [stdout] | ^-------- [INFO] [stdout] | | [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_Perceptron` [INFO] [stdout] 225 | pub struct Perceptron { [INFO] [stdout] | ---------- `Perceptron` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/lib.rs:224:33 [INFO] [stdout] | [INFO] [stdout] 224 | #[derive(Clone, Debug,Serialize,Deserialize)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_Perceptron` [INFO] [stdout] 225 | pub struct Perceptron { [INFO] [stdout] | ---------- `Perceptron` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/lib.rs:262:23 [INFO] [stdout] | [INFO] [stdout] 262 | #[derive(Clone, Debug,Serialize,Deserialize)] [INFO] [stdout] | ^-------- [INFO] [stdout] | | [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_NeuralNetwork` [INFO] [stdout] 263 | pub struct NeuralNetwork { [INFO] [stdout] | ------------- `NeuralNetwork` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/lib.rs:262:33 [INFO] [stdout] | [INFO] [stdout] 262 | #[derive(Clone, Debug,Serialize,Deserialize)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_NeuralNetwork` [INFO] [stdout] 263 | pub struct NeuralNetwork { [INFO] [stdout] | ------------- `NeuralNetwork` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `XOR` contains a capitalized acronym [INFO] [stdout] --> examples/simple.rs:7:8 [INFO] [stdout] | [INFO] [stdout] 7 | struct XOR; [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Xor` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `XOR` contains a capitalized acronym [INFO] [stdout] --> src/main.rs:6:8 [INFO] [stdout] | [INFO] [stdout] 6 | struct XOR; [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Xor` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `XOR` contains a capitalized acronym [INFO] [stdout] --> src/main.rs:6:8 [INFO] [stdout] | [INFO] [stdout] 6 | struct XOR; [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Xor` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 14.25s [INFO] running `Command { std: "docker" "inspect" "1c5f7ce77adf5822eebd4a3da3815c1923345fec69afca6bd2f4508faad11edf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1c5f7ce77adf5822eebd4a3da3815c1923345fec69afca6bd2f4508faad11edf", kill_on_drop: false }` [INFO] [stdout] 1c5f7ce77adf5822eebd4a3da3815c1923345fec69afca6bd2f4508faad11edf