[INFO] fetching crate markitdown 0.1.10... [INFO] linting markitdown-0.1.10 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate markitdown 0.1.10 into /workspace/builds/worker-2-tc1/source [INFO] started tweaking crates.io crate markitdown 0.1.10 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate markitdown 0.1.10 [INFO] tweaked toml for crates.io crate markitdown 0.1.10 written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate markitdown 0.1.10 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate markitdown 0.1.10 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded lockfree-object-pool v0.1.6 [INFO] [stderr] Downloaded type1-encoding-parser v0.1.0 [INFO] [stderr] Downloaded zopfli v0.8.1 [INFO] [stderr] Downloaded libz-rs-sys v0.5.0 [INFO] [stderr] Downloaded postscript v0.14.1 [INFO] [stderr] Downloaded codepage v0.1.2 [INFO] [stderr] Downloaded adobe-cmap-parser v0.4.1 [INFO] [stderr] Downloaded hard-xml v1.36.0 [INFO] [stderr] Downloaded hard-xml-derive v1.36.0 [INFO] [stderr] Downloaded jetscii v0.5.3 [INFO] [stderr] Downloaded infer v0.15.0 [INFO] [stderr] Downloaded weezl v0.1.8 [INFO] [stderr] Downloaded cff-parser v0.1.0 [INFO] [stderr] Downloaded clap_derive v4.5.32 [INFO] [stderr] Downloaded openssl-sys v0.9.107 [INFO] [stderr] Downloaded clap v4.5.36 [INFO] [stderr] Downloaded mediatype v0.19.20 [INFO] [stderr] Downloaded pdf-extract v0.8.2 [INFO] [stderr] Downloaded rangemap v1.5.1 [INFO] [stderr] Downloaded euclid v0.20.14 [INFO] [stderr] Downloaded zip v2.5.0 [INFO] [stderr] Downloaded calamine v0.26.1 [INFO] [stderr] Downloaded zlib-rs v0.5.0 [INFO] [stderr] Downloaded rig-core v0.8.0 [INFO] [stderr] Downloaded clap_builder v4.5.36 [INFO] [stderr] Downloaded winnow v0.7.6 [INFO] [stderr] Downloaded quick-xml v0.37.4 [INFO] [stderr] Downloaded pom v1.1.0 [INFO] [stderr] Downloaded feed-rs v2.3.1 [INFO] [stderr] Downloaded openssl v0.10.72 [INFO] [stderr] Downloaded docx-rust v0.1.9 [INFO] [stderr] Downloaded lopdf v0.34.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 468e90530b190e5ec80c33dbfa7ebe860900dc7e05f68d747d253ff860415c69 [INFO] running `Command { std: "docker" "start" "-a" "468e90530b190e5ec80c33dbfa7ebe860900dc7e05f68d747d253ff860415c69", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "468e90530b190e5ec80c33dbfa7ebe860900dc7e05f68d747d253ff860415c69", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "468e90530b190e5ec80c33dbfa7ebe860900dc7e05f68d747d253ff860415c69", kill_on_drop: false }` [INFO] [stdout] 468e90530b190e5ec80c33dbfa7ebe860900dc7e05f68d747d253ff860415c69 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9075d7b2f56dc4edd6d9896f46404c8dc1893a12a3636e1ad5cae7092eb7f926 [INFO] running `Command { std: "docker" "start" "-a" "9075d7b2f56dc4edd6d9896f46404c8dc1893a12a3636e1ad5cae7092eb7f926", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.95 [INFO] [stderr] Compiling unicode-ident v1.0.18 [INFO] [stderr] Compiling libc v0.2.172 [INFO] [stderr] Compiling serde v1.0.219 [INFO] [stderr] Checking log v0.4.27 [INFO] [stderr] Checking smallvec v1.15.0 [INFO] [stderr] Checking hashbrown v0.15.2 [INFO] [stderr] Compiling siphasher v1.0.1 [INFO] [stderr] Compiling icu_locid_transform_data v1.5.1 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Compiling cc v1.2.19 [INFO] [stderr] Compiling icu_properties_data v1.5.1 [INFO] [stderr] Checking encoding_rs v0.8.35 [INFO] [stderr] Checking zlib-rs v0.5.0 [INFO] [stderr] Compiling icu_normalizer_data v1.5.1 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Checking miniz_oxide v0.8.8 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking bitflags v2.9.0 [INFO] [stderr] Compiling phf_shared v0.11.3 [INFO] [stderr] Compiling getrandom v0.3.2 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling openssl v0.10.72 [INFO] [stderr] Compiling indexmap v2.9.0 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Checking tracing-core v0.1.33 [INFO] [stderr] Compiling native-tls v0.2.14 [INFO] [stderr] Compiling serde_json v1.0.140 [INFO] [stderr] Compiling winnow v0.7.6 [INFO] [stderr] Checking phf v0.11.3 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Compiling phf_generator v0.11.3 [INFO] [stderr] Checking openssl-probe v0.1.6 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking deranged v0.4.0 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking time-core v0.1.4 [INFO] [stderr] Checking simd-adler32 v0.3.7 [INFO] [stderr] Checking mio v1.0.3 [INFO] [stderr] Checking socket2 v0.5.9 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Compiling phf_codegen v0.11.3 [INFO] [stderr] Checking regex-syntax v0.8.5 [INFO] [stderr] Compiling jetscii v0.5.3 [INFO] [stderr] Checking libz-rs-sys v0.5.0 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking bumpalo v3.17.0 [INFO] [stderr] Checking lockfree-object-pool v0.1.6 [INFO] [stderr] Checking tokio v1.44.2 [INFO] [stderr] Checking flate2 v1.1.1 [INFO] [stderr] Checking anstyle-parse v0.2.6 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking uuid v1.16.0 [INFO] [stderr] Checking inout v0.1.4 [INFO] [stderr] Checking anstyle v1.0.10 [INFO] [stderr] Checking zopfli v0.8.1 [INFO] [stderr] Compiling unicase v2.8.1 [INFO] [stderr] Checking time v0.3.41 [INFO] [stderr] Compiling schemars v0.8.22 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Compiling zip v1.1.4 [INFO] [stderr] Compiling zip v2.5.0 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Compiling quote v1.0.40 [INFO] [stderr] Checking anstyle-query v1.1.2 [INFO] [stderr] Checking colorchoice v1.0.3 [INFO] [stderr] Checking pom v1.1.0 [INFO] [stderr] Compiling rustix v1.0.5 [INFO] [stderr] Checking rustls-pemfile v1.0.4 [INFO] [stderr] Compiling syn v2.0.100 [INFO] [stderr] Compiling string_cache_codegen v0.5.4 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking anstream v0.6.18 [INFO] [stderr] Compiling mime_guess v2.0.5 [INFO] [stderr] Checking tinyvec v1.9.0 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking md-5 v0.10.6 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking sync_wrapper v0.1.2 [INFO] [stderr] Checking clap_lex v0.7.4 [INFO] [stderr] Checking weezl v0.1.8 [INFO] [stderr] Checking dyn-clone v1.0.19 [INFO] [stderr] Checking ipnet v2.11.0 [INFO] [stderr] Checking rangemap v1.5.1 [INFO] [stderr] Checking xmlparser v0.13.6 [INFO] [stderr] Compiling toml_edit v0.22.24 [INFO] [stderr] Compiling openssl-sys v0.9.107 [INFO] [stderr] Checking linux-raw-sys v0.9.4 [INFO] [stderr] Checking iana-time-zone v0.1.63 [INFO] [stderr] Checking clap_builder v4.5.36 [INFO] [stderr] Checking pbkdf2 v0.12.2 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking unicode-normalization v0.1.24 [INFO] [stderr] Checking type1-encoding-parser v0.1.0 [INFO] [stderr] Checking cfb v0.7.3 [INFO] [stderr] Checking adobe-cmap-parser v0.4.1 [INFO] [stderr] Compiling markup5ever v0.12.1 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking euclid v0.20.14 [INFO] [stderr] Checking ordered-float v4.6.0 [INFO] [stderr] Checking codepage v0.1.2 [INFO] [stderr] Checking quick-xml v0.31.0 [INFO] [stderr] Checking quick-xml v0.37.4 [INFO] [stderr] Checking csv-core v0.1.12 [INFO] [stderr] Checking glob v0.3.2 [INFO] [stderr] Checking mutate_once v0.1.1 [INFO] [stderr] Checking cff-parser v0.1.0 [INFO] [stderr] Checking postscript v0.14.1 [INFO] [stderr] Checking constant_time_eq v0.3.1 [INFO] [stderr] Checking kamadak-exif v0.6.1 [INFO] [stderr] Checking infer v0.15.0 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Compiling proc-macro-crate v3.3.0 [INFO] [stderr] Checking lopdf v0.34.0 [INFO] [stderr] Compiling hard-xml-derive v1.36.0 [INFO] [stderr] Checking hard-xml v1.36.0 [INFO] [stderr] Checking pdf-extract v0.8.2 [INFO] [stderr] Checking tempfile v3.19.1 [INFO] [stderr] Checking tokio-util v0.7.14 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Compiling synstructure v0.13.1 [INFO] [stderr] Compiling serde_derive_internals v0.29.1 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.7.5 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling zerovec-derive v0.10.3 [INFO] [stderr] Compiling icu_provider_macros v1.5.0 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling tracing-attributes v0.1.28 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling html5ever v0.27.0 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling num_enum_derive v0.7.3 [INFO] [stderr] Compiling schemars_derive v0.8.22 [INFO] [stderr] Compiling async-stream-impl v0.3.6 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Compiling clap_derive v4.5.32 [INFO] [stderr] Checking async-stream v0.3.6 [INFO] [stderr] Compiling derive_more v0.99.19 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking zip v3.0.0 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking num_enum v0.7.3 [INFO] [stderr] Checking yoke v0.7.5 [INFO] [stderr] Checking zerovec v0.10.4 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking clap v4.5.36 [INFO] [stderr] Checking tinystr v0.7.6 [INFO] [stderr] Checking icu_collections v1.5.0 [INFO] [stderr] Checking icu_locid v1.5.0 [INFO] [stderr] Checking docx-rust v0.1.9 [INFO] [stderr] Checking icu_provider v1.5.0 [INFO] [stderr] Checking icu_locid_transform v1.5.0 [INFO] [stderr] Checking icu_properties v1.5.1 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking string_cache v0.8.9 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking chrono v0.4.40 [INFO] [stderr] Checking mediatype v0.19.20 [INFO] [stderr] Checking calamine v0.26.1 [INFO] [stderr] Checking csv v1.3.1 [INFO] [stderr] Checking icu_normalizer v1.5.0 [INFO] [stderr] Checking idna_adapter v1.2.0 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Checking xml5ever v0.18.1 [INFO] [stderr] Checking hyper v0.14.32 [INFO] [stderr] Checking markup5ever_rcdom v0.3.0 [INFO] [stderr] Checking feed-rs v2.3.1 [INFO] [stderr] Checking html2md v0.2.15 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.11.27 [INFO] [stderr] Checking rig-core v0.8.0 [INFO] [stderr] Checking markitdown v0.1.10 (/opt/rustwide/workdir) [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/lib.rs:17:1 [INFO] [stdout] | [INFO] [stdout] 17 | use infer; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/lib.rs:17:1 [INFO] [stdout] | [INFO] [stdout] 17 | use infer; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `index` is never read [INFO] [stdout] --> src/pptx.rs:52:21 [INFO] [stdout] | [INFO] [stdout] 51 | struct TableStat { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] 52 | index: u8, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TableStat` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/csv.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | / return Some(DocumentConverterResult { [INFO] [stdout] 42 | | title: None, [INFO] [stdout] 43 | | text_content: markdown, [INFO] [stdout] 44 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 41 ~ Some(DocumentConverterResult { [INFO] [stdout] 42 + title: None, [INFO] [stdout] 43 + text_content: markdown, [INFO] [stdout] 44 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `as_ref` does nothing [INFO] [stdout] --> src/csv.rs:30:34 [INFO] [stdout] | [INFO] [stdout] 30 | .map(|s| s.as_ref()) [INFO] [stdout] | ^^^^^^^^^^ help: try: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stdout] = note: `#[warn(clippy::useless_asref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/csv.rs:34:21 [INFO] [stdout] | [INFO] [stdout] 34 | markdown.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `markdown.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/docx.rs:24:12 [INFO] [stdout] | [INFO] [stdout] 24 | if !fs::metadata(local_path).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(local_path).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/docx.rs:37:43 [INFO] [stdout] | [INFO] [stdout] 37 | markdown.push_str(&text.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `text.as_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/docx.rs:38:25 [INFO] [stdout] | [INFO] [stdout] 38 | markdown.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `markdown.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/docx.rs:42:21 [INFO] [stdout] | [INFO] [stdout] 42 | markdown.push_str("|"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `markdown.push('|')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/docx.rs:44:25 [INFO] [stdout] | [INFO] [stdout] 44 | / match &cell { [INFO] [stdout] 45 | | TableRowContent::TableCell(tc) => { [INFO] [stdout] 46 | | tc.content.iter().for_each(|content| match content { [INFO] [stdout] 47 | | TableCellContent::Paragraph(paragraph) => { [INFO] [stdout] ... | [INFO] [stdout] 54 | | _ => {} [INFO] [stdout] 55 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 44 ~ if let TableRowContent::TableCell(tc) = &cell { [INFO] [stdout] 45 + tc.content.iter().for_each(|content| match content { [INFO] [stdout] 46 + TableCellContent::Paragraph(paragraph) => { [INFO] [stdout] 47 + for text in paragraph.iter_text() { [INFO] [stdout] 48 + markdown.push_str(&format!(" {} |", text)); [INFO] [stdout] 49 + } [INFO] [stdout] 50 + } [INFO] [stdout] 51 + }) [INFO] [stdout] 52 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/docx.rs:62:21 [INFO] [stdout] | [INFO] [stdout] 62 | markdown.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `markdown.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/docx.rs:65:25 [INFO] [stdout] | [INFO] [stdout] 65 | markdown.push_str("|"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `markdown.push('|')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/docx.rs:67:29 [INFO] [stdout] | [INFO] [stdout] 67 | / ... match &cell { [INFO] [stdout] 68 | | ... TableRowContent::TableCell(tc) => { [INFO] [stdout] 69 | | ... tc.content.iter().for_each(|content| match content { [INFO] [stdout] 70 | | ... TableCellContent::Paragraph(paragraph) => { [INFO] [stdout] ... | [INFO] [stdout] 77 | | ... _ => {} [INFO] [stdout] 78 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 67 ~ if let TableRowContent::TableCell(tc) = &cell { [INFO] [stdout] 68 + tc.content.iter().for_each(|content| match content { [INFO] [stdout] 69 + TableCellContent::Paragraph(paragraph) => { [INFO] [stdout] 70 + for text in paragraph.iter_text() { [INFO] [stdout] 71 + markdown.push_str(&format!(" {} |", text)); [INFO] [stdout] 72 + } [INFO] [stdout] 73 + } [INFO] [stdout] 74 + }) [INFO] [stdout] 75 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/docx.rs:80:25 [INFO] [stdout] | [INFO] [stdout] 80 | markdown.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `markdown.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/excel.rs:40:13 [INFO] [stdout] | [INFO] [stdout] 40 | markdown.push_str("|"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `markdown.push('|')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/excel.rs:49:13 [INFO] [stdout] | [INFO] [stdout] 49 | markdown.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `markdown.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/excel.rs:52:17 [INFO] [stdout] | [INFO] [stdout] 52 | markdown.push_str("|"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `markdown.push('|')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/excel.rs:56:17 [INFO] [stdout] | [INFO] [stdout] 56 | markdown.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `markdown.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/image.rs:25:12 [INFO] [stdout] | [INFO] [stdout] 25 | if !fs::metadata(local_path).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(local_path).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/llm.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 25 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return None; [INFO] [stdout] 25 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/pptx.rs:23:12 [INFO] [stdout] | [INFO] [stdout] 23 | if !fs::metadata(local_path).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(local_path).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/pptx.rs:86:45 [INFO] [stdout] | [INFO] [stdout] 86 | / ... if element.name().as_ref() == b"p:txBody" { [INFO] [stdout] 87 | | ... markdown.push_str("\n\n"); [INFO] [stdout] 88 | | ... break; [INFO] [stdout] 89 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 85 ~ Event::End(element) [INFO] [stdout] 86 ~ if element.name().as_ref() == b"p:txBody" => { [INFO] [stdout] 87 | markdown.push_str("\n\n"); [INFO] [stdout] 88 | break; [INFO] [stdout] 89 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/pptx.rs:64:66 [INFO] [stdout] | [INFO] [stdout] 64 | ... Event::Start(element) => match element.name().as_ref() { [INFO] [stdout] | ________________________________________________^ [INFO] [stdout] 65 | | ... b"a:t" => loop { [INFO] [stdout] 66 | | ... println!("slide: {:?}", slide); [INFO] [stdout] 67 | | ... let mut tc_buf = Vec::new(); [INFO] [stdout] ... | [INFO] [stdout] 83 | | ... _ => {} [INFO] [stdout] 84 | | ... }, [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 64 ~ Event::Start(element) => if element.name().as_ref() == b"a:t" { loop { [INFO] [stdout] 65 + println!("slide: {:?}", slide); [INFO] [stdout] 66 + let mut tc_buf = Vec::new(); [INFO] [stdout] 67 + match reader.read_event_into(&mut tc_buf).unwrap() { [INFO] [stdout] 68 + Event::Text(text) => { [INFO] [stdout] 69 + println!("text: {:?}", text); [INFO] [stdout] 70 + markdown [INFO] [stdout] 71 + .push_str(&text.unescape().unwrap()); [INFO] [stdout] 72 + } [INFO] [stdout] 73 + Event::End(element) => { [INFO] [stdout] 74 + if element.name().as_ref() == b"a:t" { [INFO] [stdout] 75 + break; [INFO] [stdout] 76 + } [INFO] [stdout] 77 + } [INFO] [stdout] 78 + _ => {} [INFO] [stdout] 79 + } [INFO] [stdout] 80 + tc_buf.clear(); [INFO] [stdout] 81 ~ } }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/pptx.rs:75:57 [INFO] [stdout] | [INFO] [stdout] 75 | / ... if element.name().as_ref() == b"a:t" { [INFO] [stdout] 76 | | ... break; [INFO] [stdout] 77 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 74 ~ Event::End(element) [INFO] [stdout] 75 ~ if element.name().as_ref() == b"a:t" => { [INFO] [stdout] 76 | break; [INFO] [stdout] 77 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/pptx.rs:128:45 [INFO] [stdout] | [INFO] [stdout] 128 | / ... if element.name().as_ref() == b"a:tbl" { [INFO] [stdout] 129 | | ... found_tables.push(stats); [INFO] [stdout] 130 | | ... break; [INFO] [stdout] 131 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 127 ~ Event::End(element) [INFO] [stdout] 128 ~ if element.name().as_ref() == b"a:tbl" => { [INFO] [stdout] 129 | found_tables.push(stats); [INFO] [stdout] 130 | break; [INFO] [stdout] 131 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/pptx.rs:138:37 [INFO] [stdout] | [INFO] [stdout] 138 | ... markdown.push_str("|"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `markdown.push('|')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/pptx.rs:147:37 [INFO] [stdout] | [INFO] [stdout] 147 | ... markdown.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `markdown.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/pptx.rs:150:41 [INFO] [stdout] | [INFO] [stdout] 150 | ... markdown.push_str("|"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `markdown.push('|')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/pptx.rs:154:41 [INFO] [stdout] | [INFO] [stdout] 154 | ... markdown.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `markdown.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/pptx.rs:156:37 [INFO] [stdout] | [INFO] [stdout] 156 | ... markdown.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `markdown.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `feed.title` after checking its variant with `is_some` [INFO] [stdout] --> src/rss.rs:44:46 [INFO] [stdout] | [INFO] [stdout] 43 | if feed.title.is_some() { [INFO] [stdout] | ----------------------- help: try: `if let Some() = feed.title` [INFO] [stdout] 44 | markdown.push_str(&format!("# {}\n", feed.title.unwrap().content)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `entry.updated` after checking its variant with `is_some` [INFO] [stdout] --> src/rss.rs:53:63 [INFO] [stdout] | [INFO] [stdout] 52 | if entry.updated.is_some() { [INFO] [stdout] | -------------------------- help: try: `if let Some() = entry.updated` [INFO] [stdout] 53 | markdown.push_str(&format!("Updated on: {}\n\n", entry.updated.unwrap())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/rss.rs:58:13 [INFO] [stdout] | [INFO] [stdout] 58 | markdown.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `markdown.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `feed.title` after checking its variant with `is_some` [INFO] [stdout] --> src/rss.rs:67:46 [INFO] [stdout] | [INFO] [stdout] 66 | if feed.title.is_some() { [INFO] [stdout] | ----------------------- help: try: `if let Some() = feed.title` [INFO] [stdout] 67 | markdown.push_str(&format!("# {}\n", feed.title.unwrap().content)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `feed.description` after checking its variant with `is_some` [INFO] [stdout] --> src/rss.rs:71:28 [INFO] [stdout] | [INFO] [stdout] 70 | if feed.description.is_some() { [INFO] [stdout] | ----------------------------- help: try: `if let Some() = feed.description` [INFO] [stdout] 71 | markdown.push_str(&feed.description.unwrap().content); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/rss.rs:72:9 [INFO] [stdout] | [INFO] [stdout] 72 | markdown.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `markdown.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `entry.published` after checking its variant with `is_some` [INFO] [stdout] --> src/rss.rs:81:65 [INFO] [stdout] | [INFO] [stdout] 80 | if entry.published.is_some() { [INFO] [stdout] | ---------------------------- help: try: `if let Some() = entry.published` [INFO] [stdout] 81 | markdown.push_str(&format!("Published on: {}\n\n", entry.published.unwrap())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/rss.rs:86:13 [INFO] [stdout] | [INFO] [stdout] 86 | markdown.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `markdown.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `MarkItDown` [INFO] [stdout] --> src/lib.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 34 | / pub fn new() -> Self { [INFO] [stdout] 35 | | let mut md = MarkItDown { [INFO] [stdout] 36 | | converters: Vec::new(), [INFO] [stdout] 37 | | }; [INFO] [stdout] ... | [INFO] [stdout] 48 | | md [INFO] [stdout] 49 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 33 + impl Default for MarkItDown { [INFO] [stdout] 34 + fn default() -> Self { [INFO] [stdout] 35 + Self::new() [INFO] [stdout] 36 + } [INFO] [stdout] 37 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:148:51 [INFO] [stdout] | [INFO] [stdout] 148 | ... converter.convert(&file_path.to_str().unwrap(), file_args.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `file_path.to_str().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `index` is never read [INFO] [stdout] --> src/pptx.rs:52:21 [INFO] [stdout] | [INFO] [stdout] 51 | struct TableStat { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] 52 | index: u8, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TableStat` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/csv.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | / return Some(DocumentConverterResult { [INFO] [stdout] 42 | | title: None, [INFO] [stdout] 43 | | text_content: markdown, [INFO] [stdout] 44 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 41 ~ Some(DocumentConverterResult { [INFO] [stdout] 42 + title: None, [INFO] [stdout] 43 + text_content: markdown, [INFO] [stdout] 44 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `as_ref` does nothing [INFO] [stdout] --> src/csv.rs:30:34 [INFO] [stdout] | [INFO] [stdout] 30 | .map(|s| s.as_ref()) [INFO] [stdout] | ^^^^^^^^^^ help: try: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stdout] = note: `#[warn(clippy::useless_asref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/csv.rs:34:21 [INFO] [stdout] | [INFO] [stdout] 34 | markdown.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `markdown.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `write_to_file` is never used [INFO] [stdout] --> tests/excel.rs:21:4 [INFO] [stdout] | [INFO] [stdout] 21 | fn write_to_file(content: &str) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/docx.rs:24:12 [INFO] [stdout] | [INFO] [stdout] 24 | if !fs::metadata(local_path).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(local_path).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/docx.rs:37:43 [INFO] [stdout] | [INFO] [stdout] 37 | markdown.push_str(&text.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `text.as_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/docx.rs:38:25 [INFO] [stdout] | [INFO] [stdout] 38 | markdown.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `markdown.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/docx.rs:42:21 [INFO] [stdout] | [INFO] [stdout] 42 | markdown.push_str("|"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `markdown.push('|')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/docx.rs:44:25 [INFO] [stdout] | [INFO] [stdout] 44 | / match &cell { [INFO] [stdout] 45 | | TableRowContent::TableCell(tc) => { [INFO] [stdout] 46 | | tc.content.iter().for_each(|content| match content { [INFO] [stdout] 47 | | TableCellContent::Paragraph(paragraph) => { [INFO] [stdout] ... | [INFO] [stdout] 54 | | _ => {} [INFO] [stdout] 55 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 44 ~ if let TableRowContent::TableCell(tc) = &cell { [INFO] [stdout] 45 + tc.content.iter().for_each(|content| match content { [INFO] [stdout] 46 + TableCellContent::Paragraph(paragraph) => { [INFO] [stdout] 47 + for text in paragraph.iter_text() { [INFO] [stdout] 48 + markdown.push_str(&format!(" {} |", text)); [INFO] [stdout] 49 + } [INFO] [stdout] 50 + } [INFO] [stdout] 51 + }) [INFO] [stdout] 52 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/docx.rs:62:21 [INFO] [stdout] | [INFO] [stdout] 62 | markdown.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `markdown.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/docx.rs:65:25 [INFO] [stdout] | [INFO] [stdout] 65 | markdown.push_str("|"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `markdown.push('|')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/docx.rs:67:29 [INFO] [stdout] | [INFO] [stdout] 67 | / ... match &cell { [INFO] [stdout] 68 | | ... TableRowContent::TableCell(tc) => { [INFO] [stdout] 69 | | ... tc.content.iter().for_each(|content| match content { [INFO] [stdout] 70 | | ... TableCellContent::Paragraph(paragraph) => { [INFO] [stdout] ... | [INFO] [stdout] 77 | | ... _ => {} [INFO] [stdout] 78 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 67 ~ if let TableRowContent::TableCell(tc) = &cell { [INFO] [stdout] 68 + tc.content.iter().for_each(|content| match content { [INFO] [stdout] 69 + TableCellContent::Paragraph(paragraph) => { [INFO] [stdout] 70 + for text in paragraph.iter_text() { [INFO] [stdout] 71 + markdown.push_str(&format!(" {} |", text)); [INFO] [stdout] 72 + } [INFO] [stdout] 73 + } [INFO] [stdout] 74 + }) [INFO] [stdout] 75 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/docx.rs:80:25 [INFO] [stdout] | [INFO] [stdout] 80 | markdown.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `markdown.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/excel.rs:40:13 [INFO] [stdout] | [INFO] [stdout] 40 | markdown.push_str("|"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `markdown.push('|')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/excel.rs:49:13 [INFO] [stdout] | [INFO] [stdout] 49 | markdown.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `markdown.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/excel.rs:52:17 [INFO] [stdout] | [INFO] [stdout] 52 | markdown.push_str("|"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `markdown.push('|')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/excel.rs:56:17 [INFO] [stdout] | [INFO] [stdout] 56 | markdown.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `markdown.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/image.rs:25:12 [INFO] [stdout] | [INFO] [stdout] 25 | if !fs::metadata(local_path).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(local_path).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/llm.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 25 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return None; [INFO] [stdout] 25 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/pptx.rs:23:12 [INFO] [stdout] | [INFO] [stdout] 23 | if !fs::metadata(local_path).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(local_path).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/pptx.rs:86:45 [INFO] [stdout] | [INFO] [stdout] 86 | / ... if element.name().as_ref() == b"p:txBody" { [INFO] [stdout] 87 | | ... markdown.push_str("\n\n"); [INFO] [stdout] 88 | | ... break; [INFO] [stdout] 89 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 85 ~ Event::End(element) [INFO] [stdout] 86 ~ if element.name().as_ref() == b"p:txBody" => { [INFO] [stdout] 87 | markdown.push_str("\n\n"); [INFO] [stdout] 88 | break; [INFO] [stdout] 89 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/pptx.rs:64:66 [INFO] [stdout] | [INFO] [stdout] 64 | ... Event::Start(element) => match element.name().as_ref() { [INFO] [stdout] | ________________________________________________^ [INFO] [stdout] 65 | | ... b"a:t" => loop { [INFO] [stdout] 66 | | ... println!("slide: {:?}", slide); [INFO] [stdout] 67 | | ... let mut tc_buf = Vec::new(); [INFO] [stdout] ... | [INFO] [stdout] 83 | | ... _ => {} [INFO] [stdout] 84 | | ... }, [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 64 ~ Event::Start(element) => if element.name().as_ref() == b"a:t" { loop { [INFO] [stdout] 65 + println!("slide: {:?}", slide); [INFO] [stdout] 66 + let mut tc_buf = Vec::new(); [INFO] [stdout] 67 + match reader.read_event_into(&mut tc_buf).unwrap() { [INFO] [stdout] 68 + Event::Text(text) => { [INFO] [stdout] 69 + println!("text: {:?}", text); [INFO] [stdout] 70 + markdown [INFO] [stdout] 71 + .push_str(&text.unescape().unwrap()); [INFO] [stdout] 72 + } [INFO] [stdout] 73 + Event::End(element) => { [INFO] [stdout] 74 + if element.name().as_ref() == b"a:t" { [INFO] [stdout] 75 + break; [INFO] [stdout] 76 + } [INFO] [stdout] 77 + } [INFO] [stdout] 78 + _ => {} [INFO] [stdout] 79 + } [INFO] [stdout] 80 + tc_buf.clear(); [INFO] [stdout] 81 ~ } }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/pptx.rs:75:57 [INFO] [stdout] | [INFO] [stdout] 75 | / ... if element.name().as_ref() == b"a:t" { [INFO] [stdout] 76 | | ... break; [INFO] [stdout] 77 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 74 ~ Event::End(element) [INFO] [stdout] 75 ~ if element.name().as_ref() == b"a:t" => { [INFO] [stdout] 76 | break; [INFO] [stdout] 77 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/pptx.rs:128:45 [INFO] [stdout] | [INFO] [stdout] 128 | / ... if element.name().as_ref() == b"a:tbl" { [INFO] [stdout] 129 | | ... found_tables.push(stats); [INFO] [stdout] 130 | | ... break; [INFO] [stdout] 131 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 127 ~ Event::End(element) [INFO] [stdout] 128 ~ if element.name().as_ref() == b"a:tbl" => { [INFO] [stdout] 129 | found_tables.push(stats); [INFO] [stdout] 130 | break; [INFO] [stdout] 131 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/pptx.rs:138:37 [INFO] [stdout] | [INFO] [stdout] 138 | ... markdown.push_str("|"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `markdown.push('|')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/pptx.rs:147:37 [INFO] [stdout] | [INFO] [stdout] 147 | ... markdown.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `markdown.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/pptx.rs:150:41 [INFO] [stdout] | [INFO] [stdout] 150 | ... markdown.push_str("|"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `markdown.push('|')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/pptx.rs:154:41 [INFO] [stdout] | [INFO] [stdout] 154 | ... markdown.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `markdown.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/pptx.rs:156:37 [INFO] [stdout] | [INFO] [stdout] 156 | ... markdown.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `markdown.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `feed.title` after checking its variant with `is_some` [INFO] [stdout] --> src/rss.rs:44:46 [INFO] [stdout] | [INFO] [stdout] 43 | if feed.title.is_some() { [INFO] [stdout] | ----------------------- help: try: `if let Some() = feed.title` [INFO] [stdout] 44 | markdown.push_str(&format!("# {}\n", feed.title.unwrap().content)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> tests/image.rs:16:12 [INFO] [stdout] | [INFO] [stdout] 16 | if let Ok(_) = std::env::var("GEMINI_API_KEY") { [INFO] [stdout] | -------^^^^^----------------------------------- help: try: `if std::env::var("GEMINI_API_KEY").is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `entry.updated` after checking its variant with `is_some` [INFO] [stdout] --> src/rss.rs:53:63 [INFO] [stdout] | [INFO] [stdout] 52 | if entry.updated.is_some() { [INFO] [stdout] | -------------------------- help: try: `if let Some() = entry.updated` [INFO] [stdout] 53 | markdown.push_str(&format!("Updated on: {}\n\n", entry.updated.unwrap())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/rss.rs:58:13 [INFO] [stdout] | [INFO] [stdout] 58 | markdown.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `markdown.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `feed.title` after checking its variant with `is_some` [INFO] [stdout] --> src/rss.rs:67:46 [INFO] [stdout] | [INFO] [stdout] 66 | if feed.title.is_some() { [INFO] [stdout] | ----------------------- help: try: `if let Some() = feed.title` [INFO] [stdout] 67 | markdown.push_str(&format!("# {}\n", feed.title.unwrap().content)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `feed.description` after checking its variant with `is_some` [INFO] [stdout] --> src/rss.rs:71:28 [INFO] [stdout] | [INFO] [stdout] 70 | if feed.description.is_some() { [INFO] [stdout] | ----------------------------- help: try: `if let Some() = feed.description` [INFO] [stdout] 71 | markdown.push_str(&feed.description.unwrap().content); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/rss.rs:72:9 [INFO] [stdout] | [INFO] [stdout] 72 | markdown.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `markdown.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `entry.published` after checking its variant with `is_some` [INFO] [stdout] --> src/rss.rs:81:65 [INFO] [stdout] | [INFO] [stdout] 80 | if entry.published.is_some() { [INFO] [stdout] | ---------------------------- help: try: `if let Some() = entry.published` [INFO] [stdout] 81 | markdown.push_str(&format!("Published on: {}\n\n", entry.published.unwrap())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/rss.rs:86:13 [INFO] [stdout] | [INFO] [stdout] 86 | markdown.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `markdown.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `MarkItDown` [INFO] [stdout] --> src/lib.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 34 | / pub fn new() -> Self { [INFO] [stdout] 35 | | let mut md = MarkItDown { [INFO] [stdout] 36 | | converters: Vec::new(), [INFO] [stdout] 37 | | }; [INFO] [stdout] ... | [INFO] [stdout] 48 | | md [INFO] [stdout] 49 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 33 + impl Default for MarkItDown { [INFO] [stdout] 34 + fn default() -> Self { [INFO] [stdout] 35 + Self::new() [INFO] [stdout] 36 + } [INFO] [stdout] 37 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:148:51 [INFO] [stdout] | [INFO] [stdout] 148 | ... converter.convert(&file_path.to_str().unwrap(), file_args.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `file_path.to_str().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `command` [INFO] [stdout] --> src/main.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | use clap::{command, Parser}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `command` [INFO] [stdout] --> src/main.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | use clap::{command, Parser}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `DocumentConverter` [INFO] [stdout] --> tests/zip.rs:2:32 [INFO] [stdout] | [INFO] [stdout] 2 | model::{ConversionOptions, DocumentConverter}, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 05s [INFO] running `Command { std: "docker" "inspect" "9075d7b2f56dc4edd6d9896f46404c8dc1893a12a3636e1ad5cae7092eb7f926", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9075d7b2f56dc4edd6d9896f46404c8dc1893a12a3636e1ad5cae7092eb7f926", kill_on_drop: false }` [INFO] [stdout] 9075d7b2f56dc4edd6d9896f46404c8dc1893a12a3636e1ad5cae7092eb7f926