[INFO] fetching crate manatee 0.3.0... [INFO] linting manatee-0.3.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate manatee 0.3.0 into /workspace/builds/worker-3-tc1/source [INFO] started tweaking crates.io crate manatee 0.3.0 [INFO] finished tweaking crates.io crate manatee 0.3.0 [INFO] tweaked toml for crates.io crate manatee 0.3.0 written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate manatee 0.3.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate manatee 0.3.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3160b61c89b8d012d80c7b17526b7e679fc308d7cc60187c784793aca114eac8 [INFO] running `Command { std: "docker" "start" "-a" "3160b61c89b8d012d80c7b17526b7e679fc308d7cc60187c784793aca114eac8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3160b61c89b8d012d80c7b17526b7e679fc308d7cc60187c784793aca114eac8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3160b61c89b8d012d80c7b17526b7e679fc308d7cc60187c784793aca114eac8", kill_on_drop: false }` [INFO] [stdout] 3160b61c89b8d012d80c7b17526b7e679fc308d7cc60187c784793aca114eac8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5b820cc5679677707caff785ba228937f6088badb757780dd2731f2883b1d5ea [INFO] running `Command { std: "docker" "start" "-a" "5b820cc5679677707caff785ba228937f6088badb757780dd2731f2883b1d5ea", kill_on_drop: false }` [INFO] [stderr] Compiling unicode-ident v1.0.23 [INFO] [stderr] Checking bytemuck v1.25.0 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Compiling proc-macro2 v1.0.106 [INFO] [stderr] Checking safe_arch v0.7.4 [INFO] [stderr] Checking wide v0.7.33 [INFO] [stderr] Compiling quote v1.0.44 [INFO] [stderr] Compiling syn v2.0.114 [INFO] [stderr] Checking simba v0.9.1 [INFO] [stderr] Checking indexmap v2.13.0 [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stderr] Checking thiserror v2.0.18 [INFO] [stderr] Checking nalgebra v0.34.1 [INFO] [stderr] Checking manatee v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: methods `bounding_box_center_nodes_with_extras`, `bounding_box_center_leaves`, `max_compound_nesting_depth`, and `estimated_size` are never used [INFO] [stdout] --> src/algo/fcose/mod.rs:1157:8 [INFO] [stdout] | [INFO] [stdout] 818 | impl SimGraph { [INFO] [stdout] | ------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 1157 | fn bounding_box_center_nodes_with_extras(&self) -> Option<(f64, f64)> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1543 | fn bounding_box_center_leaves(&self) -> Option<(f64, f64)> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1650 | fn max_compound_nesting_depth(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2529 | fn estimated_size(&self) -> f64 { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `left` and `top` are never read [INFO] [stdout] --> src/algo/fcose/mod.rs:4285:5 [INFO] [stdout] | [INFO] [stdout] 4284 | struct RepulsionGrid { [INFO] [stdout] | ------------- fields in this struct [INFO] [stdout] 4285 | left: f64, [INFO] [stdout] | ^^^^ [INFO] [stdout] 4286 | top: f64, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `RepulsionGrid` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `c` [INFO] [stdout] --> src/algo/fcose/spectral.rs:88:14 [INFO] [stdout] | [INFO] [stdout] 88 | for i in 0..node_size { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 88 - for i in 0..node_size { [INFO] [stdout] 88 + for in c.iter_mut().take(node_size) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is only used to index `c` [INFO] [stdout] --> src/algo/fcose/spectral.rs:89:18 [INFO] [stdout] | [INFO] [stdout] 89 | for j in 0..sample_size { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 89 - for j in 0..sample_size { [INFO] [stdout] 89 + for in c.iter_mut().take(sample_size) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `child_ix` is used to index `compound_parent_ix` [INFO] [stdout] --> src/algo/fcose/spectral.rs:228:21 [INFO] [stdout] | [INFO] [stdout] 228 | for child_ix in 0..compound_ids.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 228 - for child_ix in 0..compound_ids.len() { [INFO] [stdout] 228 + for (child_ix, ) in compound_parent_ix.iter().enumerate().take(compound_ids.len()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `leaf` is used to index `leaf_immediate_parent` [INFO] [stdout] --> src/algo/fcose/spectral.rs:340:21 [INFO] [stdout] | [INFO] [stdout] 340 | for leaf in 0..n_real { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 340 - for leaf in 0..n_real { [INFO] [stdout] 340 + for (leaf, ) in leaf_immediate_parent.iter().enumerate().take(n_real) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `leaf` is used to index `leaf_immediate_parent` [INFO] [stdout] --> src/algo/fcose/spectral.rs:375:21 [INFO] [stdout] | [INFO] [stdout] 375 | for leaf in 0..n_real { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 375 - for leaf in 0..n_real { [INFO] [stdout] 375 + for (leaf, ) in leaf_immediate_parent.iter().enumerate().take(n_real) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `contains()` instead of `iter().any()` is more efficient [INFO] [stdout] --> src/algo/fcose/spectral.rs:394:42 [INFO] [stdout] | [INFO] [stdout] 394 | .is_some_and(|chain| chain.iter().any(|&c| c == scope_cix)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `chain.contains(&scope_cix)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_contains [INFO] [stdout] = note: `#[warn(clippy::manual_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `bounding_box_center_nodes_with_extras`, `bounding_box_center_leaves`, `max_compound_nesting_depth`, and `estimated_size` are never used [INFO] [stdout] --> src/algo/fcose/mod.rs:1157:8 [INFO] [stdout] | [INFO] [stdout] 818 | impl SimGraph { [INFO] [stdout] | ------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 1157 | fn bounding_box_center_nodes_with_extras(&self) -> Option<(f64, f64)> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1543 | fn bounding_box_center_leaves(&self) -> Option<(f64, f64)> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1650 | fn max_compound_nesting_depth(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2529 | fn estimated_size(&self) -> f64 { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `left` and `top` are never read [INFO] [stdout] --> src/algo/fcose/mod.rs:4285:5 [INFO] [stdout] | [INFO] [stdout] 4284 | struct RepulsionGrid { [INFO] [stdout] | ------------- fields in this struct [INFO] [stdout] 4285 | left: f64, [INFO] [stdout] | ^^^^ [INFO] [stdout] 4286 | top: f64, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `RepulsionGrid` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `sig_diag` [INFO] [stdout] --> src/algo/fcose/spectral.rs:625:14 [INFO] [stdout] | [INFO] [stdout] 625 | for i in 0..n { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 625 - for i in 0..n { [INFO] [stdout] 625 + for (i, ) in sig_diag.iter_mut().enumerate().take(n) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `inv` [INFO] [stdout] --> src/algo/fcose/spectral.rs:637:14 [INFO] [stdout] | [INFO] [stdout] 637 | for i in 0..n { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 637 - for i in 0..n { [INFO] [stdout] 637 + for (i, ) in inv.iter_mut().enumerate().take(n) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is used to index `inv` [INFO] [stdout] --> src/algo/fcose/spectral.rs:638:18 [INFO] [stdout] | [INFO] [stdout] 638 | for j in 0..n { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 638 - for j in 0..n { [INFO] [stdout] 638 + for (j, ) in inv.iter_mut().enumerate().take(n) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `k` is used to index `sig_diag` [INFO] [stdout] --> src/algo/fcose/spectral.rs:640:22 [INFO] [stdout] | [INFO] [stdout] 640 | for k in 0..n { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 640 - for k in 0..n { [INFO] [stdout] 640 + for (k, ) in sig_diag.iter().enumerate().take(n) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `(n.saturating_sub(2)).min(m)` is never smaller than `0` and has therefore no effect [INFO] [stdout] --> src/algo/fcose/spectral.rs:888:15 [INFO] [stdout] | [INFO] [stdout] 888 | let nrt = (n.saturating_sub(2)).min(m).max(0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(n.saturating_sub(2)).min(m)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_min_or_max [INFO] [stdout] = note: `#[warn(clippy::unnecessary_min_or_max)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `a` [INFO] [stdout] --> src/algo/fcose/spectral.rs:894:22 [INFO] [stdout] | [INFO] [stdout] 894 | for i in k..m { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 894 - for i in k..m { [INFO] [stdout] 894 + for in a.iter().take(m).skip(k) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `a` [INFO] [stdout] --> src/algo/fcose/spectral.rs:901:26 [INFO] [stdout] | [INFO] [stdout] 901 | for i in k..m { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 901 - for i in k..m { [INFO] [stdout] 901 + for in a.iter_mut().take(m).skip(k) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `a` [INFO] [stdout] --> src/algo/fcose/spectral.rs:912:26 [INFO] [stdout] | [INFO] [stdout] 912 | for i in k..m { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 912 - for i in k..m { [INFO] [stdout] 912 + for in a.iter().take(m).skip(k) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `a` [INFO] [stdout] --> src/algo/fcose/spectral.rs:916:26 [INFO] [stdout] | [INFO] [stdout] 916 | for i in k..m { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 916 - for i in k..m { [INFO] [stdout] 916 + for in a.iter_mut().take(m).skip(k) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `work` [INFO] [stdout] --> src/algo/fcose/spectral.rs:946:26 [INFO] [stdout] | [INFO] [stdout] 946 | for i in (k + 1)..m { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 946 - for i in (k + 1)..m { [INFO] [stdout] 946 + for in work.iter_mut().take(m).skip((k + 1)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is used to index `u` [INFO] [stdout] --> src/algo/fcose/spectral.rs:983:18 [INFO] [stdout] | [INFO] [stdout] 983 | for j in nct..nu { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 983 - for j in nct..nu { [INFO] [stdout] 983 + for (j, ) in u.iter_mut().enumerate().take(nu).skip(nct) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `u` [INFO] [stdout] --> src/algo/fcose/spectral.rs:984:22 [INFO] [stdout] | [INFO] [stdout] 984 | for i in 0..m { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 984 - for i in 0..m { [INFO] [stdout] 984 + for in u.iter_mut().take(m) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `u` [INFO] [stdout] --> src/algo/fcose/spectral.rs:996:30 [INFO] [stdout] | [INFO] [stdout] 996 | for i in kk..m { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 996 - for i in kk..m { [INFO] [stdout] 996 + for in u.iter().take(m).skip(kk) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `u` [INFO] [stdout] --> src/algo/fcose/spectral.rs:1000:30 [INFO] [stdout] | [INFO] [stdout] 1000 | for i in kk..m { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 1000 - for i in kk..m { [INFO] [stdout] 1000 + for in u.iter_mut().take(m).skip(kk) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `u` [INFO] [stdout] --> src/algo/fcose/spectral.rs:1004:26 [INFO] [stdout] | [INFO] [stdout] 1004 | for i in kk..m { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 1004 - for i in kk..m { [INFO] [stdout] 1004 + for in u.iter_mut().take(m).skip(kk) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/algo/fcose/spectral.rs:1007:17 [INFO] [stdout] | [INFO] [stdout] 1007 | u[kk][kk] = 1.0 + u[kk][kk]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `u[kk][kk] += 1.0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `u` [INFO] [stdout] --> src/algo/fcose/spectral.rs:1008:26 [INFO] [stdout] | [INFO] [stdout] 1008 | for i in 0..kk.saturating_sub(1) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 1008 - for i in 0..kk.saturating_sub(1) { [INFO] [stdout] 1008 + for in u.iter_mut().take(kk.saturating_sub(1)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `u` [INFO] [stdout] --> src/algo/fcose/spectral.rs:1012:26 [INFO] [stdout] | [INFO] [stdout] 1012 | for i in 0..m { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 1012 - for i in 0..m { [INFO] [stdout] 1012 + for in u.iter_mut().take(m) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `v` [INFO] [stdout] --> src/algo/fcose/spectral.rs:1028:30 [INFO] [stdout] | [INFO] [stdout] 1028 | for i in (kk + 1)..n { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 1028 - for i in (kk + 1)..n { [INFO] [stdout] 1028 + for in v.iter().take(n).skip((kk + 1)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `v` [INFO] [stdout] --> src/algo/fcose/spectral.rs:1032:30 [INFO] [stdout] | [INFO] [stdout] 1032 | for i in (kk + 1)..n { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 1032 - for i in (kk + 1)..n { [INFO] [stdout] 1032 + for in v.iter_mut().take(n).skip((kk + 1)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `v` [INFO] [stdout] --> src/algo/fcose/spectral.rs:1037:22 [INFO] [stdout] | [INFO] [stdout] 1037 | for i in 0..n { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 1037 - for i in 0..n { [INFO] [stdout] 1037 + for in v.iter_mut().take(n) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/algo/fcose/spectral.rs:1111:25 [INFO] [stdout] | [INFO] [stdout] 1111 | e[(j - 1) as usize] = cs * e[(j - 1) as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `e[(j - 1) as usize] *= cs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `v` [INFO] [stdout] --> src/algo/fcose/spectral.rs:1114:34 [INFO] [stdout] | [INFO] [stdout] 1114 | for i in 0..n { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 1114 - for i in 0..n { [INFO] [stdout] 1114 + for in v.iter_mut().take(n) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/algo/fcose/spectral.rs:1135:21 [INFO] [stdout] | [INFO] [stdout] 1135 | e[ju] = cs * e[ju]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `e[ju] *= cs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `u` [INFO] [stdout] --> src/algo/fcose/spectral.rs:1137:34 [INFO] [stdout] | [INFO] [stdout] 1137 | for i in 0..m { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 1137 - for i in 0..m { [INFO] [stdout] 1137 + for in u.iter_mut().take(m) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/algo/fcose/spectral.rs:1183:21 [INFO] [stdout] | [INFO] [stdout] 1183 | s[ju + 1] = cs * s[ju + 1]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `s[ju + 1] *= cs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `v` [INFO] [stdout] --> src/algo/fcose/spectral.rs:1185:34 [INFO] [stdout] | [INFO] [stdout] 1185 | for i in 0..n { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 1185 - for i in 0..n { [INFO] [stdout] 1185 + for in v.iter_mut().take(n) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/algo/fcose/spectral.rs:1199:21 [INFO] [stdout] | [INFO] [stdout] 1199 | e[ju + 1] = cs * e[ju + 1]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `e[ju + 1] *= cs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `u` [INFO] [stdout] --> src/algo/fcose/spectral.rs:1201:34 [INFO] [stdout] | [INFO] [stdout] 1201 | for i in 0..m { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 1201 - for i in 0..m { [INFO] [stdout] 1201 + for in u.iter_mut().take(m) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `v` [INFO] [stdout] --> src/algo/fcose/spectral.rs:1217:34 [INFO] [stdout] | [INFO] [stdout] 1217 | for i in 0..=pp.max(0) as usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 1217 - for i in 0..=pp.max(0) as usize { [INFO] [stdout] 1217 + for in v.iter_mut().take(pp.max(0) as usize + 1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `v` [INFO] [stdout] --> src/algo/fcose/spectral.rs:1229:34 [INFO] [stdout] | [INFO] [stdout] 1229 | for i in 0..n { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 1229 - for i in 0..n { [INFO] [stdout] 1229 + for in v.iter_mut().take(n) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this looks like you are swapping elements of `v[i]` manually [INFO] [stdout] --> src/algo/fcose/spectral.rs:1230:29 [INFO] [stdout] | [INFO] [stdout] 1230 | / ... let t = v[i][ku + 1]; [INFO] [stdout] 1231 | | ... v[i][ku + 1] = v[i][ku]; [INFO] [stdout] 1232 | | ... v[i][ku] = t; [INFO] [stdout] | |___________________________________^ help: try: `v[i].swap(ku + 1, ku);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stdout] = note: `#[warn(clippy::manual_swap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `u` [INFO] [stdout] --> src/algo/fcose/spectral.rs:1236:34 [INFO] [stdout] | [INFO] [stdout] 1236 | for i in 0..m { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 1236 - for i in 0..m { [INFO] [stdout] 1236 + for in u.iter_mut().take(m) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this looks like you are swapping elements of `u[i]` manually [INFO] [stdout] --> src/algo/fcose/spectral.rs:1237:29 [INFO] [stdout] | [INFO] [stdout] 1237 | / ... let t = u[i][ku + 1]; [INFO] [stdout] 1238 | | ... u[i][ku + 1] = u[i][ku]; [INFO] [stdout] 1239 | | ... u[i][ku] = t; [INFO] [stdout] | |___________________________________^ help: try: `u[i].swap(ku + 1, ku);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/algo/fcose/mod.rs:681:21 [INFO] [stdout] | [INFO] [stdout] 681 | let start = (2 * len + 2) / 3; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `(2 * len).div_ceil(3)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `inclusion_depth` [INFO] [stdout] --> src/algo/fcose/mod.rs:1021:18 [INFO] [stdout] | [INFO] [stdout] 1021 | for i in 0..nodes.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 1021 - for i in 0..nodes.len() { [INFO] [stdout] 1021 + for (i, ) in inclusion_depth.iter_mut().enumerate().take(nodes.len()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/algo/fcose/mod.rs:1909:12 [INFO] [stdout] | [INFO] [stdout] 1909 | if !disable_pre [INFO] [stdout] | ____________^ [INFO] [stdout] 1910 | | && !(constraints.align_horizontal.is_empty() [INFO] [stdout] 1911 | | && constraints.align_vertical.is_empty() [INFO] [stdout] 1912 | | && constraints.relative.is_empty()) [INFO] [stdout] | |___________________________________________________^ help: try: `!(disable_pre || constraints.align_horizontal.is_empty() && constraints.align_vertical.is_empty() && constraints.relative.is_empty())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `nodes` [INFO] [stdout] --> src/algo/fcose/mod.rs:1749:22 [INFO] [stdout] | [INFO] [stdout] 1749 | for i in 0..n { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 1749 - for i in 0..n { [INFO] [stdout] 1749 + for in nodes.iter().take(n) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `c` [INFO] [stdout] --> src/algo/fcose/spectral.rs:88:14 [INFO] [stdout] | [INFO] [stdout] 88 | for i in 0..node_size { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 88 - for i in 0..node_size { [INFO] [stdout] 88 + for in c.iter_mut().take(node_size) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is only used to index `c` [INFO] [stdout] --> src/algo/fcose/spectral.rs:89:18 [INFO] [stdout] | [INFO] [stdout] 89 | for j in 0..sample_size { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 89 - for j in 0..sample_size { [INFO] [stdout] 89 + for in c.iter_mut().take(sample_size) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/algo/fcose/mod.rs:2193:17 [INFO] [stdout] | [INFO] [stdout] 2193 | / if estimated.is_finite() && estimated > 0.0 { [INFO] [stdout] 2194 | | if abs_dx > estimated || abs_dy > estimated { [INFO] [stdout] 2195 | | n.gravitation_fx = -gravity_constant * dx * compound_mul; [INFO] [stdout] 2196 | | n.gravitation_fy = -gravity_constant * dy * compound_mul; [INFO] [stdout] 2197 | | } [INFO] [stdout] 2198 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 2193 ~ if estimated.is_finite() && estimated > 0.0 [INFO] [stdout] 2194 ~ && (abs_dx > estimated || abs_dy > estimated) { [INFO] [stdout] 2195 | n.gravitation_fx = -gravity_constant * dx * compound_mul; [INFO] [stdout] 2196 | n.gravitation_fy = -gravity_constant * dy * compound_mul; [INFO] [stdout] 2197 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `child_ix` is used to index `compound_parent_ix` [INFO] [stdout] --> src/algo/fcose/spectral.rs:228:21 [INFO] [stdout] | [INFO] [stdout] 228 | for child_ix in 0..compound_ids.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 228 - for child_ix in 0..compound_ids.len() { [INFO] [stdout] 228 + for (child_ix, ) in compound_parent_ix.iter().enumerate().take(compound_ids.len()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: derefed type is same as origin [INFO] [stdout] --> src/algo/fcose/mod.rs:2346:38 [INFO] [stdout] | [INFO] [stdout] 2346 | if let (Some(t), Some(s)) = (timings.as_deref_mut(), iterations_start) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `timings` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_option_as_deref [INFO] [stdout] = note: `#[warn(clippy::needless_option_as_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `owner` is used to index `connected` [INFO] [stdout] --> src/algo/fcose/mod.rs:2382:22 [INFO] [stdout] | [INFO] [stdout] 2382 | for owner in 0..owner_count { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 2382 - for owner in 0..owner_count { [INFO] [stdout] 2382 + for (owner, ) in connected.iter_mut().enumerate().take(owner_count) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `leaf` is used to index `leaf_immediate_parent` [INFO] [stdout] --> src/algo/fcose/spectral.rs:340:21 [INFO] [stdout] | [INFO] [stdout] 340 | for leaf in 0..n_real { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 340 - for leaf in 0..n_real { [INFO] [stdout] 340 + for (leaf, ) in leaf_immediate_parent.iter().enumerate().take(n_real) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `leaf` is used to index `leaf_immediate_parent` [INFO] [stdout] --> src/algo/fcose/spectral.rs:375:21 [INFO] [stdout] | [INFO] [stdout] 375 | for leaf in 0..n_real { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 375 - for leaf in 0..n_real { [INFO] [stdout] 375 + for (leaf, ) in leaf_immediate_parent.iter().enumerate().take(n_real) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `contains()` instead of `iter().any()` is more efficient [INFO] [stdout] --> src/algo/fcose/spectral.rs:394:42 [INFO] [stdout] | [INFO] [stdout] 394 | .is_some_and(|chain| chain.iter().any(|&c| c == scope_cix)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `chain.contains(&scope_cix)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_contains [INFO] [stdout] = note: `#[warn(clippy::manual_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `sig_diag` [INFO] [stdout] --> src/algo/fcose/spectral.rs:625:14 [INFO] [stdout] | [INFO] [stdout] 625 | for i in 0..n { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 625 - for i in 0..n { [INFO] [stdout] 625 + for (i, ) in sig_diag.iter_mut().enumerate().take(n) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `inv` [INFO] [stdout] --> src/algo/fcose/spectral.rs:637:14 [INFO] [stdout] | [INFO] [stdout] 637 | for i in 0..n { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 637 - for i in 0..n { [INFO] [stdout] 637 + for (i, ) in inv.iter_mut().enumerate().take(n) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is used to index `inv` [INFO] [stdout] --> src/algo/fcose/spectral.rs:638:18 [INFO] [stdout] | [INFO] [stdout] 638 | for j in 0..n { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 638 - for j in 0..n { [INFO] [stdout] 638 + for (j, ) in inv.iter_mut().enumerate().take(n) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `k` is used to index `sig_diag` [INFO] [stdout] --> src/algo/fcose/spectral.rs:640:22 [INFO] [stdout] | [INFO] [stdout] 640 | for k in 0..n { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 640 - for k in 0..n { [INFO] [stdout] 640 + for (k, ) in sig_diag.iter().enumerate().take(n) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `(n.saturating_sub(2)).min(m)` is never smaller than `0` and has therefore no effect [INFO] [stdout] --> src/algo/fcose/spectral.rs:888:15 [INFO] [stdout] | [INFO] [stdout] 888 | let nrt = (n.saturating_sub(2)).min(m).max(0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(n.saturating_sub(2)).min(m)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_min_or_max [INFO] [stdout] = note: `#[warn(clippy::unnecessary_min_or_max)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `a` [INFO] [stdout] --> src/algo/fcose/spectral.rs:894:22 [INFO] [stdout] | [INFO] [stdout] 894 | for i in k..m { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 894 - for i in k..m { [INFO] [stdout] 894 + for in a.iter().take(m).skip(k) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `a` [INFO] [stdout] --> src/algo/fcose/spectral.rs:901:26 [INFO] [stdout] | [INFO] [stdout] 901 | for i in k..m { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 901 - for i in k..m { [INFO] [stdout] 901 + for in a.iter_mut().take(m).skip(k) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `a` [INFO] [stdout] --> src/algo/fcose/spectral.rs:912:26 [INFO] [stdout] | [INFO] [stdout] 912 | for i in k..m { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 912 - for i in k..m { [INFO] [stdout] 912 + for in a.iter().take(m).skip(k) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `a` [INFO] [stdout] --> src/algo/fcose/spectral.rs:916:26 [INFO] [stdout] | [INFO] [stdout] 916 | for i in k..m { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 916 - for i in k..m { [INFO] [stdout] 916 + for in a.iter_mut().take(m).skip(k) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `work` [INFO] [stdout] --> src/algo/fcose/spectral.rs:946:26 [INFO] [stdout] | [INFO] [stdout] 946 | for i in (k + 1)..m { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 946 - for i in (k + 1)..m { [INFO] [stdout] 946 + for in work.iter_mut().take(m).skip((k + 1)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is used to index `u` [INFO] [stdout] --> src/algo/fcose/spectral.rs:983:18 [INFO] [stdout] | [INFO] [stdout] 983 | for j in nct..nu { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 983 - for j in nct..nu { [INFO] [stdout] 983 + for (j, ) in u.iter_mut().enumerate().take(nu).skip(nct) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `u` [INFO] [stdout] --> src/algo/fcose/spectral.rs:984:22 [INFO] [stdout] | [INFO] [stdout] 984 | for i in 0..m { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 984 - for i in 0..m { [INFO] [stdout] 984 + for in u.iter_mut().take(m) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `u` [INFO] [stdout] --> src/algo/fcose/spectral.rs:996:30 [INFO] [stdout] | [INFO] [stdout] 996 | for i in kk..m { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 996 - for i in kk..m { [INFO] [stdout] 996 + for in u.iter().take(m).skip(kk) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `u` [INFO] [stdout] --> src/algo/fcose/spectral.rs:1000:30 [INFO] [stdout] | [INFO] [stdout] 1000 | for i in kk..m { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 1000 - for i in kk..m { [INFO] [stdout] 1000 + for in u.iter_mut().take(m).skip(kk) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `u` [INFO] [stdout] --> src/algo/fcose/spectral.rs:1004:26 [INFO] [stdout] | [INFO] [stdout] 1004 | for i in kk..m { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 1004 - for i in kk..m { [INFO] [stdout] 1004 + for in u.iter_mut().take(m).skip(kk) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/algo/fcose/spectral.rs:1007:17 [INFO] [stdout] | [INFO] [stdout] 1007 | u[kk][kk] = 1.0 + u[kk][kk]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `u[kk][kk] += 1.0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `u` [INFO] [stdout] --> src/algo/fcose/spectral.rs:1008:26 [INFO] [stdout] | [INFO] [stdout] 1008 | for i in 0..kk.saturating_sub(1) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 1008 - for i in 0..kk.saturating_sub(1) { [INFO] [stdout] 1008 + for in u.iter_mut().take(kk.saturating_sub(1)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `u` [INFO] [stdout] --> src/algo/fcose/spectral.rs:1012:26 [INFO] [stdout] | [INFO] [stdout] 1012 | for i in 0..m { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 1012 - for i in 0..m { [INFO] [stdout] 1012 + for in u.iter_mut().take(m) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `v` [INFO] [stdout] --> src/algo/fcose/spectral.rs:1028:30 [INFO] [stdout] | [INFO] [stdout] 1028 | for i in (kk + 1)..n { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 1028 - for i in (kk + 1)..n { [INFO] [stdout] 1028 + for in v.iter().take(n).skip((kk + 1)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `v` [INFO] [stdout] --> src/algo/fcose/spectral.rs:1032:30 [INFO] [stdout] | [INFO] [stdout] 1032 | for i in (kk + 1)..n { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 1032 - for i in (kk + 1)..n { [INFO] [stdout] 1032 + for in v.iter_mut().take(n).skip((kk + 1)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `v` [INFO] [stdout] --> src/algo/fcose/spectral.rs:1037:22 [INFO] [stdout] | [INFO] [stdout] 1037 | for i in 0..n { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 1037 - for i in 0..n { [INFO] [stdout] 1037 + for in v.iter_mut().take(n) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/algo/fcose/spectral.rs:1111:25 [INFO] [stdout] | [INFO] [stdout] 1111 | e[(j - 1) as usize] = cs * e[(j - 1) as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `e[(j - 1) as usize] *= cs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `v` [INFO] [stdout] --> src/algo/fcose/spectral.rs:1114:34 [INFO] [stdout] | [INFO] [stdout] 1114 | for i in 0..n { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 1114 - for i in 0..n { [INFO] [stdout] 1114 + for in v.iter_mut().take(n) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/algo/fcose/spectral.rs:1135:21 [INFO] [stdout] | [INFO] [stdout] 1135 | e[ju] = cs * e[ju]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `e[ju] *= cs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `u` [INFO] [stdout] --> src/algo/fcose/spectral.rs:1137:34 [INFO] [stdout] | [INFO] [stdout] 1137 | for i in 0..m { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 1137 - for i in 0..m { [INFO] [stdout] 1137 + for in u.iter_mut().take(m) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/algo/fcose/spectral.rs:1183:21 [INFO] [stdout] | [INFO] [stdout] 1183 | s[ju + 1] = cs * s[ju + 1]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `s[ju + 1] *= cs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `v` [INFO] [stdout] --> src/algo/fcose/spectral.rs:1185:34 [INFO] [stdout] | [INFO] [stdout] 1185 | for i in 0..n { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 1185 - for i in 0..n { [INFO] [stdout] 1185 + for in v.iter_mut().take(n) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/algo/fcose/spectral.rs:1199:21 [INFO] [stdout] | [INFO] [stdout] 1199 | e[ju + 1] = cs * e[ju + 1]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `e[ju + 1] *= cs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `u` [INFO] [stdout] --> src/algo/fcose/spectral.rs:1201:34 [INFO] [stdout] | [INFO] [stdout] 1201 | for i in 0..m { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 1201 - for i in 0..m { [INFO] [stdout] 1201 + for in u.iter_mut().take(m) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `v` [INFO] [stdout] --> src/algo/fcose/spectral.rs:1217:34 [INFO] [stdout] | [INFO] [stdout] 1217 | for i in 0..=pp.max(0) as usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 1217 - for i in 0..=pp.max(0) as usize { [INFO] [stdout] 1217 + for in v.iter_mut().take(pp.max(0) as usize + 1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `v` [INFO] [stdout] --> src/algo/fcose/spectral.rs:1229:34 [INFO] [stdout] | [INFO] [stdout] 1229 | for i in 0..n { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 1229 - for i in 0..n { [INFO] [stdout] 1229 + for in v.iter_mut().take(n) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this looks like you are swapping elements of `v[i]` manually [INFO] [stdout] --> src/algo/fcose/spectral.rs:1230:29 [INFO] [stdout] | [INFO] [stdout] 1230 | / ... let t = v[i][ku + 1]; [INFO] [stdout] 1231 | | ... v[i][ku + 1] = v[i][ku]; [INFO] [stdout] 1232 | | ... v[i][ku] = t; [INFO] [stdout] | |___________________________________^ help: try: `v[i].swap(ku + 1, ku);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stdout] = note: `#[warn(clippy::manual_swap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `u` [INFO] [stdout] --> src/algo/fcose/spectral.rs:1236:34 [INFO] [stdout] | [INFO] [stdout] 1236 | for i in 0..m { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 1236 - for i in 0..m { [INFO] [stdout] 1236 + for in u.iter_mut().take(m) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this looks like you are swapping elements of `u[i]` manually [INFO] [stdout] --> src/algo/fcose/spectral.rs:1237:29 [INFO] [stdout] | [INFO] [stdout] 1237 | / ... let t = u[i][ku + 1]; [INFO] [stdout] 1238 | | ... u[i][ku + 1] = u[i][ku]; [INFO] [stdout] 1239 | | ... u[i][ku] = t; [INFO] [stdout] | |___________________________________^ help: try: `u[i].swap(ku + 1, ku);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/algo/fcose/mod.rs:681:21 [INFO] [stdout] | [INFO] [stdout] 681 | let start = (2 * len + 2) / 3; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `(2 * len).div_ceil(3)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `inclusion_depth` [INFO] [stdout] --> src/algo/fcose/mod.rs:1021:18 [INFO] [stdout] | [INFO] [stdout] 1021 | for i in 0..nodes.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 1021 - for i in 0..nodes.len() { [INFO] [stdout] 1021 + for (i, ) in inclusion_depth.iter_mut().enumerate().take(nodes.len()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/algo/fcose/mod.rs:1909:12 [INFO] [stdout] | [INFO] [stdout] 1909 | if !disable_pre [INFO] [stdout] | ____________^ [INFO] [stdout] 1910 | | && !(constraints.align_horizontal.is_empty() [INFO] [stdout] 1911 | | && constraints.align_vertical.is_empty() [INFO] [stdout] 1912 | | && constraints.relative.is_empty()) [INFO] [stdout] | |___________________________________________________^ help: try: `!(disable_pre || constraints.align_horizontal.is_empty() && constraints.align_vertical.is_empty() && constraints.relative.is_empty())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `nodes` [INFO] [stdout] --> src/algo/fcose/mod.rs:1749:22 [INFO] [stdout] | [INFO] [stdout] 1749 | for i in 0..n { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 1749 - for i in 0..n { [INFO] [stdout] 1749 + for in nodes.iter().take(n) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/algo/fcose/mod.rs:2193:17 [INFO] [stdout] | [INFO] [stdout] 2193 | / if estimated.is_finite() && estimated > 0.0 { [INFO] [stdout] 2194 | | if abs_dx > estimated || abs_dy > estimated { [INFO] [stdout] 2195 | | n.gravitation_fx = -gravity_constant * dx * compound_mul; [INFO] [stdout] 2196 | | n.gravitation_fy = -gravity_constant * dy * compound_mul; [INFO] [stdout] 2197 | | } [INFO] [stdout] 2198 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 2193 ~ if estimated.is_finite() && estimated > 0.0 [INFO] [stdout] 2194 ~ && (abs_dx > estimated || abs_dy > estimated) { [INFO] [stdout] 2195 | n.gravitation_fx = -gravity_constant * dx * compound_mul; [INFO] [stdout] 2196 | n.gravitation_fy = -gravity_constant * dy * compound_mul; [INFO] [stdout] 2197 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: derefed type is same as origin [INFO] [stdout] --> src/algo/fcose/mod.rs:2346:38 [INFO] [stdout] | [INFO] [stdout] 2346 | if let (Some(t), Some(s)) = (timings.as_deref_mut(), iterations_start) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `timings` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_option_as_deref [INFO] [stdout] = note: `#[warn(clippy::needless_option_as_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `owner` is used to index `connected` [INFO] [stdout] --> src/algo/fcose/mod.rs:2382:22 [INFO] [stdout] | [INFO] [stdout] 2382 | for owner in 0..owner_count { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 2382 - for owner in 0..owner_count { [INFO] [stdout] 2382 + for (owner, ) in connected.iter_mut().enumerate().take(owner_count) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 17.14s [INFO] running `Command { std: "docker" "inspect" "5b820cc5679677707caff785ba228937f6088badb757780dd2731f2883b1d5ea", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5b820cc5679677707caff785ba228937f6088badb757780dd2731f2883b1d5ea", kill_on_drop: false }` [INFO] [stdout] 5b820cc5679677707caff785ba228937f6088badb757780dd2731f2883b1d5ea