[INFO] fetching crate mai 0.1.0... [INFO] linting mai-0.1.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate mai 0.1.0 into /workspace/builds/worker-5-tc1/source [INFO] started tweaking crates.io crate mai 0.1.0 [INFO] finished tweaking crates.io crate mai 0.1.0 [INFO] tweaked toml for crates.io crate mai 0.1.0 written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate mai 0.1.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 21 packages to latest compatible versions [INFO] [stderr] Adding lifeguard v0.5.2 (available: v0.6.1) [INFO] [stderr] Adding log v0.3.9 (available: v0.4.29) [INFO] [stderr] Adding mio v0.5.1 (available: v1.1.1) [INFO] [stderr] Adding slab v0.1.3 (available: v0.4.12) [INFO] [stderr] Adding wasi v0.10.0+wasi-snapshot-preview1 (available: v0.10.2+wasi-snapshot-preview1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded bytes v0.3.0 [INFO] [stderr] Downloaded mio v0.5.1 [INFO] [stderr] Downloaded miow v0.1.5 [INFO] [stderr] Downloaded lifeguard v0.5.2 [INFO] [stderr] Downloaded nix v0.5.1 [INFO] [stderr] Downloaded bitflags v0.4.0 [INFO] [stderr] Downloaded slab v0.1.3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 195a8246b6e8ec38ed0f674c952585762dfe3aed73ec17cb35fc9d8134361417 [INFO] running `Command { std: "docker" "start" "-a" "195a8246b6e8ec38ed0f674c952585762dfe3aed73ec17cb35fc9d8134361417", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "195a8246b6e8ec38ed0f674c952585762dfe3aed73ec17cb35fc9d8134361417", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "195a8246b6e8ec38ed0f674c952585762dfe3aed73ec17cb35fc9d8134361417", kill_on_drop: false }` [INFO] [stdout] 195a8246b6e8ec38ed0f674c952585762dfe3aed73ec17cb35fc9d8134361417 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 10fa12baf796db50663cd3939a25cc7334685d25363f2e267f30c4892ce4c072 [INFO] running `Command { std: "docker" "start" "-a" "10fa12baf796db50663cd3939a25cc7334685d25363f2e267f30c4892ce4c072", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Compiling winapi-build v0.1.1 [INFO] [stderr] Checking winapi v0.2.8 [INFO] [stderr] Checking bitflags v0.4.0 [INFO] [stderr] Checking bytes v0.3.0 [INFO] [stderr] Checking slab v0.1.3 [INFO] [stderr] Checking lifeguard v0.5.2 [INFO] [stderr] Checking net2 v0.2.39 [INFO] [stderr] Checking nix v0.5.1 [INFO] [stderr] Compiling kernel32-sys v0.2.2 [INFO] [stderr] Compiling ws2_32-sys v0.2.1 [INFO] [stderr] Checking miow v0.1.5 [INFO] [stderr] Checking mio v0.5.1 [INFO] [stderr] Checking mai v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/evented_frame_stream.rs:211:7 [INFO] [stdout] | [INFO] [stdout] 211 | try!(self.register_interest_in_writing(event_loop, token)) [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/protocol_engine.rs:254:7 [INFO] [stdout] | [INFO] [stdout] 254 | buffer_pool: buffer_pool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `buffer_pool` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/protocol_engine.rs:255:7 [INFO] [stdout] | [INFO] [stdout] 255 | outbox_pool: outbox_pool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `outbox_pool` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/protocol_engine.rs:256:7 [INFO] [stdout] | [INFO] [stdout] 256 | handler: handler, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `handler` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/protocol_engine.rs:257:7 [INFO] [stdout] | [INFO] [stdout] 257 | command_sender: command_sender [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `command_sender` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/codec.rs:41:7 [INFO] [stdout] | [INFO] [stdout] 41 | frame: frame, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `frame` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/codec.rs:42:7 [INFO] [stdout] | [INFO] [stdout] 42 | bytes_read: bytes_read [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bytes_read` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/codec.rs:54:35 [INFO] [stdout] | [INFO] [stdout] 54 | fn encode(&mut self, frame: &F, &mut [u8]) -> EncodingResult; [INFO] [stdout] | ^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: &mut [u8]` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(anonymous_parameters)]` (part of `#[warn(rust_2018_compatibility)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/codec.rs:55:24 [INFO] [stdout] | [INFO] [stdout] 55 | fn decode(&mut self, &[u8]) -> DecodingResult; [INFO] [stdout] | ^^^^^ help: try naming the parameter or explicitly ignoring it: `_: &[u8]` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/buffer.rs:39:7 [INFO] [stdout] | [INFO] [stdout] 39 | bytes: bytes, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/evented_byte_stream.rs:7:34 [INFO] [stdout] | [INFO] [stdout] 7 | fn read_into_buffer(&mut self, &mut Buffer) -> io::Result; [INFO] [stdout] | ^^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: &mut Buffer` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/evented_byte_stream.rs:8:35 [INFO] [stdout] | [INFO] [stdout] 8 | fn write_from_buffer(&mut self, &mut Buffer) -> io::Result; [INFO] [stdout] | ^^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: &mut Buffer` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/evented_frame_stream.rs:211:7 [INFO] [stdout] | [INFO] [stdout] 211 | try!(self.register_interest_in_writing(event_loop, token)) [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/context.rs:53:15 [INFO] [stdout] | [INFO] [stdout] 53 | event_loop: event_loop, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `event_loop` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/context.rs:54:15 [INFO] [stdout] | [INFO] [stdout] 54 | command_sender: command_sender [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `command_sender` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/context.rs:124:7 [INFO] [stdout] | [INFO] [stdout] 124 | event_loop: event_loop, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `event_loop` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/context.rs:125:7 [INFO] [stdout] | [INFO] [stdout] 125 | efs: efs, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `efs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/context.rs:126:7 [INFO] [stdout] | [INFO] [stdout] 126 | session: session, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `session` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/context.rs:127:7 [INFO] [stdout] | [INFO] [stdout] 127 | token: token, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `token` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/context.rs:128:7 [INFO] [stdout] | [INFO] [stdout] 128 | outbox_pool: outbox_pool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `outbox_pool` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/context.rs:129:7 [INFO] [stdout] | [INFO] [stdout] 129 | command_sender: command_sender [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `command_sender` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/context.rs:140:9 [INFO] [stdout] | [INFO] [stdout] 140 | event_loop: event_loop, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `event_loop` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/context.rs:141:9 [INFO] [stdout] | [INFO] [stdout] 141 | command_sender: command_sender [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `command_sender` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/context.rs:155:9 [INFO] [stdout] | [INFO] [stdout] 155 | event_loop: event_loop, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `event_loop` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/context.rs:156:9 [INFO] [stdout] | [INFO] [stdout] 156 | efs: efs, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `efs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/context.rs:157:9 [INFO] [stdout] | [INFO] [stdout] 157 | token: token, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `token` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/context.rs:158:9 [INFO] [stdout] | [INFO] [stdout] 158 | outbox_pool: outbox_pool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `outbox_pool` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/context.rs:159:9 [INFO] [stdout] | [INFO] [stdout] 159 | command_sender: command_sender [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `command_sender` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/context.rs:174:7 [INFO] [stdout] | [INFO] [stdout] 174 | event_loop: event_loop, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `event_loop` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/context.rs:175:7 [INFO] [stdout] | [INFO] [stdout] 175 | efs: efs, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `efs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/context.rs:176:7 [INFO] [stdout] | [INFO] [stdout] 176 | token: token, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `token` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/context.rs:177:7 [INFO] [stdout] | [INFO] [stdout] 177 | outbox_pool: outbox_pool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `outbox_pool` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/context.rs:178:7 [INFO] [stdout] | [INFO] [stdout] 178 | command_sender: command_sender [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `command_sender` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/remote.rs:19:7 [INFO] [stdout] | [INFO] [stdout] 19 | command_sender: command_sender, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `command_sender` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/remote.rs:20:7 [INFO] [stdout] | [INFO] [stdout] 20 | receiver: receiver [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `receiver` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/timeout.rs:14:11 [INFO] [stdout] | [INFO] [stdout] 14 | data: data [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/timeout.rs:21:11 [INFO] [stdout] | [INFO] [stdout] 21 | data: data [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/protocol_engine.rs:254:7 [INFO] [stdout] | [INFO] [stdout] 254 | buffer_pool: buffer_pool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `buffer_pool` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/protocol_engine.rs:255:7 [INFO] [stdout] | [INFO] [stdout] 255 | outbox_pool: outbox_pool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `outbox_pool` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/protocol_engine.rs:256:7 [INFO] [stdout] | [INFO] [stdout] 256 | handler: handler, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `handler` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/settings.rs:5:23 [INFO] [stdout] | [INFO] [stdout] 5 | fn set_option(self, T) -> T; [INFO] [stdout] | ^ help: try naming the parameter or explicitly ignoring it: `_: T` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/protocol_engine.rs:257:7 [INFO] [stdout] | [INFO] [stdout] 257 | command_sender: command_sender [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `command_sender` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/stream_id.rs:12:7 [INFO] [stdout] | [INFO] [stdout] 12 | id: id, [INFO] [stdout] | ^^^^^^ help: replace it with: `id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/stream_id.rs:13:7 [INFO] [stdout] | [INFO] [stdout] 13 | token: token [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `token` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/stream_session.rs:12:13 [INFO] [stdout] | [INFO] [stdout] 12 | efs: efs, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `efs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/stream_session.rs:13:13 [INFO] [stdout] | [INFO] [stdout] 13 | session: session [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `session` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:50:5 [INFO] [stdout] | [INFO] [stdout] 50 | handler: handler, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `handler` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/codec.rs:41:7 [INFO] [stdout] | [INFO] [stdout] 41 | frame: frame, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `frame` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/codec.rs:42:7 [INFO] [stdout] | [INFO] [stdout] 42 | bytes_read: bytes_read [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bytes_read` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/codec.rs:54:35 [INFO] [stdout] | [INFO] [stdout] 54 | fn encode(&mut self, frame: &F, &mut [u8]) -> EncodingResult; [INFO] [stdout] | ^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: &mut [u8]` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(anonymous_parameters)]` (part of `#[warn(rust_2018_compatibility)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/codec.rs:55:24 [INFO] [stdout] | [INFO] [stdout] 55 | fn decode(&mut self, &[u8]) -> DecodingResult; [INFO] [stdout] | ^^^^^ help: try naming the parameter or explicitly ignoring it: `_: &[u8]` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/buffer.rs:39:7 [INFO] [stdout] | [INFO] [stdout] 39 | bytes: bytes, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/evented_byte_stream.rs:7:34 [INFO] [stdout] | [INFO] [stdout] 7 | fn read_into_buffer(&mut self, &mut Buffer) -> io::Result; [INFO] [stdout] | ^^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: &mut Buffer` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/evented_byte_stream.rs:8:35 [INFO] [stdout] | [INFO] [stdout] 8 | fn write_from_buffer(&mut self, &mut Buffer) -> io::Result; [INFO] [stdout] | ^^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: &mut Buffer` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/context.rs:53:15 [INFO] [stdout] | [INFO] [stdout] 53 | event_loop: event_loop, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `event_loop` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/context.rs:54:15 [INFO] [stdout] | [INFO] [stdout] 54 | command_sender: command_sender [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `command_sender` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/context.rs:124:7 [INFO] [stdout] | [INFO] [stdout] 124 | event_loop: event_loop, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `event_loop` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/context.rs:125:7 [INFO] [stdout] | [INFO] [stdout] 125 | efs: efs, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `efs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/context.rs:126:7 [INFO] [stdout] | [INFO] [stdout] 126 | session: session, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `session` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/context.rs:127:7 [INFO] [stdout] | [INFO] [stdout] 127 | token: token, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `token` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/context.rs:128:7 [INFO] [stdout] | [INFO] [stdout] 128 | outbox_pool: outbox_pool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `outbox_pool` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/context.rs:129:7 [INFO] [stdout] | [INFO] [stdout] 129 | command_sender: command_sender [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `command_sender` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/context.rs:140:9 [INFO] [stdout] | [INFO] [stdout] 140 | event_loop: event_loop, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `event_loop` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/context.rs:141:9 [INFO] [stdout] | [INFO] [stdout] 141 | command_sender: command_sender [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `command_sender` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/context.rs:155:9 [INFO] [stdout] | [INFO] [stdout] 155 | event_loop: event_loop, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `event_loop` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/context.rs:156:9 [INFO] [stdout] | [INFO] [stdout] 156 | efs: efs, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `efs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/context.rs:157:9 [INFO] [stdout] | [INFO] [stdout] 157 | token: token, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `token` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/context.rs:158:9 [INFO] [stdout] | [INFO] [stdout] 158 | outbox_pool: outbox_pool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `outbox_pool` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/context.rs:159:9 [INFO] [stdout] | [INFO] [stdout] 159 | command_sender: command_sender [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `command_sender` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/context.rs:174:7 [INFO] [stdout] | [INFO] [stdout] 174 | event_loop: event_loop, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `event_loop` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/context.rs:175:7 [INFO] [stdout] | [INFO] [stdout] 175 | efs: efs, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `efs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/context.rs:176:7 [INFO] [stdout] | [INFO] [stdout] 176 | token: token, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `token` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/context.rs:177:7 [INFO] [stdout] | [INFO] [stdout] 177 | outbox_pool: outbox_pool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `outbox_pool` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/context.rs:178:7 [INFO] [stdout] | [INFO] [stdout] 178 | command_sender: command_sender [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `command_sender` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/remote.rs:19:7 [INFO] [stdout] | [INFO] [stdout] 19 | command_sender: command_sender, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `command_sender` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/remote.rs:20:7 [INFO] [stdout] | [INFO] [stdout] 20 | receiver: receiver [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `receiver` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/timeout.rs:14:11 [INFO] [stdout] | [INFO] [stdout] 14 | data: data [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/timeout.rs:21:11 [INFO] [stdout] | [INFO] [stdout] 21 | data: data [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/settings.rs:5:23 [INFO] [stdout] | [INFO] [stdout] 5 | fn set_option(self, T) -> T; [INFO] [stdout] | ^ help: try naming the parameter or explicitly ignoring it: `_: T` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/stream_id.rs:12:7 [INFO] [stdout] | [INFO] [stdout] 12 | id: id, [INFO] [stdout] | ^^^^^^ help: replace it with: `id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/stream_id.rs:13:7 [INFO] [stdout] | [INFO] [stdout] 13 | token: token [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `token` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/stream_session.rs:12:13 [INFO] [stdout] | [INFO] [stdout] 12 | efs: efs, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `efs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/stream_session.rs:13:13 [INFO] [stdout] | [INFO] [stdout] 13 | session: session [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `session` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:50:5 [INFO] [stdout] | [INFO] [stdout] 50 | handler: handler, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `handler` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Write` [INFO] [stdout] --> src/protocol_engine.rs:8:27 [INFO] [stdout] | [INFO] [stdout] 8 | use std::io::{self, Read, Write}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Recycleable` [INFO] [stdout] --> src/protocol_engine.rs:5:23 [INFO] [stdout] | [INFO] [stdout] 5 | use lifeguard::{self, Recycleable, Pool, StartingSize, MaxSize, Supplier}; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Evented` [INFO] [stdout] --> src/protocol_engine.rs:1:11 [INFO] [stdout] | [INFO] [stdout] 1 | use mio::{Evented, EventSet, PollOpt, Token}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Read` [INFO] [stdout] --> src/protocol_engine.rs:8:21 [INFO] [stdout] | [INFO] [stdout] 8 | use std::io::{self, Read, Write}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Write` [INFO] [stdout] --> src/protocol_engine.rs:8:27 [INFO] [stdout] | [INFO] [stdout] 8 | use std::io::{self, Read, Write}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Recycleable` [INFO] [stdout] --> src/protocol_engine.rs:5:23 [INFO] [stdout] | [INFO] [stdout] 5 | use lifeguard::{self, Recycleable, Pool, StartingSize, MaxSize, Supplier}; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Evented` [INFO] [stdout] --> src/protocol_engine.rs:1:11 [INFO] [stdout] | [INFO] [stdout] 1 | use mio::{Evented, EventSet, PollOpt, Token}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Read` [INFO] [stdout] --> src/protocol_engine.rs:8:21 [INFO] [stdout] | [INFO] [stdout] 8 | use std::io::{self, Read, Write}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/evented_frame_stream.rs:215:9 [INFO] [stdout] | [INFO] [stdout] 215 | let mut outbox = self.outbox(outbox_pool); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/evented_frame_stream.rs:215:9 [INFO] [stdout] | [INFO] [stdout] 215 | let mut outbox = self.outbox(outbox_pool); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/protocol_engine.rs:131:12 [INFO] [stdout] | [INFO] [stdout] 131 | let mut stream_session: &mut StreamSession

= stream_session.unwrap(); [INFO] [stdout] | ----^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/protocol_engine.rs:133:13 [INFO] [stdout] | [INFO] [stdout] 133 | let (mut efs, mut session) = stream_session.components(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/protocol_engine.rs:133:22 [INFO] [stdout] | [INFO] [stdout] 133 | let (mut efs, mut session) = stream_session.components(); [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/protocol_engine.rs:131:12 [INFO] [stdout] | [INFO] [stdout] 131 | let mut stream_session: &mut StreamSession

= stream_session.unwrap(); [INFO] [stdout] | ----^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/protocol_engine.rs:215:17 [INFO] [stdout] | [INFO] [stdout] 215 | let mut stream_session: &mut StreamSession

= stream_session.unwrap(); [INFO] [stdout] | ----^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/protocol_engine.rs:133:13 [INFO] [stdout] | [INFO] [stdout] 133 | let (mut efs, mut session) = stream_session.components(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/protocol_engine.rs:133:22 [INFO] [stdout] | [INFO] [stdout] 133 | let (mut efs, mut session) = stream_session.components(); [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/protocol_engine.rs:215:17 [INFO] [stdout] | [INFO] [stdout] 215 | let mut stream_session: &mut StreamSession

= stream_session.unwrap(); [INFO] [stdout] | ----^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/protocol_engine.rs:216:18 [INFO] [stdout] | [INFO] [stdout] 216 | let (mut efs, mut session) = stream_session.components(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/protocol_engine.rs:216:27 [INFO] [stdout] | [INFO] [stdout] 216 | let (mut efs, mut session) = stream_session.components(); [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/protocol_engine.rs:216:18 [INFO] [stdout] | [INFO] [stdout] 216 | let (mut efs, mut session) = stream_session.components(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/protocol_engine.rs:216:27 [INFO] [stdout] | [INFO] [stdout] 216 | let (mut efs, mut session) = stream_session.components(); [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/protocol_engine.rs:531:26 [INFO] [stdout] | [INFO] [stdout] 531 | let (codec, _stream, mut write_buffer, outbox) = efs.writing_toolset(buffer_pool, outbox_pool); [INFO] [stdout] | ----^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `frame_count` is never read [INFO] [stdout] --> src/protocol_engine.rs:543:11 [INFO] [stdout] | [INFO] [stdout] 543 | frame_count += 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/protocol_engine.rs:531:26 [INFO] [stdout] | [INFO] [stdout] 531 | let (codec, _stream, mut write_buffer, outbox) = efs.writing_toolset(buffer_pool, outbox_pool); [INFO] [stdout] | ----^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `frame_count` is never read [INFO] [stdout] --> src/protocol_engine.rs:543:11 [INFO] [stdout] | [INFO] [stdout] 543 | frame_count += 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.read_buffer` after checking its variant with `is_some` [INFO] [stdout] --> src/evented_frame_stream.rs:53:25 [INFO] [stdout] | [INFO] [stdout] 52 | if self.read_buffer.is_some() { [INFO] [stdout] | ----------------------------- help: try: `if let Some() = &mut self.read_buffer` [INFO] [stdout] 53 | let read_buffer = self.read_buffer.as_mut().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.write_buffer` after checking its variant with `is_some` [INFO] [stdout] --> src/evented_frame_stream.rs:61:26 [INFO] [stdout] | [INFO] [stdout] 60 | if self.write_buffer.is_some() { [INFO] [stdout] | ------------------------------ help: try: `if let Some() = &mut self.write_buffer` [INFO] [stdout] 61 | let write_buffer = self.write_buffer.as_mut().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.outbox` after checking its variant with `is_some` [INFO] [stdout] --> src/evented_frame_stream.rs:69:20 [INFO] [stdout] | [INFO] [stdout] 68 | if self.outbox.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = &mut self.outbox` [INFO] [stdout] 69 | let outbox = self.outbox.as_mut().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/evented_frame_stream.rs:70:10 [INFO] [stdout] | [INFO] [stdout] 70 | if outbox.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `outbox.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/evented_frame_stream.rs:91:6 [INFO] [stdout] | [INFO] [stdout] 91 | (!self.write_buffer.is_none() && self.write_buffer.as_ref().unwrap().len() > 0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.write_buffer.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.read_buffer` after checking its variant with `is_some` [INFO] [stdout] --> src/evented_frame_stream.rs:53:25 [INFO] [stdout] | [INFO] [stdout] 52 | if self.read_buffer.is_some() { [INFO] [stdout] | ----------------------------- help: try: `if let Some() = &mut self.read_buffer` [INFO] [stdout] 53 | let read_buffer = self.read_buffer.as_mut().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/evented_frame_stream.rs:93:13 [INFO] [stdout] | [INFO] [stdout] 93 | || (!self.outbox.is_none() && self.outbox.as_ref().unwrap().len() > 0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.outbox.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.write_buffer` after checking its variant with `is_some` [INFO] [stdout] --> src/evented_frame_stream.rs:61:26 [INFO] [stdout] | [INFO] [stdout] 60 | if self.write_buffer.is_some() { [INFO] [stdout] | ------------------------------ help: try: `if let Some() = &mut self.write_buffer` [INFO] [stdout] 61 | let write_buffer = self.write_buffer.as_mut().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.outbox` after checking its variant with `is_some` [INFO] [stdout] --> src/evented_frame_stream.rs:69:20 [INFO] [stdout] | [INFO] [stdout] 68 | if self.outbox.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = &mut self.outbox` [INFO] [stdout] 69 | let outbox = self.outbox.as_mut().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/evented_frame_stream.rs:93:39 [INFO] [stdout] | [INFO] [stdout] 93 | || (!self.outbox.is_none() && self.outbox.as_ref().unwrap().len() > 0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.outbox.as_ref().unwrap().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/evented_frame_stream.rs:70:10 [INFO] [stdout] | [INFO] [stdout] 70 | if outbox.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `outbox.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/evented_frame_stream.rs:91:6 [INFO] [stdout] | [INFO] [stdout] 91 | (!self.write_buffer.is_none() && self.write_buffer.as_ref().unwrap().len() > 0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.write_buffer.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/evented_frame_stream.rs:93:13 [INFO] [stdout] | [INFO] [stdout] 93 | || (!self.outbox.is_none() && self.outbox.as_ref().unwrap().len() > 0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.outbox.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/evented_frame_stream.rs:93:39 [INFO] [stdout] | [INFO] [stdout] 93 | || (!self.outbox.is_none() && self.outbox.as_ref().unwrap().len() > 0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.outbox.as_ref().unwrap().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/evented_frame_stream.rs:184:3 [INFO] [stdout] | [INFO] [stdout] 184 | / pub fn on_error( [INFO] [stdout] 185 | | &mut self, [INFO] [stdout] 186 | | event_loop: &mut EventLoop>, [INFO] [stdout] 187 | | token: Token, [INFO] [stdout] ... | [INFO] [stdout] 191 | | handler: &mut P::Handler, [INFO] [stdout] 192 | | error: &Error) { [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/evented_frame_stream.rs:184:3 [INFO] [stdout] | [INFO] [stdout] 184 | / pub fn on_error( [INFO] [stdout] 185 | | &mut self, [INFO] [stdout] 186 | | event_loop: &mut EventLoop>, [INFO] [stdout] 187 | | token: Token, [INFO] [stdout] ... | [INFO] [stdout] 191 | | handler: &mut P::Handler, [INFO] [stdout] 192 | | error: &Error) { [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/protocol_engine.rs:95:9 [INFO] [stdout] | [INFO] [stdout] 95 | / match Self::send_frame(streams, outbox_pool, event_loop, token, frame) { [INFO] [stdout] 96 | | Err(error) => error!("Failed to send to {:?}: {:?}", token, error), [INFO] [stdout] 97 | | _ => {} [INFO] [stdout] 98 | | } [INFO] [stdout] | |_________^ help: try: `if let Err(error) = Self::send_frame(streams, outbox_pool, event_loop, token, frame) { error!("Failed to send to {:?}: {:?}", token, error) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/protocol_engine.rs:102:9 [INFO] [stdout] | [INFO] [stdout] 102 | / match self.broadcast(event_loop, frame) { [INFO] [stdout] 103 | | Err(error) => error!("Failed to broadcast message: {:?}", error), [INFO] [stdout] 104 | | _ => {} [INFO] [stdout] 105 | | } [INFO] [stdout] | |_________^ help: try: `if let Err(error) = self.broadcast(event_loop, frame) { error!("Failed to broadcast message: {:?}", error) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/protocol_engine.rs:95:9 [INFO] [stdout] | [INFO] [stdout] 95 | / match Self::send_frame(streams, outbox_pool, event_loop, token, frame) { [INFO] [stdout] 96 | | Err(error) => error!("Failed to send to {:?}: {:?}", token, error), [INFO] [stdout] 97 | | _ => {} [INFO] [stdout] 98 | | } [INFO] [stdout] | |_________^ help: try: `if let Err(error) = Self::send_frame(streams, outbox_pool, event_loop, token, frame) { error!("Failed to send to {:?}: {:?}", token, error) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/protocol_engine.rs:102:9 [INFO] [stdout] | [INFO] [stdout] 102 | / match self.broadcast(event_loop, frame) { [INFO] [stdout] 103 | | Err(error) => error!("Failed to broadcast message: {:?}", error), [INFO] [stdout] 104 | | _ => {} [INFO] [stdout] 105 | | } [INFO] [stdout] | |_________^ help: try: `if let Err(error) = self.broadcast(event_loop, frame) { error!("Failed to broadcast message: {:?}", error) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/protocol_engine.rs:286:5 [INFO] [stdout] | [INFO] [stdout] 286 | / let _ = event_loop.register( [INFO] [stdout] 287 | | &stream_session.stream().stream, [INFO] [stdout] 288 | | token, [INFO] [stdout] 289 | | EventSet::all(), [INFO] [stdout] 290 | | PollOpt::level() [INFO] [stdout] 291 | | ).unwrap(); [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 286 - let _ = event_loop.register( [INFO] [stdout] 286 + event_loop.register( [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/protocol_engine.rs:327:3 [INFO] [stdout] | [INFO] [stdout] 327 | / fn on_readable(event_loop: &mut MioEventLoop>, [INFO] [stdout] 328 | | handler: &mut P::Handler, [INFO] [stdout] 329 | | token: Token, [INFO] [stdout] 330 | | efs: &mut EventedFrameStream

, [INFO] [stdout] ... | [INFO] [stdout] 333 | | outbox_pool: &mut Pool>, [INFO] [stdout] 334 | | command_sender: &mut MioSender>) -> Result<(), Error> { [INFO] [stdout] | |__________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/protocol_engine.rs:353:3 [INFO] [stdout] | [INFO] [stdout] 353 | / fn read(event_loop: &mut MioEventLoop>, [INFO] [stdout] 354 | | handler: &mut P::Handler, [INFO] [stdout] 355 | | token: Token, [INFO] [stdout] 356 | | efs: &mut EventedFrameStream

, [INFO] [stdout] ... | [INFO] [stdout] 359 | | outbox_pool: &mut Pool>, [INFO] [stdout] 360 | | command_sender: &mut MioSender>) -> Result<(), Error> { [INFO] [stdout] | |__________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/protocol_engine.rs:286:5 [INFO] [stdout] | [INFO] [stdout] 286 | / let _ = event_loop.register( [INFO] [stdout] 287 | | &stream_session.stream().stream, [INFO] [stdout] 288 | | token, [INFO] [stdout] 289 | | EventSet::all(), [INFO] [stdout] 290 | | PollOpt::level() [INFO] [stdout] 291 | | ).unwrap(); [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 286 - let _ = event_loop.register( [INFO] [stdout] 286 + event_loop.register( [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/protocol_engine.rs:385:81 [INFO] [stdout] | [INFO] [stdout] 385 | let (codec, read_buffer): (&mut P::Codec, &mut Buffer) = (&mut efs.codec, &mut efs.read_buffer.as_mut().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `efs.read_buffer.as_mut().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/protocol_engine.rs:327:3 [INFO] [stdout] | [INFO] [stdout] 327 | / fn on_readable(event_loop: &mut MioEventLoop>, [INFO] [stdout] 328 | | handler: &mut P::Handler, [INFO] [stdout] 329 | | token: Token, [INFO] [stdout] 330 | | efs: &mut EventedFrameStream

, [INFO] [stdout] ... | [INFO] [stdout] 333 | | outbox_pool: &mut Pool>, [INFO] [stdout] 334 | | command_sender: &mut MioSender>) -> Result<(), Error> { [INFO] [stdout] | |__________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/protocol_engine.rs:415:35 [INFO] [stdout] | [INFO] [stdout] 415 | match stream.read_into_buffer(&mut read_buffer) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `read_buffer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/protocol_engine.rs:353:3 [INFO] [stdout] | [INFO] [stdout] 353 | / fn read(event_loop: &mut MioEventLoop>, [INFO] [stdout] 354 | | handler: &mut P::Handler, [INFO] [stdout] 355 | | token: Token, [INFO] [stdout] 356 | | efs: &mut EventedFrameStream

, [INFO] [stdout] ... | [INFO] [stdout] 359 | | outbox_pool: &mut Pool>, [INFO] [stdout] 360 | | command_sender: &mut MioSender>) -> Result<(), Error> { [INFO] [stdout] | |__________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/protocol_engine.rs:385:81 [INFO] [stdout] | [INFO] [stdout] 385 | let (codec, read_buffer): (&mut P::Codec, &mut Buffer) = (&mut efs.codec, &mut efs.read_buffer.as_mut().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `efs.read_buffer.as_mut().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/protocol_engine.rs:468:3 [INFO] [stdout] | [INFO] [stdout] 468 | / fn on_writable(event_loop: &mut MioEventLoop>, [INFO] [stdout] 469 | | handler: &mut P::Handler, [INFO] [stdout] 470 | | token: Token, [INFO] [stdout] 471 | | efs: &mut EventedFrameStream

, [INFO] [stdout] ... | [INFO] [stdout] 474 | | outbox_pool: &mut Pool>, [INFO] [stdout] 475 | | command_sender: &mut MioSender>) -> Result<(), Error> { [INFO] [stdout] | |___________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/protocol_engine.rs:415:35 [INFO] [stdout] | [INFO] [stdout] 415 | match stream.read_into_buffer(&mut read_buffer) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `read_buffer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/protocol_engine.rs:538:11 [INFO] [stdout] | [INFO] [stdout] 538 | while outbox.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!outbox.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/protocol_engine.rs:468:3 [INFO] [stdout] | [INFO] [stdout] 468 | / fn on_writable(event_loop: &mut MioEventLoop>, [INFO] [stdout] 469 | | handler: &mut P::Handler, [INFO] [stdout] 470 | | token: Token, [INFO] [stdout] 471 | | efs: &mut EventedFrameStream

, [INFO] [stdout] ... | [INFO] [stdout] 474 | | outbox_pool: &mut Pool>, [INFO] [stdout] 475 | | command_sender: &mut MioSender>) -> Result<(), Error> { [INFO] [stdout] | |___________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/protocol_engine.rs:574:36 [INFO] [stdout] | [INFO] [stdout] 574 | match stream.write_from_buffer(&mut write_buffer) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `write_buffer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/codec.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | / match error.kind() { [INFO] [stdout] 26 | | WriteZero => return EncodingError::InsufficientBuffer, [INFO] [stdout] 27 | | _ => {} [INFO] [stdout] 28 | | } [INFO] [stdout] | |_________^ help: try: `if error.kind() == WriteZero { return EncodingError::InsufficientBuffer }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/protocol_engine.rs:538:11 [INFO] [stdout] | [INFO] [stdout] 538 | while outbox.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!outbox.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Buffer` [INFO] [stdout] --> src/buffer.rs:29:3 [INFO] [stdout] | [INFO] [stdout] 29 | / pub fn new() -> Buffer { [INFO] [stdout] 30 | | Buffer::with_capacity(DEFAULT_BUFFER_SIZE) [INFO] [stdout] 31 | | } [INFO] [stdout] | |___^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 28 + impl Default for Buffer { [INFO] [stdout] 29 + fn default() -> Self { [INFO] [stdout] 30 + Self::new() [INFO] [stdout] 31 + } [INFO] [stdout] 32 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Buffer` has a public `len` method, but no `is_empty` method [INFO] [stdout] --> src/buffer.rs:80:3 [INFO] [stdout] | [INFO] [stdout] 80 | pub fn len(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] = note: `#[warn(clippy::len_without_is_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/evented_byte_stream.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 41 | return Ok(bytes_available); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 41 - return Ok(bytes_available); [INFO] [stdout] 41 + Ok(bytes_available) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/protocol_engine.rs:574:36 [INFO] [stdout] | [INFO] [stdout] 574 | match stream.write_from_buffer(&mut write_buffer) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `write_buffer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/evented_byte_stream.rs:18:10 [INFO] [stdout] | [INFO] [stdout] 18 | if raw_buffer.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `raw_buffer.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/codec.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | / match error.kind() { [INFO] [stdout] 26 | | WriteZero => return EncodingError::InsufficientBuffer, [INFO] [stdout] 27 | | _ => {} [INFO] [stdout] 28 | | } [INFO] [stdout] | |_________^ help: try: `if error.kind() == WriteZero { return EncodingError::InsufficientBuffer }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/evented_byte_stream.rs:76:5 [INFO] [stdout] | [INFO] [stdout] 76 | return Ok(total_bytes_written); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 76 - return Ok(total_bytes_written); [INFO] [stdout] 76 + Ok(total_bytes_written) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Buffer` [INFO] [stdout] --> src/buffer.rs:29:3 [INFO] [stdout] | [INFO] [stdout] 29 | / pub fn new() -> Buffer { [INFO] [stdout] 30 | | Buffer::with_capacity(DEFAULT_BUFFER_SIZE) [INFO] [stdout] 31 | | } [INFO] [stdout] | |___^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 28 + impl Default for Buffer { [INFO] [stdout] 29 + fn default() -> Self { [INFO] [stdout] 30 + Self::new() [INFO] [stdout] 31 + } [INFO] [stdout] 32 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/evented_byte_stream.rs:49:10 [INFO] [stdout] | [INFO] [stdout] 49 | if working_buffer.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `working_buffer.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Buffer` has a public `len` method, but no `is_empty` method [INFO] [stdout] --> src/buffer.rs:80:3 [INFO] [stdout] | [INFO] [stdout] 80 | pub fn len(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] = note: `#[warn(clippy::len_without_is_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/evented_byte_stream.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 41 | return Ok(bytes_available); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 41 - return Ok(bytes_available); [INFO] [stdout] 41 + Ok(bytes_available) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/evented_byte_stream.rs:18:10 [INFO] [stdout] | [INFO] [stdout] 18 | if raw_buffer.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `raw_buffer.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/context.rs:183:5 [INFO] [stdout] | [INFO] [stdout] 183 | &mut self.session [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `self.session` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/evented_byte_stream.rs:76:5 [INFO] [stdout] | [INFO] [stdout] 76 | return Ok(total_bytes_written); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 76 - return Ok(total_bytes_written); [INFO] [stdout] 76 + Ok(total_bytes_written) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/evented_byte_stream.rs:49:10 [INFO] [stdout] | [INFO] [stdout] 49 | if working_buffer.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `working_buffer.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/token_bucket.rs:16:32 [INFO] [stdout] | [INFO] [stdout] 16 | self.free_tokens.pop().map(|usize_token| Index::from_usize(usize_token)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Index::from_usize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/context.rs:183:5 [INFO] [stdout] | [INFO] [stdout] 183 | &mut self.session [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `self.session` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `ok().expect()` on a `Result` value [INFO] [stdout] --> src/lib.rs:51:17 [INFO] [stdout] | [INFO] [stdout] 51 | event_loop: EventLoop::new().ok().expect("EventLoop creation failed."), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stdout] = note: `#[warn(clippy::ok_expect)]` on by default [INFO] [stdout] help: call `expect()` directly on the `Result` [INFO] [stdout] | [INFO] [stdout] 51 - event_loop: EventLoop::new().ok().expect("EventLoop creation failed."), [INFO] [stdout] 51 + event_loop: EventLoop::new().expect("EventLoop creation failed."), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/token_bucket.rs:16:32 [INFO] [stdout] | [INFO] [stdout] 16 | self.free_tokens.pop().map(|usize_token| Index::from_usize(usize_token)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Index::from_usize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/context.rs:145:29 [INFO] [stdout] | [INFO] [stdout] 145 | pub fn stream_and_session(& mut self) -> (StreamHandle

, &mut P::Session) { [INFO] [stdout] | ^^^^^^^^^^ ^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ the same lifetime is elided here [INFO] [stdout] | | | [INFO] [stdout] | | the same lifetime is hidden here [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 145 | pub fn stream_and_session(& mut self) -> (StreamHandle<'_, P>, &mut P::Session) { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/context.rs:164:17 [INFO] [stdout] | [INFO] [stdout] 164 | pub fn stream(&mut self) -> StreamHandle

{ [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 164 | pub fn stream(&mut self) -> StreamHandle<'_, P> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `ok().expect()` on a `Result` value [INFO] [stdout] --> src/lib.rs:51:17 [INFO] [stdout] | [INFO] [stdout] 51 | event_loop: EventLoop::new().ok().expect("EventLoop creation failed."), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stdout] = note: `#[warn(clippy::ok_expect)]` on by default [INFO] [stdout] help: call `expect()` directly on the `Result` [INFO] [stdout] | [INFO] [stdout] 51 - event_loop: EventLoop::new().ok().expect("EventLoop creation failed."), [INFO] [stdout] 51 + event_loop: EventLoop::new().expect("EventLoop creation failed."), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/context.rs:145:29 [INFO] [stdout] | [INFO] [stdout] 145 | pub fn stream_and_session(& mut self) -> (StreamHandle

, &mut P::Session) { [INFO] [stdout] | ^^^^^^^^^^ ^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ the same lifetime is elided here [INFO] [stdout] | | | [INFO] [stdout] | | the same lifetime is hidden here [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 145 | pub fn stream_and_session(& mut self) -> (StreamHandle<'_, P>, &mut P::Session) { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/context.rs:164:17 [INFO] [stdout] | [INFO] [stdout] 164 | pub fn stream(&mut self) -> StreamHandle

{ [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 164 | pub fn stream(&mut self) -> StreamHandle<'_, P> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.18s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: bitflags v0.4.0 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 3` [INFO] running `Command { std: "docker" "inspect" "10fa12baf796db50663cd3939a25cc7334685d25363f2e267f30c4892ce4c072", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "10fa12baf796db50663cd3939a25cc7334685d25363f2e267f30c4892ce4c072", kill_on_drop: false }` [INFO] [stdout] 10fa12baf796db50663cd3939a25cc7334685d25363f2e267f30c4892ce4c072