[INFO] fetching crate magi-tool 0.0.5... [INFO] linting magi-tool-0.0.5 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate magi-tool 0.0.5 into /workspace/builds/worker-7-tc1/source [INFO] started tweaking crates.io crate magi-tool 0.0.5 [INFO] finished tweaking crates.io crate magi-tool 0.0.5 [INFO] tweaked toml for crates.io crate magi-tool 0.0.5 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate magi-tool 0.0.5 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate magi-tool 0.0.5 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded schemars_derive v1.0.4 [INFO] [stderr] Downloaded rmcp-macros v0.8.2 [INFO] [stderr] Downloaded schemars v1.0.4 [INFO] [stderr] Downloaded rmcp v0.8.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5bc8df9c0b927ed2ae3b6ef4fc132b6cf21489a4b0d7827f7743053b9913829b [INFO] running `Command { std: "docker" "start" "-a" "5bc8df9c0b927ed2ae3b6ef4fc132b6cf21489a4b0d7827f7743053b9913829b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5bc8df9c0b927ed2ae3b6ef4fc132b6cf21489a4b0d7827f7743053b9913829b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5bc8df9c0b927ed2ae3b6ef4fc132b6cf21489a4b0d7827f7743053b9913829b", kill_on_drop: false }` [INFO] [stdout] 5bc8df9c0b927ed2ae3b6ef4fc132b6cf21489a4b0d7827f7743053b9913829b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 270bf262073d35c41308e2a3392a2f68b54438f562d7c94180e7d469fd046817 [INFO] running `Command { std: "docker" "start" "-a" "270bf262073d35c41308e2a3392a2f68b54438f562d7c94180e7d469fd046817", kill_on_drop: false }` [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling quote v1.0.41 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Compiling ref-cast v1.0.25 [INFO] [stderr] Compiling serde_json v1.0.145 [INFO] [stderr] Compiling ryu v1.0.20 [INFO] [stderr] Compiling memchr v2.7.6 [INFO] [stderr] Compiling syn v2.0.107 [INFO] [stderr] Checking tracing-core v0.1.34 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking dyn-clone v1.0.20 [INFO] [stderr] Checking dashmap v6.1.0 [INFO] [stderr] Compiling darling_core v0.21.3 [INFO] [stderr] Compiling serde_derive_internals v0.29.1 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling ref-cast-impl v1.0.25 [INFO] [stderr] Compiling thiserror-impl v2.0.17 [INFO] [stderr] Compiling tracing-attributes v0.1.30 [INFO] [stderr] Compiling schemars_derive v1.0.4 [INFO] [stderr] Checking tokio v1.48.0 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking thiserror v2.0.17 [INFO] [stderr] Compiling darling_macro v0.21.3 [INFO] [stderr] Compiling darling v0.21.3 [INFO] [stderr] Compiling rmcp-macros v0.8.2 [INFO] [stderr] Checking chrono v0.4.42 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking schemars v1.0.4 [INFO] [stderr] Checking tokio-util v0.7.16 [INFO] [stderr] Checking tokio-stream v0.1.17 [INFO] [stderr] Checking rmcp v0.8.2 [INFO] [stderr] Checking magi-tool v0.0.5 (/opt/rustwide/workdir) [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/pegboard.rs:23:15 [INFO] [stdout] | [INFO] [stdout] 23 | services: DashMap< [INFO] [stdout] | _______________^ [INFO] [stdout] 24 | | String, [INFO] [stdout] 25 | | ( [INFO] [stdout] 26 | | String, [INFO] [stdout] 27 | | RunningService>>, [INFO] [stdout] 28 | | ), [INFO] [stdout] 29 | | >, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::borrow::Cow<'_, str>` [INFO] [stdout] --> src/pegboard.rs:146:51 [INFO] [stdout] | [INFO] [stdout] 146 | description: rmcp_tool.description.map(Cow::from), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider removing [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/pegboard.rs:23:15 [INFO] [stdout] | [INFO] [stdout] 23 | services: DashMap< [INFO] [stdout] | _______________^ [INFO] [stdout] 24 | | String, [INFO] [stdout] 25 | | ( [INFO] [stdout] 26 | | String, [INFO] [stdout] 27 | | RunningService>>, [INFO] [stdout] 28 | | ), [INFO] [stdout] 29 | | >, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::borrow::Cow<'_, str>` [INFO] [stdout] --> src/pegboard.rs:146:51 [INFO] [stdout] | [INFO] [stdout] 146 | description: rmcp_tool.description.map(Cow::from), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider removing [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap_or_default()` on `None` value [INFO] [stdout] --> src/pegboard.rs:893:19 [INFO] [stdout] | [INFO] [stdout] 893 | let ns1 = namespace_none.unwrap_or_default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the `None` and `unwrap_or_default()` [INFO] [stdout] --> src/pegboard.rs:889:46 [INFO] [stdout] | [INFO] [stdout] 889 | let namespace_none: Option = None; [INFO] [stdout] | ^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_literal_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_literal_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap_or_default()` on `Some` value [INFO] [stdout] --> src/pegboard.rs:894:19 [INFO] [stdout] | [INFO] [stdout] 894 | let ns2 = namespace_empty.unwrap_or_default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the `Some` and `unwrap_or_default()` [INFO] [stdout] --> src/pegboard.rs:890:31 [INFO] [stdout] | [INFO] [stdout] 890 | let namespace_empty = Some(String::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_literal_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/pegboard.rs:898:17 [INFO] [stdout] | [INFO] [stdout] 898 | assert!(!ns1.is_empty() == false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ns1.is_empty() != false` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/pegboard.rs:898:17 [INFO] [stdout] | [INFO] [stdout] 898 | assert!(!ns1.is_empty() == false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ns1.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/pegboard.rs:899:17 [INFO] [stdout] | [INFO] [stdout] 899 | assert!(!ns2.is_empty() == false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ns2.is_empty() != false` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/pegboard.rs:899:17 [INFO] [stdout] | [INFO] [stdout] 899 | assert!(!ns2.is_empty() == false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ns2.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 46.20s [INFO] running `Command { std: "docker" "inspect" "270bf262073d35c41308e2a3392a2f68b54438f562d7c94180e7d469fd046817", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "270bf262073d35c41308e2a3392a2f68b54438f562d7c94180e7d469fd046817", kill_on_drop: false }` [INFO] [stdout] 270bf262073d35c41308e2a3392a2f68b54438f562d7c94180e7d469fd046817