[INFO] fetching crate macon_derive 1.3.0... [INFO] linting macon_derive-1.3.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate macon_derive 1.3.0 into /workspace/builds/worker-5-tc1/source [INFO] started tweaking crates.io crate macon_derive 1.3.0 [INFO] finished tweaking crates.io crate macon_derive 1.3.0 [INFO] tweaked toml for crates.io crate macon_derive 1.3.0 written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate macon_derive 1.3.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 4 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6fe63b252c2be872de05a07a0d3a119509f2fcba09d86db3c1f2dd38607f58c1 [INFO] running `Command { std: "docker" "start" "-a" "6fe63b252c2be872de05a07a0d3a119509f2fcba09d86db3c1f2dd38607f58c1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6fe63b252c2be872de05a07a0d3a119509f2fcba09d86db3c1f2dd38607f58c1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6fe63b252c2be872de05a07a0d3a119509f2fcba09d86db3c1f2dd38607f58c1", kill_on_drop: false }` [INFO] [stdout] 6fe63b252c2be872de05a07a0d3a119509f2fcba09d86db3c1f2dd38607f58c1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3bbe911f6c38ef7dcddb6ebc88e250bbbf37b13d7660fe00a3f18ca94cadf43d [INFO] running `Command { std: "docker" "start" "-a" "3bbe911f6c38ef7dcddb6ebc88e250bbbf37b13d7660fe00a3f18ca94cadf43d", kill_on_drop: false }` [INFO] [stderr] Checking unicode-ident v1.0.24 [INFO] [stderr] Checking proc-macro2 v1.0.106 [INFO] [stderr] Checking quote v1.0.45 [INFO] [stderr] Checking syn v2.0.117 [INFO] [stderr] Checking macon_derive v1.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: struct `PropertySettings` is never constructed [INFO] [stdout] --> src/model.rs:71:12 [INFO] [stdout] | [INFO] [stdout] 71 | pub struct PropertySettings { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `into_*` usually take `self` by value [INFO] [stdout] --> src/attributes.rs:133:21 [INFO] [stdout] | [INFO] [stdout] 133 | pub fn into_mut(&mut self) -> &mut Setting<()> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/attributes.rs:210:38 [INFO] [stdout] | [INFO] [stdout] 210 | .map_err_context(format!("Unable to parse Default value for field builder attribute"))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Unable to parse Default value for field builder attribute".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/attributes.rs:216:38 [INFO] [stdout] | [INFO] [stdout] 216 | .map_err_context(format!("Unable to parse Into value for field builder attribute"))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Unable to parse Into value for field builder attribute".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Span` which implements the `Copy` trait [INFO] [stdout] --> src/common.rs:38:59 [INFO] [stdout] | [INFO] [stdout] 38 | Self::Disabled { span } => Self::Disabled { span: span.clone() }, [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*span` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Span` which implements the `Copy` trait [INFO] [stdout] --> src/common.rs:39:85 [INFO] [stdout] | [INFO] [stdout] 39 | Self::Enabled { value, span }=> Self::Enabled { value: value.clone(), span: span.clone() }, [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*span` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/config.rs:14:31 [INFO] [stdout] | [INFO] [stdout] 14 | CONFIGURATION.get_or_init(|| Default::default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Default::default` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Span` which implements the `Copy` trait [INFO] [stdout] --> src/model.rs:143:48 [INFO] [stdout] | [INFO] [stdout] 143 | ... _ => return Err(Error::new(span.clone(), format!("Unsupported mode value {} for struct builder attribute", value))), [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*span` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Span` which implements the `Copy` trait [INFO] [stdout] --> src/model.rs:146:65 [INFO] [stdout] | [INFO] [stdout] 146 | ... Setting::Disabled { span } => return Err(Error::new(span.clone(), format!("Unsupported disabled mode for struct builder attri... [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*span` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/model.rs:146:79 [INFO] [stdout] | [INFO] [stdout] 146 | ...Error::new(span.clone(), format!("Unsupported disabled mode for struct builder attribute"))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Unsupported disabled mode for struct builder attribute".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/model.rs:150:1 [INFO] [stdout] | [INFO] [stdout] 150 | / impl Default for Mode { [INFO] [stdout] 151 | | fn default() -> Self { [INFO] [stdout] 152 | | Self::Typestate [INFO] [stdout] 153 | | } [INFO] [stdout] 154 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 55 + #[derive(Default)] [INFO] [stdout] 56 | pub enum Mode { [INFO] [stdout] 57 ~ #[default] [INFO] [stdout] 58 ~ Typestate, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Setting<()>` which implements the `Copy` trait [INFO] [stdout] --> src/model.rs:185:26 [INFO] [stdout] | [INFO] [stdout] 185 | self.set_default(builder.default().clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*builder.default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Setting<()>` which implements the `Copy` trait [INFO] [stdout] --> src/model.rs:187:35 [INFO] [stdout] | [INFO] [stdout] 187 | self.properties.option = builder.fields().option().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*builder.fields().option()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Setting<()>` which implements the `Copy` trait [INFO] [stdout] --> src/model.rs:188:35 [INFO] [stdout] | [INFO] [stdout] 188 | self.properties.default = builder.fields().default().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*builder.fields().default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Setting<()>` which implements the `Copy` trait [INFO] [stdout] --> src/model.rs:189:35 [INFO] [stdout] | [INFO] [stdout] 189 | self.properties.into = builder.fields().into_().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*builder.fields().into_()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Span` which implements the `Copy` trait [INFO] [stdout] --> src/model.rs:193:54 [INFO] [stdout] | [INFO] [stdout] 193 | self.set_default(Setting::enable((), span.clone())); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*span` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Setting<()>` which implements the `Copy` trait [INFO] [stdout] --> src/model.rs:273:13 [INFO] [stdout] | [INFO] [stdout] 273 | builder_attribute.default().clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*builder_attribute.default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Setting<()>` which implements the `Copy` trait [INFO] [stdout] --> src/model.rs:276:13 [INFO] [stdout] | [INFO] [stdout] 276 | builder.properties.into.clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `builder.properties.into` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Setting<()>` which implements the `Copy` trait [INFO] [stdout] --> src/model.rs:278:13 [INFO] [stdout] | [INFO] [stdout] 278 | builder_attribute.into_().clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*builder_attribute.into_()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Setting<()>` which implements the `Copy` trait [INFO] [stdout] --> src/model.rs:289:29 [INFO] [stdout] | [INFO] [stdout] 289 | struct_default: builder.default.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `builder.default` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/model.rs:371:9 [INFO] [stdout] | [INFO] [stdout] 371 | / ! self.option.is_enabled() && [INFO] [stdout] 372 | | ! self.default.is_enabled() && [INFO] [stdout] 373 | | ! self.struct_default.is_enabled() && [INFO] [stdout] 374 | | true [INFO] [stdout] | |____________^ help: try: `!self.option.is_enabled() && !self.default.is_enabled() && !self.struct_default.is_enabled()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/model.rs:586:17 [INFO] [stdout] | [INFO] [stdout] 586 | / if setter != Setter::Default { [INFO] [stdout] 587 | | if self.default.is_enabled() { [INFO] [stdout] 588 | | value = quote!(::macon::Defaulting::Set(#value)); [INFO] [stdout] 589 | | } [INFO] [stdout] 590 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 586 ~ if setter != Setter::Default [INFO] [stdout] 587 ~ && self.default.is_enabled() { [INFO] [stdout] 588 | value = quote!(::macon::Defaulting::Set(#value)); [INFO] [stdout] 589 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/model.rs:338:19 [INFO] [stdout] | [INFO] [stdout] 338 | pub fn setter(&self) -> Cow { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 338 | pub fn setter(&self) -> Cow<'_, Ident> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `PropertySettings` is never constructed [INFO] [stdout] --> src/model.rs:71:12 [INFO] [stdout] | [INFO] [stdout] 71 | pub struct PropertySettings { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `into_*` usually take `self` by value [INFO] [stdout] --> src/attributes.rs:133:21 [INFO] [stdout] | [INFO] [stdout] 133 | pub fn into_mut(&mut self) -> &mut Setting<()> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/attributes.rs:210:38 [INFO] [stdout] | [INFO] [stdout] 210 | .map_err_context(format!("Unable to parse Default value for field builder attribute"))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Unable to parse Default value for field builder attribute".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/attributes.rs:216:38 [INFO] [stdout] | [INFO] [stdout] 216 | .map_err_context(format!("Unable to parse Into value for field builder attribute"))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Unable to parse Into value for field builder attribute".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Span` which implements the `Copy` trait [INFO] [stdout] --> src/common.rs:38:59 [INFO] [stdout] | [INFO] [stdout] 38 | Self::Disabled { span } => Self::Disabled { span: span.clone() }, [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*span` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Span` which implements the `Copy` trait [INFO] [stdout] --> src/common.rs:39:85 [INFO] [stdout] | [INFO] [stdout] 39 | Self::Enabled { value, span }=> Self::Enabled { value: value.clone(), span: span.clone() }, [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*span` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/config.rs:14:31 [INFO] [stdout] | [INFO] [stdout] 14 | CONFIGURATION.get_or_init(|| Default::default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Default::default` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Span` which implements the `Copy` trait [INFO] [stdout] --> src/model.rs:143:48 [INFO] [stdout] | [INFO] [stdout] 143 | ... _ => return Err(Error::new(span.clone(), format!("Unsupported mode value {} for struct builder attribute", value))), [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*span` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Span` which implements the `Copy` trait [INFO] [stdout] --> src/model.rs:146:65 [INFO] [stdout] | [INFO] [stdout] 146 | ... Setting::Disabled { span } => return Err(Error::new(span.clone(), format!("Unsupported disabled mode for struct builder attri... [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*span` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/model.rs:146:79 [INFO] [stdout] | [INFO] [stdout] 146 | ...Error::new(span.clone(), format!("Unsupported disabled mode for struct builder attribute"))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Unsupported disabled mode for struct builder attribute".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/model.rs:150:1 [INFO] [stdout] | [INFO] [stdout] 150 | / impl Default for Mode { [INFO] [stdout] 151 | | fn default() -> Self { [INFO] [stdout] 152 | | Self::Typestate [INFO] [stdout] 153 | | } [INFO] [stdout] 154 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 55 + #[derive(Default)] [INFO] [stdout] 56 | pub enum Mode { [INFO] [stdout] 57 ~ #[default] [INFO] [stdout] 58 ~ Typestate, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Setting<()>` which implements the `Copy` trait [INFO] [stdout] --> src/model.rs:185:26 [INFO] [stdout] | [INFO] [stdout] 185 | self.set_default(builder.default().clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*builder.default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Setting<()>` which implements the `Copy` trait [INFO] [stdout] --> src/model.rs:187:35 [INFO] [stdout] | [INFO] [stdout] 187 | self.properties.option = builder.fields().option().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*builder.fields().option()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Setting<()>` which implements the `Copy` trait [INFO] [stdout] --> src/model.rs:188:35 [INFO] [stdout] | [INFO] [stdout] 188 | self.properties.default = builder.fields().default().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*builder.fields().default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Setting<()>` which implements the `Copy` trait [INFO] [stdout] --> src/model.rs:189:35 [INFO] [stdout] | [INFO] [stdout] 189 | self.properties.into = builder.fields().into_().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*builder.fields().into_()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Span` which implements the `Copy` trait [INFO] [stdout] --> src/model.rs:193:54 [INFO] [stdout] | [INFO] [stdout] 193 | self.set_default(Setting::enable((), span.clone())); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*span` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Setting<()>` which implements the `Copy` trait [INFO] [stdout] --> src/model.rs:273:13 [INFO] [stdout] | [INFO] [stdout] 273 | builder_attribute.default().clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*builder_attribute.default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Setting<()>` which implements the `Copy` trait [INFO] [stdout] --> src/model.rs:276:13 [INFO] [stdout] | [INFO] [stdout] 276 | builder.properties.into.clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `builder.properties.into` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Setting<()>` which implements the `Copy` trait [INFO] [stdout] --> src/model.rs:278:13 [INFO] [stdout] | [INFO] [stdout] 278 | builder_attribute.into_().clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*builder_attribute.into_()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Setting<()>` which implements the `Copy` trait [INFO] [stdout] --> src/model.rs:289:29 [INFO] [stdout] | [INFO] [stdout] 289 | struct_default: builder.default.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `builder.default` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/model.rs:371:9 [INFO] [stdout] | [INFO] [stdout] 371 | / ! self.option.is_enabled() && [INFO] [stdout] 372 | | ! self.default.is_enabled() && [INFO] [stdout] 373 | | ! self.struct_default.is_enabled() && [INFO] [stdout] 374 | | true [INFO] [stdout] | |____________^ help: try: `!self.option.is_enabled() && !self.default.is_enabled() && !self.struct_default.is_enabled()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/model.rs:586:17 [INFO] [stdout] | [INFO] [stdout] 586 | / if setter != Setter::Default { [INFO] [stdout] 587 | | if self.default.is_enabled() { [INFO] [stdout] 588 | | value = quote!(::macon::Defaulting::Set(#value)); [INFO] [stdout] 589 | | } [INFO] [stdout] 590 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 586 ~ if setter != Setter::Default [INFO] [stdout] 587 ~ && self.default.is_enabled() { [INFO] [stdout] 588 | value = quote!(::macon::Defaulting::Set(#value)); [INFO] [stdout] 589 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/model.rs:338:19 [INFO] [stdout] | [INFO] [stdout] 338 | pub fn setter(&self) -> Cow { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 338 | pub fn setter(&self) -> Cow<'_, Ident> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.81s [INFO] running `Command { std: "docker" "inspect" "3bbe911f6c38ef7dcddb6ebc88e250bbbf37b13d7660fe00a3f18ca94cadf43d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3bbe911f6c38ef7dcddb6ebc88e250bbbf37b13d7660fe00a3f18ca94cadf43d", kill_on_drop: false }` [INFO] [stdout] 3bbe911f6c38ef7dcddb6ebc88e250bbbf37b13d7660fe00a3f18ca94cadf43d