[INFO] fetching crate luhorm 0.0.4... [INFO] linting luhorm-0.0.4 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate luhorm 0.0.4 into /workspace/builds/worker-6-tc1/source [INFO] started tweaking crates.io crate luhorm 0.0.4 [INFO] finished tweaking crates.io crate luhorm 0.0.4 [INFO] tweaked toml for crates.io crate luhorm 0.0.4 written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate luhorm 0.0.4 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate luhorm 0.0.4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded luhtwin v0.1.4 [INFO] [stderr] Downloaded luhcore v0.0.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4ceafd4d140effaa8acdef022428e2340819915be7e38703377fa3fde785f2c8 [INFO] running `Command { std: "docker" "start" "-a" "4ceafd4d140effaa8acdef022428e2340819915be7e38703377fa3fde785f2c8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4ceafd4d140effaa8acdef022428e2340819915be7e38703377fa3fde785f2c8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4ceafd4d140effaa8acdef022428e2340819915be7e38703377fa3fde785f2c8", kill_on_drop: false }` [INFO] [stdout] 4ceafd4d140effaa8acdef022428e2340819915be7e38703377fa3fde785f2c8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a9c24c885754089ee08b1dccd472d30e6c123beed84c757cf461a1a5b64329ec [INFO] running `Command { std: "docker" "start" "-a" "a9c24c885754089ee08b1dccd472d30e6c123beed84c757cf461a1a5b64329ec", kill_on_drop: false }` [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Compiling find-msvc-tools v0.1.5 [INFO] [stderr] Compiling icu_properties_data v2.1.1 [INFO] [stderr] Compiling stable_deref_trait v1.2.1 [INFO] [stderr] Compiling libc v0.2.178 [INFO] [stderr] Compiling zerocopy v0.8.31 [INFO] [stderr] Compiling openssl v0.10.75 [INFO] [stderr] Compiling litemap v0.8.1 [INFO] [stderr] Compiling syn v2.0.111 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling writeable v0.6.2 [INFO] [stderr] Compiling serde_json v1.0.145 [INFO] [stderr] Compiling native-tls v0.2.14 [INFO] [stderr] Compiling pin-project-lite v0.2.16 [INFO] [stderr] Compiling rust_decimal v1.40.0 [INFO] [stderr] Compiling futures-core v0.3.31 [INFO] [stderr] Compiling subtle v2.6.1 [INFO] [stderr] Compiling icu_normalizer_data v2.1.1 [INFO] [stderr] Compiling cc v1.2.49 [INFO] [stderr] Compiling futures-sink v0.3.31 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling crossbeam-utils v0.8.21 [INFO] [stderr] Compiling foreign-types-shared v0.1.1 [INFO] [stderr] Compiling percent-encoding v2.3.2 [INFO] [stderr] Compiling futures-io v0.3.31 [INFO] [stderr] Compiling slab v0.4.11 [INFO] [stderr] Compiling bytes v1.11.0 [INFO] [stderr] Compiling foldhash v0.1.5 [INFO] [stderr] Compiling foreign-types v0.3.2 [INFO] [stderr] Compiling futures-task v0.3.31 [INFO] [stderr] Compiling utf8_iter v1.0.4 [INFO] [stderr] Compiling pin-utils v0.1.0 [INFO] [stderr] Compiling form_urlencoded v1.2.2 [INFO] [stderr] Compiling bitflags v2.10.0 [INFO] [stderr] Compiling futures-util v0.3.31 [INFO] [stderr] Compiling hashbrown v0.15.5 [INFO] [stderr] Compiling tracing-core v0.1.36 [INFO] [stderr] Compiling crc-catalog v2.4.0 [INFO] [stderr] Compiling openssl-probe v0.1.6 [INFO] [stderr] Compiling iana-time-zone v0.1.64 [INFO] [stderr] Compiling parking v2.2.1 [INFO] [stderr] Compiling crypto-common v0.1.7 [INFO] [stderr] Compiling block-buffer v0.10.4 [INFO] [stderr] Compiling concurrent-queue v2.5.0 [INFO] [stderr] Compiling tinyvec_macros v0.1.1 [INFO] [stderr] Compiling arrayvec v0.7.6 [INFO] [stderr] Compiling tinyvec v1.10.0 [INFO] [stderr] Compiling digest v0.10.7 [INFO] [stderr] Compiling event-listener v5.4.1 [INFO] [stderr] Compiling crossbeam-queue v0.3.12 [INFO] [stderr] Compiling sha2 v0.10.9 [INFO] [stderr] Compiling crc v3.4.0 [INFO] [stderr] Compiling hashlink v0.10.0 [INFO] [stderr] Compiling chrono v0.4.42 [INFO] [stderr] Checking signal-hook-registry v1.4.7 [INFO] [stderr] Compiling socket2 v0.6.1 [INFO] [stderr] Compiling mio v1.1.1 [INFO] [stderr] Compiling getrandom v0.2.16 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Compiling base64 v0.22.1 [INFO] [stderr] Compiling unicode-normalization v0.1.25 [INFO] [stderr] Compiling openssl-sys v0.9.111 [INFO] [stderr] Compiling libsqlite3-sys v0.30.1 [INFO] [stderr] Compiling atoi v2.0.0 [INFO] [stderr] Compiling hmac v0.12.1 [INFO] [stderr] Compiling tokio v1.48.0 [INFO] [stderr] Compiling futures-channel v0.3.31 [INFO] [stderr] Compiling spin v0.9.8 [INFO] [stderr] Compiling unicode-properties v0.1.4 [INFO] [stderr] Compiling unicode-bidi v0.3.18 [INFO] [stderr] Compiling ppv-lite86 v0.2.21 [INFO] [stderr] Compiling flume v0.11.1 [INFO] [stderr] Compiling hkdf v0.12.4 [INFO] [stderr] Checking getrandom v0.3.4 [INFO] [stderr] Compiling rand_chacha v0.3.1 [INFO] [stderr] Compiling stringprep v0.1.5 [INFO] [stderr] Compiling md-5 v0.10.6 [INFO] [stderr] Compiling dotenvy v0.15.7 [INFO] [stderr] Compiling whoami v1.6.1 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Compiling home v0.5.11 [INFO] [stderr] Compiling byteorder v1.5.0 [INFO] [stderr] Checking rand_core v0.9.5 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking convert_case v0.10.0 [INFO] [stderr] Checking uuid v1.19.0 [INFO] [stderr] Checking luhtwin v0.1.4 [INFO] [stderr] Checking luhcore v0.0.1 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Compiling futures-executor v0.3.31 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Compiling thiserror-impl v2.0.17 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Compiling tokio-stream v0.1.17 [INFO] [stderr] Compiling tracing v0.1.44 [INFO] [stderr] Compiling zerofrom v0.1.6 [INFO] [stderr] Compiling yoke v0.8.1 [INFO] [stderr] Compiling zerotrie v0.2.3 [INFO] [stderr] Compiling zerovec v0.11.5 [INFO] [stderr] Compiling thiserror v2.0.17 [INFO] [stderr] Compiling tinystr v0.8.2 [INFO] [stderr] Compiling potential_utf v0.1.4 [INFO] [stderr] Compiling icu_collections v2.1.1 [INFO] [stderr] Compiling icu_locale_core v2.1.1 [INFO] [stderr] Compiling icu_provider v2.1.1 [INFO] [stderr] Compiling icu_properties v2.1.1 [INFO] [stderr] Compiling smallvec v1.15.1 [INFO] [stderr] Compiling either v1.15.0 [INFO] [stderr] Compiling serde_urlencoded v0.7.1 [INFO] [stderr] Compiling icu_normalizer v2.1.1 [INFO] [stderr] Compiling parking_lot_core v0.9.12 [INFO] [stderr] Compiling parking_lot v0.12.5 [INFO] [stderr] Compiling futures-intrusive v0.5.0 [INFO] [stderr] Compiling idna_adapter v1.2.1 [INFO] [stderr] Compiling idna v1.1.0 [INFO] [stderr] Checking url v2.5.7 [INFO] [stderr] Compiling sqlx-core v0.8.6 [INFO] [stderr] Compiling sqlx-sqlite v0.8.6 [INFO] [stderr] Compiling sqlx-postgres v0.8.6 [INFO] [stderr] Compiling sqlx-macros-core v0.8.6 [INFO] [stderr] Compiling sqlx-macros v0.8.6 [INFO] [stderr] Checking sqlx v0.8.6 [INFO] [stderr] Checking luhorm v0.0.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: called `map(..).flatten()` on `Iterator` [INFO] [stdout] --> src/impls.rs:422:14 [INFO] [stdout] | [INFO] [stdout] 422 | .map(|row| row.value("name").string().ok()) [INFO] [stdout] | ______________^ [INFO] [stdout] 423 | | .flatten() [INFO] [stdout] | |______________________^ help: try replacing `map` with `filter_map` and remove the `.flatten()`: `filter_map(|row| row.value("name").string().ok())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] = note: `#[warn(clippy::map_flatten)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Iterator` [INFO] [stdout] --> src/impls.rs:532:14 [INFO] [stdout] | [INFO] [stdout] 532 | .map(|row| row.value("table_name").string().ok()) [INFO] [stdout] | ______________^ [INFO] [stdout] 533 | | .flatten() [INFO] [stdout] | |______________________^ help: try replacing `map` with `filter_map` and remove the `.flatten()`: `filter_map(|row| row.value("table_name").string().ok())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/lib.rs:174:23 [INFO] [stdout] | [INFO] [stdout] 174 | let whether = match self { [INFO] [stdout] | _______________________^ [INFO] [stdout] 175 | | DbType::Timestamp => true, [INFO] [stdout] 176 | | DbType::Json => true, [INFO] [stdout] 177 | | DbType::Numeric => true, [INFO] [stdout] ... | [INFO] [stdout] 180 | | _ => false [INFO] [stdout] 181 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 174 - let whether = match self { [INFO] [stdout] 175 - DbType::Timestamp => true, [INFO] [stdout] 176 - DbType::Json => true, [INFO] [stdout] 177 - DbType::Numeric => true, [INFO] [stdout] 178 - DbType::Uuid => true, [INFO] [stdout] 179 - [INFO] [stdout] 180 - _ => false [INFO] [stdout] 181 - }; [INFO] [stdout] 174 + let whether = matches!(self, DbType::Timestamp | DbType::Json | DbType::Numeric | DbType::Uuid); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `LuhRow` [INFO] [stdout] --> src/lib.rs:350:5 [INFO] [stdout] | [INFO] [stdout] 350 | / pub fn new() -> Self { [INFO] [stdout] 351 | | Self { cols: HashMap::new() } [INFO] [stdout] 352 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 348 + impl Default for LuhRow { [INFO] [stdout] 349 + fn default() -> Self { [INFO] [stdout] 350 + Self::new() [INFO] [stdout] 351 + } [INFO] [stdout] 352 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: found call to `str::trim` before `str::split_whitespace` [INFO] [stdout] --> src/lib.rs:476:14 [INFO] [stdout] | [INFO] [stdout] 476 | .trim() [INFO] [stdout] | ______________^ [INFO] [stdout] 477 | | .split_whitespace() [INFO] [stdout] | |_____________^ help: remove `trim()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trim_split_whitespace [INFO] [stdout] = note: `#[warn(clippy::trim_split_whitespace)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lib.rs:751:13 [INFO] [stdout] | [INFO] [stdout] 751 | / if let Some(fname) = path.file_name().and_then(|s| s.to_str()) { [INFO] [stdout] 752 | | if fname.starts_with('.') || fname.starts_with('#') || fname.ends_with('~') { [INFO] [stdout] 753 | | return false; [INFO] [stdout] 754 | | } [INFO] [stdout] 755 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 751 ~ if let Some(fname) = path.file_name().and_then(|s| s.to_str()) [INFO] [stdout] 752 ~ && (fname.starts_with('.') || fname.starts_with('#') || fname.ends_with('~')) { [INFO] [stdout] 753 | return false; [INFO] [stdout] 754 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/lib.rs:1098:20 [INFO] [stdout] | [INFO] [stdout] 1098 | type_patterns: HashMap String + Send + Sync>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/lib.rs:1101:22 [INFO] [stdout] | [INFO] [stdout] 1101 | column_patterns: HashMap<(String, String), Box String + Send + Sync>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `PatternBuilder` [INFO] [stdout] --> src/lib.rs:1105:5 [INFO] [stdout] | [INFO] [stdout] 1105 | / pub fn new() -> Self { [INFO] [stdout] 1106 | | Self { [INFO] [stdout] 1107 | | type_patterns: HashMap::new(), [INFO] [stdout] 1108 | | column_patterns: HashMap::new(), [INFO] [stdout] 1109 | | } [INFO] [stdout] 1110 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 1104 + impl Default for PatternBuilder { [INFO] [stdout] 1105 + fn default() -> Self { [INFO] [stdout] 1106 + Self::new() [INFO] [stdout] 1107 + } [INFO] [stdout] 1108 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Iterator` [INFO] [stdout] --> src/impls.rs:422:14 [INFO] [stdout] | [INFO] [stdout] 422 | .map(|row| row.value("name").string().ok()) [INFO] [stdout] | ______________^ [INFO] [stdout] 423 | | .flatten() [INFO] [stdout] | |______________________^ help: try replacing `map` with `filter_map` and remove the `.flatten()`: `filter_map(|row| row.value("name").string().ok())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] = note: `#[warn(clippy::map_flatten)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/lib.rs:1409:40 [INFO] [stdout] | [INFO] [stdout] 1409 | table_struct_name: format!("{}", base_struct_name), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `base_struct_name.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Iterator` [INFO] [stdout] --> src/impls.rs:532:14 [INFO] [stdout] | [INFO] [stdout] 532 | .map(|row| row.value("table_name").string().ok()) [INFO] [stdout] | ______________^ [INFO] [stdout] 533 | | .flatten() [INFO] [stdout] | |______________________^ help: try replacing `map` with `filter_map` and remove the `.flatten()`: `filter_map(|row| row.value("table_name").string().ok())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/lib.rs:174:23 [INFO] [stdout] | [INFO] [stdout] 174 | let whether = match self { [INFO] [stdout] | _______________________^ [INFO] [stdout] 175 | | DbType::Timestamp => true, [INFO] [stdout] 176 | | DbType::Json => true, [INFO] [stdout] 177 | | DbType::Numeric => true, [INFO] [stdout] ... | [INFO] [stdout] 180 | | _ => false [INFO] [stdout] 181 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 174 - let whether = match self { [INFO] [stdout] 175 - DbType::Timestamp => true, [INFO] [stdout] 176 - DbType::Json => true, [INFO] [stdout] 177 - DbType::Numeric => true, [INFO] [stdout] 178 - DbType::Uuid => true, [INFO] [stdout] 179 - [INFO] [stdout] 180 - _ => false [INFO] [stdout] 181 - }; [INFO] [stdout] 174 + let whether = matches!(self, DbType::Timestamp | DbType::Json | DbType::Numeric | DbType::Uuid); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `LuhRow` [INFO] [stdout] --> src/lib.rs:350:5 [INFO] [stdout] | [INFO] [stdout] 350 | / pub fn new() -> Self { [INFO] [stdout] 351 | | Self { cols: HashMap::new() } [INFO] [stdout] 352 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 348 + impl Default for LuhRow { [INFO] [stdout] 349 + fn default() -> Self { [INFO] [stdout] 350 + Self::new() [INFO] [stdout] 351 + } [INFO] [stdout] 352 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: found call to `str::trim` before `str::split_whitespace` [INFO] [stdout] --> src/lib.rs:476:14 [INFO] [stdout] | [INFO] [stdout] 476 | .trim() [INFO] [stdout] | ______________^ [INFO] [stdout] 477 | | .split_whitespace() [INFO] [stdout] | |_____________^ help: remove `trim()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trim_split_whitespace [INFO] [stdout] = note: `#[warn(clippy::trim_split_whitespace)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lib.rs:751:13 [INFO] [stdout] | [INFO] [stdout] 751 | / if let Some(fname) = path.file_name().and_then(|s| s.to_str()) { [INFO] [stdout] 752 | | if fname.starts_with('.') || fname.starts_with('#') || fname.ends_with('~') { [INFO] [stdout] 753 | | return false; [INFO] [stdout] 754 | | } [INFO] [stdout] 755 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 751 ~ if let Some(fname) = path.file_name().and_then(|s| s.to_str()) [INFO] [stdout] 752 ~ && (fname.starts_with('.') || fname.starts_with('#') || fname.ends_with('~')) { [INFO] [stdout] 753 | return false; [INFO] [stdout] 754 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/lib.rs:1098:20 [INFO] [stdout] | [INFO] [stdout] 1098 | type_patterns: HashMap String + Send + Sync>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/lib.rs:1101:22 [INFO] [stdout] | [INFO] [stdout] 1101 | column_patterns: HashMap<(String, String), Box String + Send + Sync>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `PatternBuilder` [INFO] [stdout] --> src/lib.rs:1105:5 [INFO] [stdout] | [INFO] [stdout] 1105 | / pub fn new() -> Self { [INFO] [stdout] 1106 | | Self { [INFO] [stdout] 1107 | | type_patterns: HashMap::new(), [INFO] [stdout] 1108 | | column_patterns: HashMap::new(), [INFO] [stdout] 1109 | | } [INFO] [stdout] 1110 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 1104 + impl Default for PatternBuilder { [INFO] [stdout] 1105 + fn default() -> Self { [INFO] [stdout] 1106 + Self::new() [INFO] [stdout] 1107 + } [INFO] [stdout] 1108 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/lib.rs:1849:23 [INFO] [stdout] | [INFO] [stdout] 1849 | let col = table.cols.first() [INFO] [stdout] | _______________________^ [INFO] [stdout] 1850 | | .ok_or_else(|| { [INFO] [stdout] 1851 | | "no cols in table.cols for some reason (Query struct docs)" [INFO] [stdout] 1852 | | })?; [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default [INFO] [stdout] help: use `ok_or` instead [INFO] [stdout] | [INFO] [stdout] 1850 ~ .ok_or({ [INFO] [stdout] 1851 + "no cols in table.cols for some reason (Query struct docs)" [INFO] [stdout] 1852 ~ })?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/lib.rs:1409:40 [INFO] [stdout] | [INFO] [stdout] 1409 | table_struct_name: format!("{}", base_struct_name), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `base_struct_name.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/lib.rs:1849:23 [INFO] [stdout] | [INFO] [stdout] 1849 | let col = table.cols.first() [INFO] [stdout] | _______________________^ [INFO] [stdout] 1850 | | .ok_or_else(|| { [INFO] [stdout] 1851 | | "no cols in table.cols for some reason (Query struct docs)" [INFO] [stdout] 1852 | | })?; [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default [INFO] [stdout] help: use `ok_or` instead [INFO] [stdout] | [INFO] [stdout] 1850 ~ .ok_or({ [INFO] [stdout] 1851 + "no cols in table.cols for some reason (Query struct docs)" [INFO] [stdout] 1852 ~ })?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:2600:81 [INFO] [stdout] | [INFO] [stdout] 2600 | ... let fake_val = self.fake_data.generate(&table.name, &col, b); [INFO] [stdout] | ^^^^ help: change this to: `col` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:2600:81 [INFO] [stdout] | [INFO] [stdout] 2600 | ... let fake_val = self.fake_data.generate(&table.name, &col, b); [INFO] [stdout] | ^^^^ help: change this to: `col` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 10s [INFO] running `Command { std: "docker" "inspect" "a9c24c885754089ee08b1dccd472d30e6c123beed84c757cf461a1a5b64329ec", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a9c24c885754089ee08b1dccd472d30e6c123beed84c757cf461a1a5b64329ec", kill_on_drop: false }` [INFO] [stdout] a9c24c885754089ee08b1dccd472d30e6c123beed84c757cf461a1a5b64329ec