[INFO] fetching crate logisheets_astchecker 0.7.0... [INFO] linting logisheets_astchecker-0.7.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate logisheets_astchecker 0.7.0 into /workspace/builds/worker-2-tc1/source [INFO] started tweaking crates.io crate logisheets_astchecker 0.7.0 [INFO] finished tweaking crates.io crate logisheets_astchecker 0.7.0 [INFO] tweaked toml for crates.io crate logisheets_astchecker 0.7.0 written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate logisheets_astchecker 0.7.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 95 packages to latest compatible versions [INFO] [stderr] Adding generic-array v0.14.7 (available: v0.14.9) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded xmlserde v0.10.2 [INFO] [stderr] Downloaded xmlserde_derives v0.10.2 [INFO] [stderr] Downloaded logisheets_base v0.7.0 [INFO] [stderr] Downloaded logisheets_parser v0.7.0 [INFO] [stderr] Downloaded logisheets_workbook_derives v0.7.0 [INFO] [stderr] Downloaded logisheets_lexer v0.7.0 [INFO] [stderr] Downloaded logisheets_workbook v0.7.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ac6e19e0c2722611eb954a1cff3a140861ac2a03fefb319e4353f3f25adc41a4 [INFO] running `Command { std: "docker" "start" "-a" "ac6e19e0c2722611eb954a1cff3a140861ac2a03fefb319e4353f3f25adc41a4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ac6e19e0c2722611eb954a1cff3a140861ac2a03fefb319e4353f3f25adc41a4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ac6e19e0c2722611eb954a1cff3a140861ac2a03fefb319e4353f3f25adc41a4", kill_on_drop: false }` [INFO] [stdout] ac6e19e0c2722611eb954a1cff3a140861ac2a03fefb319e4353f3f25adc41a4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b68494254986ee362d2ecd0ba314392f195e97a2d57bc0f79448e73d711b4f68 [INFO] running `Command { std: "docker" "start" "-a" "b68494254986ee362d2ecd0ba314392f195e97a2d57bc0f79448e73d711b4f68", kill_on_drop: false }` [INFO] [stderr] Checking futures-core v0.3.32 [INFO] [stderr] Checking futures-sink v0.3.32 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling im v15.1.0 [INFO] [stderr] Checking bitmaps v2.1.0 [INFO] [stderr] Checking flate2 v1.1.9 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_xoshiro v0.6.0 [INFO] [stderr] Checking futures-channel v0.3.32 [INFO] [stderr] Checking zip v0.6.6 [INFO] [stderr] Checking sized-chunks v0.6.5 [INFO] [stderr] Compiling logisheets_workbook_derives v0.7.0 [INFO] [stderr] Compiling pest_generator v2.8.6 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling futures-macro v0.3.32 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Compiling xmlserde_derives v0.10.2 [INFO] [stderr] Compiling pest_derive v2.8.6 [INFO] [stderr] Checking futures-util v0.3.32 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking logisheets_lexer v0.7.0 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking quick-xml v0.37.5 [INFO] [stderr] Checking futures-executor v0.3.32 [INFO] [stderr] Checking futures v0.3.32 [INFO] [stderr] Checking xmlserde v0.10.2 [INFO] [stderr] Checking logisheets_workbook v0.7.0 [INFO] [stderr] Checking logisheets_base v0.7.0 [INFO] [stderr] Checking logisheets_parser v0.7.0 [INFO] [stderr] Checking logisheets_astchecker v0.7.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:86:12 [INFO] [stdout] | [INFO] [stdout] 86 | if !(count <= limit) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `(count > limit)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:91:12 [INFO] [stdout] | [INFO] [stdout] 91 | if !(count >= limit) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `(count < limit)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:96:12 [INFO] [stdout] | [INFO] [stdout] 96 | if !(count == limit) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `(count != limit)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/lib.rs:106:17 [INFO] [stdout] | [INFO] [stdout] 106 | if b && count % 2 != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace with: `!count.is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/lib.rs:137:43 [INFO] [stdout] | [INFO] [stdout] 137 | fn args_check(sign: &FuncSignature, args: &Vec) -> Result<(), FuncCheckError> { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 137 - fn args_check(sign: &FuncSignature, args: &Vec) -> Result<(), FuncCheckError> { [INFO] [stdout] 137 + fn args_check(sign: &FuncSignature, args: &[Node]) -> Result<(), FuncCheckError> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> src/lib.rs:150:5 [INFO] [stdout] | [INFO] [stdout] 150 | while let Some(arg) = args_iter.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for arg in args_iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] = note: `#[warn(clippy::while_let_on_iterator)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lib.rs:174:9 [INFO] [stdout] | [INFO] [stdout] 174 | / match &arg.pure { [INFO] [stdout] 175 | | ast::PureNode::Value(_) => return false, [INFO] [stdout] 176 | | _ => {} [INFO] [stdout] 177 | | }; [INFO] [stdout] | |_________^ help: try: `if let ast::PureNode::Value(_) = &arg.pure { return false }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:86:12 [INFO] [stdout] | [INFO] [stdout] 86 | if !(count <= limit) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `(count > limit)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:91:12 [INFO] [stdout] | [INFO] [stdout] 91 | if !(count >= limit) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `(count < limit)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:96:12 [INFO] [stdout] | [INFO] [stdout] 96 | if !(count == limit) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `(count != limit)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/lib.rs:106:17 [INFO] [stdout] | [INFO] [stdout] 106 | if b && count % 2 != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace with: `!count.is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/lib.rs:137:43 [INFO] [stdout] | [INFO] [stdout] 137 | fn args_check(sign: &FuncSignature, args: &Vec) -> Result<(), FuncCheckError> { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 137 - fn args_check(sign: &FuncSignature, args: &Vec) -> Result<(), FuncCheckError> { [INFO] [stdout] 137 + fn args_check(sign: &FuncSignature, args: &[Node]) -> Result<(), FuncCheckError> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> src/lib.rs:150:5 [INFO] [stdout] | [INFO] [stdout] 150 | while let Some(arg) = args_iter.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for arg in args_iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] = note: `#[warn(clippy::while_let_on_iterator)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lib.rs:174:9 [INFO] [stdout] | [INFO] [stdout] 174 | / match &arg.pure { [INFO] [stdout] 175 | | ast::PureNode::Value(_) => return false, [INFO] [stdout] 176 | | _ => {} [INFO] [stdout] 177 | | }; [INFO] [stdout] | |_________^ help: try: `if let ast::PureNode::Value(_) = &arg.pure { return false }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 24.97s [INFO] running `Command { std: "docker" "inspect" "b68494254986ee362d2ecd0ba314392f195e97a2d57bc0f79448e73d711b4f68", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b68494254986ee362d2ecd0ba314392f195e97a2d57bc0f79448e73d711b4f68", kill_on_drop: false }` [INFO] [stdout] b68494254986ee362d2ecd0ba314392f195e97a2d57bc0f79448e73d711b4f68