[INFO] fetching crate llmtrace-storage 0.1.5... [INFO] linting llmtrace-storage-0.1.5 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate llmtrace-storage 0.1.5 into /workspace/builds/worker-0-tc1/source [INFO] started tweaking crates.io crate llmtrace-storage 0.1.5 [INFO] finished tweaking crates.io crate llmtrace-storage 0.1.5 [INFO] tweaked toml for crates.io crate llmtrace-storage 0.1.5 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate llmtrace-storage 0.1.5 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate llmtrace-storage 0.1.5 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded zmij v1.0.18 [INFO] [stderr] Downloaded llmtrace-core v0.1.5 [INFO] [stderr] Downloaded clickhouse-types v0.1.1 [INFO] [stderr] Downloaded never-say-never v6.6.666 [INFO] [stderr] Downloaded polonius-the-crab v0.5.0 [INFO] [stderr] Downloaded clickhouse-macros v0.3.0 [INFO] [stderr] Downloaded higher-kinded-types v0.2.1 [INFO] [stderr] Downloaded backon v1.6.0 [INFO] [stderr] Downloaded lz4_flex v0.11.5 [INFO] [stderr] Downloaded bnum v0.13.0 [INFO] [stderr] Downloaded utoipa v5.4.0 [INFO] [stderr] Downloaded zerocopy-derive v0.8.37 [INFO] [stderr] Downloaded utoipa-gen v5.4.0 [INFO] [stderr] Downloaded cityhash-rs v1.0.1 [INFO] [stderr] Downloaded zerocopy v0.8.37 [INFO] [stderr] Downloaded clickhouse v0.14.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d453126df1ec0e6b572b960baae75a5659a260a1eac253262543890d901f33b8 [INFO] running `Command { std: "docker" "start" "-a" "d453126df1ec0e6b572b960baae75a5659a260a1eac253262543890d901f33b8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d453126df1ec0e6b572b960baae75a5659a260a1eac253262543890d901f33b8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d453126df1ec0e6b572b960baae75a5659a260a1eac253262543890d901f33b8", kill_on_drop: false }` [INFO] [stdout] d453126df1ec0e6b572b960baae75a5659a260a1eac253262543890d901f33b8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 219bef04e428296948b8f26039788cbc413711ecac61641d208917d4c15543da [INFO] running `Command { std: "docker" "start" "-a" "219bef04e428296948b8f26039788cbc413711ecac61641d208917d4c15543da", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.114 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling stable_deref_trait v1.2.1 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Compiling zmij v1.0.18 [INFO] [stderr] Compiling cc v1.2.55 [INFO] [stderr] Compiling litemap v0.8.1 [INFO] [stderr] Compiling serde_json v1.0.149 [INFO] [stderr] Compiling writeable v0.6.2 [INFO] [stderr] Compiling pin-project-lite v0.2.16 [INFO] [stderr] Compiling futures-core v0.3.31 [INFO] [stderr] Compiling typenum v1.19.0 [INFO] [stderr] Compiling zeroize v1.8.2 [INFO] [stderr] Compiling rustls v0.23.36 [INFO] [stderr] Compiling crossbeam-utils v0.8.21 [INFO] [stderr] Compiling icu_properties_data v2.1.2 [INFO] [stderr] Compiling icu_normalizer_data v2.1.1 [INFO] [stderr] Compiling futures-sink v0.3.31 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Compiling getrandom v0.2.17 [INFO] [stderr] Compiling percent-encoding v2.3.2 [INFO] [stderr] Compiling untrusted v0.9.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling socket2 v0.6.2 [INFO] [stderr] Compiling rustls-pki-types v1.14.0 [INFO] [stderr] Compiling form_urlencoded v1.2.2 [INFO] [stderr] Compiling mio v1.1.1 [INFO] [stderr] Compiling slab v0.4.12 [INFO] [stderr] Compiling bytes v1.11.1 [INFO] [stderr] Compiling foldhash v0.1.5 [INFO] [stderr] Compiling futures-task v0.3.31 [INFO] [stderr] Compiling futures-io v0.3.31 [INFO] [stderr] Compiling utf8_iter v1.0.4 [INFO] [stderr] Compiling pin-utils v0.1.0 [INFO] [stderr] Compiling allocator-api2 v0.2.21 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Compiling futures-util v0.3.31 [INFO] [stderr] Compiling webpki-roots v1.0.5 [INFO] [stderr] Checking getrandom v0.3.4 [INFO] [stderr] Compiling tracing-core v0.1.36 [INFO] [stderr] Compiling concurrent-queue v2.5.0 [INFO] [stderr] Compiling hashbrown v0.15.5 [INFO] [stderr] Checking errno v0.3.14 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling tokio v1.49.0 [INFO] [stderr] Compiling log v0.4.29 [INFO] [stderr] Compiling iana-time-zone v0.1.65 [INFO] [stderr] Compiling parking v2.2.1 [INFO] [stderr] Compiling crc-catalog v2.4.0 [INFO] [stderr] Compiling subtle v2.6.1 [INFO] [stderr] Checking signal-hook-registry v1.4.8 [INFO] [stderr] Compiling crossbeam-queue v0.3.12 [INFO] [stderr] Compiling chrono v0.4.43 [INFO] [stderr] Compiling event-listener v5.4.1 [INFO] [stderr] Compiling crc v3.4.0 [INFO] [stderr] Compiling futures-intrusive v0.5.0 [INFO] [stderr] Compiling webpki-roots v0.26.11 [INFO] [stderr] Checking crypto-common v0.1.7 [INFO] [stderr] Compiling ryu v1.0.22 [INFO] [stderr] Compiling uuid v1.20.0 [INFO] [stderr] Compiling base64 v0.22.1 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Compiling libsqlite3-sys v0.30.1 [INFO] [stderr] Compiling flume v0.11.1 [INFO] [stderr] Compiling atoi v2.0.0 [INFO] [stderr] Compiling futures-channel v0.3.31 [INFO] [stderr] Compiling hashlink v0.10.0 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Compiling block-buffer v0.10.4 [INFO] [stderr] Compiling dotenvy v0.15.7 [INFO] [stderr] Checking dashmap v6.1.0 [INFO] [stderr] Checking tempfile v3.24.0 [INFO] [stderr] Checking indexmap v2.13.0 [INFO] [stderr] Compiling futures-executor v0.3.31 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Compiling utoipa-gen v5.4.0 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Compiling tokio-stream v0.1.18 [INFO] [stderr] Compiling zerofrom v0.1.6 [INFO] [stderr] Compiling yoke v0.8.1 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Compiling rustls-webpki v0.103.9 [INFO] [stderr] Compiling zerovec v0.11.5 [INFO] [stderr] Compiling zerotrie v0.2.3 [INFO] [stderr] Compiling tracing v0.1.44 [INFO] [stderr] Compiling thiserror v2.0.18 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking either v1.15.0 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking utoipa v5.4.0 [INFO] [stderr] Compiling sqlx-core v0.8.6 [INFO] [stderr] Checking llmtrace-core v0.1.5 [INFO] [stderr] Checking sqlx-sqlite v0.8.6 [INFO] [stderr] Compiling sqlx-macros-core v0.8.6 [INFO] [stderr] Compiling sqlx-macros v0.8.6 [INFO] [stderr] Checking sqlx v0.8.6 [INFO] [stderr] Checking llmtrace-storage v0.1.5 (/opt/rustwide/workdir) [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/memory.rs:170:9 [INFO] [stdout] | [INFO] [stdout] 170 | results.sort_by(|a, b| b.created_at.cmp(&a.created_at)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 170 - results.sort_by(|a, b| b.created_at.cmp(&a.created_at)); [INFO] [stdout] 170 + results.sort_by_key(|b| std::cmp::Reverse(b.created_at)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/memory.rs:190:9 [INFO] [stdout] | [INFO] [stdout] 190 | all.sort_by(|a, b| b.start_time.cmp(&a.start_time)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 190 - all.sort_by(|a, b| b.start_time.cmp(&a.start_time)); [INFO] [stdout] 190 + all.sort_by_key(|b| std::cmp::Reverse(b.start_time)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/memory.rs:413:9 [INFO] [stdout] | [INFO] [stdout] 413 | results.sort_by(|a, b| b.timestamp.cmp(&a.timestamp)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 413 - results.sort_by(|a, b| b.timestamp.cmp(&a.timestamp)); [INFO] [stdout] 413 + results.sort_by_key(|b| std::cmp::Reverse(b.timestamp)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/memory.rs:495:9 [INFO] [stdout] | [INFO] [stdout] 495 | results.sort_by(|a, b| b.created_at.cmp(&a.created_at)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 495 - results.sort_by(|a, b| b.created_at.cmp(&a.created_at)); [INFO] [stdout] 495 + results.sort_by_key(|b| std::cmp::Reverse(b.created_at)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/memory.rs:170:9 [INFO] [stdout] | [INFO] [stdout] 170 | results.sort_by(|a, b| b.created_at.cmp(&a.created_at)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 170 - results.sort_by(|a, b| b.created_at.cmp(&a.created_at)); [INFO] [stdout] 170 + results.sort_by_key(|b| std::cmp::Reverse(b.created_at)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/memory.rs:190:9 [INFO] [stdout] | [INFO] [stdout] 190 | all.sort_by(|a, b| b.start_time.cmp(&a.start_time)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 190 - all.sort_by(|a, b| b.start_time.cmp(&a.start_time)); [INFO] [stdout] 190 + all.sort_by_key(|b| std::cmp::Reverse(b.start_time)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/memory.rs:413:9 [INFO] [stdout] | [INFO] [stdout] 413 | results.sort_by(|a, b| b.timestamp.cmp(&a.timestamp)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 413 - results.sort_by(|a, b| b.timestamp.cmp(&a.timestamp)); [INFO] [stdout] 413 + results.sort_by_key(|b| std::cmp::Reverse(b.timestamp)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/memory.rs:495:9 [INFO] [stdout] | [INFO] [stdout] 495 | results.sort_by(|a, b| b.created_at.cmp(&a.created_at)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 495 - results.sort_by(|a, b| b.created_at.cmp(&a.created_at)); [INFO] [stdout] 495 + results.sort_by_key(|b| std::cmp::Reverse(b.created_at)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 12s [INFO] running `Command { std: "docker" "inspect" "219bef04e428296948b8f26039788cbc413711ecac61641d208917d4c15543da", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "219bef04e428296948b8f26039788cbc413711ecac61641d208917d4c15543da", kill_on_drop: false }` [INFO] [stdout] 219bef04e428296948b8f26039788cbc413711ecac61641d208917d4c15543da