[INFO] fetching crate lin_algebra 0.3.1... [INFO] linting lin_algebra-0.3.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate lin_algebra 0.3.1 into /workspace/builds/worker-4-tc1/source [INFO] started tweaking crates.io crate lin_algebra 0.3.1 [INFO] finished tweaking crates.io crate lin_algebra 0.3.1 [INFO] tweaked toml for crates.io crate lin_algebra 0.3.1 written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate lin_algebra 0.3.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate lin_algebra 0.3.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7ab1aa76283df9dca17c80396eb554743ef1ceb97515532bb420d6862eb017cc [INFO] running `Command { std: "docker" "start" "-a" "7ab1aa76283df9dca17c80396eb554743ef1ceb97515532bb420d6862eb017cc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7ab1aa76283df9dca17c80396eb554743ef1ceb97515532bb420d6862eb017cc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7ab1aa76283df9dca17c80396eb554743ef1ceb97515532bb420d6862eb017cc", kill_on_drop: false }` [INFO] [stdout] 7ab1aa76283df9dca17c80396eb554743ef1ceb97515532bb420d6862eb017cc [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2462c6b2dd8765a639dc1be55c161f41d75604c64286cecc9fc28379df06aceb [INFO] running `Command { std: "docker" "start" "-a" "2462c6b2dd8765a639dc1be55c161f41d75604c64286cecc9fc28379df06aceb", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking lin_algebra v0.3.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/gf2_matrix.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - return true; [INFO] [stdout] 42 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/gf2_matrix.rs:30:41 [INFO] [stdout] | [INFO] [stdout] 30 | if piv < old_piv || found_zero_row == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `found_zero_row` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/gf2_matrix.rs:55:13 [INFO] [stdout] | [INFO] [stdout] 55 | return self.rank_echelon_form(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 55 - return self.rank_echelon_form(); [INFO] [stdout] 55 + self.rank_echelon_form() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/gf2_matrix.rs:58:13 [INFO] [stdout] | [INFO] [stdout] 58 | return ech_form.rank_echelon_form(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 58 - return ech_form.rank_echelon_form(); [INFO] [stdout] 58 + ech_form.rank_echelon_form() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/gf2_matrix.rs:72:13 [INFO] [stdout] | [INFO] [stdout] 72 | return self.kernel_echelon_form(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 72 - return self.kernel_echelon_form(); [INFO] [stdout] 72 + self.kernel_echelon_form() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/gf2_matrix.rs:76:13 [INFO] [stdout] | [INFO] [stdout] 76 | return ech_form.kernel_echelon_form(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 76 - return ech_form.kernel_echelon_form(); [INFO] [stdout] 76 + ech_form.kernel_echelon_form() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/gf2_matrix.rs:149:16 [INFO] [stdout] | [INFO] [stdout] 149 | if !piv.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `piv.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/gf2_matrix.rs:170:37 [INFO] [stdout] | [INFO] [stdout] 170 | fn apply_operations(operations: &Vec<(usize, usize)>, v: &Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 170 - fn apply_operations(operations: &Vec<(usize, usize)>, v: &Vec) -> Vec { [INFO] [stdout] 170 + fn apply_operations(operations: &[(usize, usize)], v: &Vec) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/gf2_matrix.rs:170:62 [INFO] [stdout] | [INFO] [stdout] 170 | fn apply_operations(operations: &Vec<(usize, usize)>, v: &Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 170 ~ fn apply_operations(operations: &Vec<(usize, usize)>, v: &[u8]) -> Vec { [INFO] [stdout] 171 ~ let mut result = v.to_owned(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is used to index `elements` [INFO] [stdout] --> src/gf2_matrix.rs:203:18 [INFO] [stdout] | [INFO] [stdout] 203 | for j in 0..y.ncols() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 203 - for j in 0..y.ncols() { [INFO] [stdout] 203 + for (j, ) in elements.iter_mut().enumerate().take(y.ncols()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/gf2_matrix.rs:285:25 [INFO] [stdout] | [INFO] [stdout] 285 | sum = sum ^ (self.elements[p_row][col] * kernel_vector[col]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sum ^= (self.elements[p_row][col] * kernel_vector[col])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `self.elements().get(0)` [INFO] [stdout] --> src/matrix.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | self.elements().get(0).map_or(0, |row| row.len()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.elements().first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/matrix.rs:22:23 [INFO] [stdout] | [INFO] [stdout] 22 | fn get_pivot(vec: &Vec) -> Option { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 22 - fn get_pivot(vec: &Vec) -> Option { [INFO] [stdout] 22 + fn get_pivot(vec: &[T]) -> Option { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/gf2_matrix.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - return true; [INFO] [stdout] 42 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/gf2_matrix.rs:30:41 [INFO] [stdout] | [INFO] [stdout] 30 | if piv < old_piv || found_zero_row == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `found_zero_row` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/gf2_matrix.rs:55:13 [INFO] [stdout] | [INFO] [stdout] 55 | return self.rank_echelon_form(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 55 - return self.rank_echelon_form(); [INFO] [stdout] 55 + self.rank_echelon_form() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/gf2_matrix.rs:58:13 [INFO] [stdout] | [INFO] [stdout] 58 | return ech_form.rank_echelon_form(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 58 - return ech_form.rank_echelon_form(); [INFO] [stdout] 58 + ech_form.rank_echelon_form() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/gf2_matrix.rs:72:13 [INFO] [stdout] | [INFO] [stdout] 72 | return self.kernel_echelon_form(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 72 - return self.kernel_echelon_form(); [INFO] [stdout] 72 + self.kernel_echelon_form() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/gf2_matrix.rs:76:13 [INFO] [stdout] | [INFO] [stdout] 76 | return ech_form.kernel_echelon_form(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 76 - return ech_form.kernel_echelon_form(); [INFO] [stdout] 76 + ech_form.kernel_echelon_form() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/gf2_matrix.rs:149:16 [INFO] [stdout] | [INFO] [stdout] 149 | if !piv.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `piv.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/gf2_matrix.rs:170:37 [INFO] [stdout] | [INFO] [stdout] 170 | fn apply_operations(operations: &Vec<(usize, usize)>, v: &Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 170 - fn apply_operations(operations: &Vec<(usize, usize)>, v: &Vec) -> Vec { [INFO] [stdout] 170 + fn apply_operations(operations: &[(usize, usize)], v: &Vec) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/gf2_matrix.rs:170:62 [INFO] [stdout] | [INFO] [stdout] 170 | fn apply_operations(operations: &Vec<(usize, usize)>, v: &Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 170 ~ fn apply_operations(operations: &Vec<(usize, usize)>, v: &[u8]) -> Vec { [INFO] [stdout] 171 ~ let mut result = v.to_owned(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is used to index `elements` [INFO] [stdout] --> src/gf2_matrix.rs:203:18 [INFO] [stdout] | [INFO] [stdout] 203 | for j in 0..y.ncols() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 203 - for j in 0..y.ncols() { [INFO] [stdout] 203 + for (j, ) in elements.iter_mut().enumerate().take(y.ncols()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/gf2_matrix.rs:285:25 [INFO] [stdout] | [INFO] [stdout] 285 | sum = sum ^ (self.elements[p_row][col] * kernel_vector[col]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sum ^= (self.elements[p_row][col] * kernel_vector[col])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `self.elements().get(0)` [INFO] [stdout] --> src/matrix.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | self.elements().get(0).map_or(0, |row| row.len()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.elements().first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/matrix.rs:22:23 [INFO] [stdout] | [INFO] [stdout] 22 | fn get_pivot(vec: &Vec) -> Option { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 22 - fn get_pivot(vec: &Vec) -> Option { [INFO] [stdout] 22 + fn get_pivot(vec: &[T]) -> Option { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/lib.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | / assert_eq!( [INFO] [stdout] 57 | | GF2Matrix::new(vec![vec![1, 0, 0, 0], vec![1, 1, 0, 1]]).is_reduced_echelon(), [INFO] [stdout] 58 | | false [INFO] [stdout] 59 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 56 ~ assert!( [INFO] [stdout] 57 ~ !GF2Matrix::new(vec![vec![1, 0, 0, 0], vec![1, 1, 0, 1]]).is_reduced_echelon() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/lib.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 60 | / assert_eq!( [INFO] [stdout] 61 | | GF2Matrix::new(vec![vec![1, 0, 0, 0], vec![1, 1, 0, 1]]).is_reduced_echelon(), [INFO] [stdout] 62 | | false [INFO] [stdout] 63 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 60 ~ assert!( [INFO] [stdout] 61 ~ !GF2Matrix::new(vec![vec![1, 0, 0, 0], vec![1, 1, 0, 1]]).is_reduced_echelon() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/lib.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 64 | / assert_eq!( [INFO] [stdout] 65 | | GF2Matrix::new(vec![vec![1, 1, 0, 1], vec![0, 1, 0, 1]]).is_reduced_echelon(), [INFO] [stdout] 66 | | false [INFO] [stdout] 67 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 64 ~ assert!( [INFO] [stdout] 65 ~ !GF2Matrix::new(vec![vec![1, 1, 0, 1], vec![0, 1, 0, 1]]).is_reduced_echelon() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/lib.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | / assert_eq!( [INFO] [stdout] 69 | | GF2Matrix::new(vec![vec![1, 0, 0, 1], vec![0, 1, 0, 1]]).is_reduced_echelon(), [INFO] [stdout] 70 | | true [INFO] [stdout] 71 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 68 ~ assert!( [INFO] [stdout] 69 ~ GF2Matrix::new(vec![vec![1, 0, 0, 1], vec![0, 1, 0, 1]]).is_reduced_echelon() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/lib.rs:72:9 [INFO] [stdout] | [INFO] [stdout] 72 | / assert_eq!( [INFO] [stdout] 73 | | GF2Matrix::new(vec![vec![1, 0, 0, 0], vec![1, 1, 0, 1], vec![0, 0, 1, 1]]) [INFO] [stdout] 74 | | .is_reduced_echelon(), [INFO] [stdout] 75 | | false [INFO] [stdout] 76 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 72 ~ assert!( [INFO] [stdout] 73 ~ !GF2Matrix::new(vec![vec![1, 0, 0, 0], vec![1, 1, 0, 1], vec![0, 0, 1, 1]]) [INFO] [stdout] 74 ~ .is_reduced_echelon() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/lib.rs:77:9 [INFO] [stdout] | [INFO] [stdout] 77 | / assert_eq!( [INFO] [stdout] 78 | | GF2Matrix::new(vec![vec![1, 0, 0, 0], vec![0, 1, 0, 0], vec![0, 0, 1, 1]]) [INFO] [stdout] 79 | | .is_reduced_echelon(), [INFO] [stdout] 80 | | true [INFO] [stdout] 81 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 77 ~ assert!( [INFO] [stdout] 78 | GF2Matrix::new(vec![vec![1, 0, 0, 0], vec![0, 1, 0, 0], vec![0, 0, 1, 1]]) [INFO] [stdout] 79 ~ .is_reduced_echelon() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/lib.rs:82:9 [INFO] [stdout] | [INFO] [stdout] 82 | / assert_eq!( [INFO] [stdout] 83 | | GF2Matrix::new(vec![vec![1, 0, 0, 0], vec![0, 1, 0, 1], vec![0, 1, 0, 1]]) [INFO] [stdout] 84 | | .is_reduced_echelon(), [INFO] [stdout] 85 | | false [INFO] [stdout] 86 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 82 ~ assert!( [INFO] [stdout] 83 ~ !GF2Matrix::new(vec![vec![1, 0, 0, 0], vec![0, 1, 0, 1], vec![0, 1, 0, 1]]) [INFO] [stdout] 84 ~ .is_reduced_echelon() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/lib.rs:87:9 [INFO] [stdout] | [INFO] [stdout] 87 | / assert_eq!( [INFO] [stdout] 88 | | GF2Matrix::new(vec![vec![1, 0, 0, 0], vec![0, 0, 0, 0], vec![0, 1, 0, 1]]) [INFO] [stdout] 89 | | .is_reduced_echelon(), [INFO] [stdout] 90 | | false [INFO] [stdout] 91 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 87 ~ assert!( [INFO] [stdout] 88 ~ !GF2Matrix::new(vec![vec![1, 0, 0, 0], vec![0, 0, 0, 0], vec![0, 1, 0, 1]]) [INFO] [stdout] 89 ~ .is_reduced_echelon() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/lib.rs:96:9 [INFO] [stdout] | [INFO] [stdout] 96 | / assert_eq!( [INFO] [stdout] 97 | | GF2Matrix::new(vec![vec![0, 0, 0, 0], vec![1, 0, 0, 0], vec![0, 1, 0, 1]]) [INFO] [stdout] 98 | | .is_reduced_echelon(), [INFO] [stdout] 99 | | false [INFO] [stdout] 100 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 96 ~ assert!( [INFO] [stdout] 97 ~ !GF2Matrix::new(vec![vec![0, 0, 0, 0], vec![1, 0, 0, 0], vec![0, 1, 0, 1]]) [INFO] [stdout] 98 ~ .is_reduced_echelon() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/lib.rs:101:9 [INFO] [stdout] | [INFO] [stdout] 101 | / assert_eq!( [INFO] [stdout] 102 | | GF2Matrix::new(vec![vec![1, 0, 0, 0], vec![0, 0, 0, 0], vec![0, 1, 0, 1]]) [INFO] [stdout] 103 | | .is_reduced_echelon(), [INFO] [stdout] 104 | | false [INFO] [stdout] 105 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 101 ~ assert!( [INFO] [stdout] 102 ~ !GF2Matrix::new(vec![vec![1, 0, 0, 0], vec![0, 0, 0, 0], vec![0, 1, 0, 1]]) [INFO] [stdout] 103 ~ .is_reduced_echelon() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/lib.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 106 | / assert_eq!( [INFO] [stdout] 107 | | GF2Matrix::new(vec![vec![1, 0, 1, 0], vec![0, 0, 0, 0]]).is_reduced_echelon(), [INFO] [stdout] 108 | | true [INFO] [stdout] 109 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 106 ~ assert!( [INFO] [stdout] 107 ~ GF2Matrix::new(vec![vec![1, 0, 1, 0], vec![0, 0, 0, 0]]).is_reduced_echelon() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.30s [INFO] running `Command { std: "docker" "inspect" "2462c6b2dd8765a639dc1be55c161f41d75604c64286cecc9fc28379df06aceb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2462c6b2dd8765a639dc1be55c161f41d75604c64286cecc9fc28379df06aceb", kill_on_drop: false }` [INFO] [stdout] 2462c6b2dd8765a639dc1be55c161f41d75604c64286cecc9fc28379df06aceb