[INFO] fetching crate libwhen 0.4.0... [INFO] linting libwhen-0.4.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate libwhen 0.4.0 into /workspace/builds/worker-4-tc1/source [INFO] started tweaking crates.io crate libwhen 0.4.0 [INFO] finished tweaking crates.io crate libwhen 0.4.0 [INFO] tweaked toml for crates.io crate libwhen 0.4.0 written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate libwhen 0.4.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 71 packages to latest compatible versions [INFO] [stderr] Adding chrono-tz v0.6.3 (available: v0.10.4) [INFO] [stderr] Adding generic-array v0.14.7 (available: v0.14.9) [INFO] [stderr] Adding localzone v0.2.0 (available: v0.3.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded localzone v0.2.0 [INFO] [stderr] Downloaded chrono-tz-build v0.0.3 [INFO] [stderr] Downloaded chrono-tz v0.6.3 [INFO] [stderr] Downloaded windows_aarch64_msvc v0.28.0 [INFO] [stderr] Downloaded windows_x86_64_msvc v0.28.0 [INFO] [stderr] Downloaded windows_i686_gnu v0.28.0 [INFO] [stderr] Downloaded windows_i686_msvc v0.28.0 [INFO] [stderr] Downloaded windows_x86_64_gnu v0.28.0 [INFO] [stderr] Downloaded windows-sys v0.28.0 [INFO] [stderr] Downloaded windows v0.28.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3afa82044017214fe17b4bb90e6c8e9a5f5c8041ebb2b374944423fbfcf3e280 [INFO] running `Command { std: "docker" "start" "-a" "3afa82044017214fe17b4bb90e6c8e9a5f5c8041ebb2b374944423fbfcf3e280", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3afa82044017214fe17b4bb90e6c8e9a5f5c8041ebb2b374944423fbfcf3e280", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3afa82044017214fe17b4bb90e6c8e9a5f5c8041ebb2b374944423fbfcf3e280", kill_on_drop: false }` [INFO] [stdout] 3afa82044017214fe17b4bb90e6c8e9a5f5c8041ebb2b374944423fbfcf3e280 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 53b506e15a00c60086400340499bf28d2a931bc6612570631cfb786b3e160734 [INFO] running `Command { std: "docker" "start" "-a" "53b506e15a00c60086400340499bf28d2a931bc6612570631cfb786b3e160734", kill_on_drop: false }` [INFO] [stderr] Compiling uncased v0.9.10 [INFO] [stderr] Compiling siphasher v1.0.2 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Compiling regex-syntax v0.8.10 [INFO] [stderr] Compiling ucd-trie v0.1.7 [INFO] [stderr] Compiling memchr v2.8.0 [INFO] [stderr] Compiling libwhen v0.4.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking localzone v0.2.0 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Checking pest v2.8.6 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Checking phf_shared v0.11.3 [INFO] [stderr] Checking phf v0.11.3 [INFO] [stderr] Compiling phf_generator v0.11.3 [INFO] [stderr] Compiling phf_codegen v0.11.3 [INFO] [stderr] Compiling pest_meta v2.8.6 [INFO] [stderr] Compiling regex-automata v0.4.14 [INFO] [stderr] Compiling pest_generator v2.8.6 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Compiling pest_derive v2.8.6 [INFO] [stderr] Checking chrono v0.4.44 [INFO] [stderr] Compiling regex v1.12.3 [INFO] [stderr] Compiling parse-zoneinfo v0.3.1 [INFO] [stderr] Compiling chrono-tz-build v0.0.3 [INFO] [stderr] Compiling chrono-tz v0.6.3 [INFO] [stdout] warning: use of deprecated associated function `chrono::NaiveDateTime::from_timestamp_opt`: use `DateTime::from_timestamp` instead [INFO] [stdout] --> src/parser.rs:333:41 [INFO] [stdout] | [INFO] [stdout] 333 | let dt = NaiveDateTime::from_timestamp_opt(ts, 0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::NaiveDateTime::from_timestamp_opt`: use `DateTime::from_timestamp` instead [INFO] [stdout] --> src/parser.rs:333:41 [INFO] [stdout] | [INFO] [stdout] 333 | let dt = NaiveDateTime::from_timestamp_opt(ts, 0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/location.rs:146:28 [INFO] [stdout] | [INFO] [stdout] 146 | || x.admin_code.map_or(false, |x| x.eq_ignore_ascii_case(code))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 146 - || x.admin_code.map_or(false, |x| x.eq_ignore_ascii_case(code))) [INFO] [stdout] 146 + || x.admin_code.is_some_and(|x| x.eq_ignore_ascii_case(code))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/parser.rs:110:6 [INFO] [stdout] | [INFO] [stdout] 110 | impl<'a> Serialize for TimeAtLocation { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `self.locations.get(0)` [INFO] [stdout] --> src/parser.rs:168:9 [INFO] [stdout] | [INFO] [stdout] 168 | self.locations.get(0).copied() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `self.locations.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/parser.rs:543:41 [INFO] [stdout] | [INFO] [stdout] 543 | && (rv.locations.is_empty() || !find_zone(rv.locations[0]).map_or(false, |x| x.is_utc())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 543 - && (rv.locations.is_empty() || !find_zone(rv.locations[0]).map_or(false, |x| x.is_utc())) [INFO] [stdout] 543 + && (rv.locations.is_empty() || !find_zone(rv.locations[0]).is_some_and(|x| x.is_utc())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/location.rs:146:28 [INFO] [stdout] | [INFO] [stdout] 146 | || x.admin_code.map_or(false, |x| x.eq_ignore_ascii_case(code))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 146 - || x.admin_code.map_or(false, |x| x.eq_ignore_ascii_case(code))) [INFO] [stdout] 146 + || x.admin_code.is_some_and(|x| x.eq_ignore_ascii_case(code))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/parser.rs:110:6 [INFO] [stdout] | [INFO] [stdout] 110 | impl<'a> Serialize for TimeAtLocation { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `self.locations.get(0)` [INFO] [stdout] --> src/parser.rs:168:9 [INFO] [stdout] | [INFO] [stdout] 168 | self.locations.get(0).copied() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `self.locations.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/parser.rs:543:41 [INFO] [stdout] | [INFO] [stdout] 543 | && (rv.locations.is_empty() || !find_zone(rv.locations[0]).map_or(false, |x| x.is_utc())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 543 - && (rv.locations.is_empty() || !find_zone(rv.locations[0]).map_or(false, |x| x.is_utc())) [INFO] [stdout] 543 + && (rv.locations.is_empty() || !find_zone(rv.locations[0]).is_some_and(|x| x.is_utc())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 28.62s [INFO] running `Command { std: "docker" "inspect" "53b506e15a00c60086400340499bf28d2a931bc6612570631cfb786b3e160734", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "53b506e15a00c60086400340499bf28d2a931bc6612570631cfb786b3e160734", kill_on_drop: false }` [INFO] [stdout] 53b506e15a00c60086400340499bf28d2a931bc6612570631cfb786b3e160734