[INFO] fetching crate libreda-structural-verilog 0.0.5... [INFO] linting libreda-structural-verilog-0.0.5 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate libreda-structural-verilog 0.0.5 into /workspace/builds/worker-4-tc1/source [INFO] started tweaking crates.io crate libreda-structural-verilog 0.0.5 [INFO] finished tweaking crates.io crate libreda-structural-verilog 0.0.5 [INFO] tweaked toml for crates.io crate libreda-structural-verilog 0.0.5 written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate libreda-structural-verilog 0.0.5 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 97 packages to latest compatible versions [INFO] [stderr] Adding itertools v0.13.0 (available: v0.14.0) [INFO] [stderr] Adding lalrpop v0.20.2 (available: v0.23.1) [INFO] [stderr] Adding lalrpop-util v0.20.2 (available: v0.23.1) [INFO] [stderr] Adding petgraph v0.6.5 (available: v0.8.3) [INFO] [stderr] Adding regex v1.10.6 (available: v1.12.3) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded libreda-splay v0.1.1 [INFO] [stderr] Downloaded iron-shapes-booleanop v0.1.0 [INFO] [stderr] Downloaded portrait-framework v0.2.1 [INFO] [stderr] Downloaded portrait v0.2.3 [INFO] [stderr] Downloaded portrait-codegen v0.2.3 [INFO] [stderr] Downloaded libreda-db v0.0.12 [INFO] [stderr] Downloaded iron-shapes v0.1.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8c5a32e8dabdbb44a9e620c6512a326d391c0a2ec6cc1c8566c615211958f72d [INFO] running `Command { std: "docker" "start" "-a" "8c5a32e8dabdbb44a9e620c6512a326d391c0a2ec6cc1c8566c615211958f72d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8c5a32e8dabdbb44a9e620c6512a326d391c0a2ec6cc1c8566c615211958f72d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8c5a32e8dabdbb44a9e620c6512a326d391c0a2ec6cc1c8566c615211958f72d", kill_on_drop: false }` [INFO] [stdout] 8c5a32e8dabdbb44a9e620c6512a326d391c0a2ec6cc1c8566c615211958f72d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 35c31352bbead9672eb1f05bf167e6b0077ec987c688286a42f2bc1db6eef032 [INFO] running `Command { std: "docker" "start" "-a" "35c31352bbead9672eb1f05bf167e6b0077ec987c688286a42f2bc1db6eef032", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.183 [INFO] [stderr] Compiling smallvec v1.15.1 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling zerocopy v0.8.42 [INFO] [stderr] Compiling aho-corasick v1.1.4 [INFO] [stderr] Compiling parking_lot_core v0.9.12 [INFO] [stderr] Compiling lock_api v0.4.14 [INFO] [stderr] Compiling crunchy v0.2.4 [INFO] [stderr] Compiling siphasher v1.0.2 [INFO] [stderr] Checking libm v0.2.16 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Compiling heapless v0.7.17 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Compiling new_debug_unreachable v1.0.6 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling bit-vec v0.6.3 [INFO] [stderr] Compiling petgraph v0.6.5 [INFO] [stderr] Checking hash32 v0.2.1 [INFO] [stderr] Compiling walkdir v2.5.0 [INFO] [stderr] Compiling ena v0.14.4 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Compiling itertools v0.10.5 [INFO] [stderr] Compiling phf_shared v0.11.3 [INFO] [stderr] Compiling bit-set v0.5.3 [INFO] [stderr] Compiling itertools v0.11.0 [INFO] [stderr] Compiling pico-args v0.5.0 [INFO] [stderr] Compiling unicode-xid v0.2.6 [INFO] [stderr] Checking regex-syntax v0.8.10 [INFO] [stderr] Checking libreda-splay v0.1.1 [INFO] [stderr] Compiling getrandom v0.2.17 [INFO] [stderr] Compiling dirs-sys-next v0.1.2 [INFO] [stderr] Compiling parking_lot v0.12.5 [INFO] [stderr] Compiling dirs-next v2.0.0 [INFO] [stderr] Compiling regex-automata v0.4.14 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Compiling term v0.7.0 [INFO] [stderr] Compiling string_cache v0.8.9 [INFO] [stderr] Compiling ascii-canvas v3.0.0 [INFO] [stderr] Compiling num-derive v0.3.3 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking rstar v0.9.3 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking lalrpop-util v0.20.2 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Compiling lalrpop v0.20.2 [INFO] [stderr] Compiling ppv-lite86 v0.2.21 [INFO] [stderr] Compiling rand_chacha v0.3.1 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Compiling portrait-framework v0.2.1 [INFO] [stderr] Compiling portrait-codegen v0.2.3 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking portrait v0.2.3 [INFO] [stderr] Checking iron-shapes v0.1.1 [INFO] [stderr] Checking iron-shapes-booleanop v0.1.0 [INFO] [stderr] Checking libreda-db v0.0.12 [INFO] [stderr] Compiling libreda-structural-verilog v0.0.5 (/opt/rustwide/workdir) [INFO] [stdout] warning: consider choosing a more descriptive name [INFO] [stdout] --> src/ast.rs:148:9 [INFO] [stdout] | [INFO] [stdout] 148 | let _0 = Bit::Zero; [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stdout] = note: `#[warn(clippy::just_underscores_and_digits)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider choosing a more descriptive name [INFO] [stdout] --> src/ast.rs:149:9 [INFO] [stdout] | [INFO] [stdout] 149 | let _1 = Bit::One; [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after outer attribute [INFO] [stdout] --> /opt/rustwide/target/debug/build/libreda-structural-verilog-ff35f054b1433591/out/grammar.rs:9150:1 [INFO] [stdout] | [INFO] [stdout] 9150 | / #[allow(clippy::type_complexity, dead_code)] [INFO] [stdout] 9151 | | [INFO] [stdout] | |_^ [INFO] [stdout] 9152 | pub trait __ToTriple<'input, > [INFO] [stdout] | --------------------- the attribute applies to this trait [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_outer_attr [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_outer_attr)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after outer attribute [INFO] [stdout] --> /opt/rustwide/target/debug/build/libreda-structural-verilog-ff35f054b1433591/out/grammar.rs:9150:1 [INFO] [stdout] | [INFO] [stdout] 9150 | / #[allow(clippy::type_complexity, dead_code)] [INFO] [stdout] 9151 | | [INFO] [stdout] | |_^ [INFO] [stdout] 9152 | pub trait __ToTriple<'input, > [INFO] [stdout] | --------------------- the attribute applies to this trait [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_outer_attr [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_outer_attr)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/ast.rs:102:30 [INFO] [stdout] | [INFO] [stdout] 102 | pub fn to_bits_lsb_first(&self) -> Vec { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/ast.rs:102:30 [INFO] [stdout] | [INFO] [stdout] 102 | pub fn to_bits_lsb_first(&self) -> Vec { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/ast.rs:121:13 [INFO] [stdout] | [INFO] [stdout] 121 | value = value >> 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `value >>= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/ast.rs:122:13 [INFO] [stdout] | [INFO] [stdout] 122 | xs = xs >> 1; [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `xs >>= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/ast.rs:123:13 [INFO] [stdout] | [INFO] [stdout] 123 | zs = zs >> 1; [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `zs >>= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/ast.rs:134:30 [INFO] [stdout] | [INFO] [stdout] 134 | pub fn to_bits_msb_first(&self) -> Vec { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/ast.rs:121:13 [INFO] [stdout] | [INFO] [stdout] 121 | value = value >> 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `value >>= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/ast.rs:122:13 [INFO] [stdout] | [INFO] [stdout] 122 | xs = xs >> 1; [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `xs >>= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/ast.rs:123:13 [INFO] [stdout] | [INFO] [stdout] 123 | zs = zs >> 1; [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `zs >>= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/ast.rs:134:30 [INFO] [stdout] | [INFO] [stdout] 134 | pub fn to_bits_msb_first(&self) -> Vec { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/ast.rs:175:28 [INFO] [stdout] | [INFO] [stdout] 175 | let non_xz = s.replace(&is_xz, "0"); [INFO] [stdout] | ^^^^^^ help: change this to: `is_xz` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/ast.rs:176:50 [INFO] [stdout] | [INFO] [stdout] 176 | let x = s.replace(|c| !is_x(c), "0").replace(&is_x, one_digit); [INFO] [stdout] | ^^^^^ help: change this to: `is_x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/ast.rs:177:50 [INFO] [stdout] | [INFO] [stdout] 177 | let z = s.replace(|c| !is_z(c), "0").replace(&is_z, one_digit); [INFO] [stdout] | ^^^^^ help: change this to: `is_z` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/ast.rs:175:28 [INFO] [stdout] | [INFO] [stdout] 175 | let non_xz = s.replace(&is_xz, "0"); [INFO] [stdout] | ^^^^^^ help: change this to: `is_xz` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/ast.rs:176:50 [INFO] [stdout] | [INFO] [stdout] 176 | let x = s.replace(|c| !is_x(c), "0").replace(&is_x, one_digit); [INFO] [stdout] | ^^^^^ help: change this to: `is_x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/ast.rs:177:50 [INFO] [stdout] | [INFO] [stdout] 177 | let z = s.replace(|c| !is_z(c), "0").replace(&is_z, one_digit); [INFO] [stdout] | ^^^^^ help: change this to: `is_z` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `from_str_radix` can be replaced with a call to `str::parse` [INFO] [stdout] --> /opt/rustwide/target/debug/build/libreda-structural-verilog-ff35f054b1433591/out/grammar.rs:6203:5 [INFO] [stdout] | [INFO] [stdout] 6203 | u64::from_str_radix(__0[2..].replace("_", "").as_str(), 10).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `__0[2..].replace("_", "").as_str().parse::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_str_radix_10 [INFO] [stdout] = note: `#[warn(clippy::from_str_radix_10)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `from_str_radix` can be replaced with a call to `str::parse` [INFO] [stdout] --> /opt/rustwide/target/debug/build/libreda-structural-verilog-ff35f054b1433591/out/grammar.rs:6203:5 [INFO] [stdout] | [INFO] [stdout] 6203 | u64::from_str_radix(__0[2..].replace("_", "").as_str(), 10).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `__0[2..].replace("_", "").as_str().parse::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_str_radix_10 [INFO] [stdout] = note: `#[warn(clippy::from_str_radix_10)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `StructuralVerilogReader` [INFO] [stdout] --> src/reader.rs:127:5 [INFO] [stdout] | [INFO] [stdout] 127 | / pub fn new() -> Self { [INFO] [stdout] 128 | | StructuralVerilogReader { [INFO] [stdout] 129 | | load_blackboxes: false, [INFO] [stdout] 130 | | } [INFO] [stdout] 131 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 125 + impl Default for StructuralVerilogReader { [INFO] [stdout] 126 + fn default() -> Self { [INFO] [stdout] 127 + Self::new() [INFO] [stdout] 128 + } [INFO] [stdout] 129 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/reader.rs:201:28 [INFO] [stdout] | [INFO] [stdout] 201 | && !netlist.cell_by_name(name.as_str()).is_some() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `netlist.cell_by_name(name.as_str()).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `StructuralVerilogReader` [INFO] [stdout] --> src/reader.rs:127:5 [INFO] [stdout] | [INFO] [stdout] 127 | / pub fn new() -> Self { [INFO] [stdout] 128 | | StructuralVerilogReader { [INFO] [stdout] 129 | | load_blackboxes: false, [INFO] [stdout] 130 | | } [INFO] [stdout] 131 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 125 + impl Default for StructuralVerilogReader { [INFO] [stdout] 126 + fn default() -> Self { [INFO] [stdout] 127 + Self::new() [INFO] [stdout] 128 + } [INFO] [stdout] 129 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/reader.rs:201:28 [INFO] [stdout] | [INFO] [stdout] 201 | && !netlist.cell_by_name(name.as_str()).is_some() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `netlist.cell_by_name(name.as_str()).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::ops::RangeFrom` [INFO] [stdout] --> src/reader.rs:398:42 [INFO] [stdout] | [INFO] [stdout] 398 | let mut net_id_counter = (2..).into_iter().peekable(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(2..)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::ops::RangeFrom` [INFO] [stdout] --> src/reader.rs:398:42 [INFO] [stdout] | [INFO] [stdout] 398 | let mut net_id_counter = (2..).into_iter().peekable(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(2..)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/reader.rs:589:61 [INFO] [stdout] | [INFO] [stdout] 589 | ... let pin_name = netlist.pin_name(&pin_id); [INFO] [stdout] | ^^^^^^^ help: change this to: `pin_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/reader.rs:589:61 [INFO] [stdout] | [INFO] [stdout] 589 | ... let pin_name = netlist.pin_name(&pin_id); [INFO] [stdout] | ^^^^^^^ help: change this to: `pin_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` [INFO] [stdout] --> src/reader.rs:724:71 [INFO] [stdout] | [INFO] [stdout] 724 | ... for (&pin_position, net) in pin_positions.into_iter().zip(flat_nets) { [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/reader.rs:745:72 [INFO] [stdout] | [INFO] [stdout] 745 | ... find_net_ids(&net_ids_by_name, &expr).into_iter()) [INFO] [stdout] | ^^^^^ help: change this to: `expr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` [INFO] [stdout] --> src/reader.rs:724:71 [INFO] [stdout] | [INFO] [stdout] 724 | ... for (&pin_position, net) in pin_positions.into_iter().zip(flat_nets) { [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/reader.rs:745:72 [INFO] [stdout] | [INFO] [stdout] 745 | ... find_net_ids(&net_ids_by_name, &expr).into_iter()) [INFO] [stdout] | ^^^^^ help: change this to: `expr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling .bytes() is very inefficient when data is not in memory [INFO] [stdout] --> src/reader.rs:857:37 [INFO] [stdout] | [INFO] [stdout] 857 | let verilog_data: Vec = reader.bytes().map(|b| b.unwrap()).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `BufReader` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unbuffered_bytes [INFO] [stdout] = note: `#[warn(clippy::unbuffered_bytes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling .bytes() is very inefficient when data is not in memory [INFO] [stdout] --> src/reader.rs:857:37 [INFO] [stdout] | [INFO] [stdout] 857 | let verilog_data: Vec = reader.bytes().map(|b| b.unwrap()).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `BufReader` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unbuffered_bytes [INFO] [stdout] = note: `#[warn(clippy::unbuffered_bytes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `StructuralVerilogWriter` [INFO] [stdout] --> src/writer.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 37 | / pub fn new() -> Self { [INFO] [stdout] 38 | | StructuralVerilogWriter {} [INFO] [stdout] 39 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 35 + impl Default for StructuralVerilogWriter { [INFO] [stdout] 36 + fn default() -> Self { [INFO] [stdout] 37 + Self::new() [INFO] [stdout] 38 + } [INFO] [stdout] 39 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/writer.rs:46:57 [INFO] [stdout] | [INFO] [stdout] 46 | let is_legal_char_when_masked = |c: char| -> bool { '!' <= c && c <= '~' }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `('!'..='~').contains(&c)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/writer.rs:49:16 [INFO] [stdout] | [INFO] [stdout] 49 | || 'a' <= c && c <= 'z' [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `('a'..='z').contains(&c)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `StructuralVerilogWriter` [INFO] [stdout] --> src/writer.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 37 | / pub fn new() -> Self { [INFO] [stdout] 38 | | StructuralVerilogWriter {} [INFO] [stdout] 39 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 35 + impl Default for StructuralVerilogWriter { [INFO] [stdout] 36 + fn default() -> Self { [INFO] [stdout] 37 + Self::new() [INFO] [stdout] 38 + } [INFO] [stdout] 39 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/writer.rs:46:57 [INFO] [stdout] | [INFO] [stdout] 46 | let is_legal_char_when_masked = |c: char| -> bool { '!' <= c && c <= '~' }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `('!'..='~').contains(&c)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/writer.rs:49:16 [INFO] [stdout] | [INFO] [stdout] 49 | || 'a' <= c && c <= 'z' [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `('a'..='z').contains(&c)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::ops::RangeFrom` [INFO] [stdout] --> src/writer.rs:136:40 [INFO] [stdout] | [INFO] [stdout] 136 | let mut net_name_counter = (0..).into_iter(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::ops::RangeFrom` [INFO] [stdout] --> src/writer.rs:147:29 [INFO] [stdout] | [INFO] [stdout] 147 | / ... (0..) [INFO] [stdout] 148 | | ... .into_iter() [INFO] [stdout] | |______________________________________^ help: consider removing `.into_iter()`: `(0..)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::ops::RangeFrom` [INFO] [stdout] --> src/writer.rs:169:45 [INFO] [stdout] | [INFO] [stdout] 169 | let mut instance_name_counter = (0..).into_iter(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::ops::RangeFrom` [INFO] [stdout] --> src/writer.rs:136:40 [INFO] [stdout] | [INFO] [stdout] 136 | let mut net_name_counter = (0..).into_iter(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::ops::RangeFrom` [INFO] [stdout] --> src/writer.rs:177:21 [INFO] [stdout] | [INFO] [stdout] 177 | / (0..) [INFO] [stdout] 178 | | .into_iter() [INFO] [stdout] | |____________________________________^ help: consider removing `.into_iter()`: `(0..)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::ops::RangeFrom` [INFO] [stdout] --> src/writer.rs:147:29 [INFO] [stdout] | [INFO] [stdout] 147 | / ... (0..) [INFO] [stdout] 148 | | ... .into_iter() [INFO] [stdout] | |______________________________________^ help: consider removing `.into_iter()`: `(0..)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::ops::RangeFrom` [INFO] [stdout] --> src/writer.rs:169:45 [INFO] [stdout] | [INFO] [stdout] 169 | let mut instance_name_counter = (0..).into_iter(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::ops::RangeFrom` [INFO] [stdout] --> src/writer.rs:177:21 [INFO] [stdout] | [INFO] [stdout] 177 | / (0..) [INFO] [stdout] 178 | | .into_iter() [INFO] [stdout] | |____________________________________^ help: consider removing `.into_iter()`: `(0..)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 22.68s [INFO] running `Command { std: "docker" "inspect" "35c31352bbead9672eb1f05bf167e6b0077ec987c688286a42f2bc1db6eef032", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "35c31352bbead9672eb1f05bf167e6b0077ec987c688286a42f2bc1db6eef032", kill_on_drop: false }` [INFO] [stdout] 35c31352bbead9672eb1f05bf167e6b0077ec987c688286a42f2bc1db6eef032