[INFO] fetching crate libcrux-psq 0.0.7... [INFO] linting libcrux-psq-0.0.7 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate libcrux-psq 0.0.7 into /workspace/builds/worker-6-tc1/source [INFO] started tweaking crates.io crate libcrux-psq 0.0.7 [INFO] removed 0 missing examples [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate libcrux-psq 0.0.7 [INFO] tweaked toml for crates.io crate libcrux-psq 0.0.7 written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate libcrux-psq 0.0.7 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate libcrux-psq 0.0.7 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded libcrux-platform v0.0.3 [INFO] [stderr] Downloaded libcrux-macros v0.0.3 [INFO] [stderr] Downloaded pretty_env_logger v0.5.0 [INFO] [stderr] Downloaded libcrux-sha2 v0.0.6 [INFO] [stderr] Downloaded libcrux-secrets v0.0.5 [INFO] [stderr] Downloaded libcrux-traits v0.0.6 [INFO] [stderr] Downloaded libcrux-sha3 v0.0.7 [INFO] [stderr] Downloaded libcrux-poly1305 v0.0.4 [INFO] [stderr] Downloaded pastey v0.2.0 [INFO] [stderr] Downloaded libcrux-chacha20poly1305 v0.0.6 [INFO] [stderr] Downloaded libcrux-hkdf v0.0.6 [INFO] [stderr] Downloaded classic-mceliece-rust v3.1.0 [INFO] [stderr] Downloaded libcrux-aesgcm v0.0.7 [INFO] [stderr] Downloaded libcrux-ecdh v0.0.6 [INFO] [stderr] Downloaded libcrux-ml-kem v0.0.7 [INFO] [stderr] Downloaded libcrux-ml-dsa v0.0.7 [INFO] [stderr] Downloaded libcrux-ed25519 v0.0.6 [INFO] [stderr] Downloaded libcrux-p256 v0.0.6 [INFO] [stderr] Downloaded core-models v0.0.5 [INFO] [stderr] Downloaded libcrux-hmac v0.0.6 [INFO] [stderr] Downloaded libcrux-curve25519 v0.0.6 [INFO] [stderr] Downloaded libcrux-kem v0.0.6 [INFO] [stderr] Downloaded libcrux-intrinsics v0.0.6 [INFO] [stderr] Downloaded libcrux-hacl-rs v0.0.4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8c049d67950b671d7e5e644716924d3bc99380aea1098d20a007f125f969bb14 [INFO] running `Command { std: "docker" "start" "-a" "8c049d67950b671d7e5e644716924d3bc99380aea1098d20a007f125f969bb14", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8c049d67950b671d7e5e644716924d3bc99380aea1098d20a007f125f969bb14", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8c049d67950b671d7e5e644716924d3bc99380aea1098d20a007f125f969bb14", kill_on_drop: false }` [INFO] [stdout] 8c049d67950b671d7e5e644716924d3bc99380aea1098d20a007f125f969bb14 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] de27ef656f1b9550c0b2aad3bd33f5427068723694e0d9c0ffd90a1a28db7239 [INFO] running `Command { std: "docker" "start" "-a" "de27ef656f1b9550c0b2aad3bd33f5427068723694e0d9c0ffd90a1a28db7239", kill_on_drop: false }` [INFO] [stderr] Compiling zerocopy v0.8.27 [INFO] [stderr] Compiling hax-lib v0.3.6 [INFO] [stderr] Compiling quote v1.0.41 [INFO] [stderr] Compiling libcrux-intrinsics v0.0.6 [INFO] [stderr] Compiling libcrux-sha3 v0.0.7 [INFO] [stderr] Checking libcrux-platform v0.0.3 [INFO] [stderr] Checking aho-corasick v1.1.4 [INFO] [stderr] Compiling cc v1.2.44 [INFO] [stderr] Compiling libcrux-ml-kem v0.0.7 [INFO] [stderr] Checking anstyle-query v1.1.4 [INFO] [stderr] Compiling libcrux-aesgcm v0.0.7 [INFO] [stderr] Compiling libcrux-ml-dsa v0.0.7 [INFO] [stderr] Checking clap_lex v0.7.6 [INFO] [stderr] Checking anstream v0.6.21 [INFO] [stderr] Checking is-terminal v0.4.17 [INFO] [stderr] Compiling syn v2.0.108 [INFO] [stderr] Checking humantime v2.3.0 [INFO] [stderr] Checking criterion-plot v0.8.1 [INFO] [stderr] Checking page_size v0.6.0 [INFO] [stderr] Checking clap_builder v4.5.51 [INFO] [stderr] Checking regex-automata v0.4.13 [INFO] [stderr] Compiling alloca v0.4.0 [INFO] [stderr] Checking regex v1.12.2 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Checking pretty_env_logger v0.5.0 [INFO] [stderr] Compiling zerocopy-derive v0.8.27 [INFO] [stderr] Compiling hax-lib-macros v0.3.6 [INFO] [stderr] Compiling libcrux-macros v0.0.3 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Compiling tls_codec_derive v0.4.2 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling clap_derive v4.5.49 [INFO] [stderr] Checking libcrux-hacl-rs v0.0.4 [INFO] [stderr] Checking libcrux-secrets v0.0.5 [INFO] [stderr] Checking zeroize v1.8.2 [INFO] [stderr] Checking tls_codec v0.4.2 [INFO] [stderr] Checking clap v4.5.51 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking half v2.7.1 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking libcrux-traits v0.0.6 [INFO] [stderr] Checking criterion v0.8.1 [INFO] [stderr] Checking libcrux-sha2 v0.0.6 [INFO] [stderr] Checking libcrux-curve25519 v0.0.6 [INFO] [stderr] Checking libcrux-poly1305 v0.0.4 [INFO] [stderr] Checking libcrux-chacha20poly1305 v0.0.6 [INFO] [stderr] Checking libcrux-p256 v0.0.6 [INFO] [stderr] Checking libcrux-hmac v0.0.6 [INFO] [stderr] Checking libcrux-ed25519 v0.0.6 [INFO] [stderr] Checking libcrux-hkdf v0.0.6 [INFO] [stderr] Checking libcrux-ecdh v0.0.6 [INFO] [stderr] Checking libcrux-kem v0.0.6 [INFO] [stderr] Checking libcrux-psq v0.0.7 (/opt/rustwide/workdir) [INFO] [stdout] warning: using `clone` on type `DHPublicKey` which implements the `Copy` trait [INFO] [stdout] --> src/handshake/dhkem.rs:42:27 [INFO] [stdout] | [INFO] [stdout] 42 | Authenticator::Dh(self.clone()) [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/handshake/dhkem.rs:72:53 [INFO] [stdout] | [INFO] [stdout] 72 | libcrux_ecdh::derive(Algorithm::X25519, &pk.0, &sk.0) [INFO] [stdout] | ^^^^^ help: change this to: `pk.0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/handshake/dhkem.rs:100:12 [INFO] [stdout] | [INFO] [stdout] 100 | if !libcrux_ecdh::validate_scalar(libcrux_ecdh::Algorithm::X25519, value).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `libcrux_ecdh::validate_scalar(libcrux_ecdh::Algorithm::X25519, value).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `DHPublicKey` which implements the `Copy` trait [INFO] [stdout] --> src/handshake/dhkem.rs:42:27 [INFO] [stdout] | [INFO] [stdout] 42 | Authenticator::Dh(self.clone()) [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/handshake/dhkem.rs:72:53 [INFO] [stdout] | [INFO] [stdout] 72 | libcrux_ecdh::derive(Algorithm::X25519, &pk.0, &sk.0) [INFO] [stdout] | ^^^^^ help: change this to: `pk.0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/handshake/dhkem.rs:100:12 [INFO] [stdout] | [INFO] [stdout] 100 | if !libcrux_ecdh::validate_scalar(libcrux_ecdh::Algorithm::X25519, value).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `libcrux_ecdh::validate_scalar(libcrux_ecdh::Algorithm::X25519, value).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `DHPublicKey` which implements the `Copy` trait [INFO] [stdout] --> src/handshake/responder.rs:521:29 [INFO] [stdout] | [INFO] [stdout] 521 | .push_front(initiator_outer_message.pk.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `initiator_outer_message.pk` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `DHPublicKey` which implements the `Copy` trait [INFO] [stdout] --> src/handshake/responder.rs:521:29 [INFO] [stdout] | [INFO] [stdout] 521 | .push_front(initiator_outer_message.pk.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `initiator_outer_message.pk` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `DHPublicKey` which implements the `Copy` trait [INFO] [stdout] --> src/handshake/ciphersuite/types.rs:51:55 [INFO] [stdout] | [INFO] [stdout] 51 | Auth::DH(dhkey_pair) => Authenticator::Dh(dhkey_pair.pk.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `dhkey_pair.pk` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `DHPublicKey` which implements the `Copy` trait [INFO] [stdout] --> src/handshake/ciphersuite/types.rs:51:55 [INFO] [stdout] | [INFO] [stdout] 51 | Auth::DH(dhkey_pair) => Authenticator::Dh(dhkey_pair.pk.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `dhkey_pair.pk` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> tests/registration.rs:27:53 [INFO] [stdout] | [INFO] [stdout] 27 | static SETUP: LazyLock = LazyLock::new(|| CommonSetup::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `CommonSetup::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `DHPublicKey` which implements the `Copy` trait [INFO] [stdout] --> tests/registration.rs:93:35 [INFO] [stdout] | [INFO] [stdout] 93 | Authenticator::Dh(self.initiator_x25519_keys.pk.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.initiator_x25519_keys.pk` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> tests/registration.rs:633:9 [INFO] [stdout] | [INFO] [stdout] 633 | &*SETUP, [INFO] [stdout] | ^^^^^^^ help: try: `&SETUP` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> tests/registration.rs:637:9 [INFO] [stdout] | [INFO] [stdout] 637 | &*SETUP, [INFO] [stdout] | ^^^^^^^ help: try: `&SETUP` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> benches/psq_v2.rs:71:23 [INFO] [stdout] | [INFO] [stdout] 71 | c.bench_function(&format!("[Query] Initiator setup"), |b| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"[Query] Initiator setup".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> benches/psq_v2.rs:73:13 [INFO] [stdout] | [INFO] [stdout] 73 | || rand::rng(), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace the closure with the function itself: `rand::rng` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> benches/psq_v2.rs:85:13 [INFO] [stdout] | [INFO] [stdout] 85 | || rand::rng(), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace the closure with the function itself: `rand::rng` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> benches/psq_v2.rs:243:23 [INFO] [stdout] | [INFO] [stdout] 243 | c.bench_function(&format!("[Registration] Initiator setup"), |b| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"[Registration] Initiator setup".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> benches/psq_v2.rs:245:13 [INFO] [stdout] | [INFO] [stdout] 245 | || rand::rng(), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace the closure with the function itself: `rand::rng` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> benches/psq_v2.rs:266:17 [INFO] [stdout] | [INFO] [stdout] 266 | || rand::rng(), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace the closure with the function itself: `rand::rng` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 37.22s [INFO] running `Command { std: "docker" "inspect" "de27ef656f1b9550c0b2aad3bd33f5427068723694e0d9c0ffd90a1a28db7239", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "de27ef656f1b9550c0b2aad3bd33f5427068723694e0d9c0ffd90a1a28db7239", kill_on_drop: false }` [INFO] [stdout] de27ef656f1b9550c0b2aad3bd33f5427068723694e0d9c0ffd90a1a28db7239