[INFO] fetching crate lbfgsbrs 0.1.2... [INFO] linting lbfgsbrs-0.1.2 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate lbfgsbrs 0.1.2 into /workspace/builds/worker-4-tc1/source [INFO] started tweaking crates.io crate lbfgsbrs 0.1.2 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate lbfgsbrs 0.1.2 [INFO] tweaked toml for crates.io crate lbfgsbrs 0.1.2 written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate lbfgsbrs 0.1.2 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate lbfgsbrs 0.1.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded anstyle-query v1.1.3 [INFO] [stderr] Downloaded anstyle-wincon v3.0.9 [INFO] [stderr] Downloaded anstream v0.6.19 [INFO] [stderr] Downloaded syn v2.0.101 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] aafb681ea9607ba63816e9ecc37727eb3039ba95240d32d0323a5e033a99bfaa [INFO] running `Command { std: "docker" "start" "-a" "aafb681ea9607ba63816e9ecc37727eb3039ba95240d32d0323a5e033a99bfaa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "aafb681ea9607ba63816e9ecc37727eb3039ba95240d32d0323a5e033a99bfaa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "aafb681ea9607ba63816e9ecc37727eb3039ba95240d32d0323a5e033a99bfaa", kill_on_drop: false }` [INFO] [stdout] aafb681ea9607ba63816e9ecc37727eb3039ba95240d32d0323a5e033a99bfaa [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 447b9d544f1232acbdb18dc4ecb232d7bdec00c95d4d040b6f41e8fa14bd8422 [INFO] running `Command { std: "docker" "start" "-a" "447b9d544f1232acbdb18dc4ecb232d7bdec00c95d4d040b6f41e8fa14bd8422", kill_on_drop: false }` [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking regex-syntax v0.8.5 [INFO] [stderr] Checking log v0.4.27 [INFO] [stderr] Compiling lbfgsbrs v0.1.2 (/opt/rustwide/workdir) [INFO] [stderr] Checking anstyle-query v1.1.3 [INFO] [stderr] Checking jiff v0.2.14 [INFO] [stderr] Checking anstream v0.6.19 [INFO] [stdout] warning: unused import: `super::timer::timer` [INFO] [stdout] --> src/lbfgsb.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use super::timer::timer; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lbfgsb.rs:103:13 [INFO] [stdout] | [INFO] [stdout] 103 | n: n, [INFO] [stdout] | ^^^^ help: replace it with: `n` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lbfgsb.rs:108:13 [INFO] [stdout] | [INFO] [stdout] 108 | f: f, [INFO] [stdout] | ^^^^ help: replace it with: `f` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lbfgsb.rs:109:13 [INFO] [stdout] | [INFO] [stdout] 109 | g: g, [INFO] [stdout] | ^^^^ help: replace it with: `g` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lbfgsb.rs:117:13 [INFO] [stdout] | [INFO] [stdout] 117 | params: params [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `params` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stdout] warning: taking a mutable reference to a `const` item [INFO] [stdout] --> src/linesearch.rs:162:9 [INFO] [stdout] | [INFO] [stdout] 162 | &mut FTOL, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: each usage of a `const` item creates a new temporary [INFO] [stdout] = note: the mutable reference will refer to this temporary, not the original `const` item [INFO] [stdout] note: `const` item defined here [INFO] [stdout] --> src/linesearch.rs:28:1 [INFO] [stdout] | [INFO] [stdout] 28 | pub const FTOL: f64 = 0.001f64; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(const_item_mutation)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taking a mutable reference to a `const` item [INFO] [stdout] --> src/linesearch.rs:163:9 [INFO] [stdout] | [INFO] [stdout] 163 | &mut GTOL, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: each usage of a `const` item creates a new temporary [INFO] [stdout] = note: the mutable reference will refer to this temporary, not the original `const` item [INFO] [stdout] note: `const` item defined here [INFO] [stdout] --> src/linesearch.rs:29:1 [INFO] [stdout] | [INFO] [stdout] 29 | pub const GTOL: f64 = 0.9f64; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taking a mutable reference to a `const` item [INFO] [stdout] --> src/linesearch.rs:164:9 [INFO] [stdout] | [INFO] [stdout] 164 | &mut XTOL, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: each usage of a `const` item creates a new temporary [INFO] [stdout] = note: the mutable reference will refer to this temporary, not the original `const` item [INFO] [stdout] note: `const` item defined here [INFO] [stdout] --> src/linesearch.rs:30:1 [INFO] [stdout] | [INFO] [stdout] 30 | pub const XTOL: f64 = 0.1f64; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taking a mutable reference to a `const` item [INFO] [stdout] --> src/linesearch.rs:165:9 [INFO] [stdout] | [INFO] [stdout] 165 | &mut STEPMIN, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: each usage of a `const` item creates a new temporary [INFO] [stdout] = note: the mutable reference will refer to this temporary, not the original `const` item [INFO] [stdout] note: `const` item defined here [INFO] [stdout] --> src/linesearch.rs:31:1 [INFO] [stdout] | [INFO] [stdout] 31 | pub const STEPMIN: f64 = 0.0f64; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `d` [INFO] [stdout] --> src/subalgorithms.rs:1135:17 [INFO] [stdout] | [INFO] [stdout] 1135 | let mut d = ddot(col as i32, &wn[(is * wn_dim) as usize..], 1, &wn[js * wn_dim..], 1); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_d` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lbfgsb.rs:107:25 [INFO] [stdout] | [INFO] [stdout] 107 | nbd: vec![0;n as usize], [INFO] [stdout] | ^^^^^^^^^^ help: try: `n` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lbfgsb.rs:110:29 [INFO] [stdout] | [INFO] [stdout] 110 | wa: vec![0.0f64;(2*params.m*n+11*params.m*params.m+params.m*n+8*params.m) as usize], [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((2*params.m*n+11*params.m*params.m+params.m*n+8*params.m))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lbfgsb.rs:111:27 [INFO] [stdout] | [INFO] [stdout] 111 | iwa: vec![0;3*n as usize], [INFO] [stdout] | ^^^^^^^^^^ help: try: `n` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (30/7) [INFO] [stdout] --> src/linesearch.rs:62:1 [INFO] [stdout] | [INFO] [stdout] 62 | / pub fn lnsrlb( [INFO] [stdout] 63 | | n: i32, [INFO] [stdout] 64 | | l: &[f64], [INFO] [stdout] 65 | | u: &[f64], [INFO] [stdout] ... | [INFO] [stdout] 92 | | dsave: &mut [f64], // Slice for dsave array [INFO] [stdout] 93 | | ) -> i32 { [INFO] [stdout] | |________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/linesearch.rs:95:17 [INFO] [stdout] | [INFO] [stdout] 95 | if *task != FG_LN as i32 { [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `FG_LN` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/linesearch.rs:101:12 [INFO] [stdout] | [INFO] [stdout] 101 | if cnstnd == true { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `cnstnd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/linesearch.rs:128:26 [INFO] [stdout] | [INFO] [stdout] 128 | if *iter == 0 && boxed == false { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `!boxed` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/linesearch.rs:142:18 [INFO] [stdout] | [INFO] [stdout] 142 | *csave = START as i32; [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `START` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i32` is unnecessary [INFO] [stdout] --> src/linesearch.rs:152:21 [INFO] [stdout] | [INFO] [stdout] 152 | *info = -(4) as i32; [INFO] [stdout] | ^^^^^^^^^^^ help: try: `-4_i32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/linesearch.rs:175:32 [INFO] [stdout] | [INFO] [stdout] 175 | let is_warning = *csave >= WARNING as i32 && *csave <= WARNING_END as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `WARNING` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/linesearch.rs:175:60 [INFO] [stdout] | [INFO] [stdout] 175 | let is_warning = *csave >= WARNING as i32 && *csave <= WARNING_END as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `WARNING_END` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/linesearch.rs:176:36 [INFO] [stdout] | [INFO] [stdout] 176 | let is_convergence = *csave >= CONVERGENCE as i32 && *csave <= CONVERGENCE_END as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `CONVERGENCE` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/linesearch.rs:176:68 [INFO] [stdout] | [INFO] [stdout] 176 | let is_convergence = *csave >= CONVERGENCE as i32 && *csave <= CONVERGENCE_END as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `CONVERGENCE_END` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/linesearch.rs:179:17 [INFO] [stdout] | [INFO] [stdout] 179 | *task = FG_LNSRCH as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `FG_LNSRCH` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like you're manually copying between slices [INFO] [stdout] --> src/linesearch.rs:186:13 [INFO] [stdout] | [INFO] [stdout] 186 | / for i in 0..n as usize { [INFO] [stdout] 187 | | x[i] = z[i]; [INFO] [stdout] 188 | | } [INFO] [stdout] | |_____________^ help: try replacing the loop by: `x[..(n as usize)].copy_from_slice(&z[..(n as usize)]);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stdout] = note: `#[warn(clippy::manual_memcpy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/linesearch.rs:196:17 [INFO] [stdout] | [INFO] [stdout] 196 | *task = NEW_X as i32; [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `NEW_X` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/linesearch.rs:348:12 [INFO] [stdout] | [INFO] [stdout] 348 | if !(*task >= WARNING as i32 && *task <= WARNING_END as i32) [INFO] [stdout] | ____________^ [INFO] [stdout] 349 | | && !(*task >= CONVERGENCE as i32 && *task <= CONVERGENCE_END as i32) { [INFO] [stdout] | |________________________________________________________________________________^ help: try: `!(*task >= WARNING as i32 && *task <= WARNING_END as i32 || *task >= CONVERGENCE as i32 && *task <= CONVERGENCE_END as i32)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/linesearch.rs:406:16 [INFO] [stdout] | [INFO] [stdout] 406 | if brackt == true && (*stp <= stmin || *stp >= stmax) [INFO] [stdout] | ________________^ [INFO] [stdout] 407 | | || (brackt == true && (stmax - stmin <= *xtol * stmax)) { [INFO] [stdout] | |_______________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 406 - if brackt == true && (*stp <= stmin || *stp >= stmax) [INFO] [stdout] 407 - || (brackt == true && (stmax - stmin <= *xtol * stmax)) { [INFO] [stdout] 406 + if !(brackt != true || *stp > stmin && *stp < stmax && stmax - stmin > *xtol * stmax) { [INFO] [stdout] | [INFO] [stdout] 406 - if brackt == true && (*stp <= stmin || *stp >= stmax) [INFO] [stdout] 407 - || (brackt == true && (stmax - stmin <= *xtol * stmax)) { [INFO] [stdout] 406 + if ((stmax - stmin <= *xtol * stmax) || *stp >= stmax || *stp <= stmin) && brackt == true { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (11/7) [INFO] [stdout] --> src/linesearch.rs:219:1 [INFO] [stdout] | [INFO] [stdout] 219 | / fn dcsrch( [INFO] [stdout] 220 | | f: &mut f64, [INFO] [stdout] 221 | | g: &mut f64, [INFO] [stdout] 222 | | stp: &mut f64, [INFO] [stdout] ... | [INFO] [stdout] 230 | | dsave: &mut [f64], // Slice for dsave array (needs 13 elements) [INFO] [stdout] 231 | | ) -> i32 { [INFO] [stdout] | |________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/linesearch.rs:255:17 [INFO] [stdout] | [INFO] [stdout] 255 | if *task == START as i32 { [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `START` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/linesearch.rs:258:21 [INFO] [stdout] | [INFO] [stdout] 258 | *task = ERROR_SMALLSTP as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `ERROR_SMALLSTP` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/linesearch.rs:261:21 [INFO] [stdout] | [INFO] [stdout] 261 | *task = ERROR_LARGESTP as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `ERROR_LARGESTP` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/linesearch.rs:264:21 [INFO] [stdout] | [INFO] [stdout] 264 | *task = ERROR_INITIAL as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `ERROR_INITIAL` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/linesearch.rs:267:21 [INFO] [stdout] | [INFO] [stdout] 267 | *task = ERROR_FTOL as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `ERROR_FTOL` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/linesearch.rs:270:21 [INFO] [stdout] | [INFO] [stdout] 270 | *task = ERROR_GTOL as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `ERROR_GTOL` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/linesearch.rs:273:21 [INFO] [stdout] | [INFO] [stdout] 273 | *task = ERROR_XTOL as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `ERROR_XTOL` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/linesearch.rs:276:21 [INFO] [stdout] | [INFO] [stdout] 276 | *task = ERROR_STP0 as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `ERROR_STP0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/linesearch.rs:279:21 [INFO] [stdout] | [INFO] [stdout] 279 | *task = ERROR_STP1 as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `ERROR_STP1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/linesearch.rs:282:22 [INFO] [stdout] | [INFO] [stdout] 282 | if (*task >= ERROR as i32) && (*task <= ERROR_END as i32) { [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `ERROR` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/linesearch.rs:282:49 [INFO] [stdout] | [INFO] [stdout] 282 | if (*task >= ERROR as i32) && (*task <= ERROR_END as i32) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `ERROR_END` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/linesearch.rs:305:17 [INFO] [stdout] | [INFO] [stdout] 305 | *task = FG as i32; [INFO] [stdout] | ^^^^^^^^^ help: try: `FG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/linesearch.rs:308:18 [INFO] [stdout] | [INFO] [stdout] 308 | brackt = if isave[21] == 1 { true } else { false }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `isave[21] == 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/linesearch.rs:331:12 [INFO] [stdout] | [INFO] [stdout] 331 | if brackt == true && (*stp <= stmin || *stp >= stmax) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `brackt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/linesearch.rs:332:21 [INFO] [stdout] | [INFO] [stdout] 332 | *task = WARNING_ROUND as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `WARNING_ROUND` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/linesearch.rs:334:12 [INFO] [stdout] | [INFO] [stdout] 334 | if brackt == true && stmax - stmin <= *xtol * stmax { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `brackt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/linesearch.rs:335:21 [INFO] [stdout] | [INFO] [stdout] 335 | *task = WARNING_XTOL as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `WARNING_XTOL` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/linesearch.rs:338:21 [INFO] [stdout] | [INFO] [stdout] 338 | *task = WARNING_STPMAX as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `WARNING_STPMAX` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/linesearch.rs:341:21 [INFO] [stdout] | [INFO] [stdout] 341 | *task = WARNING_STPMIN as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `WARNING_STPMIN` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/linesearch.rs:344:21 [INFO] [stdout] | [INFO] [stdout] 344 | *task = CONVERGENCE as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `CONVERGENCE` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/linesearch.rs:348:23 [INFO] [stdout] | [INFO] [stdout] 348 | if !(*task >= WARNING as i32 && *task <= WARNING_END as i32) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `WARNING` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/linesearch.rs:348:50 [INFO] [stdout] | [INFO] [stdout] 348 | if !(*task >= WARNING as i32 && *task <= WARNING_END as i32) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `WARNING_END` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/linesearch.rs:349:27 [INFO] [stdout] | [INFO] [stdout] 349 | && !(*task >= CONVERGENCE as i32 && *task <= CONVERGENCE_END as i32) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `CONVERGENCE` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/linesearch.rs:349:58 [INFO] [stdout] | [INFO] [stdout] 349 | && !(*task >= CONVERGENCE as i32 && *task <= CONVERGENCE_END as i32) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `CONVERGENCE_END` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/linesearch.rs:384:16 [INFO] [stdout] | [INFO] [stdout] 384 | if brackt == true { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `brackt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/linesearch.rs:393:16 [INFO] [stdout] | [INFO] [stdout] 393 | if brackt == true { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `brackt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/linesearch.rs:406:16 [INFO] [stdout] | [INFO] [stdout] 406 | if brackt == true && (*stp <= stmin || *stp >= stmax) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `brackt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/linesearch.rs:407:21 [INFO] [stdout] | [INFO] [stdout] 407 | || (brackt == true && (stmax - stmin <= *xtol * stmax)) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `brackt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/linesearch.rs:411:21 [INFO] [stdout] | [INFO] [stdout] 411 | *task = FG as i32; [INFO] [stdout] | ^^^^^^^^^ help: try: `FG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/linesearch.rs:416:20 [INFO] [stdout] | [INFO] [stdout] 416 | isave[21] = if brackt == true { 1 } else { 0 }; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `brackt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (12/7) [INFO] [stdout] --> src/linesearch.rs:447:1 [INFO] [stdout] | [INFO] [stdout] 447 | / fn dcstep( [INFO] [stdout] 448 | | stx: &mut f64, [INFO] [stdout] 449 | | fx: &mut f64, [INFO] [stdout] 450 | | dx: &mut f64, [INFO] [stdout] ... | [INFO] [stdout] 459 | | stpmax: &mut f64, [INFO] [stdout] 460 | | ) -> i32 { [INFO] [stdout] | |________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/linesearch.rs:518:12 [INFO] [stdout] | [INFO] [stdout] 518 | if *brackt == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `*brackt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/linesearch.rs:538:15 [INFO] [stdout] | [INFO] [stdout] 538 | } else if *brackt == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `*brackt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/miniblas.rs:198:17 [INFO] [stdout] | [INFO] [stdout] 198 | dx[i as usize] = da * dx[i as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dx[i as usize] *= da` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/miniblas.rs:207:13 [INFO] [stdout] | [INFO] [stdout] 207 | dx[i as usize] = da * dx[i as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dx[i as usize] *= da` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/miniblas.rs:208:13 [INFO] [stdout] | [INFO] [stdout] 208 | dx[(i + 1) as usize] = da * dx[(i + 1) as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dx[(i + 1) as usize] *= da` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/miniblas.rs:209:13 [INFO] [stdout] | [INFO] [stdout] 209 | dx[(i + 2) as usize] = da * dx[(i + 2) as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dx[(i + 2) as usize] *= da` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/miniblas.rs:210:13 [INFO] [stdout] | [INFO] [stdout] 210 | dx[(i + 3) as usize] = da * dx[(i + 3) as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dx[(i + 3) as usize] *= da` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/miniblas.rs:211:13 [INFO] [stdout] | [INFO] [stdout] 211 | dx[(i + 4) as usize] = da * dx[(i + 4) as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dx[(i + 4) as usize] *= da` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/miniblas.rs:217:13 [INFO] [stdout] | [INFO] [stdout] 217 | dx[ix as usize] = da * dx[ix as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dx[ix as usize] *= da` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i32` is unnecessary [INFO] [stdout] --> src/print.rs:6:24 [INFO] [stdout] | [INFO] [stdout] 6 | pub const ERROR: i32 = 200 as i32; [INFO] [stdout] | ^^^^^^^^^^ help: try: `200_i32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i32` is unnecessary [INFO] [stdout] --> src/print.rs:7:28 [INFO] [stdout] | [INFO] [stdout] 7 | pub const ERROR_END: i32 = 240 as i32; [INFO] [stdout] | ^^^^^^^^^^ help: try: `240_i32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i32` is unnecessary [INFO] [stdout] --> src/print.rs:8:27 [INFO] [stdout] | [INFO] [stdout] 8 | pub const ERROR_N0: i32 = 209 as i32; [INFO] [stdout] | ^^^^^^^^^^ help: try: `209_i32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i32` is unnecessary [INFO] [stdout] --> src/print.rs:9:27 [INFO] [stdout] | [INFO] [stdout] 9 | pub const ERROR_M0: i32 = 210 as i32; [INFO] [stdout] | ^^^^^^^^^^ help: try: `210_i32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i32` is unnecessary [INFO] [stdout] --> src/print.rs:10:30 [INFO] [stdout] | [INFO] [stdout] 10 | pub const ERROR_FACTR: i32 = 211 as i32; [INFO] [stdout] | ^^^^^^^^^^ help: try: `211_i32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i32` is unnecessary [INFO] [stdout] --> src/print.rs:11:28 [INFO] [stdout] | [INFO] [stdout] 11 | pub const ERROR_NBD: i32 = 212 as i32; [INFO] [stdout] | ^^^^^^^^^^ help: try: `212_i32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i32` is unnecessary [INFO] [stdout] --> src/print.rs:12:29 [INFO] [stdout] | [INFO] [stdout] 12 | pub const ERROR_FEAS: i32 = 213 as i32; [INFO] [stdout] | ^^^^^^^^^^ help: try: `213_i32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i32` is unnecessary [INFO] [stdout] --> src/print.rs:13:31 [INFO] [stdout] | [INFO] [stdout] 13 | pub const WORD_DEFAULT: i32 = 0 as i32; [INFO] [stdout] | ^^^^^^^^ help: try: `0_i32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i32` is unnecessary [INFO] [stdout] --> src/print.rs:14:27 [INFO] [stdout] | [INFO] [stdout] 14 | pub const WORD_CON: i32 = 1 as i32; [INFO] [stdout] | ^^^^^^^^ help: try: `1_i32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i32` is unnecessary [INFO] [stdout] --> src/print.rs:15:27 [INFO] [stdout] | [INFO] [stdout] 15 | pub const WORD_BND: i32 = 2 as i32; [INFO] [stdout] | ^^^^^^^^ help: try: `2_i32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i32` is unnecessary [INFO] [stdout] --> src/print.rs:16:27 [INFO] [stdout] | [INFO] [stdout] 16 | pub const WORD_TNT: i32 = 3 as i32; [INFO] [stdout] | ^^^^^^^^ help: try: `3_i32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `l` [INFO] [stdout] --> src/print.rs:34:14 [INFO] [stdout] | [INFO] [stdout] 34 | for i in 0..n as usize { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 34 - for i in 0..n as usize { [INFO] [stdout] 34 + for in l.iter().take(n as usize) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `x` [INFO] [stdout] --> src/print.rs:40:14 [INFO] [stdout] | [INFO] [stdout] 40 | for i in 0..n as usize { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 40 - for i in 0..n as usize { [INFO] [stdout] 40 + for in x.iter().take(n as usize) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `u` [INFO] [stdout] --> src/print.rs:46:14 [INFO] [stdout] | [INFO] [stdout] 46 | for i in 0..n as usize { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 46 - for i in 0..n as usize { [INFO] [stdout] 46 + for in u.iter().take(n as usize) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (10/7) [INFO] [stdout] --> src/print.rs:55:1 [INFO] [stdout] | [INFO] [stdout] 55 | / pub fn prn2lb( [INFO] [stdout] 56 | | n: i32, [INFO] [stdout] 57 | | x: &[f64], [INFO] [stdout] 58 | | f: f64, [INFO] [stdout] ... | [INFO] [stdout] 65 | | xstep: f64, [INFO] [stdout] 66 | | ) -> i32 { [INFO] [stdout] | |________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/print.rs:68:17 [INFO] [stdout] | [INFO] [stdout] 68 | *word = WORD_CON as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `WORD_CON` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/print.rs:70:17 [INFO] [stdout] | [INFO] [stdout] 70 | *word = WORD_BND as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `WORD_BND` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/print.rs:72:17 [INFO] [stdout] | [INFO] [stdout] 72 | *word = WORD_TNT as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `WORD_TNT` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/print.rs:74:17 [INFO] [stdout] | [INFO] [stdout] 74 | *word = WORD_DEFAULT as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `WORD_DEFAULT` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `x` [INFO] [stdout] --> src/print.rs:81:14 [INFO] [stdout] | [INFO] [stdout] 81 | for i in 0..n as usize { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 81 - for i in 0..n as usize { [INFO] [stdout] 81 + for in x.iter().take(n as usize) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `g` [INFO] [stdout] --> src/print.rs:87:14 [INFO] [stdout] | [INFO] [stdout] 87 | for i in 0..n as usize { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 87 - for i in 0..n as usize { [INFO] [stdout] 87 + for in g.iter().take(n as usize) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (16/7) [INFO] [stdout] --> src/print.rs:98:1 [INFO] [stdout] | [INFO] [stdout] 98 | / pub fn prn3lb( [INFO] [stdout] 99 | | n: i32, [INFO] [stdout] 100 | | x: &[f64], [INFO] [stdout] 101 | | f: f64, [INFO] [stdout] ... | [INFO] [stdout] 114 | | lnscht: f64, [INFO] [stdout] 115 | | ) -> i32 { [INFO] [stdout] | |________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/print.rs:116:29 [INFO] [stdout] | [INFO] [stdout] 116 | let is_error = *task >= ERROR as i32 && *task <= ERROR_END as i32; [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `ERROR` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/print.rs:116:54 [INFO] [stdout] | [INFO] [stdout] 116 | let is_error = *task >= ERROR as i32 && *task <= ERROR_END as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `ERROR_END` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `x` [INFO] [stdout] --> src/print.rs:133:18 [INFO] [stdout] | [INFO] [stdout] 133 | for i in 0..n as usize { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 133 - for i in 0..n as usize { [INFO] [stdout] 133 + for in x.iter().take(n as usize) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i32` is unnecessary [INFO] [stdout] --> src/print.rs:186:5 [INFO] [stdout] | [INFO] [stdout] 186 | 0 as i32 [INFO] [stdout] | ^^^^^^^^ help: try: `0_i32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/print.rs:190:1 [INFO] [stdout] | [INFO] [stdout] 190 | / pub fn errclb( [INFO] [stdout] 191 | | n: i32, [INFO] [stdout] 192 | | m: i32, [INFO] [stdout] 193 | | factr: f64, [INFO] [stdout] ... | [INFO] [stdout] 199 | | k: &mut i32, [INFO] [stdout] 200 | | ) -> i32 { [INFO] [stdout] | |________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/print.rs:202:17 [INFO] [stdout] | [INFO] [stdout] 202 | *task = ERROR_N0 as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `ERROR_N0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/print.rs:205:17 [INFO] [stdout] | [INFO] [stdout] 205 | *task = ERROR_M0 as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `ERROR_M0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/print.rs:208:17 [INFO] [stdout] | [INFO] [stdout] 208 | *task = ERROR_FACTR as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `ERROR_FACTR` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/print.rs:213:21 [INFO] [stdout] | [INFO] [stdout] 213 | *task = ERROR_NBD as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `ERROR_NBD` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/print.rs:217:9 [INFO] [stdout] | [INFO] [stdout] 217 | / if nbd[i] == 2 { [INFO] [stdout] 218 | | if l[i] > u[i] { [INFO] [stdout] 219 | | *task = ERROR_FEAS as i32; [INFO] [stdout] 220 | | *info = -7; [INFO] [stdout] ... | [INFO] [stdout] 223 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 217 ~ if nbd[i] == 2 [INFO] [stdout] 218 ~ && l[i] > u[i] { [INFO] [stdout] 219 | *task = ERROR_FEAS as i32; [INFO] [stdout] 220 | *info = -7; [INFO] [stdout] 221 | *k = (i + 1) as i32; // Convert back to 1-based indexing for error reporting [INFO] [stdout] 222 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/print.rs:219:25 [INFO] [stdout] | [INFO] [stdout] 219 | *task = ERROR_FEAS as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `ERROR_FEAS` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> src/algorithm.rs:41:30 [INFO] [stdout] | [INFO] [stdout] 41 | pub const DBL_EPSILON: f64 = 2.2204460492503131e-16f64; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] = note: `#[warn(clippy::excessive_precision)]` on by default [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 41 - pub const DBL_EPSILON: f64 = 2.2204460492503131e-16f64; [INFO] [stdout] 41 + pub const DBL_EPSILON: f64 = 2.220_446_049_250_313e-16_f64; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (17/7) [INFO] [stdout] --> src/algorithm.rs:53:1 [INFO] [stdout] | [INFO] [stdout] 53 | / pub fn setulb( [INFO] [stdout] 54 | | n: usize, [INFO] [stdout] 55 | | m: usize, [INFO] [stdout] 56 | | x: &mut [f64], [INFO] [stdout] ... | [INFO] [stdout] 70 | | dsave: &mut [f64], [INFO] [stdout] 71 | | ) -> i32 { [INFO] [stdout] | |________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (31/7) [INFO] [stdout] --> src/algorithm.rs:173:1 [INFO] [stdout] | [INFO] [stdout] 173 | / pub fn mainlb( [INFO] [stdout] 174 | | n: usize, [INFO] [stdout] 175 | | m: usize, [INFO] [stdout] 176 | | x: &mut [f64], [INFO] [stdout] ... | [INFO] [stdout] 204 | | dsave: &mut [f64], [INFO] [stdout] 205 | | ) -> i32 { [INFO] [stdout] | |________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/algorithm.rs:671:32 [INFO] [stdout] | [INFO] [stdout] 671 | ... if cnstnd == false && col > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `!cnstnd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/algorithm.rs:769:36 [INFO] [stdout] | [INFO] [stdout] 769 | ... if wrk == true { [INFO] [stdout] | ^^^^^^^^^^^ help: try: `wrk` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/algorithm.rs:778:41 [INFO] [stdout] | [INFO] [stdout] 778 | ... iupdat as usize, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `iupdat` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/algorithm.rs:974:5 [INFO] [stdout] | [INFO] [stdout] 974 | / match current_block { [INFO] [stdout] 975 | | Block::Init => { [INFO] [stdout] 976 | | *task = FG_START; [INFO] [stdout] ... | [INFO] [stdout] 980 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 974 ~ if let Block::Init = current_block { [INFO] [stdout] 975 + *task = FG_START; [INFO] [stdout] 976 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/subalgorithms.rs:12:1 [INFO] [stdout] | [INFO] [stdout] 12 | / pub fn active( [INFO] [stdout] 13 | | n: usize, [INFO] [stdout] 14 | | l: &[f64], [INFO] [stdout] 15 | | u: &[f64], [INFO] [stdout] ... | [INFO] [stdout] 21 | | boxed: &mut bool, [INFO] [stdout] 22 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like you're manually copying between slices [INFO] [stdout] --> src/subalgorithms.rs:107:5 [INFO] [stdout] | [INFO] [stdout] 107 | / for i in 0..col { [INFO] [stdout] 108 | | p_col_plus[i] = p[col + i]; [INFO] [stdout] 109 | | } [INFO] [stdout] | |_____^ help: try replacing the loop by: `p_col_plus[..col].copy_from_slice(&p[col..(col + col)]);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like you're manually copying between slices [INFO] [stdout] --> src/subalgorithms.rs:124:13 [INFO] [stdout] | [INFO] [stdout] 124 | / for i in 0..col { [INFO] [stdout] 125 | | p[col + i] = p_col_plus[i]; [INFO] [stdout] 126 | | } [INFO] [stdout] | |_____________^ help: try replacing the loop by: `p[col..(col + col)].copy_from_slice(&p_col_plus[..col]);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like you're manually copying between slices [INFO] [stdout] --> src/subalgorithms.rs:138:5 [INFO] [stdout] | [INFO] [stdout] 138 | / for i in 0..col { [INFO] [stdout] 139 | | p_col_plus[i] = p[col + i]; [INFO] [stdout] 140 | | } [INFO] [stdout] | |_____^ help: try replacing the loop by: `p_col_plus[..col].copy_from_slice(&p[col..(col + col)]);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like you're manually copying between slices [INFO] [stdout] --> src/subalgorithms.rs:151:13 [INFO] [stdout] | [INFO] [stdout] 151 | / for i in 0..col { [INFO] [stdout] 152 | | p[col + i] = p_col_plus[i]; [INFO] [stdout] 153 | | } [INFO] [stdout] | |_____________^ help: try replacing the loop by: `p[col..(col + col)].copy_from_slice(&p_col_plus[..col]);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (16/7) [INFO] [stdout] --> src/subalgorithms.rs:187:1 [INFO] [stdout] | [INFO] [stdout] 187 | / fn initialize_cauchy( [INFO] [stdout] 188 | | n: usize, [INFO] [stdout] 189 | | x: &[f64], [INFO] [stdout] 190 | | l: &[f64], [INFO] [stdout] ... | [INFO] [stdout] 203 | | p: &mut [f64] [INFO] [stdout] 204 | | ) -> (bool, usize, usize, usize, f64, f64) { [INFO] [stdout] | |__________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `p` [INFO] [stdout] --> src/subalgorithms.rs:217:14 [INFO] [stdout] | [INFO] [stdout] 217 | for i in 0..col2 { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 217 - for i in 0..col2 { [INFO] [stdout] 217 + for in p.iter_mut().take(col2) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the use of negated comparison operators on partially ordered types produces code that is hard to read and refactor, please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable [INFO] [stdout] --> src/subalgorithms.rs:339:20 [INFO] [stdout] | [INFO] [stdout] 339 | if !(ddum < t[idx(j)]) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stdout] = note: `#[warn(clippy::neg_cmp_op_on_partial_ord)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the use of negated comparison operators on partially ordered types produces code that is hard to read and refactor, please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable [INFO] [stdout] --> src/subalgorithms.rs:380:16 [INFO] [stdout] | [INFO] [stdout] 380 | if !(t[idx(j)] < ddum) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (26/7) [INFO] [stdout] --> src/subalgorithms.rs:435:1 [INFO] [stdout] | [INFO] [stdout] 435 | / pub fn cauchy( [INFO] [stdout] 436 | | n: usize, [INFO] [stdout] 437 | | x: &[f64], [INFO] [stdout] 438 | | l: &[f64], [INFO] [stdout] ... | [INFO] [stdout] 461 | | epsmch: f64 [INFO] [stdout] 462 | | ) -> Result<(), i32> { [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is only used to index `c` [INFO] [stdout] --> src/subalgorithms.rs:493:14 [INFO] [stdout] | [INFO] [stdout] 493 | for j in 0..col2 { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 493 - for j in 0..col2 { [INFO] [stdout] 493 + for in c.iter_mut().take(col2) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/subalgorithms.rs:658:24 [INFO] [stdout] | [INFO] [stdout] 658 | if let Err(_) = result { [INFO] [stdout] | -------^^^^^^--------- help: try: `if result.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (17/7) [INFO] [stdout] --> src/subalgorithms.rs:731:1 [INFO] [stdout] | [INFO] [stdout] 731 | / pub fn cmprlb( [INFO] [stdout] 732 | | n: usize, [INFO] [stdout] 733 | | m: usize, [INFO] [stdout] 734 | | x: &[f64], [INFO] [stdout] ... | [INFO] [stdout] 748 | | cnstnd: bool, [INFO] [stdout] 749 | | ) -> Result<(), i32> { [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like you're manually copying between slices [INFO] [stdout] --> src/subalgorithms.rs:782:5 [INFO] [stdout] | [INFO] [stdout] 782 | / for i in 0..2*col { [INFO] [stdout] 783 | | wa[i] = p[i]; [INFO] [stdout] 784 | | } [INFO] [stdout] | |_____^ help: try replacing the loop by: `wa[..(2 * col)].copy_from_slice(&p[..(2 * col)]);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (17/7) [INFO] [stdout] --> src/subalgorithms.rs:829:1 [INFO] [stdout] | [INFO] [stdout] 829 | / pub fn formk( [INFO] [stdout] 830 | | n: usize, [INFO] [stdout] 831 | | nsub: usize, [INFO] [stdout] 832 | | ind: &[i32], [INFO] [stdout] ... | [INFO] [stdout] 846 | | head: usize, [INFO] [stdout] 847 | | ) -> Result<(), i32> { [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:866:34 [INFO] [stdout] | [INFO] [stdout] 866 | let src_offset = ((jy + 1) + (jy + 1) * wn1_dim) as usize; // Equivalent to 1-based jy + 1 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((jy + 1) + (jy + 1) * wn1_dim)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:867:34 [INFO] [stdout] | [INFO] [stdout] 867 | let dst_offset = (jy + jy * wn1_dim) as usize; // Equivalent to 1-based jy [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(jy + jy * wn1_dim)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:868:33 [INFO] [stdout] | [INFO] [stdout] 868 | let slice_len = i__2 as usize; [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `i__2` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:874:34 [INFO] [stdout] | [INFO] [stdout] 874 | let src_offset = ((js + 1) + (js + 1) * wn1_dim) as usize; // Equivalent to 1-based js + 1 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((js + 1) + (js + 1) * wn1_dim)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:875:34 [INFO] [stdout] | [INFO] [stdout] 875 | let dst_offset = (js + js * wn1_dim) as usize; // Equivalent to 1-based js [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(js + js * wn1_dim)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:876:33 [INFO] [stdout] | [INFO] [stdout] 876 | let slice_len = i__2 as usize; [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `i__2` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:882:34 [INFO] [stdout] | [INFO] [stdout] 882 | let src_offset = (m + 1 + (jy + 1) * wn1_dim) as usize; // Equivalent to 1-based m + 2 + (jy + 1) * wn1_dim [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(m + 1 + (jy + 1) * wn1_dim)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:883:34 [INFO] [stdout] | [INFO] [stdout] 883 | let dst_offset = (m + jy * wn1_dim) as usize; // Equivalent to 1-based m + 1 + jy * wn1_dim [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(m + jy * wn1_dim)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:884:33 [INFO] [stdout] | [INFO] [stdout] 884 | let slice_len = i__2 as usize; [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `i__2` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `k` is only used to index `ind` [INFO] [stdout] --> src/subalgorithms.rs:913:22 [INFO] [stdout] | [INFO] [stdout] 913 | for k in pbegin..=pend { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 913 - for k in pbegin..=pend { [INFO] [stdout] 913 + for in ind.iter().take(pend + 1).skip(pbegin) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `k` is only used to index `ind` [INFO] [stdout] --> src/subalgorithms.rs:921:22 [INFO] [stdout] | [INFO] [stdout] 921 | for k in dbegin..=dend { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 921 - for k in dbegin..=dend { [INFO] [stdout] 921 + for in ind.iter().take(dend + 1).skip(dbegin) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `k` is only used to index `ind` [INFO] [stdout] --> src/subalgorithms.rs:953:22 [INFO] [stdout] | [INFO] [stdout] 953 | for k in pbegin..=pend { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 953 - for k in pbegin..=pend { [INFO] [stdout] 953 + for in ind.iter().take(pend + 1).skip(pbegin) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `k` is only used to index `indx2` [INFO] [stdout] --> src/subalgorithms.rs:985:22 [INFO] [stdout] | [INFO] [stdout] 985 | for k in 0..nenter { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 985 - for k in 0..nenter { [INFO] [stdout] 985 + for in indx2.iter().take(nenter) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `k` is only used to index `indx2` [INFO] [stdout] --> src/subalgorithms.rs:997:22 [INFO] [stdout] | [INFO] [stdout] 997 | for k in (ileave - 1)..n { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 997 - for k in (ileave - 1)..n { [INFO] [stdout] 997 + for in indx2.iter().take(n).skip((ileave - 1)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `k` is only used to index `indx2` [INFO] [stdout] --> src/subalgorithms.rs:1030:22 [INFO] [stdout] | [INFO] [stdout] 1030 | for k in 0..nenter { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 1030 - for k in 0..nenter { [INFO] [stdout] 1030 + for in indx2.iter().take(nenter) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `k` is only used to index `indx2` [INFO] [stdout] --> src/subalgorithms.rs:1039:22 [INFO] [stdout] | [INFO] [stdout] 1039 | for k in (ileave - 1)..n { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 1039 - for k in (ileave - 1)..n { [INFO] [stdout] 1039 + for in indx2.iter().take(n).skip((ileave - 1)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:1135:46 [INFO] [stdout] | [INFO] [stdout] 1135 | let mut d = ddot(col as i32, &wn[(is * wn_dim) as usize..], 1, &wn[js * wn_dim..], 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `(is * wn_dim)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:1176:22 [INFO] [stdout] | [INFO] [stdout] 1176 | let k1 = (i.min(j) - 1) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(i.min(j) - 1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (11/7) [INFO] [stdout] --> src/subalgorithms.rs:1191:1 [INFO] [stdout] | [INFO] [stdout] 1191 | / pub fn freev( [INFO] [stdout] 1192 | | n: usize, [INFO] [stdout] 1193 | | nfree: &mut usize, [INFO] [stdout] 1194 | | index: &mut [i32], [INFO] [stdout] ... | [INFO] [stdout] 1202 | | iter: i32, [INFO] [stdout] 1203 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (17/7) [INFO] [stdout] --> src/subalgorithms.rs:1270:1 [INFO] [stdout] | [INFO] [stdout] 1270 | / pub fn matupd( [INFO] [stdout] 1271 | | n: usize, [INFO] [stdout] 1272 | | m: usize, [INFO] [stdout] 1273 | | ws: &mut [f64], [INFO] [stdout] ... | [INFO] [stdout] 1287 | | dtd: f64, [INFO] [stdout] 1288 | | ) -> i32 { [INFO] [stdout] | |________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:1310:47 [INFO] [stdout] | [INFO] [stdout] 1310 | ws[(i + itail_zero * n) as usize] = d[i as usize]; [INFO] [stdout] | ^^^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:1310:12 [INFO] [stdout] | [INFO] [stdout] 1310 | ws[(i + itail_zero * n) as usize] = d[i as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((i + itail_zero * n))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:1315:47 [INFO] [stdout] | [INFO] [stdout] 1315 | wy[(i + itail_zero * n) as usize] = r[i as usize]; [INFO] [stdout] | ^^^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:1315:12 [INFO] [stdout] | [INFO] [stdout] 1315 | wy[(i + itail_zero * n) as usize] = r[i as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((i + itail_zero * n))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:1324:21 [INFO] [stdout] | [INFO] [stdout] 1324 | for j in 1..(*col as usize) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `*col` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:1327:63 [INFO] [stdout] | [INFO] [stdout] 1327 | ss[k + (j-1) * (m as usize)] = ss[(k+1) + j * (m as usize)]; [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `m` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:1327:32 [INFO] [stdout] | [INFO] [stdout] 1327 | ss[k + (j-1) * (m as usize)] = ss[(k+1) + j * (m as usize)]; [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `m` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:1331:25 [INFO] [stdout] | [INFO] [stdout] 1331 | for k in j..(*col as usize) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `*col` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:1332:61 [INFO] [stdout] | [INFO] [stdout] 1332 | sy[k-1 + (j-1) * (m as usize)] = sy[k + j * (m as usize)]; [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `m` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:1332:34 [INFO] [stdout] | [INFO] [stdout] 1332 | sy[k-1 + (j-1) * (m as usize)] = sy[k + j * (m as usize)]; [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `m` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:1338:22 [INFO] [stdout] | [INFO] [stdout] 1338 | let mut pointr = *head as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `*head` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:1339:17 [INFO] [stdout] | [INFO] [stdout] 1339 | for j in 1..(*col as usize) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `*col` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:1343:83 [INFO] [stdout] | [INFO] [stdout] 1343 | sy[(*col as usize - 1) + j_idx * (m as usize)] = ddot(n as i32, d, 1, &wy[((pointr-1) * (wy_dim1 as usize)) as usize..], 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((pointr-1) * (wy_dim1 as usize))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:1343:97 [INFO] [stdout] | [INFO] [stdout] 1343 | sy[(*col as usize - 1) + j_idx * (m as usize)] = ddot(n as i32, d, 1, &wy[((pointr-1) * (wy_dim1 as usize)) as usize..], 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `wy_dim1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:1343:13 [INFO] [stdout] | [INFO] [stdout] 1343 | sy[(*col as usize - 1) + j_idx * (m as usize)] = ddot(n as i32, d, 1, &wy[((pointr-1) * (wy_dim1 as usize)) as usize..], 1); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `*col` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:1343:42 [INFO] [stdout] | [INFO] [stdout] 1343 | sy[(*col as usize - 1) + j_idx * (m as usize)] = ddot(n as i32, d, 1, &wy[((pointr-1) * (wy_dim1 as usize)) as usize..], 1); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `m` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:1344:77 [INFO] [stdout] | [INFO] [stdout] 1344 | ss[j_idx + (*col as usize - 1) * (m as usize)] = ddot(n as i32, &ws[((pointr-1) * (wy_dim1 as usize)) as usize..], 1, d, 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((pointr-1) * (wy_dim1 as usize))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:1344:91 [INFO] [stdout] | [INFO] [stdout] 1344 | ss[j_idx + (*col as usize - 1) * (m as usize)] = ddot(n as i32, &ws[((pointr-1) * (wy_dim1 as usize)) as usize..], 1, d, 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `wy_dim1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:1344:21 [INFO] [stdout] | [INFO] [stdout] 1344 | ss[j_idx + (*col as usize - 1) * (m as usize)] = ddot(n as i32, &ws[((pointr-1) * (wy_dim1 as usize)) as usize..], 1, d, 1); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `*col` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:1344:42 [INFO] [stdout] | [INFO] [stdout] 1344 | ss[j_idx + (*col as usize - 1) * (m as usize)] = ddot(n as i32, &ws[((pointr-1) * (wy_dim1 as usize)) as usize..], 1, d, 1); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `m` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:1347:27 [INFO] [stdout] | [INFO] [stdout] 1347 | pointr = pointr % (m as usize) + 1; [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `m` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:1352:12 [INFO] [stdout] | [INFO] [stdout] 1352 | ss[(col_zero + col_zero * ss_dim1) as usize] = dtd; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((col_zero + col_zero * ss_dim1))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:1354:12 [INFO] [stdout] | [INFO] [stdout] 1354 | ss[(col_zero + col_zero * ss_dim1) as usize] = stp * stp * dtd; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((col_zero + col_zero * ss_dim1))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:1358:8 [INFO] [stdout] | [INFO] [stdout] 1358 | sy[(col_zero + col_zero * sy_dim1) as usize] = dr; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((col_zero + col_zero * sy_dim1))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (12/7) [INFO] [stdout] --> src/subalgorithms.rs:1393:1 [INFO] [stdout] | [INFO] [stdout] 1393 | / pub fn compute_newton_direction( [INFO] [stdout] 1394 | | nsub: usize, [INFO] [stdout] 1395 | | ind: &[i32], [INFO] [stdout] 1396 | | d: &mut [f64], [INFO] [stdout] ... | [INFO] [stdout] 1405 | | n: usize, [INFO] [stdout] 1406 | | ) -> Result<(), i32> { [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `wv` [INFO] [stdout] --> src/subalgorithms.rs:1445:14 [INFO] [stdout] | [INFO] [stdout] 1445 | for i in 0..col { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 1445 - for i in 0..col { [INFO] [stdout] 1445 + for in wv.iter_mut().take(col) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `d` [INFO] [stdout] --> src/subalgorithms.rs:1476:14 [INFO] [stdout] | [INFO] [stdout] 1476 | for i in 0..nsub { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 1476 - for i in 0..nsub { [INFO] [stdout] 1476 + for in d.iter_mut().take(nsub) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/subalgorithms.rs:1484:1 [INFO] [stdout] | [INFO] [stdout] 1484 | / fn project_onto_feasible_region( [INFO] [stdout] 1485 | | nsub: usize, [INFO] [stdout] 1486 | | ind: &[i32], [INFO] [stdout] 1487 | | d: &[f64], [INFO] [stdout] ... | [INFO] [stdout] 1493 | | n: usize, [INFO] [stdout] 1494 | | ) -> bool { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (11/7) [INFO] [stdout] --> src/subalgorithms.rs:1537:1 [INFO] [stdout] | [INFO] [stdout] 1537 | / fn backtrack_if_needed( [INFO] [stdout] 1538 | | nsub: usize, [INFO] [stdout] 1539 | | ind: &[i32], [INFO] [stdout] 1540 | | d: &mut [f64], [INFO] [stdout] ... | [INFO] [stdout] 1548 | | n: usize, [INFO] [stdout] 1549 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (19/7) [INFO] [stdout] --> src/subalgorithms.rs:1613:1 [INFO] [stdout] | [INFO] [stdout] 1613 | / pub fn subsm( [INFO] [stdout] 1614 | | n: usize, [INFO] [stdout] 1615 | | m: usize, [INFO] [stdout] 1616 | | nsub: usize, [INFO] [stdout] ... | [INFO] [stdout] 1632 | | wn: &[f64], [INFO] [stdout] 1633 | | ) -> i32 { [INFO] [stdout] | |________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/subalgorithms.rs:1693:5 [INFO] [stdout] | [INFO] [stdout] 1693 | return iword; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1693 - return iword; [INFO] [stdout] 1693 + iword [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/timer.rs:8:13 [INFO] [stdout] | [INFO] [stdout] 7 | let seconds = duration.as_secs_f64(); [INFO] [stdout] | ------------------------------------- unnecessary `let` binding [INFO] [stdout] 8 | seconds [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 7 ~ [INFO] [stdout] 8 ~ duration.as_secs_f64() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `vector` [INFO] [stdout] --> src/debug.rs:19:14 [INFO] [stdout] | [INFO] [stdout] 19 | for i in 0..len { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 19 - for i in 0..len { [INFO] [stdout] 19 + for in vector.iter().take(len) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `vector` [INFO] [stdout] --> src/debug.rs:29:14 [INFO] [stdout] | [INFO] [stdout] 29 | for i in 0..len { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 29 - for i in 0..len { [INFO] [stdout] 29 + for in vector.iter().take(len) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Checking env_filter v0.1.3 [INFO] [stderr] Checking env_logger v0.11.8 [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> examples/driver1.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | use env_logger; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::timer::timer` [INFO] [stdout] --> src/lbfgsb.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use super::timer::timer; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> examples/driver2.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | use env_logger; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> examples/driver2.rs:4:1 [INFO] [stdout] | [INFO] [stdout] 4 | use log; [INFO] [stdout] | ^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lbfgsb.rs:103:13 [INFO] [stdout] | [INFO] [stdout] 103 | n: n, [INFO] [stdout] | ^^^^ help: replace it with: `n` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lbfgsb.rs:108:13 [INFO] [stdout] | [INFO] [stdout] 108 | f: f, [INFO] [stdout] | ^^^^ help: replace it with: `f` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lbfgsb.rs:109:13 [INFO] [stdout] | [INFO] [stdout] 109 | g: g, [INFO] [stdout] | ^^^^ help: replace it with: `g` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lbfgsb.rs:117:13 [INFO] [stdout] | [INFO] [stdout] 117 | params: params [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `params` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> examples/driver3.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | use env_logger; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> examples/driver3.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | use log; [INFO] [stdout] | ^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> examples/driver2.rs:96:49 [INFO] [stdout] | [INFO] [stdout] 96 | 1.0867246621088944, 1.1809704912345709, 1.3946913011665660, 1.9451638255508485, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] = note: `#[warn(clippy::excessive_precision)]` on by default [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 96 - 1.0867246621088944, 1.1809704912345709, 1.3946913011665660, 1.9451638255508485, [INFO] [stdout] 96 + 1.0867246621088944, 1.1809704912345709, 1.394_691_301_166_566, 1.9451638255508485, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> examples/driver3.rs:91:88 [INFO] [stdout] | [INFO] [stdout] 91 | let ref_final_x = vec![1.0000000000000000, 0.9999999999999298, 1.0000000000000000, 1.0000000000001319, 1.0000000000001259, 1.000... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] = note: `#[warn(clippy::excessive_precision)]` on by default [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 91 - let ref_final_x = vec![1.0000000000000000, 0.9999999999999298, 1.0000000000000000, 1.0000000000001319, 1.0000000000001259, 1.0000000000004210, 1.0000000000002660, 1.0000000000007556, 1.0000000000006632, 1.0000000000007858, 1.0027613236431623, 1.0055302721945152, 1.0110911282976183, 1.0223052697237622, 1.0451080645051254, 1.0922508664949420, 1.1930119553596639, 1.4232775256318961, 2.0257189149696382, 4.1035371224629555]; [INFO] [stdout] 91 + let ref_final_x = vec![1.0000000000000000, 0.9999999999999298, 1.0000000000000000, 1.000_000_000_000_132, 1.0000000000001259, 1.0000000000004210, 1.0000000000002660, 1.0000000000007556, 1.0000000000006632, 1.0000000000007858, 1.0027613236431623, 1.0055302721945152, 1.0110911282976183, 1.0223052697237622, 1.0451080645051254, 1.0922508664949420, 1.1930119553596639, 1.4232775256318961, 2.0257189149696382, 4.1035371224629555]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> examples/driver3.rs:91:108 [INFO] [stdout] | [INFO] [stdout] 91 | let ref_final_x = vec![1.0000000000000000, 0.9999999999999298, 1.0000000000000000, 1.0000000000001319, 1.0000000000001259, 1.000... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 91 - let ref_final_x = vec![1.0000000000000000, 0.9999999999999298, 1.0000000000000000, 1.0000000000001319, 1.0000000000001259, 1.0000000000004210, 1.0000000000002660, 1.0000000000007556, 1.0000000000006632, 1.0000000000007858, 1.0027613236431623, 1.0055302721945152, 1.0110911282976183, 1.0223052697237622, 1.0451080645051254, 1.0922508664949420, 1.1930119553596639, 1.4232775256318961, 2.0257189149696382, 4.1035371224629555]; [INFO] [stdout] 91 + let ref_final_x = vec![1.0000000000000000, 0.9999999999999298, 1.0000000000000000, 1.0000000000001319, 1.000_000_000_000_126, 1.0000000000004210, 1.0000000000002660, 1.0000000000007556, 1.0000000000006632, 1.0000000000007858, 1.0027613236431623, 1.0055302721945152, 1.0110911282976183, 1.0223052697237622, 1.0451080645051254, 1.0922508664949420, 1.1930119553596639, 1.4232775256318961, 2.0257189149696382, 4.1035371224629555]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> examples/driver3.rs:91:128 [INFO] [stdout] | [INFO] [stdout] 91 | ...0000000000000, 1.0000000000001319, 1.0000000000001259, 1.0000000000004210, 1.0000000000002660, 1.0000000000007556, 1.000000000000... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 91 - let ref_final_x = vec![1.0000000000000000, 0.9999999999999298, 1.0000000000000000, 1.0000000000001319, 1.0000000000001259, 1.0000000000004210, 1.0000000000002660, 1.0000000000007556, 1.0000000000006632, 1.0000000000007858, 1.0027613236431623, 1.0055302721945152, 1.0110911282976183, 1.0223052697237622, 1.0451080645051254, 1.0922508664949420, 1.1930119553596639, 1.4232775256318961, 2.0257189149696382, 4.1035371224629555]; [INFO] [stdout] 91 + let ref_final_x = vec![1.0000000000000000, 0.9999999999999298, 1.0000000000000000, 1.0000000000001319, 1.0000000000001259, 1.000_000_000_000_421, 1.0000000000002660, 1.0000000000007556, 1.0000000000006632, 1.0000000000007858, 1.0027613236431623, 1.0055302721945152, 1.0110911282976183, 1.0223052697237622, 1.0451080645051254, 1.0922508664949420, 1.1930119553596639, 1.4232775256318961, 2.0257189149696382, 4.1035371224629555]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> examples/driver3.rs:91:148 [INFO] [stdout] | [INFO] [stdout] 91 | ...0000000001319, 1.0000000000001259, 1.0000000000004210, 1.0000000000002660, 1.0000000000007556, 1.0000000000006632, 1.000000000000... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 91 - let ref_final_x = vec![1.0000000000000000, 0.9999999999999298, 1.0000000000000000, 1.0000000000001319, 1.0000000000001259, 1.0000000000004210, 1.0000000000002660, 1.0000000000007556, 1.0000000000006632, 1.0000000000007858, 1.0027613236431623, 1.0055302721945152, 1.0110911282976183, 1.0223052697237622, 1.0451080645051254, 1.0922508664949420, 1.1930119553596639, 1.4232775256318961, 2.0257189149696382, 4.1035371224629555]; [INFO] [stdout] 91 + let ref_final_x = vec![1.0000000000000000, 0.9999999999999298, 1.0000000000000000, 1.0000000000001319, 1.0000000000001259, 1.0000000000004210, 1.000_000_000_000_266, 1.0000000000007556, 1.0000000000006632, 1.0000000000007858, 1.0027613236431623, 1.0055302721945152, 1.0110911282976183, 1.0223052697237622, 1.0451080645051254, 1.0922508664949420, 1.1930119553596639, 1.4232775256318961, 2.0257189149696382, 4.1035371224629555]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> examples/driver3.rs:91:328 [INFO] [stdout] | [INFO] [stdout] 91 | ...0911282976183, 1.0223052697237622, 1.0451080645051254, 1.0922508664949420, 1.1930119553596639, 1.4232775256318961, 2.025718914969... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 91 - let ref_final_x = vec![1.0000000000000000, 0.9999999999999298, 1.0000000000000000, 1.0000000000001319, 1.0000000000001259, 1.0000000000004210, 1.0000000000002660, 1.0000000000007556, 1.0000000000006632, 1.0000000000007858, 1.0027613236431623, 1.0055302721945152, 1.0110911282976183, 1.0223052697237622, 1.0451080645051254, 1.0922508664949420, 1.1930119553596639, 1.4232775256318961, 2.0257189149696382, 4.1035371224629555]; [INFO] [stdout] 91 + let ref_final_x = vec![1.0000000000000000, 0.9999999999999298, 1.0000000000000000, 1.0000000000001319, 1.0000000000001259, 1.0000000000004210, 1.0000000000002660, 1.0000000000007556, 1.0000000000006632, 1.0000000000007858, 1.0027613236431623, 1.0055302721945152, 1.0110911282976183, 1.0223052697237622, 1.0451080645051254, 1.092_250_866_494_942, 1.1930119553596639, 1.4232775256318961, 2.0257189149696382, 4.1035371224629555]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> examples/driver3.rs:91:388 [INFO] [stdout] | [INFO] [stdout] 91 | ...2508664949420, 1.1930119553596639, 1.4232775256318961, 2.0257189149696382, 4.1035371224629555]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 91 - let ref_final_x = vec![1.0000000000000000, 0.9999999999999298, 1.0000000000000000, 1.0000000000001319, 1.0000000000001259, 1.0000000000004210, 1.0000000000002660, 1.0000000000007556, 1.0000000000006632, 1.0000000000007858, 1.0027613236431623, 1.0055302721945152, 1.0110911282976183, 1.0223052697237622, 1.0451080645051254, 1.0922508664949420, 1.1930119553596639, 1.4232775256318961, 2.0257189149696382, 4.1035371224629555]; [INFO] [stdout] 91 + let ref_final_x = vec![1.0000000000000000, 0.9999999999999298, 1.0000000000000000, 1.0000000000001319, 1.0000000000001259, 1.0000000000004210, 1.0000000000002660, 1.0000000000007556, 1.0000000000006632, 1.0000000000007858, 1.0027613236431623, 1.0055302721945152, 1.0110911282976183, 1.0223052697237622, 1.0451080645051254, 1.0922508664949420, 1.1930119553596639, 1.4232775256318961, 2.025_718_914_969_638, 4.1035371224629555]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taking a mutable reference to a `const` item [INFO] [stdout] --> src/linesearch.rs:162:9 [INFO] [stdout] | [INFO] [stdout] 162 | &mut FTOL, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: each usage of a `const` item creates a new temporary [INFO] [stdout] = note: the mutable reference will refer to this temporary, not the original `const` item [INFO] [stdout] note: `const` item defined here [INFO] [stdout] --> src/linesearch.rs:28:1 [INFO] [stdout] | [INFO] [stdout] 28 | pub const FTOL: f64 = 0.001f64; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(const_item_mutation)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taking a mutable reference to a `const` item [INFO] [stdout] --> src/linesearch.rs:163:9 [INFO] [stdout] | [INFO] [stdout] 163 | &mut GTOL, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: each usage of a `const` item creates a new temporary [INFO] [stdout] = note: the mutable reference will refer to this temporary, not the original `const` item [INFO] [stdout] note: `const` item defined here [INFO] [stdout] --> src/linesearch.rs:29:1 [INFO] [stdout] | [INFO] [stdout] 29 | pub const GTOL: f64 = 0.9f64; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taking a mutable reference to a `const` item [INFO] [stdout] --> src/linesearch.rs:164:9 [INFO] [stdout] | [INFO] [stdout] 164 | &mut XTOL, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: each usage of a `const` item creates a new temporary [INFO] [stdout] = note: the mutable reference will refer to this temporary, not the original `const` item [INFO] [stdout] note: `const` item defined here [INFO] [stdout] --> src/linesearch.rs:30:1 [INFO] [stdout] | [INFO] [stdout] 30 | pub const XTOL: f64 = 0.1f64; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taking a mutable reference to a `const` item [INFO] [stdout] --> src/linesearch.rs:165:9 [INFO] [stdout] | [INFO] [stdout] 165 | &mut STEPMIN, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: each usage of a `const` item creates a new temporary [INFO] [stdout] = note: the mutable reference will refer to this temporary, not the original `const` item [INFO] [stdout] note: `const` item defined here [INFO] [stdout] --> src/linesearch.rs:31:1 [INFO] [stdout] | [INFO] [stdout] 31 | pub const STEPMIN: f64 = 0.0f64; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `d` [INFO] [stdout] --> src/subalgorithms.rs:1135:17 [INFO] [stdout] | [INFO] [stdout] 1135 | let mut d = ddot(col as i32, &wn[(is * wn_dim) as usize..], 1, &wn[js * wn_dim..], 1); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_d` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lbfgsb.rs:107:25 [INFO] [stdout] | [INFO] [stdout] 107 | nbd: vec![0;n as usize], [INFO] [stdout] | ^^^^^^^^^^ help: try: `n` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lbfgsb.rs:110:29 [INFO] [stdout] | [INFO] [stdout] 110 | wa: vec![0.0f64;(2*params.m*n+11*params.m*params.m+params.m*n+8*params.m) as usize], [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((2*params.m*n+11*params.m*params.m+params.m*n+8*params.m))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lbfgsb.rs:111:27 [INFO] [stdout] | [INFO] [stdout] 111 | iwa: vec![0;3*n as usize], [INFO] [stdout] | ^^^^^^^^^^ help: try: `n` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (30/7) [INFO] [stdout] --> src/linesearch.rs:62:1 [INFO] [stdout] | [INFO] [stdout] 62 | / pub fn lnsrlb( [INFO] [stdout] 63 | | n: i32, [INFO] [stdout] 64 | | l: &[f64], [INFO] [stdout] 65 | | u: &[f64], [INFO] [stdout] ... | [INFO] [stdout] 92 | | dsave: &mut [f64], // Slice for dsave array [INFO] [stdout] 93 | | ) -> i32 { [INFO] [stdout] | |________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/linesearch.rs:95:17 [INFO] [stdout] | [INFO] [stdout] 95 | if *task != FG_LN as i32 { [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `FG_LN` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/linesearch.rs:101:12 [INFO] [stdout] | [INFO] [stdout] 101 | if cnstnd == true { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `cnstnd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/linesearch.rs:128:26 [INFO] [stdout] | [INFO] [stdout] 128 | if *iter == 0 && boxed == false { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `!boxed` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/linesearch.rs:142:18 [INFO] [stdout] | [INFO] [stdout] 142 | *csave = START as i32; [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `START` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i32` is unnecessary [INFO] [stdout] --> src/linesearch.rs:152:21 [INFO] [stdout] | [INFO] [stdout] 152 | *info = -(4) as i32; [INFO] [stdout] | ^^^^^^^^^^^ help: try: `-4_i32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/linesearch.rs:175:32 [INFO] [stdout] | [INFO] [stdout] 175 | let is_warning = *csave >= WARNING as i32 && *csave <= WARNING_END as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `WARNING` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/linesearch.rs:175:60 [INFO] [stdout] | [INFO] [stdout] 175 | let is_warning = *csave >= WARNING as i32 && *csave <= WARNING_END as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `WARNING_END` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/linesearch.rs:176:36 [INFO] [stdout] | [INFO] [stdout] 176 | let is_convergence = *csave >= CONVERGENCE as i32 && *csave <= CONVERGENCE_END as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `CONVERGENCE` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/linesearch.rs:176:68 [INFO] [stdout] | [INFO] [stdout] 176 | let is_convergence = *csave >= CONVERGENCE as i32 && *csave <= CONVERGENCE_END as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `CONVERGENCE_END` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/linesearch.rs:179:17 [INFO] [stdout] | [INFO] [stdout] 179 | *task = FG_LNSRCH as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `FG_LNSRCH` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like you're manually copying between slices [INFO] [stdout] --> src/linesearch.rs:186:13 [INFO] [stdout] | [INFO] [stdout] 186 | / for i in 0..n as usize { [INFO] [stdout] 187 | | x[i] = z[i]; [INFO] [stdout] 188 | | } [INFO] [stdout] | |_____________^ help: try replacing the loop by: `x[..(n as usize)].copy_from_slice(&z[..(n as usize)]);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stdout] = note: `#[warn(clippy::manual_memcpy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/linesearch.rs:196:17 [INFO] [stdout] | [INFO] [stdout] 196 | *task = NEW_X as i32; [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `NEW_X` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/linesearch.rs:348:12 [INFO] [stdout] | [INFO] [stdout] 348 | if !(*task >= WARNING as i32 && *task <= WARNING_END as i32) [INFO] [stdout] | ____________^ [INFO] [stdout] 349 | | && !(*task >= CONVERGENCE as i32 && *task <= CONVERGENCE_END as i32) { [INFO] [stdout] | |________________________________________________________________________________^ help: try: `!(*task >= WARNING as i32 && *task <= WARNING_END as i32 || *task >= CONVERGENCE as i32 && *task <= CONVERGENCE_END as i32)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/linesearch.rs:406:16 [INFO] [stdout] | [INFO] [stdout] 406 | if brackt == true && (*stp <= stmin || *stp >= stmax) [INFO] [stdout] | ________________^ [INFO] [stdout] 407 | | || (brackt == true && (stmax - stmin <= *xtol * stmax)) { [INFO] [stdout] | |_______________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 406 - if brackt == true && (*stp <= stmin || *stp >= stmax) [INFO] [stdout] 407 - || (brackt == true && (stmax - stmin <= *xtol * stmax)) { [INFO] [stdout] 406 + if !(brackt != true || *stp > stmin && *stp < stmax && stmax - stmin > *xtol * stmax) { [INFO] [stdout] | [INFO] [stdout] 406 - if brackt == true && (*stp <= stmin || *stp >= stmax) [INFO] [stdout] 407 - || (brackt == true && (stmax - stmin <= *xtol * stmax)) { [INFO] [stdout] 406 + if ((stmax - stmin <= *xtol * stmax) || *stp >= stmax || *stp <= stmin) && brackt == true { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (11/7) [INFO] [stdout] --> src/linesearch.rs:219:1 [INFO] [stdout] | [INFO] [stdout] 219 | / fn dcsrch( [INFO] [stdout] 220 | | f: &mut f64, [INFO] [stdout] 221 | | g: &mut f64, [INFO] [stdout] 222 | | stp: &mut f64, [INFO] [stdout] ... | [INFO] [stdout] 230 | | dsave: &mut [f64], // Slice for dsave array (needs 13 elements) [INFO] [stdout] 231 | | ) -> i32 { [INFO] [stdout] | |________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/linesearch.rs:255:17 [INFO] [stdout] | [INFO] [stdout] 255 | if *task == START as i32 { [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `START` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/linesearch.rs:258:21 [INFO] [stdout] | [INFO] [stdout] 258 | *task = ERROR_SMALLSTP as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `ERROR_SMALLSTP` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/linesearch.rs:261:21 [INFO] [stdout] | [INFO] [stdout] 261 | *task = ERROR_LARGESTP as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `ERROR_LARGESTP` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/linesearch.rs:264:21 [INFO] [stdout] | [INFO] [stdout] 264 | *task = ERROR_INITIAL as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `ERROR_INITIAL` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/linesearch.rs:267:21 [INFO] [stdout] | [INFO] [stdout] 267 | *task = ERROR_FTOL as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `ERROR_FTOL` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/linesearch.rs:270:21 [INFO] [stdout] | [INFO] [stdout] 270 | *task = ERROR_GTOL as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `ERROR_GTOL` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/linesearch.rs:273:21 [INFO] [stdout] | [INFO] [stdout] 273 | *task = ERROR_XTOL as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `ERROR_XTOL` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/linesearch.rs:276:21 [INFO] [stdout] | [INFO] [stdout] 276 | *task = ERROR_STP0 as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `ERROR_STP0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/linesearch.rs:279:21 [INFO] [stdout] | [INFO] [stdout] 279 | *task = ERROR_STP1 as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `ERROR_STP1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/linesearch.rs:282:22 [INFO] [stdout] | [INFO] [stdout] 282 | if (*task >= ERROR as i32) && (*task <= ERROR_END as i32) { [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `ERROR` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/linesearch.rs:282:49 [INFO] [stdout] | [INFO] [stdout] 282 | if (*task >= ERROR as i32) && (*task <= ERROR_END as i32) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `ERROR_END` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/linesearch.rs:305:17 [INFO] [stdout] | [INFO] [stdout] 305 | *task = FG as i32; [INFO] [stdout] | ^^^^^^^^^ help: try: `FG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/linesearch.rs:308:18 [INFO] [stdout] | [INFO] [stdout] 308 | brackt = if isave[21] == 1 { true } else { false }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `isave[21] == 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/linesearch.rs:331:12 [INFO] [stdout] | [INFO] [stdout] 331 | if brackt == true && (*stp <= stmin || *stp >= stmax) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `brackt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/linesearch.rs:332:21 [INFO] [stdout] | [INFO] [stdout] 332 | *task = WARNING_ROUND as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `WARNING_ROUND` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/linesearch.rs:334:12 [INFO] [stdout] | [INFO] [stdout] 334 | if brackt == true && stmax - stmin <= *xtol * stmax { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `brackt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/linesearch.rs:335:21 [INFO] [stdout] | [INFO] [stdout] 335 | *task = WARNING_XTOL as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `WARNING_XTOL` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/linesearch.rs:338:21 [INFO] [stdout] | [INFO] [stdout] 338 | *task = WARNING_STPMAX as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `WARNING_STPMAX` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/linesearch.rs:341:21 [INFO] [stdout] | [INFO] [stdout] 341 | *task = WARNING_STPMIN as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `WARNING_STPMIN` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/linesearch.rs:344:21 [INFO] [stdout] | [INFO] [stdout] 344 | *task = CONVERGENCE as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `CONVERGENCE` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/linesearch.rs:348:23 [INFO] [stdout] | [INFO] [stdout] 348 | if !(*task >= WARNING as i32 && *task <= WARNING_END as i32) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `WARNING` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/linesearch.rs:348:50 [INFO] [stdout] | [INFO] [stdout] 348 | if !(*task >= WARNING as i32 && *task <= WARNING_END as i32) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `WARNING_END` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/linesearch.rs:349:27 [INFO] [stdout] | [INFO] [stdout] 349 | && !(*task >= CONVERGENCE as i32 && *task <= CONVERGENCE_END as i32) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `CONVERGENCE` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/linesearch.rs:349:58 [INFO] [stdout] | [INFO] [stdout] 349 | && !(*task >= CONVERGENCE as i32 && *task <= CONVERGENCE_END as i32) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `CONVERGENCE_END` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/linesearch.rs:384:16 [INFO] [stdout] | [INFO] [stdout] 384 | if brackt == true { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `brackt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/linesearch.rs:393:16 [INFO] [stdout] | [INFO] [stdout] 393 | if brackt == true { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `brackt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/linesearch.rs:406:16 [INFO] [stdout] | [INFO] [stdout] 406 | if brackt == true && (*stp <= stmin || *stp >= stmax) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `brackt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/linesearch.rs:407:21 [INFO] [stdout] | [INFO] [stdout] 407 | || (brackt == true && (stmax - stmin <= *xtol * stmax)) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `brackt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/linesearch.rs:411:21 [INFO] [stdout] | [INFO] [stdout] 411 | *task = FG as i32; [INFO] [stdout] | ^^^^^^^^^ help: try: `FG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/linesearch.rs:416:20 [INFO] [stdout] | [INFO] [stdout] 416 | isave[21] = if brackt == true { 1 } else { 0 }; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `brackt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (12/7) [INFO] [stdout] --> src/linesearch.rs:447:1 [INFO] [stdout] | [INFO] [stdout] 447 | / fn dcstep( [INFO] [stdout] 448 | | stx: &mut f64, [INFO] [stdout] 449 | | fx: &mut f64, [INFO] [stdout] 450 | | dx: &mut f64, [INFO] [stdout] ... | [INFO] [stdout] 459 | | stpmax: &mut f64, [INFO] [stdout] 460 | | ) -> i32 { [INFO] [stdout] | |________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/linesearch.rs:518:12 [INFO] [stdout] | [INFO] [stdout] 518 | if *brackt == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `*brackt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/linesearch.rs:538:15 [INFO] [stdout] | [INFO] [stdout] 538 | } else if *brackt == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `*brackt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/miniblas.rs:198:17 [INFO] [stdout] | [INFO] [stdout] 198 | dx[i as usize] = da * dx[i as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dx[i as usize] *= da` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/miniblas.rs:207:13 [INFO] [stdout] | [INFO] [stdout] 207 | dx[i as usize] = da * dx[i as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dx[i as usize] *= da` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/miniblas.rs:208:13 [INFO] [stdout] | [INFO] [stdout] 208 | dx[(i + 1) as usize] = da * dx[(i + 1) as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dx[(i + 1) as usize] *= da` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/miniblas.rs:209:13 [INFO] [stdout] | [INFO] [stdout] 209 | dx[(i + 2) as usize] = da * dx[(i + 2) as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dx[(i + 2) as usize] *= da` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/miniblas.rs:210:13 [INFO] [stdout] | [INFO] [stdout] 210 | dx[(i + 3) as usize] = da * dx[(i + 3) as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dx[(i + 3) as usize] *= da` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/miniblas.rs:211:13 [INFO] [stdout] | [INFO] [stdout] 211 | dx[(i + 4) as usize] = da * dx[(i + 4) as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dx[(i + 4) as usize] *= da` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/miniblas.rs:217:13 [INFO] [stdout] | [INFO] [stdout] 217 | dx[ix as usize] = da * dx[ix as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dx[ix as usize] *= da` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i32` is unnecessary [INFO] [stdout] --> src/print.rs:6:24 [INFO] [stdout] | [INFO] [stdout] 6 | pub const ERROR: i32 = 200 as i32; [INFO] [stdout] | ^^^^^^^^^^ help: try: `200_i32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i32` is unnecessary [INFO] [stdout] --> src/print.rs:7:28 [INFO] [stdout] | [INFO] [stdout] 7 | pub const ERROR_END: i32 = 240 as i32; [INFO] [stdout] | ^^^^^^^^^^ help: try: `240_i32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i32` is unnecessary [INFO] [stdout] --> src/print.rs:8:27 [INFO] [stdout] | [INFO] [stdout] 8 | pub const ERROR_N0: i32 = 209 as i32; [INFO] [stdout] | ^^^^^^^^^^ help: try: `209_i32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i32` is unnecessary [INFO] [stdout] --> src/print.rs:9:27 [INFO] [stdout] | [INFO] [stdout] 9 | pub const ERROR_M0: i32 = 210 as i32; [INFO] [stdout] | ^^^^^^^^^^ help: try: `210_i32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i32` is unnecessary [INFO] [stdout] --> src/print.rs:10:30 [INFO] [stdout] | [INFO] [stdout] 10 | pub const ERROR_FACTR: i32 = 211 as i32; [INFO] [stdout] | ^^^^^^^^^^ help: try: `211_i32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i32` is unnecessary [INFO] [stdout] --> src/print.rs:11:28 [INFO] [stdout] | [INFO] [stdout] 11 | pub const ERROR_NBD: i32 = 212 as i32; [INFO] [stdout] | ^^^^^^^^^^ help: try: `212_i32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i32` is unnecessary [INFO] [stdout] --> src/print.rs:12:29 [INFO] [stdout] | [INFO] [stdout] 12 | pub const ERROR_FEAS: i32 = 213 as i32; [INFO] [stdout] | ^^^^^^^^^^ help: try: `213_i32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i32` is unnecessary [INFO] [stdout] --> src/print.rs:13:31 [INFO] [stdout] | [INFO] [stdout] 13 | pub const WORD_DEFAULT: i32 = 0 as i32; [INFO] [stdout] | ^^^^^^^^ help: try: `0_i32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i32` is unnecessary [INFO] [stdout] --> src/print.rs:14:27 [INFO] [stdout] | [INFO] [stdout] 14 | pub const WORD_CON: i32 = 1 as i32; [INFO] [stdout] | ^^^^^^^^ help: try: `1_i32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i32` is unnecessary [INFO] [stdout] --> src/print.rs:15:27 [INFO] [stdout] | [INFO] [stdout] 15 | pub const WORD_BND: i32 = 2 as i32; [INFO] [stdout] | ^^^^^^^^ help: try: `2_i32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i32` is unnecessary [INFO] [stdout] --> src/print.rs:16:27 [INFO] [stdout] | [INFO] [stdout] 16 | pub const WORD_TNT: i32 = 3 as i32; [INFO] [stdout] | ^^^^^^^^ help: try: `3_i32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `l` [INFO] [stdout] --> src/print.rs:34:14 [INFO] [stdout] | [INFO] [stdout] 34 | for i in 0..n as usize { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 34 - for i in 0..n as usize { [INFO] [stdout] 34 + for in l.iter().take(n as usize) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `x` [INFO] [stdout] --> src/print.rs:40:14 [INFO] [stdout] | [INFO] [stdout] 40 | for i in 0..n as usize { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 40 - for i in 0..n as usize { [INFO] [stdout] 40 + for in x.iter().take(n as usize) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `u` [INFO] [stdout] --> src/print.rs:46:14 [INFO] [stdout] | [INFO] [stdout] 46 | for i in 0..n as usize { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 46 - for i in 0..n as usize { [INFO] [stdout] 46 + for in u.iter().take(n as usize) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (10/7) [INFO] [stdout] --> src/print.rs:55:1 [INFO] [stdout] | [INFO] [stdout] 55 | / pub fn prn2lb( [INFO] [stdout] 56 | | n: i32, [INFO] [stdout] 57 | | x: &[f64], [INFO] [stdout] 58 | | f: f64, [INFO] [stdout] ... | [INFO] [stdout] 65 | | xstep: f64, [INFO] [stdout] 66 | | ) -> i32 { [INFO] [stdout] | |________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/print.rs:68:17 [INFO] [stdout] | [INFO] [stdout] 68 | *word = WORD_CON as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `WORD_CON` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/print.rs:70:17 [INFO] [stdout] | [INFO] [stdout] 70 | *word = WORD_BND as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `WORD_BND` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/print.rs:72:17 [INFO] [stdout] | [INFO] [stdout] 72 | *word = WORD_TNT as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `WORD_TNT` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/print.rs:74:17 [INFO] [stdout] | [INFO] [stdout] 74 | *word = WORD_DEFAULT as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `WORD_DEFAULT` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `x` [INFO] [stdout] --> src/print.rs:81:14 [INFO] [stdout] | [INFO] [stdout] 81 | for i in 0..n as usize { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 81 - for i in 0..n as usize { [INFO] [stdout] 81 + for in x.iter().take(n as usize) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `g` [INFO] [stdout] --> src/print.rs:87:14 [INFO] [stdout] | [INFO] [stdout] 87 | for i in 0..n as usize { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 87 - for i in 0..n as usize { [INFO] [stdout] 87 + for in g.iter().take(n as usize) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (16/7) [INFO] [stdout] --> src/print.rs:98:1 [INFO] [stdout] | [INFO] [stdout] 98 | / pub fn prn3lb( [INFO] [stdout] 99 | | n: i32, [INFO] [stdout] 100 | | x: &[f64], [INFO] [stdout] 101 | | f: f64, [INFO] [stdout] ... | [INFO] [stdout] 114 | | lnscht: f64, [INFO] [stdout] 115 | | ) -> i32 { [INFO] [stdout] | |________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/print.rs:116:29 [INFO] [stdout] | [INFO] [stdout] 116 | let is_error = *task >= ERROR as i32 && *task <= ERROR_END as i32; [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `ERROR` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/print.rs:116:54 [INFO] [stdout] | [INFO] [stdout] 116 | let is_error = *task >= ERROR as i32 && *task <= ERROR_END as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `ERROR_END` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `x` [INFO] [stdout] --> src/print.rs:133:18 [INFO] [stdout] | [INFO] [stdout] 133 | for i in 0..n as usize { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 133 - for i in 0..n as usize { [INFO] [stdout] 133 + for in x.iter().take(n as usize) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i32` is unnecessary [INFO] [stdout] --> src/print.rs:186:5 [INFO] [stdout] | [INFO] [stdout] 186 | 0 as i32 [INFO] [stdout] | ^^^^^^^^ help: try: `0_i32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/print.rs:190:1 [INFO] [stdout] | [INFO] [stdout] 190 | / pub fn errclb( [INFO] [stdout] 191 | | n: i32, [INFO] [stdout] 192 | | m: i32, [INFO] [stdout] 193 | | factr: f64, [INFO] [stdout] ... | [INFO] [stdout] 199 | | k: &mut i32, [INFO] [stdout] 200 | | ) -> i32 { [INFO] [stdout] | |________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/print.rs:202:17 [INFO] [stdout] | [INFO] [stdout] 202 | *task = ERROR_N0 as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `ERROR_N0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/print.rs:205:17 [INFO] [stdout] | [INFO] [stdout] 205 | *task = ERROR_M0 as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `ERROR_M0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/print.rs:208:17 [INFO] [stdout] | [INFO] [stdout] 208 | *task = ERROR_FACTR as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `ERROR_FACTR` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/print.rs:213:21 [INFO] [stdout] | [INFO] [stdout] 213 | *task = ERROR_NBD as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `ERROR_NBD` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/print.rs:217:9 [INFO] [stdout] | [INFO] [stdout] 217 | / if nbd[i] == 2 { [INFO] [stdout] 218 | | if l[i] > u[i] { [INFO] [stdout] 219 | | *task = ERROR_FEAS as i32; [INFO] [stdout] 220 | | *info = -7; [INFO] [stdout] ... | [INFO] [stdout] 223 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 217 ~ if nbd[i] == 2 [INFO] [stdout] 218 ~ && l[i] > u[i] { [INFO] [stdout] 219 | *task = ERROR_FEAS as i32; [INFO] [stdout] 220 | *info = -7; [INFO] [stdout] 221 | *k = (i + 1) as i32; // Convert back to 1-based indexing for error reporting [INFO] [stdout] 222 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/print.rs:219:25 [INFO] [stdout] | [INFO] [stdout] 219 | *task = ERROR_FEAS as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `ERROR_FEAS` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> src/algorithm.rs:41:30 [INFO] [stdout] | [INFO] [stdout] 41 | pub const DBL_EPSILON: f64 = 2.2204460492503131e-16f64; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] = note: `#[warn(clippy::excessive_precision)]` on by default [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 41 - pub const DBL_EPSILON: f64 = 2.2204460492503131e-16f64; [INFO] [stdout] 41 + pub const DBL_EPSILON: f64 = 2.220_446_049_250_313e-16_f64; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (17/7) [INFO] [stdout] --> src/algorithm.rs:53:1 [INFO] [stdout] | [INFO] [stdout] 53 | / pub fn setulb( [INFO] [stdout] 54 | | n: usize, [INFO] [stdout] 55 | | m: usize, [INFO] [stdout] 56 | | x: &mut [f64], [INFO] [stdout] ... | [INFO] [stdout] 70 | | dsave: &mut [f64], [INFO] [stdout] 71 | | ) -> i32 { [INFO] [stdout] | |________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (31/7) [INFO] [stdout] --> src/algorithm.rs:173:1 [INFO] [stdout] | [INFO] [stdout] 173 | / pub fn mainlb( [INFO] [stdout] 174 | | n: usize, [INFO] [stdout] 175 | | m: usize, [INFO] [stdout] 176 | | x: &mut [f64], [INFO] [stdout] ... | [INFO] [stdout] 204 | | dsave: &mut [f64], [INFO] [stdout] 205 | | ) -> i32 { [INFO] [stdout] | |________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/algorithm.rs:671:32 [INFO] [stdout] | [INFO] [stdout] 671 | ... if cnstnd == false && col > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `!cnstnd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/algorithm.rs:769:36 [INFO] [stdout] | [INFO] [stdout] 769 | ... if wrk == true { [INFO] [stdout] | ^^^^^^^^^^^ help: try: `wrk` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/algorithm.rs:778:41 [INFO] [stdout] | [INFO] [stdout] 778 | ... iupdat as usize, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `iupdat` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/algorithm.rs:974:5 [INFO] [stdout] | [INFO] [stdout] 974 | / match current_block { [INFO] [stdout] 975 | | Block::Init => { [INFO] [stdout] 976 | | *task = FG_START; [INFO] [stdout] ... | [INFO] [stdout] 980 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 974 ~ if let Block::Init = current_block { [INFO] [stdout] 975 + *task = FG_START; [INFO] [stdout] 976 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/subalgorithms.rs:12:1 [INFO] [stdout] | [INFO] [stdout] 12 | / pub fn active( [INFO] [stdout] 13 | | n: usize, [INFO] [stdout] 14 | | l: &[f64], [INFO] [stdout] 15 | | u: &[f64], [INFO] [stdout] ... | [INFO] [stdout] 21 | | boxed: &mut bool, [INFO] [stdout] 22 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like you're manually copying between slices [INFO] [stdout] --> src/subalgorithms.rs:107:5 [INFO] [stdout] | [INFO] [stdout] 107 | / for i in 0..col { [INFO] [stdout] 108 | | p_col_plus[i] = p[col + i]; [INFO] [stdout] 109 | | } [INFO] [stdout] | |_____^ help: try replacing the loop by: `p_col_plus[..col].copy_from_slice(&p[col..(col + col)]);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like you're manually copying between slices [INFO] [stdout] --> src/subalgorithms.rs:124:13 [INFO] [stdout] | [INFO] [stdout] 124 | / for i in 0..col { [INFO] [stdout] 125 | | p[col + i] = p_col_plus[i]; [INFO] [stdout] 126 | | } [INFO] [stdout] | |_____________^ help: try replacing the loop by: `p[col..(col + col)].copy_from_slice(&p_col_plus[..col]);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like you're manually copying between slices [INFO] [stdout] --> src/subalgorithms.rs:138:5 [INFO] [stdout] | [INFO] [stdout] 138 | / for i in 0..col { [INFO] [stdout] 139 | | p_col_plus[i] = p[col + i]; [INFO] [stdout] 140 | | } [INFO] [stdout] | |_____^ help: try replacing the loop by: `p_col_plus[..col].copy_from_slice(&p[col..(col + col)]);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like you're manually copying between slices [INFO] [stdout] --> src/subalgorithms.rs:151:13 [INFO] [stdout] | [INFO] [stdout] 151 | / for i in 0..col { [INFO] [stdout] 152 | | p[col + i] = p_col_plus[i]; [INFO] [stdout] 153 | | } [INFO] [stdout] | |_____________^ help: try replacing the loop by: `p[col..(col + col)].copy_from_slice(&p_col_plus[..col]);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (16/7) [INFO] [stdout] --> src/subalgorithms.rs:187:1 [INFO] [stdout] | [INFO] [stdout] 187 | / fn initialize_cauchy( [INFO] [stdout] 188 | | n: usize, [INFO] [stdout] 189 | | x: &[f64], [INFO] [stdout] 190 | | l: &[f64], [INFO] [stdout] ... | [INFO] [stdout] 203 | | p: &mut [f64] [INFO] [stdout] 204 | | ) -> (bool, usize, usize, usize, f64, f64) { [INFO] [stdout] | |__________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `p` [INFO] [stdout] --> src/subalgorithms.rs:217:14 [INFO] [stdout] | [INFO] [stdout] 217 | for i in 0..col2 { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 217 - for i in 0..col2 { [INFO] [stdout] 217 + for in p.iter_mut().take(col2) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the use of negated comparison operators on partially ordered types produces code that is hard to read and refactor, please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable [INFO] [stdout] --> src/subalgorithms.rs:339:20 [INFO] [stdout] | [INFO] [stdout] 339 | if !(ddum < t[idx(j)]) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stdout] = note: `#[warn(clippy::neg_cmp_op_on_partial_ord)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the use of negated comparison operators on partially ordered types produces code that is hard to read and refactor, please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable [INFO] [stdout] --> src/subalgorithms.rs:380:16 [INFO] [stdout] | [INFO] [stdout] 380 | if !(t[idx(j)] < ddum) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (26/7) [INFO] [stdout] --> src/subalgorithms.rs:435:1 [INFO] [stdout] | [INFO] [stdout] 435 | / pub fn cauchy( [INFO] [stdout] 436 | | n: usize, [INFO] [stdout] 437 | | x: &[f64], [INFO] [stdout] 438 | | l: &[f64], [INFO] [stdout] ... | [INFO] [stdout] 461 | | epsmch: f64 [INFO] [stdout] 462 | | ) -> Result<(), i32> { [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is only used to index `c` [INFO] [stdout] --> src/subalgorithms.rs:493:14 [INFO] [stdout] | [INFO] [stdout] 493 | for j in 0..col2 { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 493 - for j in 0..col2 { [INFO] [stdout] 493 + for in c.iter_mut().take(col2) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/subalgorithms.rs:658:24 [INFO] [stdout] | [INFO] [stdout] 658 | if let Err(_) = result { [INFO] [stdout] | -------^^^^^^--------- help: try: `if result.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (17/7) [INFO] [stdout] --> src/subalgorithms.rs:731:1 [INFO] [stdout] | [INFO] [stdout] 731 | / pub fn cmprlb( [INFO] [stdout] 732 | | n: usize, [INFO] [stdout] 733 | | m: usize, [INFO] [stdout] 734 | | x: &[f64], [INFO] [stdout] ... | [INFO] [stdout] 748 | | cnstnd: bool, [INFO] [stdout] 749 | | ) -> Result<(), i32> { [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like you're manually copying between slices [INFO] [stdout] --> src/subalgorithms.rs:782:5 [INFO] [stdout] | [INFO] [stdout] 782 | / for i in 0..2*col { [INFO] [stdout] 783 | | wa[i] = p[i]; [INFO] [stdout] 784 | | } [INFO] [stdout] | |_____^ help: try replacing the loop by: `wa[..(2 * col)].copy_from_slice(&p[..(2 * col)]);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (17/7) [INFO] [stdout] --> src/subalgorithms.rs:829:1 [INFO] [stdout] | [INFO] [stdout] 829 | / pub fn formk( [INFO] [stdout] 830 | | n: usize, [INFO] [stdout] 831 | | nsub: usize, [INFO] [stdout] 832 | | ind: &[i32], [INFO] [stdout] ... | [INFO] [stdout] 846 | | head: usize, [INFO] [stdout] 847 | | ) -> Result<(), i32> { [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:866:34 [INFO] [stdout] | [INFO] [stdout] 866 | let src_offset = ((jy + 1) + (jy + 1) * wn1_dim) as usize; // Equivalent to 1-based jy + 1 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((jy + 1) + (jy + 1) * wn1_dim)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:867:34 [INFO] [stdout] | [INFO] [stdout] 867 | let dst_offset = (jy + jy * wn1_dim) as usize; // Equivalent to 1-based jy [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(jy + jy * wn1_dim)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:868:33 [INFO] [stdout] | [INFO] [stdout] 868 | let slice_len = i__2 as usize; [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `i__2` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:874:34 [INFO] [stdout] | [INFO] [stdout] 874 | let src_offset = ((js + 1) + (js + 1) * wn1_dim) as usize; // Equivalent to 1-based js + 1 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((js + 1) + (js + 1) * wn1_dim)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:875:34 [INFO] [stdout] | [INFO] [stdout] 875 | let dst_offset = (js + js * wn1_dim) as usize; // Equivalent to 1-based js [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(js + js * wn1_dim)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:876:33 [INFO] [stdout] | [INFO] [stdout] 876 | let slice_len = i__2 as usize; [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `i__2` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:882:34 [INFO] [stdout] | [INFO] [stdout] 882 | let src_offset = (m + 1 + (jy + 1) * wn1_dim) as usize; // Equivalent to 1-based m + 2 + (jy + 1) * wn1_dim [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(m + 1 + (jy + 1) * wn1_dim)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:883:34 [INFO] [stdout] | [INFO] [stdout] 883 | let dst_offset = (m + jy * wn1_dim) as usize; // Equivalent to 1-based m + 1 + jy * wn1_dim [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(m + jy * wn1_dim)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:884:33 [INFO] [stdout] | [INFO] [stdout] 884 | let slice_len = i__2 as usize; [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `i__2` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `k` is only used to index `ind` [INFO] [stdout] --> src/subalgorithms.rs:913:22 [INFO] [stdout] | [INFO] [stdout] 913 | for k in pbegin..=pend { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 913 - for k in pbegin..=pend { [INFO] [stdout] 913 + for in ind.iter().take(pend + 1).skip(pbegin) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `k` is only used to index `ind` [INFO] [stdout] --> src/subalgorithms.rs:921:22 [INFO] [stdout] | [INFO] [stdout] 921 | for k in dbegin..=dend { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 921 - for k in dbegin..=dend { [INFO] [stdout] 921 + for in ind.iter().take(dend + 1).skip(dbegin) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `k` is only used to index `ind` [INFO] [stdout] --> src/subalgorithms.rs:953:22 [INFO] [stdout] | [INFO] [stdout] 953 | for k in pbegin..=pend { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 953 - for k in pbegin..=pend { [INFO] [stdout] 953 + for in ind.iter().take(pend + 1).skip(pbegin) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `k` is only used to index `indx2` [INFO] [stdout] --> src/subalgorithms.rs:985:22 [INFO] [stdout] | [INFO] [stdout] 985 | for k in 0..nenter { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 985 - for k in 0..nenter { [INFO] [stdout] 985 + for in indx2.iter().take(nenter) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `k` is only used to index `indx2` [INFO] [stdout] --> src/subalgorithms.rs:997:22 [INFO] [stdout] | [INFO] [stdout] 997 | for k in (ileave - 1)..n { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 997 - for k in (ileave - 1)..n { [INFO] [stdout] 997 + for in indx2.iter().take(n).skip((ileave - 1)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `k` is only used to index `indx2` [INFO] [stdout] --> src/subalgorithms.rs:1030:22 [INFO] [stdout] | [INFO] [stdout] 1030 | for k in 0..nenter { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 1030 - for k in 0..nenter { [INFO] [stdout] 1030 + for in indx2.iter().take(nenter) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `k` is only used to index `indx2` [INFO] [stdout] --> src/subalgorithms.rs:1039:22 [INFO] [stdout] | [INFO] [stdout] 1039 | for k in (ileave - 1)..n { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 1039 - for k in (ileave - 1)..n { [INFO] [stdout] 1039 + for in indx2.iter().take(n).skip((ileave - 1)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:1135:46 [INFO] [stdout] | [INFO] [stdout] 1135 | let mut d = ddot(col as i32, &wn[(is * wn_dim) as usize..], 1, &wn[js * wn_dim..], 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `(is * wn_dim)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:1176:22 [INFO] [stdout] | [INFO] [stdout] 1176 | let k1 = (i.min(j) - 1) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(i.min(j) - 1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (11/7) [INFO] [stdout] --> src/subalgorithms.rs:1191:1 [INFO] [stdout] | [INFO] [stdout] 1191 | / pub fn freev( [INFO] [stdout] 1192 | | n: usize, [INFO] [stdout] 1193 | | nfree: &mut usize, [INFO] [stdout] 1194 | | index: &mut [i32], [INFO] [stdout] ... | [INFO] [stdout] 1202 | | iter: i32, [INFO] [stdout] 1203 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (17/7) [INFO] [stdout] --> src/subalgorithms.rs:1270:1 [INFO] [stdout] | [INFO] [stdout] 1270 | / pub fn matupd( [INFO] [stdout] 1271 | | n: usize, [INFO] [stdout] 1272 | | m: usize, [INFO] [stdout] 1273 | | ws: &mut [f64], [INFO] [stdout] ... | [INFO] [stdout] 1287 | | dtd: f64, [INFO] [stdout] 1288 | | ) -> i32 { [INFO] [stdout] | |________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:1310:47 [INFO] [stdout] | [INFO] [stdout] 1310 | ws[(i + itail_zero * n) as usize] = d[i as usize]; [INFO] [stdout] | ^^^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:1310:12 [INFO] [stdout] | [INFO] [stdout] 1310 | ws[(i + itail_zero * n) as usize] = d[i as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((i + itail_zero * n))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:1315:47 [INFO] [stdout] | [INFO] [stdout] 1315 | wy[(i + itail_zero * n) as usize] = r[i as usize]; [INFO] [stdout] | ^^^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:1315:12 [INFO] [stdout] | [INFO] [stdout] 1315 | wy[(i + itail_zero * n) as usize] = r[i as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((i + itail_zero * n))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:1324:21 [INFO] [stdout] | [INFO] [stdout] 1324 | for j in 1..(*col as usize) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `*col` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:1327:63 [INFO] [stdout] | [INFO] [stdout] 1327 | ss[k + (j-1) * (m as usize)] = ss[(k+1) + j * (m as usize)]; [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `m` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:1327:32 [INFO] [stdout] | [INFO] [stdout] 1327 | ss[k + (j-1) * (m as usize)] = ss[(k+1) + j * (m as usize)]; [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `m` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:1331:25 [INFO] [stdout] | [INFO] [stdout] 1331 | for k in j..(*col as usize) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `*col` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:1332:61 [INFO] [stdout] | [INFO] [stdout] 1332 | sy[k-1 + (j-1) * (m as usize)] = sy[k + j * (m as usize)]; [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `m` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:1332:34 [INFO] [stdout] | [INFO] [stdout] 1332 | sy[k-1 + (j-1) * (m as usize)] = sy[k + j * (m as usize)]; [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `m` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:1338:22 [INFO] [stdout] | [INFO] [stdout] 1338 | let mut pointr = *head as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `*head` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:1339:17 [INFO] [stdout] | [INFO] [stdout] 1339 | for j in 1..(*col as usize) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `*col` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:1343:83 [INFO] [stdout] | [INFO] [stdout] 1343 | sy[(*col as usize - 1) + j_idx * (m as usize)] = ddot(n as i32, d, 1, &wy[((pointr-1) * (wy_dim1 as usize)) as usize..], 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((pointr-1) * (wy_dim1 as usize))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:1343:97 [INFO] [stdout] | [INFO] [stdout] 1343 | sy[(*col as usize - 1) + j_idx * (m as usize)] = ddot(n as i32, d, 1, &wy[((pointr-1) * (wy_dim1 as usize)) as usize..], 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `wy_dim1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:1343:13 [INFO] [stdout] | [INFO] [stdout] 1343 | sy[(*col as usize - 1) + j_idx * (m as usize)] = ddot(n as i32, d, 1, &wy[((pointr-1) * (wy_dim1 as usize)) as usize..], 1); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `*col` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:1343:42 [INFO] [stdout] | [INFO] [stdout] 1343 | sy[(*col as usize - 1) + j_idx * (m as usize)] = ddot(n as i32, d, 1, &wy[((pointr-1) * (wy_dim1 as usize)) as usize..], 1); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `m` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:1344:77 [INFO] [stdout] | [INFO] [stdout] 1344 | ss[j_idx + (*col as usize - 1) * (m as usize)] = ddot(n as i32, &ws[((pointr-1) * (wy_dim1 as usize)) as usize..], 1, d, 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((pointr-1) * (wy_dim1 as usize))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:1344:91 [INFO] [stdout] | [INFO] [stdout] 1344 | ss[j_idx + (*col as usize - 1) * (m as usize)] = ddot(n as i32, &ws[((pointr-1) * (wy_dim1 as usize)) as usize..], 1, d, 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `wy_dim1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:1344:21 [INFO] [stdout] | [INFO] [stdout] 1344 | ss[j_idx + (*col as usize - 1) * (m as usize)] = ddot(n as i32, &ws[((pointr-1) * (wy_dim1 as usize)) as usize..], 1, d, 1); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `*col` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:1344:42 [INFO] [stdout] | [INFO] [stdout] 1344 | ss[j_idx + (*col as usize - 1) * (m as usize)] = ddot(n as i32, &ws[((pointr-1) * (wy_dim1 as usize)) as usize..], 1, d, 1); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `m` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:1347:27 [INFO] [stdout] | [INFO] [stdout] 1347 | pointr = pointr % (m as usize) + 1; [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `m` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:1352:12 [INFO] [stdout] | [INFO] [stdout] 1352 | ss[(col_zero + col_zero * ss_dim1) as usize] = dtd; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((col_zero + col_zero * ss_dim1))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:1354:12 [INFO] [stdout] | [INFO] [stdout] 1354 | ss[(col_zero + col_zero * ss_dim1) as usize] = stp * stp * dtd; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((col_zero + col_zero * ss_dim1))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/subalgorithms.rs:1358:8 [INFO] [stdout] | [INFO] [stdout] 1358 | sy[(col_zero + col_zero * sy_dim1) as usize] = dr; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((col_zero + col_zero * sy_dim1))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (12/7) [INFO] [stdout] --> src/subalgorithms.rs:1393:1 [INFO] [stdout] | [INFO] [stdout] 1393 | / pub fn compute_newton_direction( [INFO] [stdout] 1394 | | nsub: usize, [INFO] [stdout] 1395 | | ind: &[i32], [INFO] [stdout] 1396 | | d: &mut [f64], [INFO] [stdout] ... | [INFO] [stdout] 1405 | | n: usize, [INFO] [stdout] 1406 | | ) -> Result<(), i32> { [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `wv` [INFO] [stdout] --> src/subalgorithms.rs:1445:14 [INFO] [stdout] | [INFO] [stdout] 1445 | for i in 0..col { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 1445 - for i in 0..col { [INFO] [stdout] 1445 + for in wv.iter_mut().take(col) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `d` [INFO] [stdout] --> src/subalgorithms.rs:1476:14 [INFO] [stdout] | [INFO] [stdout] 1476 | for i in 0..nsub { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 1476 - for i in 0..nsub { [INFO] [stdout] 1476 + for in d.iter_mut().take(nsub) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/subalgorithms.rs:1484:1 [INFO] [stdout] | [INFO] [stdout] 1484 | / fn project_onto_feasible_region( [INFO] [stdout] 1485 | | nsub: usize, [INFO] [stdout] 1486 | | ind: &[i32], [INFO] [stdout] 1487 | | d: &[f64], [INFO] [stdout] ... | [INFO] [stdout] 1493 | | n: usize, [INFO] [stdout] 1494 | | ) -> bool { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (11/7) [INFO] [stdout] --> src/subalgorithms.rs:1537:1 [INFO] [stdout] | [INFO] [stdout] 1537 | / fn backtrack_if_needed( [INFO] [stdout] 1538 | | nsub: usize, [INFO] [stdout] 1539 | | ind: &[i32], [INFO] [stdout] 1540 | | d: &mut [f64], [INFO] [stdout] ... | [INFO] [stdout] 1548 | | n: usize, [INFO] [stdout] 1549 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (19/7) [INFO] [stdout] --> src/subalgorithms.rs:1613:1 [INFO] [stdout] | [INFO] [stdout] 1613 | / pub fn subsm( [INFO] [stdout] 1614 | | n: usize, [INFO] [stdout] 1615 | | m: usize, [INFO] [stdout] 1616 | | nsub: usize, [INFO] [stdout] ... | [INFO] [stdout] 1632 | | wn: &[f64], [INFO] [stdout] 1633 | | ) -> i32 { [INFO] [stdout] | |________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/subalgorithms.rs:1693:5 [INFO] [stdout] | [INFO] [stdout] 1693 | return iword; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1693 - return iword; [INFO] [stdout] 1693 + iword [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/timer.rs:8:13 [INFO] [stdout] | [INFO] [stdout] 7 | let seconds = duration.as_secs_f64(); [INFO] [stdout] | ------------------------------------- unnecessary `let` binding [INFO] [stdout] 8 | seconds [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 7 ~ [INFO] [stdout] 8 ~ duration.as_secs_f64() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `vector` [INFO] [stdout] --> src/debug.rs:19:14 [INFO] [stdout] | [INFO] [stdout] 19 | for i in 0..len { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 19 - for i in 0..len { [INFO] [stdout] 19 + for in vector.iter().take(len) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `vector` [INFO] [stdout] --> src/debug.rs:29:14 [INFO] [stdout] | [INFO] [stdout] 29 | for i in 0..len { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 29 - for i in 0..len { [INFO] [stdout] 29 + for in vector.iter().take(len) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 7.30s [INFO] running `Command { std: "docker" "inspect" "447b9d544f1232acbdb18dc4ecb232d7bdec00c95d4d040b6f41e8fa14bd8422", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "447b9d544f1232acbdb18dc4ecb232d7bdec00c95d4d040b6f41e8fa14bd8422", kill_on_drop: false }` [INFO] [stdout] 447b9d544f1232acbdb18dc4ecb232d7bdec00c95d4d040b6f41e8fa14bd8422