[INFO] fetching crate lain_derive 0.5.5... [INFO] linting lain_derive-0.5.5 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate lain_derive 0.5.5 into /workspace/builds/worker-1-tc1/source [INFO] started tweaking crates.io crate lain_derive 0.5.5 [INFO] finished tweaking crates.io crate lain_derive 0.5.5 [INFO] tweaked toml for crates.io crate lain_derive 0.5.5 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate lain_derive 0.5.5 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 6 packages to latest compatible versions [INFO] [stderr] Adding proc-macro2 v0.4.30 (available: v1.0.106) [INFO] [stderr] Adding quote v0.6.13 (available: v1.0.45) [INFO] [stderr] Adding syn v0.15.44 (available: v2.0.117) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 54f7b3fe62551fbb149155d7f2130d288814190e59580d86b26c9de3474f0946 [INFO] running `Command { std: "docker" "start" "-a" "54f7b3fe62551fbb149155d7f2130d288814190e59580d86b26c9de3474f0946", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "54f7b3fe62551fbb149155d7f2130d288814190e59580d86b26c9de3474f0946", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "54f7b3fe62551fbb149155d7f2130d288814190e59580d86b26c9de3474f0946", kill_on_drop: false }` [INFO] [stdout] 54f7b3fe62551fbb149155d7f2130d288814190e59580d86b26c9de3474f0946 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5bfa6aa1a8a5956ec044d4d546aed6ad370cb274f369d1e9b6509ecb04bb967e [INFO] running `Command { std: "docker" "start" "-a" "5bfa6aa1a8a5956ec044d4d546aed6ad370cb274f369d1e9b6509ecb04bb967e", kill_on_drop: false }` [INFO] [stderr] Checking unicode-xid v0.1.0 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking log v0.4.29 [INFO] [stderr] Checking proc-macro2 v0.4.30 [INFO] [stderr] Checking quote v0.6.13 [INFO] [stderr] Checking lain_derive v0.5.5 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/internals/attr.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 25 | cx: cx, [INFO] [stdout] | ^^^^^^ help: replace it with: `cx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/internals/attr.rs:26:13 [INFO] [stdout] | [INFO] [stdout] 26 | name: name, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/internals/ctxt.rs:8:1 [INFO] [stdout] | [INFO] [stdout] 8 | use syn; [INFO] [stdout] | ^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/internals/attr.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 25 | cx: cx, [INFO] [stdout] | ^^^^^^ help: replace it with: `cx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/internals/attr.rs:26:13 [INFO] [stdout] | [INFO] [stdout] 26 | name: name, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/internals/ctxt.rs:8:1 [INFO] [stdout] | [INFO] [stdout] 8 | use syn; [INFO] [stdout] | ^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `generics` and `original` are never read [INFO] [stdout] --> src/internals/ast.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 8 | pub struct Container<'a> { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 16 | pub generics: &'a syn::Generics, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 17 | /// Original input. [INFO] [stdout] 18 | pub original: &'a syn::DeriveInput, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/internals/ast.rs:141:71 [INFO] [stdout] | [INFO] [stdout] 141 | let bitfield_type = field.attrs.bitfield_type().unwrap_or(&field.ty); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `field.ty` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/internals/ast.rs:151:37 [INFO] [stdout] | [INFO] [stdout] 151 | ... cx.error_spanned_by(&field.ty, "Unsupported bitfield datatype. Did you forget to specify `#[lain(bitfield_type = \"...\")]`?"); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `field.ty` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/internals/ast.rs:158:37 [INFO] [stdout] | [INFO] [stdout] 158 | cx.error_spanned_by(&field.ty, "Number of bits specified overflows bitfield type"); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `field.ty` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/internals/ast.rs:166:8 [INFO] [stdout] | [INFO] [stdout] 166 | if fields.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `fields.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/internals/attr.rs:120:9 [INFO] [stdout] | [INFO] [stdout] 120 | self.serialized_size.clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.serialized_size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/internals/attr.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 124 | self.min_serialized_size.clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.min_serialized_size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/internals/attr.rs:211:63 [INFO] [stdout] | [INFO] [stdout] 211 | if let Ok(expr) = parse_lit_into_type(&cx, BITFIELD_TYPE, &m.lit) { [INFO] [stdout] | ^^^ help: change this to: `cx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> src/internals/attr.rs:255:57 [INFO] [stdout] | [INFO] [stdout] 255 | ... ignore_chance.set(&m.ident, f.value() as f64); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `f.value()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern creates a reference to a reference [INFO] [stdout] --> src/internals/attr.rs:266:35 [INFO] [stdout] | [INFO] [stdout] 266 | if let Ok(ref s) = get_lit_str(cx, INITIALIZER, INITIALIZER, &m.lit) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 266 - if let Ok(ref s) = get_lit_str(cx, INITIALIZER, INITIALIZER, &m.lit) { [INFO] [stdout] 266 + if let Ok(s) = get_lit_str(cx, INITIALIZER, INITIALIZER, &m.lit) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internals/attr.rs:324:9 [INFO] [stdout] | [INFO] [stdout] 324 | return self.is_last_field; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 324 - return self.is_last_field; [INFO] [stdout] 324 + self.is_last_field [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/internals/attr.rs:328:9 [INFO] [stdout] | [INFO] [stdout] 328 | self.bits.clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.bits` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/internals/attr.rs:332:9 [INFO] [stdout] | [INFO] [stdout] 332 | self.bit_shift.clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.bit_shift` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/internals/attr.rs:356:9 [INFO] [stdout] | [INFO] [stdout] 356 | self.ignore_chance.clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.ignore_chance` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> src/internals/attr.rs:411:57 [INFO] [stdout] | [INFO] [stdout] 411 | ... ignore_chance.set(&m.ident, f.value() as f64); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `f.value()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/internals/attr.rs:442:9 [INFO] [stdout] | [INFO] [stdout] 442 | self.weight.clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.weight` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/internals/symbol.rs:28:6 [INFO] [stdout] | [INFO] [stdout] 28 | impl<'a> PartialEq for &'a Ident { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 28 - impl<'a> PartialEq for &'a Ident { [INFO] [stdout] 28 + impl PartialEq for &Ident { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.filter_map(..)` can be written more simply using `.map(..)` [INFO] [stdout] --> src/mutations.rs:220:10 [INFO] [stdout] | [INFO] [stdout] 220 | .filter_map(|variant| { [INFO] [stdout] | __________^ [INFO] [stdout] ... | [INFO] [stdout] 228 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map [INFO] [stdout] = note: `#[warn(clippy::unnecessary_filter_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.filter_map(..)` can be written more simply using `.map(..)` [INFO] [stdout] --> src/mutations.rs:237:10 [INFO] [stdout] | [INFO] [stdout] 237 | .filter_map(|variant| { [INFO] [stdout] | __________^ [INFO] [stdout] ... | [INFO] [stdout] 264 | | Some(match_arm) [INFO] [stdout] 265 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/mutations.rs:481:64 [INFO] [stdout] | [INFO] [stdout] 481 | if attrs.ignore() || (attrs.initializer().is_some() && !attrs.ignore_chance().is_some()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `attrs.ignore_chance().is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/mutations.rs:480:5 [INFO] [stdout] | [INFO] [stdout] 480 | / if !for_mutation { [INFO] [stdout] 481 | | if attrs.ignore() || (attrs.initializer().is_some() && !attrs.ignore_chance().is_some()) { [INFO] [stdout] 482 | | return TokenStream::new(); [INFO] [stdout] 483 | | } [INFO] [stdout] 484 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 480 ~ if !for_mutation [INFO] [stdout] 481 ~ && (attrs.ignore() || (attrs.initializer().is_some() && !attrs.ignore_chance().is_some())) { [INFO] [stdout] 482 | return TokenStream::new(); [INFO] [stdout] 483 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/mutations.rs:574:43 [INFO] [stdout] | [INFO] [stdout] 574 | let inc_max_size = decrement_max_size(&field, &value_ident); [INFO] [stdout] | ^^^^^^ help: change this to: `field` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/mutations.rs:685:53 [INFO] [stdout] | [INFO] [stdout] 685 | let inc_max_size = mutatable_decrement_max_size(&field, &value_ident); [INFO] [stdout] | ^^^^^^ help: change this to: `field` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/serialize.rs:142:25 [INFO] [stdout] | [INFO] [stdout] 142 | if let Some(size) = size.clone() { [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/serialize.rs:246:67 [INFO] [stdout] | [INFO] [stdout] 246 | let bitfield_type = field.attrs.bitfield_type().unwrap_or(&field.ty); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `field.ty` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/serialize.rs:250:37 [INFO] [stdout] | [INFO] [stdout] 250 | } else if is_primitive_type(&bitfield_type, "u16") { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `bitfield_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/serialize.rs:252:37 [INFO] [stdout] | [INFO] [stdout] 252 | } else if is_primitive_type(&bitfield_type, "u32") { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `bitfield_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/serialize.rs:254:37 [INFO] [stdout] | [INFO] [stdout] 254 | } else if is_primitive_type(&bitfield_type, "u64") { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `bitfield_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/serialize.rs:463:67 [INFO] [stdout] | [INFO] [stdout] 463 | let bitfield_type = field.attrs.bitfield_type().unwrap_or(&field.ty); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `field.ty` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/serialize.rs:468:37 [INFO] [stdout] | [INFO] [stdout] 468 | } else if is_primitive_type(&bitfield_type, "u16") { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `bitfield_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/serialize.rs:470:37 [INFO] [stdout] | [INFO] [stdout] 470 | } else if is_primitive_type(&bitfield_type, "u32") { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `bitfield_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/serialize.rs:472:37 [INFO] [stdout] | [INFO] [stdout] 472 | } else if is_primitive_type(&bitfield_type, "u64") { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `bitfield_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:213:20 [INFO] [stdout] | [INFO] [stdout] 213 | if fields.named.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `fields.named.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `proc_macro2::TokenStream` [INFO] [stdout] --> src/lib.rs:256:9 [INFO] [stdout] | [INFO] [stdout] 256 | / mutations::expand_new_fuzzed(&input) [INFO] [stdout] 257 | | .unwrap_or_else(to_compile_errors) [INFO] [stdout] 258 | | .into(), [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing `.into()` [INFO] [stdout] | [INFO] [stdout] 256 ~ mutations::expand_new_fuzzed(&input) [INFO] [stdout] 257 ~ .unwrap_or_else(to_compile_errors), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `proc_macro2::TokenStream` [INFO] [stdout] --> src/lib.rs:261:9 [INFO] [stdout] | [INFO] [stdout] 261 | / mutations::expand_mutatable(&input) [INFO] [stdout] 262 | | .unwrap_or_else(to_compile_errors) [INFO] [stdout] 263 | | .into(), [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing `.into()` [INFO] [stdout] | [INFO] [stdout] 261 ~ mutations::expand_mutatable(&input) [INFO] [stdout] 262 ~ .unwrap_or_else(to_compile_errors), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/internals/attr.rs:127:22 [INFO] [stdout] | [INFO] [stdout] 127 | pub fn lain_path(&self) -> Cow { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 127 | pub fn lain_path(&self) -> Cow<'_, syn::Path> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `generics` and `original` are never read [INFO] [stdout] --> src/internals/ast.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 8 | pub struct Container<'a> { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 16 | pub generics: &'a syn::Generics, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 17 | /// Original input. [INFO] [stdout] 18 | pub original: &'a syn::DeriveInput, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/internals/ast.rs:141:71 [INFO] [stdout] | [INFO] [stdout] 141 | let bitfield_type = field.attrs.bitfield_type().unwrap_or(&field.ty); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `field.ty` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/internals/ast.rs:151:37 [INFO] [stdout] | [INFO] [stdout] 151 | ... cx.error_spanned_by(&field.ty, "Unsupported bitfield datatype. Did you forget to specify `#[lain(bitfield_type = \"...\")]`?"); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `field.ty` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/internals/ast.rs:158:37 [INFO] [stdout] | [INFO] [stdout] 158 | cx.error_spanned_by(&field.ty, "Number of bits specified overflows bitfield type"); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `field.ty` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/internals/ast.rs:166:8 [INFO] [stdout] | [INFO] [stdout] 166 | if fields.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `fields.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/internals/attr.rs:120:9 [INFO] [stdout] | [INFO] [stdout] 120 | self.serialized_size.clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.serialized_size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/internals/attr.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 124 | self.min_serialized_size.clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.min_serialized_size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/internals/attr.rs:211:63 [INFO] [stdout] | [INFO] [stdout] 211 | if let Ok(expr) = parse_lit_into_type(&cx, BITFIELD_TYPE, &m.lit) { [INFO] [stdout] | ^^^ help: change this to: `cx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> src/internals/attr.rs:255:57 [INFO] [stdout] | [INFO] [stdout] 255 | ... ignore_chance.set(&m.ident, f.value() as f64); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `f.value()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern creates a reference to a reference [INFO] [stdout] --> src/internals/attr.rs:266:35 [INFO] [stdout] | [INFO] [stdout] 266 | if let Ok(ref s) = get_lit_str(cx, INITIALIZER, INITIALIZER, &m.lit) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 266 - if let Ok(ref s) = get_lit_str(cx, INITIALIZER, INITIALIZER, &m.lit) { [INFO] [stdout] 266 + if let Ok(s) = get_lit_str(cx, INITIALIZER, INITIALIZER, &m.lit) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internals/attr.rs:324:9 [INFO] [stdout] | [INFO] [stdout] 324 | return self.is_last_field; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 324 - return self.is_last_field; [INFO] [stdout] 324 + self.is_last_field [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/internals/attr.rs:328:9 [INFO] [stdout] | [INFO] [stdout] 328 | self.bits.clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.bits` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/internals/attr.rs:332:9 [INFO] [stdout] | [INFO] [stdout] 332 | self.bit_shift.clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.bit_shift` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/internals/attr.rs:356:9 [INFO] [stdout] | [INFO] [stdout] 356 | self.ignore_chance.clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.ignore_chance` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> src/internals/attr.rs:411:57 [INFO] [stdout] | [INFO] [stdout] 411 | ... ignore_chance.set(&m.ident, f.value() as f64); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `f.value()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/internals/attr.rs:442:9 [INFO] [stdout] | [INFO] [stdout] 442 | self.weight.clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.weight` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/internals/symbol.rs:28:6 [INFO] [stdout] | [INFO] [stdout] 28 | impl<'a> PartialEq for &'a Ident { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 28 - impl<'a> PartialEq for &'a Ident { [INFO] [stdout] 28 + impl PartialEq for &Ident { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.filter_map(..)` can be written more simply using `.map(..)` [INFO] [stdout] --> src/mutations.rs:220:10 [INFO] [stdout] | [INFO] [stdout] 220 | .filter_map(|variant| { [INFO] [stdout] | __________^ [INFO] [stdout] ... | [INFO] [stdout] 228 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map [INFO] [stdout] = note: `#[warn(clippy::unnecessary_filter_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.filter_map(..)` can be written more simply using `.map(..)` [INFO] [stdout] --> src/mutations.rs:237:10 [INFO] [stdout] | [INFO] [stdout] 237 | .filter_map(|variant| { [INFO] [stdout] | __________^ [INFO] [stdout] ... | [INFO] [stdout] 264 | | Some(match_arm) [INFO] [stdout] 265 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/mutations.rs:481:64 [INFO] [stdout] | [INFO] [stdout] 481 | if attrs.ignore() || (attrs.initializer().is_some() && !attrs.ignore_chance().is_some()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `attrs.ignore_chance().is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/mutations.rs:480:5 [INFO] [stdout] | [INFO] [stdout] 480 | / if !for_mutation { [INFO] [stdout] 481 | | if attrs.ignore() || (attrs.initializer().is_some() && !attrs.ignore_chance().is_some()) { [INFO] [stdout] 482 | | return TokenStream::new(); [INFO] [stdout] 483 | | } [INFO] [stdout] 484 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 480 ~ if !for_mutation [INFO] [stdout] 481 ~ && (attrs.ignore() || (attrs.initializer().is_some() && !attrs.ignore_chance().is_some())) { [INFO] [stdout] 482 | return TokenStream::new(); [INFO] [stdout] 483 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/mutations.rs:574:43 [INFO] [stdout] | [INFO] [stdout] 574 | let inc_max_size = decrement_max_size(&field, &value_ident); [INFO] [stdout] | ^^^^^^ help: change this to: `field` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/mutations.rs:685:53 [INFO] [stdout] | [INFO] [stdout] 685 | let inc_max_size = mutatable_decrement_max_size(&field, &value_ident); [INFO] [stdout] | ^^^^^^ help: change this to: `field` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/serialize.rs:142:25 [INFO] [stdout] | [INFO] [stdout] 142 | if let Some(size) = size.clone() { [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/serialize.rs:246:67 [INFO] [stdout] | [INFO] [stdout] 246 | let bitfield_type = field.attrs.bitfield_type().unwrap_or(&field.ty); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `field.ty` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/serialize.rs:250:37 [INFO] [stdout] | [INFO] [stdout] 250 | } else if is_primitive_type(&bitfield_type, "u16") { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `bitfield_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/serialize.rs:252:37 [INFO] [stdout] | [INFO] [stdout] 252 | } else if is_primitive_type(&bitfield_type, "u32") { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `bitfield_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/serialize.rs:254:37 [INFO] [stdout] | [INFO] [stdout] 254 | } else if is_primitive_type(&bitfield_type, "u64") { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `bitfield_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/serialize.rs:463:67 [INFO] [stdout] | [INFO] [stdout] 463 | let bitfield_type = field.attrs.bitfield_type().unwrap_or(&field.ty); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `field.ty` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/serialize.rs:468:37 [INFO] [stdout] | [INFO] [stdout] 468 | } else if is_primitive_type(&bitfield_type, "u16") { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `bitfield_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/serialize.rs:470:37 [INFO] [stdout] | [INFO] [stdout] 470 | } else if is_primitive_type(&bitfield_type, "u32") { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `bitfield_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/serialize.rs:472:37 [INFO] [stdout] | [INFO] [stdout] 472 | } else if is_primitive_type(&bitfield_type, "u64") { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `bitfield_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:213:20 [INFO] [stdout] | [INFO] [stdout] 213 | if fields.named.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `fields.named.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `proc_macro2::TokenStream` [INFO] [stdout] --> src/lib.rs:256:9 [INFO] [stdout] | [INFO] [stdout] 256 | / mutations::expand_new_fuzzed(&input) [INFO] [stdout] 257 | | .unwrap_or_else(to_compile_errors) [INFO] [stdout] 258 | | .into(), [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing `.into()` [INFO] [stdout] | [INFO] [stdout] 256 ~ mutations::expand_new_fuzzed(&input) [INFO] [stdout] 257 ~ .unwrap_or_else(to_compile_errors), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `proc_macro2::TokenStream` [INFO] [stdout] --> src/lib.rs:261:9 [INFO] [stdout] | [INFO] [stdout] 261 | / mutations::expand_mutatable(&input) [INFO] [stdout] 262 | | .unwrap_or_else(to_compile_errors) [INFO] [stdout] 263 | | .into(), [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing `.into()` [INFO] [stdout] | [INFO] [stdout] 261 ~ mutations::expand_mutatable(&input) [INFO] [stdout] 262 ~ .unwrap_or_else(to_compile_errors), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/internals/attr.rs:127:22 [INFO] [stdout] | [INFO] [stdout] 127 | pub fn lain_path(&self) -> Cow { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 127 | pub fn lain_path(&self) -> Cow<'_, syn::Path> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 4.97s [INFO] running `Command { std: "docker" "inspect" "5bfa6aa1a8a5956ec044d4d546aed6ad370cb274f369d1e9b6509ecb04bb967e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5bfa6aa1a8a5956ec044d4d546aed6ad370cb274f369d1e9b6509ecb04bb967e", kill_on_drop: false }` [INFO] [stdout] 5bfa6aa1a8a5956ec044d4d546aed6ad370cb274f369d1e9b6509ecb04bb967e