[INFO] fetching crate kalgan_router 0.9.1... [INFO] linting kalgan_router-0.9.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate kalgan_router 0.9.1 into /workspace/builds/worker-3-tc1/source [INFO] started tweaking crates.io crate kalgan_router 0.9.1 [INFO] finished tweaking crates.io crate kalgan_router 0.9.1 [INFO] tweaked toml for crates.io crate kalgan_router 0.9.1 written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate kalgan_router 0.9.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 21 packages to latest compatible versions [INFO] [stderr] Adding serde_yaml v0.8.26 (available: v0.9.34+deprecated) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded kalgan_string v0.9.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4fa398fe41ed4103b5295a107740f5ad42ddd4396a7b1f45c08d75a4de70b525 [INFO] running `Command { std: "docker" "start" "-a" "4fa398fe41ed4103b5295a107740f5ad42ddd4396a7b1f45c08d75a4de70b525", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4fa398fe41ed4103b5295a107740f5ad42ddd4396a7b1f45c08d75a4de70b525", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4fa398fe41ed4103b5295a107740f5ad42ddd4396a7b1f45c08d75a4de70b525", kill_on_drop: false }` [INFO] [stdout] 4fa398fe41ed4103b5295a107740f5ad42ddd4396a7b1f45c08d75a4de70b525 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b719a1cc94c626003185b16b16b8e66e10c94344a70b2864bc0b6572fdeb634c [INFO] running `Command { std: "docker" "start" "-a" "b719a1cc94c626003185b16b16b8e66e10c94344a70b2864bc0b6572fdeb634c", kill_on_drop: false }` [INFO] [stderr] Checking kalgan_string v0.9.1 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking serde_yaml v0.8.26 [INFO] [stderr] Checking kalgan_router v0.9.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/lib.rs:164:37 [INFO] [stdout] | [INFO] [stdout] 164 | / ... format!( [INFO] [stdout] 165 | | ... r"{}", [INFO] [stdout] 166 | | ... &requirement[&Value::String(value)].as_str().unwrap() [INFO] [stdout] 167 | | ... ) [INFO] [stdout] | |_______________________^ help: consider using `.to_string()`: `(&requirement[&Value::String(value)].as_str().unwrap()).to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:215:32 [INFO] [stdout] | [INFO] [stdout] 215 | ... if !parameter.requirement.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `parameter.requirement.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `parameter.requirement` after checking its variant with `is_none` [INFO] [stdout] --> src/lib.rs:210:23 [INFO] [stdout] | [INFO] [stdout] 195 | if parameter.requirement.is_none() { [INFO] [stdout] | ---------------------------------- help: try: `if let Some() = ¶meter.requirement` [INFO] [stdout] ... [INFO] [stdout] 210 | match parameter.requirement.as_ref().unwrap().find(&partial_uri) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/lib.rs:212:25 [INFO] [stdout] | [INFO] [stdout] 212 | / if value.start() == 0 { [INFO] [stdout] 213 | | let result = &partial_uri[value.start()..value.end()]; [INFO] [stdout] 214 | | end = start + result.len(); [INFO] [stdout] 215 | | if !parameter.requirement.is_none() { [INFO] [stdout] ... | [INFO] [stdout] 220 | | return false; [INFO] [stdout] 221 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 211 ~ Some(value) [INFO] [stdout] 212 ~ if value.start() == 0 => { [INFO] [stdout] 213 | let result = &partial_uri[value.start()..value.end()]; [INFO] [stdout] ... [INFO] [stdout] 218 | } [INFO] [stdout] 219 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:210:68 [INFO] [stdout] | [INFO] [stdout] 210 | match parameter.requirement.as_ref().unwrap().find(&partial_uri) { [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `partial_uri` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:239:17 [INFO] [stdout] | [INFO] [stdout] 239 | / &route_keys[&Value::String("methods".to_string())] [INFO] [stdout] 240 | | .as_str() [INFO] [stdout] 241 | | .unwrap(), [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 239 ~ route_keys[&Value::String("methods".to_string())] [INFO] [stdout] 240 + .as_str() [INFO] [stdout] 241 ~ .unwrap(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lib.rs:288:9 [INFO] [stdout] | [INFO] [stdout] 288 | / if !self.language.is_empty() { [INFO] [stdout] 289 | | if self.parameters.contains_key(&self.language) { [INFO] [stdout] 290 | | self.language = self.parameters[&self.language].clone(); [INFO] [stdout] 291 | | } [INFO] [stdout] 292 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 288 ~ if !self.language.is_empty() [INFO] [stdout] 289 ~ && self.parameters.contains_key(&self.language) { [INFO] [stdout] 290 | self.language = self.parameters[&self.language].clone(); [INFO] [stdout] 291 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:319:43 [INFO] [stdout] | [INFO] [stdout] 319 | && route.uri_matches_path(&uri) [INFO] [stdout] | ^^^^ help: change this to: `uri` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/lib.rs:164:37 [INFO] [stdout] | [INFO] [stdout] 164 | / ... format!( [INFO] [stdout] 165 | | ... r"{}", [INFO] [stdout] 166 | | ... &requirement[&Value::String(value)].as_str().unwrap() [INFO] [stdout] 167 | | ... ) [INFO] [stdout] | |_______________________^ help: consider using `.to_string()`: `(&requirement[&Value::String(value)].as_str().unwrap()).to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:215:32 [INFO] [stdout] | [INFO] [stdout] 215 | ... if !parameter.requirement.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `parameter.requirement.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `parameter.requirement` after checking its variant with `is_none` [INFO] [stdout] --> src/lib.rs:210:23 [INFO] [stdout] | [INFO] [stdout] 195 | if parameter.requirement.is_none() { [INFO] [stdout] | ---------------------------------- help: try: `if let Some() = ¶meter.requirement` [INFO] [stdout] ... [INFO] [stdout] 210 | match parameter.requirement.as_ref().unwrap().find(&partial_uri) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/lib.rs:212:25 [INFO] [stdout] | [INFO] [stdout] 212 | / if value.start() == 0 { [INFO] [stdout] 213 | | let result = &partial_uri[value.start()..value.end()]; [INFO] [stdout] 214 | | end = start + result.len(); [INFO] [stdout] 215 | | if !parameter.requirement.is_none() { [INFO] [stdout] ... | [INFO] [stdout] 220 | | return false; [INFO] [stdout] 221 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 211 ~ Some(value) [INFO] [stdout] 212 ~ if value.start() == 0 => { [INFO] [stdout] 213 | let result = &partial_uri[value.start()..value.end()]; [INFO] [stdout] ... [INFO] [stdout] 218 | } [INFO] [stdout] 219 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:210:68 [INFO] [stdout] | [INFO] [stdout] 210 | match parameter.requirement.as_ref().unwrap().find(&partial_uri) { [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `partial_uri` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:239:17 [INFO] [stdout] | [INFO] [stdout] 239 | / &route_keys[&Value::String("methods".to_string())] [INFO] [stdout] 240 | | .as_str() [INFO] [stdout] 241 | | .unwrap(), [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 239 ~ route_keys[&Value::String("methods".to_string())] [INFO] [stdout] 240 + .as_str() [INFO] [stdout] 241 ~ .unwrap(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lib.rs:288:9 [INFO] [stdout] | [INFO] [stdout] 288 | / if !self.language.is_empty() { [INFO] [stdout] 289 | | if self.parameters.contains_key(&self.language) { [INFO] [stdout] 290 | | self.language = self.parameters[&self.language].clone(); [INFO] [stdout] 291 | | } [INFO] [stdout] 292 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 288 ~ if !self.language.is_empty() [INFO] [stdout] 289 ~ && self.parameters.contains_key(&self.language) { [INFO] [stdout] 290 | self.language = self.parameters[&self.language].clone(); [INFO] [stdout] 291 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:319:43 [INFO] [stdout] | [INFO] [stdout] 319 | && route.uri_matches_path(&uri) [INFO] [stdout] | ^^^^ help: change this to: `uri` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.55s [INFO] running `Command { std: "docker" "inspect" "b719a1cc94c626003185b16b16b8e66e10c94344a70b2864bc0b6572fdeb634c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b719a1cc94c626003185b16b16b8e66e10c94344a70b2864bc0b6572fdeb634c", kill_on_drop: false }` [INFO] [stdout] b719a1cc94c626003185b16b16b8e66e10c94344a70b2864bc0b6572fdeb634c