[INFO] fetching crate java_random 0.1.7... [INFO] linting java_random-0.1.7 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate java_random 0.1.7 into /workspace/builds/worker-7-tc1/source [INFO] started tweaking crates.io crate java_random 0.1.7 [INFO] finished tweaking crates.io crate java_random 0.1.7 [INFO] tweaked toml for crates.io crate java_random 0.1.7 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate java_random 0.1.7 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a08519dcd20c329e5cd9b6f691c7b059fd24d77e7275176546adbe0da5958cbf [INFO] running `Command { std: "docker" "start" "-a" "a08519dcd20c329e5cd9b6f691c7b059fd24d77e7275176546adbe0da5958cbf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a08519dcd20c329e5cd9b6f691c7b059fd24d77e7275176546adbe0da5958cbf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a08519dcd20c329e5cd9b6f691c7b059fd24d77e7275176546adbe0da5958cbf", kill_on_drop: false }` [INFO] [stdout] a08519dcd20c329e5cd9b6f691c7b059fd24d77e7275176546adbe0da5958cbf [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d95b5f6b634db199b6029c334cdd8305099e95fcead3e4895d384d27647eaca6 [INFO] running `Command { std: "docker" "start" "-a" "d95b5f6b634db199b6029c334cdd8305099e95fcead3e4895d384d27647eaca6", kill_on_drop: false }` [INFO] [stderr] Checking java_random v0.1.7 (/opt/rustwide/workdir) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:46:9 [INFO] [stdout] | [INFO] [stdout] 46 | return LCG { multiplier: Self::modulo(multiplier), addend: Self::modulo(addend) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 46 - return LCG { multiplier: Self::modulo(multiplier), addend: Self::modulo(addend) }; [INFO] [stdout] 46 + LCG { multiplier: Self::modulo(multiplier), addend: Self::modulo(addend) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:71:9 [INFO] [stdout] | [INFO] [stdout] 71 | / return LCG { [INFO] [stdout] 72 | | multiplier: self.multiplier * lcg.multiplier, [INFO] [stdout] 73 | | addend: self.addend * lcg.multiplier + lcg.addend, [INFO] [stdout] 74 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 71 ~ LCG { [INFO] [stdout] 72 + multiplier: self.multiplier * lcg.multiplier, [INFO] [stdout] 73 + addend: self.addend * lcg.multiplier + lcg.addend, [INFO] [stdout] 74 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:173:12 [INFO] [stdout] | [INFO] [stdout] 173 | if !(n > 0) { [INFO] [stdout] | ^^^^^^^^ help: try: `(n <= 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:46:9 [INFO] [stdout] | [INFO] [stdout] 46 | return LCG { multiplier: Self::modulo(multiplier), addend: Self::modulo(addend) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 46 - return LCG { multiplier: Self::modulo(multiplier), addend: Self::modulo(addend) }; [INFO] [stdout] 46 + LCG { multiplier: Self::modulo(multiplier), addend: Self::modulo(addend) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:71:9 [INFO] [stdout] | [INFO] [stdout] 71 | / return LCG { [INFO] [stdout] 72 | | multiplier: self.multiplier * lcg.multiplier, [INFO] [stdout] 73 | | addend: self.addend * lcg.multiplier + lcg.addend, [INFO] [stdout] 74 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 71 ~ LCG { [INFO] [stdout] 72 + multiplier: self.multiplier * lcg.multiplier, [INFO] [stdout] 73 + addend: self.addend * lcg.multiplier + lcg.addend, [INFO] [stdout] 74 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:173:12 [INFO] [stdout] | [INFO] [stdout] 173 | if !(n > 0) { [INFO] [stdout] | ^^^^^^^^ help: try: `(n <= 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.28s [INFO] running `Command { std: "docker" "inspect" "d95b5f6b634db199b6029c334cdd8305099e95fcead3e4895d384d27647eaca6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d95b5f6b634db199b6029c334cdd8305099e95fcead3e4895d384d27647eaca6", kill_on_drop: false }` [INFO] [stdout] d95b5f6b634db199b6029c334cdd8305099e95fcead3e4895d384d27647eaca6