[INFO] fetching crate jacquard-identity 0.9.5... [INFO] linting jacquard-identity-0.9.5 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate jacquard-identity 0.9.5 into /workspace/builds/worker-3-tc1/source [INFO] started tweaking crates.io crate jacquard-identity 0.9.5 [INFO] finished tweaking crates.io crate jacquard-identity 0.9.5 [INFO] tweaked toml for crates.io crate jacquard-identity 0.9.5 written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate jacquard-identity 0.9.5 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate jacquard-identity 0.9.5 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded cordyceps v0.3.4 [INFO] [stderr] Downloaded futures-buffered v0.2.12 [INFO] [stderr] Downloaded match-lookup v0.1.1 [INFO] [stderr] Downloaded jacquard-derive v0.9.5 [INFO] [stderr] Downloaded mini-moka-wasm v0.10.99 [INFO] [stderr] Downloaded bon v3.8.1 [INFO] [stderr] Downloaded jacquard-lexicon v0.9.5 [INFO] [stderr] Downloaded async-compression v0.4.35 [INFO] [stderr] Downloaded hickory-resolver v0.24.4 [INFO] [stderr] Downloaded bon-macros v3.8.1 [INFO] [stderr] Downloaded jacquard-common v0.9.5 [INFO] [stderr] Downloaded smol_str v0.3.4 [INFO] [stderr] Downloaded diatomic-waker v0.2.3 [INFO] [stderr] Downloaded n0-future v0.1.3 [INFO] [stderr] Downloaded compression-codecs v0.4.34 [INFO] [stderr] Downloaded serde_html_form v0.2.8 [INFO] [stderr] Downloaded hickory-proto v0.24.4 [INFO] [stderr] Downloaded jacquard-api v0.9.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e6ba08816fbb6438d8ead8613cb7326a97543bcad34d4e669644360b53590e28 [INFO] running `Command { std: "docker" "start" "-a" "e6ba08816fbb6438d8ead8613cb7326a97543bcad34d4e669644360b53590e28", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e6ba08816fbb6438d8ead8613cb7326a97543bcad34d4e669644360b53590e28", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e6ba08816fbb6438d8ead8613cb7326a97543bcad34d4e669644360b53590e28", kill_on_drop: false }` [INFO] [stdout] e6ba08816fbb6438d8ead8613cb7326a97543bcad34d4e669644360b53590e28 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 576314745d4eb8379b6705f624ba22cc405b5c6ded43266f47b209d250331863 [INFO] running `Command { std: "docker" "start" "-a" "576314745d4eb8379b6705f624ba22cc405b5c6ded43266f47b209d250331863", kill_on_drop: false }` [INFO] [stderr] Compiling zeroize v1.8.2 [INFO] [stderr] Compiling subtle v2.6.1 [INFO] [stderr] Compiling const-oid v0.9.6 [INFO] [stderr] Compiling smallvec v1.15.1 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling stable_deref_trait v1.2.1 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling getrandom v0.2.16 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Compiling bytes v1.11.0 [INFO] [stderr] Checking generic-array v0.14.9 [INFO] [stderr] Compiling zerofrom v0.1.6 [INFO] [stderr] Compiling data-encoding v2.9.0 [INFO] [stderr] Compiling slab v0.4.11 [INFO] [stderr] Compiling zerocopy v0.8.31 [INFO] [stderr] Compiling zerocopy-derive v0.8.31 [INFO] [stderr] Compiling mio v1.1.1 [INFO] [stderr] Compiling socket2 v0.6.1 [INFO] [stderr] Compiling yoke v0.8.1 [INFO] [stderr] Compiling rustls v0.23.35 [INFO] [stderr] Compiling darling_core v0.21.3 [INFO] [stderr] Compiling base64ct v1.8.1 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Compiling zerovec v0.11.5 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Compiling pem-rfc7468 v0.7.0 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling litemap v0.8.1 [INFO] [stderr] Compiling der v0.7.10 [INFO] [stderr] Compiling tinystr v0.8.2 [INFO] [stderr] Compiling writeable v0.6.2 [INFO] [stderr] Compiling cpufeatures v0.2.17 [INFO] [stderr] Compiling nom v7.1.3 [INFO] [stderr] Checking tokio v1.48.0 [INFO] [stderr] Checking http v1.4.0 [INFO] [stderr] Compiling icu_locale_core v2.1.1 [INFO] [stderr] Compiling data-encoding-macro-internal v0.1.16 [INFO] [stderr] Compiling sha2 v0.10.9 [INFO] [stderr] Compiling spki v0.7.3 [INFO] [stderr] Compiling potential_utf v0.1.4 [INFO] [stderr] Compiling zerotrie v0.2.3 [INFO] [stderr] Compiling cc-traits v2.0.0 [INFO] [stderr] Compiling percent-encoding v2.3.2 [INFO] [stderr] Compiling ciborium-io v0.2.2 [INFO] [stderr] Compiling icu_provider v2.1.1 [INFO] [stderr] Compiling btree-slab v0.6.1 [INFO] [stderr] Compiling pkcs8 v0.10.2 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling icu_collections v2.1.1 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Compiling http-body v1.0.1 [INFO] [stderr] Compiling ff v0.13.1 [INFO] [stderr] Compiling tracing-core v0.1.35 [INFO] [stderr] Compiling rustls-pki-types v1.13.1 [INFO] [stderr] Compiling futures-task v0.3.31 [INFO] [stderr] Compiling base16ct v0.2.0 [INFO] [stderr] Compiling range-traits v0.3.2 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling sec1 v0.7.3 [INFO] [stderr] Compiling proc-macro2-diagnostics v0.10.1 [INFO] [stderr] Compiling group v0.13.0 [INFO] [stderr] Compiling tracing v0.1.43 [INFO] [stderr] Compiling thiserror v1.0.69 [INFO] [stderr] Compiling crypto-bigint v0.5.5 [INFO] [stderr] Compiling icu_normalizer_data v2.1.1 [INFO] [stderr] Compiling icu_properties_data v2.1.1 [INFO] [stderr] Compiling hex_fmt v0.3.0 [INFO] [stderr] Compiling simd-adler32 v0.3.8 [INFO] [stderr] Compiling const-str v0.4.3 [INFO] [stderr] Compiling ouroboros_macro v0.18.5 [INFO] [stderr] Compiling icu_properties v2.1.1 [INFO] [stderr] Compiling abnf-core v0.5.0 [INFO] [stderr] Compiling btree-range-map v0.7.2 [INFO] [stderr] Compiling miniz_oxide v0.8.9 [INFO] [stderr] Compiling icu_normalizer v2.1.1 [INFO] [stderr] Compiling darling_macro v0.21.3 [INFO] [stderr] Compiling abnf v0.13.0 [INFO] [stderr] Compiling lock_api v0.4.14 [INFO] [stderr] Compiling darling v0.21.3 [INFO] [stderr] Compiling bon-macros v3.8.1 [INFO] [stderr] Compiling form_urlencoded v1.2.2 [INFO] [stderr] Compiling data-encoding-macro v0.1.18 [INFO] [stderr] Compiling half v2.7.1 [INFO] [stderr] Compiling hmac v0.12.1 [INFO] [stderr] Compiling httparse v1.10.1 [INFO] [stderr] Compiling miette-derive v7.6.0 [INFO] [stderr] Compiling core2 v0.4.0 [INFO] [stderr] Compiling ciborium-ll v0.2.2 [INFO] [stderr] Compiling base-x v0.2.11 [INFO] [stderr] Compiling unsigned-varint v0.8.0 [INFO] [stderr] Compiling rfc6979 v0.4.0 [INFO] [stderr] Compiling ciborium v0.2.2 [INFO] [stderr] Compiling match-lookup v0.1.1 [INFO] [stderr] Compiling multihash v0.19.3 [INFO] [stderr] Compiling tokio-util v0.7.17 [INFO] [stderr] Compiling idna_adapter v1.2.1 [INFO] [stderr] Compiling base256emoji v1.0.2 [INFO] [stderr] Compiling elliptic-curve v0.13.8 [INFO] [stderr] Checking rustls-webpki v0.103.8 [INFO] [stderr] Compiling multibase v0.9.2 [INFO] [stderr] Compiling h2 v0.4.12 [INFO] [stderr] Compiling flate2 v1.1.5 [INFO] [stderr] Compiling serde_bytes v0.11.19 [INFO] [stderr] Compiling signature v2.2.0 [INFO] [stderr] Compiling getrandom v0.3.4 [INFO] [stderr] Compiling static-regular-grammar v2.0.2 [INFO] [stderr] Compiling compression-core v0.4.31 [INFO] [stderr] Compiling ipnet v2.11.0 [INFO] [stderr] Compiling compression-codecs v0.4.34 [INFO] [stderr] Compiling rand_core v0.9.3 [INFO] [stderr] Compiling cid v0.11.1 [INFO] [stderr] Compiling tower v0.5.2 [INFO] [stderr] Compiling idna v1.1.0 [INFO] [stderr] Compiling hash32 v0.2.1 [INFO] [stderr] Compiling ecdsa v0.16.9 [INFO] [stderr] Compiling spin v0.9.8 [INFO] [stderr] Compiling ppv-lite86 v0.2.21 [INFO] [stderr] Compiling serde_with_macros v3.16.1 [INFO] [stderr] Compiling webpki-roots v1.0.4 [INFO] [stderr] Compiling trait-variant v0.1.2 [INFO] [stderr] Compiling aho-corasick v1.1.4 [INFO] [stderr] Compiling regex-syntax v0.8.8 [INFO] [stderr] Compiling bitflags v2.10.0 [INFO] [stderr] Compiling iri-string v0.7.9 [INFO] [stderr] Compiling url v2.5.7 [INFO] [stderr] Compiling rand_chacha v0.9.0 [INFO] [stderr] Compiling cobs v0.3.0 [INFO] [stderr] Compiling heapless v0.7.17 [INFO] [stderr] Compiling ipld-core v0.4.2 [INFO] [stderr] Compiling async-compression v0.4.35 [INFO] [stderr] Compiling primeorder v0.13.6 [INFO] [stderr] Compiling serde_urlencoded v0.7.1 [INFO] [stderr] Compiling serde_json v1.0.145 [INFO] [stderr] Compiling cbor4ii v0.2.14 [INFO] [stderr] Compiling http-body-util v0.1.3 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling encoding_rs v0.8.35 [INFO] [stderr] Compiling iana-time-zone v0.1.64 [INFO] [stderr] Compiling regex-automata v0.4.13 [INFO] [stderr] Compiling aliasable v0.1.3 [INFO] [stderr] Checking tower-http v0.6.8 [INFO] [stderr] Compiling miette v7.6.0 [INFO] [stderr] Compiling ouroboros v0.18.5 [INFO] [stderr] Compiling serde_ipld_dagcbor v0.6.4 [INFO] [stderr] Compiling chrono v0.4.42 [INFO] [stderr] Compiling postcard v1.1.3 [INFO] [stderr] Compiling p256 v0.13.2 [INFO] [stderr] Compiling hyper v1.8.1 [INFO] [stderr] Compiling rand v0.9.2 [INFO] [stderr] Checking tokio-rustls v0.26.4 [INFO] [stderr] Compiling k256 v0.13.4 [INFO] [stderr] Compiling serde_html_form v0.2.8 [INFO] [stderr] Compiling parking_lot_core v0.9.12 [INFO] [stderr] Compiling smol_str v0.3.4 [INFO] [stderr] Compiling serde_repr v0.1.20 [INFO] [stderr] Compiling hashbrown v0.14.5 [INFO] [stderr] Compiling bon v3.8.1 [INFO] [stderr] Compiling serde_with v3.16.1 [INFO] [stderr] Compiling inventory v0.3.21 [INFO] [stderr] Checking regex v1.12.2 [INFO] [stderr] Checking dashmap v6.1.0 [INFO] [stderr] Compiling n0-future v0.1.3 [INFO] [stderr] Compiling hyper-util v0.1.19 [INFO] [stderr] Compiling derive_more-impl v1.0.0 [INFO] [stderr] Checking spin v0.10.0 [INFO] [stderr] Checking cordyceps v0.3.4 [INFO] [stderr] Checking diatomic-waker v0.2.3 [INFO] [stderr] Checking fastrand v2.3.0 [INFO] [stderr] Compiling langtag v0.4.0 [INFO] [stderr] Checking futures-buffered v0.2.12 [INFO] [stderr] Checking futures-lite v2.6.1 [INFO] [stderr] Checking hyper-rustls v0.27.7 [INFO] [stderr] Checking reqwest v0.12.24 [INFO] [stderr] Checking derive_more v1.0.0 [INFO] [stderr] Checking jacquard-common v0.9.5 [INFO] [stderr] Checking jacquard-lexicon v0.9.5 [INFO] [stderr] Compiling jacquard-derive v0.9.5 [INFO] [stderr] Checking jacquard-api v0.9.2 [INFO] [stderr] Checking jacquard-identity v0.9.5 (/opt/rustwide/workdir) [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lexicon_resolver.rs:273:45 [INFO] [stdout] | [INFO] [stdout] 273 | let qs = serde_html_form::to_string(&ResolveLexicon::new().nsid(nsid.clone()).build()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `ResolveLexicon::new().nsid(nsid.clone()).build()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/lexicon_resolver.rs:503:29 [INFO] [stdout] | [INFO] [stdout] 503 | .ok_or_else(|| IdentityError::missing_pds_endpoint())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `IdentityError::missing_pds_endpoint` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/resolver.rs:86:35 [INFO] [stdout] | [INFO] [stdout] 86 | pub fn parse<'b>(&'b self) -> Result> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 232 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `resolver::IdentityError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] = note: `#[warn(clippy::result_large_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/resolver.rs:117:45 [INFO] [stdout] | [INFO] [stdout] 117 | pub fn parse_validated<'b>(&'b self) -> Result> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 232 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `resolver::IdentityError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/resolver.rs:119:9 [INFO] [stdout] | [INFO] [stdout] 119 | / if let Some(expected) = &self.requested { [INFO] [stdout] 120 | | if doc.id.as_str() != expected.as_str() { [INFO] [stdout] 121 | | return Err(IdentityError::doc_id_mismatch( [INFO] [stdout] 122 | | expected.clone(), [INFO] [stdout] ... | [INFO] [stdout] 126 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 119 ~ if let Some(expected) = &self.requested [INFO] [stdout] 120 ~ && doc.id.as_str() != expected.as_str() { [INFO] [stdout] 121 | return Err(IdentityError::doc_id_mismatch( [INFO] [stdout] ... [INFO] [stdout] 124 | )); [INFO] [stdout] 125 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/resolver.rs:131:32 [INFO] [stdout] | [INFO] [stdout] 131 | pub fn into_owned(self) -> Result> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 232 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `resolver::IdentityError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lexicon_resolver.rs:273:45 [INFO] [stdout] | [INFO] [stdout] 273 | let qs = serde_html_form::to_string(&ResolveLexicon::new().nsid(nsid.clone()).build()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `ResolveLexicon::new().nsid(nsid.clone()).build()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/resolver.rs:233:9 [INFO] [stdout] | [INFO] [stdout] 233 | / let mut handle_order = vec![]; [INFO] [stdout] 234 | | #[cfg(not(target_family = "wasm"))] [INFO] [stdout] 235 | | handle_order.push(HandleStep::DnsTxt); [INFO] [stdout] 236 | | #[cfg(not(target_family = "wasm"))] [INFO] [stdout] 237 | | handle_order.push(HandleStep::HttpsWellKnown); [INFO] [stdout] 238 | | handle_order.push(HandleStep::PdsResolveHandle); [INFO] [stdout] | |________________________________________________________^ help: consider using the `vec![]` macro: `let handle_order = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] = note: `#[warn(clippy::vec_init_then_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/resolver.rs:244:9 [INFO] [stdout] | [INFO] [stdout] 244 | / let mut did_order = vec![]; [INFO] [stdout] 245 | | #[cfg(not(target_family = "wasm"))] [INFO] [stdout] 246 | | did_order.push(DidStep::DidWebHttps); [INFO] [stdout] 247 | | did_order.push(DidStep::PlcHttp); [INFO] [stdout] 248 | | did_order.push(DidStep::PdsResolveDid); [INFO] [stdout] | |_______________________________________________^ help: consider using the `vec![]` macro: `let did_order = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/resolver.rs:308:64 [INFO] [stdout] | [INFO] [stdout] 308 | AtIdentifier::Did(did) => self.resolve_did_doc(&did).await, [INFO] [stdout] | ^^^^ help: change this to: `did` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/resolver.rs:310:51 [INFO] [stdout] | [INFO] [stdout] 310 | let did = self.resolve_handle(&handle).await?; [INFO] [stdout] | ^^^^^^^ help: change this to: `handle` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/resolver.rs:345:70 [INFO] [stdout] | [INFO] [stdout] 345 | AtIdentifier::Did(did) => self.resolve_did_doc_owned(&did).await, [INFO] [stdout] | ^^^^ help: change this to: `did` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/resolver.rs:347:51 [INFO] [stdout] | [INFO] [stdout] 347 | let did = self.resolve_handle(&handle).await?; [INFO] [stdout] | ^^^^^^^ help: change this to: `handle` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/resolver.rs:402:13 [INFO] [stdout] | [INFO] [stdout] 402 | / if self.options().validate_doc_id { [INFO] [stdout] 403 | | if doc.id.as_str() != did.as_str() { [INFO] [stdout] 404 | | return Err(IdentityError::doc_id_mismatch( [INFO] [stdout] 405 | | did.clone().into_static(), [INFO] [stdout] ... | [INFO] [stdout] 409 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 402 ~ if self.options().validate_doc_id [INFO] [stdout] 403 ~ && doc.id.as_str() != did.as_str() { [INFO] [stdout] 404 | return Err(IdentityError::doc_id_mismatch( [INFO] [stdout] ... [INFO] [stdout] 407 | )); [INFO] [stdout] 408 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/resolver.rs:411:29 [INFO] [stdout] | [INFO] [stdout] 411 | .ok_or_else(|| IdentityError::missing_pds_endpoint()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `IdentityError::missing_pds_endpoint` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/lexicon_resolver.rs:503:29 [INFO] [stdout] | [INFO] [stdout] 503 | .ok_or_else(|| IdentityError::missing_pds_endpoint())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `IdentityError::missing_pds_endpoint` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/resolver.rs:86:35 [INFO] [stdout] | [INFO] [stdout] 86 | pub fn parse<'b>(&'b self) -> Result> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 232 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `resolver::IdentityError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] = note: `#[warn(clippy::result_large_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/resolver.rs:117:45 [INFO] [stdout] | [INFO] [stdout] 117 | pub fn parse_validated<'b>(&'b self) -> Result> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 232 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `resolver::IdentityError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/resolver.rs:119:9 [INFO] [stdout] | [INFO] [stdout] 119 | / if let Some(expected) = &self.requested { [INFO] [stdout] 120 | | if doc.id.as_str() != expected.as_str() { [INFO] [stdout] 121 | | return Err(IdentityError::doc_id_mismatch( [INFO] [stdout] 122 | | expected.clone(), [INFO] [stdout] ... | [INFO] [stdout] 126 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 119 ~ if let Some(expected) = &self.requested [INFO] [stdout] 120 ~ && doc.id.as_str() != expected.as_str() { [INFO] [stdout] 121 | return Err(IdentityError::doc_id_mismatch( [INFO] [stdout] ... [INFO] [stdout] 124 | )); [INFO] [stdout] 125 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/resolver.rs:131:32 [INFO] [stdout] | [INFO] [stdout] 131 | pub fn into_owned(self) -> Result> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 232 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `resolver::IdentityError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/lib.rs:418:45 [INFO] [stdout] | [INFO] [stdout] 418 | fn did_web_url(&self, did: &Did<'_>) -> resolver::Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 232 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `resolver::IdentityError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/lib.rs:528:22 [INFO] [stdout] | [INFO] [stdout] 528 | .map_err(|e| IdentityError::dns(e))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `IdentityError::dns` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/lib.rs:550:46 [INFO] [stdout] | [INFO] [stdout] 550 | fn parse_atproto_did_body(body: &str) -> resolver::Result> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 232 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `resolver::IdentityError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/lib.rs:554:25 [INFO] [stdout] | [INFO] [stdout] 554 | .ok_or_else(|| IdentityError::invalid_well_known())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `IdentityError::invalid_well_known` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/resolver.rs:233:9 [INFO] [stdout] | [INFO] [stdout] 233 | / let mut handle_order = vec![]; [INFO] [stdout] 234 | | #[cfg(not(target_family = "wasm"))] [INFO] [stdout] 235 | | handle_order.push(HandleStep::DnsTxt); [INFO] [stdout] 236 | | #[cfg(not(target_family = "wasm"))] [INFO] [stdout] 237 | | handle_order.push(HandleStep::HttpsWellKnown); [INFO] [stdout] 238 | | handle_order.push(HandleStep::PdsResolveHandle); [INFO] [stdout] | |________________________________________________________^ help: consider using the `vec![]` macro: `let handle_order = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] = note: `#[warn(clippy::vec_init_then_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/resolver.rs:244:9 [INFO] [stdout] | [INFO] [stdout] 244 | / let mut did_order = vec![]; [INFO] [stdout] 245 | | #[cfg(not(target_family = "wasm"))] [INFO] [stdout] 246 | | did_order.push(DidStep::DidWebHttps); [INFO] [stdout] 247 | | did_order.push(DidStep::PlcHttp); [INFO] [stdout] 248 | | did_order.push(DidStep::PdsResolveDid); [INFO] [stdout] | |_______________________________________________^ help: consider using the `vec![]` macro: `let did_order = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/resolver.rs:308:64 [INFO] [stdout] | [INFO] [stdout] 308 | AtIdentifier::Did(did) => self.resolve_did_doc(&did).await, [INFO] [stdout] | ^^^^ help: change this to: `did` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/resolver.rs:310:51 [INFO] [stdout] | [INFO] [stdout] 310 | let did = self.resolve_handle(&handle).await?; [INFO] [stdout] | ^^^^^^^ help: change this to: `handle` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:629:13 [INFO] [stdout] | [INFO] [stdout] 629 | / &resolve_did::ResolveDid::new() [INFO] [stdout] 630 | | .did(did.clone().into_static()) [INFO] [stdout] 631 | | .build(), [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 629 ~ resolve_did::ResolveDid::new() [INFO] [stdout] 630 + .did(did.clone().into_static()) [INFO] [stdout] 631 ~ .build(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/resolver.rs:345:70 [INFO] [stdout] | [INFO] [stdout] 345 | AtIdentifier::Did(did) => self.resolve_did_doc_owned(&did).await, [INFO] [stdout] | ^^^^ help: change this to: `did` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/resolver.rs:347:51 [INFO] [stdout] | [INFO] [stdout] 347 | let did = self.resolve_handle(&handle).await?; [INFO] [stdout] | ^^^^^^^ help: change this to: `handle` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lib.rs:667:29 [INFO] [stdout] | [INFO] [stdout] 667 | / ... if let Some(did_str) = txt.strip_prefix("did=") { [INFO] [stdout] 668 | | ... if let Ok(did) = Did::new(did_str) { [INFO] [stdout] 669 | | ... resolved_did = Some(did.into_static()); [INFO] [stdout] 670 | | ... break 'outer; [INFO] [stdout] 671 | | ... } [INFO] [stdout] 672 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 667 ~ if let Some(did_str) = txt.strip_prefix("did=") [INFO] [stdout] 668 ~ && let Ok(did) = Did::new(did_str) { [INFO] [stdout] 669 | resolved_did = Some(did.into_static()); [INFO] [stdout] 670 | break 'outer; [INFO] [stdout] 671 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lib.rs:678:21 [INFO] [stdout] | [INFO] [stdout] 678 | / if let Ok(text) = self.get_text(url).await { [INFO] [stdout] 679 | | if let Ok(did) = Self::parse_atproto_did_body(&text) { [INFO] [stdout] 680 | | resolved_did = Some(did); [INFO] [stdout] 681 | | break 'outer; [INFO] [stdout] 682 | | } [INFO] [stdout] 683 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 678 ~ if let Ok(text) = self.get_text(url).await [INFO] [stdout] 679 ~ && let Ok(did) = Self::parse_atproto_did_body(&text) { [INFO] [stdout] 680 | resolved_did = Some(did); [INFO] [stdout] 681 | break 'outer; [INFO] [stdout] 682 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/resolver.rs:402:13 [INFO] [stdout] | [INFO] [stdout] 402 | / if self.options().validate_doc_id { [INFO] [stdout] 403 | | if doc.id.as_str() != did.as_str() { [INFO] [stdout] 404 | | return Err(IdentityError::doc_id_mismatch( [INFO] [stdout] 405 | | did.clone().into_static(), [INFO] [stdout] ... | [INFO] [stdout] 409 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 402 ~ if self.options().validate_doc_id [INFO] [stdout] 403 ~ && doc.id.as_str() != did.as_str() { [INFO] [stdout] 404 | return Err(IdentityError::doc_id_mismatch( [INFO] [stdout] ... [INFO] [stdout] 407 | )); [INFO] [stdout] 408 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/resolver.rs:411:29 [INFO] [stdout] | [INFO] [stdout] 411 | .ok_or_else(|| IdentityError::missing_pds_endpoint()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `IdentityError::missing_pds_endpoint` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lib.rs:692:21 [INFO] [stdout] | [INFO] [stdout] 692 | / if self.opts.public_fallback_for_handle { [INFO] [stdout] 693 | | if let Ok(mut url) = Url::parse("https://public.api.bsky.app") { [INFO] [stdout] 694 | | url.set_path("/xrpc/com.atproto.identity.resolveHandle"); [INFO] [stdout] 695 | | if let Ok(qs) = serde_html_form::to_string( [INFO] [stdout] ... | [INFO] [stdout] 719 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 692 ~ if self.opts.public_fallback_for_handle [INFO] [stdout] 693 ~ && let Ok(mut url) = Url::parse("https://public.api.bsky.app") { [INFO] [stdout] 694 | url.set_path("/xrpc/com.atproto.identity.resolveHandle"); [INFO] [stdout] ... [INFO] [stdout] 717 | } [INFO] [stdout] 718 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:696:33 [INFO] [stdout] | [INFO] [stdout] 696 | ... &ResolveHandle::new().handle((*handle).clone()).build(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `ResolveHandle::new().handle((*handle).clone()).build()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lib.rs:702:29 [INFO] [stdout] | [INFO] [stdout] 702 | / ... if let Ok((buf, status)) = self.get_json_bytes(url).await { [INFO] [stdout] 703 | | ... if status.is_success() { [INFO] [stdout] 704 | | ... if let Ok(val) = [INFO] [stdout] 705 | | ... serde_json::from_slice::(&buf) [INFO] [stdout] ... | [INFO] [stdout] 717 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 702 ~ if let Ok((buf, status)) = self.get_json_bytes(url).await [INFO] [stdout] 703 ~ && status.is_success() { [INFO] [stdout] 704 | if let Ok(val) = [INFO] [stdout] ... [INFO] [stdout] 715 | } [INFO] [stdout] 716 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lib.rs:703:33 [INFO] [stdout] | [INFO] [stdout] 703 | / ... if status.is_success() { [INFO] [stdout] 704 | | ... if let Ok(val) = [INFO] [stdout] 705 | | ... serde_json::from_slice::(&buf) [INFO] [stdout] ... | [INFO] [stdout] 716 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 703 ~ if status.is_success() [INFO] [stdout] 704 ~ && let Ok(val) = [INFO] [stdout] 705 | serde_json::from_slice::(&buf) [INFO] [stdout] ... [INFO] [stdout] 714 | } [INFO] [stdout] 715 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lib.rs:704:37 [INFO] [stdout] | [INFO] [stdout] 704 | / ... if let Ok(val) = [INFO] [stdout] 705 | | ... serde_json::from_slice::(&buf) [INFO] [stdout] 706 | | ... { [INFO] [stdout] 707 | | ... if let Some(did_str) = [INFO] [stdout] ... | [INFO] [stdout] 715 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 705 ~ serde_json::from_slice::(&buf) [INFO] [stdout] 706 ~ && let Some(did_str) = [INFO] [stdout] 707 | val.get("did").and_then(|v| v.as_str()) [INFO] [stdout] ... [INFO] [stdout] 712 | } [INFO] [stdout] 713 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lib.rs:707:41 [INFO] [stdout] | [INFO] [stdout] 707 | / ... if let Some(did_str) = [INFO] [stdout] 708 | | ... val.get("did").and_then(|v| v.as_str()) [INFO] [stdout] 709 | | ... { [INFO] [stdout] 710 | | ... if let Ok(did) = Did::new_owned(did_str) { [INFO] [stdout] ... | [INFO] [stdout] 714 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 708 ~ val.get("did").and_then(|v| v.as_str()) [INFO] [stdout] 709 ~ && let Ok(did) = Did::new_owned(did_str) { [INFO] [stdout] 710 | resolved_did = Some(did.into_static()); [INFO] [stdout] 711 | break 'outer; [INFO] [stdout] 712 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:725:29 [INFO] [stdout] | [INFO] [stdout] 725 | ... &ResolveHandle::new().handle((*handle).clone()).build(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `ResolveHandle::new().handle((*handle).clone()).build()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lib.rs:731:25 [INFO] [stdout] | [INFO] [stdout] 731 | / if let Ok((buf, status)) = self.get_json_bytes(url).await { [INFO] [stdout] 732 | | if status.is_success() { [INFO] [stdout] 733 | | if let Ok(val) = serde_json::from_slice::(&buf) { [INFO] [stdout] 734 | | if let Some(did_str) = val.get("did").and_then(|v| v.as_str()) { [INFO] [stdout] ... | [INFO] [stdout] 742 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 731 ~ if let Ok((buf, status)) = self.get_json_bytes(url).await [INFO] [stdout] 732 ~ && status.is_success() { [INFO] [stdout] 733 | if let Ok(val) = serde_json::from_slice::(&buf) { [INFO] [stdout] ... [INFO] [stdout] 740 | } [INFO] [stdout] 741 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lib.rs:732:29 [INFO] [stdout] | [INFO] [stdout] 732 | / ... if status.is_success() { [INFO] [stdout] 733 | | ... if let Ok(val) = serde_json::from_slice::(&buf) { [INFO] [stdout] 734 | | ... if let Some(did_str) = val.get("did").and_then(|v| v.as_str()) { [INFO] [stdout] 735 | | ... if let Ok(did) = Did::new_owned(did_str) { [INFO] [stdout] ... | [INFO] [stdout] 741 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 732 ~ if status.is_success() [INFO] [stdout] 733 ~ && let Ok(val) = serde_json::from_slice::(&buf) { [INFO] [stdout] 734 | if let Some(did_str) = val.get("did").and_then(|v| v.as_str()) { [INFO] [stdout] ... [INFO] [stdout] 739 | } [INFO] [stdout] 740 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lib.rs:733:33 [INFO] [stdout] | [INFO] [stdout] 733 | / ... if let Ok(val) = serde_json::from_slice::(&buf) { [INFO] [stdout] 734 | | ... if let Some(did_str) = val.get("did").and_then(|v| v.as_str()) { [INFO] [stdout] 735 | | ... if let Ok(did) = Did::new_owned(did_str) { [INFO] [stdout] 736 | | ... resolved_did = Some(did.into_static()); [INFO] [stdout] ... | [INFO] [stdout] 740 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 733 ~ if let Ok(val) = serde_json::from_slice::(&buf) [INFO] [stdout] 734 ~ && let Some(did_str) = val.get("did").and_then(|v| v.as_str()) { [INFO] [stdout] 735 | if let Ok(did) = Did::new_owned(did_str) { [INFO] [stdout] ... [INFO] [stdout] 738 | } [INFO] [stdout] 739 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lib.rs:734:37 [INFO] [stdout] | [INFO] [stdout] 734 | / ... if let Some(did_str) = val.get("did").and_then(|v| v.as_str()) { [INFO] [stdout] 735 | | ... if let Ok(did) = Did::new_owned(did_str) { [INFO] [stdout] 736 | | ... resolved_did = Some(did.into_static()); [INFO] [stdout] 737 | | ... break 'outer; [INFO] [stdout] 738 | | ... } [INFO] [stdout] 739 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 734 ~ if let Some(did_str) = val.get("did").and_then(|v| v.as_str()) [INFO] [stdout] 735 ~ && let Ok(did) = Did::new_owned(did_str) { [INFO] [stdout] 736 | resolved_did = Some(did.into_static()); [INFO] [stdout] 737 | break 'outer; [INFO] [stdout] 738 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/lib.rs:1008:71 [INFO] [stdout] | [INFO] [stdout] 1008 | fn slingshot_mini_doc_url(&self, base: &Url, identifier: &str) -> resolver::Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 232 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `resolver::IdentityError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/lib.rs:1102:35 [INFO] [stdout] | [INFO] [stdout] 1102 | pub fn parse<'b>(&'b self) -> resolver::Result> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 232 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `resolver::IdentityError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/lib.rs:1142:5 [INFO] [stdout] | [INFO] [stdout] 1142 | opts.plc_source = PlcSource::slingshot_default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `resolver::ResolverOptions { plc_source: PlcSource::slingshot_default(), ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/lib.rs:1141:5 [INFO] [stdout] | [INFO] [stdout] 1141 | let mut opts = ResolverOptions::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] = note: `#[warn(clippy::field_reassign_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/lib.rs:418:45 [INFO] [stdout] | [INFO] [stdout] 418 | fn did_web_url(&self, did: &Did<'_>) -> resolver::Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 232 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `resolver::IdentityError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/lib.rs:528:22 [INFO] [stdout] | [INFO] [stdout] 528 | .map_err(|e| IdentityError::dns(e))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `IdentityError::dns` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/lib.rs:550:46 [INFO] [stdout] | [INFO] [stdout] 550 | fn parse_atproto_did_body(body: &str) -> resolver::Result> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 232 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `resolver::IdentityError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/lib.rs:554:25 [INFO] [stdout] | [INFO] [stdout] 554 | .ok_or_else(|| IdentityError::invalid_well_known())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `IdentityError::invalid_well_known` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:629:13 [INFO] [stdout] | [INFO] [stdout] 629 | / &resolve_did::ResolveDid::new() [INFO] [stdout] 630 | | .did(did.clone().into_static()) [INFO] [stdout] 631 | | .build(), [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 629 ~ resolve_did::ResolveDid::new() [INFO] [stdout] 630 + .did(did.clone().into_static()) [INFO] [stdout] 631 ~ .build(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lib.rs:667:29 [INFO] [stdout] | [INFO] [stdout] 667 | / ... if let Some(did_str) = txt.strip_prefix("did=") { [INFO] [stdout] 668 | | ... if let Ok(did) = Did::new(did_str) { [INFO] [stdout] 669 | | ... resolved_did = Some(did.into_static()); [INFO] [stdout] 670 | | ... break 'outer; [INFO] [stdout] 671 | | ... } [INFO] [stdout] 672 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 667 ~ if let Some(did_str) = txt.strip_prefix("did=") [INFO] [stdout] 668 ~ && let Ok(did) = Did::new(did_str) { [INFO] [stdout] 669 | resolved_did = Some(did.into_static()); [INFO] [stdout] 670 | break 'outer; [INFO] [stdout] 671 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lib.rs:678:21 [INFO] [stdout] | [INFO] [stdout] 678 | / if let Ok(text) = self.get_text(url).await { [INFO] [stdout] 679 | | if let Ok(did) = Self::parse_atproto_did_body(&text) { [INFO] [stdout] 680 | | resolved_did = Some(did); [INFO] [stdout] 681 | | break 'outer; [INFO] [stdout] 682 | | } [INFO] [stdout] 683 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 678 ~ if let Ok(text) = self.get_text(url).await [INFO] [stdout] 679 ~ && let Ok(did) = Self::parse_atproto_did_body(&text) { [INFO] [stdout] 680 | resolved_did = Some(did); [INFO] [stdout] 681 | break 'outer; [INFO] [stdout] 682 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lib.rs:692:21 [INFO] [stdout] | [INFO] [stdout] 692 | / if self.opts.public_fallback_for_handle { [INFO] [stdout] 693 | | if let Ok(mut url) = Url::parse("https://public.api.bsky.app") { [INFO] [stdout] 694 | | url.set_path("/xrpc/com.atproto.identity.resolveHandle"); [INFO] [stdout] 695 | | if let Ok(qs) = serde_html_form::to_string( [INFO] [stdout] ... | [INFO] [stdout] 719 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 692 ~ if self.opts.public_fallback_for_handle [INFO] [stdout] 693 ~ && let Ok(mut url) = Url::parse("https://public.api.bsky.app") { [INFO] [stdout] 694 | url.set_path("/xrpc/com.atproto.identity.resolveHandle"); [INFO] [stdout] ... [INFO] [stdout] 717 | } [INFO] [stdout] 718 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:696:33 [INFO] [stdout] | [INFO] [stdout] 696 | ... &ResolveHandle::new().handle((*handle).clone()).build(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `ResolveHandle::new().handle((*handle).clone()).build()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lib.rs:702:29 [INFO] [stdout] | [INFO] [stdout] 702 | / ... if let Ok((buf, status)) = self.get_json_bytes(url).await { [INFO] [stdout] 703 | | ... if status.is_success() { [INFO] [stdout] 704 | | ... if let Ok(val) = [INFO] [stdout] 705 | | ... serde_json::from_slice::(&buf) [INFO] [stdout] ... | [INFO] [stdout] 717 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 702 ~ if let Ok((buf, status)) = self.get_json_bytes(url).await [INFO] [stdout] 703 ~ && status.is_success() { [INFO] [stdout] 704 | if let Ok(val) = [INFO] [stdout] ... [INFO] [stdout] 715 | } [INFO] [stdout] 716 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lib.rs:703:33 [INFO] [stdout] | [INFO] [stdout] 703 | / ... if status.is_success() { [INFO] [stdout] 704 | | ... if let Ok(val) = [INFO] [stdout] 705 | | ... serde_json::from_slice::(&buf) [INFO] [stdout] ... | [INFO] [stdout] 716 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 703 ~ if status.is_success() [INFO] [stdout] 704 ~ && let Ok(val) = [INFO] [stdout] 705 | serde_json::from_slice::(&buf) [INFO] [stdout] ... [INFO] [stdout] 714 | } [INFO] [stdout] 715 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lib.rs:704:37 [INFO] [stdout] | [INFO] [stdout] 704 | / ... if let Ok(val) = [INFO] [stdout] 705 | | ... serde_json::from_slice::(&buf) [INFO] [stdout] 706 | | ... { [INFO] [stdout] 707 | | ... if let Some(did_str) = [INFO] [stdout] ... | [INFO] [stdout] 715 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 705 ~ serde_json::from_slice::(&buf) [INFO] [stdout] 706 ~ && let Some(did_str) = [INFO] [stdout] 707 | val.get("did").and_then(|v| v.as_str()) [INFO] [stdout] ... [INFO] [stdout] 712 | } [INFO] [stdout] 713 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lib.rs:707:41 [INFO] [stdout] | [INFO] [stdout] 707 | / ... if let Some(did_str) = [INFO] [stdout] 708 | | ... val.get("did").and_then(|v| v.as_str()) [INFO] [stdout] 709 | | ... { [INFO] [stdout] 710 | | ... if let Ok(did) = Did::new_owned(did_str) { [INFO] [stdout] ... | [INFO] [stdout] 714 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 708 ~ val.get("did").and_then(|v| v.as_str()) [INFO] [stdout] 709 ~ && let Ok(did) = Did::new_owned(did_str) { [INFO] [stdout] 710 | resolved_did = Some(did.into_static()); [INFO] [stdout] 711 | break 'outer; [INFO] [stdout] 712 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:725:29 [INFO] [stdout] | [INFO] [stdout] 725 | ... &ResolveHandle::new().handle((*handle).clone()).build(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `ResolveHandle::new().handle((*handle).clone()).build()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lib.rs:731:25 [INFO] [stdout] | [INFO] [stdout] 731 | / if let Ok((buf, status)) = self.get_json_bytes(url).await { [INFO] [stdout] 732 | | if status.is_success() { [INFO] [stdout] 733 | | if let Ok(val) = serde_json::from_slice::(&buf) { [INFO] [stdout] 734 | | if let Some(did_str) = val.get("did").and_then(|v| v.as_str()) { [INFO] [stdout] ... | [INFO] [stdout] 742 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 731 ~ if let Ok((buf, status)) = self.get_json_bytes(url).await [INFO] [stdout] 732 ~ && status.is_success() { [INFO] [stdout] 733 | if let Ok(val) = serde_json::from_slice::(&buf) { [INFO] [stdout] ... [INFO] [stdout] 740 | } [INFO] [stdout] 741 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lib.rs:732:29 [INFO] [stdout] | [INFO] [stdout] 732 | / ... if status.is_success() { [INFO] [stdout] 733 | | ... if let Ok(val) = serde_json::from_slice::(&buf) { [INFO] [stdout] 734 | | ... if let Some(did_str) = val.get("did").and_then(|v| v.as_str()) { [INFO] [stdout] 735 | | ... if let Ok(did) = Did::new_owned(did_str) { [INFO] [stdout] ... | [INFO] [stdout] 741 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 732 ~ if status.is_success() [INFO] [stdout] 733 ~ && let Ok(val) = serde_json::from_slice::(&buf) { [INFO] [stdout] 734 | if let Some(did_str) = val.get("did").and_then(|v| v.as_str()) { [INFO] [stdout] ... [INFO] [stdout] 739 | } [INFO] [stdout] 740 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lib.rs:733:33 [INFO] [stdout] | [INFO] [stdout] 733 | / ... if let Ok(val) = serde_json::from_slice::(&buf) { [INFO] [stdout] 734 | | ... if let Some(did_str) = val.get("did").and_then(|v| v.as_str()) { [INFO] [stdout] 735 | | ... if let Ok(did) = Did::new_owned(did_str) { [INFO] [stdout] 736 | | ... resolved_did = Some(did.into_static()); [INFO] [stdout] ... | [INFO] [stdout] 740 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 733 ~ if let Ok(val) = serde_json::from_slice::(&buf) [INFO] [stdout] 734 ~ && let Some(did_str) = val.get("did").and_then(|v| v.as_str()) { [INFO] [stdout] 735 | if let Ok(did) = Did::new_owned(did_str) { [INFO] [stdout] ... [INFO] [stdout] 738 | } [INFO] [stdout] 739 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lib.rs:734:37 [INFO] [stdout] | [INFO] [stdout] 734 | / ... if let Some(did_str) = val.get("did").and_then(|v| v.as_str()) { [INFO] [stdout] 735 | | ... if let Ok(did) = Did::new_owned(did_str) { [INFO] [stdout] 736 | | ... resolved_did = Some(did.into_static()); [INFO] [stdout] 737 | | ... break 'outer; [INFO] [stdout] 738 | | ... } [INFO] [stdout] 739 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 734 ~ if let Some(did_str) = val.get("did").and_then(|v| v.as_str()) [INFO] [stdout] 735 ~ && let Ok(did) = Did::new_owned(did_str) { [INFO] [stdout] 736 | resolved_did = Some(did.into_static()); [INFO] [stdout] 737 | break 'outer; [INFO] [stdout] 738 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/lib.rs:1008:71 [INFO] [stdout] | [INFO] [stdout] 1008 | fn slingshot_mini_doc_url(&self, base: &Url, identifier: &str) -> resolver::Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 232 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `resolver::IdentityError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/lib.rs:1102:35 [INFO] [stdout] | [INFO] [stdout] 1102 | pub fn parse<'b>(&'b self) -> resolver::Result> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 232 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `resolver::IdentityError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/lib.rs:1142:5 [INFO] [stdout] | [INFO] [stdout] 1142 | opts.plc_source = PlcSource::slingshot_default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `resolver::ResolverOptions { plc_source: PlcSource::slingshot_default(), ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/lib.rs:1141:5 [INFO] [stdout] | [INFO] [stdout] 1141 | let mut opts = ResolverOptions::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] = note: `#[warn(clippy::field_reassign_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 40s [INFO] running `Command { std: "docker" "inspect" "576314745d4eb8379b6705f624ba22cc405b5c6ded43266f47b209d250331863", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "576314745d4eb8379b6705f624ba22cc405b5c6ded43266f47b209d250331863", kill_on_drop: false }` [INFO] [stdout] 576314745d4eb8379b6705f624ba22cc405b5c6ded43266f47b209d250331863