[INFO] fetching crate isutra 0.2.1... [INFO] linting isutra-0.2.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate isutra 0.2.1 into /workspace/builds/worker-0-tc1/source [INFO] started tweaking crates.io crate isutra 0.2.1 [INFO] finished tweaking crates.io crate isutra 0.2.1 [INFO] tweaked toml for crates.io crate isutra 0.2.1 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate isutra 0.2.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate isutra 0.2.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded strum v0.26.3 [INFO] [stderr] Downloaded unicode-truncate v1.1.0 [INFO] [stderr] Downloaded home v0.5.11 [INFO] [stderr] Downloaded lru v0.12.5 [INFO] [stderr] Downloaded strum_macros v0.26.4 [INFO] [stderr] Downloaded stability v0.2.1 [INFO] [stderr] Downloaded which v6.0.3 [INFO] [stderr] Downloaded wasm-bindgen-macro v0.2.111 [INFO] [stderr] Downloaded wasm-bindgen-shared v0.2.111 [INFO] [stderr] Downloaded dirs v5.0.1 [INFO] [stderr] Downloaded signal-hook-mio v0.2.5 [INFO] [stderr] Downloaded libredox v0.1.12 [INFO] [stderr] Downloaded castaway v0.2.4 [INFO] [stderr] Downloaded clap_derive v4.5.55 [INFO] [stderr] Downloaded clap v4.5.60 [INFO] [stderr] Downloaded js-sys v0.3.88 [INFO] [stderr] Downloaded wasm-bindgen-macro-support v0.2.111 [INFO] [stderr] Downloaded wasm-bindgen v0.2.111 [INFO] [stderr] Downloaded compact_str v0.7.1 [INFO] [stderr] Downloaded mio v0.8.11 [INFO] [stderr] Downloaded crossterm v0.27.0 [INFO] [stderr] Downloaded signal-hook v0.3.18 [INFO] [stderr] Downloaded crossterm_winapi v0.9.1 [INFO] [stderr] Downloaded clap_lex v1.0.0 [INFO] [stderr] Downloaded dirs-sys v0.4.1 [INFO] [stderr] Downloaded clap_builder v4.5.60 [INFO] [stderr] Downloaded winsafe v0.0.19 [INFO] [stderr] Downloaded ratatui v0.26.3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8eece8b81be5fb042205d5ff362c790f396b1860de6620260f0233234615eb61 [INFO] running `Command { std: "docker" "start" "-a" "8eece8b81be5fb042205d5ff362c790f396b1860de6620260f0233234615eb61", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8eece8b81be5fb042205d5ff362c790f396b1860de6620260f0233234615eb61", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8eece8b81be5fb042205d5ff362c790f396b1860de6620260f0233234615eb61", kill_on_drop: false }` [INFO] [stdout] 8eece8b81be5fb042205d5ff362c790f396b1860de6620260f0233234615eb61 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 50866b6901fed2900e7358548c4d67465236eb4238293a240f253f0112b94dd4 [INFO] running `Command { std: "docker" "start" "-a" "50866b6901fed2900e7358548c4d67465236eb4238293a240f253f0112b94dd4", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.182 [INFO] [stderr] Compiling unicode-ident v1.0.24 [INFO] [stderr] Compiling quote v1.0.44 [INFO] [stderr] Checking either v1.15.0 [INFO] [stderr] Compiling signal-hook v0.3.18 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Checking bitflags v2.11.0 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking log v0.4.29 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Compiling rustix v0.38.44 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking foldhash v0.1.5 [INFO] [stderr] Checking colorchoice v1.0.4 [INFO] [stderr] Checking anstyle v1.0.13 [INFO] [stderr] Checking anstyle-parse v0.2.7 [INFO] [stderr] Compiling zmij v1.0.21 [INFO] [stderr] Compiling proc-macro2 v1.0.106 [INFO] [stderr] Checking lock_api v0.4.14 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Checking is_terminal_polyfill v1.70.2 [INFO] [stderr] Checking anstyle-query v1.1.5 [INFO] [stderr] Checking castaway v0.2.4 [INFO] [stderr] Checking unicode-segmentation v1.12.0 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking linux-raw-sys v0.4.15 [INFO] [stderr] Compiling anyhow v1.0.102 [INFO] [stderr] Checking clap_lex v1.0.0 [INFO] [stderr] Checking anstream v0.6.21 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking ryu v1.0.23 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Checking unicode-width v0.1.14 [INFO] [stderr] Checking hashbrown v0.15.5 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking compact_str v0.7.1 [INFO] [stderr] Compiling serde_json v1.0.149 [INFO] [stderr] Checking cassowary v0.3.0 [INFO] [stderr] Checking memchr v2.8.0 [INFO] [stderr] Checking home v0.5.11 [INFO] [stderr] Checking clap_builder v4.5.60 [INFO] [stderr] Checking iana-time-zone v0.1.65 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Checking lru v0.12.5 [INFO] [stderr] Checking errno v0.3.14 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking signal-hook-registry v1.4.8 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking unicode-truncate v1.1.0 [INFO] [stderr] Checking signal-hook-mio v0.2.5 [INFO] [stderr] Checking crossterm v0.27.0 [INFO] [stderr] Checking which v6.0.3 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling clap_derive v4.5.55 [INFO] [stderr] Compiling stability v0.2.1 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking ratatui v0.26.3 [INFO] [stderr] Checking clap v4.5.60 [INFO] [stderr] Checking chrono v0.4.43 [INFO] [stderr] Checking isutra v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/filters.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / /// High-precision filtering to avoid suggesting shell builtins and meta-commands. [INFO] [stdout] 2 | | [INFO] [stdout] | |_^ [INFO] [stdout] 3 | pub fn is_banned_base(cmd0: &str) -> bool { [INFO] [stdout] | --------------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the comment should document the parent module use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 1 - /// High-precision filtering to avoid suggesting shell builtins and meta-commands. [INFO] [stdout] 1 + //! High-precision filtering to avoid suggesting shell builtins and meta-commands. [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/filters.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / /// High-precision filtering to avoid suggesting shell builtins and meta-commands. [INFO] [stdout] 2 | | [INFO] [stdout] | |_^ [INFO] [stdout] 3 | pub fn is_banned_base(cmd0: &str) -> bool { [INFO] [stdout] | --------------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the comment should document the parent module use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 1 - /// High-precision filtering to avoid suggesting shell builtins and meta-commands. [INFO] [stdout] 1 + //! High-precision filtering to avoid suggesting shell builtins and meta-commands. [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `flatten()` will run forever if the iterator repeatedly produces an `Err` [INFO] [stdout] --> src/history.rs:58:28 [INFO] [stdout] | [INFO] [stdout] 58 | for line in br.lines().flatten() { [INFO] [stdout] | ^^^^^^^^^ help: replace with: `map_while(Result::ok)` [INFO] [stdout] | [INFO] [stdout] note: this expression returning a `std::io::Lines` may produce an infinite number of `Err` in case of a read error [INFO] [stdout] --> src/history.rs:58:17 [INFO] [stdout] | [INFO] [stdout] 58 | for line in br.lines().flatten() { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lines_filter_map_ok [INFO] [stdout] = note: `#[warn(clippy::lines_filter_map_ok)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/smriti.rs:71:43 [INFO] [stdout] | [INFO] [stdout] 71 | cwd_full.entry(canonical.clone()).or_insert_with(HashMap::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/smriti.rs:74:38 [INFO] [stdout] | [INFO] [stdout] 74 | cwd_base.entry(base.clone()).or_insert_with(HashMap::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `cand_tokens.get(0)` [INFO] [stdout] --> src/scoring.rs:73:36 [INFO] [stdout] | [INFO] [stdout] 73 | } else if let Some(base) = cand_tokens.get(0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `cand_tokens.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `tokens.get(0)` [INFO] [stdout] --> src/suggest.rs:120:16 [INFO] [stdout] | [INFO] [stdout] 120 | let cmd0 = tokens.get(0).copied().unwrap_or(""); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `tokens.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/hooks.rs:93:5 [INFO] [stdout] | [INFO] [stdout] 93 | new_content.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `new_content.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `cand_toks` [INFO] [stdout] --> src/main.rs:57:14 [INFO] [stdout] | [INFO] [stdout] 57 | for i in 0..n { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 57 - for i in 0..n { [INFO] [stdout] 57 + for in cand_toks.iter().take(n) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `in_toks` [INFO] [stdout] --> src/main.rs:62:14 [INFO] [stdout] | [INFO] [stdout] 62 | for i in n..in_toks.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 62 - for i in n..in_toks.len() { [INFO] [stdout] 62 + for in in_toks.iter().skip(n) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:196:35 [INFO] [stdout] | [INFO] [stdout] 196 | let import_bash = bash || (!bash && !zsh); // default both if none specified [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 196 - let import_bash = bash || (!bash && !zsh); // default both if none specified [INFO] [stdout] 196 + let import_bash = !(!bash && zsh); // default both if none specified [INFO] [stdout] | [INFO] [stdout] 196 - let import_bash = bash || (!bash && !zsh); // default both if none specified [INFO] [stdout] 196 + let import_bash = bash || !zsh; // default both if none specified [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:197:34 [INFO] [stdout] | [INFO] [stdout] 197 | let import_zsh = zsh || (!bash && !zsh); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 197 - let import_zsh = zsh || (!bash && !zsh); [INFO] [stdout] 197 + let import_zsh = !(!zsh && bash); [INFO] [stdout] | [INFO] [stdout] 197 - let import_zsh = zsh || (!bash && !zsh); [INFO] [stdout] 197 + let import_zsh = zsh || !bash; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `args.get(0)` [INFO] [stdout] --> src/main.rs:230:24 [INFO] [stdout] | [INFO] [stdout] 230 | let cmd0 = args.get(0).map(|s| s.as_str()).unwrap_or(""); [INFO] [stdout] | ^^^^^^^^^^^ help: try: `args.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `flatten()` will run forever if the iterator repeatedly produces an `Err` [INFO] [stdout] --> src/history.rs:58:28 [INFO] [stdout] | [INFO] [stdout] 58 | for line in br.lines().flatten() { [INFO] [stdout] | ^^^^^^^^^ help: replace with: `map_while(Result::ok)` [INFO] [stdout] | [INFO] [stdout] note: this expression returning a `std::io::Lines` may produce an infinite number of `Err` in case of a read error [INFO] [stdout] --> src/history.rs:58:17 [INFO] [stdout] | [INFO] [stdout] 58 | for line in br.lines().flatten() { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lines_filter_map_ok [INFO] [stdout] = note: `#[warn(clippy::lines_filter_map_ok)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/smriti.rs:71:43 [INFO] [stdout] | [INFO] [stdout] 71 | cwd_full.entry(canonical.clone()).or_insert_with(HashMap::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/smriti.rs:74:38 [INFO] [stdout] | [INFO] [stdout] 74 | cwd_base.entry(base.clone()).or_insert_with(HashMap::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `cand_tokens.get(0)` [INFO] [stdout] --> src/scoring.rs:73:36 [INFO] [stdout] | [INFO] [stdout] 73 | } else if let Some(base) = cand_tokens.get(0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `cand_tokens.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `tokens.get(0)` [INFO] [stdout] --> src/suggest.rs:120:16 [INFO] [stdout] | [INFO] [stdout] 120 | let cmd0 = tokens.get(0).copied().unwrap_or(""); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `tokens.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/hooks.rs:93:5 [INFO] [stdout] | [INFO] [stdout] 93 | new_content.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `new_content.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `cand_toks` [INFO] [stdout] --> src/main.rs:57:14 [INFO] [stdout] | [INFO] [stdout] 57 | for i in 0..n { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 57 - for i in 0..n { [INFO] [stdout] 57 + for in cand_toks.iter().take(n) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `in_toks` [INFO] [stdout] --> src/main.rs:62:14 [INFO] [stdout] | [INFO] [stdout] 62 | for i in n..in_toks.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 62 - for i in n..in_toks.len() { [INFO] [stdout] 62 + for in in_toks.iter().skip(n) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:196:35 [INFO] [stdout] | [INFO] [stdout] 196 | let import_bash = bash || (!bash && !zsh); // default both if none specified [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 196 - let import_bash = bash || (!bash && !zsh); // default both if none specified [INFO] [stdout] 196 + let import_bash = !(!bash && zsh); // default both if none specified [INFO] [stdout] | [INFO] [stdout] 196 - let import_bash = bash || (!bash && !zsh); // default both if none specified [INFO] [stdout] 196 + let import_bash = bash || !zsh; // default both if none specified [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:197:34 [INFO] [stdout] | [INFO] [stdout] 197 | let import_zsh = zsh || (!bash && !zsh); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 197 - let import_zsh = zsh || (!bash && !zsh); [INFO] [stdout] 197 + let import_zsh = !(!zsh && bash); [INFO] [stdout] | [INFO] [stdout] 197 - let import_zsh = zsh || (!bash && !zsh); [INFO] [stdout] 197 + let import_zsh = zsh || !bash; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `args.get(0)` [INFO] [stdout] --> src/main.rs:230:24 [INFO] [stdout] | [INFO] [stdout] 230 | let cmd0 = args.get(0).map(|s| s.as_str()).unwrap_or(""); [INFO] [stdout] | ^^^^^^^^^^^ help: try: `args.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 21.08s [INFO] running `Command { std: "docker" "inspect" "50866b6901fed2900e7358548c4d67465236eb4238293a240f253f0112b94dd4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "50866b6901fed2900e7358548c4d67465236eb4238293a240f253f0112b94dd4", kill_on_drop: false }` [INFO] [stdout] 50866b6901fed2900e7358548c4d67465236eb4238293a240f253f0112b94dd4