[INFO] fetching crate ipnet 2.12.0... [INFO] linting ipnet-2.12.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate ipnet 2.12.0 into /workspace/builds/worker-4-tc1/source [INFO] started tweaking crates.io crate ipnet 2.12.0 [INFO] finished tweaking crates.io crate ipnet 2.12.0 [INFO] tweaked toml for crates.io crate ipnet 2.12.0 written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate ipnet 2.12.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate ipnet 2.12.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded serde_test v1.0.177 [INFO] [stderr] Downloaded ref-cast-impl v1.0.25 [INFO] [stderr] Downloaded ref-cast v1.0.25 [INFO] [stderr] Downloaded dyn-clone v1.0.20 [INFO] [stderr] Downloaded hash32 v0.3.1 [INFO] [stderr] Downloaded quote v1.0.44 [INFO] [stderr] Downloaded schemars v0.8.22 [INFO] [stderr] Downloaded schemars v1.2.1 [INFO] [stderr] Downloaded heapless v0.9.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a3f6bfe568f70d2565529cfe7178b4e47a1ab416339323ed6281311bb8f7368e [INFO] running `Command { std: "docker" "start" "-a" "a3f6bfe568f70d2565529cfe7178b4e47a1ab416339323ed6281311bb8f7368e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a3f6bfe568f70d2565529cfe7178b4e47a1ab416339323ed6281311bb8f7368e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a3f6bfe568f70d2565529cfe7178b4e47a1ab416339323ed6281311bb8f7368e", kill_on_drop: false }` [INFO] [stdout] a3f6bfe568f70d2565529cfe7178b4e47a1ab416339323ed6281311bb8f7368e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7ef1b1b1b597eb09edd2f002fd2bb00a904ccbf21beffc0057df86b71c66e2fa [INFO] running `Command { std: "docker" "start" "-a" "7ef1b1b1b597eb09edd2f002fd2bb00a904ccbf21beffc0057df86b71c66e2fa", kill_on_drop: false }` [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Checking ipnet v2.12.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/ipext.rs:376:13 [INFO] [stdout] | [INFO] [stdout] 376 | start: start, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/ipext.rs:377:13 [INFO] [stdout] | [INFO] [stdout] 377 | end: end, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `end` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/ipext.rs:398:13 [INFO] [stdout] | [INFO] [stdout] 398 | start: start, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/ipext.rs:399:13 [INFO] [stdout] | [INFO] [stdout] 399 | end: end, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `end` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/ipnet.rs:628:32 [INFO] [stdout] | [INFO] [stdout] 628 | Ok(Ipv4Net { addr: ip, prefix_len: prefix_len }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `prefix_len` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/ipnet.rs:659:29 [INFO] [stdout] | [INFO] [stdout] 659 | Ipv4Net { addr: ip, prefix_len: prefix_len } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `prefix_len` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/ipnet.rs:1016:32 [INFO] [stdout] | [INFO] [stdout] 1016 | Ok(Ipv6Net { addr: ip, prefix_len: prefix_len }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `prefix_len` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/ipnet.rs:1047:29 [INFO] [stdout] | [INFO] [stdout] 1047 | Ipv6Net { addr: ip, prefix_len: prefix_len } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `prefix_len` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/ipnet.rs:1572:13 [INFO] [stdout] | [INFO] [stdout] 1572 | start: start, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/ipnet.rs:1573:13 [INFO] [stdout] | [INFO] [stdout] 1573 | end: end, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `end` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/ipnet.rs:1574:13 [INFO] [stdout] | [INFO] [stdout] 1574 | min_prefix_len: min_prefix_len, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `min_prefix_len` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/ipnet.rs:1582:13 [INFO] [stdout] | [INFO] [stdout] 1582 | start: start, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/ipnet.rs:1583:13 [INFO] [stdout] | [INFO] [stdout] 1583 | end: end, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `end` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/ipnet.rs:1584:13 [INFO] [stdout] | [INFO] [stdout] 1584 | min_prefix_len: min_prefix_len, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `min_prefix_len` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/ipext.rs:505:29 [INFO] [stdout] | [INFO] [stdout] 505 | if count <= core::usize::MAX as u32 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 505 - if count <= core::usize::MAX as u32 { [INFO] [stdout] 505 + if count <= usize::MAX as u32 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/ipext.rs:510:21 [INFO] [stdout] | [INFO] [stdout] 510 | core::usize::MAX + 2 + count as usize [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 510 - core::usize::MAX + 2 + count as usize [INFO] [stdout] 510 + usize::MAX + 2 + count as usize [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/ipext.rs:555:20 [INFO] [stdout] | [INFO] [stdout] 555 | if count > core::usize::MAX as u64 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 555 - if count > core::usize::MAX as u64 { [INFO] [stdout] 555 + if count > usize::MAX as u64 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/ipext.rs:556:14 [INFO] [stdout] | [INFO] [stdout] 556 | (core::usize::MAX, None) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 556 - (core::usize::MAX, None) [INFO] [stdout] 556 + (usize::MAX, None) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/ipext.rs:585:21 [INFO] [stdout] | [INFO] [stdout] 585 | if count <= core::usize::MAX as u128 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 585 - if count <= core::usize::MAX as u128 { [INFO] [stdout] 585 + if count <= usize::MAX as u128 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/ipext.rs:590:13 [INFO] [stdout] | [INFO] [stdout] 590 | core::usize::MAX + 1 + count as usize [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 590 - core::usize::MAX + 1 + count as usize [INFO] [stdout] 590 + usize::MAX + 1 + count as usize [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/ipext.rs:640:24 [INFO] [stdout] | [INFO] [stdout] 640 | if count > core::usize::MAX as u128 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 640 - if count > core::usize::MAX as u128 { [INFO] [stdout] 640 + if count > usize::MAX as u128 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/ipext.rs:641:18 [INFO] [stdout] | [INFO] [stdout] 641 | (core::usize::MAX, None) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 641 - (core::usize::MAX, None) [INFO] [stdout] 641 + (usize::MAX, None) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/ipext.rs:647:14 [INFO] [stdout] | [INFO] [stdout] 647 | (core::usize::MAX, None) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 647 - (core::usize::MAX, None) [INFO] [stdout] 647 + (usize::MAX, None) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/ipnet.rs:732:9 [INFO] [stdout] | [INFO] [stdout] 732 | u32::max_value().checked_shl(32 - self.prefix_len as u32).unwrap_or(0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 732 - u32::max_value().checked_shl(32 - self.prefix_len as u32).unwrap_or(0) [INFO] [stdout] 732 + u32::MAX.checked_shl(32 - self.prefix_len as u32).unwrap_or(0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/ipnet.rs:751:9 [INFO] [stdout] | [INFO] [stdout] 751 | u32::max_value().checked_shr(self.prefix_len as u32).unwrap_or(0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 751 - u32::max_value().checked_shr(self.prefix_len as u32).unwrap_or(0) [INFO] [stdout] 751 + u32::MAX.checked_shr(self.prefix_len as u32).unwrap_or(0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/ipnet.rs:952:32 [INFO] [stdout] | [INFO] [stdout] 952 | pub fn aggregate(networks: &Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 952 - pub fn aggregate(networks: &Vec) -> Vec { [INFO] [stdout] 952 + pub fn aggregate(networks: &[Ipv4Net]) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/ipnet.rs:958:23 [INFO] [stdout] | [INFO] [stdout] 958 | if end != core::u32::MAX { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 958 - if end != core::u32::MAX { [INFO] [stdout] 958 + if end != u32::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/ipnet.rs:1120:9 [INFO] [stdout] | [INFO] [stdout] 1120 | u128::max_value().checked_shl((128 - self.prefix_len) as u32).unwrap_or(u128::min_value()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 1120 - u128::max_value().checked_shl((128 - self.prefix_len) as u32).unwrap_or(u128::min_value()) [INFO] [stdout] 1120 + u128::MAX.checked_shl((128 - self.prefix_len) as u32).unwrap_or(u128::min_value()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/ipnet.rs:1120:81 [INFO] [stdout] | [INFO] [stdout] 1120 | u128::max_value().checked_shl((128 - self.prefix_len) as u32).unwrap_or(u128::min_value()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 1120 - u128::max_value().checked_shl((128 - self.prefix_len) as u32).unwrap_or(u128::min_value()) [INFO] [stdout] 1120 + u128::max_value().checked_shl((128 - self.prefix_len) as u32).unwrap_or(u128::MIN) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/ipnet.rs:1139:9 [INFO] [stdout] | [INFO] [stdout] 1139 | u128::max_value().checked_shr(self.prefix_len as u32).unwrap_or(u128::min_value()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 1139 - u128::max_value().checked_shr(self.prefix_len as u32).unwrap_or(u128::min_value()) [INFO] [stdout] 1139 + u128::MAX.checked_shr(self.prefix_len as u32).unwrap_or(u128::min_value()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/ipnet.rs:1139:73 [INFO] [stdout] | [INFO] [stdout] 1139 | u128::max_value().checked_shr(self.prefix_len as u32).unwrap_or(u128::min_value()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 1139 - u128::max_value().checked_shr(self.prefix_len as u32).unwrap_or(u128::min_value()) [INFO] [stdout] 1139 + u128::max_value().checked_shr(self.prefix_len as u32).unwrap_or(u128::MIN) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/ipnet.rs:1328:32 [INFO] [stdout] | [INFO] [stdout] 1328 | pub fn aggregate(networks: &Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1328 - pub fn aggregate(networks: &Vec) -> Vec { [INFO] [stdout] 1328 + pub fn aggregate(networks: &[Ipv6Net]) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/ipnet.rs:1334:23 [INFO] [stdout] | [INFO] [stdout] 1334 | if end != core::u128::MAX { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 1334 - if end != core::u128::MAX { [INFO] [stdout] 1334 + if end != u128::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/ipnet.rs:1409:6 [INFO] [stdout] | [INFO] [stdout] 1409 | impl<'a> Contains<&'a IpNet> for IpNet { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 1409 - impl<'a> Contains<&'a IpNet> for IpNet { [INFO] [stdout] 1409 + impl Contains<&IpNet> for IpNet { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/ipnet.rs:1419:6 [INFO] [stdout] | [INFO] [stdout] 1419 | impl<'a> Contains<&'a IpAddr> for IpNet { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 1419 - impl<'a> Contains<&'a IpAddr> for IpNet { [INFO] [stdout] 1419 + impl Contains<&IpAddr> for IpNet { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/ipnet.rs:1614:17 [INFO] [stdout] | [INFO] [stdout] 1614 | if range == core::u32::MAX && min_prefix_len == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 1614 - if range == core::u32::MAX && min_prefix_len == 0 { [INFO] [stdout] 1614 + if range == u32::MAX && min_prefix_len == 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/ipnet.rs:1628:17 [INFO] [stdout] | [INFO] [stdout] 1628 | if range == core::u128::MAX && min_prefix_len == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 1628 - if range == core::u128::MAX && min_prefix_len == 0 { [INFO] [stdout] 1628 + if range == u128::MAX && min_prefix_len == 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/ipnet.rs:1705:8 [INFO] [stdout] | [INFO] [stdout] 1705 | if intervals.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `intervals.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/parser.rs:63:39 [INFO] [stdout] | [INFO] [stdout] 63 | fn read_or(&mut self, parsers: &mut [Box Option + 'static>]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/parser.rs:120:16 [INFO] [stdout] | [INFO] [stdout] 120 | if c >= b'0' && c <= b'9' { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `(b'0'..=b'9').contains(&c)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parser.rs:247:12 [INFO] [stdout] | [INFO] [stdout] 247 | if !self.read_given_char(':').is_some() || !self.read_given_char(':').is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.read_given_char(':').is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parser.rs:247:52 [INFO] [stdout] | [INFO] [stdout] 247 | if !self.read_given_char(':').is_some() || !self.read_given_char(':').is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.read_given_char(':').is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/parser.rs:210:32 [INFO] [stdout] | [INFO] [stdout] 210 | groups[i + 0] = ((octets[0] as u16) << 8) | (octets[1] as u16); [INFO] [stdout] | ^^^^^ help: consider reducing it to: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking serde_test v1.0.177 [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/ipext.rs:376:13 [INFO] [stdout] | [INFO] [stdout] 376 | start: start, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/ipext.rs:377:13 [INFO] [stdout] | [INFO] [stdout] 377 | end: end, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `end` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/ipext.rs:398:13 [INFO] [stdout] | [INFO] [stdout] 398 | start: start, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/ipext.rs:399:13 [INFO] [stdout] | [INFO] [stdout] 399 | end: end, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `end` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/ipnet.rs:628:32 [INFO] [stdout] | [INFO] [stdout] 628 | Ok(Ipv4Net { addr: ip, prefix_len: prefix_len }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `prefix_len` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/ipnet.rs:659:29 [INFO] [stdout] | [INFO] [stdout] 659 | Ipv4Net { addr: ip, prefix_len: prefix_len } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `prefix_len` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/ipnet.rs:1016:32 [INFO] [stdout] | [INFO] [stdout] 1016 | Ok(Ipv6Net { addr: ip, prefix_len: prefix_len }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `prefix_len` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/ipnet.rs:1047:29 [INFO] [stdout] | [INFO] [stdout] 1047 | Ipv6Net { addr: ip, prefix_len: prefix_len } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `prefix_len` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/ipnet.rs:1572:13 [INFO] [stdout] | [INFO] [stdout] 1572 | start: start, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/ipnet.rs:1573:13 [INFO] [stdout] | [INFO] [stdout] 1573 | end: end, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `end` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/ipnet.rs:1574:13 [INFO] [stdout] | [INFO] [stdout] 1574 | min_prefix_len: min_prefix_len, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `min_prefix_len` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/ipnet.rs:1582:13 [INFO] [stdout] | [INFO] [stdout] 1582 | start: start, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/ipnet.rs:1583:13 [INFO] [stdout] | [INFO] [stdout] 1583 | end: end, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `end` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/ipnet.rs:1584:13 [INFO] [stdout] | [INFO] [stdout] 1584 | min_prefix_len: min_prefix_len, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `min_prefix_len` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/ipext.rs:505:29 [INFO] [stdout] | [INFO] [stdout] 505 | if count <= core::usize::MAX as u32 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 505 - if count <= core::usize::MAX as u32 { [INFO] [stdout] 505 + if count <= usize::MAX as u32 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/ipext.rs:510:21 [INFO] [stdout] | [INFO] [stdout] 510 | core::usize::MAX + 2 + count as usize [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 510 - core::usize::MAX + 2 + count as usize [INFO] [stdout] 510 + usize::MAX + 2 + count as usize [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/ipext.rs:555:20 [INFO] [stdout] | [INFO] [stdout] 555 | if count > core::usize::MAX as u64 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 555 - if count > core::usize::MAX as u64 { [INFO] [stdout] 555 + if count > usize::MAX as u64 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/ipext.rs:556:14 [INFO] [stdout] | [INFO] [stdout] 556 | (core::usize::MAX, None) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 556 - (core::usize::MAX, None) [INFO] [stdout] 556 + (usize::MAX, None) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/ipext.rs:585:21 [INFO] [stdout] | [INFO] [stdout] 585 | if count <= core::usize::MAX as u128 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 585 - if count <= core::usize::MAX as u128 { [INFO] [stdout] 585 + if count <= usize::MAX as u128 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/ipext.rs:590:13 [INFO] [stdout] | [INFO] [stdout] 590 | core::usize::MAX + 1 + count as usize [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 590 - core::usize::MAX + 1 + count as usize [INFO] [stdout] 590 + usize::MAX + 1 + count as usize [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/ipext.rs:640:24 [INFO] [stdout] | [INFO] [stdout] 640 | if count > core::usize::MAX as u128 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 640 - if count > core::usize::MAX as u128 { [INFO] [stdout] 640 + if count > usize::MAX as u128 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/ipext.rs:641:18 [INFO] [stdout] | [INFO] [stdout] 641 | (core::usize::MAX, None) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 641 - (core::usize::MAX, None) [INFO] [stdout] 641 + (usize::MAX, None) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/ipext.rs:647:14 [INFO] [stdout] | [INFO] [stdout] 647 | (core::usize::MAX, None) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 647 - (core::usize::MAX, None) [INFO] [stdout] 647 + (usize::MAX, None) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/ipext.rs:904:36 [INFO] [stdout] | [INFO] [stdout] 904 | assert_eq!(i.size_hint(), (core::usize::MAX, None)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 904 - assert_eq!(i.size_hint(), (core::usize::MAX, None)); [INFO] [stdout] 904 + assert_eq!(i.size_hint(), (usize::MAX, None)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> src/ipext.rs:928:20 [INFO] [stdout] | [INFO] [stdout] 928 | assert_eq!(i.clone().nth(0), Some(Ipv4Addr::from_str("10.0.0.0").unwrap())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `i.clone().next()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] = note: `#[warn(clippy::iter_nth_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Ipv4AddrRange` which implements the `Copy` trait [INFO] [stdout] --> src/ipext.rs:932:22 [INFO] [stdout] | [INFO] [stdout] 932 | let mut i2 = i.clone(); [INFO] [stdout] | ^^^^^^^^^ help: try removing the `clone` call: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> src/ipext.rs:935:20 [INFO] [stdout] | [INFO] [stdout] 935 | assert_eq!(i2.nth(0), None); [INFO] [stdout] | ^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `i2.next()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Ipv4AddrRange` which implements the `Copy` trait [INFO] [stdout] --> src/ipext.rs:936:22 [INFO] [stdout] | [INFO] [stdout] 936 | let mut i3 = i.clone(); [INFO] [stdout] | ^^^^^^^^^ help: try removing the `clone` call: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> src/ipext.rs:944:20 [INFO] [stdout] | [INFO] [stdout] 944 | assert_eq!(i.clone().nth(0), Some(Ipv6Addr::from_str("fd00::").unwrap())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `i.clone().next()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Ipv6AddrRange` which implements the `Copy` trait [INFO] [stdout] --> src/ipext.rs:948:22 [INFO] [stdout] | [INFO] [stdout] 948 | let mut i2 = i.clone(); [INFO] [stdout] | ^^^^^^^^^ help: try removing the `clone` call: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> src/ipext.rs:951:20 [INFO] [stdout] | [INFO] [stdout] 951 | assert_eq!(i2.nth(0), None); [INFO] [stdout] | ^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `i2.next()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Ipv6AddrRange` which implements the `Copy` trait [INFO] [stdout] --> src/ipext.rs:952:22 [INFO] [stdout] | [INFO] [stdout] 952 | let mut i3 = i.clone(); [INFO] [stdout] | ^^^^^^^^^ help: try removing the `clone` call: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Ipv4AddrRange` which implements the `Copy` trait [INFO] [stdout] --> src/ipext.rs:965:22 [INFO] [stdout] | [INFO] [stdout] 965 | let mut i2 = i.clone(); [INFO] [stdout] | ^^^^^^^^^ help: try removing the `clone` call: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Ipv4AddrRange` which implements the `Copy` trait [INFO] [stdout] --> src/ipext.rs:969:22 [INFO] [stdout] | [INFO] [stdout] 969 | let mut i3 = i.clone(); [INFO] [stdout] | ^^^^^^^^^ help: try removing the `clone` call: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Ipv6AddrRange` which implements the `Copy` trait [INFO] [stdout] --> src/ipext.rs:981:22 [INFO] [stdout] | [INFO] [stdout] 981 | let mut i2 = i.clone(); [INFO] [stdout] | ^^^^^^^^^ help: try removing the `clone` call: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Ipv6AddrRange` which implements the `Copy` trait [INFO] [stdout] --> src/ipext.rs:985:22 [INFO] [stdout] | [INFO] [stdout] 985 | let mut i3 = i.clone(); [INFO] [stdout] | ^^^^^^^^^ help: try removing the `clone` call: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/ipnet.rs:732:9 [INFO] [stdout] | [INFO] [stdout] 732 | u32::max_value().checked_shl(32 - self.prefix_len as u32).unwrap_or(0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 732 - u32::max_value().checked_shl(32 - self.prefix_len as u32).unwrap_or(0) [INFO] [stdout] 732 + u32::MAX.checked_shl(32 - self.prefix_len as u32).unwrap_or(0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/ipnet.rs:751:9 [INFO] [stdout] | [INFO] [stdout] 751 | u32::max_value().checked_shr(self.prefix_len as u32).unwrap_or(0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 751 - u32::max_value().checked_shr(self.prefix_len as u32).unwrap_or(0) [INFO] [stdout] 751 + u32::MAX.checked_shr(self.prefix_len as u32).unwrap_or(0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/ipnet.rs:952:32 [INFO] [stdout] | [INFO] [stdout] 952 | pub fn aggregate(networks: &Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 952 - pub fn aggregate(networks: &Vec) -> Vec { [INFO] [stdout] 952 + pub fn aggregate(networks: &[Ipv4Net]) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/ipnet.rs:958:23 [INFO] [stdout] | [INFO] [stdout] 958 | if end != core::u32::MAX { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 958 - if end != core::u32::MAX { [INFO] [stdout] 958 + if end != u32::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/ipnet.rs:1120:9 [INFO] [stdout] | [INFO] [stdout] 1120 | u128::max_value().checked_shl((128 - self.prefix_len) as u32).unwrap_or(u128::min_value()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 1120 - u128::max_value().checked_shl((128 - self.prefix_len) as u32).unwrap_or(u128::min_value()) [INFO] [stdout] 1120 + u128::MAX.checked_shl((128 - self.prefix_len) as u32).unwrap_or(u128::min_value()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/ipnet.rs:1120:81 [INFO] [stdout] | [INFO] [stdout] 1120 | u128::max_value().checked_shl((128 - self.prefix_len) as u32).unwrap_or(u128::min_value()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 1120 - u128::max_value().checked_shl((128 - self.prefix_len) as u32).unwrap_or(u128::min_value()) [INFO] [stdout] 1120 + u128::max_value().checked_shl((128 - self.prefix_len) as u32).unwrap_or(u128::MIN) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/ipnet.rs:1139:9 [INFO] [stdout] | [INFO] [stdout] 1139 | u128::max_value().checked_shr(self.prefix_len as u32).unwrap_or(u128::min_value()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 1139 - u128::max_value().checked_shr(self.prefix_len as u32).unwrap_or(u128::min_value()) [INFO] [stdout] 1139 + u128::MAX.checked_shr(self.prefix_len as u32).unwrap_or(u128::min_value()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/ipnet.rs:1139:73 [INFO] [stdout] | [INFO] [stdout] 1139 | u128::max_value().checked_shr(self.prefix_len as u32).unwrap_or(u128::min_value()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 1139 - u128::max_value().checked_shr(self.prefix_len as u32).unwrap_or(u128::min_value()) [INFO] [stdout] 1139 + u128::max_value().checked_shr(self.prefix_len as u32).unwrap_or(u128::MIN) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/ipnet.rs:1328:32 [INFO] [stdout] | [INFO] [stdout] 1328 | pub fn aggregate(networks: &Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1328 - pub fn aggregate(networks: &Vec) -> Vec { [INFO] [stdout] 1328 + pub fn aggregate(networks: &[Ipv6Net]) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/ipnet.rs:1334:23 [INFO] [stdout] | [INFO] [stdout] 1334 | if end != core::u128::MAX { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 1334 - if end != core::u128::MAX { [INFO] [stdout] 1334 + if end != u128::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/ipnet.rs:1409:6 [INFO] [stdout] | [INFO] [stdout] 1409 | impl<'a> Contains<&'a IpNet> for IpNet { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 1409 - impl<'a> Contains<&'a IpNet> for IpNet { [INFO] [stdout] 1409 + impl Contains<&IpNet> for IpNet { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/ipnet.rs:1419:6 [INFO] [stdout] | [INFO] [stdout] 1419 | impl<'a> Contains<&'a IpAddr> for IpNet { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 1419 - impl<'a> Contains<&'a IpAddr> for IpNet { [INFO] [stdout] 1419 + impl Contains<&IpAddr> for IpNet { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/ipnet.rs:1614:17 [INFO] [stdout] | [INFO] [stdout] 1614 | if range == core::u32::MAX && min_prefix_len == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 1614 - if range == core::u32::MAX && min_prefix_len == 0 { [INFO] [stdout] 1614 + if range == u32::MAX && min_prefix_len == 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/ipnet.rs:1628:17 [INFO] [stdout] | [INFO] [stdout] 1628 | if range == core::u128::MAX && min_prefix_len == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 1628 - if range == core::u128::MAX && min_prefix_len == 0 { [INFO] [stdout] 1628 + if range == u128::MAX && min_prefix_len == 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/ipnet.rs:1705:8 [INFO] [stdout] | [INFO] [stdout] 1705 | if intervals.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `intervals.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/parser.rs:63:39 [INFO] [stdout] | [INFO] [stdout] 63 | fn read_or(&mut self, parsers: &mut [Box Option + 'static>]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 4.61s [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/parser.rs:120:16 [INFO] [stdout] | [INFO] [stdout] 120 | if c >= b'0' && c <= b'9' { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `(b'0'..=b'9').contains(&c)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parser.rs:247:12 [INFO] [stdout] | [INFO] [stdout] 247 | if !self.read_given_char(':').is_some() || !self.read_given_char(':').is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.read_given_char(':').is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parser.rs:247:52 [INFO] [stdout] | [INFO] [stdout] 247 | if !self.read_given_char(':').is_some() || !self.read_given_char(':').is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.read_given_char(':').is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/parser.rs:210:32 [INFO] [stdout] | [INFO] [stdout] 210 | groups[i + 0] = ((octets[0] as u16) << 8) | (octets[1] as u16); [INFO] [stdout] | ^^^^^ help: consider reducing it to: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "7ef1b1b1b597eb09edd2f002fd2bb00a904ccbf21beffc0057df86b71c66e2fa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7ef1b1b1b597eb09edd2f002fd2bb00a904ccbf21beffc0057df86b71c66e2fa", kill_on_drop: false }` [INFO] [stdout] 7ef1b1b1b597eb09edd2f002fd2bb00a904ccbf21beffc0057df86b71c66e2fa