[INFO] fetching crate intl_pluralrules 7.0.2... [INFO] linting intl_pluralrules-7.0.2 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate intl_pluralrules 7.0.2 into /workspace/builds/worker-3-tc1/source [INFO] started tweaking crates.io crate intl_pluralrules 7.0.2 [INFO] finished tweaking crates.io crate intl_pluralrules 7.0.2 [INFO] tweaked toml for crates.io crate intl_pluralrules 7.0.2 written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate intl_pluralrules 7.0.2 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 72 packages to latest compatible versions [INFO] [stderr] Adding criterion v0.3.6 (available: v0.8.2) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9e17494cdf4acbc96001926fbc2ed11a7c4e1a497b9baf35b9c881fc1c8b27cb [INFO] running `Command { std: "docker" "start" "-a" "9e17494cdf4acbc96001926fbc2ed11a7c4e1a497b9baf35b9c881fc1c8b27cb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9e17494cdf4acbc96001926fbc2ed11a7c4e1a497b9baf35b9c881fc1c8b27cb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9e17494cdf4acbc96001926fbc2ed11a7c4e1a497b9baf35b9c881fc1c8b27cb", kill_on_drop: false }` [INFO] [stdout] 9e17494cdf4acbc96001926fbc2ed11a7c4e1a497b9baf35b9c881fc1c8b27cb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bb4586d84c9374f58ce572994f1495f14d387a054eb1000762767f420bcc1e98 [INFO] running `Command { std: "docker" "start" "-a" "bb4586d84c9374f58ce572994f1495f14d387a054eb1000762767f420bcc1e98", kill_on_drop: false }` [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling proc-macro-hack v0.5.20+deprecated [INFO] [stderr] Checking regex-syntax v0.8.10 [INFO] [stderr] Checking csv-core v0.1.13 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Checking criterion-plot v0.4.5 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking regex-automata v0.4.14 [INFO] [stderr] Checking regex v1.12.3 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking serde_json v1.0.149 [INFO] [stderr] Checking csv v1.4.0 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling tinystr v0.8.2 [INFO] [stderr] Checking unic-langid-impl v0.9.6 [INFO] [stderr] Compiling unic-langid-macros-impl v0.9.6 [INFO] [stderr] Checking unic-langid-macros v0.9.6 [INFO] [stderr] Checking unic-langid v0.9.6 [INFO] [stderr] Checking intl_pluralrules v7.0.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: `feature = "cargo-clippy"` was replaced by `clippy` [INFO] [stdout] --> src/operands.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 51 | #![cfg_attr(feature = "cargo-clippy", allow(clippy::cast_lossless))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `clippy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_clippy_cfg_attr [INFO] [stdout] = note: `#[warn(clippy::deprecated_clippy_cfg_attr)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `feature = "cargo-clippy"` was replaced by `clippy` [INFO] [stdout] --> src/rules.rs:2:13 [INFO] [stdout] | [INFO] [stdout] 2 | #![cfg_attr(feature = "cargo-clippy", allow(clippy::float_cmp))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `clippy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_clippy_cfg_attr [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `feature = "cargo-clippy"` was replaced by `clippy` [INFO] [stdout] --> src/rules.rs:3:13 [INFO] [stdout] | [INFO] [stdout] 3 | #![cfg_attr(feature = "cargo-clippy", allow(clippy::unreadable_literal))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `clippy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_clippy_cfg_attr [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `feature = "cargo-clippy"` was replaced by `clippy` [INFO] [stdout] --> src/rules.rs:4:13 [INFO] [stdout] | [INFO] [stdout] 4 | #![cfg_attr(feature = "cargo-clippy", allow(clippy::nonminimal_bool))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `clippy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_clippy_cfg_attr [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/operands.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 51 | #![cfg_attr(feature = "cargo-clippy", allow(clippy::cast_lossless))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `cargo-clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `tarpaulin_include` [INFO] [stdout] --> src/lib.rs:30:11 [INFO] [stdout] | [INFO] [stdout] 30 | #[cfg(not(tarpaulin_include))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `docsrs`, `feature`, and `test` and 31 more [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(tarpaulin_include)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(tarpaulin_include)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/rules.rs:2:13 [INFO] [stdout] | [INFO] [stdout] 2 | #![cfg_attr(feature = "cargo-clippy", allow(clippy::float_cmp))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `cargo-clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/rules.rs:3:13 [INFO] [stdout] | [INFO] [stdout] 3 | #![cfg_attr(feature = "cargo-clippy", allow(clippy::unreadable_literal))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `cargo-clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/rules.rs:4:13 [INFO] [stdout] | [INFO] [stdout] 4 | #![cfg_attr(feature = "cargo-clippy", allow(clippy::nonminimal_bool))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `cargo-clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: importing legacy numeric constants [INFO] [stdout] --> src/operands.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 53 | use std::isize; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove this import [INFO] [stdout] = note: then `isize::` will resolve to the respective associated constant [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/operands.rs:78:13 [INFO] [stdout] | [INFO] [stdout] 78 | &input[1..] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/operands.rs:77:23 [INFO] [stdout] | [INFO] [stdout] 77 | let abs_str = if input.starts_with('-') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 77 ~ let abs_str = if let Some() = input.strip_prefix('-') { [INFO] [stdout] 78 ~ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/operands.rs:80:13 [INFO] [stdout] | [INFO] [stdout] 80 | &input [INFO] [stdout] | ^^^^^^ help: change this to: `input` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/operands.rs:83:44 [INFO] [stdout] | [INFO] [stdout] 83 | let absolute_value = f64::from_str(&abs_str).map_err(|_| "Incorrect number passed!")?; [INFO] [stdout] | ^^^^^^^^ help: change this to: `abs_str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/operands.rs:96:31 [INFO] [stdout] | [INFO] [stdout] 96 | u64::from_str(&int_str).map_err(|_| "Could not convert string to integer!")?; [INFO] [stdout] | ^^^^^^^^ help: change this to: `int_str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/operands.rs:100:36 [INFO] [stdout] | [INFO] [stdout] 100 | num_fraction_digits0 = dec_str.len() as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `dec_str.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/operands.rs:101:35 [INFO] [stdout] | [INFO] [stdout] 101 | num_fraction_digits = backtrace.len() as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `backtrace.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rules.rs:625:16 [INFO] [stdout] | [INFO] [stdout] 625 | if ((3..=10).contains(&(po.i)) && po.f == 0 || (13..=19).contains(&(po.i)) && po.f == 0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 625 - if ((3..=10).contains(&(po.i)) && po.f == 0 || (13..=19).contains(&(po.i)) && po.f == 0) [INFO] [stdout] 625 + if !(po.f != 0 || !(3..=10).contains(&(po.i)) && !(13..=19).contains(&(po.i))) [INFO] [stdout] | [INFO] [stdout] 625 - if ((3..=10).contains(&(po.i)) && po.f == 0 || (13..=19).contains(&(po.i)) && po.f == 0) [INFO] [stdout] 625 + if ((13..=19).contains(&(po.i)) || (3..=10).contains(&(po.i))) && po.f == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rules.rs:848:16 [INFO] [stdout] | [INFO] [stdout] 848 | if (po.t == 0 && po.i % 10 == 1 && po.i % 100 != 11) || (po.t != 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `po.t != 0 || po.i % 10 == 1 && po.i % 100 != 11` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rules.rs:1244:16 [INFO] [stdout] | [INFO] [stdout] 1244 | if (po.i % 10 == 1 && po.i % 100 != 11) [INFO] [stdout] | ________________^ [INFO] [stdout] 1245 | | || (po.v == 2 && po.f % 10 == 1 && po.f % 100 != 11) [INFO] [stdout] 1246 | | || (po.v != 2 && po.f % 10 == 1) [INFO] [stdout] | |________________________________________________^ help: try: `po.i % 10 == 1 && po.i % 100 != 11 || po.v != 2 && po.f % 10 == 1 || po.f % 10 == 1 && po.f % 100 != 11` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rules.rs:1633:16 [INFO] [stdout] | [INFO] [stdout] 1633 | if (po.i % 10 == 1 && po.i % 100 != 11) [INFO] [stdout] | ________________^ [INFO] [stdout] 1634 | | || (po.v == 2 && po.f % 10 == 1 && po.f % 100 != 11) [INFO] [stdout] 1635 | | || (po.v != 2 && po.f % 10 == 1) [INFO] [stdout] | |________________________________________________^ help: try: `po.i % 10 == 1 && po.i % 100 != 11 || po.v != 2 && po.f % 10 == 1 || po.f % 10 == 1 && po.f % 100 != 11` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rules.rs:1723:23 [INFO] [stdout] | [INFO] [stdout] 1723 | } else if (po.v == 0 && po.i % 10 == 0) [INFO] [stdout] | _______________________^ [INFO] [stdout] 1724 | | || (po.v == 0 && (5..=9).contains(&(po.i % 10))) [INFO] [stdout] 1725 | | || (po.v == 0 && (11..=14).contains(&(po.i % 100))) [INFO] [stdout] | |___________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1723 - } else if (po.v == 0 && po.i % 10 == 0) [INFO] [stdout] 1724 - || (po.v == 0 && (5..=9).contains(&(po.i % 10))) [INFO] [stdout] 1725 - || (po.v == 0 && (11..=14).contains(&(po.i % 100))) [INFO] [stdout] 1723 + } else if !(po.v != 0 || po.i % 10 != 0 && !(5..=9).contains(&(po.i % 10)) && !(11..=14).contains(&(po.i % 100))) [INFO] [stdout] | [INFO] [stdout] 1723 - } else if (po.v == 0 && po.i % 10 == 0) [INFO] [stdout] 1724 - || (po.v == 0 && (5..=9).contains(&(po.i % 10))) [INFO] [stdout] 1725 - || (po.v == 0 && (11..=14).contains(&(po.i % 100))) [INFO] [stdout] 1723 + } else if ((11..=14).contains(&(po.i % 100)) || (5..=9).contains(&(po.i % 10)) || po.i % 10 == 0) && po.v == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rules.rs:1723:23 [INFO] [stdout] | [INFO] [stdout] 1723 | } else if (po.v == 0 && po.i % 10 == 0) [INFO] [stdout] | _______________________^ [INFO] [stdout] 1724 | | || (po.v == 0 && (5..=9).contains(&(po.i % 10))) [INFO] [stdout] | |________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1723 - } else if (po.v == 0 && po.i % 10 == 0) [INFO] [stdout] 1724 - || (po.v == 0 && (5..=9).contains(&(po.i % 10))) [INFO] [stdout] 1723 + } else if !(po.v != 0 || po.i % 10 != 0 && !(5..=9).contains(&(po.i % 10))) [INFO] [stdout] | [INFO] [stdout] 1723 - } else if (po.v == 0 && po.i % 10 == 0) [INFO] [stdout] 1724 - || (po.v == 0 && (5..=9).contains(&(po.i % 10))) [INFO] [stdout] 1723 + } else if ((5..=9).contains(&(po.i % 10)) || po.i % 10 == 0) && po.v == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rules.rs:1932:16 [INFO] [stdout] | [INFO] [stdout] 1932 | if (po.v == 0 && (3..=4).contains(&(po.i % 100))) || (po.v != 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1932 - if (po.v == 0 && (3..=4).contains(&(po.i % 100))) || (po.v != 0) { [INFO] [stdout] 1932 + if !(po.v == 0 && !(3..=4).contains(&(po.i % 100))) { [INFO] [stdout] | [INFO] [stdout] 1932 - if (po.v == 0 && (3..=4).contains(&(po.i % 100))) || (po.v != 0) { [INFO] [stdout] 1932 + if po.v != 0 || (3..=4).contains(&(po.i % 100)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rules.rs:2267:16 [INFO] [stdout] | [INFO] [stdout] 2267 | if ((0..=1).contains(&(po.i)) && po.f == 0) [INFO] [stdout] | ________________^ [INFO] [stdout] 2268 | | || ((11..=99).contains(&(po.i)) && po.f == 0) [INFO] [stdout] | |_____________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 2267 - if ((0..=1).contains(&(po.i)) && po.f == 0) [INFO] [stdout] 2268 - || ((11..=99).contains(&(po.i)) && po.f == 0) [INFO] [stdout] 2267 + if !(po.f != 0 || !(0..=1).contains(&(po.i)) && !(11..=99).contains(&(po.i))) [INFO] [stdout] | [INFO] [stdout] 2267 - if ((0..=1).contains(&(po.i)) && po.f == 0) [INFO] [stdout] 2268 - || ((11..=99).contains(&(po.i)) && po.f == 0) [INFO] [stdout] 2267 + if ((11..=99).contains(&(po.i)) || (0..=1).contains(&(po.i))) && po.f == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rules.rs:2291:23 [INFO] [stdout] | [INFO] [stdout] 2291 | } else if (po.v == 0 && po.i % 10 == 0) [INFO] [stdout] | _______________________^ [INFO] [stdout] 2292 | | || (po.v == 0 && (5..=9).contains(&(po.i % 10))) [INFO] [stdout] 2293 | | || (po.v == 0 && (11..=14).contains(&(po.i % 100))) [INFO] [stdout] | |___________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 2291 - } else if (po.v == 0 && po.i % 10 == 0) [INFO] [stdout] 2292 - || (po.v == 0 && (5..=9).contains(&(po.i % 10))) [INFO] [stdout] 2293 - || (po.v == 0 && (11..=14).contains(&(po.i % 100))) [INFO] [stdout] 2291 + } else if !(po.v != 0 || po.i % 10 != 0 && !(5..=9).contains(&(po.i % 10)) && !(11..=14).contains(&(po.i % 100))) [INFO] [stdout] | [INFO] [stdout] 2291 - } else if (po.v == 0 && po.i % 10 == 0) [INFO] [stdout] 2292 - || (po.v == 0 && (5..=9).contains(&(po.i % 10))) [INFO] [stdout] 2293 - || (po.v == 0 && (11..=14).contains(&(po.i % 100))) [INFO] [stdout] 2291 + } else if ((11..=14).contains(&(po.i % 100)) || (5..=9).contains(&(po.i % 10)) || po.i % 10 == 0) && po.v == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rules.rs:2291:23 [INFO] [stdout] | [INFO] [stdout] 2291 | } else if (po.v == 0 && po.i % 10 == 0) [INFO] [stdout] | _______________________^ [INFO] [stdout] 2292 | | || (po.v == 0 && (5..=9).contains(&(po.i % 10))) [INFO] [stdout] | |________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 2291 - } else if (po.v == 0 && po.i % 10 == 0) [INFO] [stdout] 2292 - || (po.v == 0 && (5..=9).contains(&(po.i % 10))) [INFO] [stdout] 2291 + } else if !(po.v != 0 || po.i % 10 != 0 && !(5..=9).contains(&(po.i % 10))) [INFO] [stdout] | [INFO] [stdout] 2291 - } else if (po.v == 0 && po.i % 10 == 0) [INFO] [stdout] 2292 - || (po.v == 0 && (5..=9).contains(&(po.i % 10))) [INFO] [stdout] 2291 + } else if ((5..=9).contains(&(po.i % 10)) || po.i % 10 == 0) && po.v == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking criterion v0.3.6 [INFO] [stdout] warning: `feature = "cargo-clippy"` was replaced by `clippy` [INFO] [stdout] --> src/operands.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 51 | #![cfg_attr(feature = "cargo-clippy", allow(clippy::cast_lossless))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `clippy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_clippy_cfg_attr [INFO] [stdout] = note: `#[warn(clippy::deprecated_clippy_cfg_attr)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `feature = "cargo-clippy"` was replaced by `clippy` [INFO] [stdout] --> src/rules.rs:2:13 [INFO] [stdout] | [INFO] [stdout] 2 | #![cfg_attr(feature = "cargo-clippy", allow(clippy::float_cmp))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `clippy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_clippy_cfg_attr [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `feature = "cargo-clippy"` was replaced by `clippy` [INFO] [stdout] --> src/rules.rs:3:13 [INFO] [stdout] | [INFO] [stdout] 3 | #![cfg_attr(feature = "cargo-clippy", allow(clippy::unreadable_literal))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `clippy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_clippy_cfg_attr [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `feature = "cargo-clippy"` was replaced by `clippy` [INFO] [stdout] --> src/rules.rs:4:13 [INFO] [stdout] | [INFO] [stdout] 4 | #![cfg_attr(feature = "cargo-clippy", allow(clippy::nonminimal_bool))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `clippy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_clippy_cfg_attr [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/operands.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 51 | #![cfg_attr(feature = "cargo-clippy", allow(clippy::cast_lossless))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `cargo-clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `tarpaulin_include` [INFO] [stdout] --> src/lib.rs:30:11 [INFO] [stdout] | [INFO] [stdout] 30 | #[cfg(not(tarpaulin_include))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `docsrs`, `feature`, and `test` and 31 more [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(tarpaulin_include)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(tarpaulin_include)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/rules.rs:2:13 [INFO] [stdout] | [INFO] [stdout] 2 | #![cfg_attr(feature = "cargo-clippy", allow(clippy::float_cmp))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `cargo-clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/rules.rs:3:13 [INFO] [stdout] | [INFO] [stdout] 3 | #![cfg_attr(feature = "cargo-clippy", allow(clippy::unreadable_literal))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `cargo-clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/rules.rs:4:13 [INFO] [stdout] | [INFO] [stdout] 4 | #![cfg_attr(feature = "cargo-clippy", allow(clippy::nonminimal_bool))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `cargo-clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: importing legacy numeric constants [INFO] [stdout] --> src/operands.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 53 | use std::isize; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove this import [INFO] [stdout] = note: then `isize::` will resolve to the respective associated constant [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/operands.rs:78:13 [INFO] [stdout] | [INFO] [stdout] 78 | &input[1..] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/operands.rs:77:23 [INFO] [stdout] | [INFO] [stdout] 77 | let abs_str = if input.starts_with('-') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 77 ~ let abs_str = if let Some() = input.strip_prefix('-') { [INFO] [stdout] 78 ~ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/operands.rs:80:13 [INFO] [stdout] | [INFO] [stdout] 80 | &input [INFO] [stdout] | ^^^^^^ help: change this to: `input` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/operands.rs:83:44 [INFO] [stdout] | [INFO] [stdout] 83 | let absolute_value = f64::from_str(&abs_str).map_err(|_| "Incorrect number passed!")?; [INFO] [stdout] | ^^^^^^^^ help: change this to: `abs_str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/operands.rs:96:31 [INFO] [stdout] | [INFO] [stdout] 96 | u64::from_str(&int_str).map_err(|_| "Could not convert string to integer!")?; [INFO] [stdout] | ^^^^^^^^ help: change this to: `int_str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/operands.rs:100:36 [INFO] [stdout] | [INFO] [stdout] 100 | num_fraction_digits0 = dec_str.len() as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `dec_str.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/operands.rs:101:35 [INFO] [stdout] | [INFO] [stdout] 101 | num_fraction_digits = backtrace.len() as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `backtrace.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rules.rs:625:16 [INFO] [stdout] | [INFO] [stdout] 625 | if ((3..=10).contains(&(po.i)) && po.f == 0 || (13..=19).contains(&(po.i)) && po.f == 0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 625 - if ((3..=10).contains(&(po.i)) && po.f == 0 || (13..=19).contains(&(po.i)) && po.f == 0) [INFO] [stdout] 625 + if !(po.f != 0 || !(3..=10).contains(&(po.i)) && !(13..=19).contains(&(po.i))) [INFO] [stdout] | [INFO] [stdout] 625 - if ((3..=10).contains(&(po.i)) && po.f == 0 || (13..=19).contains(&(po.i)) && po.f == 0) [INFO] [stdout] 625 + if ((13..=19).contains(&(po.i)) || (3..=10).contains(&(po.i))) && po.f == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rules.rs:848:16 [INFO] [stdout] | [INFO] [stdout] 848 | if (po.t == 0 && po.i % 10 == 1 && po.i % 100 != 11) || (po.t != 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `po.t != 0 || po.i % 10 == 1 && po.i % 100 != 11` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rules.rs:1244:16 [INFO] [stdout] | [INFO] [stdout] 1244 | if (po.i % 10 == 1 && po.i % 100 != 11) [INFO] [stdout] | ________________^ [INFO] [stdout] 1245 | | || (po.v == 2 && po.f % 10 == 1 && po.f % 100 != 11) [INFO] [stdout] 1246 | | || (po.v != 2 && po.f % 10 == 1) [INFO] [stdout] | |________________________________________________^ help: try: `po.i % 10 == 1 && po.i % 100 != 11 || po.v != 2 && po.f % 10 == 1 || po.f % 10 == 1 && po.f % 100 != 11` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rules.rs:1633:16 [INFO] [stdout] | [INFO] [stdout] 1633 | if (po.i % 10 == 1 && po.i % 100 != 11) [INFO] [stdout] | ________________^ [INFO] [stdout] 1634 | | || (po.v == 2 && po.f % 10 == 1 && po.f % 100 != 11) [INFO] [stdout] 1635 | | || (po.v != 2 && po.f % 10 == 1) [INFO] [stdout] | |________________________________________________^ help: try: `po.i % 10 == 1 && po.i % 100 != 11 || po.v != 2 && po.f % 10 == 1 || po.f % 10 == 1 && po.f % 100 != 11` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rules.rs:1723:23 [INFO] [stdout] | [INFO] [stdout] 1723 | } else if (po.v == 0 && po.i % 10 == 0) [INFO] [stdout] | _______________________^ [INFO] [stdout] 1724 | | || (po.v == 0 && (5..=9).contains(&(po.i % 10))) [INFO] [stdout] 1725 | | || (po.v == 0 && (11..=14).contains(&(po.i % 100))) [INFO] [stdout] | |___________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1723 - } else if (po.v == 0 && po.i % 10 == 0) [INFO] [stdout] 1724 - || (po.v == 0 && (5..=9).contains(&(po.i % 10))) [INFO] [stdout] 1725 - || (po.v == 0 && (11..=14).contains(&(po.i % 100))) [INFO] [stdout] 1723 + } else if !(po.v != 0 || po.i % 10 != 0 && !(5..=9).contains(&(po.i % 10)) && !(11..=14).contains(&(po.i % 100))) [INFO] [stdout] | [INFO] [stdout] 1723 - } else if (po.v == 0 && po.i % 10 == 0) [INFO] [stdout] 1724 - || (po.v == 0 && (5..=9).contains(&(po.i % 10))) [INFO] [stdout] 1725 - || (po.v == 0 && (11..=14).contains(&(po.i % 100))) [INFO] [stdout] 1723 + } else if ((11..=14).contains(&(po.i % 100)) || (5..=9).contains(&(po.i % 10)) || po.i % 10 == 0) && po.v == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rules.rs:1723:23 [INFO] [stdout] | [INFO] [stdout] 1723 | } else if (po.v == 0 && po.i % 10 == 0) [INFO] [stdout] | _______________________^ [INFO] [stdout] 1724 | | || (po.v == 0 && (5..=9).contains(&(po.i % 10))) [INFO] [stdout] | |________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1723 - } else if (po.v == 0 && po.i % 10 == 0) [INFO] [stdout] 1724 - || (po.v == 0 && (5..=9).contains(&(po.i % 10))) [INFO] [stdout] 1723 + } else if !(po.v != 0 || po.i % 10 != 0 && !(5..=9).contains(&(po.i % 10))) [INFO] [stdout] | [INFO] [stdout] 1723 - } else if (po.v == 0 && po.i % 10 == 0) [INFO] [stdout] 1724 - || (po.v == 0 && (5..=9).contains(&(po.i % 10))) [INFO] [stdout] 1723 + } else if ((5..=9).contains(&(po.i % 10)) || po.i % 10 == 0) && po.v == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rules.rs:1932:16 [INFO] [stdout] | [INFO] [stdout] 1932 | if (po.v == 0 && (3..=4).contains(&(po.i % 100))) || (po.v != 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1932 - if (po.v == 0 && (3..=4).contains(&(po.i % 100))) || (po.v != 0) { [INFO] [stdout] 1932 + if !(po.v == 0 && !(3..=4).contains(&(po.i % 100))) { [INFO] [stdout] | [INFO] [stdout] 1932 - if (po.v == 0 && (3..=4).contains(&(po.i % 100))) || (po.v != 0) { [INFO] [stdout] 1932 + if po.v != 0 || (3..=4).contains(&(po.i % 100)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rules.rs:2267:16 [INFO] [stdout] | [INFO] [stdout] 2267 | if ((0..=1).contains(&(po.i)) && po.f == 0) [INFO] [stdout] | ________________^ [INFO] [stdout] 2268 | | || ((11..=99).contains(&(po.i)) && po.f == 0) [INFO] [stdout] | |_____________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 2267 - if ((0..=1).contains(&(po.i)) && po.f == 0) [INFO] [stdout] 2268 - || ((11..=99).contains(&(po.i)) && po.f == 0) [INFO] [stdout] 2267 + if !(po.f != 0 || !(0..=1).contains(&(po.i)) && !(11..=99).contains(&(po.i))) [INFO] [stdout] | [INFO] [stdout] 2267 - if ((0..=1).contains(&(po.i)) && po.f == 0) [INFO] [stdout] 2268 - || ((11..=99).contains(&(po.i)) && po.f == 0) [INFO] [stdout] 2267 + if ((11..=99).contains(&(po.i)) || (0..=1).contains(&(po.i))) && po.f == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rules.rs:2291:23 [INFO] [stdout] | [INFO] [stdout] 2291 | } else if (po.v == 0 && po.i % 10 == 0) [INFO] [stdout] | _______________________^ [INFO] [stdout] 2292 | | || (po.v == 0 && (5..=9).contains(&(po.i % 10))) [INFO] [stdout] 2293 | | || (po.v == 0 && (11..=14).contains(&(po.i % 100))) [INFO] [stdout] | |___________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 2291 - } else if (po.v == 0 && po.i % 10 == 0) [INFO] [stdout] 2292 - || (po.v == 0 && (5..=9).contains(&(po.i % 10))) [INFO] [stdout] 2293 - || (po.v == 0 && (11..=14).contains(&(po.i % 100))) [INFO] [stdout] 2291 + } else if !(po.v != 0 || po.i % 10 != 0 && !(5..=9).contains(&(po.i % 10)) && !(11..=14).contains(&(po.i % 100))) [INFO] [stdout] | [INFO] [stdout] 2291 - } else if (po.v == 0 && po.i % 10 == 0) [INFO] [stdout] 2292 - || (po.v == 0 && (5..=9).contains(&(po.i % 10))) [INFO] [stdout] 2293 - || (po.v == 0 && (11..=14).contains(&(po.i % 100))) [INFO] [stdout] 2291 + } else if ((11..=14).contains(&(po.i % 100)) || (5..=9).contains(&(po.i % 10)) || po.i % 10 == 0) && po.v == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rules.rs:2291:23 [INFO] [stdout] | [INFO] [stdout] 2291 | } else if (po.v == 0 && po.i % 10 == 0) [INFO] [stdout] | _______________________^ [INFO] [stdout] 2292 | | || (po.v == 0 && (5..=9).contains(&(po.i % 10))) [INFO] [stdout] | |________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 2291 - } else if (po.v == 0 && po.i % 10 == 0) [INFO] [stdout] 2292 - || (po.v == 0 && (5..=9).contains(&(po.i % 10))) [INFO] [stdout] 2291 + } else if !(po.v != 0 || po.i % 10 != 0 && !(5..=9).contains(&(po.i % 10))) [INFO] [stdout] | [INFO] [stdout] 2291 - } else if (po.v == 0 && po.i % 10 == 0) [INFO] [stdout] 2292 - || (po.v == 0 && (5..=9).contains(&(po.i % 10))) [INFO] [stdout] 2291 + } else if ((5..=9).contains(&(po.i % 10)) || po.i % 10 == 0) && po.v == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:202:40 [INFO] [stdout] | [INFO] [stdout] 202 | assert_eq!(pr_broken.is_err(), !pr_broken.is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `pr_broken.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/lib.rs:220:9 [INFO] [stdout] | [INFO] [stdout] 220 | / assert_eq!( [INFO] [stdout] 221 | | PluralRules::get_locales(PluralRuleType::CARDINAL).is_empty(), [INFO] [stdout] 222 | | false [INFO] [stdout] 223 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 220 ~ assert!( [INFO] [stdout] 221 ~ !PluralRules::get_locales(PluralRuleType::CARDINAL).is_empty() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 15.04s [INFO] running `Command { std: "docker" "inspect" "bb4586d84c9374f58ce572994f1495f14d387a054eb1000762767f420bcc1e98", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bb4586d84c9374f58ce572994f1495f14d387a054eb1000762767f420bcc1e98", kill_on_drop: false }` [INFO] [stdout] bb4586d84c9374f58ce572994f1495f14d387a054eb1000762767f420bcc1e98