[INFO] fetching crate intelhex 0.2.1... [INFO] linting intelhex-0.2.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate intelhex 0.2.1 into /workspace/builds/worker-1-tc1/source [INFO] started tweaking crates.io crate intelhex 0.2.1 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate intelhex 0.2.1 [INFO] tweaked toml for crates.io crate intelhex 0.2.1 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate intelhex 0.2.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate intelhex 0.2.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8fc31fc952e04583377dc074bd0ca34afd1e08ebafcafaeda2ea170d8305cf4f [INFO] running `Command { std: "docker" "start" "-a" "8fc31fc952e04583377dc074bd0ca34afd1e08ebafcafaeda2ea170d8305cf4f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8fc31fc952e04583377dc074bd0ca34afd1e08ebafcafaeda2ea170d8305cf4f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8fc31fc952e04583377dc074bd0ca34afd1e08ebafcafaeda2ea170d8305cf4f", kill_on_drop: false }` [INFO] [stdout] 8fc31fc952e04583377dc074bd0ca34afd1e08ebafcafaeda2ea170d8305cf4f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e61ebab9ee1cb6c2544fca2854dd2d1d60615e5ace0bdc8ca475bbf803fca9e6 [INFO] running `Command { std: "docker" "start" "-a" "e61ebab9ee1cb6c2544fca2854dd2d1d60615e5ace0bdc8ca475bbf803fca9e6", kill_on_drop: false }` [INFO] [stderr] Checking intelhex v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib/intelhex/file.rs:89:13 [INFO] [stdout] | [INFO] [stdout] 89 | len: len, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `len` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/intelhex/util.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | return (input as i64 * -1i64) as u8; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return (input as i64 * -1i64) as u8; [INFO] [stdout] 29 + (input as i64 * -1i64) as u8 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this multiplication by -1 can be written more succinctly [INFO] [stdout] --> src/lib/intelhex/util.rs:29:12 [INFO] [stdout] | [INFO] [stdout] 29 | return (input as i64 * -1i64) as u8; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `-(input as i64)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stdout] = note: `#[warn(clippy::neg_multiply)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/intelhex/error.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | return self [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 - return self [INFO] [stdout] 14 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/lib/intelhex/error.rs:56:5 [INFO] [stdout] | [INFO] [stdout] 56 | / pub fn new(self, msg:&str) -> IntelHexError { [INFO] [stdout] 57 | | IntelHexError { [INFO] [stdout] 58 | | msg: msg.to_string(), [INFO] [stdout] 59 | | err_type: self, [INFO] [stdout] ... | [INFO] [stdout] 62 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] = note: `#[warn(clippy::new_ret_no_self)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib/intelhex/file.rs:82:12 [INFO] [stdout] | [INFO] [stdout] 82 | if !(record_end <= record_str.len()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(record_end > record_str.len())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this manual char comparison can be written more succinctly [INFO] [stdout] --> src/lib/intelhex/file.rs:62:37 [INFO] [stdout] | [INFO] [stdout] 62 | let start = match line.find(|b| b == RECORD_START) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using a `char`: `RECORD_START` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_pattern_char_comparison [INFO] [stdout] = note: `#[warn(clippy::manual_pattern_char_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` expression can be replaced with `?` [INFO] [stdout] --> src/lib/intelhex/file.rs:100:20 [INFO] [stdout] | [INFO] [stdout] 100 | rtype: match RecordType::parse(&record_str[6..8]) { [INFO] [stdout] | ____________________^ [INFO] [stdout] 101 | | Ok(rtype) => rtype, [INFO] [stdout] 102 | | Err(err) => return Err(err) [INFO] [stdout] 103 | | }, [INFO] [stdout] | |_____________^ help: try instead: `RecordType::parse(&record_str[6..8])?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/intelhex/file.rs:147:9 [INFO] [stdout] | [INFO] [stdout] 147 | return b.into(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 147 - return b.into(); [INFO] [stdout] 147 + b.into() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/intelhex/file.rs:157:9 [INFO] [stdout] | [INFO] [stdout] 157 | return hex_str; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 157 - return hex_str; [INFO] [stdout] 157 + hex_str [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/intelhex/file.rs:202:9 [INFO] [stdout] | [INFO] [stdout] 202 | return Ok(records); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 202 - return Ok(records); [INFO] [stdout] 202 + Ok(records) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needless call to `bytes` [INFO] [stdout] --> src/lib/intelhex/file.rs:208:19 [INFO] [stdout] | [INFO] [stdout] 208 | size: raw_data.bytes().len(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `raw_data.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_as_bytes [INFO] [stdout] = note: `#[warn(clippy::needless_as_bytes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib/intelhex/file.rs:209:48 [INFO] [stdout] | [INFO] [stdout] 209 | records: match Self::parse_records(&raw_data) { [INFO] [stdout] | ^^^^^^^^^ help: change this to: `raw_data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/intelhex/file.rs:233:9 [INFO] [stdout] | [INFO] [stdout] 233 | return Ok(intel_hex_file) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 233 - return Ok(intel_hex_file) [INFO] [stdout] 233 + Ok(intel_hex_file) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` expression can be replaced with `?` [INFO] [stdout] --> src/lib/intelhex/file.rs:226:34 [INFO] [stdout] | [INFO] [stdout] 226 | let mut intel_hex_file = match Self::load(&raw_data) { [INFO] [stdout] | __________________________________^ [INFO] [stdout] 227 | | Ok(file) => file, [INFO] [stdout] 228 | | Err(err_box) => return Err(err_box) [INFO] [stdout] 229 | | }; [INFO] [stdout] | |_________^ help: try instead: `Self::load(&raw_data)?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/intelhex/file.rs:247:9 [INFO] [stdout] | [INFO] [stdout] 247 | return b.into(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 247 - return b.into(); [INFO] [stdout] 247 + b.into() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/intelhex/file.rs:261:9 [INFO] [stdout] | [INFO] [stdout] 261 | return hex_str; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 261 - return hex_str; [INFO] [stdout] 261 + hex_str [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib/intelhex/file.rs:89:13 [INFO] [stdout] | [INFO] [stdout] 89 | len: len, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `len` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/intelhex/util.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | return (input as i64 * -1i64) as u8; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return (input as i64 * -1i64) as u8; [INFO] [stdout] 29 + (input as i64 * -1i64) as u8 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this multiplication by -1 can be written more succinctly [INFO] [stdout] --> src/lib/intelhex/util.rs:29:12 [INFO] [stdout] | [INFO] [stdout] 29 | return (input as i64 * -1i64) as u8; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `-(input as i64)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stdout] = note: `#[warn(clippy::neg_multiply)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/intelhex/error.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | return self [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 - return self [INFO] [stdout] 14 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/lib/intelhex/error.rs:56:5 [INFO] [stdout] | [INFO] [stdout] 56 | / pub fn new(self, msg:&str) -> IntelHexError { [INFO] [stdout] 57 | | IntelHexError { [INFO] [stdout] 58 | | msg: msg.to_string(), [INFO] [stdout] 59 | | err_type: self, [INFO] [stdout] ... | [INFO] [stdout] 62 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] = note: `#[warn(clippy::new_ret_no_self)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib/intelhex/file.rs:82:12 [INFO] [stdout] | [INFO] [stdout] 82 | if !(record_end <= record_str.len()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(record_end > record_str.len())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this manual char comparison can be written more succinctly [INFO] [stdout] --> src/lib/intelhex/file.rs:62:37 [INFO] [stdout] | [INFO] [stdout] 62 | let start = match line.find(|b| b == RECORD_START) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using a `char`: `RECORD_START` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_pattern_char_comparison [INFO] [stdout] = note: `#[warn(clippy::manual_pattern_char_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` expression can be replaced with `?` [INFO] [stdout] --> src/lib/intelhex/file.rs:100:20 [INFO] [stdout] | [INFO] [stdout] 100 | rtype: match RecordType::parse(&record_str[6..8]) { [INFO] [stdout] | ____________________^ [INFO] [stdout] 101 | | Ok(rtype) => rtype, [INFO] [stdout] 102 | | Err(err) => return Err(err) [INFO] [stdout] 103 | | }, [INFO] [stdout] | |_____________^ help: try instead: `RecordType::parse(&record_str[6..8])?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/intelhex/file.rs:147:9 [INFO] [stdout] | [INFO] [stdout] 147 | return b.into(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 147 - return b.into(); [INFO] [stdout] 147 + b.into() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/intelhex/file.rs:157:9 [INFO] [stdout] | [INFO] [stdout] 157 | return hex_str; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 157 - return hex_str; [INFO] [stdout] 157 + hex_str [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/intelhex/file.rs:202:9 [INFO] [stdout] | [INFO] [stdout] 202 | return Ok(records); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 202 - return Ok(records); [INFO] [stdout] 202 + Ok(records) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needless call to `bytes` [INFO] [stdout] --> src/lib/intelhex/file.rs:208:19 [INFO] [stdout] | [INFO] [stdout] 208 | size: raw_data.bytes().len(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `raw_data.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_as_bytes [INFO] [stdout] = note: `#[warn(clippy::needless_as_bytes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib/intelhex/file.rs:209:48 [INFO] [stdout] | [INFO] [stdout] 209 | records: match Self::parse_records(&raw_data) { [INFO] [stdout] | ^^^^^^^^^ help: change this to: `raw_data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/intelhex/file.rs:233:9 [INFO] [stdout] | [INFO] [stdout] 233 | return Ok(intel_hex_file) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 233 - return Ok(intel_hex_file) [INFO] [stdout] 233 + Ok(intel_hex_file) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` expression can be replaced with `?` [INFO] [stdout] --> src/lib/intelhex/file.rs:226:34 [INFO] [stdout] | [INFO] [stdout] 226 | let mut intel_hex_file = match Self::load(&raw_data) { [INFO] [stdout] | __________________________________^ [INFO] [stdout] 227 | | Ok(file) => file, [INFO] [stdout] 228 | | Err(err_box) => return Err(err_box) [INFO] [stdout] 229 | | }; [INFO] [stdout] | |_________^ help: try instead: `Self::load(&raw_data)?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/intelhex/file.rs:247:9 [INFO] [stdout] | [INFO] [stdout] 247 | return b.into(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 247 - return b.into(); [INFO] [stdout] 247 + b.into() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/intelhex/file.rs:261:9 [INFO] [stdout] | [INFO] [stdout] 261 | return hex_str; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 261 - return hex_str; [INFO] [stdout] 261 + hex_str [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> examples/save_file.rs:24:13 [INFO] [stdout] | [INFO] [stdout] 24 | return [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 23 ~ println!("{:?}", error); [INFO] [stdout] 24 | } [INFO] [stdout] 25 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.41s [INFO] running `Command { std: "docker" "inspect" "e61ebab9ee1cb6c2544fca2854dd2d1d60615e5ace0bdc8ca475bbf803fca9e6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e61ebab9ee1cb6c2544fca2854dd2d1d60615e5ace0bdc8ca475bbf803fca9e6", kill_on_drop: false }` [INFO] [stdout] e61ebab9ee1cb6c2544fca2854dd2d1d60615e5ace0bdc8ca475bbf803fca9e6