[INFO] fetching crate infinitable 1.6.0... [INFO] linting infinitable-1.6.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate infinitable 1.6.0 into /workspace/builds/worker-0-tc1/source [INFO] started tweaking crates.io crate infinitable 1.6.0 [INFO] finished tweaking crates.io crate infinitable 1.6.0 [INFO] tweaked toml for crates.io crate infinitable 1.6.0 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate infinitable 1.6.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 2 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 59a8370e413e27920a262d182f8c2d157170bd925c35bc41ea50fc630b4f7064 [INFO] running `Command { std: "docker" "start" "-a" "59a8370e413e27920a262d182f8c2d157170bd925c35bc41ea50fc630b4f7064", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "59a8370e413e27920a262d182f8c2d157170bd925c35bc41ea50fc630b4f7064", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "59a8370e413e27920a262d182f8c2d157170bd925c35bc41ea50fc630b4f7064", kill_on_drop: false }` [INFO] [stdout] 59a8370e413e27920a262d182f8c2d157170bd925c35bc41ea50fc630b4f7064 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8586650d3d793c47d2a7b5566c4ec5ddddee9aec84a89dd3d743576adacbd004 [INFO] running `Command { std: "docker" "start" "-a" "8586650d3d793c47d2a7b5566c4ec5ddddee9aec84a89dd3d743576adacbd004", kill_on_drop: false }` [INFO] [stderr] Checking infinitable v1.6.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/lib.rs:67:9 [INFO] [stdout] | [INFO] [stdout] 67 | / match self { [INFO] [stdout] 68 | | Finite(_) => true, [INFO] [stdout] 69 | | _ => false, [INFO] [stdout] 70 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 67 - match self { [INFO] [stdout] 68 - Finite(_) => true, [INFO] [stdout] 69 - _ => false, [INFO] [stdout] 70 - } [INFO] [stdout] 67 + matches!(self, Finite(_)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has a `#[must_use]` attribute with no message, but returns a type already marked as `#[must_use]` [INFO] [stdout] --> src/lib.rs:217:5 [INFO] [stdout] | [INFO] [stdout] 217 | pub fn try_convert_into(self) -> Result, T::Error> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: either add some descriptive message or remove the attribute [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_must_use [INFO] [stdout] = note: `#[warn(clippy::double_must_use)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/lib.rs:67:9 [INFO] [stdout] | [INFO] [stdout] 67 | / match self { [INFO] [stdout] 68 | | Finite(_) => true, [INFO] [stdout] 69 | | _ => false, [INFO] [stdout] 70 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 67 - match self { [INFO] [stdout] 68 - Finite(_) => true, [INFO] [stdout] 69 - _ => false, [INFO] [stdout] 70 - } [INFO] [stdout] 67 + matches!(self, Finite(_)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has a `#[must_use]` attribute with no message, but returns a type already marked as `#[must_use]` [INFO] [stdout] --> src/lib.rs:217:5 [INFO] [stdout] | [INFO] [stdout] 217 | pub fn try_convert_into(self) -> Result, T::Error> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: either add some descriptive message or remove the attribute [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_must_use [INFO] [stdout] = note: `#[warn(clippy::double_must_use)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> tests/test.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 15 | assert!(false, "Not finite?"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] = note: `#[warn(clippy::assertions_on_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> tests/test.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | assert!(false, "Not finite?"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/test.rs:43:13 [INFO] [stdout] | [INFO] [stdout] 43 | assert!(!(ZERO > ONE)); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `(ZERO <= ONE)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/test.rs:44:13 [INFO] [stdout] | [INFO] [stdout] 44 | assert!(!(ZERO >= ONE)); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `(ZERO < ONE)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/test.rs:45:13 [INFO] [stdout] | [INFO] [stdout] 45 | assert!(!(ONE < ZERO)); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `(ONE >= ZERO)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/test.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | assert!(!(ONE <= ZERO)); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `(ONE > ZERO)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/test.rs:57:13 [INFO] [stdout] | [INFO] [stdout] 57 | assert!(!(INF != INF)); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `(INF == INF)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.47s [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/test.rs:58:13 [INFO] [stdout] | [INFO] [stdout] 58 | assert!(!(NEGINF != NEGINF)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(NEGINF == NEGINF)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/test.rs:60:13 [INFO] [stdout] | [INFO] [stdout] 60 | assert!(!(INF == NEGINF)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `(INF != NEGINF)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/test.rs:62:13 [INFO] [stdout] | [INFO] [stdout] 62 | assert!(!(NEGINF == INF)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `(NEGINF != INF)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/test.rs:65:13 [INFO] [stdout] | [INFO] [stdout] 65 | assert!(!(INF == ZERO)); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `(INF != ZERO)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/test.rs:67:13 [INFO] [stdout] | [INFO] [stdout] 67 | assert!(!(ZERO == INF)); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `(ZERO != INF)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/test.rs:82:13 [INFO] [stdout] | [INFO] [stdout] 82 | assert!(!(INF < ONE)); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `(INF >= ONE)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/test.rs:83:13 [INFO] [stdout] | [INFO] [stdout] 83 | assert!(!(INF <= ONE)); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `(INF > ONE)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/test.rs:84:13 [INFO] [stdout] | [INFO] [stdout] 84 | assert!(!(INF < NEGINF)); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `(INF >= NEGINF)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/test.rs:85:13 [INFO] [stdout] | [INFO] [stdout] 85 | assert!(!(INF <= NEGINF)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `(INF > NEGINF)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/test.rs:86:13 [INFO] [stdout] | [INFO] [stdout] 86 | assert!(!(ONE > INF)); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `(ONE <= INF)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/test.rs:87:13 [INFO] [stdout] | [INFO] [stdout] 87 | assert!(!(ONE >= INF)); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `(ONE < INF)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/test.rs:88:13 [INFO] [stdout] | [INFO] [stdout] 88 | assert!(!(NEGINF > INF)); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `(NEGINF <= INF)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/test.rs:89:13 [INFO] [stdout] | [INFO] [stdout] 89 | assert!(!(NEGINF >= INF)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `(NEGINF < INF)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/test.rs:103:13 [INFO] [stdout] | [INFO] [stdout] 103 | assert!(!(NEGINF > ZERO)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `(NEGINF <= ZERO)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/test.rs:104:13 [INFO] [stdout] | [INFO] [stdout] 104 | assert!(!(NEGINF >= ZERO)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `(NEGINF < ZERO)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/test.rs:105:13 [INFO] [stdout] | [INFO] [stdout] 105 | assert!(!(NEGINF > INF)); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `(NEGINF <= INF)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/test.rs:106:13 [INFO] [stdout] | [INFO] [stdout] 106 | assert!(!(NEGINF >= INF)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `(NEGINF < INF)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/test.rs:107:13 [INFO] [stdout] | [INFO] [stdout] 107 | assert!(!(ZERO < NEGINF)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `(ZERO >= NEGINF)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/test.rs:108:13 [INFO] [stdout] | [INFO] [stdout] 108 | assert!(!(ZERO <= NEGINF)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `(ZERO > NEGINF)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/test.rs:109:13 [INFO] [stdout] | [INFO] [stdout] 109 | assert!(!(INF < NEGINF)); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `(INF >= NEGINF)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/test.rs:110:13 [INFO] [stdout] | [INFO] [stdout] 110 | assert!(!(INF <= NEGINF)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `(INF > NEGINF)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "8586650d3d793c47d2a7b5566c4ec5ddddee9aec84a89dd3d743576adacbd004", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8586650d3d793c47d2a7b5566c4ec5ddddee9aec84a89dd3d743576adacbd004", kill_on_drop: false }` [INFO] [stdout] 8586650d3d793c47d2a7b5566c4ec5ddddee9aec84a89dd3d743576adacbd004