[INFO] fetching crate inbq 0.17.2... [INFO] linting inbq-0.17.2 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate inbq 0.17.2 into /workspace/builds/worker-6-tc1/source [INFO] started tweaking crates.io crate inbq 0.17.2 [INFO] finished tweaking crates.io crate inbq 0.17.2 [INFO] tweaked toml for crates.io crate inbq 0.17.2 written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate inbq 0.17.2 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate inbq 0.17.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded serde_spanned v1.0.3 [INFO] [stderr] Downloaded anstyle-wincon v3.0.7 [INFO] [stderr] Downloaded clap_lex v0.7.4 [INFO] [stderr] Downloaded env_filter v0.1.3 [INFO] [stderr] Downloaded strum v0.27.2 [INFO] [stderr] Downloaded toml_datetime v0.7.3 [INFO] [stderr] Downloaded toml_writer v1.0.4 [INFO] [stderr] Downloaded strum_macros v0.27.2 [INFO] [stderr] Downloaded crossbeam-deque v0.8.6 [INFO] [stderr] Downloaded toml_parser v1.0.4 [INFO] [stderr] Downloaded toml v0.9.8 [INFO] [stderr] Downloaded clap_derive v4.5.49 [INFO] [stderr] Downloaded portable-atomic-util v0.2.4 [INFO] [stderr] Downloaded env_logger v0.11.8 [INFO] [stderr] Downloaded log v0.4.28 [INFO] [stderr] Downloaded crossbeam-utils v0.8.21 [INFO] [stderr] Downloaded jiff-static v0.2.13 [INFO] [stderr] Downloaded clap v4.5.51 [INFO] [stderr] Downloaded rayon-core v1.13.0 [INFO] [stderr] Downloaded indexmap v2.12.0 [INFO] [stderr] Downloaded hashbrown v0.16.0 [INFO] [stderr] Downloaded winnow v0.7.13 [INFO] [stderr] Downloaded clap_builder v4.5.51 [INFO] [stderr] Downloaded rayon v1.11.0 [INFO] [stderr] Downloaded portable-atomic v1.11.0 [INFO] [stderr] Downloaded serde_json v1.0.145 [INFO] [stderr] Downloaded syn v2.0.108 [INFO] [stderr] Downloaded regex-automata v0.4.9 [INFO] [stderr] Downloaded jiff v0.2.13 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f2bea313bbedc662e3d7326391da3cb196e3f7ca3fe1562f544d97a15a4dffc7 [INFO] running `Command { std: "docker" "start" "-a" "f2bea313bbedc662e3d7326391da3cb196e3f7ca3fe1562f544d97a15a4dffc7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f2bea313bbedc662e3d7326391da3cb196e3f7ca3fe1562f544d97a15a4dffc7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f2bea313bbedc662e3d7326391da3cb196e3f7ca3fe1562f544d97a15a4dffc7", kill_on_drop: false }` [INFO] [stdout] f2bea313bbedc662e3d7326391da3cb196e3f7ca3fe1562f544d97a15a4dffc7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a22ad0dc1f8bb563111b5df39b64eabc182ae2cba10b28983f7c5962da9f62d7 [INFO] running `Command { std: "docker" "start" "-a" "a22ad0dc1f8bb563111b5df39b64eabc182ae2cba10b28983f7c5962da9f62d7", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.95 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling unicode-ident v1.0.18 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling crossbeam-utils v0.8.21 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking anstyle-query v1.1.2 [INFO] [stderr] Checking anstyle v1.0.10 [INFO] [stderr] Checking colorchoice v1.0.3 [INFO] [stderr] Checking anstyle-parse v0.2.6 [INFO] [stderr] Checking regex-syntax v0.8.5 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Compiling rayon-core v1.13.0 [INFO] [stderr] Checking anstream v0.6.18 [INFO] [stderr] Checking winnow v0.7.13 [INFO] [stderr] Compiling serde_json v1.0.145 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking clap_lex v0.7.4 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Compiling quote v1.0.40 [INFO] [stderr] Compiling anyhow v1.0.100 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Checking log v0.4.28 [INFO] [stderr] Compiling syn v2.0.108 [INFO] [stderr] Checking crossbeam-deque v0.8.6 [INFO] [stderr] Checking clap_builder v4.5.51 [INFO] [stderr] Checking itoa v1.0.15 [INFO] [stderr] Checking ryu v1.0.20 [INFO] [stderr] Checking equivalent v1.0.2 [INFO] [stderr] Checking toml_writer v1.0.4 [INFO] [stderr] Checking hashbrown v0.16.0 [INFO] [stderr] Checking jiff v0.2.13 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Checking either v1.15.0 [INFO] [stderr] Checking rayon v1.11.0 [INFO] [stderr] Checking bitflags v2.10.0 [INFO] [stderr] Checking strum v0.27.2 [INFO] [stderr] Checking toml_parser v1.0.4 [INFO] [stderr] Checking toml_datetime v0.7.3 [INFO] [stderr] Checking serde_spanned v1.0.3 [INFO] [stderr] Checking indexmap v2.12.0 [INFO] [stderr] Checking toml v0.9.8 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Checking env_filter v0.1.3 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling clap_derive v4.5.49 [INFO] [stderr] Compiling strum_macros v0.27.2 [INFO] [stderr] Checking env_logger v0.11.8 [INFO] [stderr] Checking clap v4.5.51 [INFO] [stderr] Checking inbq v0.17.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/lineage.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | mod lineage; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lineage/lineage.rs:1739:13 [INFO] [stdout] | [INFO] [stdout] 1739 | return Ok(node_idx); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1739 - return Ok(node_idx); [INFO] [stdout] 1739 + Ok(node_idx) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lineage/lineage.rs:1741:13 [INFO] [stdout] | [INFO] [stdout] 1741 | / return Err(anyhow!(GetColumnError::NotFound(format!( [INFO] [stdout] 1742 | | "Column `{}` not found in context.", [INFO] [stdout] 1743 | | column [INFO] [stdout] 1744 | | )))); [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1741 ~ Err(anyhow!(GetColumnError::NotFound(format!( [INFO] [stdout] 1742 + "Column `{}` not found in context.", [INFO] [stdout] 1743 + column [INFO] [stdout] 1744 ~ )))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lineage/lineage.rs:1674:13 [INFO] [stdout] | [INFO] [stdout] 1674 | / if let Some(selected_columns) = self.curr_selected_columns() { [INFO] [stdout] 1675 | | if let Some(node_idx) = selected_columns.get(&column) { [INFO] [stdout] 1676 | | return Ok(*node_idx); [INFO] [stdout] 1677 | | } [INFO] [stdout] 1678 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1674 ~ if let Some(selected_columns) = self.curr_selected_columns() [INFO] [stdout] 1675 ~ && let Some(node_idx) = selected_columns.get(&column) { [INFO] [stdout] 1676 | return Ok(*node_idx); [INFO] [stdout] 1677 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lineage/lineage.rs:6937:24 [INFO] [stdout] | [INFO] [stdout] 6937 | && !lineage_extractor [INFO] [stdout] | ________________________^ [INFO] [stdout] 6938 | | .context [INFO] [stdout] 6939 | | .last_select_statement [INFO] [stdout] 6940 | | .as_ref() [INFO] [stdout] 6941 | | .is_some_and(|anon_name| *anon_name == *obj_name)) [INFO] [stdout] | |_________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 6937 ~ && lineage_extractor [INFO] [stdout] 6938 + .context [INFO] [stdout] 6939 + .last_select_statement [INFO] [stdout] 6940 ~ .as_ref().is_none_or(|anon_name| *anon_name != *obj_name)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/lineage/lineage.rs:6861:26 [INFO] [stdout] | [INFO] [stdout] 6861 | let mut objects: IndexMap< [INFO] [stdout] | __________________________^ [INFO] [stdout] 6862 | | ArenaIndex, [INFO] [stdout] 6863 | | IndexMap>, [INFO] [stdout] 6864 | | > = IndexMap::new(); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser.rs:2774:13 [INFO] [stdout] | [INFO] [stdout] 2774 | / return Err(anyhow!( [INFO] [stdout] 2775 | | self.error(self.peek(), "Expected `ON` or `USING`.") [INFO] [stdout] 2776 | | )); [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 2774 ~ Err(anyhow!( [INFO] [stdout] 2775 + self.error(self.peek(), "Expected `ON` or `USING`.") [INFO] [stdout] 2776 ~ )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/lineage.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | mod lineage; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lineage/lineage.rs:1739:13 [INFO] [stdout] | [INFO] [stdout] 1739 | return Ok(node_idx); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1739 - return Ok(node_idx); [INFO] [stdout] 1739 + Ok(node_idx) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lineage/lineage.rs:1741:13 [INFO] [stdout] | [INFO] [stdout] 1741 | / return Err(anyhow!(GetColumnError::NotFound(format!( [INFO] [stdout] 1742 | | "Column `{}` not found in context.", [INFO] [stdout] 1743 | | column [INFO] [stdout] 1744 | | )))); [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1741 ~ Err(anyhow!(GetColumnError::NotFound(format!( [INFO] [stdout] 1742 + "Column `{}` not found in context.", [INFO] [stdout] 1743 + column [INFO] [stdout] 1744 ~ )))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lineage/lineage.rs:1674:13 [INFO] [stdout] | [INFO] [stdout] 1674 | / if let Some(selected_columns) = self.curr_selected_columns() { [INFO] [stdout] 1675 | | if let Some(node_idx) = selected_columns.get(&column) { [INFO] [stdout] 1676 | | return Ok(*node_idx); [INFO] [stdout] 1677 | | } [INFO] [stdout] 1678 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1674 ~ if let Some(selected_columns) = self.curr_selected_columns() [INFO] [stdout] 1675 ~ && let Some(node_idx) = selected_columns.get(&column) { [INFO] [stdout] 1676 | return Ok(*node_idx); [INFO] [stdout] 1677 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lineage/lineage.rs:6937:24 [INFO] [stdout] | [INFO] [stdout] 6937 | && !lineage_extractor [INFO] [stdout] | ________________________^ [INFO] [stdout] 6938 | | .context [INFO] [stdout] 6939 | | .last_select_statement [INFO] [stdout] 6940 | | .as_ref() [INFO] [stdout] 6941 | | .is_some_and(|anon_name| *anon_name == *obj_name)) [INFO] [stdout] | |_________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 6937 ~ && lineage_extractor [INFO] [stdout] 6938 + .context [INFO] [stdout] 6939 + .last_select_statement [INFO] [stdout] 6940 ~ .as_ref().is_none_or(|anon_name| *anon_name != *obj_name)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/lineage/lineage.rs:6861:26 [INFO] [stdout] | [INFO] [stdout] 6861 | let mut objects: IndexMap< [INFO] [stdout] | __________________________^ [INFO] [stdout] 6862 | | ArenaIndex, [INFO] [stdout] 6863 | | IndexMap>, [INFO] [stdout] 6864 | | > = IndexMap::new(); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser.rs:2774:13 [INFO] [stdout] | [INFO] [stdout] 2774 | / return Err(anyhow!( [INFO] [stdout] 2775 | | self.error(self.peek(), "Expected `ON` or `USING`.") [INFO] [stdout] 2776 | | )); [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 2774 ~ Err(anyhow!( [INFO] [stdout] 2775 + self.error(self.peek(), "Expected `ON` or `USING`.") [INFO] [stdout] 2776 ~ )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 53.79s [INFO] running `Command { std: "docker" "inspect" "a22ad0dc1f8bb563111b5df39b64eabc182ae2cba10b28983f7c5962da9f62d7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a22ad0dc1f8bb563111b5df39b64eabc182ae2cba10b28983f7c5962da9f62d7", kill_on_drop: false }` [INFO] [stdout] a22ad0dc1f8bb563111b5df39b64eabc182ae2cba10b28983f7c5962da9f62d7