[INFO] fetching crate id-card 0.1.3... [INFO] linting id-card-0.1.3 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate id-card 0.1.3 into /workspace/builds/worker-7-tc1/source [INFO] started tweaking crates.io crate id-card 0.1.3 [INFO] finished tweaking crates.io crate id-card 0.1.3 [INFO] tweaked toml for crates.io crate id-card 0.1.3 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate id-card 0.1.3 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 45 packages to latest compatible versions [INFO] [stderr] Adding rand v0.8.5 (available: v0.10.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 37a94d6ed9fcb28d0525e68faa399147d74da8ab542c5bd4248326bed4f9c58c [INFO] running `Command { std: "docker" "start" "-a" "37a94d6ed9fcb28d0525e68faa399147d74da8ab542c5bd4248326bed4f9c58c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "37a94d6ed9fcb28d0525e68faa399147d74da8ab542c5bd4248326bed4f9c58c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "37a94d6ed9fcb28d0525e68faa399147d74da8ab542c5bd4248326bed4f9c58c", kill_on_drop: false }` [INFO] [stdout] 37a94d6ed9fcb28d0525e68faa399147d74da8ab542c5bd4248326bed4f9c58c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 499047bea49b9370d854a622310abc756ff617ecb7f9486e4d9f30334681a309 [INFO] running `Command { std: "docker" "start" "-a" "499047bea49b9370d854a622310abc756ff617ecb7f9486e4d9f30334681a309", kill_on_drop: false }` [INFO] [stderr] Checking id-card v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/region/mod.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 17 | assert_eq!(validate_code("640000"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 17 - assert_eq!(validate_code("640000"), true); [INFO] [stdout] 17 + assert!(validate_code("640000")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/region/mod.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | assert_eq!(validate_code("649999"), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 18 - assert_eq!(validate_code("649999"), false); [INFO] [stdout] 18 + assert!(!validate_code("649999")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:23:8 [INFO] [stdout] | [INFO] [stdout] 23 | if !birth_date.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `birth_date.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 41 | return verify_code_expected[modulo as usize] == check_code.to_ascii_uppercase(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 41 - return verify_code_expected[modulo as usize] == check_code.to_ascii_uppercase(); [INFO] [stdout] 41 + verify_code_expected[modulo as usize] == check_code.to_ascii_uppercase() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/lib.rs:13:8 [INFO] [stdout] | [INFO] [stdout] 13 | if id_pattern.is_match(id_number) == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!id_pattern.is_match(id_number)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:23:8 [INFO] [stdout] | [INFO] [stdout] 23 | if !birth_date.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `birth_date.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 41 | return verify_code_expected[modulo as usize] == check_code.to_ascii_uppercase(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 41 - return verify_code_expected[modulo as usize] == check_code.to_ascii_uppercase(); [INFO] [stdout] 41 + verify_code_expected[modulo as usize] == check_code.to_ascii_uppercase() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/lib.rs:13:8 [INFO] [stdout] | [INFO] [stdout] 13 | if id_pattern.is_match(id_number) == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!id_pattern.is_match(id_number)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/tests.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | assert_eq!(id_card_number::validate("440524188001010014"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 5 - assert_eq!(id_card_number::validate("440524188001010014"), true); [INFO] [stdout] 5 + assert!(id_card_number::validate("440524188001010014")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/tests.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | assert_eq!(id_card_number::validate("11010519491231002x"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 6 - assert_eq!(id_card_number::validate("11010519491231002x"), true); [INFO] [stdout] 6 + assert!(id_card_number::validate("11010519491231002x")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/tests.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | assert_eq!(id_card_number::validate("11010519491231002X"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 7 - assert_eq!(id_card_number::validate("11010519491231002X"), true); [INFO] [stdout] 7 + assert!(id_card_number::validate("11010519491231002X")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/tests.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | assert_eq!(id_card_number::validate("440524188001010018"), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 12 - assert_eq!(id_card_number::validate("440524188001010018"), false); [INFO] [stdout] 12 + assert!(!id_card_number::validate("440524188001010018")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/tests.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | assert_eq!(id_card_number::validate("110105194912310020"), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 13 - assert_eq!(id_card_number::validate("110105194912310020"), false); [INFO] [stdout] 13 + assert!(!id_card_number::validate("110105194912310020")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/tests.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | assert_eq!(id_card_number::validate("a40524188001010y14"), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 18 - assert_eq!(id_card_number::validate("a40524188001010y14"), false); [INFO] [stdout] 18 + assert!(!id_card_number::validate("a40524188001010y14")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/tests.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | assert_eq!(id_card_number::validate("a40524188001010游42"), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 19 - assert_eq!(id_card_number::validate("a40524188001010游42"), false); [INFO] [stdout] 19 + assert!(!id_card_number::validate("a40524188001010游42")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/tests.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | assert_eq!(id_card_number::validate("游40524188001010014'"), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 20 - assert_eq!(id_card_number::validate("游40524188001010014'"), false); [INFO] [stdout] 20 + assert!(!id_card_number::validate("游40524188001010014'")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/tests.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | assert_eq!(id_card_number::validate("449994188001010014"), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 25 - assert_eq!(id_card_number::validate("449994188001010014"), false); [INFO] [stdout] 25 + assert!(!id_card_number::validate("449994188001010014")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/tests.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | assert_eq!(id_card_number::validate("449994188002290014"), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 30 - assert_eq!(id_card_number::validate("449994188002290014"), false); [INFO] [stdout] 30 + assert!(!id_card_number::validate("449994188002290014")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.50s [INFO] running `Command { std: "docker" "inspect" "499047bea49b9370d854a622310abc756ff617ecb7f9486e4d9f30334681a309", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "499047bea49b9370d854a622310abc756ff617ecb7f9486e4d9f30334681a309", kill_on_drop: false }` [INFO] [stdout] 499047bea49b9370d854a622310abc756ff617ecb7f9486e4d9f30334681a309