[INFO] fetching crate iced_spatial_navigation 0.4.0... [INFO] linting iced_spatial_navigation-0.4.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate iced_spatial_navigation 0.4.0 into /workspace/builds/worker-7-tc1/source [INFO] started tweaking crates.io crate iced_spatial_navigation 0.4.0 [INFO] finished tweaking crates.io crate iced_spatial_navigation 0.4.0 [INFO] tweaked toml for crates.io crate iced_spatial_navigation 0.4.0 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate iced_spatial_navigation 0.4.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate iced_spatial_navigation 0.4.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded vector-x v0.1.3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2d0d2451c3a6353452507620df2d4db83f08248d1668647c4fa34e5c647fa038 [INFO] running `Command { std: "docker" "start" "-a" "2d0d2451c3a6353452507620df2d4db83f08248d1668647c4fa34e5c647fa038", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2d0d2451c3a6353452507620df2d4db83f08248d1668647c4fa34e5c647fa038", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2d0d2451c3a6353452507620df2d4db83f08248d1668647c4fa34e5c647fa038", kill_on_drop: false }` [INFO] [stdout] 2d0d2451c3a6353452507620df2d4db83f08248d1668647c4fa34e5c647fa038 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0e12b8d0358a6fde1a5e73adab8d9e0d0dc198ad03b09f93d9b90d0d80204add [INFO] running `Command { std: "docker" "start" "-a" "0e12b8d0358a6fde1a5e73adab8d9e0d0dc198ad03b09f93d9b90d0d80204add", kill_on_drop: false }` [INFO] [stderr] Checking rustix v1.1.3 [INFO] [stderr] Compiling cc v1.2.55 [INFO] [stderr] Compiling syn v2.0.114 [INFO] [stderr] Checking wayland-sys v0.31.8 [INFO] [stderr] Compiling crossbeam-utils v0.8.21 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling toml_parser v1.0.6+spec-1.1.0 [INFO] [stderr] Checking bit-vec v0.8.0 [INFO] [stderr] Checking indexmap v2.13.0 [INFO] [stderr] Checking fontdb v0.23.0 [INFO] [stderr] Checking unicode-bidi v0.3.18 [INFO] [stderr] Checking xkeysym v0.2.1 [INFO] [stderr] Checking cursor-icon v1.2.0 [INFO] [stderr] Checking xcursor v0.3.10 [INFO] [stderr] Checking strict-num v0.1.1 [INFO] [stderr] Compiling rustix v0.38.44 [INFO] [stderr] Checking quote v1.0.44 [INFO] [stderr] Checking bit-set v0.8.0 [INFO] [stderr] Compiling wgpu-core v27.0.3 [INFO] [stderr] Checking linux-raw-sys v0.4.15 [INFO] [stderr] Checking euclid v0.22.13 [INFO] [stderr] Compiling wgpu v27.0.1 [INFO] [stderr] Compiling tiny-xlib v0.2.4 [INFO] [stderr] Checking async-task v4.7.1 [INFO] [stderr] Checking svg_fmt v0.4.5 [INFO] [stderr] Compiling endi v1.1.1 [INFO] [stderr] Compiling smithay-client-toolkit v0.20.0 [INFO] [stderr] Compiling smithay-client-toolkit v0.19.2 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking ctor-lite v0.1.1 [INFO] [stderr] Checking piper v0.2.4 [INFO] [stderr] Checking owned_ttf_parser v0.25.1 [INFO] [stderr] Compiling ahash v0.8.12 [INFO] [stderr] Checking lru v0.16.3 [INFO] [stderr] Compiling android-build v0.1.3 [INFO] [stderr] Checking getrandom v0.3.4 [INFO] [stderr] Checking event-listener v5.4.1 [INFO] [stderr] Compiling toml_edit v0.23.10+spec-1.0.0 [INFO] [stderr] Checking ab_glyph v0.2.32 [INFO] [stderr] Checking async-executor v1.13.3 [INFO] [stderr] Checking uuid v1.20.0 [INFO] [stderr] Checking kurbo v0.10.4 [INFO] [stderr] Compiling winit v0.30.12 [INFO] [stderr] Checking event-listener-strategy v0.5.4 [INFO] [stderr] Checking ordered-stream v0.2.0 [INFO] [stderr] Checking etagere v0.2.15 [INFO] [stderr] Checking guillotiere v0.6.2 [INFO] [stderr] Checking x11-dl v2.21.0 [INFO] [stderr] Checking async-channel v2.5.0 [INFO] [stderr] Checking async-lock v3.4.2 [INFO] [stderr] Compiling mundy v0.2.2 [INFO] [stderr] Checking async-broadcast v0.7.2 [INFO] [stderr] Checking blocking v1.6.2 [INFO] [stderr] Checking xkbcommon-dl v0.4.2 [INFO] [stderr] Checking dpi v0.1.2 [INFO] [stderr] Checking vector-x v0.1.3 [INFO] [stderr] Compiling proc-macro-crate v3.4.0 [INFO] [stderr] Compiling wayland-backend v0.3.12 [INFO] [stderr] Checking polling v3.11.0 [INFO] [stderr] Checking gethostname v1.1.0 [INFO] [stderr] Checking x11rb v0.13.2 [INFO] [stderr] Checking async-io v2.6.0 [INFO] [stderr] Checking async-signal v0.2.13 [INFO] [stderr] Checking async-process v2.5.0 [INFO] [stderr] Compiling bytemuck_derive v1.10.2 [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stderr] Compiling zerocopy-derive v0.8.39 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling enumflags2_derive v0.7.12 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling serde_repr v0.1.20 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking wayland-client v0.31.12 [INFO] [stderr] Checking wayland-csd-frame v0.3.0 [INFO] [stderr] Checking bytemuck v1.25.0 [INFO] [stderr] Checking thiserror v2.0.18 [INFO] [stderr] Checking font-types v0.10.1 [INFO] [stderr] Checking iced_core v0.14.0 [INFO] [stderr] Checking wgpu-types v27.0.1 [INFO] [stderr] Checking tiny-skia-path v0.11.4 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking calloop v0.13.0 [INFO] [stderr] Checking zerocopy v0.8.39 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking read-fonts v0.35.0 [INFO] [stderr] Checking tiny-skia v0.11.4 [INFO] [stderr] Checking clipboard_x11 v0.4.3 [INFO] [stderr] Checking calloop v0.14.3 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Checking wayland-protocols v0.32.10 [INFO] [stderr] Checking wayland-cursor v0.31.12 [INFO] [stderr] Checking calloop-wayland-source v0.3.0 [INFO] [stderr] Checking softbuffer v0.4.8 [INFO] [stderr] Checking calloop-wayland-source v0.4.1 [INFO] [stderr] Checking zvariant_utils v3.3.0 [INFO] [stderr] Checking enumflags2 v0.7.12 [INFO] [stderr] Compiling zvariant_derive v5.9.2 [INFO] [stderr] Compiling zvariant v5.9.2 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking iced_futures v0.14.0 [INFO] [stderr] Checking iced_debug v0.14.0 [INFO] [stderr] Checking iced_runtime v0.14.0 [INFO] [stderr] Checking half v2.7.1 [INFO] [stderr] Checking zbus_names v4.3.1 [INFO] [stderr] Checking naga v27.0.3 [INFO] [stderr] Compiling zbus_macros v5.13.2 [INFO] [stderr] Checking wayland-protocols-wlr v0.3.10 [INFO] [stderr] Checking wayland-protocols-experimental v20250721.0.1 [INFO] [stderr] Checking wayland-protocols-misc v0.3.10 [INFO] [stderr] Checking wayland-protocols-plasma v0.3.10 [INFO] [stderr] Checking skrifa v0.37.0 [INFO] [stderr] Checking harfrust v0.3.2 [INFO] [stderr] Checking zbus v5.13.2 [INFO] [stderr] Checking sctk-adwaita v0.10.1 [INFO] [stderr] Checking smithay-clipboard v0.7.3 [INFO] [stderr] Checking swash v0.2.6 [INFO] [stderr] Checking clipboard_wayland v0.2.2 [INFO] [stderr] Checking window_clipboard v0.5.1 [INFO] [stderr] Checking cosmic-text v0.15.0 [INFO] [stderr] Checking wgpu-hal v27.0.4 [INFO] [stderr] Checking iced_graphics v0.14.0 [INFO] [stderr] Checking iced_tiny_skia v0.14.0 [INFO] [stderr] Checking iced_program v0.14.0 [INFO] [stderr] Checking iced_winit v0.14.0 [INFO] [stderr] Checking wgpu-core-deps-windows-linux-android v27.0.0 [INFO] [stderr] Checking cryoglyph v0.1.0 [INFO] [stderr] Checking iced_wgpu v0.14.0 [INFO] [stderr] Checking iced_renderer v0.14.0 [INFO] [stderr] Checking iced_widget v0.14.2 [INFO] [stderr] Checking iced v0.14.0 [INFO] [stderr] Checking iced_spatial_navigation v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/environment.rs:16:13 [INFO] [stdout] | [INFO] [stdout] 16 | grid: grid, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `grid` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `marker::PhantomData` [INFO] [stdout] --> src/grid.rs:1:21 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{any::Any, marker::PhantomData}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/position.rs:14:13 [INFO] [stdout] | [INFO] [stdout] 14 | x: x, [INFO] [stdout] | ^^^^ help: replace it with: `x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/position.rs:15:13 [INFO] [stdout] | [INFO] [stdout] 15 | y: y [INFO] [stdout] | ^^^^ help: replace it with: `y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/environment.rs:16:13 [INFO] [stdout] | [INFO] [stdout] 16 | grid: grid, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `grid` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `marker::PhantomData` [INFO] [stdout] --> src/grid.rs:1:21 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{any::Any, marker::PhantomData}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/position.rs:14:13 [INFO] [stdout] | [INFO] [stdout] 14 | x: x, [INFO] [stdout] | ^^^^ help: replace it with: `x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/position.rs:15:13 [INFO] [stdout] | [INFO] [stdout] 15 | y: y [INFO] [stdout] | ^^^^ help: replace it with: `y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/environment.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 15 | / return Self { [INFO] [stdout] 16 | | grid: grid, [INFO] [stdout] 17 | | render_target: ws.clone(), [INFO] [stdout] 18 | | window_size: ws.clone() [INFO] [stdout] 19 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 15 ~ Self { [INFO] [stdout] 16 + grid: grid, [INFO] [stdout] 17 + render_target: ws.clone(), [INFO] [stdout] 18 + window_size: ws.clone() [INFO] [stdout] 19 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `(f32, f32)` which implements the `Copy` trait [INFO] [stdout] --> src/environment.rs:17:28 [INFO] [stdout] | [INFO] [stdout] 17 | render_target: ws.clone(), [INFO] [stdout] | ^^^^^^^^^^ help: try removing the `clone` call: `ws` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `(f32, f32)` which implements the `Copy` trait [INFO] [stdout] --> src/environment.rs:18:26 [INFO] [stdout] | [INFO] [stdout] 18 | window_size: ws.clone() [INFO] [stdout] | ^^^^^^^^^^ help: try removing the `clone` call: `ws` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/environment.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | return Self::new(|| Grid::new().with_spacing(10.0).with_tile_size(150.0)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return Self::new(|| Grid::new().with_spacing(10.0).with_tile_size(150.0)); [INFO] [stdout] 25 + Self::new(|| Grid::new().with_spacing(10.0).with_tile_size(150.0)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/environment.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | return &self.grid; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 31 - return &self.grid; [INFO] [stdout] 31 + &self.grid [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/environment.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | / return f32::min( [INFO] [stdout] 36 | | self.window_size.0 / self.render_target.0, [INFO] [stdout] 37 | | self.window_size.1 / self.render_target.1 [INFO] [stdout] 38 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 35 ~ f32::min( [INFO] [stdout] 36 + self.window_size.0 / self.render_target.0, [INFO] [stdout] 37 + self.window_size.1 / self.render_target.1 [INFO] [stdout] 38 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/environment.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | return &mut self.grid; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - return &mut self.grid; [INFO] [stdout] 42 + &mut self.grid [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Grid` [INFO] [stdout] --> src/grid.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 52 | / pub fn new() -> Self { [INFO] [stdout] 53 | | return Self { [INFO] [stdout] 54 | | locations: Vec::new(), [INFO] [stdout] 55 | | position: Position::zero(), [INFO] [stdout] ... | [INFO] [stdout] 65 | | }; [INFO] [stdout] 66 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 51 + impl Default for Grid { [INFO] [stdout] 52 + fn default() -> Self { [INFO] [stdout] 53 + Self::new() [INFO] [stdout] 54 + } [INFO] [stdout] 55 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grid.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 53 | / return Self { [INFO] [stdout] 54 | | locations: Vec::new(), [INFO] [stdout] 55 | | position: Position::zero(), [INFO] [stdout] 56 | | tile_size: Vector2::new(0.0, 0.0), [INFO] [stdout] ... | [INFO] [stdout] 64 | | button_container_size: 0.0 [INFO] [stdout] 65 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 53 ~ Self { [INFO] [stdout] 54 + locations: Vec::new(), [INFO] [stdout] 55 + position: Position::zero(), [INFO] [stdout] 56 + tile_size: Vector2::new(0.0, 0.0), [INFO] [stdout] 57 + spacing: Vector2::new(0.0, 0.0), [INFO] [stdout] 58 + container_style_callback: Option::None, [INFO] [stdout] 59 + culling_callback: Option::None, [INFO] [stdout] 60 + button_style_callback: Option::None, [INFO] [stdout] 61 + grid_size: Option::None, [INFO] [stdout] 62 + padding: 0.0, [INFO] [stdout] 63 + scroll_id: Id::unique(), [INFO] [stdout] 64 + button_container_size: 0.0 [INFO] [stdout] 65 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grid.rs:72:9 [INFO] [stdout] | [INFO] [stdout] 72 | return self.with_x_tile_size(tile_size).with_y_tile_size(tile_size); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 72 - return self.with_x_tile_size(tile_size).with_y_tile_size(tile_size); [INFO] [stdout] 72 + self.with_x_tile_size(tile_size).with_y_tile_size(tile_size) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grid.rs:77:9 [INFO] [stdout] | [INFO] [stdout] 77 | return self.with_x_spacing(spacing).with_y_spacing(spacing); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 77 - return self.with_x_spacing(spacing).with_y_spacing(spacing); [INFO] [stdout] 77 + self.with_x_spacing(spacing).with_y_spacing(spacing) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grid.rs:82:9 [INFO] [stdout] | [INFO] [stdout] 82 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 82 - return self; [INFO] [stdout] 82 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grid.rs:87:9 [INFO] [stdout] | [INFO] [stdout] 87 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 87 - return self; [INFO] [stdout] 87 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grid.rs:92:9 [INFO] [stdout] | [INFO] [stdout] 92 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 92 - return self; [INFO] [stdout] 92 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grid.rs:97:9 [INFO] [stdout] | [INFO] [stdout] 97 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 97 - return self; [INFO] [stdout] 97 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grid.rs:102:9 [INFO] [stdout] | [INFO] [stdout] 102 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 102 - return self; [INFO] [stdout] 102 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grid.rs:107:9 [INFO] [stdout] | [INFO] [stdout] 107 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 107 - return self; [INFO] [stdout] 107 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grid.rs:115:9 [INFO] [stdout] | [INFO] [stdout] 115 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 115 - return self; [INFO] [stdout] 115 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grid.rs:123:9 [INFO] [stdout] | [INFO] [stdout] 123 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 123 - return self; [INFO] [stdout] 123 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grid.rs:131:9 [INFO] [stdout] | [INFO] [stdout] 131 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 131 - return self; [INFO] [stdout] 131 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grid.rs:139:9 [INFO] [stdout] | [INFO] [stdout] 139 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 139 - return self; [INFO] [stdout] 139 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grid.rs:143:9 [INFO] [stdout] | [INFO] [stdout] 143 | / return match &self.culling_callback { [INFO] [stdout] 144 | | Option::Some(callback) => callback(self, row_index), [INFO] [stdout] 145 | | Option::None => true [INFO] [stdout] 146 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 143 ~ match &self.culling_callback { [INFO] [stdout] 144 + Option::Some(callback) => callback(self, row_index), [INFO] [stdout] 145 + Option::None => true [INFO] [stdout] 146 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grid.rs:153:9 [INFO] [stdout] | [INFO] [stdout] 153 | / return self.to_element_advanced( [INFO] [stdout] 154 | | true, [INFO] [stdout] 155 | | Option::None [INFO] [stdout] 156 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 153 ~ self.to_element_advanced( [INFO] [stdout] 154 + true, [INFO] [stdout] 155 + Option::None [INFO] [stdout] 156 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grid.rs:254:9 [INFO] [stdout] | [INFO] [stdout] 254 | / return container(content) [INFO] [stdout] 255 | | .padding(Padding::new(self.padding)) [INFO] [stdout] 256 | | .into(); [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 254 ~ container(content) [INFO] [stdout] 255 + .padding(Padding::new(self.padding)) [INFO] [stdout] 256 ~ .into() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grid.rs:192:29 [INFO] [stdout] | [INFO] [stdout] 192 | / ... return match &self.button_style_callback { [INFO] [stdout] 193 | | ... Option::Some(cb) => cb( [INFO] [stdout] 194 | | ... self, c, r, [INFO] [stdout] 195 | | ... t, s, button [INFO] [stdout] 196 | | ... ), [INFO] [stdout] 197 | | ... Option::None => ButtonStyle::default() [INFO] [stdout] 198 | | ... }; [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 192 ~ match &self.button_style_callback { [INFO] [stdout] 193 + Option::Some(cb) => cb( [INFO] [stdout] 194 + self, c, r, [INFO] [stdout] 195 + t, s, button [INFO] [stdout] 196 + ), [INFO] [stdout] 197 + Option::None => ButtonStyle::default() [INFO] [stdout] 198 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grid.rs:205:29 [INFO] [stdout] | [INFO] [stdout] 205 | / ... return match &self.container_style_callback { [INFO] [stdout] 206 | | ... Option::Some(callback) => callback( [INFO] [stdout] 207 | | ... self, [INFO] [stdout] 208 | | ... c, r, [INFO] [stdout] ... | [INFO] [stdout] 211 | | ... Option::None => ContainerStyle::default() [INFO] [stdout] 212 | | ... }; [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 205 ~ match &self.container_style_callback { [INFO] [stdout] 206 + Option::Some(callback) => callback( [INFO] [stdout] 207 + self, [INFO] [stdout] 208 + c, r, [INFO] [stdout] 209 + t, button [INFO] [stdout] 210 + ), [INFO] [stdout] 211 + Option::None => ContainerStyle::default() [INFO] [stdout] 212 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grid.rs:263:9 [INFO] [stdout] | [INFO] [stdout] 263 | / return self.move_on_grid_with_callback(dir, [INFO] [stdout] 264 | | |_, _, _, _| Task::none() [INFO] [stdout] 265 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 263 ~ self.move_on_grid_with_callback(dir, [INFO] [stdout] 264 + |_, _, _, _| Task::none() [INFO] [stdout] 265 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grid.rs:328:9 [INFO] [stdout] | [INFO] [stdout] 328 | / return callback( [INFO] [stdout] 329 | | &self, dir, [INFO] [stdout] 330 | | &self.locations[self.position.y][self.position.x], [INFO] [stdout] 331 | | Vector2::new(old_position, self.position) [INFO] [stdout] 332 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 328 ~ callback( [INFO] [stdout] 329 + &self, dir, [INFO] [stdout] 330 + &self.locations[self.position.y][self.position.x], [INFO] [stdout] 331 + Vector2::new(old_position, self.position) [INFO] [stdout] 332 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/grid.rs:329:13 [INFO] [stdout] | [INFO] [stdout] 329 | &self, dir, [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/message.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | / return match self { [INFO] [stdout] 22 | | Self::Custom(cm) => Option::Some(cm), [INFO] [stdout] 23 | | _ => Option::None [INFO] [stdout] 24 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 ~ match self { [INFO] [stdout] 22 + Self::Custom(cm) => Option::Some(cm), [INFO] [stdout] 23 + _ => Option::None [INFO] [stdout] 24 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/position.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | / return Self { [INFO] [stdout] 14 | | x: x, [INFO] [stdout] 15 | | y: y [INFO] [stdout] 16 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 13 ~ Self { [INFO] [stdout] 14 + x: x, [INFO] [stdout] 15 + y: y [INFO] [stdout] 16 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/position.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | return Self::new(0, 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 20 - return Self::new(0, 0); [INFO] [stdout] 20 + Self::new(0, 0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/position.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | return self.x == other.x && self.y == other.y; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 26 - return self.x == other.x && self.y == other.y; [INFO] [stdout] 26 + self.x == other.x && self.y == other.y [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/position.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | return write!(f, "[x: {}, y: {}]", self.x, self.y); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 - return write!(f, "[x: {}, y: {}]", self.x, self.y); [INFO] [stdout] 32 + write!(f, "[x: {}, y: {}]", self.x, self.y) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/position.rs:36:1 [INFO] [stdout] | [INFO] [stdout] 36 | impl Into> for Position { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: `impl From for Foreign` is allowed by the orphan rules, for more information see [INFO] [stdout] https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: `#[warn(clippy::from_over_into)]` on by default [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 36 ~ impl From for Vector2 { [INFO] [stdout] 37 ~ fn from(val: Position) -> Self { [INFO] [stdout] 38 ~ return Vector2::new(val.x, val.y); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/position.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 38 | return Vector2::new(self.x, self.y); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 38 - return Vector2::new(self.x, self.y); [INFO] [stdout] 38 + Vector2::new(self.x, self.y) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/position.rs:42:1 [INFO] [stdout] | [INFO] [stdout] 42 | impl Into for Vector2 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] help: replace the `Into` implementation with `From>` [INFO] [stdout] | [INFO] [stdout] 42 ~ impl From> for Position { [INFO] [stdout] 43 ~ fn from(val: Vector2) -> Self { [INFO] [stdout] 44 ~ let (x, y) = val.into(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/position.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | return Position::new(x, y); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 45 - return Position::new(x, y); [INFO] [stdout] 45 + Position::new(x, y) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/environment.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 15 | / return Self { [INFO] [stdout] 16 | | grid: grid, [INFO] [stdout] 17 | | render_target: ws.clone(), [INFO] [stdout] 18 | | window_size: ws.clone() [INFO] [stdout] 19 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 15 ~ Self { [INFO] [stdout] 16 + grid: grid, [INFO] [stdout] 17 + render_target: ws.clone(), [INFO] [stdout] 18 + window_size: ws.clone() [INFO] [stdout] 19 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `(f32, f32)` which implements the `Copy` trait [INFO] [stdout] --> src/environment.rs:17:28 [INFO] [stdout] | [INFO] [stdout] 17 | render_target: ws.clone(), [INFO] [stdout] | ^^^^^^^^^^ help: try removing the `clone` call: `ws` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `(f32, f32)` which implements the `Copy` trait [INFO] [stdout] --> src/environment.rs:18:26 [INFO] [stdout] | [INFO] [stdout] 18 | window_size: ws.clone() [INFO] [stdout] | ^^^^^^^^^^ help: try removing the `clone` call: `ws` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/environment.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | return Self::new(|| Grid::new().with_spacing(10.0).with_tile_size(150.0)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return Self::new(|| Grid::new().with_spacing(10.0).with_tile_size(150.0)); [INFO] [stdout] 25 + Self::new(|| Grid::new().with_spacing(10.0).with_tile_size(150.0)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/environment.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | return &self.grid; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 31 - return &self.grid; [INFO] [stdout] 31 + &self.grid [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/environment.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | / return f32::min( [INFO] [stdout] 36 | | self.window_size.0 / self.render_target.0, [INFO] [stdout] 37 | | self.window_size.1 / self.render_target.1 [INFO] [stdout] 38 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 35 ~ f32::min( [INFO] [stdout] 36 + self.window_size.0 / self.render_target.0, [INFO] [stdout] 37 + self.window_size.1 / self.render_target.1 [INFO] [stdout] 38 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/environment.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | return &mut self.grid; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - return &mut self.grid; [INFO] [stdout] 42 + &mut self.grid [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Grid` [INFO] [stdout] --> src/grid.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 52 | / pub fn new() -> Self { [INFO] [stdout] 53 | | return Self { [INFO] [stdout] 54 | | locations: Vec::new(), [INFO] [stdout] 55 | | position: Position::zero(), [INFO] [stdout] ... | [INFO] [stdout] 65 | | }; [INFO] [stdout] 66 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 51 + impl Default for Grid { [INFO] [stdout] 52 + fn default() -> Self { [INFO] [stdout] 53 + Self::new() [INFO] [stdout] 54 + } [INFO] [stdout] 55 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grid.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 53 | / return Self { [INFO] [stdout] 54 | | locations: Vec::new(), [INFO] [stdout] 55 | | position: Position::zero(), [INFO] [stdout] 56 | | tile_size: Vector2::new(0.0, 0.0), [INFO] [stdout] ... | [INFO] [stdout] 64 | | button_container_size: 0.0 [INFO] [stdout] 65 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 53 ~ Self { [INFO] [stdout] 54 + locations: Vec::new(), [INFO] [stdout] 55 + position: Position::zero(), [INFO] [stdout] 56 + tile_size: Vector2::new(0.0, 0.0), [INFO] [stdout] 57 + spacing: Vector2::new(0.0, 0.0), [INFO] [stdout] 58 + container_style_callback: Option::None, [INFO] [stdout] 59 + culling_callback: Option::None, [INFO] [stdout] 60 + button_style_callback: Option::None, [INFO] [stdout] 61 + grid_size: Option::None, [INFO] [stdout] 62 + padding: 0.0, [INFO] [stdout] 63 + scroll_id: Id::unique(), [INFO] [stdout] 64 + button_container_size: 0.0 [INFO] [stdout] 65 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grid.rs:72:9 [INFO] [stdout] | [INFO] [stdout] 72 | return self.with_x_tile_size(tile_size).with_y_tile_size(tile_size); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 72 - return self.with_x_tile_size(tile_size).with_y_tile_size(tile_size); [INFO] [stdout] 72 + self.with_x_tile_size(tile_size).with_y_tile_size(tile_size) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grid.rs:77:9 [INFO] [stdout] | [INFO] [stdout] 77 | return self.with_x_spacing(spacing).with_y_spacing(spacing); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 77 - return self.with_x_spacing(spacing).with_y_spacing(spacing); [INFO] [stdout] 77 + self.with_x_spacing(spacing).with_y_spacing(spacing) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grid.rs:82:9 [INFO] [stdout] | [INFO] [stdout] 82 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 82 - return self; [INFO] [stdout] 82 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grid.rs:87:9 [INFO] [stdout] | [INFO] [stdout] 87 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 87 - return self; [INFO] [stdout] 87 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grid.rs:92:9 [INFO] [stdout] | [INFO] [stdout] 92 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 92 - return self; [INFO] [stdout] 92 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grid.rs:97:9 [INFO] [stdout] | [INFO] [stdout] 97 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 97 - return self; [INFO] [stdout] 97 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grid.rs:102:9 [INFO] [stdout] | [INFO] [stdout] 102 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 102 - return self; [INFO] [stdout] 102 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grid.rs:107:9 [INFO] [stdout] | [INFO] [stdout] 107 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 107 - return self; [INFO] [stdout] 107 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grid.rs:115:9 [INFO] [stdout] | [INFO] [stdout] 115 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 115 - return self; [INFO] [stdout] 115 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grid.rs:123:9 [INFO] [stdout] | [INFO] [stdout] 123 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 123 - return self; [INFO] [stdout] 123 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grid.rs:131:9 [INFO] [stdout] | [INFO] [stdout] 131 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 131 - return self; [INFO] [stdout] 131 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grid.rs:139:9 [INFO] [stdout] | [INFO] [stdout] 139 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 139 - return self; [INFO] [stdout] 139 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grid.rs:143:9 [INFO] [stdout] | [INFO] [stdout] 143 | / return match &self.culling_callback { [INFO] [stdout] 144 | | Option::Some(callback) => callback(self, row_index), [INFO] [stdout] 145 | | Option::None => true [INFO] [stdout] 146 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 143 ~ match &self.culling_callback { [INFO] [stdout] 144 + Option::Some(callback) => callback(self, row_index), [INFO] [stdout] 145 + Option::None => true [INFO] [stdout] 146 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grid.rs:153:9 [INFO] [stdout] | [INFO] [stdout] 153 | / return self.to_element_advanced( [INFO] [stdout] 154 | | true, [INFO] [stdout] 155 | | Option::None [INFO] [stdout] 156 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 153 ~ self.to_element_advanced( [INFO] [stdout] 154 + true, [INFO] [stdout] 155 + Option::None [INFO] [stdout] 156 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grid.rs:254:9 [INFO] [stdout] | [INFO] [stdout] 254 | / return container(content) [INFO] [stdout] 255 | | .padding(Padding::new(self.padding)) [INFO] [stdout] 256 | | .into(); [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 254 ~ container(content) [INFO] [stdout] 255 + .padding(Padding::new(self.padding)) [INFO] [stdout] 256 ~ .into() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grid.rs:192:29 [INFO] [stdout] | [INFO] [stdout] 192 | / ... return match &self.button_style_callback { [INFO] [stdout] 193 | | ... Option::Some(cb) => cb( [INFO] [stdout] 194 | | ... self, c, r, [INFO] [stdout] 195 | | ... t, s, button [INFO] [stdout] 196 | | ... ), [INFO] [stdout] 197 | | ... Option::None => ButtonStyle::default() [INFO] [stdout] 198 | | ... }; [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 192 ~ match &self.button_style_callback { [INFO] [stdout] 193 + Option::Some(cb) => cb( [INFO] [stdout] 194 + self, c, r, [INFO] [stdout] 195 + t, s, button [INFO] [stdout] 196 + ), [INFO] [stdout] 197 + Option::None => ButtonStyle::default() [INFO] [stdout] 198 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grid.rs:205:29 [INFO] [stdout] | [INFO] [stdout] 205 | / ... return match &self.container_style_callback { [INFO] [stdout] 206 | | ... Option::Some(callback) => callback( [INFO] [stdout] 207 | | ... self, [INFO] [stdout] 208 | | ... c, r, [INFO] [stdout] ... | [INFO] [stdout] 211 | | ... Option::None => ContainerStyle::default() [INFO] [stdout] 212 | | ... }; [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 205 ~ match &self.container_style_callback { [INFO] [stdout] 206 + Option::Some(callback) => callback( [INFO] [stdout] 207 + self, [INFO] [stdout] 208 + c, r, [INFO] [stdout] 209 + t, button [INFO] [stdout] 210 + ), [INFO] [stdout] 211 + Option::None => ContainerStyle::default() [INFO] [stdout] 212 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grid.rs:263:9 [INFO] [stdout] | [INFO] [stdout] 263 | / return self.move_on_grid_with_callback(dir, [INFO] [stdout] 264 | | |_, _, _, _| Task::none() [INFO] [stdout] 265 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 263 ~ self.move_on_grid_with_callback(dir, [INFO] [stdout] 264 + |_, _, _, _| Task::none() [INFO] [stdout] 265 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grid.rs:328:9 [INFO] [stdout] | [INFO] [stdout] 328 | / return callback( [INFO] [stdout] 329 | | &self, dir, [INFO] [stdout] 330 | | &self.locations[self.position.y][self.position.x], [INFO] [stdout] 331 | | Vector2::new(old_position, self.position) [INFO] [stdout] 332 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 328 ~ callback( [INFO] [stdout] 329 + &self, dir, [INFO] [stdout] 330 + &self.locations[self.position.y][self.position.x], [INFO] [stdout] 331 + Vector2::new(old_position, self.position) [INFO] [stdout] 332 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/grid.rs:329:13 [INFO] [stdout] | [INFO] [stdout] 329 | &self, dir, [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/message.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | / return match self { [INFO] [stdout] 22 | | Self::Custom(cm) => Option::Some(cm), [INFO] [stdout] 23 | | _ => Option::None [INFO] [stdout] 24 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 ~ match self { [INFO] [stdout] 22 + Self::Custom(cm) => Option::Some(cm), [INFO] [stdout] 23 + _ => Option::None [INFO] [stdout] 24 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/position.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | / return Self { [INFO] [stdout] 14 | | x: x, [INFO] [stdout] 15 | | y: y [INFO] [stdout] 16 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 13 ~ Self { [INFO] [stdout] 14 + x: x, [INFO] [stdout] 15 + y: y [INFO] [stdout] 16 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/position.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | return Self::new(0, 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 20 - return Self::new(0, 0); [INFO] [stdout] 20 + Self::new(0, 0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 23s [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/position.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | return self.x == other.x && self.y == other.y; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 26 - return self.x == other.x && self.y == other.y; [INFO] [stdout] 26 + self.x == other.x && self.y == other.y [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/position.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | return write!(f, "[x: {}, y: {}]", self.x, self.y); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 - return write!(f, "[x: {}, y: {}]", self.x, self.y); [INFO] [stdout] 32 + write!(f, "[x: {}, y: {}]", self.x, self.y) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/position.rs:36:1 [INFO] [stdout] | [INFO] [stdout] 36 | impl Into> for Position { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: `impl From for Foreign` is allowed by the orphan rules, for more information see [INFO] [stdout] https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: `#[warn(clippy::from_over_into)]` on by default [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 36 ~ impl From for Vector2 { [INFO] [stdout] 37 ~ fn from(val: Position) -> Self { [INFO] [stdout] 38 ~ return Vector2::new(val.x, val.y); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/position.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 38 | return Vector2::new(self.x, self.y); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 38 - return Vector2::new(self.x, self.y); [INFO] [stdout] 38 + Vector2::new(self.x, self.y) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/position.rs:42:1 [INFO] [stdout] | [INFO] [stdout] 42 | impl Into for Vector2 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] help: replace the `Into` implementation with `From>` [INFO] [stdout] | [INFO] [stdout] 42 ~ impl From> for Position { [INFO] [stdout] 43 ~ fn from(val: Vector2) -> Self { [INFO] [stdout] 44 ~ let (x, y) = val.into(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/position.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | return Position::new(x, y); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 45 - return Position::new(x, y); [INFO] [stdout] 45 + Position::new(x, y) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "0e12b8d0358a6fde1a5e73adab8d9e0d0dc198ad03b09f93d9b90d0d80204add", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0e12b8d0358a6fde1a5e73adab8d9e0d0dc198ad03b09f93d9b90d0d80204add", kill_on_drop: false }` [INFO] [stdout] 0e12b8d0358a6fde1a5e73adab8d9e0d0dc198ad03b09f93d9b90d0d80204add