[INFO] fetching crate iceberg-catalog-hadoop-unofficial 0.6.0-alpha.6... [INFO] linting iceberg-catalog-hadoop-unofficial-0.6.0-alpha.6 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate iceberg-catalog-hadoop-unofficial 0.6.0-alpha.6 into /workspace/builds/worker-0-tc1/source [INFO] started tweaking crates.io crate iceberg-catalog-hadoop-unofficial 0.6.0-alpha.6 [INFO] finished tweaking crates.io crate iceberg-catalog-hadoop-unofficial 0.6.0-alpha.6 [INFO] tweaked toml for crates.io crate iceberg-catalog-hadoop-unofficial 0.6.0-alpha.6 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate iceberg-catalog-hadoop-unofficial 0.6.0-alpha.6 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate iceberg-catalog-hadoop-unofficial 0.6.0-alpha.6 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded trim-in-place v0.1.7 [INFO] [stderr] Downloaded bitflags v2.9.2 [INFO] [stderr] Downloaded rust-ini v0.21.1 [INFO] [stderr] Downloaded g2poly v1.2.2 [INFO] [stderr] Downloaded aws-smithy-checksums v0.63.3 [INFO] [stderr] Downloaded aws-smithy-json v0.61.4 [INFO] [stderr] Downloaded twox-hash v2.1.1 [INFO] [stderr] Downloaded aws-credential-types v1.2.5 [INFO] [stderr] Downloaded aws-smithy-xml v0.60.10 [INFO] [stderr] Downloaded aws-smithy-query v0.60.7 [INFO] [stderr] Downloaded aws-smithy-http-client v1.1.0 [INFO] [stderr] Downloaded crc-fast v1.4.0 [INFO] [stderr] Downloaded aws-smithy-runtime v1.9.0 [INFO] [stderr] Downloaded bigdecimal v0.4.8 [INFO] [stderr] Downloaded aws-sdk-ssooidc v1.82.0 [INFO] [stderr] Downloaded aws-sdk-sso v1.81.0 [INFO] [stderr] Downloaded lexical-write-float v1.0.5 [INFO] [stderr] Downloaded lexical-parse-float v1.0.5 [INFO] [stderr] Downloaded hdfs-native v0.11.3 [INFO] [stderr] Downloaded hdfs-native v0.10.4 [INFO] [stderr] Downloaded arrow-array v55.2.0 [INFO] [stderr] Downloaded arrow-cast v55.2.0 [INFO] [stderr] Downloaded lexical-util v1.0.6 [INFO] [stderr] Downloaded arrow-ipc v55.2.0 [INFO] [stderr] Downloaded arrow-buffer v55.2.0 [INFO] [stderr] Downloaded aws-config v1.8.5 [INFO] [stderr] Downloaded aws-sdk-sts v1.83.0 [INFO] [stderr] Downloaded iceberg-unofficial v0.6.0-alpha.6 [INFO] [stderr] Downloaded quick-xml v0.38.1 [INFO] [stderr] Downloaded arrow-schema v55.2.0 [INFO] [stderr] Downloaded lexical-write-integer v1.0.5 [INFO] [stderr] Downloaded libflate v2.1.0 [INFO] [stderr] Downloaded arrow-ord v55.2.0 [INFO] [stderr] Downloaded backon v1.5.2 [INFO] [stderr] Downloaded lexical-parse-integer v1.0.5 [INFO] [stderr] Downloaded parquet v55.2.0 [INFO] [stderr] Downloaded arrow-data v55.2.0 [INFO] [stderr] Downloaded arrow-arith v55.2.0 [INFO] [stderr] Downloaded arrow-string v55.2.0 [INFO] [stderr] Downloaded des v0.8.1 [INFO] [stderr] Downloaded opendal-unofficial v0.54.0-alpha.1 [INFO] [stderr] Downloaded g2p v1.2.2 [INFO] [stderr] Downloaded roaring v0.11.2 [INFO] [stderr] Downloaded dary_heap v0.3.7 [INFO] [stderr] Downloaded libflate_lz77 v2.1.0 [INFO] [stderr] Downloaded dns-lookup v2.1.0 [INFO] [stderr] Downloaded lexical-core v1.0.5 [INFO] [stderr] Downloaded arrow-select v55.2.0 [INFO] [stderr] Downloaded reqsign v0.16.5 [INFO] [stderr] Downloaded murmur3 v0.5.2 [INFO] [stderr] Downloaded crc32c v0.6.8 [INFO] [stderr] Downloaded g2gen v1.2.2 [INFO] [stderr] Downloaded aws-sdk-s3 v1.85.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2f60f4eb5a385d472374ce181e282b9f3851ff70668b37fac79e33f653988c20 [INFO] running `Command { std: "docker" "start" "-a" "2f60f4eb5a385d472374ce181e282b9f3851ff70668b37fac79e33f653988c20", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2f60f4eb5a385d472374ce181e282b9f3851ff70668b37fac79e33f653988c20", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2f60f4eb5a385d472374ce181e282b9f3851ff70668b37fac79e33f653988c20", kill_on_drop: false }` [INFO] [stdout] 2f60f4eb5a385d472374ce181e282b9f3851ff70668b37fac79e33f653988c20 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 86b293e6167d4dc784605954798b4d1f982745be5074b947a1ac4d49475e998c [INFO] running `Command { std: "docker" "start" "-a" "86b293e6167d4dc784605954798b4d1f982745be5074b947a1ac4d49475e998c", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.219 [INFO] [stderr] Compiling libc v0.2.175 [INFO] [stderr] Compiling syn v2.0.106 [INFO] [stderr] Checking socket2 v0.6.0 [INFO] [stderr] Checking signal-hook-registry v1.4.6 [INFO] [stderr] Checking mio v1.0.4 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Checking getrandom v0.3.3 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking time v0.3.41 [INFO] [stderr] Checking indexmap v2.10.0 [INFO] [stderr] Compiling ahash v0.8.12 [INFO] [stderr] Compiling aws-lc-rs v1.13.3 [INFO] [stderr] Checking crc32fast v1.5.0 [INFO] [stderr] Compiling rustls v0.23.31 [INFO] [stderr] Checking socket2 v0.5.10 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling anyhow v1.0.99 [INFO] [stderr] Checking chrono v0.4.41 [INFO] [stderr] Checking rustls-native-certs v0.8.1 [INFO] [stderr] Checking webpki-roots v1.0.2 [INFO] [stderr] Checking der v0.6.1 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking base64ct v1.8.0 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Compiling rustls v0.21.12 [INFO] [stderr] Checking ff v0.12.1 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking crypto-bigint v0.4.9 [INFO] [stderr] Checking half v2.6.0 [INFO] [stderr] Checking group v0.12.1 [INFO] [stderr] Checking block-padding v0.3.3 [INFO] [stderr] Checking arrow-schema v55.2.0 [INFO] [stderr] Checking bitflags v2.9.2 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Checking rustls-native-certs v0.6.3 [INFO] [stderr] Checking inout v0.1.4 [INFO] [stderr] Checking signature v1.6.4 [INFO] [stderr] Checking lexical-util v1.0.6 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking rand_core v0.9.3 [INFO] [stderr] Compiling aws-types v1.3.8 [INFO] [stderr] Compiling jobserver v0.1.33 [INFO] [stderr] Checking crypto-bigint v0.5.5 [INFO] [stderr] Compiling serde_json v1.0.143 [INFO] [stderr] Checking spki v0.6.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking md-5 v0.10.6 [INFO] [stderr] Compiling g2poly v1.2.2 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking lexical-parse-integer v1.0.5 [INFO] [stderr] Checking pkcs8 v0.9.0 [INFO] [stderr] Checking lexical-write-integer v1.0.5 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking sec1 v0.3.0 [INFO] [stderr] Checking rfc6979 v0.3.1 [INFO] [stderr] Compiling flatbuffers v25.2.10 [INFO] [stderr] Compiling const-random-macro v0.1.16 [INFO] [stderr] Compiling thiserror v2.0.15 [INFO] [stderr] Compiling cc v1.2.33 [INFO] [stderr] Checking lexical-parse-float v1.0.5 [INFO] [stderr] Checking event-listener v5.4.1 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking ctr v0.9.2 [INFO] [stderr] Checking lexical-write-float v1.0.5 [INFO] [stderr] Checking des v0.8.1 [INFO] [stderr] Checking cbc v0.1.2 [INFO] [stderr] Checking dns-lookup v2.1.0 [INFO] [stderr] Compiling crc32c v0.6.8 [INFO] [stderr] Checking num_cpus v1.17.0 [INFO] [stderr] Checking elliptic-curve v0.12.3 [INFO] [stderr] Checking libloading v0.8.8 [INFO] [stderr] Checking core2 v0.4.0 [INFO] [stderr] Compiling bigdecimal v0.4.8 [INFO] [stderr] Checking const-random v0.1.18 [INFO] [stderr] Checking rle-decode-fast v1.0.3 [INFO] [stderr] Compiling snap v1.1.1 [INFO] [stderr] Compiling hdfs-native v0.11.3 [INFO] [stderr] Checking zlib-rs v0.5.1 [INFO] [stderr] Checking trim-in-place v0.1.7 [INFO] [stderr] Checking whoami v1.6.1 [INFO] [stderr] Checking libflate_lz77 v2.1.0 [INFO] [stderr] Checking dlv-list v0.5.2 [INFO] [stderr] Checking threadpool v1.8.1 [INFO] [stderr] Checking event-listener-strategy v0.5.4 [INFO] [stderr] Checking parking_lot_core v0.9.11 [INFO] [stderr] Checking aws-smithy-xml v0.60.10 [INFO] [stderr] Checking ordered-float v2.10.1 [INFO] [stderr] Checking ordered-multimap v0.7.3 [INFO] [stderr] Checking atoi v2.0.0 [INFO] [stderr] Checking dary_heap v0.3.7 [INFO] [stderr] Checking roxmltree v0.20.0 [INFO] [stderr] Checking twox-hash v2.1.1 [INFO] [stderr] Compiling moka v0.12.10 [INFO] [stderr] Compiling rust_decimal v1.37.2 [INFO] [stderr] Checking lexical-core v1.0.5 [INFO] [stderr] Checking ecdsa v0.14.8 [INFO] [stderr] Checking adler32 v1.2.0 [INFO] [stderr] Checking async-lock v3.4.1 [INFO] [stderr] Checking lz4_flex v0.11.5 [INFO] [stderr] Checking libflate v2.1.0 [INFO] [stderr] Checking parking_lot v0.12.4 [INFO] [stderr] Checking brotli v8.0.2 [INFO] [stderr] Checking crc-fast v1.4.0 [INFO] [stderr] Checking p256 v0.11.1 [INFO] [stderr] Checking rust-ini v0.21.1 [INFO] [stderr] Compiling seq-macro v0.3.6 [INFO] [stderr] Checking thrift v0.17.0 [INFO] [stderr] Checking bytemuck v1.23.2 [INFO] [stderr] Checking dissimilar v1.0.10 [INFO] [stderr] Checking simdutf8 v0.1.5 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Compiling cmake v0.1.54 [INFO] [stderr] Compiling hdfs-native v0.10.4 [INFO] [stderr] Checking roaring v0.11.2 [INFO] [stderr] Checking roxmltree v0.18.1 [INFO] [stderr] Checking expect-test v1.5.1 [INFO] [stderr] Checking ordered-float v4.6.0 [INFO] [stderr] Checking as-any v0.3.2 [INFO] [stderr] Checking murmur3 v0.5.2 [INFO] [stderr] Checking array-init v2.1.0 [INFO] [stderr] Checking bimap v0.6.3 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Compiling aws-lc-sys v0.30.0 [INFO] [stderr] Compiling zstd-sys v2.0.15+zstd.1.5.7 [INFO] [stderr] Checking libz-rs-sys v0.5.1 [INFO] [stderr] Checking flate2 v1.1.2 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling darling_core v0.20.11 [INFO] [stderr] Compiling tokio-macros v2.5.0 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling tracing-attributes v0.1.30 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.0 [INFO] [stderr] Compiling zerovec-derive v0.11.1 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling g2gen v1.2.2 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling prost-derive v0.13.5 [INFO] [stderr] Checking g2p v1.2.2 [INFO] [stderr] Checking tokio v1.47.1 [INFO] [stderr] Compiling thiserror-impl v2.0.15 [INFO] [stderr] Compiling prost-derive v0.12.6 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Checking rustls-webpki v0.101.7 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Compiling typed-builder-macro v0.19.1 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Compiling typed-builder-macro v0.20.1 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Checking yoke v0.8.0 [INFO] [stderr] Checking zerovec v0.11.4 [INFO] [stderr] Checking zerotrie v0.2.2 [INFO] [stderr] Compiling strum_macros v0.27.2 [INFO] [stderr] Compiling serde_repr v0.1.20 [INFO] [stderr] Compiling darling_macro v0.20.11 [INFO] [stderr] Compiling zstd-safe v7.2.4 [INFO] [stderr] Checking zstd v0.13.3 [INFO] [stderr] Checking prost v0.13.5 [INFO] [stderr] Compiling darling v0.20.11 [INFO] [stderr] Compiling derive_builder_core v0.20.2 [INFO] [stderr] Compiling serde_with_macros v3.14.0 [INFO] [stderr] Checking prost v0.12.6 [INFO] [stderr] Checking typed-builder v0.19.1 [INFO] [stderr] Checking typed-builder v0.20.1 [INFO] [stderr] Checking prost-types v0.13.5 [INFO] [stderr] Checking prost-types v0.12.6 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking tinystr v0.8.1 [INFO] [stderr] Checking potential_utf v0.1.2 [INFO] [stderr] Checking icu_collections v2.0.0 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking icu_locale_core v2.0.0 [INFO] [stderr] Compiling derive_builder_macro v0.20.2 [INFO] [stderr] Checking derive_builder v0.20.2 [INFO] [stderr] Checking icu_provider v2.0.0 [INFO] [stderr] Checking strum v0.27.2 [INFO] [stderr] Checking icu_normalizer v2.0.0 [INFO] [stderr] Checking icu_properties v2.0.1 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking uuid v1.18.0 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking quick-xml v0.37.5 [INFO] [stderr] Checking quick-xml v0.38.1 [INFO] [stderr] Checking serde_bytes v0.11.17 [INFO] [stderr] Checking serde_with v3.14.0 [INFO] [stderr] Checking tokio-util v0.7.16 [INFO] [stderr] Checking aws-smithy-async v1.2.5 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Checking tokio-rustls v0.24.1 [INFO] [stderr] Checking backon v1.5.2 [INFO] [stderr] Checking aws-smithy-types v1.3.2 [INFO] [stderr] Checking h2 v0.4.12 [INFO] [stderr] Checking h2 v0.3.27 [INFO] [stderr] Checking tower-http v0.6.6 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking arrow-buffer v55.2.0 [INFO] [stderr] Checking aws-smithy-runtime-api v1.9.0 [INFO] [stderr] Checking aws-smithy-eventstream v0.60.11 [INFO] [stderr] Checking aws-smithy-json v0.61.4 [INFO] [stderr] Checking aws-smithy-query v0.60.7 [INFO] [stderr] Checking apache-avro v0.17.0 [INFO] [stderr] Checking arrow-data v55.2.0 [INFO] [stderr] Checking arrow-array v55.2.0 [INFO] [stderr] Checking aws-smithy-http v0.62.3 [INFO] [stderr] Checking aws-credential-types v1.2.5 [INFO] [stderr] Checking aws-smithy-observability v0.1.3 [INFO] [stderr] Checking aws-sigv4 v1.3.4 [INFO] [stderr] Checking aws-smithy-checksums v0.63.3 [INFO] [stderr] Checking hyper v1.7.0 [INFO] [stderr] Checking hyper v0.14.32 [INFO] [stderr] Checking arrow-select v55.2.0 [INFO] [stderr] Checking arrow-ipc v55.2.0 [INFO] [stderr] Checking arrow-arith v55.2.0 [INFO] [stderr] Checking hyper-util v0.1.16 [INFO] [stderr] Checking arrow-cast v55.2.0 [INFO] [stderr] Checking arrow-ord v55.2.0 [INFO] [stderr] Checking arrow-string v55.2.0 [INFO] [stderr] Checking rustls-webpki v0.103.4 [INFO] [stderr] Checking parquet v55.2.0 [INFO] [stderr] Checking hyper-rustls v0.24.2 [INFO] [stderr] Checking tokio-rustls v0.26.2 [INFO] [stderr] Checking hyper-rustls v0.27.7 [INFO] [stderr] Checking aws-smithy-http-client v1.1.0 [INFO] [stderr] Checking reqwest v0.12.23 [INFO] [stderr] Checking aws-smithy-runtime v1.9.0 [INFO] [stderr] Checking reqsign v0.16.5 [INFO] [stderr] Checking opendal-unofficial v0.54.0-alpha.1 [INFO] [stderr] Checking aws-runtime v1.5.10 [INFO] [stderr] Checking aws-sdk-sts v1.83.0 [INFO] [stderr] Checking aws-sdk-sso v1.81.0 [INFO] [stderr] Checking aws-sdk-ssooidc v1.82.0 [INFO] [stderr] Checking aws-sdk-s3 v1.85.0 [INFO] [stderr] Checking aws-config v1.8.5 [INFO] [stderr] Checking iceberg-unofficial v0.6.0-alpha.6 [INFO] [stderr] Checking iceberg-catalog-hadoop-unofficial v0.6.0-alpha.6 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/catalog.rs:87:21 [INFO] [stdout] | [INFO] [stdout] 87 | config: config, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/catalog.rs:89:21 [INFO] [stdout] | [INFO] [stdout] 89 | s3_client: s3_client, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `s3_client` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/catalog.rs:111:21 [INFO] [stdout] | [INFO] [stdout] 111 | config: config, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/catalog.rs:112:21 [INFO] [stdout] | [INFO] [stdout] 112 | file_io: file_io, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `file_io` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/catalog.rs:87:21 [INFO] [stdout] | [INFO] [stdout] 87 | config: config, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/catalog.rs:89:21 [INFO] [stdout] | [INFO] [stdout] 89 | s3_client: s3_client, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `s3_client` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/catalog.rs:111:21 [INFO] [stdout] | [INFO] [stdout] 111 | config: config, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/catalog.rs:112:21 [INFO] [stdout] | [INFO] [stdout] 112 | file_io: file_io, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `file_io` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/catalog.rs:46:9 [INFO] [stdout] | [INFO] [stdout] 46 | /// when using hdfs filesystem (like the properties in hdfs-site.xml) [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 46 | /// when using hdfs filesystem (like the properties in hdfs-site.xml) [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/catalog.rs:118:13 [INFO] [stdout] | [INFO] [stdout] 118 | / return Err(Error::new( [INFO] [stdout] 119 | | ErrorKind::DataInvalid, [INFO] [stdout] 120 | | "warehouse_url is not supported", [INFO] [stdout] 121 | | )); [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 118 ~ Err(Error::new( [INFO] [stdout] 119 + ErrorKind::DataInvalid, [INFO] [stdout] 120 + "warehouse_url is not supported", [INFO] [stdout] 121 ~ )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/catalog.rs:123:13 [INFO] [stdout] | [INFO] [stdout] 123 | / return Err(Error::new( [INFO] [stdout] 124 | | ErrorKind::DataInvalid, [INFO] [stdout] 125 | | "warehouse_url is required", [INFO] [stdout] 126 | | )); [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 123 ~ Err(Error::new( [INFO] [stdout] 124 + ErrorKind::DataInvalid, [INFO] [stdout] 125 + "warehouse_url is required", [INFO] [stdout] 126 ~ )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/catalog.rs:81:49 [INFO] [stdout] | [INFO] [stdout] 81 | let file_io = FileIO::from_path(&warehouse_url)? [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `warehouse_url` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/catalog.rs:94:49 [INFO] [stdout] | [INFO] [stdout] 94 | let file_io = FileIO::from_path(&warehouse_url)? [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `warehouse_url` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/catalog.rs:46:9 [INFO] [stdout] | [INFO] [stdout] 46 | /// when using hdfs filesystem (like the properties in hdfs-site.xml) [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 46 | /// when using hdfs filesystem (like the properties in hdfs-site.xml) [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/catalog.rs:106:58 [INFO] [stdout] | [INFO] [stdout] 106 | hdfs_native::Client::new_with_config(&default_fs, config.properties.clone()) [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `default_fs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/catalog.rs:224:32 [INFO] [stdout] | [INFO] [stdout] 224 | ... if !table_version_hint.is_ok() && !namespaces.is_empty() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `table_version_hint.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.s3_client` after checking its variant with `is_some` [INFO] [stdout] --> src/catalog.rs:153:29 [INFO] [stdout] | [INFO] [stdout] 152 | if self.s3_client.is_some() { [INFO] [stdout] | --------------------------- help: try: `if let Some() = &self.s3_client` [INFO] [stdout] 153 | let s3_client = self.s3_client.as_ref().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.s3_client` after checking its variant with `is_some` [INFO] [stdout] --> src/catalog.rs:323:29 [INFO] [stdout] | [INFO] [stdout] 319 | if self.s3_client.is_some() { [INFO] [stdout] | --------------------------- help: try: `if let Some() = &self.s3_client` [INFO] [stdout] ... [INFO] [stdout] 323 | let s3_client = self.s3_client.as_ref().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/catalog.rs:320:36 [INFO] [stdout] | [INFO] [stdout] 320 | if valid_s3_namespaces(&namespace).is_err() { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `namespace` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.s3_client` after checking its variant with `is_some` [INFO] [stdout] --> src/catalog.rs:416:29 [INFO] [stdout] | [INFO] [stdout] 412 | if self.s3_client.is_some() { [INFO] [stdout] | --------------------------- help: try: `if let Some() = &self.s3_client` [INFO] [stdout] ... [INFO] [stdout] 416 | let s3_client = self.s3_client.as_ref().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/catalog.rs:413:36 [INFO] [stdout] | [INFO] [stdout] 413 | if valid_s3_namespaces(&namespace).is_err() { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `namespace` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/catalog.rs:118:13 [INFO] [stdout] | [INFO] [stdout] 118 | / return Err(Error::new( [INFO] [stdout] 119 | | ErrorKind::DataInvalid, [INFO] [stdout] 120 | | "warehouse_url is not supported", [INFO] [stdout] 121 | | )); [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 118 ~ Err(Error::new( [INFO] [stdout] 119 + ErrorKind::DataInvalid, [INFO] [stdout] 120 + "warehouse_url is not supported", [INFO] [stdout] 121 ~ )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/catalog.rs:123:13 [INFO] [stdout] | [INFO] [stdout] 123 | / return Err(Error::new( [INFO] [stdout] 124 | | ErrorKind::DataInvalid, [INFO] [stdout] 125 | | "warehouse_url is required", [INFO] [stdout] 126 | | )); [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 123 ~ Err(Error::new( [INFO] [stdout] 124 + ErrorKind::DataInvalid, [INFO] [stdout] 125 + "warehouse_url is required", [INFO] [stdout] 126 ~ )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/catalog.rs:81:49 [INFO] [stdout] | [INFO] [stdout] 81 | let file_io = FileIO::from_path(&warehouse_url)? [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `warehouse_url` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/catalog.rs:94:49 [INFO] [stdout] | [INFO] [stdout] 94 | let file_io = FileIO::from_path(&warehouse_url)? [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `warehouse_url` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/catalog.rs:106:58 [INFO] [stdout] | [INFO] [stdout] 106 | hdfs_native::Client::new_with_config(&default_fs, config.properties.clone()) [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `default_fs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/catalog.rs:224:32 [INFO] [stdout] | [INFO] [stdout] 224 | ... if !table_version_hint.is_ok() && !namespaces.is_empty() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `table_version_hint.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.s3_client` after checking its variant with `is_some` [INFO] [stdout] --> src/catalog.rs:153:29 [INFO] [stdout] | [INFO] [stdout] 152 | if self.s3_client.is_some() { [INFO] [stdout] | --------------------------- help: try: `if let Some() = &self.s3_client` [INFO] [stdout] 153 | let s3_client = self.s3_client.as_ref().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.s3_client` after checking its variant with `is_some` [INFO] [stdout] --> src/catalog.rs:548:29 [INFO] [stdout] | [INFO] [stdout] 544 | if self.s3_client.is_some() { [INFO] [stdout] | --------------------------- help: try: `if let Some() = &self.s3_client` [INFO] [stdout] ... [INFO] [stdout] 548 | let s3_client = self.s3_client.as_ref().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/catalog.rs:545:36 [INFO] [stdout] | [INFO] [stdout] 545 | if valid_s3_namespaces(&namespace).is_err() { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `namespace` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.s3_client` after checking its variant with `is_some` [INFO] [stdout] --> src/catalog.rs:692:29 [INFO] [stdout] | [INFO] [stdout] 691 | if self.s3_client.is_some() { [INFO] [stdout] | --------------------------- help: try: `if let Some() = &self.s3_client` [INFO] [stdout] 692 | let s3_client = self.s3_client.as_ref().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.s3_client` after checking its variant with `is_some` [INFO] [stdout] --> src/catalog.rs:323:29 [INFO] [stdout] | [INFO] [stdout] 319 | if self.s3_client.is_some() { [INFO] [stdout] | --------------------------- help: try: `if let Some() = &self.s3_client` [INFO] [stdout] ... [INFO] [stdout] 323 | let s3_client = self.s3_client.as_ref().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/catalog.rs:320:36 [INFO] [stdout] | [INFO] [stdout] 320 | if valid_s3_namespaces(&namespace).is_err() { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `namespace` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.s3_client` after checking its variant with `is_some` [INFO] [stdout] --> src/catalog.rs:416:29 [INFO] [stdout] | [INFO] [stdout] 412 | if self.s3_client.is_some() { [INFO] [stdout] | --------------------------- help: try: `if let Some() = &self.s3_client` [INFO] [stdout] ... [INFO] [stdout] 416 | let s3_client = self.s3_client.as_ref().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/catalog.rs:413:36 [INFO] [stdout] | [INFO] [stdout] 413 | if valid_s3_namespaces(&namespace).is_err() { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `namespace` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.s3_client` after checking its variant with `is_some` [INFO] [stdout] --> src/catalog.rs:795:29 [INFO] [stdout] | [INFO] [stdout] 794 | if self.s3_client.is_some() { [INFO] [stdout] | --------------------------- help: try: `if let Some() = &self.s3_client` [INFO] [stdout] 795 | let s3_client = self.s3_client.as_ref().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/catalog.rs:838:81 [INFO] [stdout] | [INFO] [stdout] 838 | ... table_name = table_name.split("/").last().unwrap_or(&"").to_string(); [INFO] [stdout] | ^^^ help: change this to: `""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.s3_client` after checking its variant with `is_some` [INFO] [stdout] --> src/catalog.rs:548:29 [INFO] [stdout] | [INFO] [stdout] 544 | if self.s3_client.is_some() { [INFO] [stdout] | --------------------------- help: try: `if let Some() = &self.s3_client` [INFO] [stdout] ... [INFO] [stdout] 548 | let s3_client = self.s3_client.as_ref().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/catalog.rs:545:36 [INFO] [stdout] | [INFO] [stdout] 545 | if valid_s3_namespaces(&namespace).is_err() { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `namespace` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/catalog.rs:907:93 [INFO] [stdout] | [INFO] [stdout] 907 | ... let table_name = file_relative_path.split("/").last().unwrap_or(&""); [INFO] [stdout] | ^^^ help: change this to: `""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.s3_client` after checking its variant with `is_some` [INFO] [stdout] --> src/catalog.rs:960:29 [INFO] [stdout] | [INFO] [stdout] 959 | if self.s3_client.is_some() { [INFO] [stdout] | --------------------------- help: try: `if let Some() = &self.s3_client` [INFO] [stdout] 960 | let s3_client = self.s3_client.as_ref().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/catalog.rs:947:44 [INFO] [stdout] | [INFO] [stdout] 947 | get_default_table_location(&namespace, &table_name, &warehouse_url) [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `namespace` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/catalog.rs:993:44 [INFO] [stdout] | [INFO] [stdout] 993 | if valid_s3_namespaces(&namespace).is_err() { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `namespace` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.s3_client` after checking its variant with `is_some` [INFO] [stdout] --> src/catalog.rs:692:29 [INFO] [stdout] | [INFO] [stdout] 691 | if self.s3_client.is_some() { [INFO] [stdout] | --------------------------- help: try: `if let Some() = &self.s3_client` [INFO] [stdout] 692 | let s3_client = self.s3_client.as_ref().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.s3_client` after checking its variant with `is_some` [INFO] [stdout] --> src/catalog.rs:1065:29 [INFO] [stdout] | [INFO] [stdout] 1064 | if self.s3_client.is_some() { [INFO] [stdout] | --------------------------- help: try: `if let Some() = &self.s3_client` [INFO] [stdout] 1065 | let s3_client = self.s3_client.as_ref().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.s3_client` after checking its variant with `is_some` [INFO] [stdout] --> src/catalog.rs:795:29 [INFO] [stdout] | [INFO] [stdout] 794 | if self.s3_client.is_some() { [INFO] [stdout] | --------------------------- help: try: `if let Some() = &self.s3_client` [INFO] [stdout] 795 | let s3_client = self.s3_client.as_ref().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/catalog.rs:1118:36 [INFO] [stdout] | [INFO] [stdout] 1118 | ... return Ok(Table::builder() [INFO] [stdout] | ______________________________^ [INFO] [stdout] 1119 | | ... .file_io(self.file_io.clone()) [INFO] [stdout] 1120 | | ... .metadata_location(metadata_location) [INFO] [stdout] 1121 | | ... .metadata(metadata) [INFO] [stdout] 1122 | | ... .identifier(table_ident.clone()) [INFO] [stdout] 1123 | | ... .build()?); [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 1118 ~ return Table::builder() [INFO] [stdout] 1119 | .file_io(self.file_io.clone()) [INFO] [stdout] ... [INFO] [stdout] 1122 | .identifier(table_ident.clone()) [INFO] [stdout] 1123 ~ .build(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/catalog.rs:1178:39 [INFO] [stdout] | [INFO] [stdout] 1178 | ... .read(table_version_hint_file_status.length as usize) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `table_version_hint_file_status.length` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/catalog.rs:838:81 [INFO] [stdout] | [INFO] [stdout] 838 | ... table_name = table_name.split("/").last().unwrap_or(&"").to_string(); [INFO] [stdout] | ^^^ help: change this to: `""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/catalog.rs:1200:36 [INFO] [stdout] | [INFO] [stdout] 1200 | ... return Ok(Table::builder() [INFO] [stdout] | ______________________________^ [INFO] [stdout] 1201 | | ... .file_io(self.file_io.clone()) [INFO] [stdout] 1202 | | ... .metadata_location(metadata_location) [INFO] [stdout] 1203 | | ... .metadata(metadata) [INFO] [stdout] 1204 | | ... .identifier(table_ident.clone()) [INFO] [stdout] 1205 | | ... .build()?); [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 1200 ~ return Table::builder() [INFO] [stdout] 1201 | .file_io(self.file_io.clone()) [INFO] [stdout] ... [INFO] [stdout] 1204 | .identifier(table_ident.clone()) [INFO] [stdout] 1205 ~ .build(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/catalog.rs:907:93 [INFO] [stdout] | [INFO] [stdout] 907 | ... let table_name = file_relative_path.split("/").last().unwrap_or(&""); [INFO] [stdout] | ^^^ help: change this to: `""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.s3_client` after checking its variant with `is_some` [INFO] [stdout] --> src/catalog.rs:1239:29 [INFO] [stdout] | [INFO] [stdout] 1238 | if self.s3_client.is_some() { [INFO] [stdout] | --------------------------- help: try: `if let Some() = &self.s3_client` [INFO] [stdout] 1239 | let s3_client = self.s3_client.as_ref().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.s3_client` after checking its variant with `is_some` [INFO] [stdout] --> src/catalog.rs:960:29 [INFO] [stdout] | [INFO] [stdout] 959 | if self.s3_client.is_some() { [INFO] [stdout] | --------------------------- help: try: `if let Some() = &self.s3_client` [INFO] [stdout] 960 | let s3_client = self.s3_client.as_ref().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/catalog.rs:947:44 [INFO] [stdout] | [INFO] [stdout] 947 | get_default_table_location(&namespace, &table_name, &warehouse_url) [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `namespace` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/catalog.rs:993:44 [INFO] [stdout] | [INFO] [stdout] 993 | if valid_s3_namespaces(&namespace).is_err() { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `namespace` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.s3_client` after checking its variant with `is_some` [INFO] [stdout] --> src/catalog.rs:1345:29 [INFO] [stdout] | [INFO] [stdout] 1344 | if self.s3_client.is_some() { [INFO] [stdout] | --------------------------- help: try: `if let Some() = &self.s3_client` [INFO] [stdout] 1345 | let s3_client = self.s3_client.as_ref().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.s3_client` after checking its variant with `is_some` [INFO] [stdout] --> src/catalog.rs:1065:29 [INFO] [stdout] | [INFO] [stdout] 1064 | if self.s3_client.is_some() { [INFO] [stdout] | --------------------------- help: try: `if let Some() = &self.s3_client` [INFO] [stdout] 1065 | let s3_client = self.s3_client.as_ref().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/catalog.rs:1118:36 [INFO] [stdout] | [INFO] [stdout] 1118 | ... return Ok(Table::builder() [INFO] [stdout] | ______________________________^ [INFO] [stdout] 1119 | | ... .file_io(self.file_io.clone()) [INFO] [stdout] 1120 | | ... .metadata_location(metadata_location) [INFO] [stdout] 1121 | | ... .metadata(metadata) [INFO] [stdout] 1122 | | ... .identifier(table_ident.clone()) [INFO] [stdout] 1123 | | ... .build()?); [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 1118 ~ return Table::builder() [INFO] [stdout] 1119 | .file_io(self.file_io.clone()) [INFO] [stdout] ... [INFO] [stdout] 1122 | .identifier(table_ident.clone()) [INFO] [stdout] 1123 ~ .build(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/catalog.rs:1178:39 [INFO] [stdout] | [INFO] [stdout] 1178 | ... .read(table_version_hint_file_status.length as usize) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `table_version_hint_file_status.length` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:148:5 [INFO] [stdout] | [INFO] [stdout] 148 | / return format!( [INFO] [stdout] 149 | | "{}/{}/{}", [INFO] [stdout] 150 | | warehouse.as_ref(), [INFO] [stdout] 151 | | namespace.join("/"), [INFO] [stdout] 152 | | table_name.as_ref() [INFO] [stdout] 153 | | ); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 148 ~ format!( [INFO] [stdout] 149 + "{}/{}/{}", [INFO] [stdout] 150 + warehouse.as_ref(), [INFO] [stdout] 151 + namespace.join("/"), [INFO] [stdout] 152 + table_name.as_ref() [INFO] [stdout] 153 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/catalog.rs:1200:36 [INFO] [stdout] | [INFO] [stdout] 1200 | ... return Ok(Table::builder() [INFO] [stdout] | ______________________________^ [INFO] [stdout] 1201 | | ... .file_io(self.file_io.clone()) [INFO] [stdout] 1202 | | ... .metadata_location(metadata_location) [INFO] [stdout] 1203 | | ... .metadata(metadata) [INFO] [stdout] 1204 | | ... .identifier(table_ident.clone()) [INFO] [stdout] 1205 | | ... .build()?); [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 1200 ~ return Table::builder() [INFO] [stdout] 1201 | .file_io(self.file_io.clone()) [INFO] [stdout] ... [INFO] [stdout] 1204 | .identifier(table_ident.clone()) [INFO] [stdout] 1205 ~ .build(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.s3_client` after checking its variant with `is_some` [INFO] [stdout] --> src/catalog.rs:1239:29 [INFO] [stdout] | [INFO] [stdout] 1238 | if self.s3_client.is_some() { [INFO] [stdout] | --------------------------- help: try: `if let Some() = &self.s3_client` [INFO] [stdout] 1239 | let s3_client = self.s3_client.as_ref().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.s3_client` after checking its variant with `is_some` [INFO] [stdout] --> src/catalog.rs:1345:29 [INFO] [stdout] | [INFO] [stdout] 1344 | if self.s3_client.is_some() { [INFO] [stdout] | --------------------------- help: try: `if let Some() = &self.s3_client` [INFO] [stdout] 1345 | let s3_client = self.s3_client.as_ref().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:148:5 [INFO] [stdout] | [INFO] [stdout] 148 | / return format!( [INFO] [stdout] 149 | | "{}/{}/{}", [INFO] [stdout] 150 | | warehouse.as_ref(), [INFO] [stdout] 151 | | namespace.join("/"), [INFO] [stdout] 152 | | table_name.as_ref() [INFO] [stdout] 153 | | ); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 148 ~ format!( [INFO] [stdout] 149 + "{}/{}/{}", [INFO] [stdout] 150 + warehouse.as_ref(), [INFO] [stdout] 151 + namespace.join("/"), [INFO] [stdout] 152 + table_name.as_ref() [INFO] [stdout] 153 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 59s [INFO] running `Command { std: "docker" "inspect" "86b293e6167d4dc784605954798b4d1f982745be5074b947a1ac4d49475e998c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "86b293e6167d4dc784605954798b4d1f982745be5074b947a1ac4d49475e998c", kill_on_drop: false }` [INFO] [stdout] 86b293e6167d4dc784605954798b4d1f982745be5074b947a1ac4d49475e998c