[INFO] fetching crate ic_tx 0.0.1... [INFO] linting ic_tx-0.0.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate ic_tx 0.0.1 into /workspace/builds/worker-7-tc1/source [INFO] started tweaking crates.io crate ic_tx 0.0.1 [INFO] finished tweaking crates.io crate ic_tx 0.0.1 [INFO] tweaked toml for crates.io crate ic_tx 0.0.1 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate ic_tx 0.0.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 106 packages to latest compatible versions [INFO] [stderr] Adding candid v0.8.4 (available: v0.10.26) [INFO] [stderr] Adding generic-array v0.14.7 (available: v0.14.9) [INFO] [stderr] Adding thiserror v1.0.69 (available: v2.0.18) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded candid_derive v0.5.0 [INFO] [stderr] Downloaded pretty v0.10.0 [INFO] [stderr] Downloaded candid v0.8.4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ff0dcfcb80cac4f4238eae22f4d954057c933905796828ab04a95b139de7a927 [INFO] running `Command { std: "docker" "start" "-a" "ff0dcfcb80cac4f4238eae22f4d954057c933905796828ab04a95b139de7a927", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ff0dcfcb80cac4f4238eae22f4d954057c933905796828ab04a95b139de7a927", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ff0dcfcb80cac4f4238eae22f4d954057c933905796828ab04a95b139de7a927", kill_on_drop: false }` [INFO] [stdout] ff0dcfcb80cac4f4238eae22f4d954057c933905796828ab04a95b139de7a927 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 69b7b47445ab1045398d5ef82ec9f521be760e1051426e7479232f0611e234cf [INFO] running `Command { std: "docker" "start" "-a" "69b7b47445ab1045398d5ef82ec9f521be760e1051426e7479232f0611e234cf", kill_on_drop: false }` [INFO] [stderr] Checking ic_tx v0.0.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: you should consider adding a `Default` implementation for `HashmapBackend` [INFO] [stdout] --> src/backend/hashmap.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | / pub fn new() -> Self { [INFO] [stdout] 15 | | HashmapBackend { map: RefCell::new(HashMap::default()) } [INFO] [stdout] 16 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 12 + impl Default for HashmapBackend { [INFO] [stdout] 13 + fn default() -> Self { [INFO] [stdout] 14 + Self::new() [INFO] [stdout] 15 + } [INFO] [stdout] 16 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `model::NewModel` [INFO] [stdout] --> src/backend/hashmap.rs:85:42 [INFO] [stdout] | [INFO] [stdout] 85 | v.insert(Model::from_new(model.into())); [INFO] [stdout] | ^^^^^^^^^^^^ help: consider removing `.into()`: `model` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/tx.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 79 | / match result { [INFO] [stdout] 80 | | Ok(version) => { [INFO] [stdout] 81 | | self.actions.push(Action::Delete { id: id.clone(), version }); [INFO] [stdout] 82 | | }, [INFO] [stdout] 83 | | _ => () [INFO] [stdout] 84 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 79 ~ if let Ok(version) = result { [INFO] [stdout] 80 + self.actions.push(Action::Delete { id: id.clone(), version }); [INFO] [stdout] 81 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/tx.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 90 | / match result { [INFO] [stdout] 91 | | Ok(Some(version)) => { [INFO] [stdout] 92 | | self.actions.push(Action::DeleteOption { id: id.clone(), version }); [INFO] [stdout] 93 | | }, [INFO] [stdout] 94 | | _ => () [INFO] [stdout] 95 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 90 ~ if let Ok(Some(version)) = result { [INFO] [stdout] 91 + self.actions.push(Action::DeleteOption { id: id.clone(), version }); [INFO] [stdout] 92 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `HashmapBackend` [INFO] [stdout] --> src/backend/hashmap.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | / pub fn new() -> Self { [INFO] [stdout] 15 | | HashmapBackend { map: RefCell::new(HashMap::default()) } [INFO] [stdout] 16 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 12 + impl Default for HashmapBackend { [INFO] [stdout] 13 + fn default() -> Self { [INFO] [stdout] 14 + Self::new() [INFO] [stdout] 15 + } [INFO] [stdout] 16 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `model::NewModel` [INFO] [stdout] --> src/backend/hashmap.rs:85:42 [INFO] [stdout] | [INFO] [stdout] 85 | v.insert(Model::from_new(model.into())); [INFO] [stdout] | ^^^^^^^^^^^^ help: consider removing `.into()`: `model` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/tx.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 79 | / match result { [INFO] [stdout] 80 | | Ok(version) => { [INFO] [stdout] 81 | | self.actions.push(Action::Delete { id: id.clone(), version }); [INFO] [stdout] 82 | | }, [INFO] [stdout] 83 | | _ => () [INFO] [stdout] 84 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 79 ~ if let Ok(version) = result { [INFO] [stdout] 80 + self.actions.push(Action::Delete { id: id.clone(), version }); [INFO] [stdout] 81 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/tx.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 90 | / match result { [INFO] [stdout] 91 | | Ok(Some(version)) => { [INFO] [stdout] 92 | | self.actions.push(Action::DeleteOption { id: id.clone(), version }); [INFO] [stdout] 93 | | }, [INFO] [stdout] 94 | | _ => () [INFO] [stdout] 95 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 90 ~ if let Ok(Some(version)) = result { [INFO] [stdout] 91 + self.actions.push(Action::DeleteOption { id: id.clone(), version }); [INFO] [stdout] 92 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> src/tx.rs:245:13 [INFO] [stdout] | [INFO] [stdout] 245 | assert!(true, "The update should succeed"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] = note: `#[warn(clippy::assertions_on_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/tx.rs:248:13 [INFO] [stdout] | [INFO] [stdout] 248 | assert!(false, "Should panic before this line"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/tx.rs:632:17 [INFO] [stdout] | [INFO] [stdout] 632 | assert!(!delete_result_2.is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `delete_result_2.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.50s [INFO] running `Command { std: "docker" "inspect" "69b7b47445ab1045398d5ef82ec9f521be760e1051426e7479232f0611e234cf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "69b7b47445ab1045398d5ef82ec9f521be760e1051426e7479232f0611e234cf", kill_on_drop: false }` [INFO] [stdout] 69b7b47445ab1045398d5ef82ec9f521be760e1051426e7479232f0611e234cf