[INFO] fetching crate hybrid-rc 0.6.0... [INFO] linting hybrid-rc-0.6.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate hybrid-rc 0.6.0 into /workspace/builds/worker-2-tc1/source [INFO] started tweaking crates.io crate hybrid-rc 0.6.0 [INFO] finished tweaking crates.io crate hybrid-rc 0.6.0 [INFO] tweaked toml for crates.io crate hybrid-rc 0.6.0 written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate hybrid-rc 0.6.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 63 packages to latest compatible versions [INFO] [stderr] Adding criterion v0.3.6 (available: v0.8.2) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9df38f09faa8973f858b1accff5cda2809173df9c0395e68ab6148b4b68647f6 [INFO] running `Command { std: "docker" "start" "-a" "9df38f09faa8973f858b1accff5cda2809173df9c0395e68ab6148b4b68647f6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9df38f09faa8973f858b1accff5cda2809173df9c0395e68ab6148b4b68647f6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9df38f09faa8973f858b1accff5cda2809173df9c0395e68ab6148b4b68647f6", kill_on_drop: false }` [INFO] [stdout] 9df38f09faa8973f858b1accff5cda2809173df9c0395e68ab6148b4b68647f6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f583ec425ecf4ca15b2bc94c4e0061fb78db5fd5972dd53e82c579753f44d16d [INFO] running `Command { std: "docker" "start" "-a" "f583ec425ecf4ca15b2bc94c4e0061fb78db5fd5972dd53e82c579753f44d16d", kill_on_drop: false }` [INFO] [stderr] Checking hybrid-rc v0.6.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:70:4 [INFO] [stdout] | [INFO] [stdout] 70 | * let sender = sender.clone(); [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] = note: `#[warn(clippy::tabs_in_doc_comments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:71:4 [INFO] [stdout] | [INFO] [stdout] 71 | * let shared = Rc::to_shared(&local); [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:72:4 [INFO] [stdout] | [INFO] [stdout] 72 | * thread::spawn(move || { [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:73:4 [INFO] [stdout] | [INFO] [stdout] 73 | * sender.send(expensive_computation(shared, i)); [INFO] [stdout] | ^^^^^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:74:4 [INFO] [stdout] | [INFO] [stdout] 74 | * }); [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:79:4 [INFO] [stdout] | [INFO] [stdout] 79 | * do_something(local.clone(), i); [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:84:4 [INFO] [stdout] | [INFO] [stdout] 84 | * println!("{:?}", receiver.recv().unwrap()); [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:105:4 [INFO] [stdout] | [INFO] [stdout] 105 | * do_something(&*shared); [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:70:4 [INFO] [stdout] | [INFO] [stdout] 70 | * let sender = sender.clone(); [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] = note: `#[warn(clippy::tabs_in_doc_comments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:71:4 [INFO] [stdout] | [INFO] [stdout] 71 | * let shared = Rc::to_shared(&local); [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:72:4 [INFO] [stdout] | [INFO] [stdout] 72 | * thread::spawn(move || { [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:73:4 [INFO] [stdout] | [INFO] [stdout] 73 | * sender.send(expensive_computation(shared, i)); [INFO] [stdout] | ^^^^^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:74:4 [INFO] [stdout] | [INFO] [stdout] 74 | * }); [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:79:4 [INFO] [stdout] | [INFO] [stdout] 79 | * do_something(local.clone(), i); [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:84:4 [INFO] [stdout] | [INFO] [stdout] 84 | * println!("{:?}", receiver.recv().unwrap()); [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:105:4 [INFO] [stdout] | [INFO] [stdout] 105 | * do_something(&*shared); [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:1692:6 [INFO] [stdout] | [INFO] [stdout] 1692 | /// // Deferred initialization [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:1693:6 [INFO] [stdout] | [INFO] [stdout] 1693 | /// Rc::get_mut_unchecked(&mut reference).as_mut_ptr().write(1337); [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:2007:6 [INFO] [stdout] | [INFO] [stdout] 2007 | /// vec![1,2,3], [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:2008:6 [INFO] [stdout] | [INFO] [stdout] 2008 | /// vec![4,5,6], [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:2290:6 [INFO] [stdout] | [INFO] [stdout] 2290 | /// let pointer = weak.as_ptr(); [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:2291:6 [INFO] [stdout] | [INFO] [stdout] 2291 | /// // As long as strong is not dropped, the pointer stays valid [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:2292:6 [INFO] [stdout] | [INFO] [stdout] 2292 | /// assert_eq!(42, unsafe { *pointer }); [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:2296:6 [INFO] [stdout] | [INFO] [stdout] 2296 | /// // Calling weak.as_ptr() is still safe, but dereferencing it would lead [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:2297:6 [INFO] [stdout] | [INFO] [stdout] 2297 | /// // to undefined behaviour. [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:2298:6 [INFO] [stdout] | [INFO] [stdout] 2298 | /// let pointer = weak.as_ptr(); [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:2299:6 [INFO] [stdout] | [INFO] [stdout] 2299 | /// // assert_eq!(42, unsafe { &*pointer }); // undefined behaviour [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:2336:6 [INFO] [stdout] | [INFO] [stdout] 2336 | /// let strong2 = weak.upgrade_local()?; [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:2337:6 [INFO] [stdout] | [INFO] [stdout] 2337 | /// assert_eq!(Arc::as_ptr(&strong), Rc::as_ptr(&strong2)); [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:1692:6 [INFO] [stdout] | [INFO] [stdout] 1692 | /// // Deferred initialization [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:1693:6 [INFO] [stdout] | [INFO] [stdout] 1693 | /// Rc::get_mut_unchecked(&mut reference).as_mut_ptr().write(1337); [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:2007:6 [INFO] [stdout] | [INFO] [stdout] 2007 | /// vec![1,2,3], [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:2008:6 [INFO] [stdout] | [INFO] [stdout] 2008 | /// vec![4,5,6], [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:2290:6 [INFO] [stdout] | [INFO] [stdout] 2290 | /// let pointer = weak.as_ptr(); [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:2291:6 [INFO] [stdout] | [INFO] [stdout] 2291 | /// // As long as strong is not dropped, the pointer stays valid [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:2292:6 [INFO] [stdout] | [INFO] [stdout] 2292 | /// assert_eq!(42, unsafe { *pointer }); [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:2296:6 [INFO] [stdout] | [INFO] [stdout] 2296 | /// // Calling weak.as_ptr() is still safe, but dereferencing it would lead [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:2297:6 [INFO] [stdout] | [INFO] [stdout] 2297 | /// // to undefined behaviour. [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:2298:6 [INFO] [stdout] | [INFO] [stdout] 2298 | /// let pointer = weak.as_ptr(); [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:2299:6 [INFO] [stdout] | [INFO] [stdout] 2299 | /// // assert_eq!(42, unsafe { &*pointer }); // undefined behaviour [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:2336:6 [INFO] [stdout] | [INFO] [stdout] 2336 | /// let strong2 = weak.upgrade_local()?; [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:2337:6 [INFO] [stdout] | [INFO] [stdout] 2337 | /// assert_eq!(Arc::as_ptr(&strong), Rc::as_ptr(&strong2)); [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: initializer for `thread_local` value can be made `const` [INFO] [stdout] --> src/thread_id.rs:10:29 [INFO] [stdout] | [INFO] [stdout] 10 | static THREAD_MARKER: () = (); [INFO] [stdout] | ^^ help: replace with: `const { () }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_const_for_thread_local [INFO] [stdout] = note: `#[warn(clippy::missing_const_for_thread_local)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `NonZeroUsize::new()` and `Option::unwrap()` can be safely used in a `const` context [INFO] [stdout] --> src/thread_id.rs:13:31 [INFO] [stdout] | [INFO] [stdout] 13 | const SENITEL: NonZeroUsize = unsafe { NonZeroUsize::new_unchecked(usize::MAX) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use instead: `NonZeroUsize::new(usize::MAX).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_nonzero_new_unchecked [INFO] [stdout] = note: `#[warn(clippy::useless_nonzero_new_unchecked)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::ptr::NonNull>>` [INFO] [stdout] --> src/lib.rs:1176:35 [INFO] [stdout] | [INFO] [stdout] 1176 | let weak: Weak = Weak { ptr: NonNull::from(inner).cast() }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `NonNull::from()`: `inner` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::ptr::NonNull>>` [INFO] [stdout] --> src/lib.rs:1236:27 [INFO] [stdout] | [INFO] [stdout] 1236 | Ok(HybridRc::from_inner(inner.into())) [INFO] [stdout] | ^^^^^^^^^^^^ help: consider removing `.into()`: `inner` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/lib.rs:1357:32 [INFO] [stdout] | [INFO] [stdout] 1357 | let dest = ptr::addr_of_mut!((*inner).data).cast(); [INFO] [stdout] | ^^^^^^^^ help: try: `inner` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/lib.rs:1876:3 [INFO] [stdout] | [INFO] [stdout] 1876 | &**self [INFO] [stdout] | ^^^^^^^ help: try: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/lib.rs:1883:3 [INFO] [stdout] | [INFO] [stdout] 1883 | &**self [INFO] [stdout] | ^^^^^^^ help: try: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/lib.rs:2365:6 [INFO] [stdout] | [INFO] [stdout] 2365 | if owner == None || owner == Some(current_thread) { [INFO] [stdout] | ^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `owner.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: ambiguous wide pointer comparison, the comparison includes metadata which may not be expected [INFO] [stdout] --> src/lib.rs:962:3 [INFO] [stdout] | [INFO] [stdout] 962 | this.ptr.as_ptr() == other.ptr.as_ptr() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(ambiguous_wide_pointer_comparisons)]` on by default [INFO] [stdout] help: use `std::ptr::addr_eq` or untyped pointers to only compare their addresses [INFO] [stdout] | [INFO] [stdout] 962 - this.ptr.as_ptr() == other.ptr.as_ptr() [INFO] [stdout] 962 + std::ptr::addr_eq(this.ptr.as_ptr(), other.ptr.as_ptr()) [INFO] [stdout] | [INFO] [stdout] help: use explicit `std::ptr::eq` method to compare metadata and addresses [INFO] [stdout] | [INFO] [stdout] 962 - this.ptr.as_ptr() == other.ptr.as_ptr() [INFO] [stdout] 962 + std::ptr::eq(this.ptr.as_ptr(), other.ptr.as_ptr()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: ambiguous wide pointer comparison, the comparison includes metadata which may not be expected [INFO] [stdout] --> src/lib.rs:971:3 [INFO] [stdout] | [INFO] [stdout] 971 | this.ptr.as_ptr() == other.ptr.as_ptr() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: use `std::ptr::addr_eq` or untyped pointers to only compare their addresses [INFO] [stdout] | [INFO] [stdout] 971 - this.ptr.as_ptr() == other.ptr.as_ptr() [INFO] [stdout] 971 + std::ptr::addr_eq(this.ptr.as_ptr(), other.ptr.as_ptr()) [INFO] [stdout] | [INFO] [stdout] help: use explicit `std::ptr::eq` method to compare metadata and addresses [INFO] [stdout] | [INFO] [stdout] 971 - this.ptr.as_ptr() == other.ptr.as_ptr() [INFO] [stdout] 971 + std::ptr::eq(this.ptr.as_ptr(), other.ptr.as_ptr()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: initializer for `thread_local` value can be made `const` [INFO] [stdout] --> src/tests.rs:14:37 [INFO] [stdout] | [INFO] [stdout] 14 | static DROP_COUNTER: Cell = Cell::new(0); [INFO] [stdout] | ^^^^^^^^^^^^ help: replace with: `const { Cell::new(0) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_const_for_thread_local [INFO] [stdout] = note: `#[warn(clippy::missing_const_for_thread_local)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/tests.rs:53:10 [INFO] [stdout] | [INFO] [stdout] 53 | assert!(a <= b && a >= b && !(a < b) && !(a > b)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 53 - assert!(a <= b && a >= b && !(a < b) && !(a > b)); [INFO] [stdout] 53 + assert!(!(a > b || a < b)); [INFO] [stdout] | [INFO] [stdout] 53 - assert!(a <= b && a >= b && !(a < b) && !(a > b)); [INFO] [stdout] 53 + assert!(a <= b && a >= b); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/tests.rs:53:10 [INFO] [stdout] | [INFO] [stdout] 53 | assert!(a <= b && a >= b && !(a < b) && !(a > b)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 53 - assert!(a <= b && a >= b && !(a < b) && !(a > b)); [INFO] [stdout] 53 + assert!(!(a > b || a < b) && !(a > b)); [INFO] [stdout] | [INFO] [stdout] 53 - assert!(a <= b && a >= b && !(a < b) && !(a > b)); [INFO] [stdout] 53 + assert!(a <= b && a >= b && !(a > b)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/tests.rs:53:30 [INFO] [stdout] | [INFO] [stdout] 53 | assert!(a <= b && a >= b && !(a < b) && !(a > b)); [INFO] [stdout] | ^^^^^^^^ help: try: `(a >= b)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/tests.rs:53:42 [INFO] [stdout] | [INFO] [stdout] 53 | assert!(a <= b && a >= b && !(a < b) && !(a > b)); [INFO] [stdout] | ^^^^^^^^ help: try: `(a <= b)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this binary expression can be simplified [INFO] [stdout] --> src/tests.rs:53:10 [INFO] [stdout] | [INFO] [stdout] 53 | assert!(a <= b && a >= b && !(a < b) && !(a > b)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `a == b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_comparisons [INFO] [stdout] = note: `#[warn(clippy::double_comparisons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(&a).is_some()` [INFO] [stdout] --> src/tests.rs:61:14 [INFO] [stdout] | [INFO] [stdout] 61 | assert!(map.get(&a).is_some()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace it with: `contains_key(&a)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] = note: `#[warn(clippy::unnecessary_get_then_check)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/tests.rs:305:2 [INFO] [stdout] | [INFO] [stdout] 305 | let _value = Rc::try_unwrap(a).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 305 - let _value = Rc::try_unwrap(a).unwrap(); [INFO] [stdout] 305 + Rc::try_unwrap(a).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/tests.rs:558:15 [INFO] [stdout] | [INFO] [stdout] 558 | let weak = &(*rc).0; [INFO] [stdout] | ^^^^^ help: try: `rc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/tests.rs:562:15 [INFO] [stdout] | [INFO] [stdout] 562 | assert_eq!(&(*rc).0 as *const _, weak as *const _); [INFO] [stdout] | ^^^^^ help: try: `rc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/tests.rs:570:15 [INFO] [stdout] | [INFO] [stdout] 570 | let weak = &(*arc).0; [INFO] [stdout] | ^^^^^^ help: try: `arc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/tests.rs:574:15 [INFO] [stdout] | [INFO] [stdout] 574 | assert_eq!(&(*arc2).0 as *const _, weak as *const _); [INFO] [stdout] | ^^^^^^^ help: try: `arc2` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: initializer for `thread_local` value can be made `const` [INFO] [stdout] --> src/thread_id.rs:10:29 [INFO] [stdout] | [INFO] [stdout] 10 | static THREAD_MARKER: () = (); [INFO] [stdout] | ^^ help: replace with: `const { () }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_const_for_thread_local [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `NonZeroUsize::new()` and `Option::unwrap()` can be safely used in a `const` context [INFO] [stdout] --> src/thread_id.rs:13:31 [INFO] [stdout] | [INFO] [stdout] 13 | const SENITEL: NonZeroUsize = unsafe { NonZeroUsize::new_unchecked(usize::MAX) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use instead: `NonZeroUsize::new(usize::MAX).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_nonzero_new_unchecked [INFO] [stdout] = note: `#[warn(clippy::useless_nonzero_new_unchecked)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> benches/benchmark.rs:43:38 [INFO] [stdout] | [INFO] [stdout] 43 | b.iter_batched(|| std_rc.clone(), |r| drop(r), SmallInput) [INFO] [stdout] | ^^^^^^^^^^^ help: replace the closure with the function itself: `drop` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> benches/benchmark.rs:50:38 [INFO] [stdout] | [INFO] [stdout] 50 | b.iter_batched(|| our_rc.clone(), |r| drop(r), SmallInput) [INFO] [stdout] | ^^^^^^^^^^^ help: replace the closure with the function itself: `drop` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> benches/benchmark.rs:57:39 [INFO] [stdout] | [INFO] [stdout] 57 | b.iter_batched(|| our_arc.clone(), |r| drop(r), SmallInput) [INFO] [stdout] | ^^^^^^^^^^^ help: replace the closure with the function itself: `drop` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/thread_id.rs:102:25 [INFO] [stdout] | [INFO] [stdout] 102 | let b = thread::spawn(move || ThreadId::current_thread()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `ThreadId::current_thread` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> benches/benchmark.rs:64:35 [INFO] [stdout] | [INFO] [stdout] 64 | b.iter_batched(|| arc.clone(), |r| drop(r), SmallInput) [INFO] [stdout] | ^^^^^^^^^^^ help: replace the closure with the function itself: `drop` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `ThreadId` which implements the `Copy` trait [INFO] [stdout] --> src/thread_id.rs:125:11 [INFO] [stdout] | [INFO] [stdout] 125 | let b = a.clone(); [INFO] [stdout] | ^^^^^^^^^ help: try removing the `clone` call: `a` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::ptr::NonNull>>` [INFO] [stdout] --> src/lib.rs:1176:35 [INFO] [stdout] | [INFO] [stdout] 1176 | let weak: Weak = Weak { ptr: NonNull::from(inner).cast() }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `NonNull::from()`: `inner` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::ptr::NonNull>>` [INFO] [stdout] --> src/lib.rs:1236:27 [INFO] [stdout] | [INFO] [stdout] 1236 | Ok(HybridRc::from_inner(inner.into())) [INFO] [stdout] | ^^^^^^^^^^^^ help: consider removing `.into()`: `inner` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/lib.rs:1357:32 [INFO] [stdout] | [INFO] [stdout] 1357 | let dest = ptr::addr_of_mut!((*inner).data).cast(); [INFO] [stdout] | ^^^^^^^^ help: try: `inner` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/lib.rs:1876:3 [INFO] [stdout] | [INFO] [stdout] 1876 | &**self [INFO] [stdout] | ^^^^^^^ help: try: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/lib.rs:1883:3 [INFO] [stdout] | [INFO] [stdout] 1883 | &**self [INFO] [stdout] | ^^^^^^^ help: try: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/lib.rs:2365:6 [INFO] [stdout] | [INFO] [stdout] 2365 | if owner == None || owner == Some(current_thread) { [INFO] [stdout] | ^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `owner.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/tests.rs:485:12 [INFO] [stdout] | [INFO] [stdout] 485 | let vec = vec![1, 2, 3, 4]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: you can use an array directly: `[1, 2, 3, 4]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: ambiguous wide pointer comparison, the comparison includes metadata which may not be expected [INFO] [stdout] --> src/lib.rs:962:3 [INFO] [stdout] | [INFO] [stdout] 962 | this.ptr.as_ptr() == other.ptr.as_ptr() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(ambiguous_wide_pointer_comparisons)]` on by default [INFO] [stdout] help: use `std::ptr::addr_eq` or untyped pointers to only compare their addresses [INFO] [stdout] | [INFO] [stdout] 962 - this.ptr.as_ptr() == other.ptr.as_ptr() [INFO] [stdout] 962 + std::ptr::addr_eq(this.ptr.as_ptr(), other.ptr.as_ptr()) [INFO] [stdout] | [INFO] [stdout] help: use explicit `std::ptr::eq` method to compare metadata and addresses [INFO] [stdout] | [INFO] [stdout] 962 - this.ptr.as_ptr() == other.ptr.as_ptr() [INFO] [stdout] 962 + std::ptr::eq(this.ptr.as_ptr(), other.ptr.as_ptr()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: ambiguous wide pointer comparison, the comparison includes metadata which may not be expected [INFO] [stdout] --> src/lib.rs:971:3 [INFO] [stdout] | [INFO] [stdout] 971 | this.ptr.as_ptr() == other.ptr.as_ptr() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: use `std::ptr::addr_eq` or untyped pointers to only compare their addresses [INFO] [stdout] | [INFO] [stdout] 971 - this.ptr.as_ptr() == other.ptr.as_ptr() [INFO] [stdout] 971 + std::ptr::addr_eq(this.ptr.as_ptr(), other.ptr.as_ptr()) [INFO] [stdout] | [INFO] [stdout] help: use explicit `std::ptr::eq` method to compare metadata and addresses [INFO] [stdout] | [INFO] [stdout] 971 - this.ptr.as_ptr() == other.ptr.as_ptr() [INFO] [stdout] 971 + std::ptr::eq(this.ptr.as_ptr(), other.ptr.as_ptr()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.91s [INFO] running `Command { std: "docker" "inspect" "f583ec425ecf4ca15b2bc94c4e0061fb78db5fd5972dd53e82c579753f44d16d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f583ec425ecf4ca15b2bc94c4e0061fb78db5fd5972dd53e82c579753f44d16d", kill_on_drop: false }` [INFO] [stdout] f583ec425ecf4ca15b2bc94c4e0061fb78db5fd5972dd53e82c579753f44d16d