[INFO] fetching crate http_reader 0.2.2... [INFO] linting http_reader-0.2.2 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate http_reader 0.2.2 into /workspace/builds/worker-3-tc1/source [INFO] started tweaking crates.io crate http_reader 0.2.2 [INFO] finished tweaking crates.io crate http_reader 0.2.2 [INFO] tweaked toml for crates.io crate http_reader 0.2.2 written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate http_reader 0.2.2 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate http_reader 0.2.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded native-tls v0.2.13 [INFO] [stderr] Downloaded miniz_oxide v0.8.4 [INFO] [stderr] Downloaded cc v1.2.14 [INFO] [stderr] Downloaded ring v0.17.9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cda4365cf63917a934ae82977b062fc1a1bf07ee73bb5665bda46017ba29ae8f [INFO] running `Command { std: "docker" "start" "-a" "cda4365cf63917a934ae82977b062fc1a1bf07ee73bb5665bda46017ba29ae8f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cda4365cf63917a934ae82977b062fc1a1bf07ee73bb5665bda46017ba29ae8f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cda4365cf63917a934ae82977b062fc1a1bf07ee73bb5665bda46017ba29ae8f", kill_on_drop: false }` [INFO] [stdout] cda4365cf63917a934ae82977b062fc1a1bf07ee73bb5665bda46017ba29ae8f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5c7616f51de9eb0f6dcc1f426d184f9edb1845a50124e8c540c9baae8fa4fcd9 [INFO] running `Command { std: "docker" "start" "-a" "5c7616f51de9eb0f6dcc1f426d184f9edb1845a50124e8c540c9baae8fa4fcd9", kill_on_drop: false }` [INFO] [stderr] Compiling unicode-ident v1.0.16 [INFO] [stderr] Compiling libc v0.2.169 [INFO] [stderr] Checking bytes v1.10.0 [INFO] [stderr] Checking once_cell v1.20.3 [INFO] [stderr] Compiling cc v1.2.14 [INFO] [stderr] Compiling openssl v0.10.71 [INFO] [stderr] Compiling httparse v1.10.0 [INFO] [stderr] Checking bitflags v2.8.0 [INFO] [stderr] Compiling native-tls v0.2.13 [INFO] [stderr] Checking indexmap v2.7.1 [INFO] [stderr] Checking log v0.4.25 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Compiling serde v1.0.217 [INFO] [stderr] Checking ryu v1.0.19 [INFO] [stderr] Checking rustls-pemfile v2.2.0 [INFO] [stderr] Checking tracing-core v0.1.33 [INFO] [stderr] Compiling proc-macro2 v1.0.93 [INFO] [stderr] Compiling quote v1.0.38 [INFO] [stderr] Compiling syn v2.0.98 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking mio v1.0.3 [INFO] [stderr] Checking socket2 v0.5.8 [INFO] [stderr] Checking http v1.2.0 [INFO] [stderr] Compiling openssl-sys v0.9.106 [INFO] [stderr] Checking tokio v1.43.0 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Compiling synstructure v0.13.1 [INFO] [stderr] Checking tokio-util v0.7.13 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Compiling zerovec-derive v0.10.3 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling icu_provider_macros v1.5.0 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling zerofrom-derive v0.1.5 [INFO] [stderr] Compiling yoke-derive v0.7.5 [INFO] [stderr] Checking h2 v0.4.7 [INFO] [stderr] Checking zerofrom v0.1.5 [INFO] [stderr] Checking yoke v0.7.5 [INFO] [stderr] Checking zerovec v0.10.4 [INFO] [stderr] Checking tinystr v0.7.6 [INFO] [stderr] Checking icu_collections v1.5.0 [INFO] [stderr] Checking icu_locid v1.5.0 [INFO] [stderr] Checking icu_provider v1.5.0 [INFO] [stderr] Checking hyper v1.6.0 [INFO] [stderr] Checking icu_locid_transform v1.5.0 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking icu_properties v1.5.1 [INFO] [stderr] Checking hyper-util v0.1.10 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking icu_normalizer v1.5.0 [INFO] [stderr] Checking idna_adapter v1.2.0 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Checking reqwest v0.12.12 [INFO] [stderr] Checking http_reader v0.2.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: the feature `let_chains` has been stable since 1.88.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | #![feature(let_chains)] [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `let_chains` has been stable since 1.88.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | #![feature(let_chains)] [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/lib.rs:67:9 [INFO] [stdout] | [INFO] [stdout] 67 | std::io::Error::new(std::io::ErrorKind::Other, format!("Request error: {}", error)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 67 - std::io::Error::new(std::io::ErrorKind::Other, format!("Request error: {}", error)) [INFO] [stdout] 67 + std::io::Error::other(format!("Request error: {}", error)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/lib.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 69 | std::io::Error::new(std::io::ErrorKind::Other, format!("Redirect error: {}", error)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 69 - std::io::Error::new(std::io::ErrorKind::Other, format!("Redirect error: {}", error)) [INFO] [stdout] 69 + std::io::Error::other(format!("Redirect error: {}", error)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/lib.rs:71:9 [INFO] [stdout] | [INFO] [stdout] 71 | std::io::Error::new(std::io::ErrorKind::Other, format!("HTTP status error: {}", error)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 71 - std::io::Error::new(std::io::ErrorKind::Other, format!("HTTP status error: {}", error)) [INFO] [stdout] 71 + std::io::Error::other(format!("HTTP status error: {}", error)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/lib.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 73 | std::io::Error::new(std::io::ErrorKind::Other, format!("Body error: {}", error)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 73 - std::io::Error::new(std::io::ErrorKind::Other, format!("Body error: {}", error)) [INFO] [stdout] 73 + std::io::Error::other(format!("Body error: {}", error)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/lib.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 79 | std::io::Error::new(std::io::ErrorKind::Other, format!("Builder error: {}", error)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 79 - std::io::Error::new(std::io::ErrorKind::Other, format!("Builder error: {}", error)) [INFO] [stdout] 79 + std::io::Error::other(format!("Builder error: {}", error)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/lib.rs:81:9 [INFO] [stdout] | [INFO] [stdout] 81 | std::io::Error::new(std::io::ErrorKind::Other, format!("Unknown error: {}", error)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 81 - std::io::Error::new(std::io::ErrorKind::Other, format!("Unknown error: {}", error)) [INFO] [stdout] 81 + std::io::Error::other(format!("Unknown error: {}", error)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/lib.rs:88:72 [INFO] [stdout] | [INFO] [stdout] 88 | fn interval_analysis(a: (T, T), b: (T, T)) -> (Option<(T, T)>, Option<(T, T)>, Option<(T, T)>) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:140:48 [INFO] [stdout] | [INFO] [stdout] 140 | let (len, etag) = get_file_size_custom(&client, url)?; [INFO] [stdout] | ^^^^^^^ help: change this to: `client` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/lib.rs:163:24 [INFO] [stdout] | [INFO] [stdout] 163 | ...rr(io::Error::new(io::ErrorKind::Other, format!("Server Error: {} (pos:{} size:{})", res.status(), range_start, range_start + range_size - 1))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 163 - return Err(io::Error::new(io::ErrorKind::Other, format!("Server Error: {} (pos:{} size:{})", res.status(), range_start, range_start + range_size - 1))); [INFO] [stdout] 163 + return Err(io::Error::other(format!("Server Error: {} (pos:{} size:{})", res.status(), range_start, range_start + range_size - 1))); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/lib.rs:166:60 [INFO] [stdout] | [INFO] [stdout] 166 | .ok_or(io::Error::new(io::ErrorKind::NotFound, format!("Response doesn't include the ETag"))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Response doesn't include the ETag".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/lib.rs:167:36 [INFO] [stdout] | [INFO] [stdout] 167 | ?.to_str().map_err(|_| io::Error::new(io::ErrorKind::Other, "invalid ETag header"))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 167 - ?.to_str().map_err(|_| io::Error::new(io::ErrorKind::Other, "invalid ETag header"))?; [INFO] [stdout] 167 + ?.to_str().map_err(|_| io::Error::other("invalid ETag header"))?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/lib.rs:169:17 [INFO] [stdout] | [INFO] [stdout] 169 | Err(io::Error::new(io::ErrorKind::Other, "Server: File Modified - ETag Changed")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 169 - Err(io::Error::new(io::ErrorKind::Other, "Server: File Modified - ETag Changed")) [INFO] [stdout] 169 + Err(io::Error::other("Server: File Modified - ETag Changed")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:226:28 [INFO] [stdout] | [INFO] [stdout] 226 | let size = (left.1 - left.0) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(left.1 - left.0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lib.rs:231:17 [INFO] [stdout] | [INFO] [stdout] 231 | buf_pos = buf_pos + size; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `buf_pos += size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:235:28 [INFO] [stdout] | [INFO] [stdout] 235 | let size = (union.1 - union.0) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(union.1 - union.0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lib.rs:239:17 [INFO] [stdout] | [INFO] [stdout] 239 | buf_pos = buf_pos + size; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `buf_pos += size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:263:22 [INFO] [stdout] | [INFO] [stdout] 263 | let i_size = (i.1 - i.0) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `(i.1 - i.0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:268:54 [INFO] [stdout] | [INFO] [stdout] 268 | let mut res = self.get_file_range(i.0, end - i.0 as usize)?; [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `i.0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lib.rs:271:9 [INFO] [stdout] | [INFO] [stdout] 271 | buf_pos = buf_pos + i_size; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `buf_pos += i_size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:273:97 [INFO] [stdout] | [INFO] [stdout] 273 | res.read_exact(&mut self.httpcache.as_mut().unwrap()[precache_size..precache_size + end-i.1 as usize])?; [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `i.1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:274:31 [INFO] [stdout] | [INFO] [stdout] 274 | self.httpcache_base = i.1 as usize - precache_size; [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `i.1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:283:30 [INFO] [stdout] | [INFO] [stdout] 283 | if remaining == 0 || buf.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `buf.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:288:44 [INFO] [stdout] | [INFO] [stdout] 288 | let len = std::cmp::min(buf.len(), remaining as usize) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `remaining` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:298:56 [INFO] [stdout] | [INFO] [stdout] 298 | let bytes_to_read = std::cmp::min(len, chunk.len() as usize - offset_start); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `chunk.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:305:42 [INFO] [stdout] | [INFO] [stdout] 305 | let pos_at_chunk_start = (index*CHUNK_SIZE as usize) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(index*CHUNK_SIZE as usize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:305:49 [INFO] [stdout] | [INFO] [stdout] 305 | let pos_at_chunk_start = (index*CHUNK_SIZE as usize) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `CHUNK_SIZE` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:306:82 [INFO] [stdout] | [INFO] [stdout] 306 | let bytes_to_read = std::cmp::min(self.len - pos_at_chunk_start, CHUNK_SIZE as usize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `CHUNK_SIZE` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/lib.rs:347:24 [INFO] [stdout] | [INFO] [stdout] 347 | Ok((self.pos) as u64) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `(self.pos)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/lib.rs:360:24 [INFO] [stdout] | [INFO] [stdout] 360 | Ok((self.pos) as u64) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `(self.pos)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/lib.rs:379:56 [INFO] [stdout] | [INFO] [stdout] 379 | .ok_or(io::Error::new(io::ErrorKind::NotFound, format!("response doesn't include the content length")))? [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"response doesn't include the content length".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/lib.rs:380:31 [INFO] [stdout] | [INFO] [stdout] 380 | .to_str().map_err(|_| io::Error::new(io::ErrorKind::Other, "invalid Content-Length header"))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 380 - .to_str().map_err(|_| io::Error::new(io::ErrorKind::Other, "invalid Content-Length header"))?; [INFO] [stdout] 380 + .to_str().map_err(|_| io::Error::other("invalid Content-Length header"))?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/lib.rs:382:54 [INFO] [stdout] | [INFO] [stdout] 382 | let length = usize::from_str(length).map_err(|_| io::Error::new(io::ErrorKind::Other, "invalid Content-Length header"))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 382 - let length = usize::from_str(length).map_err(|_| io::Error::new(io::ErrorKind::Other, "invalid Content-Length header"))?; [INFO] [stdout] 382 + let length = usize::from_str(length).map_err(|_| io::Error::other("invalid Content-Length header"))?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/lib.rs:385:56 [INFO] [stdout] | [INFO] [stdout] 385 | .ok_or(io::Error::new(io::ErrorKind::NotFound, format!("Server file not found. (ETag not included)"))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Server file not found. (ETag not included)".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/lib.rs:386:32 [INFO] [stdout] | [INFO] [stdout] 386 | ?.to_str().map_err(|_| io::Error::new(io::ErrorKind::Other, "invalid ETag header"))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 386 - ?.to_str().map_err(|_| io::Error::new(io::ErrorKind::Other, "invalid ETag header"))?; [INFO] [stdout] 386 + ?.to_str().map_err(|_| io::Error::other("invalid ETag header"))?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:394:35 [INFO] [stdout] | [INFO] [stdout] 394 | get_file_size_custom(&client, &url) [INFO] [stdout] | ^^^^ help: change this to: `url` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:402:8 [INFO] [stdout] | [INFO] [stdout] 402 | if !(status == reqwest::StatusCode::PARTIAL_CONTENT) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(status != reqwest::StatusCode::PARTIAL_CONTENT)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:418:27 [INFO] [stdout] | [INFO] [stdout] 418 | get_file_range_custom(&client, url, range_start, range_start + range_size - 1) [INFO] [stdout] | ^^^^^^^ help: change this to: `client` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/lib.rs:67:9 [INFO] [stdout] | [INFO] [stdout] 67 | std::io::Error::new(std::io::ErrorKind::Other, format!("Request error: {}", error)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 67 - std::io::Error::new(std::io::ErrorKind::Other, format!("Request error: {}", error)) [INFO] [stdout] 67 + std::io::Error::other(format!("Request error: {}", error)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/lib.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 69 | std::io::Error::new(std::io::ErrorKind::Other, format!("Redirect error: {}", error)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 69 - std::io::Error::new(std::io::ErrorKind::Other, format!("Redirect error: {}", error)) [INFO] [stdout] 69 + std::io::Error::other(format!("Redirect error: {}", error)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/lib.rs:71:9 [INFO] [stdout] | [INFO] [stdout] 71 | std::io::Error::new(std::io::ErrorKind::Other, format!("HTTP status error: {}", error)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 71 - std::io::Error::new(std::io::ErrorKind::Other, format!("HTTP status error: {}", error)) [INFO] [stdout] 71 + std::io::Error::other(format!("HTTP status error: {}", error)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/lib.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 73 | std::io::Error::new(std::io::ErrorKind::Other, format!("Body error: {}", error)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 73 - std::io::Error::new(std::io::ErrorKind::Other, format!("Body error: {}", error)) [INFO] [stdout] 73 + std::io::Error::other(format!("Body error: {}", error)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/lib.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 79 | std::io::Error::new(std::io::ErrorKind::Other, format!("Builder error: {}", error)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 79 - std::io::Error::new(std::io::ErrorKind::Other, format!("Builder error: {}", error)) [INFO] [stdout] 79 + std::io::Error::other(format!("Builder error: {}", error)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/lib.rs:81:9 [INFO] [stdout] | [INFO] [stdout] 81 | std::io::Error::new(std::io::ErrorKind::Other, format!("Unknown error: {}", error)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 81 - std::io::Error::new(std::io::ErrorKind::Other, format!("Unknown error: {}", error)) [INFO] [stdout] 81 + std::io::Error::other(format!("Unknown error: {}", error)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/lib.rs:88:72 [INFO] [stdout] | [INFO] [stdout] 88 | fn interval_analysis(a: (T, T), b: (T, T)) -> (Option<(T, T)>, Option<(T, T)>, Option<(T, T)>) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:140:48 [INFO] [stdout] | [INFO] [stdout] 140 | let (len, etag) = get_file_size_custom(&client, url)?; [INFO] [stdout] | ^^^^^^^ help: change this to: `client` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/lib.rs:163:24 [INFO] [stdout] | [INFO] [stdout] 163 | ...rr(io::Error::new(io::ErrorKind::Other, format!("Server Error: {} (pos:{} size:{})", res.status(), range_start, range_start + range_size - 1))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 163 - return Err(io::Error::new(io::ErrorKind::Other, format!("Server Error: {} (pos:{} size:{})", res.status(), range_start, range_start + range_size - 1))); [INFO] [stdout] 163 + return Err(io::Error::other(format!("Server Error: {} (pos:{} size:{})", res.status(), range_start, range_start + range_size - 1))); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/lib.rs:166:60 [INFO] [stdout] | [INFO] [stdout] 166 | .ok_or(io::Error::new(io::ErrorKind::NotFound, format!("Response doesn't include the ETag"))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Response doesn't include the ETag".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/lib.rs:167:36 [INFO] [stdout] | [INFO] [stdout] 167 | ?.to_str().map_err(|_| io::Error::new(io::ErrorKind::Other, "invalid ETag header"))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 167 - ?.to_str().map_err(|_| io::Error::new(io::ErrorKind::Other, "invalid ETag header"))?; [INFO] [stdout] 167 + ?.to_str().map_err(|_| io::Error::other("invalid ETag header"))?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/lib.rs:169:17 [INFO] [stdout] | [INFO] [stdout] 169 | Err(io::Error::new(io::ErrorKind::Other, "Server: File Modified - ETag Changed")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 169 - Err(io::Error::new(io::ErrorKind::Other, "Server: File Modified - ETag Changed")) [INFO] [stdout] 169 + Err(io::Error::other("Server: File Modified - ETag Changed")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:226:28 [INFO] [stdout] | [INFO] [stdout] 226 | let size = (left.1 - left.0) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(left.1 - left.0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lib.rs:231:17 [INFO] [stdout] | [INFO] [stdout] 231 | buf_pos = buf_pos + size; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `buf_pos += size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:235:28 [INFO] [stdout] | [INFO] [stdout] 235 | let size = (union.1 - union.0) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(union.1 - union.0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lib.rs:239:17 [INFO] [stdout] | [INFO] [stdout] 239 | buf_pos = buf_pos + size; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `buf_pos += size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:263:22 [INFO] [stdout] | [INFO] [stdout] 263 | let i_size = (i.1 - i.0) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `(i.1 - i.0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:268:54 [INFO] [stdout] | [INFO] [stdout] 268 | let mut res = self.get_file_range(i.0, end - i.0 as usize)?; [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `i.0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lib.rs:271:9 [INFO] [stdout] | [INFO] [stdout] 271 | buf_pos = buf_pos + i_size; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `buf_pos += i_size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:273:97 [INFO] [stdout] | [INFO] [stdout] 273 | res.read_exact(&mut self.httpcache.as_mut().unwrap()[precache_size..precache_size + end-i.1 as usize])?; [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `i.1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:274:31 [INFO] [stdout] | [INFO] [stdout] 274 | self.httpcache_base = i.1 as usize - precache_size; [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `i.1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:283:30 [INFO] [stdout] | [INFO] [stdout] 283 | if remaining == 0 || buf.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `buf.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:288:44 [INFO] [stdout] | [INFO] [stdout] 288 | let len = std::cmp::min(buf.len(), remaining as usize) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `remaining` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:298:56 [INFO] [stdout] | [INFO] [stdout] 298 | let bytes_to_read = std::cmp::min(len, chunk.len() as usize - offset_start); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `chunk.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:305:42 [INFO] [stdout] | [INFO] [stdout] 305 | let pos_at_chunk_start = (index*CHUNK_SIZE as usize) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(index*CHUNK_SIZE as usize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:305:49 [INFO] [stdout] | [INFO] [stdout] 305 | let pos_at_chunk_start = (index*CHUNK_SIZE as usize) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `CHUNK_SIZE` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:306:82 [INFO] [stdout] | [INFO] [stdout] 306 | let bytes_to_read = std::cmp::min(self.len - pos_at_chunk_start, CHUNK_SIZE as usize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `CHUNK_SIZE` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/lib.rs:347:24 [INFO] [stdout] | [INFO] [stdout] 347 | Ok((self.pos) as u64) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `(self.pos)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/lib.rs:360:24 [INFO] [stdout] | [INFO] [stdout] 360 | Ok((self.pos) as u64) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `(self.pos)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/lib.rs:379:56 [INFO] [stdout] | [INFO] [stdout] 379 | .ok_or(io::Error::new(io::ErrorKind::NotFound, format!("response doesn't include the content length")))? [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"response doesn't include the content length".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/lib.rs:380:31 [INFO] [stdout] | [INFO] [stdout] 380 | .to_str().map_err(|_| io::Error::new(io::ErrorKind::Other, "invalid Content-Length header"))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 380 - .to_str().map_err(|_| io::Error::new(io::ErrorKind::Other, "invalid Content-Length header"))?; [INFO] [stdout] 380 + .to_str().map_err(|_| io::Error::other("invalid Content-Length header"))?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/lib.rs:382:54 [INFO] [stdout] | [INFO] [stdout] 382 | let length = usize::from_str(length).map_err(|_| io::Error::new(io::ErrorKind::Other, "invalid Content-Length header"))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 382 - let length = usize::from_str(length).map_err(|_| io::Error::new(io::ErrorKind::Other, "invalid Content-Length header"))?; [INFO] [stdout] 382 + let length = usize::from_str(length).map_err(|_| io::Error::other("invalid Content-Length header"))?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/lib.rs:385:56 [INFO] [stdout] | [INFO] [stdout] 385 | .ok_or(io::Error::new(io::ErrorKind::NotFound, format!("Server file not found. (ETag not included)"))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Server file not found. (ETag not included)".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/lib.rs:386:32 [INFO] [stdout] | [INFO] [stdout] 386 | ?.to_str().map_err(|_| io::Error::new(io::ErrorKind::Other, "invalid ETag header"))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 386 - ?.to_str().map_err(|_| io::Error::new(io::ErrorKind::Other, "invalid ETag header"))?; [INFO] [stdout] 386 + ?.to_str().map_err(|_| io::Error::other("invalid ETag header"))?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:394:35 [INFO] [stdout] | [INFO] [stdout] 394 | get_file_size_custom(&client, &url) [INFO] [stdout] | ^^^^ help: change this to: `url` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:402:8 [INFO] [stdout] | [INFO] [stdout] 402 | if !(status == reqwest::StatusCode::PARTIAL_CONTENT) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(status != reqwest::StatusCode::PARTIAL_CONTENT)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:418:27 [INFO] [stdout] | [INFO] [stdout] 418 | get_file_range_custom(&client, url, range_start, range_start + range_size - 1) [INFO] [stdout] | ^^^^^^^ help: change this to: `client` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 25.47s [INFO] running `Command { std: "docker" "inspect" "5c7616f51de9eb0f6dcc1f426d184f9edb1845a50124e8c540c9baae8fa4fcd9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5c7616f51de9eb0f6dcc1f426d184f9edb1845a50124e8c540c9baae8fa4fcd9", kill_on_drop: false }` [INFO] [stdout] 5c7616f51de9eb0f6dcc1f426d184f9edb1845a50124e8c540c9baae8fa4fcd9