[INFO] fetching crate http-manager 0.0.14... [INFO] linting http-manager-0.0.14 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate http-manager 0.0.14 into /workspace/builds/worker-7-tc1/source [INFO] started tweaking crates.io crate http-manager 0.0.14 [INFO] finished tweaking crates.io crate http-manager 0.0.14 [INFO] tweaked toml for crates.io crate http-manager 0.0.14 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate http-manager 0.0.14 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 182 packages to latest compatible versions [INFO] [stderr] Adding env_logger v0.10.2 (available: v0.11.9) [INFO] [stderr] Adding hyper v0.14.32 (available: v1.8.1) [INFO] [stderr] Adding hyper-tls v0.5.0 (available: v0.6.0) [INFO] [stderr] Adding reqwest v0.11.27 (available: v0.13.2) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1426a32901bf780ea9dffd4dce61c23be012e00434df5d34d1b3ed0934337169 [INFO] running `Command { std: "docker" "start" "-a" "1426a32901bf780ea9dffd4dce61c23be012e00434df5d34d1b3ed0934337169", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1426a32901bf780ea9dffd4dce61c23be012e00434df5d34d1b3ed0934337169", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1426a32901bf780ea9dffd4dce61c23be012e00434df5d34d1b3ed0934337169", kill_on_drop: false }` [INFO] [stdout] 1426a32901bf780ea9dffd4dce61c23be012e00434df5d34d1b3ed0934337169 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5bcec1ab0c397d4ed6c76bf3702fd6aeb12d0999de4ea69177fa93eb84c3a1e9 [INFO] running `Command { std: "docker" "start" "-a" "5bcec1ab0c397d4ed6c76bf3702fd6aeb12d0999de4ea69177fa93eb84c3a1e9", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling tokio-macros v2.6.1 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Checking openssl v0.10.76 [INFO] [stderr] Checking tokio v1.50.0 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking native-tls v0.2.18 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking tokio-stream v0.1.18 [INFO] [stderr] Checking tokio-test v0.4.5 [INFO] [stderr] Checking h2 v0.3.27 [INFO] [stderr] Checking hyper v0.14.32 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.11.27 [INFO] [stderr] Checking http-manager v0.0.14 (/opt/rustwide/workdir) [INFO] [stdout] warning: this `match` expression can be replaced with `?` [INFO] [stdout] --> src/lib.rs:15:15 [INFO] [stdout] | [INFO] [stdout] 15 | let uri = match join_uri(url, path) { [INFO] [stdout] | _______________^ [INFO] [stdout] 16 | | Ok(u) => u, [INFO] [stdout] 17 | | Err(e) => return Err(e), [INFO] [stdout] 18 | | }; [INFO] [stdout] | |_____^ help: try instead: `join_uri(url, path)?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:143:13 [INFO] [stdout] | [INFO] [stdout] 143 | / return Err(Error::new( [INFO] [stdout] 144 | | ErrorKind::Other, [INFO] [stdout] 145 | | format!("failed to fetch response {}", e), [INFO] [stdout] 146 | | )) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 143 ~ Err(Error::new( [INFO] [stdout] 144 + ErrorKind::Other, [INFO] [stdout] 145 + format!("failed to fetch response {}", e), [INFO] [stdout] 146 + )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` expression can be replaced with `?` [INFO] [stdout] --> src/lib.rs:15:15 [INFO] [stdout] | [INFO] [stdout] 15 | let uri = match join_uri(url, path) { [INFO] [stdout] | _______________^ [INFO] [stdout] 16 | | Ok(u) => u, [INFO] [stdout] 17 | | Err(e) => return Err(e), [INFO] [stdout] 18 | | }; [INFO] [stdout] | |_____^ help: try instead: `join_uri(url, path)?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:143:13 [INFO] [stdout] | [INFO] [stdout] 143 | / return Err(Error::new( [INFO] [stdout] 144 | | ErrorKind::Other, [INFO] [stdout] 145 | | format!("failed to fetch response {}", e), [INFO] [stdout] 146 | | )) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 143 ~ Err(Error::new( [INFO] [stdout] 144 + ErrorKind::Other, [INFO] [stdout] 145 + format!("failed to fetch response {}", e), [INFO] [stdout] 146 + )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:176:13 [INFO] [stdout] | [INFO] [stdout] 176 | assert!(!ret.is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `ret.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 23.38s [INFO] running `Command { std: "docker" "inspect" "5bcec1ab0c397d4ed6c76bf3702fd6aeb12d0999de4ea69177fa93eb84c3a1e9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5bcec1ab0c397d4ed6c76bf3702fd6aeb12d0999de4ea69177fa93eb84c3a1e9", kill_on_drop: false }` [INFO] [stdout] 5bcec1ab0c397d4ed6c76bf3702fd6aeb12d0999de4ea69177fa93eb84c3a1e9