[INFO] fetching crate htr 0.5.27... [INFO] linting htr-0.5.27 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate htr 0.5.27 into /workspace/builds/worker-1-tc1/source [INFO] started tweaking crates.io crate htr 0.5.27 [INFO] finished tweaking crates.io crate htr 0.5.27 [INFO] tweaked toml for crates.io crate htr 0.5.27 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate htr 0.5.27 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 2 packages to latest compatible versions [INFO] [stderr] Adding convert_case v0.5.0 (available: v0.11.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded convert_case v0.5.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 19a91b8f6e3128cd91b599c074d4f0cb6f8a0ac71b6517b81d2ff341de37a859 [INFO] running `Command { std: "docker" "start" "-a" "19a91b8f6e3128cd91b599c074d4f0cb6f8a0ac71b6517b81d2ff341de37a859", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "19a91b8f6e3128cd91b599c074d4f0cb6f8a0ac71b6517b81d2ff341de37a859", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "19a91b8f6e3128cd91b599c074d4f0cb6f8a0ac71b6517b81d2ff341de37a859", kill_on_drop: false }` [INFO] [stdout] 19a91b8f6e3128cd91b599c074d4f0cb6f8a0ac71b6517b81d2ff341de37a859 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 73dad67b65362026283251ec00df4cdf6788151a9c4bc1350252c374982cdf55 [INFO] running `Command { std: "docker" "start" "-a" "73dad67b65362026283251ec00df4cdf6788151a9c4bc1350252c374982cdf55", kill_on_drop: false }` [INFO] [stderr] Checking convert_case v0.5.0 [INFO] [stderr] Checking htr v0.5.27 (/opt/rustwide/workdir) [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/transform.rs:5:36 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn extract_html_props(context: &String) -> Vec { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 5 - pub fn extract_html_props(context: &String) -> Vec { [INFO] [stdout] 5 + pub fn extract_html_props(context: &str) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/transform.rs:106:12 [INFO] [stdout] | [INFO] [stdout] 106 | if space_before_text && c == ',' || space_before_text && i + 1 == style_replacer.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 106 - if space_before_text && c == ',' || space_before_text && i + 1 == style_replacer.len() { [INFO] [stdout] 106 + if !(!space_before_text || c != ',' && i + 1 != style_replacer.len()) { [INFO] [stdout] | [INFO] [stdout] 106 - if space_before_text && c == ',' || space_before_text && i + 1 == style_replacer.len() { [INFO] [stdout] 106 + if (i + 1 == style_replacer.len() || c == ',') && space_before_text { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/transform.rs:41:32 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn create_style_object(cc: &String) -> String { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 41 ~ pub fn create_style_object(cc: &str) -> String { [INFO] [stdout] 42 | let style_matcher = if cc.contains("style='") { [INFO] [stdout] ... [INFO] [stdout] 47 | [INFO] [stdout] 48 ~ let mut ctx = cc.to_owned(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/transform.rs:71:54 [INFO] [stdout] | [INFO] [stdout] 71 | style_replacer = style_replacer.replacen(&clp, &clp.to_case(Case::Camel), 1); [INFO] [stdout] | ^^^^ help: change this to: `clp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/utils.rs:3:17 [INFO] [stdout] | [INFO] [stdout] 3 | search_str: &String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 3 - search_str: &String, [INFO] [stdout] 3 + search_str: &str, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/utils.rs:13:34 [INFO] [stdout] | [INFO] [stdout] 13 | let end_idx = remaining.find(&end_str).unwrap_or(remaining.len()); [INFO] [stdout] | ^^^^^^^^ help: change this to: `end_str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/transform.rs:5:36 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn extract_html_props(context: &String) -> Vec { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 5 - pub fn extract_html_props(context: &String) -> Vec { [INFO] [stdout] 5 + pub fn extract_html_props(context: &str) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/transform.rs:106:12 [INFO] [stdout] | [INFO] [stdout] 106 | if space_before_text && c == ',' || space_before_text && i + 1 == style_replacer.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 106 - if space_before_text && c == ',' || space_before_text && i + 1 == style_replacer.len() { [INFO] [stdout] 106 + if !(!space_before_text || c != ',' && i + 1 != style_replacer.len()) { [INFO] [stdout] | [INFO] [stdout] 106 - if space_before_text && c == ',' || space_before_text && i + 1 == style_replacer.len() { [INFO] [stdout] 106 + if (i + 1 == style_replacer.len() || c == ',') && space_before_text { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/transform.rs:41:32 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn create_style_object(cc: &String) -> String { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 41 ~ pub fn create_style_object(cc: &str) -> String { [INFO] [stdout] 42 | let style_matcher = if cc.contains("style='") { [INFO] [stdout] ... [INFO] [stdout] 47 | [INFO] [stdout] 48 ~ let mut ctx = cc.to_owned(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/transform.rs:71:54 [INFO] [stdout] | [INFO] [stdout] 71 | style_replacer = style_replacer.replacen(&clp, &clp.to_case(Case::Camel), 1); [INFO] [stdout] | ^^^^ help: change this to: `clp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/utils.rs:3:17 [INFO] [stdout] | [INFO] [stdout] 3 | search_str: &String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 3 - search_str: &String, [INFO] [stdout] 3 + search_str: &str, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/utils.rs:13:34 [INFO] [stdout] | [INFO] [stdout] 13 | let end_idx = remaining.find(&end_str).unwrap_or(remaining.len()); [INFO] [stdout] | ^^^^^^^^ help: change this to: `end_str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/lib.rs:63:30 [INFO] [stdout] | [INFO] [stdout] 63 | pub fn convert_to_react(ctx: &String, component_name: String) -> String { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 63 - pub fn convert_to_react(ctx: &String, component_name: String) -> String { [INFO] [stdout] 63 + pub fn convert_to_react(ctx: &str, component_name: String) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut String` instead of `&mut str` involves a new object where a slice will do [INFO] [stdout] --> src/lib.rs:103:36 [INFO] [stdout] | [INFO] [stdout] 103 | pub fn convert_children_react(ctx: &mut String) -> String { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 103 - pub fn convert_children_react(ctx: &mut String) -> String { [INFO] [stdout] 103 + pub fn convert_children_react(ctx: &mut str) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `as_ref` does nothing [INFO] [stdout] --> src/lib.rs:142:45 [INFO] [stdout] | [INFO] [stdout] 142 | if SELF_ENCLOSED_TAGS.contains(¤t_prop.trim_end().as_ref()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `current_prop.trim_end()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stdout] = note: `#[warn(clippy::useless_asref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/lib.rs:63:30 [INFO] [stdout] | [INFO] [stdout] 63 | pub fn convert_to_react(ctx: &String, component_name: String) -> String { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 63 - pub fn convert_to_react(ctx: &String, component_name: String) -> String { [INFO] [stdout] 63 + pub fn convert_to_react(ctx: &str, component_name: String) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut String` instead of `&mut str` involves a new object where a slice will do [INFO] [stdout] --> src/lib.rs:103:36 [INFO] [stdout] | [INFO] [stdout] 103 | pub fn convert_children_react(ctx: &mut String) -> String { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 103 - pub fn convert_children_react(ctx: &mut String) -> String { [INFO] [stdout] 103 + pub fn convert_children_react(ctx: &mut str) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `as_ref` does nothing [INFO] [stdout] --> src/lib.rs:142:45 [INFO] [stdout] | [INFO] [stdout] 142 | if SELF_ENCLOSED_TAGS.contains(¤t_prop.trim_end().as_ref()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `current_prop.trim_end()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stdout] = note: `#[warn(clippy::useless_asref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.38s [INFO] running `Command { std: "docker" "inspect" "73dad67b65362026283251ec00df4cdf6788151a9c4bc1350252c374982cdf55", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "73dad67b65362026283251ec00df4cdf6788151a9c4bc1350252c374982cdf55", kill_on_drop: false }` [INFO] [stdout] 73dad67b65362026283251ec00df4cdf6788151a9c4bc1350252c374982cdf55