[INFO] fetching crate hj-vcs 0.1.12... [INFO] linting hj-vcs-0.1.12 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate hj-vcs 0.1.12 into /workspace/builds/worker-0-tc1/source [INFO] started tweaking crates.io crate hj-vcs 0.1.12 [INFO] finished tweaking crates.io crate hj-vcs 0.1.12 [INFO] tweaked toml for crates.io crate hj-vcs 0.1.12 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate hj-vcs 0.1.12 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate hj-vcs 0.1.12 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded trim-in-place v0.1.7 [INFO] [stderr] Downloaded shared_child v1.1.0 [INFO] [stderr] Downloaded duct v1.0.0 [INFO] [stderr] Downloaded sigchld v0.2.3 [INFO] [stderr] Downloaded shared_thread v0.1.0 [INFO] [stderr] Downloaded rust-ini v0.21.1 [INFO] [stderr] Downloaded yaml-rust2 v0.10.3 [INFO] [stderr] Downloaded openssl-src v300.5.1+3.5.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8bf1a85b3af8dd8f73b7a978b6f2983ea7cfa5a6121b502e731d26bd5158da41 [INFO] running `Command { std: "docker" "start" "-a" "8bf1a85b3af8dd8f73b7a978b6f2983ea7cfa5a6121b502e731d26bd5158da41", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8bf1a85b3af8dd8f73b7a978b6f2983ea7cfa5a6121b502e731d26bd5158da41", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8bf1a85b3af8dd8f73b7a978b6f2983ea7cfa5a6121b502e731d26bd5158da41", kill_on_drop: false }` [INFO] [stdout] 8bf1a85b3af8dd8f73b7a978b6f2983ea7cfa5a6121b502e731d26bd5158da41 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b9035416fcb68f6b81150ab0ee2581effe759f1b1356e45b884d8a80f4d6d07f [INFO] running `Command { std: "docker" "start" "-a" "b9035416fcb68f6b81150ab0ee2581effe759f1b1356e45b884d8a80f4d6d07f", kill_on_drop: false }` [INFO] [stderr] Compiling cc v1.2.27 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling zerovec-derive v0.11.1 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling thiserror-impl v2.0.12 [INFO] [stderr] Checking writeable v0.6.1 [INFO] [stderr] Checking litemap v0.8.0 [INFO] [stderr] Compiling libc v0.2.174 [INFO] [stderr] Checking mio v1.0.4 [INFO] [stderr] Checking socket2 v0.5.10 [INFO] [stderr] Compiling icu_normalizer_data v2.0.0 [INFO] [stderr] Compiling icu_properties_data v2.0.1 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.0 [INFO] [stderr] Checking tokio v1.45.1 [INFO] [stderr] Compiling openssl-src v300.5.1+3.5.1 [INFO] [stderr] Checking slab v0.4.10 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking hashbrown v0.15.4 [INFO] [stderr] Compiling thiserror v2.0.12 [INFO] [stderr] Compiling openssl-sys v0.9.109 [INFO] [stderr] Compiling getrandom v0.2.16 [INFO] [stderr] Compiling openssl v0.10.73 [INFO] [stderr] Compiling memchr v2.7.5 [INFO] [stderr] Compiling const-random-macro v0.1.16 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking getrandom v0.3.3 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling pest v2.8.1 [INFO] [stderr] Checking yoke v0.8.0 [INFO] [stderr] Compiling signal-hook v0.3.18 [INFO] [stderr] Checking zerovec v0.11.2 [INFO] [stderr] Checking zerotrie v0.2.2 [INFO] [stderr] Checking log v0.4.27 [INFO] [stderr] Checking const-random v0.1.18 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Checking signal-hook-registry v1.4.5 [INFO] [stderr] Compiling serde_json v1.0.141 [INFO] [stderr] Checking unicode-width v0.2.1 [INFO] [stderr] Checking indexmap v2.10.0 [INFO] [stderr] Checking tinystr v0.8.1 [INFO] [stderr] Checking potential_utf v0.1.2 [INFO] [stderr] Checking icu_collections v2.0.0 [INFO] [stderr] Checking icu_locale_core v2.0.0 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Compiling pest_meta v2.8.1 [INFO] [stderr] Checking dlv-list v0.5.2 [INFO] [stderr] Checking os_pipe v1.2.2 [INFO] [stderr] Checking icu_provider v2.0.0 [INFO] [stderr] Checking encoding_rs v0.8.35 [INFO] [stderr] Checking winnow v0.7.11 [INFO] [stderr] Checking icu_properties v2.0.1 [INFO] [stderr] Checking serde v1.0.219 [INFO] [stderr] Checking icu_normalizer v2.0.0 [INFO] [stderr] Checking hyper v1.6.0 [INFO] [stderr] Compiling pest_generator v2.8.1 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking hyper-util v0.1.14 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Checking sigchld v0.2.3 [INFO] [stderr] Checking ordered-multimap v0.7.3 [INFO] [stderr] Checking console v0.15.11 [INFO] [stderr] Checking rand_core v0.9.3 [INFO] [stderr] Checking hashlink v0.10.0 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Checking trim-in-place v0.1.7 [INFO] [stderr] Checking arraydeque v0.5.1 [INFO] [stderr] Checking iri-string v0.7.8 [INFO] [stderr] Compiling pest_derive v2.8.1 [INFO] [stderr] Checking clap_builder v4.5.40 [INFO] [stderr] Checking yaml-rust2 v0.10.3 [INFO] [stderr] Compiling clap_derive v4.5.40 [INFO] [stderr] Checking convert_case v0.6.0 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Checking miniz_oxide v0.8.9 [INFO] [stderr] Checking bitflags v2.9.1 [INFO] [stderr] Checking rustix v1.0.7 [INFO] [stderr] Checking serde_spanned v0.6.9 [INFO] [stderr] Checking toml_datetime v0.6.11 [INFO] [stderr] Checking toml_edit v0.22.27 [INFO] [stderr] Checking tower-http v0.6.6 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking ron v0.8.1 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking json5 v0.4.1 [INFO] [stderr] Checking rust-ini v0.21.1 [INFO] [stderr] Checking dirs-sys v0.5.0 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking shared_child v1.1.0 [INFO] [stderr] Checking filetime v0.2.25 [INFO] [stderr] Checking xattr v1.5.1 [INFO] [stderr] Checking tempfile v3.20.0 [INFO] [stderr] Compiling async-trait v0.1.88 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking shell-words v1.1.0 [INFO] [stderr] Checking number_prefix v0.4.0 [INFO] [stderr] Checking shared_thread v0.1.0 [INFO] [stderr] Checking flate2 v1.1.2 [INFO] [stderr] Checking dialoguer v0.11.0 [INFO] [stderr] Checking indicatif v0.17.11 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Checking duct v1.0.0 [INFO] [stderr] Checking toml v0.8.23 [INFO] [stderr] Checking tar v0.4.44 [INFO] [stderr] Checking rand v0.9.1 [INFO] [stderr] Checking dirs v6.0.0 [INFO] [stderr] Checking clap v4.5.40 [INFO] [stderr] Checking webbrowser v1.0.5 [INFO] [stderr] Checking console v0.16.0 [INFO] [stderr] Checking config v0.15.11 [INFO] [stderr] Compiling native-tls v0.2.14 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking reqwest v0.12.20 [INFO] [stderr] Checking hj-vcs v0.1.12 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `utils::step` [INFO] [stdout] --> src/commit.rs:3:52 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::{config::AppConfig, push::command_push, utils::step}; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `config_dir` [INFO] [stdout] --> src/config.rs:2:12 [INFO] [stdout] | [INFO] [stdout] 2 | use dirs::{config_dir, home_dir}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `push::command_push` [INFO] [stdout] --> src/pull.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | push::command_push, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::*` [INFO] [stdout] --> src/starship.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | use super::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fmt::format` [INFO] [stdout] --> src/switch.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::fmt::format; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `warning` [INFO] [stdout] --> src/upbase.rs:5:19 [INFO] [stdout] | [INFO] [stdout] 5 | utils::{step, warning}, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `utils::step` [INFO] [stdout] --> src/commit.rs:3:52 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::{config::AppConfig, push::command_push, utils::step}; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `config_dir` [INFO] [stdout] --> src/config.rs:2:12 [INFO] [stdout] | [INFO] [stdout] 2 | use dirs::{config_dir, home_dir}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `push::command_push` [INFO] [stdout] --> src/pull.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | push::command_push, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fmt::format` [INFO] [stdout] --> src/switch.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::fmt::format; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `warning` [INFO] [stdout] --> src/upbase.rs:5:19 [INFO] [stdout] | [INFO] [stdout] 5 | utils::{step, warning}, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `config` [INFO] [stdout] --> src/download.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | config: &AppConfig, [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_config` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `config` [INFO] [stdout] --> src/keepup.rs:5:30 [INFO] [stdout] | [INFO] [stdout] 5 | pub(crate) fn command_keepup(config: &AppConfig, branch: &Vec) -> anyhow::Result<()> { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_config` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `config` [INFO] [stdout] --> src/log.rs:5:31 [INFO] [stdout] | [INFO] [stdout] 5 | pub(crate) fn command_log_all(config: &AppConfig) -> anyhow::Result<()> { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_config` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `config` [INFO] [stdout] --> src/log.rs:10:31 [INFO] [stdout] | [INFO] [stdout] 10 | pub(crate) fn command_log_wip(config: &AppConfig, patch: bool) -> anyhow::Result<()> { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_config` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `config` [INFO] [stdout] --> src/pull.rs:9:28 [INFO] [stdout] | [INFO] [stdout] 9 | pub(crate) fn command_pull(config: &AppConfig, branch: Option) -> anyhow::Result<()> { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_config` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `current_branch` is never used [INFO] [stdout] --> src/starship.rs:4:8 [INFO] [stdout] | [INFO] [stdout] 4 | pub fn current_branch() -> Option { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `log` is never used [INFO] [stdout] --> src/tools.rs:3:8 [INFO] [stdout] | [INFO] [stdout] 3 | pub fn log(revset: &str, template: &str) -> Option { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/download.rs:84:20 [INFO] [stdout] | [INFO] [stdout] 84 | } else if entry.kind == "file" { [INFO] [stdout] | ____________________^ [INFO] [stdout] 85 | | if let Some(dl_url) = entry.download_url { [INFO] [stdout] 86 | | let content = client [INFO] [stdout] 87 | | .get(&dl_url) [INFO] [stdout] ... | [INFO] [stdout] 100 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 84 ~ } else if entry.kind == "file" [INFO] [stdout] 85 ~ && let Some(dl_url) = entry.download_url { [INFO] [stdout] 86 | let content = client [INFO] [stdout] ... [INFO] [stdout] 98 | println!("+ {}", entry.path); [INFO] [stdout] 99 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/download.rs:104:9 [INFO] [stdout] | [INFO] [stdout] 104 | / if entry.kind == "file" { [INFO] [stdout] 105 | | if let Some(dl_url) = entry.download_url { [INFO] [stdout] 106 | | let content = client [INFO] [stdout] 107 | | .get(&dl_url) [INFO] [stdout] ... | [INFO] [stdout] 119 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 104 ~ if entry.kind == "file" [INFO] [stdout] 105 ~ && let Some(dl_url) = entry.download_url { [INFO] [stdout] 106 | let content = client [INFO] [stdout] ... [INFO] [stdout] 117 | println!("+ {}", entry.path); [INFO] [stdout] 118 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `config` [INFO] [stdout] --> src/download.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | config: &AppConfig, [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_config` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/push.rs:11:13 [INFO] [stdout] | [INFO] [stdout] 11 | change: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 11 - change: &Vec, [INFO] [stdout] 11 + change: &[String], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `config` [INFO] [stdout] --> src/keepup.rs:5:30 [INFO] [stdout] | [INFO] [stdout] 5 | pub(crate) fn command_keepup(config: &AppConfig, branch: &Vec) -> anyhow::Result<()> { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_config` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `config` [INFO] [stdout] --> src/log.rs:5:31 [INFO] [stdout] | [INFO] [stdout] 5 | pub(crate) fn command_log_all(config: &AppConfig) -> anyhow::Result<()> { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_config` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `config` [INFO] [stdout] --> src/log.rs:10:31 [INFO] [stdout] | [INFO] [stdout] 10 | pub(crate) fn command_log_wip(config: &AppConfig, patch: bool) -> anyhow::Result<()> { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_config` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `config` [INFO] [stdout] --> src/pull.rs:9:28 [INFO] [stdout] | [INFO] [stdout] 9 | pub(crate) fn command_pull(config: &AppConfig, branch: Option) -> anyhow::Result<()> { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_config` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `log` is never used [INFO] [stdout] --> src/tools.rs:3:8 [INFO] [stdout] | [INFO] [stdout] 3 | pub fn log(revset: &str, template: &str) -> Option { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/download.rs:84:20 [INFO] [stdout] | [INFO] [stdout] 84 | } else if entry.kind == "file" { [INFO] [stdout] | ____________________^ [INFO] [stdout] 85 | | if let Some(dl_url) = entry.download_url { [INFO] [stdout] 86 | | let content = client [INFO] [stdout] 87 | | .get(&dl_url) [INFO] [stdout] ... | [INFO] [stdout] 100 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 84 ~ } else if entry.kind == "file" [INFO] [stdout] 85 ~ && let Some(dl_url) = entry.download_url { [INFO] [stdout] 86 | let content = client [INFO] [stdout] ... [INFO] [stdout] 98 | println!("+ {}", entry.path); [INFO] [stdout] 99 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/download.rs:104:9 [INFO] [stdout] | [INFO] [stdout] 104 | / if entry.kind == "file" { [INFO] [stdout] 105 | | if let Some(dl_url) = entry.download_url { [INFO] [stdout] 106 | | let content = client [INFO] [stdout] 107 | | .get(&dl_url) [INFO] [stdout] ... | [INFO] [stdout] 119 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 104 ~ if entry.kind == "file" [INFO] [stdout] 105 ~ && let Some(dl_url) = entry.download_url { [INFO] [stdout] 106 | let content = client [INFO] [stdout] ... [INFO] [stdout] 117 | println!("+ {}", entry.path); [INFO] [stdout] 118 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/push.rs:11:13 [INFO] [stdout] | [INFO] [stdout] 11 | change: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 11 - change: &Vec, [INFO] [stdout] 11 + change: &[String], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 6m 06s [INFO] running `Command { std: "docker" "inspect" "b9035416fcb68f6b81150ab0ee2581effe759f1b1356e45b884d8a80f4d6d07f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b9035416fcb68f6b81150ab0ee2581effe759f1b1356e45b884d8a80f4d6d07f", kill_on_drop: false }` [INFO] [stdout] b9035416fcb68f6b81150ab0ee2581effe759f1b1356e45b884d8a80f4d6d07f