[INFO] fetching crate hip_validator 1.0.0... [INFO] linting hip_validator-1.0.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate hip_validator 1.0.0 into /workspace/builds/worker-4-tc1/source [INFO] started tweaking crates.io crate hip_validator 1.0.0 [INFO] finished tweaking crates.io crate hip_validator 1.0.0 [INFO] tweaked toml for crates.io crate hip_validator 1.0.0 written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate hip_validator 1.0.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate hip_validator 1.0.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded radium v0.5.3 [INFO] [stderr] Downloaded predicates-core v1.0.2 [INFO] [stderr] Downloaded serde_yaml v0.8.21 [INFO] [stderr] Downloaded iso-8601 v0.4.1 [INFO] [stderr] Downloaded predicates-tree v1.0.4 [INFO] [stderr] Downloaded predicates v2.0.3 [INFO] [stderr] Downloaded termtree v0.2.3 [INFO] [stderr] Downloaded globset v0.4.8 [INFO] [stderr] Downloaded assert_cmd v1.0.8 [INFO] [stderr] Downloaded anyhow v1.0.45 [INFO] [stderr] Downloaded ignore v0.4.18 [INFO] [stderr] Downloaded assert_fs v1.0.6 [INFO] [stderr] Downloaded clap_derive v3.0.0-beta.5 [INFO] [stderr] Downloaded bitvec v0.19.5 [INFO] [stderr] Downloaded nom v6.2.1 [INFO] [stderr] Downloaded itertools v0.10.1 [INFO] [stderr] Downloaded regex v1.4.6 [INFO] [stderr] Downloaded os_str_bytes v4.1.1 [INFO] [stderr] Downloaded clap v3.0.0-beta.5 [INFO] [stderr] Downloaded bstr v0.2.15 [INFO] [stderr] Downloaded libc v0.2.107 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 402701a491c19fff1d0ea00aa3263626d4ff09d803df3a5e2344ad69eeac48ef [INFO] running `Command { std: "docker" "start" "-a" "402701a491c19fff1d0ea00aa3263626d4ff09d803df3a5e2344ad69eeac48ef", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "402701a491c19fff1d0ea00aa3263626d4ff09d803df3a5e2344ad69eeac48ef", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "402701a491c19fff1d0ea00aa3263626d4ff09d803df3a5e2344ad69eeac48ef", kill_on_drop: false }` [INFO] [stdout] 402701a491c19fff1d0ea00aa3263626d4ff09d803df3a5e2344ad69eeac48ef [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d7d7430658059bb1d0a399c938e2c615b082278d74fe87290c74c2e132e5d6bb [INFO] running `Command { std: "docker" "start" "-a" "d7d7430658059bb1d0a399c938e2c615b082278d74fe87290c74c2e132e5d6bb", kill_on_drop: false }` [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Compiling proc-macro2 v1.0.32 [INFO] [stderr] Compiling libc v0.2.107 [INFO] [stderr] Compiling syn v1.0.81 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling radium v0.5.3 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling lexical-core v0.7.6 [INFO] [stderr] Compiling nom v6.2.1 [INFO] [stderr] Checking predicates-core v1.0.2 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Checking tap v1.0.1 [INFO] [stderr] Checking ppv-lite86 v0.2.15 [INFO] [stderr] Checking wyz v0.2.0 [INFO] [stderr] Compiling unicode-segmentation v1.8.0 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Checking funty v1.1.0 [INFO] [stderr] Checking walkdir v2.3.2 [INFO] [stderr] Checking thread_local v1.1.3 [INFO] [stderr] Checking float-cmp v0.9.0 [INFO] [stderr] Checking termtree v0.2.3 [INFO] [stderr] Checking itertools v0.10.1 [INFO] [stderr] Compiling anyhow v1.0.45 [INFO] [stderr] Checking linked-hash-map v0.5.4 [INFO] [stderr] Checking textwrap v0.14.2 [INFO] [stderr] Checking predicates-tree v1.0.4 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking os_str_bytes v4.1.1 [INFO] [stderr] Checking dtoa v0.4.8 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking aho-corasick v0.7.15 [INFO] [stderr] Checking bstr v0.2.15 [INFO] [stderr] Checking bitvec v0.19.5 [INFO] [stderr] Compiling quote v1.0.10 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking regex v1.4.6 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.4 [INFO] [stderr] Checking globset v0.4.8 [INFO] [stderr] Checking predicates v2.0.3 [INFO] [stderr] Checking ignore v0.4.18 [INFO] [stderr] Checking assert_cmd v1.0.8 [INFO] [stderr] Checking tempfile v3.2.0 [INFO] [stderr] Checking globwalk v0.8.1 [INFO] [stderr] Checking assert_fs v1.0.6 [INFO] [stderr] Compiling serde_derive v1.0.130 [INFO] [stderr] Compiling clap_derive v3.0.0-beta.5 [INFO] [stderr] Compiling thiserror-impl v1.0.30 [INFO] [stderr] Checking iso-8601 v0.4.1 [INFO] [stderr] Checking thiserror v1.0.30 [INFO] [stderr] Checking clap v3.0.0-beta.5 [INFO] [stderr] Checking serde v1.0.130 [INFO] [stderr] Checking serde_yaml v0.8.21 [INFO] [stderr] Checking hip_validator v1.0.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/utils.rs:3:22 [INFO] [stdout] | [INFO] [stdout] 3 | const FM_DELIMITER: &'static str = "---\n"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/utils.rs:3:22 [INFO] [stdout] | [INFO] [stdout] 3 | const FM_DELIMITER: &'static str = "---\n"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/utils.rs:11:12 [INFO] [stdout] | [INFO] [stdout] 11 | if !fm_end.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `fm_end.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `fm_end` after checking its variant with `is_none` [INFO] [stdout] --> src/utils.rs:12:26 [INFO] [stdout] | [INFO] [stdout] 11 | if !fm_end.is_none() { [INFO] [stdout] | ---------------- the check is happening here [INFO] [stdout] 12 | let fm_end = fm_end.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/utils.rs:11:12 [INFO] [stdout] | [INFO] [stdout] 11 | if !fm_end.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `fm_end.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `fm_end` after checking its variant with `is_none` [INFO] [stdout] --> src/utils.rs:12:26 [INFO] [stdout] | [INFO] [stdout] 11 | if !fm_end.is_none() { [INFO] [stdout] | ---------------- the check is happening here [INFO] [stdout] 12 | let fm_end = fm_end.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:93:48 [INFO] [stdout] | [INFO] [stdout] 93 | let yaml: HipHeader = serde_yaml::from_str(&fm_str)?; [INFO] [stdout] | ^^^^^^^ help: change this to: `fm_str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:93:48 [INFO] [stdout] | [INFO] [stdout] 93 | let yaml: HipHeader = serde_yaml::from_str(&fm_str)?; [INFO] [stdout] | ^^^^^^^ help: change this to: `fm_str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 20.91s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: nom v6.2.1 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 4` [INFO] running `Command { std: "docker" "inspect" "d7d7430658059bb1d0a399c938e2c615b082278d74fe87290c74c2e132e5d6bb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d7d7430658059bb1d0a399c938e2c615b082278d74fe87290c74c2e132e5d6bb", kill_on_drop: false }` [INFO] [stdout] d7d7430658059bb1d0a399c938e2c615b082278d74fe87290c74c2e132e5d6bb