[INFO] fetching crate hexcat-rs 0.1.1... [INFO] linting hexcat-rs-0.1.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate hexcat-rs 0.1.1 into /workspace/builds/worker-2-tc1/source [INFO] started tweaking crates.io crate hexcat-rs 0.1.1 [INFO] finished tweaking crates.io crate hexcat-rs 0.1.1 [INFO] tweaked toml for crates.io crate hexcat-rs 0.1.1 written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate hexcat-rs 0.1.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate hexcat-rs 0.1.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a5c84743a91516f24fd814f6b000d2437862aef3eda5655d46d0b419104c90ca [INFO] running `Command { std: "docker" "start" "-a" "a5c84743a91516f24fd814f6b000d2437862aef3eda5655d46d0b419104c90ca", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a5c84743a91516f24fd814f6b000d2437862aef3eda5655d46d0b419104c90ca", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a5c84743a91516f24fd814f6b000d2437862aef3eda5655d46d0b419104c90ca", kill_on_drop: false }` [INFO] [stdout] a5c84743a91516f24fd814f6b000d2437862aef3eda5655d46d0b419104c90ca [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 80cc09415194b0e5df08834ca6949f393fad5423efb49448fe683d5731796d8f [INFO] running `Command { std: "docker" "start" "-a" "80cc09415194b0e5df08834ca6949f393fad5423efb49448fe683d5731796d8f", kill_on_drop: false }` [INFO] [stderr] Checking hexcat-rs v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:71:8 [INFO] [stdout] | [INFO] [stdout] 71 | if (!io::stdout().is_terminal() && use_color != 2) || (outfilename != "" && use_color != 2) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 71 - if (!io::stdout().is_terminal() && use_color != 2) || (outfilename != "" && use_color != 2) { [INFO] [stdout] 71 + if !(use_color == 2 || io::stdout().is_terminal() && outfilename == "") { [INFO] [stdout] | [INFO] [stdout] 71 - if (!io::stdout().is_terminal() && use_color != 2) || (outfilename != "" && use_color != 2) { [INFO] [stdout] 71 + if (outfilename != "" || !io::stdout().is_terminal()) && use_color != 2 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/main.rs:71:60 [INFO] [stdout] | [INFO] [stdout] 71 | if (!io::stdout().is_terminal() && use_color != 2) || (outfilename != "" && use_color != 2) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!outfilename.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/main.rs:127:9 [INFO] [stdout] | [INFO] [stdout] 127 | write!(outfile, "\n")?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] = note: `#[warn(clippy::write_with_newline)]` on by default [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 127 - write!(outfile, "\n")?; [INFO] [stdout] 127 + writeln!(outfile)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:71:8 [INFO] [stdout] | [INFO] [stdout] 71 | if (!io::stdout().is_terminal() && use_color != 2) || (outfilename != "" && use_color != 2) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 71 - if (!io::stdout().is_terminal() && use_color != 2) || (outfilename != "" && use_color != 2) { [INFO] [stdout] 71 + if !(use_color == 2 || io::stdout().is_terminal() && outfilename == "") { [INFO] [stdout] | [INFO] [stdout] 71 - if (!io::stdout().is_terminal() && use_color != 2) || (outfilename != "" && use_color != 2) { [INFO] [stdout] 71 + if (outfilename != "" || !io::stdout().is_terminal()) && use_color != 2 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/main.rs:71:60 [INFO] [stdout] | [INFO] [stdout] 71 | if (!io::stdout().is_terminal() && use_color != 2) || (outfilename != "" && use_color != 2) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!outfilename.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/main.rs:127:9 [INFO] [stdout] | [INFO] [stdout] 127 | write!(outfile, "\n")?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] = note: `#[warn(clippy::write_with_newline)]` on by default [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 127 - write!(outfile, "\n")?; [INFO] [stdout] 127 + writeln!(outfile)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.22s [INFO] running `Command { std: "docker" "inspect" "80cc09415194b0e5df08834ca6949f393fad5423efb49448fe683d5731796d8f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "80cc09415194b0e5df08834ca6949f393fad5423efb49448fe683d5731796d8f", kill_on_drop: false }` [INFO] [stdout] 80cc09415194b0e5df08834ca6949f393fad5423efb49448fe683d5731796d8f