[INFO] fetching crate hera 0.1.0... [INFO] linting hera-0.1.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate hera 0.1.0 into /workspace/builds/worker-1-tc1/source [INFO] started tweaking crates.io crate hera 0.1.0 [INFO] finished tweaking crates.io crate hera 0.1.0 [INFO] tweaked toml for crates.io crate hera 0.1.0 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate hera 0.1.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 140 packages to latest compatible versions [INFO] [stderr] Adding assert_cmd v0.9.1 (available: v2.2.0) [INFO] [stderr] Adding clap v2.34.0 (available: v4.6.0) [INFO] [stderr] Adding generic-array v0.14.7 (available: v0.14.9) [INFO] [stderr] Adding git2 v0.7.5 (available: v0.20.4) [INFO] [stderr] Adding tokei v8.0.1 (available: v14.0.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded predicates-core v0.9.0 [INFO] [stderr] Downloaded tokei v8.0.1 [INFO] [stderr] Downloaded predicates-tree v0.9.0 [INFO] [stderr] Downloaded assert_cmd v0.9.1 [INFO] [stderr] Downloaded normalize-line-endings v0.2.2 [INFO] [stderr] Downloaded float-cmp v0.4.0 [INFO] [stderr] Downloaded escargot v0.3.1 [INFO] [stderr] Downloaded encoding_rs_io v0.1.7 [INFO] [stderr] Downloaded predicates v0.9.1 [INFO] [stderr] Downloaded git2 v0.7.5 [INFO] [stderr] Downloaded libgit2-sys v0.7.11 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4c908c663045a85cca0a2a88fd94df336cc8b13d94ea1596bc11ecb5357e7083 [INFO] running `Command { std: "docker" "start" "-a" "4c908c663045a85cca0a2a88fd94df336cc8b13d94ea1596bc11ecb5357e7083", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4c908c663045a85cca0a2a88fd94df336cc8b13d94ea1596bc11ecb5357e7083", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4c908c663045a85cca0a2a88fd94df336cc8b13d94ea1596bc11ecb5357e7083", kill_on_drop: false }` [INFO] [stdout] 4c908c663045a85cca0a2a88fd94df336cc8b13d94ea1596bc11ecb5357e7083 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b32fbeb89a2bcec08732afcbf64d884a156ec3221d74ea0737831a3a39246918 [INFO] running `Command { std: "docker" "start" "-a" "b32fbeb89a2bcec08732afcbf64d884a156ec3221d74ea0737831a3a39246918", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Checking aho-corasick v1.1.4 [INFO] [stderr] Compiling log v0.4.29 [INFO] [stderr] Compiling bstr v1.12.1 [INFO] [stderr] Compiling libz-sys v1.1.25 [INFO] [stderr] Compiling pest_meta v2.8.6 [INFO] [stderr] Compiling libssh2-sys v0.2.23 [INFO] [stderr] Compiling curl-sys v0.4.86+curl-8.19.0 [INFO] [stderr] Compiling serde_json v1.0.149 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Compiling libgit2-sys v0.7.11 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling escargot v0.3.1 [INFO] [stderr] Checking predicates-core v0.9.0 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking encoding_rs_io v0.1.7 [INFO] [stderr] Checking float-cmp v0.4.0 [INFO] [stderr] Checking term_size v0.3.2 [INFO] [stderr] Checking normalize-line-endings v0.2.2 [INFO] [stderr] Checking treeline v0.1.0 [INFO] [stderr] Checking difference v2.0.0 [INFO] [stderr] Checking tempfile v3.27.0 [INFO] [stderr] Checking predicates-tree v0.9.0 [INFO] [stderr] Compiling regex-automata v0.4.14 [INFO] [stderr] Compiling pest_generator v2.8.6 [INFO] [stderr] Compiling pest_derive v2.8.6 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Compiling regex v1.12.3 [INFO] [stderr] Compiling globset v0.4.18 [INFO] [stderr] Compiling ignore v0.4.25 [INFO] [stderr] Compiling handlebars v1.1.0 [INFO] [stderr] Checking env_logger v0.5.13 [INFO] [stderr] Checking predicates v0.9.1 [INFO] [stderr] Checking assert_cmd v0.9.1 [INFO] [stderr] Compiling tokei v8.0.1 [INFO] [stderr] Checking git2 v0.7.5 [INFO] [stderr] Checking hera v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/main.rs:21:29 [INFO] [stdout] | [INFO] [stdout] 21 | fn main() -> Result<(), Box> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 21 | fn main() -> Result<(), Box> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/main.rs:80:25 [INFO] [stdout] | [INFO] [stdout] 80 | -> Result> [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 80 | -> Result> [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/changes.rs:47:29 [INFO] [stdout] | [INFO] [stdout] 47 | -> Result> [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 47 | -> Result> [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/main.rs:21:29 [INFO] [stdout] | [INFO] [stdout] 21 | fn main() -> Result<(), Box> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 21 | fn main() -> Result<(), Box> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/main.rs:80:25 [INFO] [stdout] | [INFO] [stdout] 80 | -> Result> [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 80 | -> Result> [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/changes.rs:47:29 [INFO] [stdout] | [INFO] [stdout] 47 | -> Result> [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 47 | -> Result> [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `status` is never read [INFO] [stdout] --> src/changes.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 18 | pub struct FileChanges { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 21 | status: Delta, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `FileChanges` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/changes.rs:71:14 [INFO] [stdout] | [INFO] [stdout] 71 | .into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `skip(..).next()` on an iterator [INFO] [stdout] --> src/changes.rs:85:36 [INFO] [stdout] | [INFO] [stdout] 85 | let line = text.lines().skip(*line_num as usize - 1).next().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `nth` instead: `.nth(*line_num as usize - 1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stdout] = note: `#[warn(clippy::iter_skip_next)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/changes.rs:86:41 [INFO] [stdout] | [INFO] [stdout] 86 | let escaped = regex::escape(&line); [INFO] [stdout] | ^^^^^ help: change this to: `line` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `status` is never read [INFO] [stdout] --> src/changes.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 18 | pub struct FileChanges { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 21 | status: Delta, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `FileChanges` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/changes.rs:71:14 [INFO] [stdout] | [INFO] [stdout] 71 | .into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `skip(..).next()` on an iterator [INFO] [stdout] --> src/changes.rs:85:36 [INFO] [stdout] | [INFO] [stdout] 85 | let line = text.lines().skip(*line_num as usize - 1).next().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `nth` instead: `.nth(*line_num as usize - 1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stdout] = note: `#[warn(clippy::iter_skip_next)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/changes.rs:86:41 [INFO] [stdout] | [INFO] [stdout] 86 | let escaped = regex::escape(&line); [INFO] [stdout] | ^^^^^ help: change this to: `line` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:195:19 [INFO] [stdout] | [INFO] [stdout] 195 | .args(&[temp.path()]) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `[temp.path()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:219:19 [INFO] [stdout] | [INFO] [stdout] 219 | .args(&[temp.path()]) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `[temp.path()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:243:19 [INFO] [stdout] | [INFO] [stdout] 243 | .args(&[temp.path()]) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `[temp.path()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:267:19 [INFO] [stdout] | [INFO] [stdout] 267 | .args(&[temp.path()]) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `[temp.path()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:291:19 [INFO] [stdout] | [INFO] [stdout] 291 | .args(&[temp.path()]) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `[temp.path()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:315:19 [INFO] [stdout] | [INFO] [stdout] 315 | .args(&[temp.path()]) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `[temp.path()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:339:19 [INFO] [stdout] | [INFO] [stdout] 339 | .args(&[temp.path()]) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `[temp.path()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:363:19 [INFO] [stdout] | [INFO] [stdout] 363 | .args(&[temp.path()]) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `[temp.path()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:387:19 [INFO] [stdout] | [INFO] [stdout] 387 | .args(&[temp.path()]) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `[temp.path()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:414:19 [INFO] [stdout] | [INFO] [stdout] 414 | .args(&["--filter", "Rust,C", temp.path().to_str().unwrap()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["--filter", "Rust,C", temp.path().to_str().unwrap()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 49.04s [INFO] running `Command { std: "docker" "inspect" "b32fbeb89a2bcec08732afcbf64d884a156ec3221d74ea0737831a3a39246918", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b32fbeb89a2bcec08732afcbf64d884a156ec3221d74ea0737831a3a39246918", kill_on_drop: false }` [INFO] [stdout] b32fbeb89a2bcec08732afcbf64d884a156ec3221d74ea0737831a3a39246918