[INFO] fetching crate hdrhistogram 7.5.4... [INFO] linting hdrhistogram-7.5.4 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate hdrhistogram 7.5.4 into /workspace/builds/worker-2-tc1/source [INFO] started tweaking crates.io crate hdrhistogram 7.5.4 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate hdrhistogram 7.5.4 [INFO] tweaked toml for crates.io crate hdrhistogram 7.5.4 written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate hdrhistogram 7.5.4 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate hdrhistogram 7.5.4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded errno v0.3.6 [INFO] [stderr] Downloaded clap v4.3.24 [INFO] [stderr] Downloaded getrandom v0.2.11 [INFO] [stderr] Downloaded clap_builder v4.3.24 [INFO] [stderr] Downloaded base64 v0.21.5 [INFO] [stderr] Downloaded rustix v0.38.21 [INFO] [stderr] Downloaded rug v1.22.0 [INFO] [stderr] Downloaded libc v0.2.150 [INFO] [stderr] Downloaded linux-raw-sys v0.4.11 [INFO] [stderr] Downloaded gmp-mpfr-sys v1.6.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2cbd38cd371c4e4aee8b4e7c19bbf94c5ed47c151d5088c1478646812aea6082 [INFO] running `Command { std: "docker" "start" "-a" "2cbd38cd371c4e4aee8b4e7c19bbf94c5ed47c151d5088c1478646812aea6082", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2cbd38cd371c4e4aee8b4e7c19bbf94c5ed47c151d5088c1478646812aea6082", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2cbd38cd371c4e4aee8b4e7c19bbf94c5ed47c151d5088c1478646812aea6082", kill_on_drop: false }` [INFO] [stdout] 2cbd38cd371c4e4aee8b4e7c19bbf94c5ed47c151d5088c1478646812aea6082 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 12443a42629452484fc5ec612905dffa6bc4e23401e7935cea2d7b44e871a603 [INFO] running `Command { std: "docker" "start" "-a" "12443a42629452484fc5ec612905dffa6bc4e23401e7935cea2d7b44e871a603", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.150 [INFO] [stderr] Compiling rustix v0.38.21 [INFO] [stderr] Checking linux-raw-sys v0.4.11 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Compiling gmp-mpfr-sys v1.6.1 [INFO] [stderr] Compiling crossbeam-utils v0.8.16 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Checking anstyle v1.0.4 [INFO] [stderr] Compiling az v1.2.1 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Checking anstyle-parse v0.2.2 [INFO] [stderr] Checking miniz_oxide v0.7.1 [INFO] [stderr] Checking clap_lex v0.5.1 [INFO] [stderr] Compiling rug v1.22.0 [INFO] [stderr] Checking base64 v0.21.5 [INFO] [stderr] Checking ieee754 v0.2.6 [INFO] [stderr] Checking flate2 v1.0.28 [INFO] [stderr] Checking crossbeam-channel v0.5.8 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Checking anstream v0.3.2 [INFO] [stderr] Checking clap_builder v4.3.24 [INFO] [stderr] Checking getrandom v0.2.11 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking hdrhistogram v7.5.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/lib.rs:608:52 [INFO] [stdout] | [INFO] [stdout] 608 | let mut needs_restat = self.total_count == u64::max_value(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 608 - let mut needs_restat = self.total_count == u64::max_value(); [INFO] [stdout] 608 + let mut needs_restat = self.total_count == u64::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/lib.rs:741:18 [INFO] [stdout] | [INFO] [stdout] 741 | if low > u64::max_value() / 2 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 741 - if low > u64::max_value() / 2 { [INFO] [stdout] 741 + if low > u64::MAX / 2 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/lib.rs:1476:21 [INFO] [stdout] | [INFO] [stdout] 1476 | if value == u64::max_value() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 1476 - if value == u64::max_value() { [INFO] [stdout] 1476 + if value == u64::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/lib.rs:1477:13 [INFO] [stdout] | [INFO] [stdout] 1477 | u64::max_value() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 1477 - u64::max_value() [INFO] [stdout] 1477 + u64::MAX [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/lib.rs:1618:45 [INFO] [stdout] | [INFO] [stdout] 1618 | if smallest_untrackable_value > u64::max_value() / 2 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 1618 - if smallest_untrackable_value > u64::max_value() / 2 { [INFO] [stdout] 1618 + if smallest_untrackable_value > u64::MAX / 2 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/lib.rs:1708:45 [INFO] [stdout] | [INFO] [stdout] 1708 | self.min_non_zero_value = if min == u64::max_value() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 1708 - self.min_non_zero_value = if min == u64::max_value() { [INFO] [stdout] 1708 + self.min_non_zero_value = if min == u64::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/serialization/deserializer.rs:168:27 [INFO] [stdout] | [INFO] [stdout] 168 | reader.read_exact(&mut payload_slice)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `payload_slice` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/serialization/interval_log/mod.rs:94:5 [INFO] [stdout] | [INFO] [stdout] 94 | //! since the epoch. The first interval's timestamp is stored to the StartTime field. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 94 | //! since the epoch. The first interval's timestamp is stored to the StartTime field. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/serialization/interval_log/mod.rs:96:5 [INFO] [stdout] | [INFO] [stdout] 96 | //! may be interpreted as deltas to be added to StartTime or as "absolute" Unix time depending on a [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 96 | //! may be interpreted as deltas to be added to StartTime or as "absolute" Unix time depending on a [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/serialization/interval_log/mod.rs:97:5 [INFO] [stdout] | [INFO] [stdout] 97 | //! heuristic. In other words, the heuristic chooses between setting the effective BaseTime to 0 or [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 97 | //! heuristic. In other words, the heuristic chooses between setting the effective BaseTime to 0 or [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/serialization/interval_log/mod.rs:98:5 [INFO] [stdout] | [INFO] [stdout] 98 | //! to StartTime. Specifically, the heuristic interprets interval timestamps as deltas if they are [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 98 | //! to StartTime. Specifically, the heuristic interprets interval timestamps as deltas if they are [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/serialization/interval_log/mod.rs:99:5 [INFO] [stdout] | [INFO] [stdout] 99 | //! more than a year's worth of seconds smaller than StartTime and as absolute timestamps otherwise. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 99 | //! more than a year's worth of seconds smaller than StartTime and as absolute timestamps otherwise. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/serialization/interval_log/mod.rs:101:5 [INFO] [stdout] | [INFO] [stdout] 101 | //! interpreted as deltas. The first interval's (delta) timestamp is stored to the StartTime field. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 101 | //! interpreted as deltas. The first interval's (delta) timestamp is stored to the StartTime field. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/serialization/interval_log/mod.rs:102:5 [INFO] [stdout] | [INFO] [stdout] 102 | //! This is likely a bug, since StartTime should be an absolute timestamp, and appears to cause [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 102 | //! This is likely a bug, since StartTime should be an absolute timestamp, and appears to cause [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/serialization/interval_log/mod.rs:103:5 [INFO] [stdout] | [INFO] [stdout] 103 | //! erroneous behavior when filtering by offset timestamps. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 103 | //! erroneous behavior when filtering by offset timestamps. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/serialization/interval_log/mod.rs:105:5 [INFO] [stdout] | [INFO] [stdout] 105 | //! present: it's a number of seconds since epoch that serves as the starting point for the [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 105 | //! present: it's a number of seconds since epoch that serves as the starting point for the [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/serialization/interval_log/mod.rs:106:5 [INFO] [stdout] | [INFO] [stdout] 106 | //! per-interval deltas to get a wall-clock time for each interval. No heuristics are applied to [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 106 | //! per-interval deltas to get a wall-clock time for each interval. No heuristics are applied to [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/serialization/interval_log/mod.rs:107:5 [INFO] [stdout] | [INFO] [stdout] 107 | //! guess whether or not the intervals are absolute or deltas. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 107 | //! guess whether or not the intervals are absolute or deltas. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/serialization/interval_log/mod.rs:319:43 [INFO] [stdout] | [INFO] [stdout] 319 | internal_writer.write_comment(&c)?; [INFO] [stdout] | ^^ help: change this to: `c` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this multiplication by -1 can be written more succinctly [INFO] [stdout] --> src/serialization/interval_log/mod.rs:705:19 [INFO] [stdout] | [INFO] [stdout] 705 | Err(t) => duration_as_fp_seconds(t.duration()) * -1_f64, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `-duration_as_fp_seconds(t.duration())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stdout] = note: `#[warn(clippy::neg_multiply)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/lib.rs:1045:9 [INFO] [stdout] | [INFO] [stdout] 1045 | &self, [INFO] [stdout] | ^^^^^ the lifetime is elided here [INFO] [stdout] 1046 | ticks_per_half_distance: u32, [INFO] [stdout] 1047 | ) -> HistogramIterator> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | the same lifetime is hidden here [INFO] [stdout] | the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 1047 | ) -> HistogramIterator<'_, T, iterators::quantile::Iter<'_, T>> { [INFO] [stdout] | +++ +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/lib.rs:1107:24 [INFO] [stdout] | [INFO] [stdout] 1107 | pub fn iter_linear(&self, step: u64) -> HistogramIterator> { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | | [INFO] [stdout] | | | the same lifetime is hidden here [INFO] [stdout] | | the same lifetime is hidden here [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 1107 | pub fn iter_linear(&self, step: u64) -> HistogramIterator<'_, T, iterators::linear::Iter<'_, T>> { [INFO] [stdout] | +++ +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/lib.rs:1145:21 [INFO] [stdout] | [INFO] [stdout] 1145 | pub fn iter_log(&self, start: u64, exp: f64) -> HistogramIterator> { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | | [INFO] [stdout] | | | the same lifetime is hidden here [INFO] [stdout] | | the same lifetime is hidden here [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 1145 | pub fn iter_log(&self, start: u64, exp: f64) -> HistogramIterator<'_, T, iterators::log::Iter<'_, T>> { [INFO] [stdout] | +++ +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/lib.rs:1183:26 [INFO] [stdout] | [INFO] [stdout] 1183 | pub fn iter_recorded(&self) -> HistogramIterator { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 1183 | pub fn iter_recorded(&self) -> HistogramIterator<'_, T, iterators::recorded::Iter> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/lib.rs:1242:21 [INFO] [stdout] | [INFO] [stdout] 1242 | pub fn iter_all(&self) -> HistogramIterator { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 1242 | pub fn iter_all(&self) -> HistogramIterator<'_, T, iterators::all::Iter> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/iterators/recorded.rs:12:34 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn new(hist: &Histogram) -> HistogramIterator { [INFO] [stdout] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 12 | pub fn new(hist: &Histogram) -> HistogramIterator<'_, T, Iter> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/iterators/all.rs:12:34 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn new(hist: &Histogram) -> HistogramIterator { [INFO] [stdout] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 12 | pub fn new(hist: &Histogram) -> HistogramIterator<'_, T, Iter> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/serialization/interval_log/mod.rs:709:22 [INFO] [stdout] | [INFO] [stdout] 709 | fn start_time(input: &[u8]) -> IResult<&[u8], LogEntry> { [INFO] [stdout] | ^^^^^ ^^^^^ ^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | | [INFO] [stdout] | | the same lifetime is elided here [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 709 | fn start_time(input: &[u8]) -> IResult<&[u8], LogEntry<'_>> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/serialization/interval_log/mod.rs:718:21 [INFO] [stdout] | [INFO] [stdout] 718 | fn base_time(input: &[u8]) -> IResult<&[u8], LogEntry> { [INFO] [stdout] | ^^^^^ ^^^^^ ^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | | [INFO] [stdout] | | the same lifetime is elided here [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 718 | fn base_time(input: &[u8]) -> IResult<&[u8], LogEntry<'_>> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/serialization/interval_log/mod.rs:734:22 [INFO] [stdout] | [INFO] [stdout] 734 | fn tag_parser(input: &[u8]) -> IResult<&[u8], Tag> { [INFO] [stdout] | ^^^^^ ^^^^^ ^^^ the same lifetime is hidden here [INFO] [stdout] | | | [INFO] [stdout] | | the same lifetime is elided here [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 734 | fn tag_parser(input: &[u8]) -> IResult<&[u8], Tag<'_>> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/serialization/interval_log/mod.rs:739:25 [INFO] [stdout] | [INFO] [stdout] 739 | fn interval_hist(input: &[u8]) -> IResult<&[u8], LogEntry> { [INFO] [stdout] | ^^^^^ ^^^^^ ^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | | [INFO] [stdout] | | the same lifetime is elided here [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 739 | fn interval_hist(input: &[u8]) -> IResult<&[u8], LogEntry<'_>> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/serialization/interval_log/mod.rs:811:27 [INFO] [stdout] | [INFO] [stdout] 811 | fn fract_sec_tuple(input: &[u8]) -> FResult { [INFO] [stdout] | ^^^^^ ^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 811 | fn fract_sec_tuple(input: &[u8]) -> FResult<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/sync/mod.rs:211:17 [INFO] [stdout] | [INFO] [stdout] 211 | pub fn idle(&mut self) -> IdleRecorderGuard { [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 211 | pub fn idle(&mut self) -> IdleRecorderGuard<'_, C> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking clap v4.3.24 [INFO] [stdout] warning: digits grouped inconsistently by underscores [INFO] [stdout] --> tests/serialization.rs:58:20 [INFO] [stdout] | [INFO] [stdout] 58 | h.record_n(1000_000, i64::max_value() as u64).unwrap(); [INFO] [stdout] | ^^^^^^^^ help: consider: `1_000_000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stdout] = note: `#[warn(clippy::inconsistent_digit_grouping)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/serialization.rs:53:58 [INFO] [stdout] | [INFO] [stdout] 53 | let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 53 - let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] 53 + let mut h = Histogram::::new_with_bounds(1, u64::MAX, 3).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/serialization.rs:56:23 [INFO] [stdout] | [INFO] [stdout] 56 | h.record_n(1, i64::max_value() as u64).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 56 - h.record_n(1, i64::max_value() as u64).unwrap(); [INFO] [stdout] 56 + h.record_n(1, i64::MAX as u64).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/serialization.rs:57:26 [INFO] [stdout] | [INFO] [stdout] 57 | h.record_n(1000, i64::max_value() as u64).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 57 - h.record_n(1000, i64::max_value() as u64).unwrap(); [INFO] [stdout] 57 + h.record_n(1000, i64::MAX as u64).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/serialization.rs:58:30 [INFO] [stdout] | [INFO] [stdout] 58 | h.record_n(1000_000, i64::max_value() as u64).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 58 - h.record_n(1000_000, i64::max_value() as u64).unwrap(); [INFO] [stdout] 58 + h.record_n(1000_000, i64::MAX as u64).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/serialization.rs:59:20 [INFO] [stdout] | [INFO] [stdout] 59 | assert_eq!(u64::max_value(), h.len()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 59 - assert_eq!(u64::max_value(), h.len()); [INFO] [stdout] 59 + assert_eq!(u64::MAX, h.len()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/serialization.rs:67:20 [INFO] [stdout] | [INFO] [stdout] 67 | assert_eq!(u64::max_value(), deser_h.len()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 67 - assert_eq!(u64::max_value(), deser_h.len()); [INFO] [stdout] 67 + assert_eq!(u64::MAX, deser_h.len()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/serialization.rs:73:43 [INFO] [stdout] | [INFO] [stdout] 73 | Histogram::new_with_bounds(1, u64::max_value() >> 1, 3).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 73 - Histogram::new_with_bounds(1, u64::max_value() >> 1, 3).unwrap(); [INFO] [stdout] 73 + Histogram::new_with_bounds(1, u64::MAX >> 1, 3).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/interval_log.rs:52:43 [INFO] [stdout] | [INFO] [stdout] 52 | intervals.iter().filter(|ilh| !ilh.tag().is_none()).count() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `ilh.tag().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/interval_log.rs:111:31 [INFO] [stdout] | [INFO] [stdout] 111 | .filter(|ilh| !ilh.tag().is_none()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `ilh.tag().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/interval_log.rs:237:66 [INFO] [stdout] | [INFO] [stdout] 237 | let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 237 - let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] 237 + let mut h = Histogram::::new_with_bounds(1, u64::MAX, 3).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `as_ref.map(...)` does nothing [INFO] [stdout] --> tests/interval_log.rs:299:46 [INFO] [stdout] | [INFO] [stdout] 299 | let tag_string: Option = tags.get(index).unwrap().as_ref().map(|s| s.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `tags.get(index).unwrap().clone()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stdout] = note: `#[warn(clippy::useless_asref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/interval_log.rs:308:49 [INFO] [stdout] | [INFO] [stdout] 308 | let mut iter = IntervalLogIterator::new(&log); [INFO] [stdout] | ^^^^ help: change this to: `log` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> tests/interval_log.rs:326:32 [INFO] [stdout] | [INFO] [stdout] 326 | fn load_iterator_from_file<'a>(path: &Path) -> IntervalLogBufHolder { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> benches/../src/serialization/rand_varint.rs:10:13 [INFO] [stdout] | [INFO] [stdout] 10 | assert!(byte_length <= 9 && byte_length >= 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(1..=9).contains(&byte_length)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> benches/../src/serialization/rand_varint.rs:21:13 [INFO] [stdout] | [INFO] [stdout] 21 | assert!(byte_length <= 9 && byte_length >= 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(1..=9).contains(&byte_length)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> benches/../src/serialization/rand_varint.rs:24:14 [INFO] [stdout] | [INFO] [stdout] 24 | 9 => u64::max_value(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 24 - 9 => u64::max_value(), [INFO] [stdout] 24 + 9 => u64::MAX, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> benches/interval_log.rs:25:58 [INFO] [stdout] | [INFO] [stdout] 25 | let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 25 - let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] 25 + let mut h = Histogram::::new_with_bounds(1, u64::MAX, 3).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> benches/interval_log.rs:59:58 [INFO] [stdout] | [INFO] [stdout] 59 | let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 59 - let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] 59 + let mut h = Histogram::::new_with_bounds(1, u64::MAX, 3).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits grouped inconsistently by underscores [INFO] [stdout] --> tests/iterators.rs:553:16 [INFO] [stdout] | [INFO] [stdout] 553 | (1000, 1000_000, 1000_000, 1.0, 0.25), [INFO] [stdout] | ^^^^^^^^ help: consider: `1_000_000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stdout] = note: `#[warn(clippy::inconsistent_digit_grouping)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits grouped inconsistently by underscores [INFO] [stdout] --> tests/iterators.rs:553:26 [INFO] [stdout] | [INFO] [stdout] 553 | (1000, 1000_000, 1000_000, 1.0, 0.25), [INFO] [stdout] | ^^^^^^^^ help: consider: `1_000_000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits grouped inconsistently by underscores [INFO] [stdout] --> tests/iterators.rs:554:19 [INFO] [stdout] | [INFO] [stdout] 554 | (1000, 0, 1000_000, 1.0, 1.0), [INFO] [stdout] | ^^^^^^^^ help: consider: `1_000_000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> benches/../src/serialization/rand_varint.rs:10:13 [INFO] [stdout] | [INFO] [stdout] 10 | assert!(byte_length <= 9 && byte_length >= 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(1..=9).contains(&byte_length)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> benches/../src/serialization/rand_varint.rs:21:13 [INFO] [stdout] | [INFO] [stdout] 21 | assert!(byte_length <= 9 && byte_length >= 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(1..=9).contains(&byte_length)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:240:44 [INFO] [stdout] | [INFO] [stdout] 240 | let h = Histogram::::new_with_max(u64::max_value(), 3).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 240 - let h = Histogram::::new_with_max(u64::max_value(), 3).unwrap(); [INFO] [stdout] 240 + let h = Histogram::::new_with_max(u64::MAX, 3).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:241:33 [INFO] [stdout] | [INFO] [stdout] 241 | let _ = h.median_equivalent(u64::max_value()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 241 - let _ = h.median_equivalent(u64::max_value()); [INFO] [stdout] 241 + let _ = h.median_equivalent(u64::MAX); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:242:33 [INFO] [stdout] | [INFO] [stdout] 242 | let _ = h.median_equivalent(u64::max_value() - 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 242 - let _ = h.median_equivalent(u64::max_value() - 1); [INFO] [stdout] 242 + let _ = h.median_equivalent(u64::MAX - 1); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> benches/../src/serialization/rand_varint.rs:24:14 [INFO] [stdout] | [INFO] [stdout] 24 | 9 => u64::max_value(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 24 - 9 => u64::max_value(), [INFO] [stdout] 24 + 9 => u64::MAX, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:344:54 [INFO] [stdout] | [INFO] [stdout] 344 | let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 5).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 344 - let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 5).unwrap(); [INFO] [stdout] 344 + let mut h = Histogram::::new_with_bounds(1, u64::MAX, 5).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:360:54 [INFO] [stdout] | [INFO] [stdout] 360 | let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 360 - let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 0).unwrap(); [INFO] [stdout] 360 + let mut h = Histogram::::new_with_bounds(1, u64::MAX, 0).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:391:19 [INFO] [stdout] | [INFO] [stdout] 391 | h.record_n(3, u16::max_value() - 1).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 391 - h.record_n(3, u16::max_value() - 1).unwrap(); [INFO] [stdout] 391 + h.record_n(3, u16::MAX - 1).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:392:19 [INFO] [stdout] | [INFO] [stdout] 392 | h.record_n(3, u16::max_value() - 1).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 392 - h.record_n(3, u16::max_value() - 1).unwrap(); [INFO] [stdout] 392 + h.record_n(3, u16::MAX - 1).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:395:16 [INFO] [stdout] | [INFO] [stdout] 395 | assert_eq!(u16::max_value(), h.count_at(3)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 395 - assert_eq!(u16::max_value(), h.count_at(3)); [INFO] [stdout] 395 + assert_eq!(u16::MAX, h.count_at(3)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:397:26 [INFO] [stdout] | [INFO] [stdout] 397 | assert_eq!(u64::from(u16::max_value() - 1) * 2, h.len()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 397 - assert_eq!(u64::from(u16::max_value() - 1) * 2, h.len()); [INFO] [stdout] 397 + assert_eq!(u64::from(u16::MAX - 1) * 2, h.len()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:402:54 [INFO] [stdout] | [INFO] [stdout] 402 | let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 402 - let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] 402 + let mut h = Histogram::::new_with_bounds(1, u64::MAX, 3).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:404:19 [INFO] [stdout] | [INFO] [stdout] 404 | h.record_n(1, u64::max_value() - 1).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 404 - h.record_n(1, u64::max_value() - 1).unwrap(); [INFO] [stdout] 404 + h.record_n(1, u64::MAX - 1).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:405:19 [INFO] [stdout] | [INFO] [stdout] 405 | h.record_n(1, u64::max_value() - 1).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 405 - h.record_n(1, u64::max_value() - 1).unwrap(); [INFO] [stdout] 405 + h.record_n(1, u64::MAX - 1).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:407:16 [INFO] [stdout] | [INFO] [stdout] 407 | assert_eq!(u64::max_value(), h.count_at(1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 407 - assert_eq!(u64::max_value(), h.count_at(1)); [INFO] [stdout] 407 + assert_eq!(u64::MAX, h.count_at(1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:408:16 [INFO] [stdout] | [INFO] [stdout] 408 | assert_eq!(u64::max_value(), h.len()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 408 - assert_eq!(u64::max_value(), h.len()); [INFO] [stdout] 408 + assert_eq!(u64::MAX, h.len()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:416:19 [INFO] [stdout] | [INFO] [stdout] 416 | h.record_n(1, u64::max_value() - 1).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 416 - h.record_n(1, u64::max_value() - 1).unwrap(); [INFO] [stdout] 416 + h.record_n(1, u64::MAX - 1).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:417:19 [INFO] [stdout] | [INFO] [stdout] 417 | h.record_n(1, u64::max_value() - 1).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 417 - h.record_n(1, u64::max_value() - 1).unwrap(); [INFO] [stdout] 417 + h.record_n(1, u64::MAX - 1).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:420:31 [INFO] [stdout] | [INFO] [stdout] 420 | h.record_n(1_000_000_000, u64::max_value() - 1).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 420 - h.record_n(1_000_000_000, u64::max_value() - 1).unwrap(); [INFO] [stdout] 420 + h.record_n(1_000_000_000, u64::MAX - 1).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:421:31 [INFO] [stdout] | [INFO] [stdout] 421 | h.record_n(1_000_000_000, u64::max_value() - 1).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 421 - h.record_n(1_000_000_000, u64::max_value() - 1).unwrap(); [INFO] [stdout] 421 + h.record_n(1_000_000_000, u64::MAX - 1).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:423:16 [INFO] [stdout] | [INFO] [stdout] 423 | assert_eq!(u64::max_value(), h.count_at(1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 423 - assert_eq!(u64::max_value(), h.count_at(1)); [INFO] [stdout] 423 + assert_eq!(u64::MAX, h.count_at(1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:424:16 [INFO] [stdout] | [INFO] [stdout] 424 | assert_eq!(u64::max_value(), h.count_at(1_000_000_000)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 424 - assert_eq!(u64::max_value(), h.count_at(1_000_000_000)); [INFO] [stdout] 424 + assert_eq!(u64::MAX, h.count_at(1_000_000_000)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> benches/serialization.rs:43:56 [INFO] [stdout] | [INFO] [stdout] 43 | do_serialize_bench(b, &mut V2Serializer::new(), 1, u64::max_value(), 3, 1.5) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 43 - do_serialize_bench(b, &mut V2Serializer::new(), 1, u64::max_value(), 3, 1.5) [INFO] [stdout] 43 + do_serialize_bench(b, &mut V2Serializer::new(), 1, u64::MAX, 3, 1.5) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:425:16 [INFO] [stdout] | [INFO] [stdout] 425 | assert_eq!(u64::max_value(), h.len()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 425 - assert_eq!(u64::max_value(), h.len()); [INFO] [stdout] 425 + assert_eq!(u64::MAX, h.len()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> benches/serialization.rs:49:56 [INFO] [stdout] | [INFO] [stdout] 49 | do_serialize_bench(b, &mut V2Serializer::new(), 1, u64::max_value(), 3, 0.1) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 49 - do_serialize_bench(b, &mut V2Serializer::new(), 1, u64::max_value(), 3, 0.1) [INFO] [stdout] 49 + do_serialize_bench(b, &mut V2Serializer::new(), 1, u64::MAX, 3, 0.1) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:430:54 [INFO] [stdout] | [INFO] [stdout] 430 | let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 430 - let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] 430 + let mut h = Histogram::::new_with_bounds(1, u64::MAX, 3).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:431:55 [INFO] [stdout] | [INFO] [stdout] 431 | let mut h2 = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 431 - let mut h2 = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] 431 + let mut h2 = Histogram::::new_with_bounds(1, u64::MAX, 3).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:433:19 [INFO] [stdout] | [INFO] [stdout] 433 | h.record_n(1, u64::max_value() - 1).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 433 - h.record_n(1, u64::max_value() - 1).unwrap(); [INFO] [stdout] 433 + h.record_n(1, u64::MAX - 1).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:434:20 [INFO] [stdout] | [INFO] [stdout] 434 | h2.record_n(1, u64::max_value() - 1).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 434 - h2.record_n(1, u64::max_value() - 1).unwrap(); [INFO] [stdout] 434 + h2.record_n(1, u64::MAX - 1).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:437:16 [INFO] [stdout] | [INFO] [stdout] 437 | assert_eq!(u64::max_value(), h.count_at(1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 437 - assert_eq!(u64::max_value(), h.count_at(1)); [INFO] [stdout] 437 + assert_eq!(u64::MAX, h.count_at(1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:438:16 [INFO] [stdout] | [INFO] [stdout] 438 | assert_eq!(u64::max_value(), h.len()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 438 - assert_eq!(u64::max_value(), h.len()); [INFO] [stdout] 438 + assert_eq!(u64::MAX, h.len()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:443:54 [INFO] [stdout] | [INFO] [stdout] 443 | let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 443 - let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] 443 + let mut h = Histogram::::new_with_bounds(1, u64::MAX, 3).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:445:55 [INFO] [stdout] | [INFO] [stdout] 445 | let mut h2 = Histogram::::new_with_bounds(1, u64::max_value(), 4).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 445 - let mut h2 = Histogram::::new_with_bounds(1, u64::max_value(), 4).unwrap(); [INFO] [stdout] 445 + let mut h2 = Histogram::::new_with_bounds(1, u64::MAX, 4).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:447:19 [INFO] [stdout] | [INFO] [stdout] 447 | h.record_n(1, u64::max_value() - 1).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 447 - h.record_n(1, u64::max_value() - 1).unwrap(); [INFO] [stdout] 447 + h.record_n(1, u64::MAX - 1).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:448:20 [INFO] [stdout] | [INFO] [stdout] 448 | h2.record_n(1, u64::max_value() - 1).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 448 - h2.record_n(1, u64::max_value() - 1).unwrap(); [INFO] [stdout] 448 + h2.record_n(1, u64::MAX - 1).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:451:16 [INFO] [stdout] | [INFO] [stdout] 451 | assert_eq!(u64::max_value(), h.count_at(1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 451 - assert_eq!(u64::max_value(), h.count_at(1)); [INFO] [stdout] 451 + assert_eq!(u64::MAX, h.count_at(1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> benches/serialization.rs:55:56 [INFO] [stdout] | [INFO] [stdout] 55 | do_serialize_bench(b, &mut V2Serializer::new(), 1, u64::max_value(), 5, 1.5) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 55 - do_serialize_bench(b, &mut V2Serializer::new(), 1, u64::max_value(), 5, 1.5) [INFO] [stdout] 55 + do_serialize_bench(b, &mut V2Serializer::new(), 1, u64::MAX, 5, 1.5) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> benches/serialization.rs:61:56 [INFO] [stdout] | [INFO] [stdout] 61 | do_serialize_bench(b, &mut V2Serializer::new(), 1, u64::max_value(), 5, 0.1) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 61 - do_serialize_bench(b, &mut V2Serializer::new(), 1, u64::max_value(), 5, 0.1) [INFO] [stdout] 61 + do_serialize_bench(b, &mut V2Serializer::new(), 1, u64::MAX, 5, 0.1) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:452:16 [INFO] [stdout] | [INFO] [stdout] 452 | assert_eq!(u64::max_value(), h.len()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 452 - assert_eq!(u64::max_value(), h.len()); [INFO] [stdout] 452 + assert_eq!(u64::MAX, h.len()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/quantile.rs:28:54 [INFO] [stdout] | [INFO] [stdout] 28 | let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 28 - let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] 28 + let mut h = Histogram::::new_with_bounds(1, u64::MAX, 3).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> benches/serialization.rs:71:9 [INFO] [stdout] | [INFO] [stdout] 71 | u64::max_value(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 71 - u64::max_value(), [INFO] [stdout] 71 + u64::MAX, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:461:19 [INFO] [stdout] | [INFO] [stdout] 461 | h.record_n(1, u64::max_value() - 1).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 461 - h.record_n(1, u64::max_value() - 1).unwrap(); [INFO] [stdout] 461 + h.record_n(1, u64::MAX - 1).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> benches/serialization.rs:84:9 [INFO] [stdout] | [INFO] [stdout] 84 | u64::max_value(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 84 - u64::max_value(), [INFO] [stdout] 84 + u64::MAX, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:462:20 [INFO] [stdout] | [INFO] [stdout] 462 | h2.record_n(1, u64::max_value() - 1).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 462 - h2.record_n(1, u64::max_value() - 1).unwrap(); [INFO] [stdout] 462 + h2.record_n(1, u64::MAX - 1).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:464:33 [INFO] [stdout] | [INFO] [stdout] 464 | h2.record_n(10_000_000_000, u64::max_value() - 1).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 464 - h2.record_n(10_000_000_000, u64::max_value() - 1).unwrap(); [INFO] [stdout] 464 + h2.record_n(10_000_000_000, u64::MAX - 1).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:467:16 [INFO] [stdout] | [INFO] [stdout] 467 | assert_eq!(u64::max_value(), h.count_at(1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 467 - assert_eq!(u64::max_value(), h.count_at(1)); [INFO] [stdout] 467 + assert_eq!(u64::MAX, h.count_at(1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:468:16 [INFO] [stdout] | [INFO] [stdout] 468 | assert_eq!(u64::max_value(), h.len()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 468 - assert_eq!(u64::max_value(), h.len()); [INFO] [stdout] 468 + assert_eq!(u64::MAX, h.len()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:473:54 [INFO] [stdout] | [INFO] [stdout] 473 | let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 473 - let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] 473 + let mut h = Histogram::::new_with_bounds(1, u64::MAX, 3).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:475:19 [INFO] [stdout] | [INFO] [stdout] 475 | h.record_n(1, u64::max_value() - 1).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 475 - h.record_n(1, u64::max_value() - 1).unwrap(); [INFO] [stdout] 475 + h.record_n(1, u64::MAX - 1).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:476:20 [INFO] [stdout] | [INFO] [stdout] 476 | h.record_n(10, u64::max_value() - 1).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 476 - h.record_n(10, u64::max_value() - 1).unwrap(); [INFO] [stdout] 476 + h.record_n(10, u64::MAX - 1).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:478:16 [INFO] [stdout] | [INFO] [stdout] 478 | assert_eq!(u64::max_value() - 1, h.count_at(1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 478 - assert_eq!(u64::max_value() - 1, h.count_at(1)); [INFO] [stdout] 478 + assert_eq!(u64::MAX - 1, h.count_at(1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:479:16 [INFO] [stdout] | [INFO] [stdout] 479 | assert_eq!(u64::max_value() - 1, h.count_at(10)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 479 - assert_eq!(u64::max_value() - 1, h.count_at(10)); [INFO] [stdout] 479 + assert_eq!(u64::MAX - 1, h.count_at(10)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:480:16 [INFO] [stdout] | [INFO] [stdout] 480 | assert_eq!(u64::max_value(), h.len()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 480 - assert_eq!(u64::max_value(), h.len()); [INFO] [stdout] 480 + assert_eq!(u64::MAX, h.len()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/quantile.rs:48:54 [INFO] [stdout] | [INFO] [stdout] 48 | let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 48 - let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] 48 + let mut h = Histogram::::new_with_bounds(1, u64::MAX, 3).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:485:54 [INFO] [stdout] | [INFO] [stdout] 485 | let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 485 - let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] 485 + let mut h = Histogram::::new_with_bounds(1, u64::MAX, 3).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:486:55 [INFO] [stdout] | [INFO] [stdout] 486 | let mut h2 = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 486 - let mut h2 = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] 486 + let mut h2 = Histogram::::new_with_bounds(1, u64::MAX, 3).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> benches/serialization.rs:117:58 [INFO] [stdout] | [INFO] [stdout] 117 | do_deserialize_bench(b, &mut V2Serializer::new(), 1, u64::max_value(), 3, 1.5) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 117 - do_deserialize_bench(b, &mut V2Serializer::new(), 1, u64::max_value(), 3, 1.5) [INFO] [stdout] 117 + do_deserialize_bench(b, &mut V2Serializer::new(), 1, u64::MAX, 3, 1.5) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:488:19 [INFO] [stdout] | [INFO] [stdout] 488 | h.record_n(1, u64::max_value() - 10).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 488 - h.record_n(1, u64::max_value() - 10).unwrap(); [INFO] [stdout] 488 + h.record_n(1, u64::MAX - 10).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:489:21 [INFO] [stdout] | [INFO] [stdout] 489 | h2.record_n(10, u64::max_value() - 1).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 489 - h2.record_n(10, u64::max_value() - 1).unwrap(); [INFO] [stdout] 489 + h2.record_n(10, u64::MAX - 1).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:495:16 [INFO] [stdout] | [INFO] [stdout] 495 | assert_eq!(u64::max_value() - 10, h.count_at(1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 495 - assert_eq!(u64::max_value() - 10, h.count_at(1)); [INFO] [stdout] 495 + assert_eq!(u64::MAX - 10, h.count_at(1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:499:16 [INFO] [stdout] | [INFO] [stdout] 499 | assert_eq!(u64::max_value(), h.len()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 499 - assert_eq!(u64::max_value(), h.len()); [INFO] [stdout] 499 + assert_eq!(u64::MAX, h.len()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/quantile.rs:62:54 [INFO] [stdout] | [INFO] [stdout] 62 | let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 62 - let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] 62 + let mut h = Histogram::::new_with_bounds(1, u64::MAX, 3).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:504:54 [INFO] [stdout] | [INFO] [stdout] 504 | let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 504 - let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] 504 + let mut h = Histogram::::new_with_bounds(1, u64::MAX, 3).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:505:55 [INFO] [stdout] | [INFO] [stdout] 505 | let mut h2 = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 505 - let mut h2 = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] 505 + let mut h2 = Histogram::::new_with_bounds(1, u64::MAX, 3).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> benches/serialization.rs:123:58 [INFO] [stdout] | [INFO] [stdout] 123 | do_deserialize_bench(b, &mut V2Serializer::new(), 1, u64::max_value(), 3, 0.1) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 123 - do_deserialize_bench(b, &mut V2Serializer::new(), 1, u64::max_value(), 3, 0.1) [INFO] [stdout] 123 + do_deserialize_bench(b, &mut V2Serializer::new(), 1, u64::MAX, 3, 0.1) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:507:19 [INFO] [stdout] | [INFO] [stdout] 507 | h.record_n(1, u64::max_value() - 10).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 507 - h.record_n(1, u64::max_value() - 10).unwrap(); [INFO] [stdout] 507 + h.record_n(1, u64::MAX - 10).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> benches/serialization.rs:129:58 [INFO] [stdout] | [INFO] [stdout] 129 | do_deserialize_bench(b, &mut V2Serializer::new(), 1, u64::max_value(), 5, 1.5) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 129 - do_deserialize_bench(b, &mut V2Serializer::new(), 1, u64::max_value(), 5, 1.5) [INFO] [stdout] 129 + do_deserialize_bench(b, &mut V2Serializer::new(), 1, u64::MAX, 5, 1.5) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:514:16 [INFO] [stdout] | [INFO] [stdout] 514 | assert_eq!(u64::max_value() - 10, h.count_at(1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 514 - assert_eq!(u64::max_value() - 10, h.count_at(1)); [INFO] [stdout] 514 + assert_eq!(u64::MAX - 10, h.count_at(1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:516:16 [INFO] [stdout] | [INFO] [stdout] 516 | assert_eq!(u64::max_value(), h.len()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 516 - assert_eq!(u64::max_value(), h.len()); [INFO] [stdout] 516 + assert_eq!(u64::MAX, h.len()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:521:54 [INFO] [stdout] | [INFO] [stdout] 521 | let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 521 - let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] 521 + let mut h = Histogram::::new_with_bounds(1, u64::MAX, 3).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:523:55 [INFO] [stdout] | [INFO] [stdout] 523 | let mut h2 = Histogram::::new_with_bounds(1, u64::max_value(), 4).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 523 - let mut h2 = Histogram::::new_with_bounds(1, u64::max_value(), 4).unwrap(); [INFO] [stdout] 523 + let mut h2 = Histogram::::new_with_bounds(1, u64::MAX, 4).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> benches/serialization.rs:135:58 [INFO] [stdout] | [INFO] [stdout] 135 | do_deserialize_bench(b, &mut V2Serializer::new(), 1, u64::max_value(), 5, 0.1) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 135 - do_deserialize_bench(b, &mut V2Serializer::new(), 1, u64::max_value(), 5, 0.1) [INFO] [stdout] 135 + do_deserialize_bench(b, &mut V2Serializer::new(), 1, u64::MAX, 5, 0.1) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> benches/serialization.rs:145:9 [INFO] [stdout] | [INFO] [stdout] 145 | u64::max_value(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 145 - u64::max_value(), [INFO] [stdout] 145 + u64::MAX, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:525:19 [INFO] [stdout] | [INFO] [stdout] 525 | h.record_n(1, u64::max_value() - 1).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 525 - h.record_n(1, u64::max_value() - 1).unwrap(); [INFO] [stdout] 525 + h.record_n(1, u64::MAX - 1).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:527:21 [INFO] [stdout] | [INFO] [stdout] 527 | h2.record_n(20, u64::max_value() - 1).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 527 - h2.record_n(20, u64::max_value() - 1).unwrap(); [INFO] [stdout] 527 + h2.record_n(20, u64::MAX - 1).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:530:16 [INFO] [stdout] | [INFO] [stdout] 530 | assert_eq!(u64::max_value() - 1, h.count_at(1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 530 - assert_eq!(u64::max_value() - 1, h.count_at(1)); [INFO] [stdout] 530 + assert_eq!(u64::MAX - 1, h.count_at(1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> benches/serialization.rs:158:9 [INFO] [stdout] | [INFO] [stdout] 158 | u64::max_value(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 158 - u64::max_value(), [INFO] [stdout] 158 + u64::MAX, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:531:16 [INFO] [stdout] | [INFO] [stdout] 531 | assert_eq!(u64::max_value() - 1, h.count_at(20)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 531 - assert_eq!(u64::max_value() - 1, h.count_at(20)); [INFO] [stdout] 531 + assert_eq!(u64::MAX - 1, h.count_at(20)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:532:16 [INFO] [stdout] | [INFO] [stdout] 532 | assert_eq!(u64::max_value(), h.len()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 532 - assert_eq!(u64::max_value(), h.len()); [INFO] [stdout] 532 + assert_eq!(u64::MAX, h.len()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/quantile.rs:89:54 [INFO] [stdout] | [INFO] [stdout] 89 | let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 89 - let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] 89 + let mut h = Histogram::::new_with_bounds(1, u64::MAX, 3).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:541:19 [INFO] [stdout] | [INFO] [stdout] 541 | h.record_n(1, u64::max_value() - 1).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 541 - h.record_n(1, u64::max_value() - 1).unwrap(); [INFO] [stdout] 541 + h.record_n(1, u64::MAX - 1).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:542:20 [INFO] [stdout] | [INFO] [stdout] 542 | h2.record_n(1, u64::max_value() - 1).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 542 - h2.record_n(1, u64::max_value() - 1).unwrap(); [INFO] [stdout] 542 + h2.record_n(1, u64::MAX - 1).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:543:33 [INFO] [stdout] | [INFO] [stdout] 543 | h2.record_n(10_000_000_000, u64::max_value() - 1).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 543 - h2.record_n(10_000_000_000, u64::max_value() - 1).unwrap(); [INFO] [stdout] 543 + h2.record_n(10_000_000_000, u64::MAX - 1).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:546:16 [INFO] [stdout] | [INFO] [stdout] 546 | assert_eq!(u64::max_value(), h.count_at(1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 546 - assert_eq!(u64::max_value(), h.count_at(1)); [INFO] [stdout] 546 + assert_eq!(u64::MAX, h.count_at(1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:547:16 [INFO] [stdout] | [INFO] [stdout] 547 | assert_eq!(u64::max_value(), h.len()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 547 - assert_eq!(u64::max_value(), h.len()); [INFO] [stdout] 547 + assert_eq!(u64::MAX, h.len()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:552:54 [INFO] [stdout] | [INFO] [stdout] 552 | let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 552 - let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] 552 + let mut h = Histogram::::new_with_bounds(1, u64::MAX, 3).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/histogram.rs:553:55 [INFO] [stdout] | [INFO] [stdout] 553 | let mut h2 = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 553 - let mut h2 = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] 553 + let mut h2 = Histogram::::new_with_bounds(1, u64::MAX, 3).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/quantile.rs:143:54 [INFO] [stdout] | [INFO] [stdout] 143 | let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 143 - let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] 143 + let mut h = Histogram::::new_with_bounds(1, u64::MAX, 3).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/auto_resize.rs:11:18 [INFO] [stdout] | [INFO] [stdout] 11 | histogram += u64::max_value(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 11 - histogram += u64::max_value(); [INFO] [stdout] 11 + histogram += u64::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/quantile.rs:199:54 [INFO] [stdout] | [INFO] [stdout] 199 | let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 199 - let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] 199 + let mut h = Histogram::::new_with_bounds(1, u64::MAX, 3).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> tests/quantile.rs:214:44 [INFO] [stdout] | [INFO] [stdout] 214 | let quantile = Rational::from((v as u64, length as u64)).to_f64(); [INFO] [stdout] | ^^^^^^^^ help: try: `v` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> tests/quantile.rs:214:54 [INFO] [stdout] | [INFO] [stdout] 214 | let quantile = Rational::from((v as u64, length as u64)).to_f64(); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `length` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/quantile.rs:238:54 [INFO] [stdout] | [INFO] [stdout] 238 | let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 238 - let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] 238 + let mut h = Histogram::::new_with_bounds(1, u64::MAX, 3).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/quantile.rs:285:54 [INFO] [stdout] | [INFO] [stdout] 285 | let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 285 - let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] 285 + let mut h = Histogram::::new_with_bounds(1, u64::MAX, 3).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> examples/cli.rs:232:8 [INFO] [stdout] | [INFO] [stdout] 232 | Io(io::Error), [INFO] [stdout] | -- ^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `CliError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 232 - Io(io::Error), [INFO] [stdout] 232 + Io(()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> examples/cli.rs:233:24 [INFO] [stdout] | [INFO] [stdout] 233 | HistogramSerialize(V2SerializeError), [INFO] [stdout] | ------------------ ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `CliError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 233 - HistogramSerialize(V2SerializeError), [INFO] [stdout] 233 + HistogramSerialize(()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> examples/cli.rs:234:34 [INFO] [stdout] | [INFO] [stdout] 234 | HistogramSerializeCompressed(V2DeflateSerializeError), [INFO] [stdout] | ---------------------------- ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `CliError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 234 - HistogramSerializeCompressed(V2DeflateSerializeError), [INFO] [stdout] 234 + HistogramSerializeCompressed(()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> examples/cli.rs:235:26 [INFO] [stdout] | [INFO] [stdout] 235 | HistogramDeserialize(DeserializeError), [INFO] [stdout] | -------------------- ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `CliError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 235 - HistogramDeserialize(DeserializeError), [INFO] [stdout] 235 + HistogramDeserialize(()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> examples/cli.rs:236:21 [INFO] [stdout] | [INFO] [stdout] 236 | HistogramRecord(RecordError), [INFO] [stdout] | --------------- ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `CliError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 236 - HistogramRecord(RecordError), [INFO] [stdout] 236 + HistogramRecord(()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> tests/quantile.rs:357:9 [INFO] [stdout] | [INFO] [stdout] 357 | / return Some(match bit_length { [INFO] [stdout] 358 | | 0 => 0, [INFO] [stdout] 359 | | 64 => u64::max_value(), [INFO] [stdout] 360 | | x => self.rng.gen_range(0..1 << x), [INFO] [stdout] 361 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 357 ~ Some(match bit_length { [INFO] [stdout] 358 + 0 => 0, [INFO] [stdout] 359 + 64 => u64::max_value(), [INFO] [stdout] 360 + x => self.rng.gen_range(0..1 << x), [INFO] [stdout] 361 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/quantile.rs:359:19 [INFO] [stdout] | [INFO] [stdout] 359 | 64 => u64::max_value(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 359 - 64 => u64::max_value(), [INFO] [stdout] 359 + 64 => u64::MAX, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> examples/cli.rs:15:37 [INFO] [stdout] | [INFO] [stdout] 15 | let default_max = format!("{}", u64::max_value()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 15 - let default_max = format!("{}", u64::max_value()); [INFO] [stdout] 15 + let default_max = format!("{}", u64::MAX); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's named elsewhere is confusing [INFO] [stdout] --> tests/quantile.rs:346:31 [INFO] [stdout] | [INFO] [stdout] 346 | fn new(rng: &'a mut R) -> RandomMaxIter { [INFO] [stdout] | -- ^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is named here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: consistently use `'a` [INFO] [stdout] | [INFO] [stdout] 346 | fn new(rng: &'a mut R) -> RandomMaxIter<'a, R> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/iterators.rs:5:54 [INFO] [stdout] | [INFO] [stdout] 5 | let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 5 - let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] 5 + let mut h = Histogram::::new_with_bounds(1, u64::MAX, 3).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/iterators.rs:22:54 [INFO] [stdout] | [INFO] [stdout] 22 | let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 22 - let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] 22 + let mut h = Histogram::::new_with_bounds(1, u64::MAX, 3).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/iterators.rs:24:19 [INFO] [stdout] | [INFO] [stdout] 24 | h.record_n(1, u64::max_value()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 24 - h.record_n(1, u64::max_value()).unwrap(); [INFO] [stdout] 24 + h.record_n(1, u64::MAX).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/iterators.rs:25:23 [INFO] [stdout] | [INFO] [stdout] 25 | h.record_n(1_000, u64::max_value()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 25 - h.record_n(1_000, u64::max_value()).unwrap(); [INFO] [stdout] 25 + h.record_n(1_000, u64::MAX).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/iterators.rs:26:27 [INFO] [stdout] | [INFO] [stdout] 26 | h.record_n(1_000_000, u64::max_value()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 26 - h.record_n(1_000_000, u64::max_value()).unwrap(); [INFO] [stdout] 26 + h.record_n(1_000_000, u64::MAX).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/iterators.rs:39:54 [INFO] [stdout] | [INFO] [stdout] 39 | let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 39 - let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] 39 + let mut h = Histogram::::new_with_bounds(1, u64::MAX, 3).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/iterators.rs:41:19 [INFO] [stdout] | [INFO] [stdout] 41 | h.record_n(1, u64::max_value()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 41 - h.record_n(1, u64::max_value()).unwrap(); [INFO] [stdout] 41 + h.record_n(1, u64::MAX).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/iterators.rs:42:19 [INFO] [stdout] | [INFO] [stdout] 42 | h.record_n(4, u64::max_value() - 1).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 42 - h.record_n(4, u64::max_value() - 1).unwrap(); [INFO] [stdout] 42 + h.record_n(4, u64::MAX - 1).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/iterators.rs:43:19 [INFO] [stdout] | [INFO] [stdout] 43 | h.record_n(5, u64::max_value() - 1).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 43 - h.record_n(5, u64::max_value() - 1).unwrap(); [INFO] [stdout] 43 + h.record_n(5, u64::MAX - 1).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/iterators.rs:50:13 [INFO] [stdout] | [INFO] [stdout] 50 | (1, u64::max_value()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 50 - (1, u64::max_value()), [INFO] [stdout] 50 + (1, u64::MAX), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/iterators.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | (5, u64::max_value()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 54 - (5, u64::max_value()), [INFO] [stdout] 54 + (5, u64::MAX), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/iterators.rs:74:54 [INFO] [stdout] | [INFO] [stdout] 74 | let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 74 - let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] 74 + let mut h = Histogram::::new_with_bounds(1, u64::MAX, 3).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `num` is never read [INFO] [stdout] --> tests/data_access.rs:453:5 [INFO] [stdout] | [INFO] [stdout] 453 | num = 0; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `num` is never read [INFO] [stdout] --> tests/data_access.rs:467:9 [INFO] [stdout] | [INFO] [stdout] 467 | num += 1; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/iterators.rs:123:54 [INFO] [stdout] | [INFO] [stdout] 123 | let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 123 - let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] 123 + let mut h = Histogram::::new_with_bounds(1, u64::MAX, 3).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> tests/iterators.rs:191:25 [INFO] [stdout] | [INFO] [stdout] 191 | let nonzero_count = iter_values [INFO] [stdout] | _________________________^ [INFO] [stdout] 192 | | .iter() [INFO] [stdout] 193 | | .filter(|v| v.1 != 0) [INFO] [stdout] 194 | | .map(|&v| v) [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] help: consider calling the dedicated `copied` method [INFO] [stdout] | [INFO] [stdout] 191 ~ let nonzero_count = iter_values [INFO] [stdout] 192 + .iter() [INFO] [stdout] 193 + .filter(|v| v.1 != 0).copied() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> tests/iterators.rs:223:25 [INFO] [stdout] | [INFO] [stdout] 223 | let nonzero_count = iter_values [INFO] [stdout] | _________________________^ [INFO] [stdout] 224 | | .iter() [INFO] [stdout] 225 | | .filter(|v| v.1 != 0) [INFO] [stdout] 226 | | .map(|&v| v) [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] help: consider calling the dedicated `copied` method [INFO] [stdout] | [INFO] [stdout] 223 ~ let nonzero_count = iter_values [INFO] [stdout] 224 + .iter() [INFO] [stdout] 225 + .filter(|v| v.1 != 0).copied() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> benches/../src/serialization/rand_varint.rs:10:13 [INFO] [stdout] | [INFO] [stdout] 10 | assert!(byte_length <= 9 && byte_length >= 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(1..=9).contains(&byte_length)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> benches/../src/serialization/rand_varint.rs:21:13 [INFO] [stdout] | [INFO] [stdout] 21 | assert!(byte_length <= 9 && byte_length >= 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(1..=9).contains(&byte_length)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> benches/../src/serialization/rand_varint.rs:24:14 [INFO] [stdout] | [INFO] [stdout] 24 | 9 => u64::max_value(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 24 - 9 => u64::max_value(), [INFO] [stdout] 24 + 9 => u64::MAX, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> benches/record.rs:16:54 [INFO] [stdout] | [INFO] [stdout] 16 | let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 16 - let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] 16 + let mut h = Histogram::::new_with_bounds(1, u64::MAX, 3).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/iterators.rs:566:23 [INFO] [stdout] | [INFO] [stdout] 566 | h.record_n(i, u64::max_value() / 100).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 566 - h.record_n(i, u64::max_value() / 100).unwrap(); [INFO] [stdout] 566 + h.record_n(i, u64::MAX / 100).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> benches/record.rs:37:54 [INFO] [stdout] | [INFO] [stdout] 37 | let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 37 - let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] 37 + let mut h = Histogram::::new_with_bounds(1, u64::MAX, 3).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> benches/record.rs:45:23 [INFO] [stdout] | [INFO] [stdout] 45 | h.record_n(v, u64::max_value()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 45 - h.record_n(v, u64::max_value()).unwrap(); [INFO] [stdout] 45 + h.record_n(v, u64::MAX).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> benches/record.rs:58:54 [INFO] [stdout] | [INFO] [stdout] 58 | let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 58 - let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] 58 + let mut h = Histogram::::new_with_bounds(1, u64::MAX, 3).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> benches/record.rs:76:54 [INFO] [stdout] | [INFO] [stdout] 76 | let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 76 - let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] 76 + let mut h = Histogram::::new_with_bounds(1, u64::MAX, 3).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> benches/record.rs:92:46 [INFO] [stdout] | [INFO] [stdout] 92 | Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 92 - Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap() [INFO] [stdout] 92 + Histogram::::new_with_bounds(1, u64::MAX, 3).unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> benches/record.rs:98:25 [INFO] [stdout] | [INFO] [stdout] 98 | do_add_benchmark(b, u64::max_value(), || { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 98 - do_add_benchmark(b, u64::max_value(), || { [INFO] [stdout] 98 + do_add_benchmark(b, u64::MAX, || { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> benches/record.rs:99:46 [INFO] [stdout] | [INFO] [stdout] 99 | Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 99 - Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap() [INFO] [stdout] 99 + Histogram::::new_with_bounds(1, u64::MAX, 3).unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> benches/record.rs:106:46 [INFO] [stdout] | [INFO] [stdout] 106 | Histogram::::new_with_bounds(1, u64::max_value(), 2).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 106 - Histogram::::new_with_bounds(1, u64::max_value(), 2).unwrap() [INFO] [stdout] 106 + Histogram::::new_with_bounds(1, u64::MAX, 2).unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> benches/record.rs:112:25 [INFO] [stdout] | [INFO] [stdout] 112 | do_add_benchmark(b, u64::max_value(), || { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 112 - do_add_benchmark(b, u64::max_value(), || { [INFO] [stdout] 112 + do_add_benchmark(b, u64::MAX, || { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> benches/record.rs:113:46 [INFO] [stdout] | [INFO] [stdout] 113 | Histogram::::new_with_bounds(1, u64::max_value(), 2).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 113 - Histogram::::new_with_bounds(1, u64::max_value(), 2).unwrap() [INFO] [stdout] 113 + Histogram::::new_with_bounds(1, u64::MAX, 2).unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> benches/record.rs:120:46 [INFO] [stdout] | [INFO] [stdout] 120 | Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 120 - Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap() [INFO] [stdout] 120 + Histogram::::new_with_bounds(1, u64::MAX, 3).unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> benches/record.rs:134:58 [INFO] [stdout] | [INFO] [stdout] 134 | let mut accum = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 134 - let mut accum = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] 134 + let mut accum = Histogram::::new_with_bounds(1, u64::MAX, 3).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> benches/record.rs:163:58 [INFO] [stdout] | [INFO] [stdout] 163 | let mut accum = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 163 - let mut accum = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] 163 + let mut accum = Histogram::::new_with_bounds(1, u64::MAX, 3).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/data_access.rs:231:54 [INFO] [stdout] | [INFO] [stdout] 231 | let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 231 - let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] 231 + let mut h = Histogram::::new_with_bounds(1, u64::MAX, 3).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/data_access.rs:234:23 [INFO] [stdout] | [INFO] [stdout] 234 | h.record_n(i, u64::max_value() - 1).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 234 - h.record_n(i, u64::max_value() - 1).unwrap(); [INFO] [stdout] 234 + h.record_n(i, u64::MAX - 1).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/data_access.rs:254:38 [INFO] [stdout] | [INFO] [stdout] 254 | assert_eq!(1.0, h.quantile_below(u64::max_value())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 254 - assert_eq!(1.0, h.quantile_below(u64::max_value())); [INFO] [stdout] 254 + assert_eq!(1.0, h.quantile_below(u64::MAX)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/data_access.rs:285:54 [INFO] [stdout] | [INFO] [stdout] 285 | let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 285 - let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] 285 + let mut h = Histogram::::new_with_bounds(1, u64::MAX, 3).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/data_access.rs:288:23 [INFO] [stdout] | [INFO] [stdout] 288 | h.record_n(i, u64::max_value() - 1).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 288 - h.record_n(i, u64::max_value() - 1).unwrap(); [INFO] [stdout] 288 + h.record_n(i, u64::MAX - 1).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/data_access.rs:291:16 [INFO] [stdout] | [INFO] [stdout] 291 | assert_eq!(u64::max_value(), h.count_between(100, 200)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 291 - assert_eq!(u64::max_value(), h.count_between(100, 200)); [INFO] [stdout] 291 + assert_eq!(u64::MAX, h.count_between(100, 200)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> tests/data_access.rs:309:30 [INFO] [stdout] | [INFO] [stdout] 309 | assert_eq!(1, h.count_at(u64::max_value())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 309 - assert_eq!(1, h.count_at(u64::max_value())); [INFO] [stdout] 309 + assert_eq!(1, h.count_at(u64::MAX)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits grouped inconsistently by underscores [INFO] [stdout] --> src/serialization/interval_log/tests.rs:261:46 [INFO] [stdout] | [INFO] [stdout] 261 | let nsecs = rng.gen_range(0..1000) * 1000_000; [INFO] [stdout] | ^^^^^^^^ help: consider: `1_000_000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stdout] = note: `#[warn(clippy::inconsistent_digit_grouping)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/lib.rs:608:52 [INFO] [stdout] | [INFO] [stdout] 608 | let mut needs_restat = self.total_count == u64::max_value(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 608 - let mut needs_restat = self.total_count == u64::max_value(); [INFO] [stdout] 608 + let mut needs_restat = self.total_count == u64::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/lib.rs:741:18 [INFO] [stdout] | [INFO] [stdout] 741 | if low > u64::max_value() / 2 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 741 - if low > u64::max_value() / 2 { [INFO] [stdout] 741 + if low > u64::MAX / 2 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/lib.rs:1476:21 [INFO] [stdout] | [INFO] [stdout] 1476 | if value == u64::max_value() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 1476 - if value == u64::max_value() { [INFO] [stdout] 1476 + if value == u64::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/lib.rs:1477:13 [INFO] [stdout] | [INFO] [stdout] 1477 | u64::max_value() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 1477 - u64::max_value() [INFO] [stdout] 1477 + u64::MAX [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/lib.rs:1618:45 [INFO] [stdout] | [INFO] [stdout] 1618 | if smallest_untrackable_value > u64::max_value() / 2 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 1618 - if smallest_untrackable_value > u64::max_value() / 2 { [INFO] [stdout] 1618 + if smallest_untrackable_value > u64::MAX / 2 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/lib.rs:1708:45 [INFO] [stdout] | [INFO] [stdout] 1708 | self.min_non_zero_value = if min == u64::max_value() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 1708 - self.min_non_zero_value = if min == u64::max_value() { [INFO] [stdout] 1708 + self.min_non_zero_value = if min == u64::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/index_calculation.rs:90:34 [INFO] [stdout] | [INFO] [stdout] 90 | let h = histo64(1_u64 << 52, u64::max_value(), 3); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 90 - let h = histo64(1_u64 << 52, u64::max_value(), 3); [INFO] [stdout] 90 + let h = histo64(1_u64 << 52, u64::MAX, 3); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/index_calculation.rs:126:32 [INFO] [stdout] | [INFO] [stdout] 126 | assert_eq!(1, h.bucket_for(u64::max_value())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 126 - assert_eq!(1, h.bucket_for(u64::max_value())); [INFO] [stdout] 126 + assert_eq!(1, h.bucket_for(u64::MAX)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/index_calculation.rs:127:46 [INFO] [stdout] | [INFO] [stdout] 127 | assert_eq!(1024 + 1023, h.sub_bucket_for(u64::max_value(), 1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 127 - assert_eq!(1024 + 1023, h.sub_bucket_for(u64::max_value(), 1)); [INFO] [stdout] 127 + assert_eq!(1024 + 1023, h.sub_bucket_for(u64::MAX, 1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/index_calculation.rs:151:32 [INFO] [stdout] | [INFO] [stdout] 151 | assert_eq!(1, h.bucket_for(u64::max_value())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 151 - assert_eq!(1, h.bucket_for(u64::max_value())); [INFO] [stdout] 151 + assert_eq!(1, h.bucket_for(u64::MAX)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/index_calculation.rs:152:44 [INFO] [stdout] | [INFO] [stdout] 152 | assert_eq!(128 + 127, h.sub_bucket_for(u64::max_value(), 1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 152 - assert_eq!(128 + 127, h.sub_bucket_for(u64::max_value(), 1)); [INFO] [stdout] 152 + assert_eq!(128 + 127, h.sub_bucket_for(u64::MAX, 1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/index_calculation.rs:168:32 [INFO] [stdout] | [INFO] [stdout] 168 | assert_eq!(1, h.bucket_for(u64::max_value())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 168 - assert_eq!(1, h.bucket_for(u64::max_value())); [INFO] [stdout] 168 + assert_eq!(1, h.bucket_for(u64::MAX)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/index_calculation.rs:169:36 [INFO] [stdout] | [INFO] [stdout] 169 | assert_eq!(1, h.sub_bucket_for(u64::max_value(), 1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 169 - assert_eq!(1, h.sub_bucket_for(u64::max_value(), 1)); [INFO] [stdout] 169 + assert_eq!(1, h.sub_bucket_for(u64::MAX, 1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/init.rs:27:24 [INFO] [stdout] | [INFO] [stdout] 27 | let h = histo64(1, u64::max_value(), 5); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 27 - let h = histo64(1, u64::max_value(), 5); [INFO] [stdout] 27 + let h = histo64(1, u64::MAX, 5); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/init.rs:29:16 [INFO] [stdout] | [INFO] [stdout] 29 | assert_eq!(u64::max_value(), h.highest_trackable_value); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 29 - assert_eq!(u64::max_value(), h.highest_trackable_value); [INFO] [stdout] 29 + assert_eq!(u64::MAX, h.highest_trackable_value); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/init.rs:53:24 [INFO] [stdout] | [INFO] [stdout] 53 | let h = histo64(1, u64::max_value(), 3); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 53 - let h = histo64(1, u64::max_value(), 3); [INFO] [stdout] 53 + let h = histo64(1, u64::MAX, 3); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/init.rs:55:16 [INFO] [stdout] | [INFO] [stdout] 55 | assert_eq!(u64::max_value(), h.highest_trackable_value); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 55 - assert_eq!(u64::max_value(), h.highest_trackable_value); [INFO] [stdout] 55 + assert_eq!(u64::MAX, h.highest_trackable_value); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/init.rs:103:24 [INFO] [stdout] | [INFO] [stdout] 103 | let h = histo64(1, u64::max_value(), 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 103 - let h = histo64(1, u64::max_value(), 0); [INFO] [stdout] 103 + let h = histo64(1, u64::MAX, 0); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/init.rs:105:16 [INFO] [stdout] | [INFO] [stdout] 105 | assert_eq!(u64::max_value(), h.highest_trackable_value); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 105 - assert_eq!(u64::max_value(), h.highest_trackable_value); [INFO] [stdout] 105 + assert_eq!(u64::MAX, h.highest_trackable_value); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/init.rs:127:27 [INFO] [stdout] | [INFO] [stdout] 127 | let h = histo64(1000, u64::max_value(), 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 127 - let h = histo64(1000, u64::max_value(), 0); [INFO] [stdout] 127 + let h = histo64(1000, u64::MAX, 0); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/init.rs:129:16 [INFO] [stdout] | [INFO] [stdout] 129 | assert_eq!(u64::max_value(), h.highest_trackable_value); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 129 - assert_eq!(u64::max_value(), h.highest_trackable_value); [INFO] [stdout] 129 + assert_eq!(u64::MAX, h.highest_trackable_value); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/init.rs:153:27 [INFO] [stdout] | [INFO] [stdout] 153 | let h = histo64(1000, u64::max_value(), 5); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 153 - let h = histo64(1000, u64::max_value(), 5); [INFO] [stdout] 153 + let h = histo64(1000, u64::MAX, 5); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/init.rs:155:16 [INFO] [stdout] | [INFO] [stdout] 155 | assert_eq!(u64::max_value(), h.highest_trackable_value); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 155 - assert_eq!(u64::max_value(), h.highest_trackable_value); [INFO] [stdout] 155 + assert_eq!(u64::MAX, h.highest_trackable_value); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/init.rs:212:21 [INFO] [stdout] | [INFO] [stdout] 212 | let h = histo64(u64::max_value() / 4, u64::max_value(), 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 212 - let h = histo64(u64::max_value() / 4, u64::max_value(), 0); [INFO] [stdout] 212 + let h = histo64(u64::MAX / 4, u64::max_value(), 0); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/init.rs:212:43 [INFO] [stdout] | [INFO] [stdout] 212 | let h = histo64(u64::max_value() / 4, u64::max_value(), 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 212 - let h = histo64(u64::max_value() / 4, u64::max_value(), 0); [INFO] [stdout] 212 + let h = histo64(u64::max_value() / 4, u64::MAX, 0); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/init.rs:214:16 [INFO] [stdout] | [INFO] [stdout] 214 | assert_eq!(u64::max_value(), h.highest_trackable_value); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 214 - assert_eq!(u64::max_value(), h.highest_trackable_value); [INFO] [stdout] 214 + assert_eq!(u64::MAX, h.highest_trackable_value); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/init.rs:215:16 [INFO] [stdout] | [INFO] [stdout] 215 | assert_eq!(u64::max_value() / 4, h.lowest_discernible_value); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 215 - assert_eq!(u64::max_value() / 4, h.lowest_discernible_value); [INFO] [stdout] 215 + assert_eq!(u64::MAX / 4, h.lowest_discernible_value); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/init.rs:243:30 [INFO] [stdout] | [INFO] [stdout] 243 | let h = histo64(1 << 45, u64::max_value(), 5); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 243 - let h = histo64(1 << 45, u64::max_value(), 5); [INFO] [stdout] 243 + let h = histo64(1 << 45, u64::MAX, 5); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/init.rs:245:16 [INFO] [stdout] | [INFO] [stdout] 245 | assert_eq!(u64::max_value(), h.highest_trackable_value); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 245 - assert_eq!(u64::max_value(), h.highest_trackable_value); [INFO] [stdout] 245 + assert_eq!(u64::MAX, h.highest_trackable_value); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/subtract.rs:20:43 [INFO] [stdout] | [INFO] [stdout] 20 | min = Some(cmp::min(min.unwrap_or(u64::max_value()), value)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 20 - min = Some(cmp::min(min.unwrap_or(u64::max_value()), value)); [INFO] [stdout] 20 + min = Some(cmp::min(min.unwrap_or(u64::MAX), value)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/subtract.rs:35:49 [INFO] [stdout] | [INFO] [stdout] 35 | let mut h1 = Histogram::::new_with_max(u64::max_value(), 3).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 35 - let mut h1 = Histogram::::new_with_max(u64::max_value(), 3).unwrap(); [INFO] [stdout] 35 + let mut h1 = Histogram::::new_with_max(u64::MAX, 3).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/subtract.rs:36:49 [INFO] [stdout] | [INFO] [stdout] 36 | let mut h2 = Histogram::::new_with_max(u64::max_value(), 3).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 36 - let mut h2 = Histogram::::new_with_max(u64::max_value(), 3).unwrap(); [INFO] [stdout] 36 + let mut h2 = Histogram::::new_with_max(u64::MAX, 3).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/subtract.rs:64:49 [INFO] [stdout] | [INFO] [stdout] 64 | let mut h1 = Histogram::::new_with_max(u64::max_value(), 3).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 64 - let mut h1 = Histogram::::new_with_max(u64::max_value(), 3).unwrap(); [INFO] [stdout] 64 + let mut h1 = Histogram::::new_with_max(u64::MAX, 3).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/subtract.rs:84:49 [INFO] [stdout] | [INFO] [stdout] 84 | let mut h1 = Histogram::::new_with_max(u64::max_value(), 3).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 84 - let mut h1 = Histogram::::new_with_max(u64::max_value(), 3).unwrap(); [INFO] [stdout] 84 + let mut h1 = Histogram::::new_with_max(u64::MAX, 3).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/subtract.rs:85:49 [INFO] [stdout] | [INFO] [stdout] 85 | let mut h2 = Histogram::::new_with_max(u64::max_value(), 3).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 85 - let mut h2 = Histogram::::new_with_max(u64::max_value(), 3).unwrap(); [INFO] [stdout] 85 + let mut h2 = Histogram::::new_with_max(u64::MAX, 3).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/subtract.rs:103:15 [INFO] [stdout] | [INFO] [stdout] 103 | let max = u64::max_value() / 2; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 103 - let max = u64::max_value() / 2; [INFO] [stdout] 103 + let max = u64::MAX / 2; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/subtract.rs:125:15 [INFO] [stdout] | [INFO] [stdout] 125 | let max = u64::max_value() / 2; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 125 - let max = u64::max_value() / 2; [INFO] [stdout] 125 + let max = u64::MAX / 2; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/subtract.rs:158:49 [INFO] [stdout] | [INFO] [stdout] 158 | let mut h1 = Histogram::::new_with_max(u64::max_value(), 3).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 158 - let mut h1 = Histogram::::new_with_max(u64::max_value(), 3).unwrap(); [INFO] [stdout] 158 + let mut h1 = Histogram::::new_with_max(u64::MAX, 3).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/subtract.rs:159:49 [INFO] [stdout] | [INFO] [stdout] 159 | let mut h2 = Histogram::::new_with_max(u64::max_value(), 3).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 159 - let mut h2 = Histogram::::new_with_max(u64::max_value(), 3).unwrap(); [INFO] [stdout] 159 + let mut h2 = Histogram::::new_with_max(u64::MAX, 3).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/subtract.rs:182:49 [INFO] [stdout] | [INFO] [stdout] 182 | let mut h1 = Histogram::::new_with_max(u64::max_value(), 3).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 182 - let mut h1 = Histogram::::new_with_max(u64::max_value(), 3).unwrap(); [INFO] [stdout] 182 + let mut h1 = Histogram::::new_with_max(u64::MAX, 3).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/subtract.rs:183:49 [INFO] [stdout] | [INFO] [stdout] 183 | let mut h2 = Histogram::::new_with_max(u64::max_value(), 3).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 183 - let mut h2 = Histogram::::new_with_max(u64::max_value(), 3).unwrap(); [INFO] [stdout] 183 + let mut h2 = Histogram::::new_with_max(u64::MAX, 3).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/subtract.rs:205:49 [INFO] [stdout] | [INFO] [stdout] 205 | let mut h1 = Histogram::::new_with_max(u64::max_value(), 3).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 205 - let mut h1 = Histogram::::new_with_max(u64::max_value(), 3).unwrap(); [INFO] [stdout] 205 + let mut h1 = Histogram::::new_with_max(u64::MAX, 3).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/subtract.rs:206:49 [INFO] [stdout] | [INFO] [stdout] 206 | let mut h2 = Histogram::::new_with_max(u64::max_value(), 3).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 206 - let mut h2 = Histogram::::new_with_max(u64::max_value(), 3).unwrap(); [INFO] [stdout] 206 + let mut h2 = Histogram::::new_with_max(u64::MAX, 3).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/subtract.rs:228:49 [INFO] [stdout] | [INFO] [stdout] 228 | let mut h1 = Histogram::::new_with_max(u64::max_value(), 3).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 228 - let mut h1 = Histogram::::new_with_max(u64::max_value(), 3).unwrap(); [INFO] [stdout] 228 + let mut h1 = Histogram::::new_with_max(u64::MAX, 3).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/subtract.rs:229:49 [INFO] [stdout] | [INFO] [stdout] 229 | let mut h2 = Histogram::::new_with_max(u64::max_value(), 5).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 229 - let mut h2 = Histogram::::new_with_max(u64::max_value(), 5).unwrap(); [INFO] [stdout] 229 + let mut h2 = Histogram::::new_with_max(u64::MAX, 5).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/subtract.rs:252:49 [INFO] [stdout] | [INFO] [stdout] 252 | let mut h1 = Histogram::::new_with_max(u64::max_value(), 3).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 252 - let mut h1 = Histogram::::new_with_max(u64::max_value(), 3).unwrap(); [INFO] [stdout] 252 + let mut h1 = Histogram::::new_with_max(u64::MAX, 3).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/subtract.rs:253:49 [INFO] [stdout] | [INFO] [stdout] 253 | let mut h2 = Histogram::::new_with_max(u64::max_value(), 5).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 253 - let mut h2 = Histogram::::new_with_max(u64::max_value(), 5).unwrap(); [INFO] [stdout] 253 + let mut h2 = Histogram::::new_with_max(u64::MAX, 5).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/subtract.rs:276:49 [INFO] [stdout] | [INFO] [stdout] 276 | let mut h1 = Histogram::::new_with_max(u64::max_value(), 3).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 276 - let mut h1 = Histogram::::new_with_max(u64::max_value(), 3).unwrap(); [INFO] [stdout] 276 + let mut h1 = Histogram::::new_with_max(u64::MAX, 3).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/subtract.rs:277:49 [INFO] [stdout] | [INFO] [stdout] 277 | let mut h2 = Histogram::::new_with_max(u64::max_value(), 5).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 277 - let mut h2 = Histogram::::new_with_max(u64::max_value(), 5).unwrap(); [INFO] [stdout] 277 + let mut h2 = Histogram::::new_with_max(u64::MAX, 5).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/subtract.rs:300:49 [INFO] [stdout] | [INFO] [stdout] 300 | let mut h1 = Histogram::::new_with_max(u64::max_value(), 3).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 300 - let mut h1 = Histogram::::new_with_max(u64::max_value(), 3).unwrap(); [INFO] [stdout] 300 + let mut h1 = Histogram::::new_with_max(u64::MAX, 3).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/subtract.rs:301:49 [INFO] [stdout] | [INFO] [stdout] 301 | let mut h2 = Histogram::::new_with_max(u64::max_value(), 5).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 301 - let mut h2 = Histogram::::new_with_max(u64::max_value(), 5).unwrap(); [INFO] [stdout] 301 + let mut h2 = Histogram::::new_with_max(u64::MAX, 5).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/subtract.rs:324:49 [INFO] [stdout] | [INFO] [stdout] 324 | let mut h1 = Histogram::::new_with_max(u64::max_value(), 3).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 324 - let mut h1 = Histogram::::new_with_max(u64::max_value(), 3).unwrap(); [INFO] [stdout] 324 + let mut h1 = Histogram::::new_with_max(u64::MAX, 3).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/subtract.rs:325:49 [INFO] [stdout] | [INFO] [stdout] 325 | let mut h2 = Histogram::::new_with_max(u64::max_value(), 3).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 325 - let mut h2 = Histogram::::new_with_max(u64::max_value(), 3).unwrap(); [INFO] [stdout] 325 + let mut h2 = Histogram::::new_with_max(u64::MAX, 3).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/subtract.rs:327:20 [INFO] [stdout] | [INFO] [stdout] 327 | h1.record_n(1, u64::max_value()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 327 - h1.record_n(1, u64::max_value()).unwrap(); [INFO] [stdout] 327 + h1.record_n(1, u64::MAX).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/subtract.rs:328:21 [INFO] [stdout] | [INFO] [stdout] 328 | h1.record_n(10, u64::max_value()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 328 - h1.record_n(10, u64::max_value()).unwrap(); [INFO] [stdout] 328 + h1.record_n(10, u64::MAX).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/subtract.rs:329:22 [INFO] [stdout] | [INFO] [stdout] 329 | h1.record_n(100, u64::max_value()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 329 - h1.record_n(100, u64::max_value()).unwrap(); [INFO] [stdout] 329 + h1.record_n(100, u64::MAX).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/subtract.rs:330:23 [INFO] [stdout] | [INFO] [stdout] 330 | h1.record_n(1000, u64::max_value()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 330 - h1.record_n(1000, u64::max_value()).unwrap(); [INFO] [stdout] 330 + h1.record_n(1000, u64::MAX).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/subtract.rs:342:16 [INFO] [stdout] | [INFO] [stdout] 342 | assert_eq!(u64::max_value(), h1.len()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 342 - assert_eq!(u64::max_value(), h1.len()); [INFO] [stdout] 342 + assert_eq!(u64::MAX, h1.len()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/subtract.rs:350:49 [INFO] [stdout] | [INFO] [stdout] 350 | let mut h1 = Histogram::::new_with_max(u64::max_value(), 3).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 350 - let mut h1 = Histogram::::new_with_max(u64::max_value(), 3).unwrap(); [INFO] [stdout] 350 + let mut h1 = Histogram::::new_with_max(u64::MAX, 3).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/subtract.rs:351:49 [INFO] [stdout] | [INFO] [stdout] 351 | let mut h2 = Histogram::::new_with_max(u64::max_value(), 3).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 351 - let mut h2 = Histogram::::new_with_max(u64::max_value(), 3).unwrap(); [INFO] [stdout] 351 + let mut h2 = Histogram::::new_with_max(u64::MAX, 3).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/subtract.rs:354:18 [INFO] [stdout] | [INFO] [stdout] 354 | let chunk = (u64::max_value() / 16) * 5; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 354 - let chunk = (u64::max_value() / 16) * 5; [INFO] [stdout] 354 + let chunk = (u64::MAX / 16) * 5; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/subtract.rs:370:16 [INFO] [stdout] | [INFO] [stdout] 370 | assert_eq!(u64::max_value() / 16 * 15, h1.len()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 370 - assert_eq!(u64::max_value() / 16 * 15, h1.len()); [INFO] [stdout] 370 + assert_eq!(u64::MAX / 16 * 15, h1.len()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/value_calculation.rs:61:24 [INFO] [stdout] | [INFO] [stdout] 61 | let h = histo64(1, u64::max_value(), 3); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 61 - let h = histo64(1, u64::max_value(), 3); [INFO] [stdout] 61 + let h = histo64(1, u64::MAX, 3); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/value_calculation.rs:76:44 [INFO] [stdout] | [INFO] [stdout] 76 | assert_eq!(1 << 53, h.equivalent_range(u64::max_value())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 76 - assert_eq!(1 << 53, h.equivalent_range(u64::max_value())); [INFO] [stdout] 76 + assert_eq!(1 << 53, h.equivalent_range(u64::MAX)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/value_calculation.rs:81:24 [INFO] [stdout] | [INFO] [stdout] 81 | let h = histo64(1, u64::max_value(), 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 81 - let h = histo64(1, u64::max_value(), 0); [INFO] [stdout] 81 + let h = histo64(1, u64::MAX, 0); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/value_calculation.rs:92:44 [INFO] [stdout] | [INFO] [stdout] 92 | assert_eq!(1 << 63, h.equivalent_range(u64::max_value())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 92 - assert_eq!(1 << 63, h.equivalent_range(u64::max_value())); [INFO] [stdout] 92 + assert_eq!(1 << 63, h.equivalent_range(u64::MAX)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/value_calculation.rs:97:24 [INFO] [stdout] | [INFO] [stdout] 97 | let h = histo64(1, u64::max_value(), 5); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 97 - let h = histo64(1, u64::max_value(), 5); [INFO] [stdout] 97 + let h = histo64(1, u64::MAX, 5); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/value_calculation.rs:112:44 [INFO] [stdout] | [INFO] [stdout] 112 | assert_eq!(1 << 46, h.equivalent_range(u64::max_value())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 112 - assert_eq!(1 << 46, h.equivalent_range(u64::max_value())); [INFO] [stdout] 112 + assert_eq!(1 << 46, h.equivalent_range(u64::MAX)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/value_calculation.rs:117:24 [INFO] [stdout] | [INFO] [stdout] 117 | let h = histo64(4, u64::max_value(), 3); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 117 - let h = histo64(4, u64::max_value(), 3); [INFO] [stdout] 117 + let h = histo64(4, u64::MAX, 3); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/value_calculation.rs:133:44 [INFO] [stdout] | [INFO] [stdout] 133 | assert_eq!(1 << 53, h.equivalent_range(u64::max_value())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 133 - assert_eq!(1 << 53, h.equivalent_range(u64::max_value())); [INFO] [stdout] 133 + assert_eq!(1 << 53, h.equivalent_range(u64::MAX)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/value_calculation.rs:138:30 [INFO] [stdout] | [INFO] [stdout] 138 | let h = histo64(1 << 50, u64::max_value(), 3); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 138 - let h = histo64(1 << 50, u64::max_value(), 3); [INFO] [stdout] 138 + let h = histo64(1 << 50, u64::MAX, 3); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/value_calculation.rs:153:44 [INFO] [stdout] | [INFO] [stdout] 153 | assert_eq!(1 << 53, h.equivalent_range(u64::max_value())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 153 - assert_eq!(1 << 53, h.equivalent_range(u64::max_value())); [INFO] [stdout] 153 + assert_eq!(1 << 53, h.equivalent_range(u64::MAX)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/value_calculation.rs:197:24 [INFO] [stdout] | [INFO] [stdout] 197 | let h = histo64(1, u64::max_value(), 3); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 197 - let h = histo64(1, u64::max_value(), 3); [INFO] [stdout] 197 + let h = histo64(1, u64::MAX, 3); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/value_calculation.rs:200:9 [INFO] [stdout] | [INFO] [stdout] 200 | u64::max_value() - 1, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 200 - u64::max_value() - 1, [INFO] [stdout] 200 + u64::MAX - 1, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/value_calculation.rs:201:30 [INFO] [stdout] | [INFO] [stdout] 201 | h.highest_equivalent(u64::max_value() - 1) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 201 - h.highest_equivalent(u64::max_value() - 1) [INFO] [stdout] 201 + h.highest_equivalent(u64::MAX - 1) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/value_calculation.rs:204:16 [INFO] [stdout] | [INFO] [stdout] 204 | assert_eq!(u64::max_value(), h.highest_equivalent(u64::max_value())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 204 - assert_eq!(u64::max_value(), h.highest_equivalent(u64::max_value())); [INFO] [stdout] 204 + assert_eq!(u64::MAX, h.highest_equivalent(u64::max_value())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/value_calculation.rs:204:55 [INFO] [stdout] | [INFO] [stdout] 204 | assert_eq!(u64::max_value(), h.highest_equivalent(u64::max_value())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 204 - assert_eq!(u64::max_value(), h.highest_equivalent(u64::max_value())); [INFO] [stdout] 204 + assert_eq!(u64::max_value(), h.highest_equivalent(u64::MAX)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/value_calculation.rs:249:24 [INFO] [stdout] | [INFO] [stdout] 249 | let h = histo64(1, u64::max_value(), 3); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 249 - let h = histo64(1, u64::max_value(), 3); [INFO] [stdout] 249 + let h = histo64(1, u64::MAX, 3); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/value_calculation.rs:252:48 [INFO] [stdout] | [INFO] [stdout] 252 | assert_eq!(1_u64 << 53, h.equivalent_range(u64::max_value())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 252 - assert_eq!(1_u64 << 53, h.equivalent_range(u64::max_value())); [INFO] [stdout] 252 + assert_eq!(1_u64 << 53, h.equivalent_range(u64::MAX)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/value_calculation.rs:256:9 [INFO] [stdout] | [INFO] [stdout] 256 | u64::max_value(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 256 - u64::max_value(), [INFO] [stdout] 256 + u64::MAX, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/value_calculation.rs:257:31 [INFO] [stdout] | [INFO] [stdout] 257 | h.next_non_equivalent(u64::max_value() - 1) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 257 - h.next_non_equivalent(u64::max_value() - 1) [INFO] [stdout] 257 + h.next_non_equivalent(u64::MAX - 1) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/value_calculation.rs:259:16 [INFO] [stdout] | [INFO] [stdout] 259 | assert_eq!(u64::max_value(), h.next_non_equivalent(u64::max_value())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 259 - assert_eq!(u64::max_value(), h.next_non_equivalent(u64::max_value())); [INFO] [stdout] 259 + assert_eq!(u64::MAX, h.next_non_equivalent(u64::max_value())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/value_calculation.rs:259:56 [INFO] [stdout] | [INFO] [stdout] 259 | assert_eq!(u64::max_value(), h.next_non_equivalent(u64::max_value())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 259 - assert_eq!(u64::max_value(), h.next_non_equivalent(u64::max_value())); [INFO] [stdout] 259 + assert_eq!(u64::max_value(), h.next_non_equivalent(u64::MAX)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/value_calculation.rs:363:28 [INFO] [stdout] | [INFO] [stdout] 363 | let mut h = histo64(1, u64::max_value(), 3); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 363 - let mut h = histo64(1, u64::max_value(), 3); [INFO] [stdout] 363 + let mut h = histo64(1, u64::MAX, 3); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/value_calculation.rs:431:15 [INFO] [stdout] | [INFO] [stdout] 431 | let max = u64::max_value(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 431 - let max = u64::max_value(); [INFO] [stdout] 431 + let max = u64::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/tests/tests.rs:23:16 [INFO] [stdout] | [INFO] [stdout] 23 | assert_eq!(u64::max_value(), super::ORIGINAL_MIN); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 23 - assert_eq!(u64::max_value(), super::ORIGINAL_MIN); [INFO] [stdout] 23 + assert_eq!(u64::MAX, super::ORIGINAL_MIN); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/serialization/rand_varint.rs:10:13 [INFO] [stdout] | [INFO] [stdout] 10 | assert!(byte_length <= 9 && byte_length >= 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(1..=9).contains(&byte_length)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/serialization/rand_varint.rs:21:13 [INFO] [stdout] | [INFO] [stdout] 21 | assert!(byte_length <= 9 && byte_length >= 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(1..=9).contains(&byte_length)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/serialization/rand_varint.rs:24:14 [INFO] [stdout] | [INFO] [stdout] 24 | 9 => u64::max_value(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 24 - 9 => u64::max_value(), [INFO] [stdout] 24 + 9 => u64::MAX, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/serialization/tests.rs:87:16 [INFO] [stdout] | [INFO] [stdout] 87 | assert_eq!(u64::max_value(), deser.min_non_zero_value); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 87 - assert_eq!(u64::max_value(), deser.min_non_zero_value); [INFO] [stdout] 87 + assert_eq!(u64::MAX, deser.min_non_zero_value); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/serialization/tests.rs:143:56 [INFO] [stdout] | [INFO] [stdout] 143 | do_serialize_roundtrip_random(V2Serializer::new(), i64::max_value() as u64); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 143 - do_serialize_roundtrip_random(V2Serializer::new(), i64::max_value() as u64); [INFO] [stdout] 143 + do_serialize_roundtrip_random(V2Serializer::new(), i64::MAX as u64); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/serialization/tests.rs:148:56 [INFO] [stdout] | [INFO] [stdout] 148 | do_serialize_roundtrip_random(V2Serializer::new(), u32::max_value()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 148 - do_serialize_roundtrip_random(V2Serializer::new(), u32::max_value()); [INFO] [stdout] 148 + do_serialize_roundtrip_random(V2Serializer::new(), u32::MAX); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/serialization/tests.rs:153:56 [INFO] [stdout] | [INFO] [stdout] 153 | do_serialize_roundtrip_random(V2Serializer::new(), u16::max_value()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 153 - do_serialize_roundtrip_random(V2Serializer::new(), u16::max_value()); [INFO] [stdout] 153 + do_serialize_roundtrip_random(V2Serializer::new(), u16::MAX); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/serialization/tests.rs:158:56 [INFO] [stdout] | [INFO] [stdout] 158 | do_serialize_roundtrip_random(V2Serializer::new(), u8::max_value()); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 158 - do_serialize_roundtrip_random(V2Serializer::new(), u8::max_value()); [INFO] [stdout] 158 + do_serialize_roundtrip_random(V2Serializer::new(), u8::MAX); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/serialization/tests.rs:163:63 [INFO] [stdout] | [INFO] [stdout] 163 | do_serialize_roundtrip_random(V2DeflateSerializer::new(), i64::max_value() as u64); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 163 - do_serialize_roundtrip_random(V2DeflateSerializer::new(), i64::max_value() as u64); [INFO] [stdout] 163 + do_serialize_roundtrip_random(V2DeflateSerializer::new(), i64::MAX as u64); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/serialization/tests.rs:168:63 [INFO] [stdout] | [INFO] [stdout] 168 | do_serialize_roundtrip_random(V2DeflateSerializer::new(), u32::max_value()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 168 - do_serialize_roundtrip_random(V2DeflateSerializer::new(), u32::max_value()); [INFO] [stdout] 168 + do_serialize_roundtrip_random(V2DeflateSerializer::new(), u32::MAX); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/serialization/tests.rs:173:63 [INFO] [stdout] | [INFO] [stdout] 173 | do_serialize_roundtrip_random(V2DeflateSerializer::new(), u16::max_value()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 173 - do_serialize_roundtrip_random(V2DeflateSerializer::new(), u16::max_value()); [INFO] [stdout] 173 + do_serialize_roundtrip_random(V2DeflateSerializer::new(), u16::MAX); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/serialization/tests.rs:178:63 [INFO] [stdout] | [INFO] [stdout] 178 | do_serialize_roundtrip_random(V2DeflateSerializer::new(), u8::max_value()); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 178 - do_serialize_roundtrip_random(V2DeflateSerializer::new(), u8::max_value()); [INFO] [stdout] 178 + do_serialize_roundtrip_random(V2DeflateSerializer::new(), u8::MAX); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/serialization/tests.rs:183:24 [INFO] [stdout] | [INFO] [stdout] 183 | let h = histo64(1, u64::max_value(), 3); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 183 - let h = histo64(1, u64::max_value(), 3); [INFO] [stdout] 183 + let h = histo64(1, u64::MAX, 3); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/serialization/tests.rs:280:19 [INFO] [stdout] | [INFO] [stdout] 280 | h.record_n(0, i64::max_value() as u64 + 1).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 280 - h.record_n(0, i64::max_value() as u64 + 1).unwrap(); [INFO] [stdout] 280 + h.record_n(0, i64::MAX as u64 + 1).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/serialization/tests.rs:315:31 [INFO] [stdout] | [INFO] [stdout] 315 | let length = varint_write(u64::max_value(), &mut buf[..]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 315 - let length = varint_write(u64::max_value(), &mut buf[..]); [INFO] [stdout] 315 + let length = varint_write(u64::MAX, &mut buf[..]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/serialization/tests.rs:323:16 [INFO] [stdout] | [INFO] [stdout] 323 | assert_eq!(u64::max_value(), varint_read(input).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 323 - assert_eq!(u64::max_value(), varint_read(input).unwrap()); [INFO] [stdout] 323 + assert_eq!(u64::MAX, varint_read(input).unwrap()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/serialization/tests.rs:454:16 [INFO] [stdout] | [INFO] [stdout] 454 | assert_eq!(u64::max_value() - 1, zig_zag_encode(i64::max_value())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 454 - assert_eq!(u64::max_value() - 1, zig_zag_encode(i64::max_value())); [INFO] [stdout] 454 + assert_eq!(u64::MAX - 1, zig_zag_encode(i64::max_value())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/serialization/tests.rs:454:53 [INFO] [stdout] | [INFO] [stdout] 454 | assert_eq!(u64::max_value() - 1, zig_zag_encode(i64::max_value())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 454 - assert_eq!(u64::max_value() - 1, zig_zag_encode(i64::max_value())); [INFO] [stdout] 454 + assert_eq!(u64::max_value() - 1, zig_zag_encode(i64::MAX)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/serialization/tests.rs:459:16 [INFO] [stdout] | [INFO] [stdout] 459 | assert_eq!(u64::max_value(), zig_zag_encode(i64::min_value())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 459 - assert_eq!(u64::max_value(), zig_zag_encode(i64::min_value())); [INFO] [stdout] 459 + assert_eq!(u64::MAX, zig_zag_encode(i64::min_value())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/serialization/tests.rs:459:49 [INFO] [stdout] | [INFO] [stdout] 459 | assert_eq!(u64::max_value(), zig_zag_encode(i64::min_value())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 459 - assert_eq!(u64::max_value(), zig_zag_encode(i64::min_value())); [INFO] [stdout] 459 + assert_eq!(u64::max_value(), zig_zag_encode(i64::MIN)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/serialization/tests.rs:464:16 [INFO] [stdout] | [INFO] [stdout] 464 | assert_eq!(i64::min_value(), zig_zag_decode(u64::max_value())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 464 - assert_eq!(i64::min_value(), zig_zag_decode(u64::max_value())) [INFO] [stdout] 464 + assert_eq!(i64::MIN, zig_zag_decode(u64::max_value())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/serialization/tests.rs:464:49 [INFO] [stdout] | [INFO] [stdout] 464 | assert_eq!(i64::min_value(), zig_zag_decode(u64::max_value())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 464 - assert_eq!(i64::min_value(), zig_zag_decode(u64::max_value())) [INFO] [stdout] 464 + assert_eq!(i64::min_value(), zig_zag_decode(u64::MAX)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/serialization/tests.rs:469:16 [INFO] [stdout] | [INFO] [stdout] 469 | assert_eq!(i64::max_value(), zig_zag_decode(u64::max_value() - 1)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 469 - assert_eq!(i64::max_value(), zig_zag_decode(u64::max_value() - 1)) [INFO] [stdout] 469 + assert_eq!(i64::MAX, zig_zag_decode(u64::max_value() - 1)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/serialization/tests.rs:469:49 [INFO] [stdout] | [INFO] [stdout] 469 | assert_eq!(i64::max_value(), zig_zag_decode(u64::max_value() - 1)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 469 - assert_eq!(i64::max_value(), zig_zag_decode(u64::max_value() - 1)) [INFO] [stdout] 469 + assert_eq!(i64::max_value(), zig_zag_decode(u64::MAX - 1)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/serialization/tests.rs:486:13 [INFO] [stdout] | [INFO] [stdout] 486 | assert!(byte_length <= 9 && byte_length >= 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(1..=9).contains(&byte_length)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually filling a slice [INFO] [stdout] --> src/serialization/tests.rs:499:9 [INFO] [stdout] | [INFO] [stdout] 499 | / for i in 0..(buf.len()) { [INFO] [stdout] 500 | | buf[i] = 0; [INFO] [stdout] 501 | | } [INFO] [stdout] | |_________^ help: try: `buf.fill(0);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_slice_fill [INFO] [stdout] = note: `#[warn(clippy::manual_slice_fill)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `buf` [INFO] [stdout] --> src/serialization/tests.rs:499:18 [INFO] [stdout] | [INFO] [stdout] 499 | for i in 0..(buf.len()) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 499 - for i in 0..(buf.len()) { [INFO] [stdout] 499 + for in &mut buf { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/serialization/tests.rs:512:13 [INFO] [stdout] | [INFO] [stdout] 512 | assert!(byte_length <= 9 && byte_length >= 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(1..=9).contains(&byte_length)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually filling a slice [INFO] [stdout] --> src/serialization/tests.rs:526:9 [INFO] [stdout] | [INFO] [stdout] 526 | / for i in 0..(buf.len()) { [INFO] [stdout] 527 | | buf[i] = 0; [INFO] [stdout] 528 | | } [INFO] [stdout] | |_________^ help: try: `buf.fill(0);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_slice_fill [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `buf` [INFO] [stdout] --> src/serialization/tests.rs:526:18 [INFO] [stdout] | [INFO] [stdout] 526 | for i in 0..(buf.len()) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 526 - for i in 0..(buf.len()) { [INFO] [stdout] 526 + for in &mut buf { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `varint_read_slice` doesn't need a mutable reference [INFO] [stdout] --> src/serialization/tests.rs:533:31 [INFO] [stdout] | [INFO] [stdout] 533 | varint_read_slice(&mut &buf[..bytes_written]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 533 - varint_read_slice(&mut &buf[..bytes_written]) [INFO] [stdout] 533 + varint_read_slice(&&buf[..bytes_written]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/serialization/tests.rs:533:31 [INFO] [stdout] | [INFO] [stdout] 533 | varint_read_slice(&mut &buf[..bytes_written]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&buf[..bytes_written]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/serialization/tests.rs:554:56 [INFO] [stdout] | [INFO] [stdout] 554 | let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 554 - let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] 554 + let mut h = Histogram::::new_with_bounds(1, u64::MAX, 3).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/serialization/deserializer.rs:168:27 [INFO] [stdout] | [INFO] [stdout] 168 | reader.read_exact(&mut payload_slice)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `payload_slice` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/serialization/interval_log/mod.rs:94:5 [INFO] [stdout] | [INFO] [stdout] 94 | //! since the epoch. The first interval's timestamp is stored to the StartTime field. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 94 | //! since the epoch. The first interval's timestamp is stored to the StartTime field. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/serialization/interval_log/mod.rs:96:5 [INFO] [stdout] | [INFO] [stdout] 96 | //! may be interpreted as deltas to be added to StartTime or as "absolute" Unix time depending on a [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 96 | //! may be interpreted as deltas to be added to StartTime or as "absolute" Unix time depending on a [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/serialization/interval_log/mod.rs:97:5 [INFO] [stdout] | [INFO] [stdout] 97 | //! heuristic. In other words, the heuristic chooses between setting the effective BaseTime to 0 or [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 97 | //! heuristic. In other words, the heuristic chooses between setting the effective BaseTime to 0 or [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/serialization/interval_log/mod.rs:98:5 [INFO] [stdout] | [INFO] [stdout] 98 | //! to StartTime. Specifically, the heuristic interprets interval timestamps as deltas if they are [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 98 | //! to StartTime. Specifically, the heuristic interprets interval timestamps as deltas if they are [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/serialization/interval_log/mod.rs:99:5 [INFO] [stdout] | [INFO] [stdout] 99 | //! more than a year's worth of seconds smaller than StartTime and as absolute timestamps otherwise. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 99 | //! more than a year's worth of seconds smaller than StartTime and as absolute timestamps otherwise. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/serialization/interval_log/mod.rs:101:5 [INFO] [stdout] | [INFO] [stdout] 101 | //! interpreted as deltas. The first interval's (delta) timestamp is stored to the StartTime field. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 101 | //! interpreted as deltas. The first interval's (delta) timestamp is stored to the StartTime field. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/serialization/interval_log/mod.rs:102:5 [INFO] [stdout] | [INFO] [stdout] 102 | //! This is likely a bug, since StartTime should be an absolute timestamp, and appears to cause [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 102 | //! This is likely a bug, since StartTime should be an absolute timestamp, and appears to cause [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/serialization/interval_log/mod.rs:103:5 [INFO] [stdout] | [INFO] [stdout] 103 | //! erroneous behavior when filtering by offset timestamps. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 103 | //! erroneous behavior when filtering by offset timestamps. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/serialization/interval_log/mod.rs:105:5 [INFO] [stdout] | [INFO] [stdout] 105 | //! present: it's a number of seconds since epoch that serves as the starting point for the [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 105 | //! present: it's a number of seconds since epoch that serves as the starting point for the [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/serialization/interval_log/mod.rs:106:5 [INFO] [stdout] | [INFO] [stdout] 106 | //! per-interval deltas to get a wall-clock time for each interval. No heuristics are applied to [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 106 | //! per-interval deltas to get a wall-clock time for each interval. No heuristics are applied to [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/serialization/interval_log/mod.rs:107:5 [INFO] [stdout] | [INFO] [stdout] 107 | //! guess whether or not the intervals are absolute or deltas. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 107 | //! guess whether or not the intervals are absolute or deltas. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/serialization/interval_log/mod.rs:319:43 [INFO] [stdout] | [INFO] [stdout] 319 | internal_writer.write_comment(&c)?; [INFO] [stdout] | ^^ help: change this to: `c` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this multiplication by -1 can be written more succinctly [INFO] [stdout] --> src/serialization/interval_log/mod.rs:705:19 [INFO] [stdout] | [INFO] [stdout] 705 | Err(t) => duration_as_fp_seconds(t.duration()) * -1_f64, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `-duration_as_fp_seconds(t.duration())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stdout] = note: `#[warn(clippy::neg_multiply)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/serialization/interval_log/tests.rs:136:54 [INFO] [stdout] | [INFO] [stdout] 136 | let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 136 - let mut h = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] 136 + let mut h = Histogram::::new_with_bounds(1, u64::MAX, 3).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/serialization/interval_log/tests.rs:167:50 [INFO] [stdout] | [INFO] [stdout] 167 | let h = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 167 - let h = Histogram::::new_with_bounds(1, u64::max_value(), 3).unwrap(); [INFO] [stdout] 167 + let h = Histogram::::new_with_bounds(1, u64::MAX, 3).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/lib.rs:1045:9 [INFO] [stdout] | [INFO] [stdout] 1045 | &self, [INFO] [stdout] | ^^^^^ the lifetime is elided here [INFO] [stdout] 1046 | ticks_per_half_distance: u32, [INFO] [stdout] 1047 | ) -> HistogramIterator> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | the same lifetime is hidden here [INFO] [stdout] | the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 1047 | ) -> HistogramIterator<'_, T, iterators::quantile::Iter<'_, T>> { [INFO] [stdout] | +++ +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/lib.rs:1107:24 [INFO] [stdout] | [INFO] [stdout] 1107 | pub fn iter_linear(&self, step: u64) -> HistogramIterator> { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | | [INFO] [stdout] | | | the same lifetime is hidden here [INFO] [stdout] | | the same lifetime is hidden here [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 1107 | pub fn iter_linear(&self, step: u64) -> HistogramIterator<'_, T, iterators::linear::Iter<'_, T>> { [INFO] [stdout] | +++ +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/lib.rs:1145:21 [INFO] [stdout] | [INFO] [stdout] 1145 | pub fn iter_log(&self, start: u64, exp: f64) -> HistogramIterator> { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | | [INFO] [stdout] | | | the same lifetime is hidden here [INFO] [stdout] | | the same lifetime is hidden here [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 1145 | pub fn iter_log(&self, start: u64, exp: f64) -> HistogramIterator<'_, T, iterators::log::Iter<'_, T>> { [INFO] [stdout] | +++ +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/lib.rs:1183:26 [INFO] [stdout] | [INFO] [stdout] 1183 | pub fn iter_recorded(&self) -> HistogramIterator { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 1183 | pub fn iter_recorded(&self) -> HistogramIterator<'_, T, iterators::recorded::Iter> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/lib.rs:1242:21 [INFO] [stdout] | [INFO] [stdout] 1242 | pub fn iter_all(&self) -> HistogramIterator { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 1242 | pub fn iter_all(&self) -> HistogramIterator<'_, T, iterators::all::Iter> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/iterators/recorded.rs:12:34 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn new(hist: &Histogram) -> HistogramIterator { [INFO] [stdout] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 12 | pub fn new(hist: &Histogram) -> HistogramIterator<'_, T, Iter> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/iterators/all.rs:12:34 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn new(hist: &Histogram) -> HistogramIterator { [INFO] [stdout] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 12 | pub fn new(hist: &Histogram) -> HistogramIterator<'_, T, Iter> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/serialization/interval_log/mod.rs:709:22 [INFO] [stdout] | [INFO] [stdout] 709 | fn start_time(input: &[u8]) -> IResult<&[u8], LogEntry> { [INFO] [stdout] | ^^^^^ ^^^^^ ^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | | [INFO] [stdout] | | the same lifetime is elided here [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 709 | fn start_time(input: &[u8]) -> IResult<&[u8], LogEntry<'_>> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/serialization/interval_log/mod.rs:718:21 [INFO] [stdout] | [INFO] [stdout] 718 | fn base_time(input: &[u8]) -> IResult<&[u8], LogEntry> { [INFO] [stdout] | ^^^^^ ^^^^^ ^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | | [INFO] [stdout] | | the same lifetime is elided here [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 718 | fn base_time(input: &[u8]) -> IResult<&[u8], LogEntry<'_>> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/serialization/interval_log/mod.rs:734:22 [INFO] [stdout] | [INFO] [stdout] 734 | fn tag_parser(input: &[u8]) -> IResult<&[u8], Tag> { [INFO] [stdout] | ^^^^^ ^^^^^ ^^^ the same lifetime is hidden here [INFO] [stdout] | | | [INFO] [stdout] | | the same lifetime is elided here [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 734 | fn tag_parser(input: &[u8]) -> IResult<&[u8], Tag<'_>> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/serialization/interval_log/mod.rs:739:25 [INFO] [stdout] | [INFO] [stdout] 739 | fn interval_hist(input: &[u8]) -> IResult<&[u8], LogEntry> { [INFO] [stdout] | ^^^^^ ^^^^^ ^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | | [INFO] [stdout] | | the same lifetime is elided here [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 739 | fn interval_hist(input: &[u8]) -> IResult<&[u8], LogEntry<'_>> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/serialization/interval_log/mod.rs:811:27 [INFO] [stdout] | [INFO] [stdout] 811 | fn fract_sec_tuple(input: &[u8]) -> FResult { [INFO] [stdout] | ^^^^^ ^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 811 | fn fract_sec_tuple(input: &[u8]) -> FResult<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/sync/mod.rs:211:17 [INFO] [stdout] | [INFO] [stdout] 211 | pub fn idle(&mut self) -> IdleRecorderGuard { [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 211 | pub fn idle(&mut self) -> IdleRecorderGuard<'_, C> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 4m 50s [INFO] running `Command { std: "docker" "inspect" "12443a42629452484fc5ec612905dffa6bc4e23401e7935cea2d7b44e871a603", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "12443a42629452484fc5ec612905dffa6bc4e23401e7935cea2d7b44e871a603", kill_on_drop: false }` [INFO] [stdout] 12443a42629452484fc5ec612905dffa6bc4e23401e7935cea2d7b44e871a603